Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21795#discussion_r203138528
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala
---
@@ -2336,46 +2336,40 @@ class DataFrameSuite extends QueryTest with
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/21792
My only question here is whether it's worth duplicating this documentation
from the Python and R docs. It's more detailed info for callers of the API, and
might just belong in the API doc.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21797
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21797
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21795
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93178/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21795
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21795
**[Test build #93178 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93178/testReport)**
for PR 21795 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21729
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93176/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21729
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21582
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21582
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21582
**[Test build #93193 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93193/testReport)**
for PR 21582 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21797
**[Test build #93192 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93192/testReport)**
for PR 21797 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21729
**[Test build #93176 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93176/testReport)**
for PR 21729 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21582
**[Test build #93191 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93191/testReport)**
for PR 21582 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21582
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21710
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21710
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93184/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21710
**[Test build #93184 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93184/testReport)**
for PR 21710 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21488
**[Test build #93188 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93188/testReport)**
for PR 21488 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21488
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93188/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21488
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21582
@dongjoon-hyun Could you submit a PR to use the latest
Decimal64ColumnVector like what Hive does
https://issues.apache.org/jira/browse/HIVE-19629 ?
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21488
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21488
**[Test build #93190 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93190/testReport)**
for PR 21488 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21488
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user shaneknapp commented on the issue:
https://github.com/apache/spark/pull/21652
running `mvn install -DskipTests=true` on the workers. again. this will
not scale.
---
-
To unsubscribe, e-mail:
Github user tedyu commented on the issue:
https://github.com/apache/spark/pull/21488
Not sure what to do with the following build error which is not caused by
the PR:
```
[ERROR]
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21719
**[Test build #93189 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93189/testReport)**
for PR 21719 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21719
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21719
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user MrBago commented on a diff in the pull request:
https://github.com/apache/spark/pull/21719#discussion_r203126526
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/util/Instrumentation.scala ---
@@ -19,45 +19,60 @@ package org.apache.spark.ml.util
import
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21488
**[Test build #93188 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93188/testReport)**
for PR 21488 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21488
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21488
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user Achuth17 commented on the issue:
https://github.com/apache/spark/pull/18193
This fix is useful, is there any update on this?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19194
**[Test build #93187 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93187/testReport)**
for PR 19194 at commit
Github user edwinalu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21221#discussion_r203122722
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/SparkListener.scala ---
@@ -160,11 +160,29 @@ case class
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19194
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19194
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21797
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21797
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21797
**[Test build #93186 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93186/testReport)**
for PR 21797 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21589
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93174/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21589
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21589
**[Test build #93174 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93174/testReport)**
for PR 21589 at commit
Github user dbtsai commented on the issue:
https://github.com/apache/spark/pull/21442
I opened a new PR at https://github.com/apache/spark/pull/21797/files Will
work on the test issue there. Thanks.
---
-
To
GitHub user dbtsai opened a pull request:
https://github.com/apache/spark/pull/21797
[SPARK-24402] [SQL] Optimize `In` expression when only one element in the
collection or collection is empty
## What changes were proposed in this pull request?
Two new rules in the logical
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21352
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93175/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21352
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21352
**[Test build #93175 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93175/testReport)**
for PR 21352 at commit
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/21488#discussion_r203109788
--- Diff:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaOffsetReader.scala
---
@@ -115,7 +116,7 @@ private[kafka010] class
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/21582
@gatorsmile . We don't use the new feature here (in Spark) yet. This is a
BUILD PR. The result comes from official ORC DecimalBench code in ORC-386
(which I mentioned.) We can get the benefit
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/21488
@tedyu We don't need to block on the release. I would expect the Kafka
client is backward complicity. In addition, most of Spark users will not
upgrade their Kafka at once after the new version
Github user tedyu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21488#discussion_r203106522
--- Diff:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaOffsetReader.scala
---
@@ -115,7 +116,7 @@ private[kafka010] class
Github user squito commented on the issue:
https://github.com/apache/spark/pull/21131
The DAGSCheudler is notified about successfully completed tasks, whether or
not the `tsm.successful` is already true:
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/21652#discussion_r203105805
--- Diff:
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/KubernetesSuite.scala
---
@@ -29,25
Github user tedyu commented on the issue:
https://github.com/apache/spark/pull/21488
@ijuma
Sorry for the late response. 9 days ago I was in China where access to
gmail is intermittent.
---
-
To unsubscribe,
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21785
@wangyum my environment is
```
$ java -version
openjdk version "1.8.0_171"
OpenJDK Runtime Environment (build 1.8.0_171-8u171-b11-0ubuntu0.16.04.1-b11)
OpenJDK 64-Bit Server VM
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/21652#discussion_r203105117
--- Diff:
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/PythonTestsSuite.scala
---
@@ -0,0
Github user tedyu commented on the issue:
https://github.com/apache/spark/pull/21488
w.r.t. stable Kafka release, it seems 2.0.0 RC2 would pass:
http://search-hadoop.com/m/Kafka/uyzND1ClBEezundG1?subj=Re+VOTE+2+0+0+RC2
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21652
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93183/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21652
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21652
**[Test build #93183 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93183/testReport)**
for PR 21652 at commit
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/21488#discussion_r203104176
--- Diff:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaOffsetReader.scala
---
@@ -115,7 +116,7 @@ private[kafka010] class
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21639
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21639
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21639
**[Test build #93185 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93185/testReport)**
for PR 21639 at commit
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/21488#discussion_r203103522
--- Diff: external/kafka-0-10-sql/pom.xml ---
@@ -74,6 +74,11 @@
${kafka.version}
test
+
+
Github user squito commented on the issue:
https://github.com/apache/spark/pull/21639
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/21488
@tedyu could you please just bump to 1.1.0, the current official latest
release from Apache Kafka?
---
-
To unsubscribe,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21710
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21652
Kubernetes integration test status failure
URL:
https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/1058/
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21652
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user squito commented on the issue:
https://github.com/apache/spark/pull/21656
lgtm
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21652
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21710
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21652
Kubernetes integration test starting
URL:
https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/1058/
---
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/21765
Yup it will always apply your PR to master anyway, so would have picked it
up in this test run.
---
-
To unsubscribe, e-mail:
Github user NiharS commented on the issue:
https://github.com/apache/spark/pull/21765
Rebased onto SPARK-24813 so hopefully tests will work now
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21652#discussion_r203101189
--- Diff:
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/KubernetesSuite.scala
---
@@ -29,25
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/21221#discussion_r203100978
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/SparkListener.scala ---
@@ -160,11 +160,29 @@ case class
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21710
**[Test build #93184 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93184/testReport)**
for PR 21710 at commit
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21652#discussion_r203099369
--- Diff:
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/PythonTestsSuite.scala
---
@@ -0,0
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21652
**[Test build #93183 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93183/testReport)**
for PR 21652 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21758
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/21652
@srowen pls review and merge. I updated the description with my local run
and rebased.
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21758
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93180/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21758
**[Test build #93180 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93180/testReport)**
for PR 21758 at commit
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/21440#discussion_r203097734
--- Diff:
core/src/main/scala/org/apache/spark/util/io/ChunkedByteBuffer.scala ---
@@ -166,6 +170,34 @@ private[spark] class ChunkedByteBuffer(var chunks:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21720
**[Test build #93182 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93182/testReport)**
for PR 21720 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21720
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21720
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user maryannxue commented on the issue:
https://github.com/apache/spark/pull/21720
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21217
**[Test build #93181 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93181/testReport)**
for PR 21217 at commit
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/21794
BTW if it becomes necessary to not change the semantics, I think the
methods could at least be streamlined a bit:
```
if (x < y) {
-1
} else if (x > y) {
1
} else if
Github user jamesthomp commented on the issue:
https://github.com/apache/spark/pull/21217
@HyukjinKwon - I have resolved the conflict with the docs changes. Please
let me know if any additional changes are required.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21758
**[Test build #93180 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93180/testReport)**
for PR 21758 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21758
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21758
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
301 - 400 of 650 matches
Mail list logo
