Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22078
**[Test build #94924 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94924/testReport)**
for PR 22078 at commit
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21931
LGTM, cc @cloud-fan @hvanhovell
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21931#discussion_r211089695
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -1437,6 +1437,16 @@ object SQLConf {
.intConf
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21931#discussion_r211089716
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/AggregateBenchmark.scala
---
@@ -366,6 +366,43 @@ class AggregateBenchmark
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21931
Minor comments. LGTM.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21931#discussion_r211089705
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/AggregateBenchmark.scala
---
@@ -366,6 +366,43 @@ class AggregateBenchmark
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22078
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94924/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22078
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user dmateusp commented on the issue:
https://github.com/apache/spark/pull/22141
I reproduced the issue with the following code (was a bit surprised with
the behavior)
The tables:
```scala
scala> spark.sql("SELECT * FROM users").show
+---+---+
|
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22141
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94930/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22141
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user igreenfield commented on a diff in the pull request:
https://github.com/apache/spark/pull/22135#discussion_r211091975
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeFormatter.scala
---
@@ -91,10 +94,7 @@ object
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21899
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22141
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22141
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22141
**[Test build #94932 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94932/testReport)**
for PR 22141 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22078
**[Test build #94925 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94925/testReport)**
for PR 22078 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22078
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94925/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22112
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22112
**[Test build #94923 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94923/testReport)**
for PR 22112 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22112
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94923/
Test FAILed.
---
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/22131
Thanks! I'd use this one. merging to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22141
**[Test build #94930 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94930/testReport)**
for PR 22141 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20838
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94927/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20838
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user witten commented on the issue:
https://github.com/apache/spark/pull/21669
I see that this branch currently has merge conflicts, but any idea on when
this might land? This is the last feature we're waiting for in order to switch
from the abandoned [apache-spark-on-k8s
Github user xuanyuanking commented on the issue:
https://github.com/apache/spark/pull/22140
cc @HyukjinKwon
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21859
**[Test build #94931 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94931/testReport)**
for PR 21859 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21859
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94931/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21859
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22078
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22141
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22141
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22141
**[Test build #94930 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94930/testReport)**
for PR 22141 at commit
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22131
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user cclauss commented on the issue:
https://github.com/apache/spark/pull/20838
This is not working at all... I am wasting way too much time. 5+ months
and 80+ comments for 12 lines of code is
I do not have the skills to solve the following undefined name 'long' in
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21859
**[Test build #94931 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94931/testReport)**
for PR 21859 at commit
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21859
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21931#discussion_r211089742
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/AggregateBenchmark.scala
---
@@ -366,6 +366,43 @@ class AggregateBenchmark
GitHub user dilipbiswal opened a pull request:
https://github.com/apache/spark/pull/22141
[SPARK-25154] Support NOT IN sub-queries inside nested OR conditions.
## What changes were proposed in this pull request?
Currently NOT IN subqueries (predicated null aware subquery) are
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20838
**[Test build #94927 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94927/testReport)**
for PR 20838 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22135
**[Test build #94926 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94926/testReport)**
for PR 22135 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22135
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22135
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94926/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21899
**[Test build #94929 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94929/testReport)**
for PR 21899 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21899
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94929/
Test PASSed.
---
GitHub user xuanyuanking opened a pull request:
https://github.com/apache/spark/pull/22140
[SPARK-25072][PySpark] Forbid extra value for custom Row
## What changes were proposed in this pull request?
Add value length check in `_create_row`, forbid extra value for custom Row
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22140
**[Test build #94920 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94920/testReport)**
for PR 22140 at commit
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/22131
I preferred the previous one (but yes, definitely good to add the check
about the args size), but I am fine with this one too. Thanks @ueshin
---
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22130
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22137
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22132
Merged to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22140
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22140
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22140
**[Test build #94920 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94920/testReport)**
for PR 22140 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22140
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94920/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22140
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22098
Let me just push this in.
Merged to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22132
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/22124
The root project should be consistent with the schema of the target table.
But now it is inconsistent.
**Before this PR**:
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21819
Merged to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22124
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22124
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22131
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94919/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22131
**[Test build #94919 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94919/testReport)**
for PR 22131 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22131
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22137
Merged to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22130
Merged to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20838
Shell we fix it here?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/21819
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22098
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user heary-cao commented on the issue:
https://github.com/apache/spark/pull/21860
cc @cloud-fan @maropu
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22124
**[Test build #94921 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94921/testReport)**
for PR 22124 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21909
**[Test build #94922 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94922/testReport)**
for PR 21909 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22124
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94921/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22124
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22078
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22078
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22078
**[Test build #94924 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94924/testReport)**
for PR 22078 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22112
I've removed the concept of "order sensitive partitioner" and came up with
a better abstraction. Please take a look at the updated PR descrption, thanks!
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22078
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22078
**[Test build #94925 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94925/testReport)**
for PR 22078 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22078
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22124
> But it is inconsistent now.
Can you point out in the codebase where the inconsistency comes from?
---
-
To
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/22124
Comes from: [[SPARK-22834][SQL] Make insertion commands have real children
to fix UI issues](https://github.com/apache/spark/pull/20020).
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22135
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22135
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22135
**[Test build #94926 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94926/testReport)**
for PR 22135 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20838
**[Test build #94927 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94927/testReport)**
for PR 20838 at commit
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21860
cc @hvanhovell
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21087#discussion_r211080067
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala
---
@@ -164,9 +165,12 @@ case class BucketSpec(
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22123
cc @MaxGekk
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22124
**[Test build #94921 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94921/testReport)**
for PR 22124 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22112
**[Test build #94923 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94923/testReport)**
for PR 22112 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22112
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22112
@tgravescs The `FileCommitProtocol` is an internal API, and our current
implementation does store task-level data temporary in a staging directory (See
`HadoopMapReduceCommitProtocol`). That
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22112
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/22135
thanks for the comment @kiszk , I am doing it!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user tgravescs commented on the issue:
https://github.com/apache/spark/pull/22112
I can't envision how that would work? You can't change how output
committers work. You would have to not store anything until all pass or store
it temporarily, both in my opinion are not good.
Github user MaxGekk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21909#discussion_r211075385
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JsonDataSource.scala
---
@@ -223,7 +224,8 @@ object
1 - 100 of 117 matches
Mail list logo
