[GitHub] spark issue #22851: [SPARK-25797][SQL][DOCS][BACKPORT-2.3] Add migration doc...

2018-10-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22851 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22771: [SPARK-25773][Core]Cancel zombie tasks in a result stage...

2018-10-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22771 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22771: [SPARK-25773][Core]Cancel zombie tasks in a result stage...

2018-10-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22771 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98083/ Test PASSed. ---

[GitHub] spark issue #22830: [SPARK-25838][ML] Remove formatVersion from Saveable

2018-10-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22830 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22830: [SPARK-25838][ML] Remove formatVersion from Saveable

2018-10-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22830 **[Test build #98088 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98088/testReport)** for PR 22830 at commit

[GitHub] spark issue #22830: [SPARK-25838][ML] Remove formatVersion from Saveable

2018-10-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22830 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22029: [SPARK-24395][SQL] IN operator should return NULL when c...

2018-10-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22029 **[Test build #98089 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98089/testReport)** for PR 22029 at commit

[GitHub] spark pull request #22848: [SPARK-25851][SQL][MINOR] Fix deprecated API warn...

2018-10-26 Thread gengliangwang
Github user gengliangwang commented on a diff in the pull request: https://github.com/apache/spark/pull/22848#discussion_r228559067 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/ui/SQLListener.scala --- @@ -89,12 +89,12 @@ private class LongLongTupleConverter

[GitHub] spark pull request #21348: [SPARK-22739][Catalyst] Additional Expression Sup...

2018-10-26 Thread xuanyuanking
Github user xuanyuanking commented on a diff in the pull request: https://github.com/apache/spark/pull/21348#discussion_r228563440 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala --- @@ -1799,3 +1805,65 @@ case class

[GitHub] spark issue #22853: [SPARK-25845][SQL] Fix MatchError for calendar interval ...

2018-10-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22853 **[Test build #98093 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98093/testReport)** for PR 22853 at commit

[GitHub] spark issue #22851: [SPARK-25797][SQL][DOCS][BACKPORT-2.3] Add migration doc...

2018-10-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22851 **[Test build #98086 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98086/testReport)** for PR 22851 at commit

[GitHub] spark issue #22851: [SPARK-25797][SQL][DOCS][BACKPORT-2.3] Add migration doc...

2018-10-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22851 **[Test build #98086 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98086/testReport)** for PR 22851 at commit

[GitHub] spark issue #22851: [SPARK-25797][SQL][DOCS][BACKPORT-2.3] Add migration doc...

2018-10-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22851 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22851: [SPARK-25797][SQL][DOCS][BACKPORT-2.3] Add migration doc...

2018-10-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22851 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98086/ Test PASSed. ---

[GitHub] spark pull request #22838: [SPARK-25835][K8s] Create kubernetes-tests profil...

2018-10-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/22838 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #22852: [SPARK-25023] Clarify Spark security documentation

2018-10-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22852 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98090/ Test PASSed. ---

[GitHub] spark issue #22802: [SPARK-25806][SQL]The instance of FileSplit is redundant...

2018-10-26 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/22802 OK, that's pretty trivial, but I agree. Any other instances of this type of thing? --- - To unsubscribe, e-mail:

[GitHub] spark issue #21348: [SPARK-22739][Catalyst] Additional Expression Support fo...

2018-10-26 Thread bdrillard
Github user bdrillard commented on the issue: https://github.com/apache/spark/pull/21348 Hi @xuanyuanking, if you'd like to take on the work to fold my prior work in databricks/spark-avro#217 into Spark, that sounds good to me. Please do include me in pull-requests on this topic. Our

[GitHub] spark issue #22838: [SPARK-25835][K8s] Create kubernetes-tests profile and u...

2018-10-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22838 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22838: [SPARK-25835][K8s] Create kubernetes-tests profile and u...

2018-10-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22838 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98085/ Test PASSed. ---

[GitHub] spark issue #22838: [SPARK-25835][K8s] Create kubernetes-tests profile and u...

2018-10-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22838 **[Test build #98085 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98085/testReport)** for PR 22838 at commit

[GitHub] spark pull request #22838: [SPARK-25835][K8s] Create kubernetes-tests profil...

2018-10-26 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/22838#discussion_r228494668 --- Diff: resource-managers/kubernetes/integration-tests/dev/dev-run-integration-tests.sh --- @@ -103,4 +104,4 @@ then properties=( ${properties[@]}

[GitHub] spark issue #22846: [SPARK-25797][SQL][DOCS] Add migration doc for solving i...

2018-10-26 Thread seancxmao
Github user seancxmao commented on the issue: https://github.com/apache/spark/pull/22846 @cloud-fan PR for 2.3 is submitted. Please see #22851. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark issue #22847: [SPARK-25850][SQL] Make the split threshold for the code...

2018-10-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22847 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98080/ Test PASSed. ---

[GitHub] spark issue #22838: [SPARK-25835][K8s] Create kubernetes-tests profile and u...

2018-10-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22838 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/4532/ ---

[GitHub] spark issue #22847: [SPARK-25850][SQL] Make the split threshold for the code...

2018-10-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22847 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #22852: [SPARK-25023] Clarify Spark security documentatio...

2018-10-26 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/22852#discussion_r228535892 --- Diff: docs/security.md --- @@ -6,7 +6,20 @@ title: Security * This will become a table of contents (this text will be scraped). {:toc}

[GitHub] spark pull request #22852: [SPARK-25023] Clarify Spark security documentatio...

2018-10-26 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/22852#discussion_r228536180 --- Diff: docs/security.md --- @@ -6,7 +6,20 @@ title: Security * This will become a table of contents (this text will be scraped). {:toc}

[GitHub] spark pull request #22852: [SPARK-25023] Clarify Spark security documentatio...

2018-10-26 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/22852#discussion_r228536280 --- Diff: docs/security.md --- @@ -6,7 +6,20 @@ title: Security * This will become a table of contents (this text will be scraped). {:toc}

[GitHub] spark issue #22852: [SPARK-25023] Clarify Spark security documentation

2018-10-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22852 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22852: [SPARK-25023] Clarify Spark security documentation

2018-10-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22852 **[Test build #98091 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98091/testReport)** for PR 22852 at commit

[GitHub] spark issue #22852: [SPARK-25023] Clarify Spark security documentation

2018-10-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22852 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22852: [SPARK-25023] Clarify Spark security documentation

2018-10-26 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/22852 I get it, the "it's your responsibility" stance, and it is. For any risk there's a sentence in this doc we could point to and say, "see, told you". If we're going to make a change here, adding

[GitHub] spark issue #22826: [SPARK-25760][DOCS][FOLLOWUP] Add note about AddJar retu...

2018-10-26 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/22826 Merged to master --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22848: [SPARK-25851][SQL][MINOR] Fix deprecated API warning in ...

2018-10-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22848 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22848: [SPARK-25851][SQL][MINOR] Fix deprecated API warning in ...

2018-10-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22848 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22848: [SPARK-25851][SQL][MINOR] Fix deprecated API warning in ...

2018-10-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22848 **[Test build #98092 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98092/testReport)** for PR 22848 at commit

[GitHub] spark issue #22850: [MINOR][DOC] Fix comment error of HiveUtils

2018-10-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22850 **[Test build #98087 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98087/testReport)** for PR 22850 at commit

[GitHub] spark pull request #22598: [SPARK-25501][SS] Add kafka delegation token supp...

2018-10-26 Thread soenkeliebau
Github user soenkeliebau commented on a diff in the pull request: https://github.com/apache/spark/pull/22598#discussion_r228576259 --- Diff: core/src/main/scala/org/apache/spark/deploy/security/KafkaDelegationTokenProvider.scala --- @@ -0,0 +1,65 @@ +/* + * Licensed to

[GitHub] spark issue #22851: [SPARK-25797][SQL][DOCS][BACKPORT-2.3] Add migration doc...

2018-10-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22851 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22847: [SPARK-25850][SQL] Make the split threshold for the code...

2018-10-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22847 **[Test build #98080 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98080/testReport)** for PR 22847 at commit

[GitHub] spark issue #22848: [SPARK-25851][SQL][MINOR] Fix deprecated API warning in ...

2018-10-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22848 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98081/ Test PASSed. ---

[GitHub] spark issue #22848: [SPARK-25851][SQL][MINOR] Fix deprecated API warning in ...

2018-10-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22848 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22850: [MINOR][DOC] Fix comment error of HiveUtils

2018-10-26 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/22850 Yea, I was aware of it. I think there are some more old comments in this file if I remember this correctly. Can you double check and fix them while we are here? ---

[GitHub] spark issue #22850: [MINOR][DOC] Fix comment error of HiveUtils

2018-10-26 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/22850 ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #22764: [SPARK-25765][ML] Add training cost to BisectingK...

2018-10-26 Thread WeichenXu123
Github user WeichenXu123 commented on a diff in the pull request: https://github.com/apache/spark/pull/22764#discussion_r228527916 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/BisectingKMeansModel.scala --- @@ -225,13 +227,14 @@ object BisectingKMeansModel

[GitHub] spark issue #22852: [SPARK-25023] Clarify Spark security documentation

2018-10-26 Thread tgravescs
Github user tgravescs commented on the issue: https://github.com/apache/spark/pull/22852 the intention is not a we told you so, its meant to grab their attention and to get people to think about it because in the end it is their responsibility in my opinion. I'm fine if you

[GitHub] spark issue #21348: [SPARK-22739][Catalyst] Additional Expression Support fo...

2018-10-26 Thread xuanyuanking
Github user xuanyuanking commented on the issue: https://github.com/apache/spark/pull/21348 The jira SPARK-25789 guide me here, thanks for @bdrillard your great job, we also meet the requirement on supporting dataset of avro during Structure Streaming. I'm adapting your code in

[GitHub] spark issue #22029: [SPARK-24395][SQL] IN operator should return NULL when c...

2018-10-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22029 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22830: [SPARK-25838][ML] Remove formatVersion from Saveable

2018-10-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22830 Build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #22029: [SPARK-24395][SQL] IN operator should return NULL when c...

2018-10-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22029 **[Test build #98084 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98084/testReport)** for PR 22029 at commit

[GitHub] spark issue #22830: [SPARK-25838][ML] Remove formatVersion from Saveable

2018-10-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22830 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98082/ Test PASSed. ---

[GitHub] spark issue #22029: [SPARK-24395][SQL] IN operator should return NULL when c...

2018-10-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22029 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98084/ Test FAILed. ---

[GitHub] spark pull request #22775: [SPARK-24709][SQL][FOLLOW-UP] Make schema_of_json...

2018-10-26 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/22775#discussion_r228520891 --- Diff: python/pyspark/sql/functions.py --- @@ -2365,30 +2365,32 @@ def to_json(col, options={}): @ignore_unicode_prefix @since(2.4)

[GitHub] spark issue #22771: [SPARK-25773][Core]Cancel zombie tasks in a result stage...

2018-10-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22771 **[Test build #98083 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98083/testReport)** for PR 22771 at commit

[GitHub] spark issue #22852: [SPARK-25023] Clarify Spark security documentation

2018-10-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22852 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22850: [MINOR][DOC] Fix comment error of HiveUtils

2018-10-26 Thread laskfla
Github user laskfla commented on the issue: https://github.com/apache/spark/pull/22850 @HyukjinKwon ,I checked the file and looks like the others looks good. --- - To unsubscribe, e-mail:

[GitHub] spark issue #22852: [SPARK-25023] Clarify Spark security documentation

2018-10-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22852 **[Test build #98090 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98090/testReport)** for PR 22852 at commit

[GitHub] spark pull request #22852: [SPARK-25023] Clarify Spark security documentatio...

2018-10-26 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/22852#discussion_r228544730 --- Diff: docs/security.md --- @@ -6,7 +6,20 @@ title: Security * This will become a table of contents (this text will be scraped). {:toc}

[GitHub] spark pull request #22775: [SPARK-24709][SQL][FOLLOW-UP] Make schema_of_json...

2018-10-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/22775 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #22815: [SPARK-25821][SQL] Remove SQLContext methods depr...

2018-10-26 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/22815#discussion_r228554831 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala --- @@ -54,6 +54,7 @@ import org.apache.spark.sql.util.ExecutionListenerManager

[GitHub] spark issue #22764: [SPARK-25765][ML] Add training cost to BisectingKMeans s...

2018-10-26 Thread WeichenXu123
Github user WeichenXu123 commented on the issue: https://github.com/apache/spark/pull/22764 I think it can target for 3.0. since 2.4 will be released soon and this PR looks a little complex and need take some time to check carefully. ---

[GitHub] spark issue #22848: [SPARK-25851][SQL][MINOR] Fix deprecated API warning in ...

2018-10-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22848 **[Test build #98081 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98081/testReport)** for PR 22848 at commit

[GitHub] spark issue #22850: [MINOR][DOC] Fix comment error of HiveUtils

2018-10-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22850 **[Test build #98087 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98087/testReport)** for PR 22850 at commit

[GitHub] spark issue #22775: [SPARK-24709][SQL][FOLLOW-UP] Make schema_of_json's inpu...

2018-10-26 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/22775 Sure! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #22848: [SPARK-25851][SQL][MINOR] Fix deprecated API warn...

2018-10-26 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/22848#discussion_r228553964 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/ui/SQLListener.scala --- @@ -89,12 +89,12 @@ private class LongLongTupleConverter extends

[GitHub] spark pull request #22826: [SPARK-25760][DOCS][FOLLOWUP] Add note about AddJ...

2018-10-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/22826 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #22843: [SPARK-16693][SPARKR] Remove methods deprecated

2018-10-26 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/22843 I personally am OK with removing anything deprecated before 2.4. Even things deprecated in 2.4 are technically fair game. If any of these were deprecated pretty recently, might be debatable, but I

[GitHub] spark pull request #22853: [SPARK-25845][SQL] Fix MatchError for calendar in...

2018-10-26 Thread jiangxb1987
GitHub user jiangxb1987 opened a pull request: https://github.com/apache/spark/pull/22853 [SPARK-25845][SQL] Fix MatchError for calendar interval type in range frame left boundary ## What changes were proposed in this pull request? WindowSpecDefinition checks start < last,

[GitHub] spark issue #22838: [SPARK-25835][K8s] Create kubernetes-tests profile and u...

2018-10-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22838 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22838: [SPARK-25835][K8s] Create kubernetes-tests profile and u...

2018-10-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22838 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/4532/ ---

[GitHub] spark issue #22838: [SPARK-25835][K8s] Create kubernetes-tests profile and u...

2018-10-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22838 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22830: [SPARK-25838][ML] Remove formatVersion from Saveable

2018-10-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22830 **[Test build #98082 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98082/testReport)** for PR 22830 at commit

[GitHub] spark issue #22029: [SPARK-24395][SQL] IN operator should return NULL when c...

2018-10-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22029 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22029: [SPARK-24395][SQL] IN operator should return NULL when c...

2018-10-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22029 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request #21348: [SPARK-22739][Catalyst] Additional Expression Sup...

2018-10-26 Thread bdrillard
Github user bdrillard commented on a diff in the pull request: https://github.com/apache/spark/pull/21348#discussion_r228577979 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala --- @@ -1799,3 +1805,65 @@ case class

[GitHub] spark issue #22838: [SPARK-25835][K8s] Create kubernetes-tests profile and u...

2018-10-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22838 **[Test build #98085 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98085/testReport)** for PR 22838 at commit

[GitHub] spark issue #22852: [SPARK-25023] Clarify Spark security documentation

2018-10-26 Thread tgravescs
Github user tgravescs commented on the issue: https://github.com/apache/spark/pull/22852 @vanzin @srowen --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #22852: [SPARK-25023] Clarify Spark security documentatio...

2018-10-26 Thread tgravescs
GitHub user tgravescs opened a pull request: https://github.com/apache/spark/pull/22852 [SPARK-25023] Clarify Spark security documentation ## What changes were proposed in this pull request? Clarify documentation about security. ## How was this patch tested?

[GitHub] spark issue #22838: [SPARK-25835][K8s] Create kubernetes-tests profile and u...

2018-10-26 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/22838 I merged to master/2.4 . The key parts here already passed individually. --- - To unsubscribe, e-mail:

[GitHub] spark pull request #22827: [SPARK-25832][SQL][BRANCH-2.4] Revert newly added...

2018-10-26 Thread gatorsmile
Github user gatorsmile closed the pull request at: https://github.com/apache/spark/pull/22827 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22850: [MINOR][DOC] Fix comment error of HiveUtils

2018-10-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22850 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22850: [MINOR][DOC] Fix comment error of HiveUtils

2018-10-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22850 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98087/ Test PASSed. ---

[GitHub] spark issue #22853: [SPARK-25845][SQL] Fix MatchError for calendar interval ...

2018-10-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22853 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22853: [SPARK-25845][SQL] Fix MatchError for calendar interval ...

2018-10-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22853 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request #22854: [SPARK-25854] fix mvn to not always exit 1

2018-10-26 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22854#discussion_r228588061 --- Diff: build/mvn --- @@ -163,8 +163,19 @@ export MAVEN_OPTS=${MAVEN_OPTS:-"$_COMPILE_JVM_OPTS"} echo "Using \`mvn\` from path: $MVN_BIN"

[GitHub] spark pull request #22854: [SPARK-25854] fix mvn to not always exit 1

2018-10-26 Thread shaneknapp
Github user shaneknapp commented on a diff in the pull request: https://github.com/apache/spark/pull/22854#discussion_r228591941 --- Diff: build/mvn --- @@ -163,8 +163,19 @@ export MAVEN_OPTS=${MAVEN_OPTS:-"$_COMPILE_JVM_OPTS"} echo "Using \`mvn\` from path: $MVN_BIN"

[GitHub] spark issue #22854: [SPARK-25854] fix mvn to not always exit 1

2018-10-26 Thread shaneknapp
Github user shaneknapp commented on the issue: https://github.com/apache/spark/pull/22854 test this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22029: [SPARK-24395][SQL] IN operator should return NULL when c...

2018-10-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22029 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98089/ Test PASSed. ---

[GitHub] spark pull request #22624: [SPARK-23781][CORE] Merge token renewer functiona...

2018-10-26 Thread ifilonenko
Github user ifilonenko commented on a diff in the pull request: https://github.com/apache/spark/pull/22624#discussion_r228605725 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/security/KubernetesHadoopDelegationTokenManager.scala --- @@

[GitHub] spark issue #22029: [SPARK-24395][SQL] IN operator should return NULL when c...

2018-10-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22029 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #22843: [SPARK-16693][SPARKR] Remove methods deprecated

2018-10-26 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/22843#discussion_r228616400 --- Diff: R/pkg/tests/fulltests/test_sparkSQL.R --- @@ -3477,39 +3447,6 @@ test_that("Window functions on a DataFrame", { expect_equal(result,

[GitHub] spark pull request #22624: [SPARK-23781][CORE] Merge token renewer functiona...

2018-10-26 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/22624#discussion_r228628515 --- Diff: core/src/main/scala/org/apache/spark/deploy/security/HadoopDelegationTokenManager.scala --- @@ -17,76 +17,175 @@ package

[GitHub] spark pull request #22809: [SPARK-19851][SQL] Add support for EVERY and ANY ...

2018-10-26 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/22809#discussion_r228633284 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/UnevaluableAggs.scala --- @@ -0,0 +1,62 @@ +/* + *

[GitHub] spark issue #22624: [SPARK-23781][CORE] Merge token renewer functionality in...

2018-10-26 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/22624 > Is there any place which documents this overall flow? Not yet. I plan to write a README.md explaining this, separately, since there's a lot of confusion not just about the flow, but

[GitHub] spark issue #15496: [SPARK-17950] [Python] Match SparseVector behavior with ...

2018-10-26 Thread holdenk
Github user holdenk commented on the issue: https://github.com/apache/spark/pull/15496 While you update to master i might include in the docstring that the similar funcitonality in densevector is done with manual delegation in `_delegate`. ---

[GitHub] spark issue #15670: [SPARK-18161] [Python] Allow pickle to serialize >4 GB o...

2018-10-26 Thread holdenk
Github user holdenk commented on the issue: https://github.com/apache/spark/pull/15670 Jenkins ok to test. @inpefess if you can update this PR to master now is a great time to get this in since the next release after 2.4 is going to be 3 so it's easier to change formats and stuff.

[GitHub] spark issue #22854: [SPARK-25854] fix mvn to not always exit 1

2018-10-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22854 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22854: [SPARK-25854] fix mvn to not always exit 1

2018-10-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22854 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #22854: [SPARK-25854] fix mvn to not always exit 1

2018-10-26 Thread shaneknapp
Github user shaneknapp commented on a diff in the pull request: https://github.com/apache/spark/pull/22854#discussion_r228607477 --- Diff: build/mvn --- @@ -163,8 +163,14 @@ export MAVEN_OPTS=${MAVEN_OPTS:-"$_COMPILE_JVM_OPTS"} echo "Using \`mvn\` from path: $MVN_BIN"

  1   2   3   4   5   >