[GitHub] [spark] HyukjinKwon edited a comment on issue #25130: [SPARK-28359][SQL][PYTHON][TESTS] Make integrated UDF tests robust by making UDFs (virtually) no-op

2019-07-17 Thread GitBox
HyukjinKwon edited a comment on issue #25130: [SPARK-28359][SQL][PYTHON][TESTS] Make integrated UDF tests robust by making UDFs (virtually) no-op URL: https://github.com/apache/spark/pull/25130#issuecomment-510760863 FYI @skonto, @imback82, @huaxingao, @vinodkc, @manuzhang, @chitralverma,

[GitHub] [spark] HyukjinKwon commented on issue #25130: [SPARK-28359][SQL][PYTHON][TESTS] Make integrated UDF tests robust by making UDFs (virtually) no-op

2019-07-17 Thread GitBox
HyukjinKwon commented on issue #25130: [SPARK-28359][SQL][PYTHON][TESTS] Make integrated UDF tests robust by making UDFs (virtually) no-op URL: https://github.com/apache/spark/pull/25130#issuecomment-512275021 thanks @cloud-fan! Guys, can you guys sync to the master branch and

[GitHub] [spark] SparkQA commented on issue #24939: [SPARK-18569][ML][R] Support RFormula arithmetic, I() and spark functions

2019-07-17 Thread GitBox
SparkQA commented on issue #24939: [SPARK-18569][ML][R] Support RFormula arithmetic, I() and spark functions URL: https://github.com/apache/spark/pull/24939#issuecomment-512286714 **[Test build #107786 has

[GitHub] [spark] AmplabJenkins commented on issue #24939: [SPARK-18569][ML][R] Support RFormula arithmetic, I() and spark functions

2019-07-17 Thread GitBox
AmplabJenkins commented on issue #24939: [SPARK-18569][ML][R] Support RFormula arithmetic, I() and spark functions URL: https://github.com/apache/spark/pull/24939#issuecomment-512287231 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #24939: [SPARK-18569][ML][R] Support RFormula arithmetic, I() and spark functions

2019-07-17 Thread GitBox
AmplabJenkins commented on issue #24939: [SPARK-18569][ML][R] Support RFormula arithmetic, I() and spark functions URL: https://github.com/apache/spark/pull/24939#issuecomment-512287248 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] pgandhi999 commented on a change in pull request #23677: [SPARK-26755][SCHEDULER] : Optimize Spark Scheduler to dequeue speculative tasks…

2019-07-17 Thread GitBox
pgandhi999 commented on a change in pull request #23677: [SPARK-26755][SCHEDULER] : Optimize Spark Scheduler to dequeue speculative tasks… URL: https://github.com/apache/spark/pull/23677#discussion_r304471805 ## File path:

[GitHub] [spark] AmplabJenkins commented on issue #25180: [SPARK-28423][SQL] merge Scan and Batch/Stream

2019-07-17 Thread GitBox
AmplabJenkins commented on issue #25180: [SPARK-28423][SQL] merge Scan and Batch/Stream URL: https://github.com/apache/spark/pull/25180#issuecomment-512334316 Merged build finished. Test FAILed. This is an automated message

[GitHub] [spark] AmplabJenkins removed a comment on issue #25180: [SPARK-28423][SQL] merge Scan and Batch/Stream

2019-07-17 Thread GitBox
AmplabJenkins removed a comment on issue #25180: [SPARK-28423][SQL] merge Scan and Batch/Stream URL: https://github.com/apache/spark/pull/25180#issuecomment-512333992 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #25180: [SPARK-28423][SQL] merge Scan and Batch/Stream

2019-07-17 Thread GitBox
AmplabJenkins removed a comment on issue #25180: [SPARK-28423][SQL] merge Scan and Batch/Stream URL: https://github.com/apache/spark/pull/25180#issuecomment-512333983 Merged build finished. Test PASSed. This is an automated

[GitHub] [spark] SparkQA removed a comment on issue #25180: [SPARK-28423][SQL] merge Scan and Batch/Stream

2019-07-17 Thread GitBox
SparkQA removed a comment on issue #25180: [SPARK-28423][SQL] merge Scan and Batch/Stream URL: https://github.com/apache/spark/pull/25180#issuecomment-512331294 **[Test build #107789 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/107789/testReport)** for

[GitHub] [spark] AmplabJenkins removed a comment on issue #25180: [SPARK-28423][SQL] merge Scan and Batch/Stream

2019-07-17 Thread GitBox
AmplabJenkins removed a comment on issue #25180: [SPARK-28423][SQL] merge Scan and Batch/Stream URL: https://github.com/apache/spark/pull/25180#issuecomment-512334316 Merged build finished. Test FAILed. This is an automated

[GitHub] [spark] SparkQA commented on issue #25180: [SPARK-28423][SQL] merge Scan and Batch/Stream

2019-07-17 Thread GitBox
SparkQA commented on issue #25180: [SPARK-28423][SQL] merge Scan and Batch/Stream URL: https://github.com/apache/spark/pull/25180#issuecomment-512334304 **[Test build #107789 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/107789/testReport)** for PR

[GitHub] [spark] AmplabJenkins commented on issue #25180: [SPARK-28423][SQL] merge Scan and Batch/Stream

2019-07-17 Thread GitBox
AmplabJenkins commented on issue #25180: [SPARK-28423][SQL] merge Scan and Batch/Stream URL: https://github.com/apache/spark/pull/25180#issuecomment-512334326 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] wangyum opened a new pull request #25181: [SPARK-28138][SQL][TEST] Port timestamp.sql

2019-07-17 Thread GitBox
wangyum opened a new pull request #25181: [SPARK-28138][SQL][TEST] Port timestamp.sql URL: https://github.com/apache/spark/pull/25181 ## What changes were proposed in this pull request? (Please fill in changes proposed in this fix) ## How was this patch tested? N/A

[GitHub] [spark] huaxingao commented on issue #25046: [SPARK-28243][PYSPARK][ML] Remove setFeatureSubsetStrategy and setSubsamplingRate from Python TreeEnsembleParams

2019-07-17 Thread GitBox
huaxingao commented on issue #25046: [SPARK-28243][PYSPARK][ML] Remove setFeatureSubsetStrategy and setSubsamplingRate from Python TreeEnsembleParams URL: https://github.com/apache/spark/pull/25046#issuecomment-512503374 @srowen Sorry I didn't make it clear in the PR description. On

[GitHub] [spark] AmplabJenkins commented on issue #20999: [SPARK-14922][SPARK-17732][SPARK-23866][SQL] Support partition filters in ALTER TABLE DROP PARTITION

2019-07-17 Thread GitBox
AmplabJenkins commented on issue #20999: [SPARK-14922][SPARK-17732][SPARK-23866][SQL] Support partition filters in ALTER TABLE DROP PARTITION URL: https://github.com/apache/spark/pull/20999#issuecomment-512509046 Test FAILed. Refer to this link for build results (access rights to CI

[GitHub] [spark] AmplabJenkins commented on issue #20999: [SPARK-14922][SPARK-17732][SPARK-23866][SQL] Support partition filters in ALTER TABLE DROP PARTITION

2019-07-17 Thread GitBox
AmplabJenkins commented on issue #20999: [SPARK-14922][SPARK-17732][SPARK-23866][SQL] Support partition filters in ALTER TABLE DROP PARTITION URL: https://github.com/apache/spark/pull/20999#issuecomment-512509035 Build finished. Test FAILed.

[GitHub] [spark] SparkQA commented on issue #20999: [SPARK-14922][SPARK-17732][SPARK-23866][SQL] Support partition filters in ALTER TABLE DROP PARTITION

2019-07-17 Thread GitBox
SparkQA commented on issue #20999: [SPARK-14922][SPARK-17732][SPARK-23866][SQL] Support partition filters in ALTER TABLE DROP PARTITION URL: https://github.com/apache/spark/pull/20999#issuecomment-512509005 **[Test build #107795 has

[GitHub] [spark] srowen commented on issue #25046: [SPARK-28243][PYSPARK][ML] Remove setFeatureSubsetStrategy and setSubsamplingRate from Python TreeEnsembleParams

2019-07-17 Thread GitBox
srowen commented on issue #25046: [SPARK-28243][PYSPARK][ML] Remove setFeatureSubsetStrategy and setSubsamplingRate from Python TreeEnsembleParams URL: https://github.com/apache/spark/pull/25046#issuecomment-512508793 OK this is really a follow up of

[GitHub] [spark] squito commented on a change in pull request #23767: [SPARK-26329][CORE] Faster polling of executor memory metrics.

2019-07-17 Thread GitBox
squito commented on a change in pull request #23767: [SPARK-26329][CORE] Faster polling of executor memory metrics. URL: https://github.com/apache/spark/pull/23767#discussion_r304578241 ## File path: core/src/test/scala/org/apache/spark/executor/ExecutorSuite.scala ## @@

[GitHub] [spark] AmplabJenkins removed a comment on issue #24637: [SPARK-27707][SQL] Prune unnecessary nested fields from Generate

2019-07-17 Thread GitBox
AmplabJenkins removed a comment on issue #24637: [SPARK-27707][SQL] Prune unnecessary nested fields from Generate URL: https://github.com/apache/spark/pull/24637#issuecomment-512512148 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #24637: [SPARK-27707][SQL] Prune unnecessary nested fields from Generate

2019-07-17 Thread GitBox
AmplabJenkins removed a comment on issue #24637: [SPARK-27707][SQL] Prune unnecessary nested fields from Generate URL: https://github.com/apache/spark/pull/24637#issuecomment-512512155 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #25180: [SPARK-28423][SQL] merge Scan and Batch/Stream

2019-07-17 Thread GitBox
AmplabJenkins removed a comment on issue #25180: [SPARK-28423][SQL] merge Scan and Batch/Stream URL: https://github.com/apache/spark/pull/25180#issuecomment-512334326 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #25181: [SPARK-28138][SQL][TEST] Port timestamp.sql

2019-07-17 Thread GitBox
AmplabJenkins commented on issue #25181: [SPARK-28138][SQL][TEST] Port timestamp.sql URL: https://github.com/apache/spark/pull/25181#issuecomment-512345426 Merged build finished. Test PASSed. This is an automated message

[GitHub] [spark] AmplabJenkins commented on issue #25181: [SPARK-28138][SQL][TEST] Port timestamp.sql

2019-07-17 Thread GitBox
AmplabJenkins commented on issue #25181: [SPARK-28138][SQL][TEST] Port timestamp.sql URL: https://github.com/apache/spark/pull/25181#issuecomment-512345437 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] DylanGuedes commented on issue #24881: [SPARK-23160][SQL][TEST] Port window.sql

2019-07-17 Thread GitBox
DylanGuedes commented on issue #24881: [SPARK-23160][SQL][TEST] Port window.sql URL: https://github.com/apache/spark/pull/24881#issuecomment-512357993 @dongjoon-hyun Thank you for the suggestion! I review'd it and I only missed a `drop view` at the end.

[GitHub] [spark] dongjoon-hyun commented on issue #24637: [SPARK-27707][SQL] Prune unnecessary nested fields from Generate

2019-07-17 Thread GitBox
dongjoon-hyun commented on issue #24637: [SPARK-27707][SQL] Prune unnecessary nested fields from Generate URL: https://github.com/apache/spark/pull/24637#issuecomment-512358172 Thank you for adding a new test. Are you going to add more tests since `Stack` is one of them? In fact, we need

[GitHub] [spark] SparkQA commented on issue #24881: [SPARK-23160][SQL][TEST] Port window.sql

2019-07-17 Thread GitBox
SparkQA commented on issue #24881: [SPARK-23160][SQL][TEST] Port window.sql URL: https://github.com/apache/spark/pull/24881#issuecomment-512367886 **[Test build #107787 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/107787/testReport)** for PR 24881 at

[GitHub] [spark] SparkQA commented on issue #20999: [SPARK-14922][SPARK-17732][SPARK-23866][SQL] Support partition filters in ALTER TABLE DROP PARTITION

2019-07-17 Thread GitBox
SparkQA commented on issue #20999: [SPARK-14922][SPARK-17732][SPARK-23866][SQL] Support partition filters in ALTER TABLE DROP PARTITION URL: https://github.com/apache/spark/pull/20999#issuecomment-512484624 **[Test build #107795 has

[GitHub] [spark] AmplabJenkins removed a comment on issue #25175: [SPARK-28411][PYTHON][SQL] InsertInto with overwrite is not honored

2019-07-17 Thread GitBox
AmplabJenkins removed a comment on issue #25175: [SPARK-28411][PYTHON][SQL] InsertInto with overwrite is not honored URL: https://github.com/apache/spark/pull/25175#issuecomment-512477423 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #25157: [WIP][SPARK-28396][SQL] Add PathCatalog for data source V2

2019-07-17 Thread GitBox
AmplabJenkins commented on issue #25157: [WIP][SPARK-28396][SQL] Add PathCatalog for data source V2 URL: https://github.com/apache/spark/pull/25157#issuecomment-512289570 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #25157: [WIP][SPARK-28396][SQL] Add PathCatalog for data source V2

2019-07-17 Thread GitBox
AmplabJenkins removed a comment on issue #25157: [WIP][SPARK-28396][SQL] Add PathCatalog for data source V2 URL: https://github.com/apache/spark/pull/25157#issuecomment-512289557 Merged build finished. Test FAILed. This is

[GitHub] [spark] SparkQA removed a comment on issue #25157: [WIP][SPARK-28396][SQL] Add PathCatalog for data source V2

2019-07-17 Thread GitBox
SparkQA removed a comment on issue #25157: [WIP][SPARK-28396][SQL] Add PathCatalog for data source V2 URL: https://github.com/apache/spark/pull/25157#issuecomment-512231353 **[Test build #107785 has

[GitHub] [spark] AmplabJenkins commented on issue #25157: [WIP][SPARK-28396][SQL] Add PathCatalog for data source V2

2019-07-17 Thread GitBox
AmplabJenkins commented on issue #25157: [WIP][SPARK-28396][SQL] Add PathCatalog for data source V2 URL: https://github.com/apache/spark/pull/25157#issuecomment-512289557 Merged build finished. Test FAILed. This is an

[GitHub] [spark] SparkQA commented on issue #24637: [SPARK-27707][SQL] Prune unnecessary nested fields from Generate

2019-07-17 Thread GitBox
SparkQA commented on issue #24637: [SPARK-27707][SQL] Prune unnecessary nested fields from Generate URL: https://github.com/apache/spark/pull/24637#issuecomment-512308990 **[Test build #107788 has

[GitHub] [spark] dongjoon-hyun commented on issue #25179: [SPARK-28419][SQL] A patch for SparkThriftServer to support multi-tenant authentication for spark-2.4.0

2019-07-17 Thread GitBox
dongjoon-hyun commented on issue #25179: [SPARK-28419][SQL] A patch for SparkThriftServer to support multi-tenant authentication for spark-2.4.0 URL: https://github.com/apache/spark/pull/25179#issuecomment-512359392 Thank you for making a PR, @AngersZh . However, we review a PR on

[GitHub] [spark] dongjoon-hyun closed pull request #25179: [SPARK-28419][SQL] A patch for SparkThriftServer to support multi-tenant authentication for spark-2.4.0

2019-07-17 Thread GitBox
dongjoon-hyun closed pull request #25179: [SPARK-28419][SQL] A patch for SparkThriftServer to support multi-tenant authentication for spark-2.4.0 URL: https://github.com/apache/spark/pull/25179 This is an automated message

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25074: [SPARK-27924][SQL] Support ANSI SQL Boolean-Predicate syntax

2019-07-17 Thread GitBox
dongjoon-hyun commented on a change in pull request #25074: [SPARK-27924][SQL] Support ANSI SQL Boolean-Predicate syntax URL: https://github.com/apache/spark/pull/25074#discussion_r304538853 ## File path:

[GitHub] [spark] SparkQA commented on issue #25175: [SPARK-28411][PYTHON][SQL] InsertInto with overwrite is not honored

2019-07-17 Thread GitBox
SparkQA commented on issue #25175: [SPARK-28411][PYTHON][SQL] InsertInto with overwrite is not honored URL: https://github.com/apache/spark/pull/25175#issuecomment-512404882 **[Test build #107793 has

[GitHub] [spark] vanzin commented on issue #24879: [SPARK-28042][K8S] Support using volume mount as local storage

2019-07-17 Thread GitBox
vanzin commented on issue #24879: [SPARK-28042][K8S] Support using volume mount as local storage URL: https://github.com/apache/spark/pull/24879#issuecomment-512445770 I'm not saying "just use pod templates". I'm saying "use pod templates to mount volume into the container, and add

[GitHub] [spark] SparkQA commented on issue #25180: [SPARK-28423][SQL] merge Scan and Batch/Stream

2019-07-17 Thread GitBox
SparkQA commented on issue #25180: [SPARK-28423][SQL] merge Scan and Batch/Stream URL: https://github.com/apache/spark/pull/25180#issuecomment-512465308 **[Test build #107794 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/107794/testReport)** for PR 25180

[GitHub] [spark] icexelloss commented on issue #24981: [WIP][SPARK-27463][PYTHON] Support Dataframe Cogroup via Pandas UDFs- Arrow Stream Impl

2019-07-17 Thread GitBox
icexelloss commented on issue #24981: [WIP][SPARK-27463][PYTHON] Support Dataframe Cogroup via Pandas UDFs- Arrow Stream Impl URL: https://github.com/apache/spark/pull/24981#issuecomment-512462884 @d80tb7 My personal preference is to keep this PR because there are already quite bit of

[GitHub] [spark] yeshengm closed pull request #25164: [SPARK-28375][SQL] Prevent the PullupCorrelatedPredicates optimizer rule from removing predicates if run multiple times

2019-07-17 Thread GitBox
yeshengm closed pull request #25164: [SPARK-28375][SQL] Prevent the PullupCorrelatedPredicates optimizer rule from removing predicates if run multiple times URL: https://github.com/apache/spark/pull/25164 This is an

[GitHub] [spark] yeshengm commented on a change in pull request #25164: [SPARK-28375][SQL] Prevent the PullupCorrelatedPredicates optimizer rule from removing predicates if run multiple times

2019-07-17 Thread GitBox
yeshengm commented on a change in pull request #25164: [SPARK-28375][SQL] Prevent the PullupCorrelatedPredicates optimizer rule from removing predicates if run multiple times URL: https://github.com/apache/spark/pull/25164#discussion_r304557504 ## File path:

[GitHub] [spark] AmplabJenkins commented on issue #24637: [SPARK-27707][SQL] Prune unnecessary nested fields from Generate

2019-07-17 Thread GitBox
AmplabJenkins commented on issue #24637: [SPARK-27707][SQL] Prune unnecessary nested fields from Generate URL: https://github.com/apache/spark/pull/24637#issuecomment-512304193 Merged build finished. Test PASSed. This is an

[GitHub] [spark] AmplabJenkins removed a comment on issue #24637: [SPARK-27707][SQL] Prune unnecessary nested fields from Generate

2019-07-17 Thread GitBox
AmplabJenkins removed a comment on issue #24637: [SPARK-27707][SQL] Prune unnecessary nested fields from Generate URL: https://github.com/apache/spark/pull/24637#issuecomment-512304193 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #24637: [SPARK-27707][SQL] Prune unnecessary nested fields from Generate

2019-07-17 Thread GitBox
AmplabJenkins removed a comment on issue #24637: [SPARK-27707][SQL] Prune unnecessary nested fields from Generate URL: https://github.com/apache/spark/pull/24637#issuecomment-512304235 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA commented on issue #25180: [SPARK-28423][SQL] merge Scan and Batch/Stream

2019-07-17 Thread GitBox
SparkQA commented on issue #25180: [SPARK-28423][SQL] merge Scan and Batch/Stream URL: https://github.com/apache/spark/pull/25180#issuecomment-512331294 **[Test build #107789 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/107789/testReport)** for PR 25180

[GitHub] [spark] SparkQA commented on issue #23677: [SPARK-26755][SCHEDULER] : Optimize Spark Scheduler to dequeue speculative tasks…

2019-07-17 Thread GitBox
SparkQA commented on issue #23677: [SPARK-26755][SCHEDULER] : Optimize Spark Scheduler to dequeue speculative tasks… URL: https://github.com/apache/spark/pull/23677#issuecomment-512331338 **[Test build #107790 has

[GitHub] [spark] AmplabJenkins removed a comment on issue #24881: [SPARK-23160][SQL][TEST] Port window.sql

2019-07-17 Thread GitBox
AmplabJenkins removed a comment on issue #24881: [SPARK-23160][SQL][TEST] Port window.sql URL: https://github.com/apache/spark/pull/24881#issuecomment-512372355 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA removed a comment on issue #24881: [SPARK-23160][SQL][TEST] Port window.sql

2019-07-17 Thread GitBox
SparkQA removed a comment on issue #24881: [SPARK-23160][SQL][TEST] Port window.sql URL: https://github.com/apache/spark/pull/24881#issuecomment-512265194 **[Test build #107787 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/107787/testReport)** for PR

[GitHub] [spark] AmplabJenkins removed a comment on issue #24881: [SPARK-23160][SQL][TEST] Port window.sql

2019-07-17 Thread GitBox
AmplabJenkins removed a comment on issue #24881: [SPARK-23160][SQL][TEST] Port window.sql URL: https://github.com/apache/spark/pull/24881#issuecomment-512372295 Merged build finished. Test PASSed. This is an automated

[GitHub] [spark] DylanGuedes commented on issue #24881: [SPARK-23160][SQL][TEST] Port window.sql

2019-07-17 Thread GitBox
DylanGuedes commented on issue #24881: [SPARK-23160][SQL][TEST] Port window.sql URL: https://github.com/apache/spark/pull/24881#issuecomment-512472968 @dongjoon-hyun Nice. So I'll document them for now. This is an automated

[GitHub] [spark] yeshengm closed pull request #25039: [WIP][SPARK-28237][SQL] Add an Idempotent batch strategy to catch potential bugs in corresponding rules

2019-07-17 Thread GitBox
yeshengm closed pull request #25039: [WIP][SPARK-28237][SQL] Add an Idempotent batch strategy to catch potential bugs in corresponding rules URL: https://github.com/apache/spark/pull/25039 This is an automated message from

[GitHub] [spark] AmplabJenkins commented on issue #24637: [SPARK-27707][SQL] Prune unnecessary nested fields from Generate

2019-07-17 Thread GitBox
AmplabJenkins commented on issue #24637: [SPARK-27707][SQL] Prune unnecessary nested fields from Generate URL: https://github.com/apache/spark/pull/24637#issuecomment-512512148 Merged build finished. Test PASSed. This is an

[GitHub] [spark] AmplabJenkins commented on issue #24637: [SPARK-27707][SQL] Prune unnecessary nested fields from Generate

2019-07-17 Thread GitBox
AmplabJenkins commented on issue #24637: [SPARK-27707][SQL] Prune unnecessary nested fields from Generate URL: https://github.com/apache/spark/pull/24637#issuecomment-512512155 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA removed a comment on issue #24939: [SPARK-18569][ML][R] Support RFormula arithmetic, I() and spark functions

2019-07-17 Thread GitBox
SparkQA removed a comment on issue #24939: [SPARK-18569][ML][R] Support RFormula arithmetic, I() and spark functions URL: https://github.com/apache/spark/pull/24939#issuecomment-512251429 **[Test build #107786 has

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #24637: [SPARK-27707][SQL] Prune unnecessary nested fields from Generate

2019-07-17 Thread GitBox
dongjoon-hyun commented on a change in pull request #24637: [SPARK-27707][SQL] Prune unnecessary nested fields from Generate URL: https://github.com/apache/spark/pull/24637#discussion_r304500435 ## File path:

[GitHub] [spark] dongjoon-hyun commented on issue #24881: [SPARK-23160][SQL][TEST] Port window.sql

2019-07-17 Thread GitBox
dongjoon-hyun commented on issue #24881: [SPARK-23160][SQL][TEST] Port window.sql URL: https://github.com/apache/spark/pull/24881#issuecomment-512360035 It's not missed. It's a temporary view. We don't need to drop it manually.

[GitHub] [spark] DylanGuedes commented on issue #24881: [SPARK-23160][SQL][TEST] Port window.sql

2019-07-17 Thread GitBox
DylanGuedes commented on issue #24881: [SPARK-23160][SQL][TEST] Port window.sql URL: https://github.com/apache/spark/pull/24881#issuecomment-512363836 Nice! So, I'm almost finishing it, I get stucked in the following questions, because I'm not sure if the current behavior is intended or if

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25074: [SPARK-27924][SQL] Support ANSI SQL Boolean-Predicate syntax

2019-07-17 Thread GitBox
dongjoon-hyun commented on a change in pull request #25074: [SPARK-27924][SQL] Support ANSI SQL Boolean-Predicate syntax URL: https://github.com/apache/spark/pull/25074#discussion_r304536038 ## File path:

[GitHub] [spark] rdblue commented on a change in pull request #24798: [SPARK-27724][SQL] Implement REPLACE TABLE and REPLACE TABLE AS SELECT with V2

2019-07-17 Thread GitBox
rdblue commented on a change in pull request #24798: [SPARK-27724][SQL] Implement REPLACE TABLE and REPLACE TABLE AS SELECT with V2 URL: https://github.com/apache/spark/pull/24798#discussion_r304537234 ## File path:

[GitHub] [spark] icexelloss edited a comment on issue #24981: [WIP][SPARK-27463][PYTHON] Support Dataframe Cogroup via Pandas UDFs- Arrow Stream Impl

2019-07-17 Thread GitBox
icexelloss edited a comment on issue #24981: [WIP][SPARK-27463][PYTHON] Support Dataframe Cogroup via Pandas UDFs- Arrow Stream Impl URL: https://github.com/apache/spark/pull/24981#issuecomment-512420808 I wonder if `df1.cogroup(df2, on='id')` is just a simple API wrapper? ```

[GitHub] [spark] AmplabJenkins commented on issue #25180: [SPARK-28423][SQL] merge Scan and Batch/Stream

2019-07-17 Thread GitBox
AmplabJenkins commented on issue #25180: [SPARK-28423][SQL] merge Scan and Batch/Stream URL: https://github.com/apache/spark/pull/25180#issuecomment-512491855 Merged build finished. Test FAILed. This is an automated message

[GitHub] [spark] SparkQA commented on issue #25180: [SPARK-28423][SQL] merge Scan and Batch/Stream

2019-07-17 Thread GitBox
SparkQA commented on issue #25180: [SPARK-28423][SQL] merge Scan and Batch/Stream URL: https://github.com/apache/spark/pull/25180#issuecomment-512491691 **[Test build #107794 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/107794/testReport)** for PR

[GitHub] [spark] AmplabJenkins commented on issue #25180: [SPARK-28423][SQL] merge Scan and Batch/Stream

2019-07-17 Thread GitBox
AmplabJenkins commented on issue #25180: [SPARK-28423][SQL] merge Scan and Batch/Stream URL: https://github.com/apache/spark/pull/25180#issuecomment-512491898 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] squito commented on a change in pull request #23677: [SPARK-26755][SCHEDULER] : Optimize Spark Scheduler to dequeue speculative tasks…

2019-07-17 Thread GitBox
squito commented on a change in pull request #23677: [SPARK-26755][SCHEDULER] : Optimize Spark Scheduler to dequeue speculative tasks… URL: https://github.com/apache/spark/pull/23677#discussion_r304567188 ## File path:

[GitHub] [spark] squito commented on a change in pull request #23677: [SPARK-26755][SCHEDULER] : Optimize Spark Scheduler to dequeue speculative tasks…

2019-07-17 Thread GitBox
squito commented on a change in pull request #23677: [SPARK-26755][SCHEDULER] : Optimize Spark Scheduler to dequeue speculative tasks… URL: https://github.com/apache/spark/pull/23677#discussion_r304565953 ## File path:

[GitHub] [spark] AmplabJenkins removed a comment on issue #20999: [SPARK-14922][SPARK-17732][SPARK-23866][SQL] Support partition filters in ALTER TABLE DROP PARTITION

2019-07-17 Thread GitBox
AmplabJenkins removed a comment on issue #20999: [SPARK-14922][SPARK-17732][SPARK-23866][SQL] Support partition filters in ALTER TABLE DROP PARTITION URL: https://github.com/apache/spark/pull/20999#issuecomment-512509035 Build finished. Test FAILed.

[GitHub] [spark] SparkQA removed a comment on issue #20999: [SPARK-14922][SPARK-17732][SPARK-23866][SQL] Support partition filters in ALTER TABLE DROP PARTITION

2019-07-17 Thread GitBox
SparkQA removed a comment on issue #20999: [SPARK-14922][SPARK-17732][SPARK-23866][SQL] Support partition filters in ALTER TABLE DROP PARTITION URL: https://github.com/apache/spark/pull/20999#issuecomment-512484624 **[Test build #107795 has

[GitHub] [spark] AmplabJenkins commented on issue #24637: [SPARK-27707][SQL] Prune unnecessary nested fields from Generate

2019-07-17 Thread GitBox
AmplabJenkins commented on issue #24637: [SPARK-27707][SQL] Prune unnecessary nested fields from Generate URL: https://github.com/apache/spark/pull/24637#issuecomment-512304235 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #25180: [SPARK-28423][SQL] merge Scan and Batch/Stream

2019-07-17 Thread GitBox
AmplabJenkins commented on issue #25180: [SPARK-28423][SQL] merge Scan and Batch/Stream URL: https://github.com/apache/spark/pull/25180#issuecomment-512333992 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] jose-torres commented on issue #25180: [SPARK-28423][SQL] merge Scan and Batch/Stream

2019-07-17 Thread GitBox
jose-torres commented on issue #25180: [SPARK-28423][SQL] merge Scan and Batch/Stream URL: https://github.com/apache/spark/pull/25180#issuecomment-512333958 This seems fine, but didn’t we decide a while back (Q4 18 I think) not to do it?

[GitHub] [spark] AmplabJenkins commented on issue #25180: [SPARK-28423][SQL] merge Scan and Batch/Stream

2019-07-17 Thread GitBox
AmplabJenkins commented on issue #25180: [SPARK-28423][SQL] merge Scan and Batch/Stream URL: https://github.com/apache/spark/pull/25180#issuecomment-512333983 Merged build finished. Test PASSed. This is an automated message

[GitHub] [spark] SparkQA commented on issue #25181: [SPARK-28138][SQL][TEST] Port timestamp.sql

2019-07-17 Thread GitBox
SparkQA commented on issue #25181: [SPARK-28138][SQL][TEST] Port timestamp.sql URL: https://github.com/apache/spark/pull/25181#issuecomment-512346258 **[Test build #107791 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/107791/testReport)** for PR 25181 at

[GitHub] [spark] AngersZhuuuu commented on issue #25179: [SPARK-28419][SQL] A patch for SparkThriftServer to support multi-tenant authentication for spark-2.4.0

2019-07-17 Thread GitBox
AngersZh commented on issue #25179: [SPARK-28419][SQL] A patch for SparkThriftServer to support multi-tenant authentication for spark-2.4.0 URL: https://github.com/apache/spark/pull/25179#issuecomment-512362487 > Thank you for making a PR, @AngersZh . > However, we review a PR

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25074: [SPARK-27924][SQL] Support ANSI SQL Boolean-Predicate syntax

2019-07-17 Thread GitBox
dongjoon-hyun commented on a change in pull request #25074: [SPARK-27924][SQL] Support ANSI SQL Boolean-Predicate syntax URL: https://github.com/apache/spark/pull/25074#discussion_r304542007 ## File path:

[GitHub] [spark] dongjoon-hyun commented on issue #25179: [SPARK-28419][SQL] A patch for SparkThriftServer to support multi-tenant authentication for spark-2.4.0

2019-07-17 Thread GitBox
dongjoon-hyun commented on issue #25179: [SPARK-28419][SQL] A patch for SparkThriftServer to support multi-tenant authentication for spark-2.4.0 URL: https://github.com/apache/spark/pull/25179#issuecomment-512375149 Thank you for your understanding, @AngersZh !

[GitHub] [spark] cloud-fan commented on issue #25180: [SPARK-28423][SQL] merge Scan and Batch/Stream

2019-07-17 Thread GitBox
cloud-fan commented on issue #25180: [SPARK-28423][SQL] merge Scan and Batch/Stream URL: https://github.com/apache/spark/pull/25180#issuecomment-512446883 @jose-torres seems there is a misunderstanding. This is on my TODO list a long time ago and I do want to finish it before 3.0.

[GitHub] [spark] SparkQA commented on issue #25175: [SPARK-28411][PYTHON][SQL] InsertInto with overwrite is not honored

2019-07-17 Thread GitBox
SparkQA commented on issue #25175: [SPARK-28411][PYTHON][SQL] InsertInto with overwrite is not honored URL: https://github.com/apache/spark/pull/25175#issuecomment-512474747 **[Test build #107793 has

[GitHub] [spark] AmplabJenkins removed a comment on issue #25180: [SPARK-28423][SQL] merge Scan and Batch/Stream

2019-07-17 Thread GitBox
AmplabJenkins removed a comment on issue #25180: [SPARK-28423][SQL] merge Scan and Batch/Stream URL: https://github.com/apache/spark/pull/25180#issuecomment-512491898 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #25180: [SPARK-28423][SQL] merge Scan and Batch/Stream

2019-07-17 Thread GitBox
AmplabJenkins removed a comment on issue #25180: [SPARK-28423][SQL] merge Scan and Batch/Stream URL: https://github.com/apache/spark/pull/25180#issuecomment-512491855 Merged build finished. Test FAILed. This is an automated

[GitHub] [spark] SparkQA removed a comment on issue #25180: [SPARK-28423][SQL] merge Scan and Batch/Stream

2019-07-17 Thread GitBox
SparkQA removed a comment on issue #25180: [SPARK-28423][SQL] merge Scan and Batch/Stream URL: https://github.com/apache/spark/pull/25180#issuecomment-512465308 **[Test build #107794 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/107794/testReport)** for

[GitHub] [spark] squito commented on issue #24796: [SPARK-27900][CORE] Add uncaught exception handler to the driver

2019-07-17 Thread GitBox
squito commented on issue #24796: [SPARK-27900][CORE] Add uncaught exception handler to the driver URL: https://github.com/apache/spark/pull/24796#issuecomment-512494993 wait, you are not all saying the same thing. @mccheah I am suggesting that we add the `-XX:OnOutOfMemoryError="kill -9

[GitHub] [spark] SparkQA removed a comment on issue #24637: [SPARK-27707][SQL] Prune unnecessary nested fields from Generate

2019-07-17 Thread GitBox
SparkQA removed a comment on issue #24637: [SPARK-27707][SQL] Prune unnecessary nested fields from Generate URL: https://github.com/apache/spark/pull/24637#issuecomment-512308990 **[Test build #107788 has

[GitHub] [spark] SparkQA commented on issue #24637: [SPARK-27707][SQL] Prune unnecessary nested fields from Generate

2019-07-17 Thread GitBox
SparkQA commented on issue #24637: [SPARK-27707][SQL] Prune unnecessary nested fields from Generate URL: https://github.com/apache/spark/pull/24637#issuecomment-512511408 **[Test build #107788 has

[GitHub] [spark] SparkQA commented on issue #25157: [WIP][SPARK-28396][SQL] Add PathCatalog for data source V2

2019-07-17 Thread GitBox
SparkQA commented on issue #25157: [WIP][SPARK-28396][SQL] Add PathCatalog for data source V2 URL: https://github.com/apache/spark/pull/25157#issuecomment-512289218 **[Test build #107785 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/107785/testReport)**

[GitHub] [spark] viirya commented on a change in pull request #24637: [SPARK-27707][SQL] Prune unnecessary nested fields from Generate

2019-07-17 Thread GitBox
viirya commented on a change in pull request #24637: [SPARK-27707][SQL] Prune unnecessary nested fields from Generate URL: https://github.com/apache/spark/pull/24637#discussion_r304461150 ## File path:

[GitHub] [spark] viirya commented on a change in pull request #24637: [SPARK-27707][SQL] Prune unnecessary nested fields from Generate

2019-07-17 Thread GitBox
viirya commented on a change in pull request #24637: [SPARK-27707][SQL] Prune unnecessary nested fields from Generate URL: https://github.com/apache/spark/pull/24637#discussion_r304461150 ## File path:

[GitHub] [spark] cloud-fan commented on a change in pull request #25134: [SPARK-28366][CORE] Logging in driver when loading single large unsplittable file

2019-07-17 Thread GitBox
cloud-fan commented on a change in pull request #25134: [SPARK-28366][CORE] Logging in driver when loading single large unsplittable file URL: https://github.com/apache/spark/pull/25134#discussion_r304475828 ## File path:

[GitHub] [spark] AmplabJenkins removed a comment on issue #25181: [SPARK-28138][SQL][TEST] Port timestamp.sql

2019-07-17 Thread GitBox
AmplabJenkins removed a comment on issue #25181: [SPARK-28138][SQL][TEST] Port timestamp.sql URL: https://github.com/apache/spark/pull/25181#issuecomment-512345437 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #25181: [SPARK-28138][SQL][TEST] Port timestamp.sql

2019-07-17 Thread GitBox
AmplabJenkins removed a comment on issue #25181: [SPARK-28138][SQL][TEST] Port timestamp.sql URL: https://github.com/apache/spark/pull/25181#issuecomment-512345426 Merged build finished. Test PASSed. This is an automated

[GitHub] [spark] dongjoon-hyun commented on issue #24881: [SPARK-23160][SQL][TEST] Port window.sql

2019-07-17 Thread GitBox
dongjoon-hyun commented on issue #24881: [SPARK-23160][SQL][TEST] Port window.sql URL: https://github.com/apache/spark/pull/24881#issuecomment-512346931 Hi, @DylanGuedes . I made a PR to you, https://github.com/DylanGuedes/spark/pull/1 . - It replaces REL_12_BETA1 with REL_12_BETA2.

[GitHub] [spark] gengliangwang commented on a change in pull request #24405: [SPARK-27506][SQL] Allow deserialization of Avro data using compatible schemas

2019-07-17 Thread GitBox
gengliangwang commented on a change in pull request #24405: [SPARK-27506][SQL] Allow deserialization of Avro data using compatible schemas URL: https://github.com/apache/spark/pull/24405#discussion_r304519989 ## File path:

[GitHub] [spark] rdblue commented on a change in pull request #24798: [SPARK-27724][SQL] Implement REPLACE TABLE and REPLACE TABLE AS SELECT with V2

2019-07-17 Thread GitBox
rdblue commented on a change in pull request #24798: [SPARK-27724][SQL] Implement REPLACE TABLE and REPLACE TABLE AS SELECT with V2 URL: https://github.com/apache/spark/pull/24798#discussion_r304539764 ## File path:

[GitHub] [spark] dongjoon-hyun commented on issue #24881: [SPARK-23160][SQL][TEST] Port window.sql

2019-07-17 Thread GitBox
dongjoon-hyun commented on issue #24881: [SPARK-23160][SQL][TEST] Port window.sql URL: https://github.com/apache/spark/pull/24881#issuecomment-512382094 Yes. Please search the JIRA and file all of them if they don't exist. For `explain (costs off)`, there might exist one.

[GitHub] [spark] icexelloss commented on issue #24981: [WIP][SPARK-27463][PYTHON] Support Dataframe Cogroup via Pandas UDFs- Arrow Stream Impl

2019-07-17 Thread GitBox
icexelloss commented on issue #24981: [WIP][SPARK-27463][PYTHON] Support Dataframe Cogroup via Pandas UDFs- Arrow Stream Impl URL: https://github.com/apache/spark/pull/24981#issuecomment-512420808 I wonder if `df1.cogroup(df2, on='id')` is just a simple API wrapper? ``` def

[GitHub] [spark] AmplabJenkins removed a comment on issue #25175: [SPARK-28411][PYTHON][SQL] InsertInto with overwrite is not honored

2019-07-17 Thread GitBox
AmplabJenkins removed a comment on issue #25175: [SPARK-28411][PYTHON][SQL] InsertInto with overwrite is not honored URL: https://github.com/apache/spark/pull/25175#issuecomment-512419655 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #25175: [SPARK-28411][PYTHON][SQL] InsertInto with overwrite is not honored

2019-07-17 Thread GitBox
AmplabJenkins removed a comment on issue #25175: [SPARK-28411][PYTHON][SQL] InsertInto with overwrite is not honored URL: https://github.com/apache/spark/pull/25175#issuecomment-512419704 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #25175: [SPARK-28411][PYTHON][SQL] InsertInto with overwrite is not honored

2019-07-17 Thread GitBox
AmplabJenkins commented on issue #25175: [SPARK-28411][PYTHON][SQL] InsertInto with overwrite is not honored URL: https://github.com/apache/spark/pull/25175#issuecomment-512419655 Merged build finished. Test PASSed. This is

  1   2   3   4   5   6   7   8   >