huaxingao commented on issue #25046: [SPARK-28243][PYSPARK][ML] Remove setFeatureSubsetStrategy and setSubsamplingRate from Python TreeEnsembleParams URL: https://github.com/apache/spark/pull/25046#issuecomment-512503374 @srowen Sorry I didn't make it clear in the PR description. On Scala side, initially, both ```setSubsamplingRate``` and ```setFeatureSubsetStrategy``` were in ```trait TreeEnsembleParams``` in ```treeParams.scala```. These two setters were deprecated and moved from ```trait TreeEnsembleParams``` to ```RandomForestClassifier/Regressor```, ```GBTClassifier/Regressor``` in 3.0.0. In this PR, I did the same thing on python side, I moved ```setSubsamplingRate``` from ```TreeEnsembleParams``` to ```RandomForestClassifier/Regressor``` and ```GBTClassifier/Regressor```. ```setFeatureSubsetStrategy``` is already in python ```RandomForestClassifier/Regressor``` and ```GBTClassifier/Regressor```, so I simply removed it from ```TreeEnsembleParams```.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
