[GitHub] [spark] imback82 commented on a change in pull request #25247: [SPARK-28319][SQL] Implement SHOW TABLES for Data Source V2 Tables

2019-08-03 Thread GitBox
imback82 commented on a change in pull request #25247: [SPARK-28319][SQL] Implement SHOW TABLES for Data Source V2 Tables URL: https://github.com/apache/spark/pull/25247#discussion_r310341532 ## File path:

[GitHub] [spark] imback82 commented on a change in pull request #25247: [SPARK-28319][SQL] Implement SHOW TABLES for Data Source V2 Tables

2019-08-03 Thread GitBox
imback82 commented on a change in pull request #25247: [SPARK-28319][SQL] Implement SHOW TABLES for Data Source V2 Tables URL: https://github.com/apache/spark/pull/25247#discussion_r310341509 ## File path:

[GitHub] [spark] WeichenXu123 commented on a change in pull request #25235: [SPARK-28483][Core] Fix canceling a spark job using barrier mode but barrier tasks blocking on BarrierTaskContext.barrier()

2019-08-03 Thread GitBox
WeichenXu123 commented on a change in pull request #25235: [SPARK-28483][Core] Fix canceling a spark job using barrier mode but barrier tasks blocking on BarrierTaskContext.barrier() URL: https://github.com/apache/spark/pull/25235#discussion_r310346267 ## File path:

[GitHub] [spark] mgaido91 commented on issue #25189: [SPARK-28435][SQL] Support accepting the interval keyword in the schema string

2019-08-03 Thread GitBox
mgaido91 commented on issue #25189: [SPARK-28435][SQL] Support accepting the interval keyword in the schema string URL: https://github.com/apache/spark/pull/25189#issuecomment-517914638 I agree with @MaxGekk when he says: > I think we should support 2 separate data types for

[GitHub] [spark] maropu commented on a change in pull request #25253: [SPARK-28470][SQL] Cast to decimal throws ArithemticException on overflow

2019-08-03 Thread GitBox
maropu commented on a change in pull request #25253: [SPARK-28470][SQL] Cast to decimal throws ArithemticException on overflow URL: https://github.com/apache/spark/pull/25253#discussion_r310350265 ## File path:

[GitHub] [spark] maropu commented on a change in pull request #25253: [SPARK-28470][SQL] Cast to decimal throws ArithemticException on overflow

2019-08-03 Thread GitBox
maropu commented on a change in pull request #25253: [SPARK-28470][SQL] Cast to decimal throws ArithemticException on overflow URL: https://github.com/apache/spark/pull/25253#discussion_r310349825 ## File path:

[GitHub] [spark] maropu commented on a change in pull request #25253: [SPARK-28470][SQL] Cast to decimal throws ArithemticException on overflow

2019-08-03 Thread GitBox
maropu commented on a change in pull request #25253: [SPARK-28470][SQL] Cast to decimal throws ArithemticException on overflow URL: https://github.com/apache/spark/pull/25253#discussion_r310350023 ## File path:

[GitHub] [spark] yeshengm opened a new pull request #25346: [SPARK-25915][SQL] Replace grouping expressions with references in `aggregateExpressions` of logical `Aggregate`

2019-08-03 Thread GitBox
yeshengm opened a new pull request #25346: [SPARK-25915][SQL] Replace grouping expressions with references in `aggregateExpressions` of logical `Aggregate` URL: https://github.com/apache/spark/pull/25346 ## What changes were proposed in this pull request? (Please fill in changes

[GitHub] [spark] beliefer commented on a change in pull request #25309: [SPARK-28577][YARN]Resource capability requested for each executor add offHeapMemorySize

2019-08-03 Thread GitBox
beliefer commented on a change in pull request #25309: [SPARK-28577][YARN]Resource capability requested for each executor add offHeapMemorySize URL: https://github.com/apache/spark/pull/25309#discussion_r310344912 ## File path:

[GitHub] [spark] beliefer commented on a change in pull request #25309: [SPARK-28577][YARN]Resource capability requested for each executor add offHeapMemorySize

2019-08-03 Thread GitBox
beliefer commented on a change in pull request #25309: [SPARK-28577][YARN]Resource capability requested for each executor add offHeapMemorySize URL: https://github.com/apache/spark/pull/25309#discussion_r310344912 ## File path:

[GitHub] [spark] planga82 commented on issue #25319: [SPARK-28585][WebUI] Improve WebUI DAG information: Add extra info to rdd from spark plan

2019-08-03 Thread GitBox
planga82 commented on issue #25319: [SPARK-28585][WebUI] Improve WebUI DAG information: Add extra info to rdd from spark plan URL: https://github.com/apache/spark/pull/25319#issuecomment-517922262 Commenting offline this pull request we have reached the conclusion that the place that this

[GitHub] [spark] planga82 closed pull request #25319: [SPARK-28585][WebUI] Improve WebUI DAG information: Add extra info to rdd from spark plan

2019-08-03 Thread GitBox
planga82 closed pull request #25319: [SPARK-28585][WebUI] Improve WebUI DAG information: Add extra info to rdd from spark plan URL: https://github.com/apache/spark/pull/25319 This is an automated message from the Apache Git

[GitHub] [spark] WeichenXu123 commented on issue #25294: [WIP][SPARK-28476][SQL] Support ALTER DATABASE SET LOCATION

2019-08-03 Thread GitBox
WeichenXu123 commented on issue #25294: [WIP][SPARK-28476][SQL] Support ALTER DATABASE SET LOCATION URL: https://github.com/apache/spark/pull/25294#issuecomment-517914267 Jenkins, retest this please. This is an automated

[GitHub] [spark] mgaido91 commented on issue #21599: [SPARK-26218][SQL] Overflow on arithmetic operations returns incorrect result

2019-08-03 Thread GitBox
mgaido91 commented on issue #21599: [SPARK-26218][SQL] Overflow on arithmetic operations returns incorrect result URL: https://github.com/apache/spark/pull/21599#issuecomment-517903452 thank you all for your great help on this!

[GitHub] [spark] mgaido91 opened a new pull request #25347: [SPARK-28610][SQL] Allow having a decimal buffer for long sum

2019-08-03 Thread GitBox
mgaido91 opened a new pull request #25347: [SPARK-28610][SQL] Allow having a decimal buffer for long sum URL: https://github.com/apache/spark/pull/25347 ## What changes were proposed in this pull request? If `spark.sql.arithmeticOperations.failOnOverFlow` is `true` temporary

[GitHub] [spark] viirya commented on a change in pull request #25340: [SPARK-28393][SQL][PYTHON][TESTS] Convert and port 'pgSQL/join.sql' into UDF test base

2019-08-03 Thread GitBox
viirya commented on a change in pull request #25340: [SPARK-28393][SQL][PYTHON][TESTS] Convert and port 'pgSQL/join.sql' into UDF test base URL: https://github.com/apache/spark/pull/25340#discussion_r310341346 ## File path:

[GitHub] [spark] viirya commented on a change in pull request #25340: [SPARK-28393][SQL][PYTHON][TESTS] Convert and port 'pgSQL/join.sql' into UDF test base

2019-08-03 Thread GitBox
viirya commented on a change in pull request #25340: [SPARK-28393][SQL][PYTHON][TESTS] Convert and port 'pgSQL/join.sql' into UDF test base URL: https://github.com/apache/spark/pull/25340#discussion_r310341375 ## File path:

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25345: [SPARK-28609][DOC] Fix broken styles/links and make up-to-date

2019-08-03 Thread GitBox
dongjoon-hyun commented on a change in pull request #25345: [SPARK-28609][DOC] Fix broken styles/links and make up-to-date URL: https://github.com/apache/spark/pull/25345#discussion_r310340148 ## File path: docs/building-spark.md ## @@ -241,8 +241,8 @@ The run-tests

[GitHub] [spark] mgaido91 commented on issue #25253: [SPARK-28470][SQL] Cast to decimal throws ArithemticException on overflow

2019-08-03 Thread GitBox
mgaido91 commented on issue #25253: [SPARK-28470][SQL] Cast to decimal throws ArithemticException on overflow URL: https://github.com/apache/spark/pull/25253#issuecomment-517903948 cc @cloud-fan @JoshRosen @maropu This is

[GitHub] [spark] AmplabJenkins commented on issue #25346: [RFC][WIP][SPARK-25915][SQL] Replace grouping expressions with references in `aggregateExpressions` of logical `Aggregate`

2019-08-03 Thread GitBox
AmplabJenkins commented on issue #25346: [RFC][WIP][SPARK-25915][SQL] Replace grouping expressions with references in `aggregateExpressions` of logical `Aggregate` URL: https://github.com/apache/spark/pull/25346#issuecomment-517907472 Can one of the admins verify this patch?

[GitHub] [spark] beliefer commented on a change in pull request #25309: [SPARK-28577][YARN]Resource capability requested for each executor add offHeapMemorySize

2019-08-03 Thread GitBox
beliefer commented on a change in pull request #25309: [SPARK-28577][YARN]Resource capability requested for each executor add offHeapMemorySize URL: https://github.com/apache/spark/pull/25309#discussion_r310344844 ## File path:

[GitHub] [spark] maropu commented on a change in pull request #25253: [SPARK-28470][SQL] Cast to decimal throws ArithemticException on overflow

2019-08-03 Thread GitBox
maropu commented on a change in pull request #25253: [SPARK-28470][SQL] Cast to decimal throws ArithemticException on overflow URL: https://github.com/apache/spark/pull/25253#discussion_r310350262 ## File path:

[GitHub] [spark] maropu commented on a change in pull request #25253: [SPARK-28470][SQL] Cast to decimal throws ArithemticException on overflow

2019-08-03 Thread GitBox
maropu commented on a change in pull request #25253: [SPARK-28470][SQL] Cast to decimal throws ArithemticException on overflow URL: https://github.com/apache/spark/pull/25253#discussion_r310350181 ## File path:

[GitHub] [spark] maropu commented on a change in pull request #25253: [SPARK-28470][SQL] Cast to decimal throws ArithemticException on overflow

2019-08-03 Thread GitBox
maropu commented on a change in pull request #25253: [SPARK-28470][SQL] Cast to decimal throws ArithemticException on overflow URL: https://github.com/apache/spark/pull/25253#discussion_r310350141 ## File path:

[GitHub] [spark] SparkQA removed a comment on issue #25136: [SPARK-28322][SQL] Add support to Decimal type for integral divide

2019-08-03 Thread GitBox
SparkQA removed a comment on issue #25136: [SPARK-28322][SQL] Add support to Decimal type for integral divide URL: https://github.com/apache/spark/pull/25136#issuecomment-517961457 **[Test build #108601 has

[GitHub] [spark] AmplabJenkins commented on issue #25347: [SPARK-28610][SQL] Allow having a decimal buffer for long sum

2019-08-03 Thread GitBox
AmplabJenkins commented on issue #25347: [SPARK-28610][SQL] Allow having a decimal buffer for long sum URL: https://github.com/apache/spark/pull/25347#issuecomment-517961672 Merged build finished. Test FAILed. This is an

[GitHub] [spark] AmplabJenkins removed a comment on issue #25136: [SPARK-28322][SQL] Add support to Decimal type for integral divide

2019-08-03 Thread GitBox
AmplabJenkins removed a comment on issue #25136: [SPARK-28322][SQL] Add support to Decimal type for integral divide URL: https://github.com/apache/spark/pull/25136#issuecomment-517961643 Merged build finished. Test FAILed.

[GitHub] [spark] SparkQA commented on issue #25347: [SPARK-28610][SQL] Allow having a decimal buffer for long sum

2019-08-03 Thread GitBox
SparkQA commented on issue #25347: [SPARK-28610][SQL] Allow having a decimal buffer for long sum URL: https://github.com/apache/spark/pull/25347#issuecomment-517961670 **[Test build #108605 has

[GitHub] [spark] AmplabJenkins commented on issue #25347: [SPARK-28610][SQL] Allow having a decimal buffer for long sum

2019-08-03 Thread GitBox
AmplabJenkins commented on issue #25347: [SPARK-28610][SQL] Allow having a decimal buffer for long sum URL: https://github.com/apache/spark/pull/25347#issuecomment-517961675 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #25347: [SPARK-28610][SQL] Allow having a decimal buffer for long sum

2019-08-03 Thread GitBox
AmplabJenkins removed a comment on issue #25347: [SPARK-28610][SQL] Allow having a decimal buffer for long sum URL: https://github.com/apache/spark/pull/25347#issuecomment-517961672 Merged build finished. Test FAILed. This

[GitHub] [spark] AmplabJenkins removed a comment on issue #25347: [SPARK-28610][SQL] Allow having a decimal buffer for long sum

2019-08-03 Thread GitBox
AmplabJenkins removed a comment on issue #25347: [SPARK-28610][SQL] Allow having a decimal buffer for long sum URL: https://github.com/apache/spark/pull/25347#issuecomment-517961675 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA removed a comment on issue #25347: [SPARK-28610][SQL] Allow having a decimal buffer for long sum

2019-08-03 Thread GitBox
SparkQA removed a comment on issue #25347: [SPARK-28610][SQL] Allow having a decimal buffer for long sum URL: https://github.com/apache/spark/pull/25347#issuecomment-517961414 **[Test build #108605 has

[GitHub] [spark] AmplabJenkins removed a comment on issue #25136: [SPARK-28322][SQL] Add support to Decimal type for integral divide

2019-08-03 Thread GitBox
AmplabJenkins removed a comment on issue #25136: [SPARK-28322][SQL] Add support to Decimal type for integral divide URL: https://github.com/apache/spark/pull/25136#issuecomment-517961645 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #25345: [SPARK-28609][DOC] Fix broken styles/links and make up-to-date

2019-08-03 Thread GitBox
AmplabJenkins commented on issue #25345: [SPARK-28609][DOC] Fix broken styles/links and make up-to-date URL: https://github.com/apache/spark/pull/25345#issuecomment-517962192 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA commented on issue #25345: [SPARK-28609][DOC] Fix broken styles/links and make up-to-date

2019-08-03 Thread GitBox
SparkQA commented on issue #25345: [SPARK-28609][DOC] Fix broken styles/links and make up-to-date URL: https://github.com/apache/spark/pull/25345#issuecomment-517962167 **[Test build #108598 has

[GitHub] [spark] AmplabJenkins commented on issue #25345: [SPARK-28609][DOC] Fix broken styles/links and make up-to-date

2019-08-03 Thread GitBox
AmplabJenkins commented on issue #25345: [SPARK-28609][DOC] Fix broken styles/links and make up-to-date URL: https://github.com/apache/spark/pull/25345#issuecomment-517962191 Merged build finished. Test PASSed. This is an

[GitHub] [spark] srowen commented on issue #25335: [SPARK-28601][CORE][SQL][test-hadoop3.2] Use StandardCharsets.UTF_8 instead of "UTF-8" string representation, and get rid of UnsupportedEncodingExcep

2019-08-03 Thread GitBox
srowen commented on issue #25335: [SPARK-28601][CORE][SQL][test-hadoop3.2] Use StandardCharsets.UTF_8 instead of "UTF-8" string representation, and get rid of UnsupportedEncodingException URL: https://github.com/apache/spark/pull/25335#issuecomment-517962169 Oh I see your point. Can you

[GitHub] [spark] SparkQA removed a comment on issue #25345: [SPARK-28609][DOC] Fix broken styles/links and make up-to-date

2019-08-03 Thread GitBox
SparkQA removed a comment on issue #25345: [SPARK-28609][DOC] Fix broken styles/links and make up-to-date URL: https://github.com/apache/spark/pull/25345#issuecomment-517961441 **[Test build #108598 has

[GitHub] [spark] AmplabJenkins removed a comment on issue #22743: [SPARK-25740][SQL] Refactor DetermineTableStats to invalidate cache when some configuration changed

2019-08-03 Thread GitBox
AmplabJenkins removed a comment on issue #22743: [SPARK-25740][SQL] Refactor DetermineTableStats to invalidate cache when some configuration changed URL: https://github.com/apache/spark/pull/22743#issuecomment-517962760 Test FAILed. Refer to this link for build results (access rights to

[GitHub] [spark] imback82 commented on a change in pull request #25247: [SPARK-28319][SQL] Implement SHOW TABLES for Data Source V2 Tables

2019-08-03 Thread GitBox
imback82 commented on a change in pull request #25247: [SPARK-28319][SQL] Implement SHOW TABLES for Data Source V2 Tables URL: https://github.com/apache/spark/pull/25247#discussion_r310365926 ## File path:

[GitHub] [spark] SparkQA commented on issue #25294: [WIP][SPARK-28476][SQL] Support ALTER DATABASE SET LOCATION

2019-08-03 Thread GitBox
SparkQA commented on issue #25294: [WIP][SPARK-28476][SQL] Support ALTER DATABASE SET LOCATION URL: https://github.com/apache/spark/pull/25294#issuecomment-517965029 **[Test build #108596 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/108596/testReport)**

[GitHub] [spark] HyukjinKwon commented on issue #25334: [SPARK-28598][SQL][WIP] Few date time manipulation functions does not provide versions supporting Column as input through the Dataframe API

2019-08-03 Thread GitBox
HyukjinKwon commented on issue #25334: [SPARK-28598][SQL][WIP] Few date time manipulation functions does not provide versions supporting Column as input through the Dataframe API URL: https://github.com/apache/spark/pull/25334#issuecomment-517964998 ok to test

[GitHub] [spark] SparkQA removed a comment on issue #25294: [WIP][SPARK-28476][SQL] Support ALTER DATABASE SET LOCATION

2019-08-03 Thread GitBox
SparkQA removed a comment on issue #25294: [WIP][SPARK-28476][SQL] Support ALTER DATABASE SET LOCATION URL: https://github.com/apache/spark/pull/25294#issuecomment-517961416 **[Test build #108596 has

[GitHub] [spark] AmplabJenkins removed a comment on issue #25294: [WIP][SPARK-28476][SQL] Support ALTER DATABASE SET LOCATION

2019-08-03 Thread GitBox
AmplabJenkins removed a comment on issue #25294: [WIP][SPARK-28476][SQL] Support ALTER DATABASE SET LOCATION URL: https://github.com/apache/spark/pull/25294#issuecomment-517965044 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #25294: [WIP][SPARK-28476][SQL] Support ALTER DATABASE SET LOCATION

2019-08-03 Thread GitBox
AmplabJenkins removed a comment on issue #25294: [WIP][SPARK-28476][SQL] Support ALTER DATABASE SET LOCATION URL: https://github.com/apache/spark/pull/25294#issuecomment-517965043 Merged build finished. Test FAILed. This is

[GitHub] [spark] AmplabJenkins commented on issue #25294: [WIP][SPARK-28476][SQL] Support ALTER DATABASE SET LOCATION

2019-08-03 Thread GitBox
AmplabJenkins commented on issue #25294: [WIP][SPARK-28476][SQL] Support ALTER DATABASE SET LOCATION URL: https://github.com/apache/spark/pull/25294#issuecomment-517965043 Merged build finished. Test FAILed. This is an

[GitHub] [spark] AmplabJenkins commented on issue #25294: [WIP][SPARK-28476][SQL] Support ALTER DATABASE SET LOCATION

2019-08-03 Thread GitBox
AmplabJenkins commented on issue #25294: [WIP][SPARK-28476][SQL] Support ALTER DATABASE SET LOCATION URL: https://github.com/apache/spark/pull/25294#issuecomment-517965044 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #25294: [WIP][SPARK-28476][SQL] Support ALTER DATABASE SET LOCATION

2019-08-03 Thread GitBox
AmplabJenkins removed a comment on issue #25294: [WIP][SPARK-28476][SQL] Support ALTER DATABASE SET LOCATION URL: https://github.com/apache/spark/pull/25294#issuecomment-517965183 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #25294: [WIP][SPARK-28476][SQL] Support ALTER DATABASE SET LOCATION

2019-08-03 Thread GitBox
AmplabJenkins commented on issue #25294: [WIP][SPARK-28476][SQL] Support ALTER DATABASE SET LOCATION URL: https://github.com/apache/spark/pull/25294#issuecomment-517966026 Merged build finished. Test FAILed. This is an

[GitHub] [spark] SparkQA commented on issue #25294: [WIP][SPARK-28476][SQL] Support ALTER DATABASE SET LOCATION

2019-08-03 Thread GitBox
SparkQA commented on issue #25294: [WIP][SPARK-28476][SQL] Support ALTER DATABASE SET LOCATION URL: https://github.com/apache/spark/pull/25294#issuecomment-517966005 **[Test build #108597 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/108597/testReport)**

[GitHub] [spark] SparkQA removed a comment on issue #25294: [WIP][SPARK-28476][SQL] Support ALTER DATABASE SET LOCATION

2019-08-03 Thread GitBox
SparkQA removed a comment on issue #25294: [WIP][SPARK-28476][SQL] Support ALTER DATABASE SET LOCATION URL: https://github.com/apache/spark/pull/25294#issuecomment-517961455 **[Test build #108597 has

[GitHub] [spark] SparkQA removed a comment on issue #25310: [SPARK-28578][INFRA] Improve Github pull request template

2019-08-03 Thread GitBox
SparkQA removed a comment on issue #25310: [SPARK-28578][INFRA] Improve Github pull request template URL: https://github.com/apache/spark/pull/25310#issuecomment-517961454 **[Test build #108609 has

[GitHub] [spark] AmplabJenkins removed a comment on issue #25294: [WIP][SPARK-28476][SQL] Support ALTER DATABASE SET LOCATION

2019-08-03 Thread GitBox
AmplabJenkins removed a comment on issue #25294: [WIP][SPARK-28476][SQL] Support ALTER DATABASE SET LOCATION URL: https://github.com/apache/spark/pull/25294#issuecomment-517966026 Merged build finished. Test FAILed. This is

[GitHub] [spark] AmplabJenkins commented on issue #25294: [WIP][SPARK-28476][SQL] Support ALTER DATABASE SET LOCATION

2019-08-03 Thread GitBox
AmplabJenkins commented on issue #25294: [WIP][SPARK-28476][SQL] Support ALTER DATABASE SET LOCATION URL: https://github.com/apache/spark/pull/25294#issuecomment-517966027 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA commented on issue #25310: [SPARK-28578][INFRA] Improve Github pull request template

2019-08-03 Thread GitBox
SparkQA commented on issue #25310: [SPARK-28578][INFRA] Improve Github pull request template URL: https://github.com/apache/spark/pull/25310#issuecomment-517966051 **[Test build #108609 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/108609/testReport)**

[GitHub] [spark] AmplabJenkins removed a comment on issue #25310: [SPARK-28578][INFRA] Improve Github pull request template

2019-08-03 Thread GitBox
AmplabJenkins removed a comment on issue #25310: [SPARK-28578][INFRA] Improve Github pull request template URL: https://github.com/apache/spark/pull/25310#issuecomment-517967699 Merged build finished. Test PASSed. This is an

[GitHub] [spark] AmplabJenkins removed a comment on issue #25310: [SPARK-28578][INFRA] Improve Github pull request template

2019-08-03 Thread GitBox
AmplabJenkins removed a comment on issue #25310: [SPARK-28578][INFRA] Improve Github pull request template URL: https://github.com/apache/spark/pull/25310#issuecomment-517967700 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA commented on issue #25335: [SPARK-28601][CORE][SQL][test-hadoop3.2] Use StandardCharsets.UTF_8 instead of "UTF-8" string representation, and get rid of UnsupportedEncodingExce

2019-08-03 Thread GitBox
SparkQA commented on issue #25335: [SPARK-28601][CORE][SQL][test-hadoop3.2] Use StandardCharsets.UTF_8 instead of "UTF-8" string representation, and get rid of UnsupportedEncodingException URL: https://github.com/apache/spark/pull/25335#issuecomment-517968079 **[Test build #108612 has

[GitHub] [spark] SparkQA removed a comment on issue #25335: [SPARK-28601][CORE][SQL][test-hadoop3.2] Use StandardCharsets.UTF_8 instead of "UTF-8" string representation, and get rid of UnsupportedEnco

2019-08-03 Thread GitBox
SparkQA removed a comment on issue #25335: [SPARK-28601][CORE][SQL][test-hadoop3.2] Use StandardCharsets.UTF_8 instead of "UTF-8" string representation, and get rid of UnsupportedEncodingException URL: https://github.com/apache/spark/pull/25335#issuecomment-517961440 **[Test build #108612

[GitHub] [spark] imback82 commented on a change in pull request #25247: [SPARK-28319][SQL] Implement SHOW TABLES for Data Source V2 Tables

2019-08-03 Thread GitBox
imback82 commented on a change in pull request #25247: [SPARK-28319][SQL] Implement SHOW TABLES for Data Source V2 Tables URL: https://github.com/apache/spark/pull/25247#discussion_r310366894 ## File path:

[GitHub] [spark] WeichenXu123 commented on a change in pull request #25235: [SPARK-28483][Core] Fix canceling a spark job using barrier mode but barrier tasks blocking on BarrierTaskContext.barrier()

2019-08-03 Thread GitBox
WeichenXu123 commented on a change in pull request #25235: [SPARK-28483][Core] Fix canceling a spark job using barrier mode but barrier tasks blocking on BarrierTaskContext.barrier() URL: https://github.com/apache/spark/pull/25235#discussion_r310368754 ## File path:

[GitHub] [spark] SparkQA commented on issue #25214: [SPARK-28461][SQL] Pad Decimal numbers with trailing zeros to the scale of the column

2019-08-03 Thread GitBox
SparkQA commented on issue #25214: [SPARK-28461][SQL] Pad Decimal numbers with trailing zeros to the scale of the column URL: https://github.com/apache/spark/pull/25214#issuecomment-517970788 **[Test build #108600 has

[GitHub] [spark] SparkQA removed a comment on issue #25214: [SPARK-28461][SQL] Pad Decimal numbers with trailing zeros to the scale of the column

2019-08-03 Thread GitBox
SparkQA removed a comment on issue #25214: [SPARK-28461][SQL] Pad Decimal numbers with trailing zeros to the scale of the column URL: https://github.com/apache/spark/pull/25214#issuecomment-517961438 **[Test build #108600 has

[GitHub] [spark] AmplabJenkins commented on issue #25214: [SPARK-28461][SQL] Pad Decimal numbers with trailing zeros to the scale of the column

2019-08-03 Thread GitBox
AmplabJenkins commented on issue #25214: [SPARK-28461][SQL] Pad Decimal numbers with trailing zeros to the scale of the column URL: https://github.com/apache/spark/pull/25214#issuecomment-517970877 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #25214: [SPARK-28461][SQL] Pad Decimal numbers with trailing zeros to the scale of the column

2019-08-03 Thread GitBox
AmplabJenkins removed a comment on issue #25214: [SPARK-28461][SQL] Pad Decimal numbers with trailing zeros to the scale of the column URL: https://github.com/apache/spark/pull/25214#issuecomment-517970876 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #25214: [SPARK-28461][SQL] Pad Decimal numbers with trailing zeros to the scale of the column

2019-08-03 Thread GitBox
AmplabJenkins commented on issue #25214: [SPARK-28461][SQL] Pad Decimal numbers with trailing zeros to the scale of the column URL: https://github.com/apache/spark/pull/25214#issuecomment-517970876 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #25214: [SPARK-28461][SQL] Pad Decimal numbers with trailing zeros to the scale of the column

2019-08-03 Thread GitBox
AmplabJenkins removed a comment on issue #25214: [SPARK-28461][SQL] Pad Decimal numbers with trailing zeros to the scale of the column URL: https://github.com/apache/spark/pull/25214#issuecomment-517970877 Test PASSed. Refer to this link for build results (access rights to CI server

[GitHub] [spark] SparkQA commented on issue #25256: [SPARK-28514][ML] Remove the redundant transformImpl method in RF & GBT

2019-08-03 Thread GitBox
SparkQA commented on issue #25256: [SPARK-28514][ML] Remove the redundant transformImpl method in RF & GBT URL: https://github.com/apache/spark/pull/25256#issuecomment-517971404 **[Test build #108618 has

[GitHub] [spark] AmplabJenkins removed a comment on issue #25256: [SPARK-28514][ML] Remove the redundant transformImpl method in RF & GBT

2019-08-03 Thread GitBox
AmplabJenkins removed a comment on issue #25256: [SPARK-28514][ML] Remove the redundant transformImpl method in RF & GBT URL: https://github.com/apache/spark/pull/25256#issuecomment-517971658 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA commented on issue #25324: [SPARK-21481][ML][FOLLOWUP] HashingTF Cleanup and Tiny Optimizations

2019-08-03 Thread GitBox
SparkQA commented on issue #25324: [SPARK-21481][ML][FOLLOWUP] HashingTF Cleanup and Tiny Optimizations URL: https://github.com/apache/spark/pull/25324#issuecomment-517971687 **[Test build #108619 has

[GitHub] [spark] AmplabJenkins removed a comment on issue #25324: [SPARK-21481][ML][FOLLOWUP] HashingTF Cleanup and Tiny Optimizations

2019-08-03 Thread GitBox
AmplabJenkins removed a comment on issue #25324: [SPARK-21481][ML][FOLLOWUP] HashingTF Cleanup and Tiny Optimizations URL: https://github.com/apache/spark/pull/25324#issuecomment-517971963 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #25324: [SPARK-21481][ML][FOLLOWUP] HashingTF Cleanup and Tiny Optimizations

2019-08-03 Thread GitBox
AmplabJenkins removed a comment on issue #25324: [SPARK-21481][ML][FOLLOWUP] HashingTF Cleanup and Tiny Optimizations URL: https://github.com/apache/spark/pull/25324#issuecomment-517971959 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #25324: [SPARK-21481][ML][FOLLOWUP] HashingTF Cleanup and Tiny Optimizations

2019-08-03 Thread GitBox
AmplabJenkins commented on issue #25324: [SPARK-21481][ML][FOLLOWUP] HashingTF Cleanup and Tiny Optimizations URL: https://github.com/apache/spark/pull/25324#issuecomment-517971963 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #25324: [SPARK-21481][ML][FOLLOWUP] HashingTF Cleanup and Tiny Optimizations

2019-08-03 Thread GitBox
AmplabJenkins commented on issue #25324: [SPARK-21481][ML][FOLLOWUP] HashingTF Cleanup and Tiny Optimizations URL: https://github.com/apache/spark/pull/25324#issuecomment-517971959 Merged build finished. Test PASSed. This is

[GitHub] [spark] SparkQA commented on issue #25324: [SPARK-21481][ML][FOLLOWUP] HashingTF Cleanup and Tiny Optimizations

2019-08-03 Thread GitBox
SparkQA commented on issue #25324: [SPARK-21481][ML][FOLLOWUP] HashingTF Cleanup and Tiny Optimizations URL: https://github.com/apache/spark/pull/25324#issuecomment-517973983 **[Test build #108619 has

[GitHub] [spark] SparkQA removed a comment on issue #25324: [SPARK-21481][ML][FOLLOWUP] HashingTF Cleanup and Tiny Optimizations

2019-08-03 Thread GitBox
SparkQA removed a comment on issue #25324: [SPARK-21481][ML][FOLLOWUP] HashingTF Cleanup and Tiny Optimizations URL: https://github.com/apache/spark/pull/25324#issuecomment-517971687 **[Test build #108619 has

[GitHub] [spark] AmplabJenkins removed a comment on issue #25324: [SPARK-21481][ML][FOLLOWUP] HashingTF Cleanup and Tiny Optimizations

2019-08-03 Thread GitBox
AmplabJenkins removed a comment on issue #25324: [SPARK-21481][ML][FOLLOWUP] HashingTF Cleanup and Tiny Optimizations URL: https://github.com/apache/spark/pull/25324#issuecomment-517974031 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #25324: [SPARK-21481][ML][FOLLOWUP] HashingTF Cleanup and Tiny Optimizations

2019-08-03 Thread GitBox
AmplabJenkins removed a comment on issue #25324: [SPARK-21481][ML][FOLLOWUP] HashingTF Cleanup and Tiny Optimizations URL: https://github.com/apache/spark/pull/25324#issuecomment-517974036 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #25324: [SPARK-21481][ML][FOLLOWUP] HashingTF Cleanup and Tiny Optimizations

2019-08-03 Thread GitBox
AmplabJenkins commented on issue #25324: [SPARK-21481][ML][FOLLOWUP] HashingTF Cleanup and Tiny Optimizations URL: https://github.com/apache/spark/pull/25324#issuecomment-517974031 Merged build finished. Test PASSed. This is

[GitHub] [spark] AmplabJenkins commented on issue #25324: [SPARK-21481][ML][FOLLOWUP] HashingTF Cleanup and Tiny Optimizations

2019-08-03 Thread GitBox
AmplabJenkins commented on issue #25324: [SPARK-21481][ML][FOLLOWUP] HashingTF Cleanup and Tiny Optimizations URL: https://github.com/apache/spark/pull/25324#issuecomment-517974036 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] srowen commented on issue #20677: [MINOR][DOC][SS] Event time can't be greater then processing time. 12:21, owl. Mistakeā€¦

2019-08-03 Thread GitBox
srowen commented on issue #20677: [MINOR][DOC][SS] Event time can't be greater then processing time. 12:21, owl. Mistakeā€¦ URL: https://github.com/apache/spark/pull/20677#issuecomment-517929930 The example isn't impossible, it just shows, twice, that an event arrives with a timestamp in

[GitHub] [spark] mgaido91 commented on issue #25337: [SPARK-28604][ML] Use log1p(x) over log(1+x) and expm1(x) over exp(x)-1 for accuracy

2019-08-03 Thread GitBox
mgaido91 commented on issue #25337: [SPARK-28604][ML] Use log1p(x) over log(1+x) and expm1(x) over exp(x)-1 for accuracy URL: https://github.com/apache/spark/pull/25337#issuecomment-517933160 LGTM This is an automated

[GitHub] [spark] LuciferYang commented on a change in pull request #25309: [SPARK-28577][YARN]Resource capability requested for each executor add offHeapMemorySize

2019-08-03 Thread GitBox
LuciferYang commented on a change in pull request #25309: [SPARK-28577][YARN]Resource capability requested for each executor add offHeapMemorySize URL: https://github.com/apache/spark/pull/25309#discussion_r310355911 ## File path:

[GitHub] [spark] AmplabJenkins commented on issue #25338: [MINOR] Fix typos in comments and replace an explicit type with <>

2019-08-03 Thread GitBox
AmplabJenkins commented on issue #25338: [MINOR] Fix typos in comments and replace an explicit type with <> URL: https://github.com/apache/spark/pull/25338#issuecomment-517939417 Can one of the admins verify this patch? This

[GitHub] [spark] HyukjinKwon commented on issue #25335: [SPARK-28601][CORE][SQL][test-hadoop3.2] Use StandardCharsets.UTF_8 instead of "UTF-8" string representation, and get rid of UnsupportedEncoding

2019-08-03 Thread GitBox
HyukjinKwon commented on issue #25335: [SPARK-28601][CORE][SQL][test-hadoop3.2] Use StandardCharsets.UTF_8 instead of "UTF-8" string representation, and get rid of UnsupportedEncodingException URL: https://github.com/apache/spark/pull/25335#issuecomment-517957877 retest this please

[GitHub] [spark] brkyvz opened a new pull request #25348: [RFC][SPARK-28554][SQL] Adds a v1 fallback writer implementation for v2 data source codepaths

2019-08-03 Thread GitBox
brkyvz opened a new pull request #25348: [RFC][SPARK-28554][SQL] Adds a v1 fallback writer implementation for v2 data source codepaths URL: https://github.com/apache/spark/pull/25348 ## What changes were proposed in this pull request? This PR adds a V1 fallback interface for writing

[GitHub] [spark] brkyvz commented on issue #25291: [SPARK-28554][SQL] implement basic catalog functionalities for JDBC v2 with a DS v1 fallback API

2019-08-03 Thread GitBox
brkyvz commented on issue #25291: [SPARK-28554][SQL] implement basic catalog functionalities for JDBC v2 with a DS v1 fallback API URL: https://github.com/apache/spark/pull/25291#issuecomment-517958687 FYI, I made an alternative proposal in #25348

[GitHub] [spark] HeartSaVioR commented on issue #25335: [SPARK-28601][CORE][SQL][test-hadoop3.2] Use StandardCharsets.UTF_8 instead of "UTF-8" string representation, and get rid of UnsupportedEncoding

2019-08-03 Thread GitBox
HeartSaVioR commented on issue #25335: [SPARK-28601][CORE][SQL][test-hadoop3.2] Use StandardCharsets.UTF_8 instead of "UTF-8" string representation, and get rid of UnsupportedEncodingException URL: https://github.com/apache/spark/pull/25335#issuecomment-517960815 This patch touches

[GitHub] [spark] AmplabJenkins commented on issue #25294: [WIP][SPARK-28476][SQL] Support ALTER DATABASE SET LOCATION

2019-08-03 Thread GitBox
AmplabJenkins commented on issue #25294: [WIP][SPARK-28476][SQL] Support ALTER DATABASE SET LOCATION URL: https://github.com/apache/spark/pull/25294#issuecomment-517961445 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA commented on issue #25294: [WIP][SPARK-28476][SQL] Support ALTER DATABASE SET LOCATION

2019-08-03 Thread GitBox
SparkQA commented on issue #25294: [WIP][SPARK-28476][SQL] Support ALTER DATABASE SET LOCATION URL: https://github.com/apache/spark/pull/25294#issuecomment-517961425 **[Test build #108599 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/108599/testReport)**

[GitHub] [spark] AmplabJenkins commented on issue #25294: [WIP][SPARK-28476][SQL] Support ALTER DATABASE SET LOCATION

2019-08-03 Thread GitBox
AmplabJenkins commented on issue #25294: [WIP][SPARK-28476][SQL] Support ALTER DATABASE SET LOCATION URL: https://github.com/apache/spark/pull/25294#issuecomment-517961443 Merged build finished. Test PASSed. This is an

[GitHub] [spark] AmplabJenkins removed a comment on issue #25346: [RFC][WIP][SPARK-25915][SQL] Replace grouping expressions with references in `aggregateExpressions` of logical `Aggregate`

2019-08-03 Thread GitBox
AmplabJenkins removed a comment on issue #25346: [RFC][WIP][SPARK-25915][SQL] Replace grouping expressions with references in `aggregateExpressions` of logical `Aggregate` URL: https://github.com/apache/spark/pull/25346#issuecomment-517961374 Test PASSed. Refer to this link for build

[GitHub] [spark] AmplabJenkins commented on issue #25253: [SPARK-28470][SQL] Cast to decimal throws ArithemticException on overflow

2019-08-03 Thread GitBox
AmplabJenkins commented on issue #25253: [SPARK-28470][SQL] Cast to decimal throws ArithemticException on overflow URL: https://github.com/apache/spark/pull/25253#issuecomment-517961474 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #25335: [SPARK-28601][CORE][SQL][test-hadoop3.2] Use StandardCharsets.UTF_8 instead of "UTF-8" string representation, and get rid of UnsupportedEncodi

2019-08-03 Thread GitBox
AmplabJenkins commented on issue #25335: [SPARK-28601][CORE][SQL][test-hadoop3.2] Use StandardCharsets.UTF_8 instead of "UTF-8" string representation, and get rid of UnsupportedEncodingException URL: https://github.com/apache/spark/pull/25335#issuecomment-517961470 Merged build finished.

[GitHub] [spark] AmplabJenkins commented on issue #25310: [SPARK-28578][INFRA] Improve Github pull request template

2019-08-03 Thread GitBox
AmplabJenkins commented on issue #25310: [SPARK-28578][INFRA] Improve Github pull request template URL: https://github.com/apache/spark/pull/25310#issuecomment-517961450 Merged build finished. Test PASSed. This is an

[GitHub] [spark] AmplabJenkins removed a comment on issue #25346: [RFC][WIP][SPARK-25915][SQL] Replace grouping expressions with references in `aggregateExpressions` of logical `Aggregate`

2019-08-03 Thread GitBox
AmplabJenkins removed a comment on issue #25346: [RFC][WIP][SPARK-25915][SQL] Replace grouping expressions with references in `aggregateExpressions` of logical `Aggregate` URL: https://github.com/apache/spark/pull/25346#issuecomment-517961371 Test PASSed. Refer to this link for build

[GitHub] [spark] AmplabJenkins commented on issue #25310: [SPARK-28578][INFRA] Improve Github pull request template

2019-08-03 Thread GitBox
AmplabJenkins commented on issue #25310: [SPARK-28578][INFRA] Improve Github pull request template URL: https://github.com/apache/spark/pull/25310#issuecomment-517961453 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA commented on issue #25345: [SPARK-28609][DOC] Fix broken styles/links and make up-to-date

2019-08-03 Thread GitBox
SparkQA commented on issue #25345: [SPARK-28609][DOC] Fix broken styles/links and make up-to-date URL: https://github.com/apache/spark/pull/25345#issuecomment-517961441 **[Test build #108598 has

[GitHub] [spark] SparkQA commented on issue #25294: [WIP][SPARK-28476][SQL] Support ALTER DATABASE SET LOCATION

2019-08-03 Thread GitBox
SparkQA commented on issue #25294: [WIP][SPARK-28476][SQL] Support ALTER DATABASE SET LOCATION URL: https://github.com/apache/spark/pull/25294#issuecomment-517961416 **[Test build #108596 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/108596/testReport)**

[GitHub] [spark] SparkQA commented on issue #25253: [SPARK-28470][SQL] Cast to decimal throws ArithemticException on overflow

2019-08-03 Thread GitBox
SparkQA commented on issue #25253: [SPARK-28470][SQL] Cast to decimal throws ArithemticException on overflow URL: https://github.com/apache/spark/pull/25253#issuecomment-517961466 **[Test build #108611 has

  1   2   3   4   >