SparkQA commented on pull request #27803:
URL: https://github.com/apache/spark/pull/27803#issuecomment-619970194
**[Test build #121883 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121883/testReport)**
for PR 27803 at commit
SparkQA commented on pull request #28294:
URL: https://github.com/apache/spark/pull/28294#issuecomment-619969970
**[Test build #121903 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121903/testReport)**
for PR 28294 at commit
SparkQA removed a comment on pull request #27019:
URL: https://github.com/apache/spark/pull/27019#issuecomment-619775791
**[Test build #121881 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121881/testReport)**
for PR 27019 at commit
AmplabJenkins removed a comment on pull request #28326:
URL: https://github.com/apache/spark/pull/28326#issuecomment-620006474
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #28362:
URL: https://github.com/apache/spark/pull/28362#issuecomment-619942415
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins removed a comment on pull request #28362:
URL: https://github.com/apache/spark/pull/28362#issuecomment-619942415
This is an automated message from the Apache Git Service.
To respond to the message, please log on
SparkQA commented on pull request #28368:
URL: https://github.com/apache/spark/pull/28368#issuecomment-619943154
**[Test build #121901 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121901/testReport)**
for PR 28368 at commit
AmplabJenkins commented on pull request #28368:
URL: https://github.com/apache/spark/pull/28368#issuecomment-619943464
Can one of the admins verify this patch?
This is an automated message from the Apache Git Service.
To
gaborgsomogyi commented on a change in pull request #28368:
URL: https://github.com/apache/spark/pull/28368#discussion_r415756591
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/connection/SecureConnectionProvider.scala
##
@@ -26,6 +26,12
yaooqinn opened a new pull request #28369:
URL: https://github.com/apache/spark/pull/28369
### What changes were proposed in this pull request?
With https://github.com/apache/spark/pull/28310, the operation of date +/-
interval(m, d, 0) has been improved a lot, about 75% time cost is
Ngone51 edited a comment on pull request #26624:
URL: https://github.com/apache/spark/pull/26624#issuecomment-619962577
> about the pattern, it should be added but I think each will add what he
needed and how he wanted it as it also supports adding local properties
starting with MDC.
AmplabJenkins removed a comment on pull request #27803:
URL: https://github.com/apache/spark/pull/27803#issuecomment-619971949
This is an automated message from the Apache Git Service.
To respond to the message, please log on
SparkQA removed a comment on pull request #28349:
URL: https://github.com/apache/spark/pull/28349#issuecomment-619855561
**[Test build #121896 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121896/testReport)**
for PR 28349 at commit
SparkQA commented on pull request #28349:
URL: https://github.com/apache/spark/pull/28349#issuecomment-619972322
**[Test build #121896 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121896/testReport)**
for PR 28349 at commit
AmplabJenkins commented on pull request #28364:
URL: https://github.com/apache/spark/pull/28364#issuecomment-619990215
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins removed a comment on pull request #27617:
URL: https://github.com/apache/spark/pull/27617#issuecomment-619991663
This is an automated message from the Apache Git Service.
To respond to the message, please log on
cloud-fan commented on pull request #28364:
URL: https://github.com/apache/spark/pull/28364#issuecomment-619992324
thanks, merging to 3.0!
This is an automated message from the Apache Git Service.
To respond to the message,
cloud-fan commented on a change in pull request #28371:
URL: https://github.com/apache/spark/pull/28371#discussion_r415829102
##
File path: sql/core/src/test/resources/sql-tests/results/cte-nested.sql.out
##
@@ -64,10 +64,9 @@ WITH
)
SELECT * FROM t2
-- !query schema
cloud-fan commented on pull request #28371:
URL: https://github.com/apache/spark/pull/28371#issuecomment-61399
cc @peter-toth @xuanyuanking @dongjoon-hyun
This is an automated message from the Apache Git Service.
To
AmplabJenkins commented on pull request #28326:
URL: https://github.com/apache/spark/pull/28326#issuecomment-620006474
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins commented on pull request #28359:
URL: https://github.com/apache/spark/pull/28359#issuecomment-620016355
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins removed a comment on pull request #28355:
URL: https://github.com/apache/spark/pull/28355#issuecomment-620016309
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
AmplabJenkins removed a comment on pull request #28355:
URL: https://github.com/apache/spark/pull/28355#issuecomment-620016298
Merged build finished. Test PASSed.
This is an automated message from the Apache Git Service.
To
AmplabJenkins commented on pull request #28355:
URL: https://github.com/apache/spark/pull/28355#issuecomment-620016298
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins removed a comment on pull request #28359:
URL: https://github.com/apache/spark/pull/28359#issuecomment-620016355
This is an automated message from the Apache Git Service.
To respond to the message, please log on
sririshindra commented on a change in pull request #28330:
URL: https://github.com/apache/spark/pull/28330#discussion_r415861439
##
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/metric/SQLMetricsSuite.scala
##
@@ -547,9 +590,9 @@ class SQLMetricsSuite
SparkQA removed a comment on pull request #28109:
URL: https://github.com/apache/spark/pull/28109#issuecomment-619846231
**[Test build #121893 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121893/testReport)**
for PR 28109 at commit
MichaelChirico commented on a change in pull request #28367:
URL: https://github.com/apache/spark/pull/28367#discussion_r415894560
##
File path: R/pkg/R/SQLContext.R
##
@@ -110,10 +110,11 @@ sparkR.conf <- function(key, defaultValue) {
value <- if (missing(defaultValue))
maropu commented on pull request #28215:
URL: https://github.com/apache/spark/pull/28215#issuecomment-619925244
I run it by myself and I checked it passed on my MacOS (Sierra, Docker
Desktop community v2.3.0.0).
This is an
gaborgsomogyi commented on a change in pull request #28368:
URL: https://github.com/apache/spark/pull/28368#discussion_r415758927
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/connection/DB2ConnectionProvider.scala
##
@@ -48,7 +48,7 @@
SparkQA removed a comment on pull request #27803:
URL: https://github.com/apache/spark/pull/27803#issuecomment-619779875
**[Test build #121883 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121883/testReport)**
for PR 27803 at commit
AmplabJenkins removed a comment on pull request #28294:
URL: https://github.com/apache/spark/pull/28294#issuecomment-619970647
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #28294:
URL: https://github.com/apache/spark/pull/28294#issuecomment-619970647
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
prakharjain09 commented on pull request #28370:
URL: https://github.com/apache/spark/pull/28370#issuecomment-619994477
Recreated PR for https://github.com/apache/spark/pull/27864 to identify and
fix test failures. Please refer to https://github.com/apache/spark/pull/27864
for more
prakharjain09 opened a new pull request #28370:
URL: https://github.com/apache/spark/pull/28370
What changes were proposed in this pull request?
After changes in SPARK-20628, CoarseGrainedSchedulerBackend can decommission
an executor and stop assigning new tasks on it. We should also
SparkQA commented on pull request #28371:
URL: https://github.com/apache/spark/pull/28371#issuecomment-62996
**[Test build #121904 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121904/testReport)**
for PR 28371 at commit
tgravescs commented on pull request #28323:
URL: https://github.com/apache/spark/pull/28323#issuecomment-620001049
it's been a long time since I looked at this so I will have to go refresh my
memory but I don't think using getUserName works in all cases.
What kind of testing have
AmplabJenkins commented on pull request #28371:
URL: https://github.com/apache/spark/pull/28371#issuecomment-620011435
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins removed a comment on pull request #28371:
URL: https://github.com/apache/spark/pull/28371#issuecomment-620011435
This is an automated message from the Apache Git Service.
To respond to the message, please log on
sarutak commented on pull request #28359:
URL: https://github.com/apache/spark/pull/28359#issuecomment-620015543
retest this please.
This is an automated message from the Apache Git Service.
To respond to the message, please
sarutak commented on pull request #28355:
URL: https://github.com/apache/spark/pull/28355#issuecomment-620015779
retest this please.
This is an automated message from the Apache Git Service.
To respond to the message, please
sririshindra commented on a change in pull request #28330:
URL: https://github.com/apache/spark/pull/28330#discussion_r415882589
##
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/metric/SQLMetricsSuite.scala
##
@@ -341,6 +341,62 @@ class SQLMetricsSuite
SparkQA commented on pull request #28330:
URL: https://github.com/apache/spark/pull/28330#issuecomment-620037823
**[Test build #121910 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121910/testReport)**
for PR 28330 at commit
MichaelChirico commented on a change in pull request #28367:
URL: https://github.com/apache/spark/pull/28367#discussion_r415892363
##
File path: R/pkg/R/SQLContext.R
##
@@ -110,10 +110,11 @@ sparkR.conf <- function(key, defaultValue) {
value <- if (missing(defaultValue))
AmplabJenkins removed a comment on pull request #28194:
URL: https://github.com/apache/spark/pull/28194#issuecomment-620043059
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins removed a comment on pull request #28194:
URL: https://github.com/apache/spark/pull/28194#issuecomment-620051756
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #28194:
URL: https://github.com/apache/spark/pull/28194#issuecomment-620051756
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
MichaelChirico opened a new pull request #28372:
URL: https://github.com/apache/spark/pull/28372
### What changes were proposed in this pull request?
Repeated `sapply` avoided in internal `checkSchemaInArrow`
### Why are the changes needed?
Current
SparkQA commented on pull request #28372:
URL: https://github.com/apache/spark/pull/28372#issuecomment-620068202
**[Test build #121915 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121915/testReport)**
for PR 28372 at commit
dongjoon-hyun commented on pull request #28370:
URL: https://github.com/apache/spark/pull/28370#issuecomment-620076140
ok to test
This is an automated message from the Apache Git Service.
To respond to the message, please
AmplabJenkins removed a comment on pull request #28370:
URL: https://github.com/apache/spark/pull/28370#issuecomment-619996941
Can one of the admins verify this patch?
This is an automated message from the Apache Git
dongjoon-hyun commented on a change in pull request #28371:
URL: https://github.com/apache/spark/pull/28371#discussion_r415944837
##
File path: sql/core/src/test/resources/sql-tests/results/cte-nested.sql.out
##
@@ -64,10 +64,9 @@ WITH
)
SELECT * FROM t2
-- !query schema
AmplabJenkins removed a comment on pull request #28370:
URL: https://github.com/apache/spark/pull/28370#issuecomment-620079338
This is an automated message from the Apache Git Service.
To respond to the message, please log on
dongjoon-hyun opened a new pull request #28373:
URL: https://github.com/apache/spark/pull/28373
### What changes were proposed in this pull request?
### Why are the changes needed?
### Does this PR introduce any user-facing change?
###
SparkQA commented on pull request #28359:
URL: https://github.com/apache/spark/pull/28359#issuecomment-620117175
**[Test build #121907 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121907/testReport)**
for PR 28359 at commit
SparkQA removed a comment on pull request #28359:
URL: https://github.com/apache/spark/pull/28359#issuecomment-620019970
**[Test build #121907 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121907/testReport)**
for PR 28359 at commit
AmplabJenkins removed a comment on pull request #28194:
URL: https://github.com/apache/spark/pull/28194#issuecomment-620124705
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
AmplabJenkins removed a comment on pull request #28194:
URL: https://github.com/apache/spark/pull/28194#issuecomment-620124693
Merged build finished. Test FAILed.
This is an automated message from the Apache Git Service.
To
AmplabJenkins commented on pull request #28368:
URL: https://github.com/apache/spark/pull/28368#issuecomment-620136374
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
venkata91 commented on a change in pull request #26339:
URL: https://github.com/apache/spark/pull/26339#discussion_r416026281
##
File path:
core/src/main/scala/org/apache/spark/internal/io/HadoopMapReduceCommitProtocol.scala
##
@@ -118,7 +147,13 @@ class
SparkQA commented on pull request #28369:
URL: https://github.com/apache/spark/pull/28369#issuecomment-620156038
**[Test build #121902 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121902/testReport)**
for PR 28369 at commit
gaborgsomogyi commented on a change in pull request #28368:
URL: https://github.com/apache/spark/pull/28368#discussion_r415908662
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/connection/DB2ConnectionProvider.scala
##
@@ -48,7 +48,7 @@
SparkQA commented on pull request #28372:
URL: https://github.com/apache/spark/pull/28372#issuecomment-620060135
**[Test build #121915 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121915/testReport)**
for PR 28372 at commit
SparkQA commented on pull request #28194:
URL: https://github.com/apache/spark/pull/28194#issuecomment-620060152
**[Test build #121916 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121916/testReport)**
for PR 28194 at commit
dongjoon-hyun edited a comment on pull request #28215:
URL: https://github.com/apache/spark/pull/28215#issuecomment-620077438
Thank you, @gaborgsomogyi .
This is an automated message from the Apache Git Service.
To respond
dongjoon-hyun commented on pull request #28215:
URL: https://github.com/apache/spark/pull/28215#issuecomment-620077438
Thank you, @gaborgsomogyi . I'll try to lower my DockerDesktop version.
This is an automated message from
holdenk commented on pull request #28370:
URL: https://github.com/apache/spark/pull/28370#issuecomment-620077765
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
holdenk removed a comment on pull request #28370:
URL: https://github.com/apache/spark/pull/28370#issuecomment-620077765
Jenkins ok time test
This is an automated message from the Apache Git Service.
To respond to the
AmplabJenkins commented on pull request #28328:
URL: https://github.com/apache/spark/pull/28328#issuecomment-620098625
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins removed a comment on pull request #28374:
URL: https://github.com/apache/spark/pull/28374#issuecomment-620100041
This is an automated message from the Apache Git Service.
To respond to the message, please log on
MichaelChirico opened a new pull request #28374:
URL: https://github.com/apache/spark/pull/28374
### What changes were proposed in this pull request?
All instances of `paste(..., sep = "")` in the code are replaced with
`paste0` which is more performant
### Why
viirya commented on pull request #28328:
URL: https://github.com/apache/spark/pull/28328#issuecomment-620101304
> A `In` with many values is slow to analyze, as the type coercion rules or
`In.resolved` are very slow.
That's a pain point. But when we merge `In` and `InSet`, we can
AmplabJenkins removed a comment on pull request #28328:
URL: https://github.com/apache/spark/pull/28328#issuecomment-620098625
This is an automated message from the Apache Git Service.
To respond to the message, please log on
SparkQA commented on pull request #28374:
URL: https://github.com/apache/spark/pull/28374#issuecomment-620099461
**[Test build #121921 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121921/testReport)**
for PR 28374 at commit
AmplabJenkins commented on pull request #28374:
URL: https://github.com/apache/spark/pull/28374#issuecomment-620100041
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #28359:
URL: https://github.com/apache/spark/pull/28359#issuecomment-620131504
**[Test build #121922 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121922/testReport)**
for PR 28359 at commit
AmplabJenkins removed a comment on pull request #28369:
URL: https://github.com/apache/spark/pull/28369#issuecomment-620158005
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #28369:
URL: https://github.com/apache/spark/pull/28369#issuecomment-620158005
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins commented on pull request #28372:
URL: https://github.com/apache/spark/pull/28372#issuecomment-620060954
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
gaborgsomogyi commented on a change in pull request #28368:
URL: https://github.com/apache/spark/pull/28368#discussion_r415916202
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/connection/DB2ConnectionProvider.scala
##
@@ -48,7 +48,7 @@
AmplabJenkins commented on pull request #28194:
URL: https://github.com/apache/spark/pull/28194#issuecomment-620060887
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins removed a comment on pull request #28372:
URL: https://github.com/apache/spark/pull/28372#issuecomment-620060954
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins removed a comment on pull request #28194:
URL: https://github.com/apache/spark/pull/28194#issuecomment-620060887
This is an automated message from the Apache Git Service.
To respond to the message, please log on
akshatb1 commented on pull request #28258:
URL: https://github.com/apache/spark/pull/28258#issuecomment-620066867
Could someone kindly review these changes? CC: @cloud-fan @srowen @Ngone51
@HeartSaVioR
This is an
peter-toth commented on a change in pull request #28371:
URL: https://github.com/apache/spark/pull/28371#discussion_r415932806
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CTESubstitution.scala
##
@@ -41,34 +43,45 @@ object CTESubstitution
SparkQA commented on pull request #28370:
URL: https://github.com/apache/spark/pull/28370#issuecomment-620078395
**[Test build #121917 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121917/testReport)**
for PR 28370 at commit
AmplabJenkins commented on pull request #28370:
URL: https://github.com/apache/spark/pull/28370#issuecomment-620079338
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
MaxGekk edited a comment on pull request #28369:
URL: https://github.com/apache/spark/pull/28369#issuecomment-620107619
> Can you explain the reason why it should follow that specific case but not
other common ones?
because
1. You do benchmarking of particular functions, and it
AmplabJenkins removed a comment on pull request #28368:
URL: https://github.com/apache/spark/pull/28368#issuecomment-620136374
This is an automated message from the Apache Git Service.
To respond to the message, please log on
SparkQA commented on pull request #28194:
URL: https://github.com/apache/spark/pull/28194#issuecomment-620142989
**[Test build #121916 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121916/testReport)**
for PR 28194 at commit
AmplabJenkins commented on pull request #28194:
URL: https://github.com/apache/spark/pull/28194#issuecomment-620143257
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA removed a comment on pull request #28369:
URL: https://github.com/apache/spark/pull/28369#issuecomment-619955813
**[Test build #121902 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121902/testReport)**
for PR 28369 at commit
SparkQA commented on pull request #28109:
URL: https://github.com/apache/spark/pull/28109#issuecomment-620057253
**[Test build #121898 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121898/testReport)**
for PR 28109 at commit
AmplabJenkins commented on pull request #28372:
URL: https://github.com/apache/spark/pull/28372#issuecomment-620056207
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins removed a comment on pull request #28372:
URL: https://github.com/apache/spark/pull/28372#issuecomment-620055599
This is an automated message from the Apache Git Service.
To respond to the message, please log on
peter-toth commented on pull request #28371:
URL: https://github.com/apache/spark/pull/28371#issuecomment-620074663
That flag is a nice trick so LGTM, I just left a minor note.
The other 2 fixes also look good.
This
SparkQA commented on pull request #28367:
URL: https://github.com/apache/spark/pull/28367#issuecomment-620081914
**[Test build #121912 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121912/testReport)**
for PR 28367 at commit
SparkQA commented on pull request #28371:
URL: https://github.com/apache/spark/pull/28371#issuecomment-620091239
**[Test build #121920 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121920/testReport)**
for PR 28371 at commit
yaooqinn commented on pull request #28369:
URL: https://github.com/apache/spark/pull/28369#issuecomment-620103718
> wholestage on or off doesn't matter actually. Could you build one table
with default settings (wholestage on) like `Conversion from/to external types`
in this benchmark.
AmplabJenkins removed a comment on pull request #28359:
URL: https://github.com/apache/spark/pull/28359#issuecomment-620118152
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
301 - 400 of 961 matches
Mail list logo