[GitHub] [spark] SparkQA commented on pull request #28572: [SPARK-31750][SQL] Eliminate UpCast if child's dataType is DecimalType

2020-05-19 Thread GitBox
SparkQA commented on pull request #28572: URL: https://github.com/apache/spark/pull/28572#issuecomment-631047525 **[Test build #122850 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122850/testReport)** for PR 28572 at commit

[GitHub] [spark] MaxGekk opened a new pull request #28582: [WIP][SPARK-31762][SQL] Fix perf regression of date/timestamp formatting in toHiveString

2020-05-19 Thread GitBox
MaxGekk opened a new pull request #28582: URL: https://github.com/apache/spark/pull/28582 ### What changes were proposed in this pull request? Add new methods that accept date-time Java types to the DateFormatter and TimestampFormatter traits. The methods format input date-time

[GitHub] [spark] SparkQA removed a comment on pull request #28572: [SPARK-31750][SQL] Eliminate UpCast if child's dataType is DecimalType

2020-05-19 Thread GitBox
SparkQA removed a comment on pull request #28572: URL: https://github.com/apache/spark/pull/28572#issuecomment-630825781 **[Test build #122850 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122850/testReport)** for PR 28572 at commit

[GitHub] [spark] tashoyan commented on pull request #28491: [SPARK-30267][SQL] Interoperability tests with Avro records generated by Avro4s

2020-05-19 Thread GitBox
tashoyan commented on pull request #28491: URL: https://github.com/apache/spark/pull/28491#issuecomment-631045701 Technically we can write case classes simulating the output of avro4s. This approach has a disadvantage: no clue about what version of avro4s we are compatible with. With

[GitHub] [spark] dbtsai closed pull request #28577: [SPARK-31399][CORE][2.4] Support indylambda Scala closure in ClosureCleaner

2020-05-19 Thread GitBox
dbtsai closed pull request #28577: URL: https://github.com/apache/spark/pull/28577 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [spark] dbtsai commented on pull request #28577: [SPARK-31399][CORE][2.4] Support indylambda Scala closure in ClosureCleaner

2020-05-19 Thread GitBox
dbtsai commented on pull request #28577: URL: https://github.com/apache/spark/pull/28577#issuecomment-631034670 Merged into branch-2.4. Thank you, @rednaxelafx This is an automated message from the Apache Git Service. To

[GitHub] [spark] dbtsai commented on pull request #28577: [SPARK-31399][CORE][2.4] Support indylambda Scala closure in ClosureCleaner

2020-05-19 Thread GitBox
dbtsai commented on pull request #28577: URL: https://github.com/apache/spark/pull/28577#issuecomment-631033792 All the tests are passing in Scala 2.12 with JDK8 and JDK11 builds. I also tested the code in the description, and it works as expected. - Scala 2.12 with JDK8

[GitHub] [spark] dongjoon-hyun edited a comment on pull request #26804: [SPARK-26346][BUILD][SQL] Upgrade parquet to 1.11.0

2020-05-19 Thread GitBox
dongjoon-hyun edited a comment on pull request #26804: URL: https://github.com/apache/spark/pull/26804#issuecomment-630997965 @h-vetinari . This is wrong, isn't it? Did someone (except you) say it's low priority here? We want new Parquet, but currently it looks infeasible technically. Do

[GitHub] [spark] dongjoon-hyun commented on pull request #26804: [SPARK-26346][BUILD][SQL] Upgrade parquet to 1.11.0

2020-05-19 Thread GitBox
dongjoon-hyun commented on pull request #26804: URL: https://github.com/apache/spark/pull/26804#issuecomment-630997965 @h-vetinari . This is wrong, isn't it? Did someone (except you) say it's low priority here? We want that, but currently it looks infeasible technically. Do you think that

[GitHub] [spark] dbtsai commented on pull request #28577: [SPARK-31399][CORE][2.4] Support indylambda Scala closure in ClosureCleaner

2020-05-19 Thread GitBox
dbtsai commented on pull request #28577: URL: https://github.com/apache/spark/pull/28577#issuecomment-630986803 @rednaxelafx We have internal Spark 2.4 builds supporting JDK11, JDK8, Scala 2.12, and Scala 2.11. I just cherry-picked this PR, and ran the full tests. I'll update the result

[GitHub] [spark] igreenfield commented on pull request #26624: [SPARK-8981][CORE][test-hadoop3.2][test-java11] Add MDC support in Executor

2020-05-19 Thread GitBox
igreenfield commented on pull request #26624: URL: https://github.com/apache/spark/pull/26624#issuecomment-630984555 @cloud-fan What the problem with these tests? This is an automated message from the Apache Git Service. To

[GitHub] [spark] tdas edited a comment on pull request #28523: [SPARK-31706][SQL] add back the support of streaming update mode

2020-05-19 Thread GitBox
tdas edited a comment on pull request #28523: URL: https://github.com/apache/spark/pull/28523#issuecomment-630975138 Without going into the nitty-gritty arguments about output modes (requires a different venue), I am okay with the changes. I think there are two ways to move forward

[GitHub] [spark] tdas edited a comment on pull request #28523: [SPARK-31706][SQL] add back the support of streaming update mode

2020-05-19 Thread GitBox
tdas edited a comment on pull request #28523: URL: https://github.com/apache/spark/pull/28523#issuecomment-630975138 Without going into the nitty-gritty arguments about output modes (requires a different venue), I am okay with the changes. I think there are two ways to move forward

[GitHub] [spark] tdas commented on pull request #28523: [SPARK-31706][SQL] add back the support of streaming update mode

2020-05-19 Thread GitBox
tdas commented on pull request #28523: URL: https://github.com/apache/spark/pull/28523#issuecomment-630975138 Without going into the nitty-gritty arguments about output modes (requires a different venue), I am okay with the changes. I think there are two ways to move forward 1.

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28579: [SPARK-31757][CORE] Improve HistoryServerDiskManager.updateAccessTime()

2020-05-19 Thread GitBox
AmplabJenkins removed a comment on pull request #28579: URL: https://github.com/apache/spark/pull/28579#issuecomment-630962041 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28579: [SPARK-31757][CORE] Improve HistoryServerDiskManager.updateAccessTime()

2020-05-19 Thread GitBox
AmplabJenkins commented on pull request #28579: URL: https://github.com/apache/spark/pull/28579#issuecomment-630962041 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28579: [SPARK-31757][CORE] Improve HistoryServerDiskManager.updateAccessTime()

2020-05-19 Thread GitBox
SparkQA commented on pull request #28579: URL: https://github.com/apache/spark/pull/28579#issuecomment-630961488 **[Test build #122853 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122853/testReport)** for PR 28579 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28576: [SPARK-31755][SQL] allow missing year/hour when parsing date/timestamp string

2020-05-19 Thread GitBox
AmplabJenkins removed a comment on pull request #28576: URL: https://github.com/apache/spark/pull/28576#issuecomment-630958815 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28576: [SPARK-31755][SQL] allow missing year/hour when parsing date/timestamp string

2020-05-19 Thread GitBox
AmplabJenkins removed a comment on pull request #28576: URL: https://github.com/apache/spark/pull/28576#issuecomment-630958801 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] SparkQA commented on pull request #28576: [SPARK-31755][SQL] allow missing year/hour when parsing date/timestamp string

2020-05-19 Thread GitBox
SparkQA commented on pull request #28576: URL: https://github.com/apache/spark/pull/28576#issuecomment-630958614 **[Test build #122851 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122851/testReport)** for PR 28576 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #28576: [SPARK-31755][SQL] allow missing year/hour when parsing date/timestamp string

2020-05-19 Thread GitBox
AmplabJenkins commented on pull request #28576: URL: https://github.com/apache/spark/pull/28576#issuecomment-630958801 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #28576: [SPARK-31755][SQL] allow missing year/hour when parsing date/timestamp string

2020-05-19 Thread GitBox
SparkQA removed a comment on pull request #28576: URL: https://github.com/apache/spark/pull/28576#issuecomment-630893465 **[Test build #122851 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122851/testReport)** for PR 28576 at commit

[GitHub] [spark] jiangxb1987 commented on pull request #28579: [SPARK-31757][CORE] Improve HistoryServerDiskManager.updateAccessTime()

2020-05-19 Thread GitBox
jiangxb1987 commented on pull request #28579: URL: https://github.com/apache/spark/pull/28579#issuecomment-630958421 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28581: KCL 2 support added to solve few ongoing issue with KCL 1 implementation

2020-05-19 Thread GitBox
AmplabJenkins removed a comment on pull request #28581: URL: https://github.com/apache/spark/pull/28581#issuecomment-630942114 Can one of the admins verify this patch? This is an automated message from the Apache Git

[GitHub] [spark] h-vetinari commented on pull request #26804: [SPARK-26346][BUILD][SQL] Upgrade parquet to 1.11.0

2020-05-19 Thread GitBox
h-vetinari commented on pull request #26804: URL: https://github.com/apache/spark/pull/26804#issuecomment-630945817 > @dongjoon-hyun: Please feel free to open a working PR. Then, the community will welcome. Sorry if my message came across as demanding. I'm not deeply involved in the

[GitHub] [spark] AmplabJenkins commented on pull request #28581: KCL 2 support added to solve few ongoing issue with KCL 1 implementation

2020-05-19 Thread GitBox
AmplabJenkins commented on pull request #28581: URL: https://github.com/apache/spark/pull/28581#issuecomment-630945312 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on pull request #28581: KCL 2 support added to solve few ongoing issue with KCL 1 implementation

2020-05-19 Thread GitBox
AmplabJenkins commented on pull request #28581: URL: https://github.com/apache/spark/pull/28581#issuecomment-630942114 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To

[GitHub] [spark] tprabh509 opened a new pull request #28581: KCL 2 support added to solve few ongoing issue with KCL 1 implementation

2020-05-19 Thread GitBox
tprabh509 opened a new pull request #28581: URL: https://github.com/apache/spark/pull/28581 ### What changes were proposed in this pull request? Currently KCL 1 is no longer supported by AWS and they already moved to KCL 2. Since Spark kinesis asl library user KCL 1 it can cause issues

[GitHub] [spark] holdenk commented on pull request #28370: [SPARK-20732][CORE] Decommission cache blocks to other executors when an executor is decommissioned

2020-05-19 Thread GitBox
holdenk commented on pull request #28370: URL: https://github.com/apache/spark/pull/28370#issuecomment-630938158 Sounds good, happy to help coordinate with any reviews needed. Would like us to be able to start using this in 3.1 :)

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28511: [SPARK-31684][SQL] Overwrite partition failed with 'WRONG FS' when the target partition is not belong to the filesystem as same

2020-05-19 Thread GitBox
AmplabJenkins removed a comment on pull request #28511: URL: https://github.com/apache/spark/pull/28511#issuecomment-630936518 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28511: [SPARK-31684][SQL] Overwrite partition failed with 'WRONG FS' when the target partition is not belong to the filesystem as same as the

2020-05-19 Thread GitBox
AmplabJenkins commented on pull request #28511: URL: https://github.com/apache/spark/pull/28511#issuecomment-630936518 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28511: [SPARK-31684][SQL] Overwrite partition failed with 'WRONG FS' when the target partition is not belong to the filesystem as same as the table

2020-05-19 Thread GitBox
SparkQA commented on pull request #28511: URL: https://github.com/apache/spark/pull/28511#issuecomment-630934499 **[Test build #122847 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122847/testReport)** for PR 28511 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #28511: [SPARK-31684][SQL] Overwrite partition failed with 'WRONG FS' when the target partition is not belong to the filesystem as same as th

2020-05-19 Thread GitBox
SparkQA removed a comment on pull request #28511: URL: https://github.com/apache/spark/pull/28511#issuecomment-630749618 **[Test build #122847 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122847/testReport)** for PR 28511 at commit

[GitHub] [spark] vinooganesh commented on a change in pull request #28128: [SPARK-31354] SparkContext only register one SparkSession ApplicationEnd listener

2020-05-19 Thread GitBox
vinooganesh commented on a change in pull request #28128: URL: https://github.com/apache/spark/pull/28128#discussion_r427422859 ## File path: core/src/main/scala/org/apache/spark/SparkContext.scala ## @@ -91,6 +91,7 @@ class SparkContext(config: SparkConf) extends Logging {

[GitHub] [spark] vganesh-veraset commented on a change in pull request #28128: [SPARK-31354] SparkContext only register one SparkSession ApplicationEnd listener

2020-05-19 Thread GitBox
vganesh-veraset commented on a change in pull request #28128: URL: https://github.com/apache/spark/pull/28128#discussion_r427421050 ## File path: core/src/main/scala/org/apache/spark/SparkContext.scala ## @@ -91,6 +91,7 @@ class SparkContext(config: SparkConf) extends Logging

[GitHub] [spark] iemejia commented on pull request #26804: [SPARK-26346][BUILD][SQL] Upgrade parquet to 1.11.0

2020-05-19 Thread GitBox
iemejia commented on pull request #26804: URL: https://github.com/apache/spark/pull/26804#issuecomment-630917979 @dongjoon-hyun You are absolutely right about no Hive with Avro 1.9 and that's the REAL problem. I don't think creating a PR that passes all UT (including Hive 1.2/2.3 profile)

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28572: [SPARK-31750][SQL] Eliminate UpCast if child's dataType is DecimalType

2020-05-19 Thread GitBox
AmplabJenkins removed a comment on pull request #28572: URL: https://github.com/apache/spark/pull/28572#issuecomment-630912501 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28572: [SPARK-31750][SQL] Eliminate UpCast if child's dataType is DecimalType

2020-05-19 Thread GitBox
AmplabJenkins commented on pull request #28572: URL: https://github.com/apache/spark/pull/28572#issuecomment-630912501 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #28572: [SPARK-31750][SQL] Eliminate UpCast if child's dataType is DecimalType

2020-05-19 Thread GitBox
SparkQA removed a comment on pull request #28572: URL: https://github.com/apache/spark/pull/28572#issuecomment-630709892 **[Test build #122844 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122844/testReport)** for PR 28572 at commit

[GitHub] [spark] SparkQA commented on pull request #28572: [SPARK-31750][SQL] Eliminate UpCast if child's dataType is DecimalType

2020-05-19 Thread GitBox
SparkQA commented on pull request #28572: URL: https://github.com/apache/spark/pull/28572#issuecomment-630911354 **[Test build #122844 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122844/testReport)** for PR 28572 at commit

[GitHub] [spark] bart-samwel commented on a change in pull request #28576: [SPARK-31755][SQL] allow missing year/hour when parsing date/timestamp string

2020-05-19 Thread GitBox
bart-samwel commented on a change in pull request #28576: URL: https://github.com/apache/spark/pull/28576#discussion_r427401584 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeFormatterHelper.scala ## @@ -31,17 +31,50 @@ import

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28540: [SPARK-31719][SQL] Refactor JoinSelection

2020-05-19 Thread GitBox
AmplabJenkins removed a comment on pull request #28540: URL: https://github.com/apache/spark/pull/28540#issuecomment-630905053 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] dongjoon-hyun edited a comment on pull request #26804: [SPARK-26346][BUILD][SQL] Upgrade parquet to 1.11.0

2020-05-19 Thread GitBox
dongjoon-hyun edited a comment on pull request #26804: URL: https://github.com/apache/spark/pull/26804#issuecomment-630904663 @h-vetinari . Parquet is a de-facto standard in Apache Spark and is related to all the other module. That's the reason why Parquet should not break anything in all

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28540: [SPARK-31719][SQL] Refactor JoinSelection

2020-05-19 Thread GitBox
AmplabJenkins removed a comment on pull request #28540: URL: https://github.com/apache/spark/pull/28540#issuecomment-630905040 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on pull request #28540: [SPARK-31719][SQL] Refactor JoinSelection

2020-05-19 Thread GitBox
AmplabJenkins commented on pull request #28540: URL: https://github.com/apache/spark/pull/28540#issuecomment-630905040 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #28540: [SPARK-31719][SQL] Refactor JoinSelection

2020-05-19 Thread GitBox
SparkQA removed a comment on pull request #28540: URL: https://github.com/apache/spark/pull/28540#issuecomment-630686085 **[Test build #122843 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122843/testReport)** for PR 28540 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28572: [SPARK-31750][SQL] Eliminate UpCast if child's dataType is DecimalType

2020-05-19 Thread GitBox
AmplabJenkins removed a comment on pull request #28572: URL: https://github.com/apache/spark/pull/28572#issuecomment-630903846 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] dongjoon-hyun commented on pull request #26804: [SPARK-26346][BUILD][SQL] Upgrade parquet to 1.11.0

2020-05-19 Thread GitBox
dongjoon-hyun commented on pull request #26804: URL: https://github.com/apache/spark/pull/26804#issuecomment-630904663 @h-vetinari . Parquet is a de-facto standard in Apache Spark and is related to all the other module. That's the reason why Parquet should not break anything in all the

[GitHub] [spark] SparkQA commented on pull request #28540: [SPARK-31719][SQL] Refactor JoinSelection

2020-05-19 Thread GitBox
SparkQA commented on pull request #28540: URL: https://github.com/apache/spark/pull/28540#issuecomment-630904087 **[Test build #122843 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122843/testReport)** for PR 28540 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #28572: [SPARK-31750][SQL] Eliminate UpCast if child's dataType is DecimalType

2020-05-19 Thread GitBox
AmplabJenkins commented on pull request #28572: URL: https://github.com/apache/spark/pull/28572#issuecomment-630903846 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28572: [SPARK-31750][SQL] Eliminate UpCast if child's dataType is DecimalType

2020-05-19 Thread GitBox
SparkQA commented on pull request #28572: URL: https://github.com/apache/spark/pull/28572#issuecomment-630903093 **[Test build #122852 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122852/testReport)** for PR 28572 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #26624: [SPARK-8981][CORE][test-hadoop3.2][test-java11] Add MDC support in Executor

2020-05-19 Thread GitBox
AmplabJenkins removed a comment on pull request #26624: URL: https://github.com/apache/spark/pull/26624#issuecomment-630901505 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #26624: [SPARK-8981][CORE][test-hadoop3.2][test-java11] Add MDC support in Executor

2020-05-19 Thread GitBox
AmplabJenkins removed a comment on pull request #26624: URL: https://github.com/apache/spark/pull/26624#issuecomment-630901494 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on pull request #26624: [SPARK-8981][CORE][test-hadoop3.2][test-java11] Add MDC support in Executor

2020-05-19 Thread GitBox
AmplabJenkins commented on pull request #26624: URL: https://github.com/apache/spark/pull/26624#issuecomment-630901494 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] Ngone51 commented on pull request #28572: [SPARK-31750][SQL] Eliminate UpCast if child's dataType is DecimalType

2020-05-19 Thread GitBox
Ngone51 commented on pull request #28572: URL: https://github.com/apache/spark/pull/28572#issuecomment-630901730 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] SparkQA removed a comment on pull request #26624: [SPARK-8981][CORE][test-hadoop3.2][test-java11] Add MDC support in Executor

2020-05-19 Thread GitBox
SparkQA removed a comment on pull request #26624: URL: https://github.com/apache/spark/pull/26624#issuecomment-630796651 **[Test build #122849 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122849/testReport)** for PR 26624 at commit

[GitHub] [spark] SparkQA commented on pull request #26624: [SPARK-8981][CORE][test-hadoop3.2][test-java11] Add MDC support in Executor

2020-05-19 Thread GitBox
SparkQA commented on pull request #26624: URL: https://github.com/apache/spark/pull/26624#issuecomment-630900818 **[Test build #122849 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122849/testReport)** for PR 26624 at commit

[GitHub] [spark] holdenk commented on pull request #28577: [SPARK-31399][CORE][2.4] Support indylambda Scala closure in ClosureCleaner

2020-05-19 Thread GitBox
holdenk commented on pull request #28577: URL: https://github.com/apache/spark/pull/28577#issuecomment-630896567 Thank you for backporting this. I’m off today and tomorrow for health reasons, but if no one has time to review by Thursday I’ll take a look :)

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28576: [SPARK-31755][SQL] allow missing year/hour when parsing date/timestamp string

2020-05-19 Thread GitBox
AmplabJenkins removed a comment on pull request #28576: URL: https://github.com/apache/spark/pull/28576#issuecomment-630894202 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28576: [SPARK-31755][SQL] allow missing year/hour when parsing date/timestamp string

2020-05-19 Thread GitBox
AmplabJenkins commented on pull request #28576: URL: https://github.com/apache/spark/pull/28576#issuecomment-630894202 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28576: [SPARK-31755][SQL] allow missing year/hour when parsing date/timestamp string

2020-05-19 Thread GitBox
SparkQA commented on pull request #28576: URL: https://github.com/apache/spark/pull/28576#issuecomment-630893465 **[Test build #122851 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122851/testReport)** for PR 28576 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28580: [SPARK-31759][Deploy] Support configurable max number of rotate logs for spark daemons

2020-05-19 Thread GitBox
AmplabJenkins removed a comment on pull request #28580: URL: https://github.com/apache/spark/pull/28580#issuecomment-630877166 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28572: [SPARK-31750][SQL] Eliminate UpCast if child's dataType is DecimalType

2020-05-19 Thread GitBox
AmplabJenkins removed a comment on pull request #28572: URL: https://github.com/apache/spark/pull/28572#issuecomment-630876764 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on pull request #28580: [SPARK-31759][Deploy] Support configurable max number of rotate logs for spark daemons

2020-05-19 Thread GitBox
AmplabJenkins commented on pull request #28580: URL: https://github.com/apache/spark/pull/28580#issuecomment-630877166 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28572: [SPARK-31750][SQL] Eliminate UpCast if child's dataType is DecimalType

2020-05-19 Thread GitBox
AmplabJenkins removed a comment on pull request #28572: URL: https://github.com/apache/spark/pull/28572#issuecomment-630876740 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on pull request #28572: [SPARK-31750][SQL] Eliminate UpCast if child's dataType is DecimalType

2020-05-19 Thread GitBox
AmplabJenkins commented on pull request #28572: URL: https://github.com/apache/spark/pull/28572#issuecomment-630876740 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #28580: [SPARK-31759][Deploy] Support configurable max number of rotate logs for spark daemons

2020-05-19 Thread GitBox
SparkQA removed a comment on pull request #28580: URL: https://github.com/apache/spark/pull/28580#issuecomment-630720005 **[Test build #122845 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122845/testReport)** for PR 28580 at commit

[GitHub] [spark] SparkQA commented on pull request #28580: [SPARK-31759][Deploy] Support configurable max number of rotate logs for spark daemons

2020-05-19 Thread GitBox
SparkQA commented on pull request #28580: URL: https://github.com/apache/spark/pull/28580#issuecomment-630875695 **[Test build #122845 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122845/testReport)** for PR 28580 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #28572: [SPARK-31750][SQL] Eliminate UpCast if child's dataType is DecimalType

2020-05-19 Thread GitBox
SparkQA removed a comment on pull request #28572: URL: https://github.com/apache/spark/pull/28572#issuecomment-630662267 **[Test build #122842 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122842/testReport)** for PR 28572 at commit

[GitHub] [spark] SparkQA commented on pull request #28572: [SPARK-31750][SQL] Eliminate UpCast if child's dataType is DecimalType

2020-05-19 Thread GitBox
SparkQA commented on pull request #28572: URL: https://github.com/apache/spark/pull/28572#issuecomment-630875386 **[Test build #122842 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122842/testReport)** for PR 28572 at commit

[GitHub] [spark] dongjoon-hyun commented on pull request #28577: [SPARK-31399][CORE][2.4] Support indylambda Scala closure in ClosureCleaner

2020-05-19 Thread GitBox
dongjoon-hyun commented on pull request #28577: URL: https://github.com/apache/spark/pull/28577#issuecomment-630871278 Thank you, @rednaxelafx . cc @holdenk since she is a release manager of Apache Spark 2.4.6. This is an

[GitHub] [spark] srowen closed pull request #27525: [MINOR] update dstream.py with more accurate exceptions

2020-05-19 Thread GitBox
srowen closed pull request #27525: URL: https://github.com/apache/spark/pull/27525 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [spark] srowen commented on pull request #27525: [MINOR] update dstream.py with more accurate exceptions

2020-05-19 Thread GitBox
srowen commented on pull request #27525: URL: https://github.com/apache/spark/pull/27525#issuecomment-630868876 Reopen if you update this. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28534: [SPARK-31710][SQL]TIMESTAMP_SECONDS, TIMESTAMP_MILLISECONDS and TIMESTAMP_MICROSECONDS to timestamp transfer

2020-05-19 Thread GitBox
AmplabJenkins removed a comment on pull request #28534: URL: https://github.com/apache/spark/pull/28534#issuecomment-630858130 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28534: [SPARK-31710][SQL]TIMESTAMP_SECONDS, TIMESTAMP_MILLISECONDS and TIMESTAMP_MICROSECONDS to timestamp transfer

2020-05-19 Thread GitBox
AmplabJenkins removed a comment on pull request #28534: URL: https://github.com/apache/spark/pull/28534#issuecomment-630858115 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] SparkQA removed a comment on pull request #28534: [SPARK-31710][SQL]TIMESTAMP_SECONDS, TIMESTAMP_MILLISECONDS and TIMESTAMP_MICROSECONDS to timestamp transfer

2020-05-19 Thread GitBox
SparkQA removed a comment on pull request #28534: URL: https://github.com/apache/spark/pull/28534#issuecomment-630789294 **[Test build #122848 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122848/testReport)** for PR 28534 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #28534: [SPARK-31710][SQL]TIMESTAMP_SECONDS, TIMESTAMP_MILLISECONDS and TIMESTAMP_MICROSECONDS to timestamp transfer

2020-05-19 Thread GitBox
AmplabJenkins commented on pull request #28534: URL: https://github.com/apache/spark/pull/28534#issuecomment-630858115 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28534: [SPARK-31710][SQL]TIMESTAMP_SECONDS, TIMESTAMP_MILLISECONDS and TIMESTAMP_MICROSECONDS to timestamp transfer

2020-05-19 Thread GitBox
SparkQA commented on pull request #28534: URL: https://github.com/apache/spark/pull/28534#issuecomment-630857909 **[Test build #122848 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122848/testReport)** for PR 28534 at commit

[GitHub] [spark] cloud-fan commented on a change in pull request #28576: [SPARK-31755][SQL] allow missing year/hour when parsing date/timestamp string

2020-05-19 Thread GitBox
cloud-fan commented on a change in pull request #28576: URL: https://github.com/apache/spark/pull/28576#discussion_r427337528 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/util/TimestampFormatterSuite.scala ## @@ -291,4 +291,95 @@ class

[GitHub] [spark] cloud-fan commented on a change in pull request #28576: [SPARK-31755][SQL] allow missing year/hour when parsing date/timestamp string

2020-05-19 Thread GitBox
cloud-fan commented on a change in pull request #28576: URL: https://github.com/apache/spark/pull/28576#discussion_r427054501 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeFormatterHelper.scala ## @@ -72,18 +94,14 @@ trait

[GitHub] [spark] cloud-fan commented on a change in pull request #28576: [SPARK-31755][SQL] allow missing year/hour when parsing date/timestamp string

2020-05-19 Thread GitBox
cloud-fan commented on a change in pull request #28576: URL: https://github.com/apache/spark/pull/28576#discussion_r427054501 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeFormatterHelper.scala ## @@ -72,18 +94,14 @@ trait

[GitHub] [spark] cloud-fan commented on a change in pull request #28576: [SPARK-31755][SQL] allow missing year/hour when parsing date/timestamp string

2020-05-19 Thread GitBox
cloud-fan commented on a change in pull request #28576: URL: https://github.com/apache/spark/pull/28576#discussion_r427333877 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeFormatterHelper.scala ## @@ -31,17 +31,39 @@ import

[GitHub] [spark] cloud-fan closed pull request #28511: [SPARK-31684][SQL] Overwrite partition failed with 'WRONG FS' when the target partition is not belong to the filesystem as same as the table

2020-05-19 Thread GitBox
cloud-fan closed pull request #28511: URL: https://github.com/apache/spark/pull/28511 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [spark] cloud-fan commented on pull request #28511: [SPARK-31684][SQL] Overwrite partition failed with 'WRONG FS' when the target partition is not belong to the filesystem as same as the tabl

2020-05-19 Thread GitBox
cloud-fan commented on pull request #28511: URL: https://github.com/apache/spark/pull/28511#issuecomment-630843338 This fixes a bug for a corner case, when table and partition locations are in different file systems. I'm merging it to master only, to reduce risk. Thanks!

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28572: [SPARK-31750][SQL] Eliminate UpCast if child's dataType is DecimalType

2020-05-19 Thread GitBox
AmplabJenkins removed a comment on pull request #28572: URL: https://github.com/apache/spark/pull/28572#issuecomment-630838249 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28572: [SPARK-31750][SQL] Eliminate UpCast if child's dataType is DecimalType

2020-05-19 Thread GitBox
AmplabJenkins removed a comment on pull request #28572: URL: https://github.com/apache/spark/pull/28572#issuecomment-630838241 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on pull request #28572: [SPARK-31750][SQL] Eliminate UpCast if child's dataType is DecimalType

2020-05-19 Thread GitBox
AmplabJenkins commented on pull request #28572: URL: https://github.com/apache/spark/pull/28572#issuecomment-630838241 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #28572: [SPARK-31750][SQL] Eliminate UpCast if child's dataType is DecimalType

2020-05-19 Thread GitBox
SparkQA removed a comment on pull request #28572: URL: https://github.com/apache/spark/pull/28572#issuecomment-630633507 **[Test build #122838 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122838/testReport)** for PR 28572 at commit

[GitHub] [spark] SparkQA commented on pull request #28572: [SPARK-31750][SQL] Eliminate UpCast if child's dataType is DecimalType

2020-05-19 Thread GitBox
SparkQA commented on pull request #28572: URL: https://github.com/apache/spark/pull/28572#issuecomment-630837013 **[Test build #122838 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122838/testReport)** for PR 28572 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28572: [SPARK-31750][SQL] Eliminate UpCast if child's dataType is DecimalType

2020-05-19 Thread GitBox
AmplabJenkins removed a comment on pull request #28572: URL: https://github.com/apache/spark/pull/28572#issuecomment-630826358 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28572: [SPARK-31750][SQL] Eliminate UpCast if child's dataType is DecimalType

2020-05-19 Thread GitBox
AmplabJenkins commented on pull request #28572: URL: https://github.com/apache/spark/pull/28572#issuecomment-630826358 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28572: [SPARK-31750][SQL] Eliminate UpCast if child's dataType is DecimalType

2020-05-19 Thread GitBox
SparkQA commented on pull request #28572: URL: https://github.com/apache/spark/pull/28572#issuecomment-630825781 **[Test build #122850 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122850/testReport)** for PR 28572 at commit

[GitHub] [spark] Ngone51 commented on a change in pull request #28572: [SPARK-31750][SQL] Eliminate UpCast if child's dataType is DecimalType

2020-05-19 Thread GitBox
Ngone51 commented on a change in pull request #28572: URL: https://github.com/apache/spark/pull/28572#discussion_r427308224 ## File path: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala ## @@ -2439,6 +2439,17 @@ class DataFrameSuite extends QueryTest val

[GitHub] [spark] cloud-fan commented on pull request #28576: [SPARK-31755][SQL] allow missing year/hour when parsing date/timestamp string

2020-05-19 Thread GitBox
cloud-fan commented on pull request #28576: URL: https://github.com/apache/spark/pull/28576#issuecomment-630820332 > The reason being that it is not a leap year, which means that it would never parse Feb 29. This is a good point. Now I agree 1970 is not a good default. I'll fail it

[GitHub] [spark] cloud-fan commented on a change in pull request #28572: [SPARK-31750][SQL] Eliminate UpCast if child's dataType is DecimalType

2020-05-19 Thread GitBox
cloud-fan commented on a change in pull request #28572: URL: https://github.com/apache/spark/pull/28572#discussion_r427300529 ## File path: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala ## @@ -2439,6 +2439,17 @@ class DataFrameSuite extends QueryTest

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28511: [SPARK-31684][SQL] Overwrite partition failed with 'WRONG FS' when the target partition is not belong to the filesystem as same

2020-05-19 Thread GitBox
AmplabJenkins removed a comment on pull request #28511: URL: https://github.com/apache/spark/pull/28511#issuecomment-630805536 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28511: [SPARK-31684][SQL] Overwrite partition failed with 'WRONG FS' when the target partition is not belong to the filesystem as same as the

2020-05-19 Thread GitBox
AmplabJenkins commented on pull request #28511: URL: https://github.com/apache/spark/pull/28511#issuecomment-630805536 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] cloud-fan commented on a change in pull request #28534: [SPARK-31710][SQL]TIMESTAMP_SECONDS, TIMESTAMP_MILLISECONDS and TIMESTAMP_MICROSECONDS to timestamp transfer

2020-05-19 Thread GitBox
cloud-fan commented on a change in pull request #28534: URL: https://github.com/apache/spark/pull/28534#discussion_r427286816 ## File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala ## @@ -3495,6 +3495,28 @@ class SQLQuerySuite extends QueryTest with

[GitHub] [spark] cloud-fan commented on a change in pull request #28534: [SPARK-31710][SQL]TIMESTAMP_SECONDS, TIMESTAMP_MILLISECONDS and TIMESTAMP_MICROSECONDS to timestamp transfer

2020-05-19 Thread GitBox
cloud-fan commented on a change in pull request #28534: URL: https://github.com/apache/spark/pull/28534#discussion_r427286362 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala ## @@ -401,6 +401,92 @@ case class

[GitHub] [spark] SparkQA commented on pull request #28511: [SPARK-31684][SQL] Overwrite partition failed with 'WRONG FS' when the target partition is not belong to the filesystem as same as the table

2020-05-19 Thread GitBox
SparkQA commented on pull request #28511: URL: https://github.com/apache/spark/pull/28511#issuecomment-630803839 **[Test build #122836 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122836/testReport)** for PR 28511 at commit

<    1   2   3   4   5   6   >