SparkQA commented on pull request #28534:
URL: https://github.com/apache/spark/pull/28534#issuecomment-631922675
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
SparkQA commented on pull request #28556:
URL: https://github.com/apache/spark/pull/28556#issuecomment-631922680
**[Test build #122916 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122916/testReport)**
for PR 28556 at commit
GuoPhilipse commented on a change in pull request #28593:
URL: https://github.com/apache/spark/pull/28593#discussion_r428481765
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##
@@ -2586,6 +2586,22 @@ object SQLConf {
AmplabJenkins commented on pull request #28534:
URL: https://github.com/apache/spark/pull/28534#issuecomment-631931016
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
turboFei commented on a change in pull request #28525:
URL: https://github.com/apache/spark/pull/28525#discussion_r428490170
##
File path:
core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala
##
@@ -626,16 +628,61 @@ final class
AmplabJenkins removed a comment on pull request #28534:
URL: https://github.com/apache/spark/pull/28534#issuecomment-631931016
This is an automated message from the Apache Git Service.
To respond to the message, please log on
turboFei commented on a change in pull request #28525:
URL: https://github.com/apache/spark/pull/28525#discussion_r428495266
##
File path:
common/network-common/src/main/java/org/apache/spark/network/util/DigestUtils.java
##
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache
AmplabJenkins removed a comment on pull request #28583:
URL: https://github.com/apache/spark/pull/28583#issuecomment-631948059
This is an automated message from the Apache Git Service.
To respond to the message, please log on
viirya commented on a change in pull request #28556:
URL: https://github.com/apache/spark/pull/28556#discussion_r428520430
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/NestedColumnAliasing.scala
##
@@ -82,6 +87,8 @@ object
zhengruifeng commented on pull request #28595:
URL: https://github.com/apache/spark/pull/28595#issuecomment-631964130
Param `k` is also used in `RankingEvaluator` and `ALS`, is it reasonable to
reuse this shared param in them?
cloud-fan commented on a change in pull request #28534:
URL: https://github.com/apache/spark/pull/28534#discussion_r428472274
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala
##
@@ -424,6 +424,9 @@ object FunctionRegistry
cloud-fan commented on a change in pull request #28534:
URL: https://github.com/apache/spark/pull/28534#discussion_r428472315
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala
##
@@ -424,6 +424,9 @@ object FunctionRegistry
AmplabJenkins removed a comment on pull request #28556:
URL: https://github.com/apache/spark/pull/28556#issuecomment-631915587
This is an automated message from the Apache Git Service.
To respond to the message, please log on
TJX2014 commented on a change in pull request #28534:
URL: https://github.com/apache/spark/pull/28534#discussion_r428478287
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala
##
@@ -424,6 +424,9 @@ object FunctionRegistry {
HyukjinKwon commented on a change in pull request #28593:
URL: https://github.com/apache/spark/pull/28593#discussion_r428488834
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##
@@ -2586,6 +2586,22 @@ object SQLConf {
SparkQA commented on pull request #28534:
URL: https://github.com/apache/spark/pull/28534#issuecomment-631930528
**[Test build #122918 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122918/testReport)**
for PR 28534 at commit
AmplabJenkins commented on pull request #28583:
URL: https://github.com/apache/spark/pull/28583#issuecomment-631948059
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #28583:
URL: https://github.com/apache/spark/pull/28583#issuecomment-631947436
**[Test build #122919 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122919/testReport)**
for PR 28583 at commit
sarutak commented on a change in pull request #28578:
URL: https://github.com/apache/spark/pull/28578#discussion_r427076227
##
File path: dev/run-tests.py
##
@@ -606,6 +609,8 @@ def main():
print("[info] Found the following changed modules:",
", ".join(x.name
AmplabJenkins removed a comment on pull request #28556:
URL: https://github.com/apache/spark/pull/28556#issuecomment-631924505
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #28556:
URL: https://github.com/apache/spark/pull/28556#issuecomment-631924505
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
cloud-fan commented on pull request #28534:
URL: https://github.com/apache/spark/pull/28534#issuecomment-631935225
LGTM except https://github.com/apache/spark/pull/28534/files#r427952417
This is an automated message from the
sarutak commented on pull request #28583:
URL: https://github.com/apache/spark/pull/28583#issuecomment-631944356
Test seems to be aborted.
This is an automated message from the Apache Git Service.
To respond to the message,
sarutak commented on pull request #28583:
URL: https://github.com/apache/spark/pull/28583#issuecomment-63194
retest this please.
This is an automated message from the Apache Git Service.
To respond to the message, please
Ngone51 commented on pull request #28584:
URL: https://github.com/apache/spark/pull/28584#issuecomment-631954552
Opened a separate PR https://github.com/apache/spark/pull/28596 to fix the
test @WeichenXu123
This is an
TJX2014 commented on a change in pull request #28534:
URL: https://github.com/apache/spark/pull/28534#discussion_r428512148
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
##
@@ -401,6 +401,78 @@ case class
AmplabJenkins removed a comment on pull request #28596:
URL: https://github.com/apache/spark/pull/28596#issuecomment-631955788
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins removed a comment on pull request #28534:
URL: https://github.com/apache/spark/pull/28534#issuecomment-631955875
This is an automated message from the Apache Git Service.
To respond to the message, please log on
GuoPhilipse commented on a change in pull request #28593:
URL: https://github.com/apache/spark/pull/28593#discussion_r428529561
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##
@@ -2586,6 +2586,22 @@ object SQLConf {
SparkQA commented on pull request #28534:
URL: https://github.com/apache/spark/pull/28534#issuecomment-631909451
**[Test build #122915 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122915/testReport)**
for PR 28534 at commit
AmplabJenkins commented on pull request #28534:
URL: https://github.com/apache/spark/pull/28534#issuecomment-631909869
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
GuoPhilipse commented on a change in pull request #28593:
URL: https://github.com/apache/spark/pull/28593#discussion_r428473216
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
##
@@ -1277,7 +1285,11 @@ abstract class CastBase
SparkQA commented on pull request #28556:
URL: https://github.com/apache/spark/pull/28556#issuecomment-631915185
**[Test build #122916 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122916/testReport)**
for PR 28556 at commit
cloud-fan commented on a change in pull request #28123:
URL: https://github.com/apache/spark/pull/28123#discussion_r428474929
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/bucketing/CoalesceBucketsInEquiJoin.scala
##
@@ -0,0 +1,127 @@
+/*
+ * Licensed
HyukjinKwon commented on a change in pull request #28534:
URL: https://github.com/apache/spark/pull/28534#discussion_r428474898
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala
##
@@ -424,6 +424,9 @@ object
AmplabJenkins commented on pull request #28556:
URL: https://github.com/apache/spark/pull/28556#issuecomment-631915587
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA removed a comment on pull request #28534:
URL: https://github.com/apache/spark/pull/28534#issuecomment-631892304
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins commented on pull request #28534:
URL: https://github.com/apache/spark/pull/28534#issuecomment-631922744
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins commented on pull request #28556:
URL: https://github.com/apache/spark/pull/28556#issuecomment-631922732
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins commented on pull request #28595:
URL: https://github.com/apache/spark/pull/28595#issuecomment-631922899
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #28595:
URL: https://github.com/apache/spark/pull/28595#issuecomment-631922678
**[Test build #122914 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122914/testReport)**
for PR 28595 at commit
AmplabJenkins removed a comment on pull request #28556:
URL: https://github.com/apache/spark/pull/28556#issuecomment-631922732
Merged build finished. Test FAILed.
This is an automated message from the Apache Git Service.
To
SparkQA removed a comment on pull request #28556:
URL: https://github.com/apache/spark/pull/28556#issuecomment-631915185
**[Test build #122916 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122916/testReport)**
for PR 28556 at commit
AmplabJenkins commented on pull request #28534:
URL: https://github.com/apache/spark/pull/28534#issuecomment-631922809
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
viirya commented on pull request #28556:
URL: https://github.com/apache/spark/pull/28556#issuecomment-631923383
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
AmplabJenkins removed a comment on pull request #28534:
URL: https://github.com/apache/spark/pull/28534#issuecomment-631922744
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins removed a comment on pull request #28595:
URL: https://github.com/apache/spark/pull/28595#issuecomment-631922899
Merged build finished. Test FAILed.
This is an automated message from the Apache Git Service.
To
SparkQA removed a comment on pull request #28595:
URL: https://github.com/apache/spark/pull/28595#issuecomment-631892298
**[Test build #122914 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122914/testReport)**
for PR 28595 at commit
AmplabJenkins commented on pull request #28534:
URL: https://github.com/apache/spark/pull/28534#issuecomment-631955875
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins commented on pull request #28596:
URL: https://github.com/apache/spark/pull/28596#issuecomment-631955788
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
zhengruifeng commented on pull request #28590:
URL: https://github.com/apache/spark/pull/28590#issuecomment-631962737
I do not object this PR. Is there any way to recompute another metric in
evaluator without involving mllib.metrics?
SparkQA commented on pull request #28556:
URL: https://github.com/apache/spark/pull/28556#issuecomment-631965191
**[Test build #122922 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122922/testReport)**
for PR 28556 at commit
AmplabJenkins removed a comment on pull request #28534:
URL: https://github.com/apache/spark/pull/28534#issuecomment-631909869
This is an automated message from the Apache Git Service.
To respond to the message, please log on
viirya commented on a change in pull request #28556:
URL: https://github.com/apache/spark/pull/28556#discussion_r428473708
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/NestedColumnAliasing.scala
##
@@ -34,7 +34,8 @@ object
viirya commented on a change in pull request #28556:
URL: https://github.com/apache/spark/pull/28556#discussion_r428473655
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/NestedColumnAliasing.scala
##
@@ -204,15 +211,8 @@ object
AmplabJenkins removed a comment on pull request #28556:
URL: https://github.com/apache/spark/pull/28556#issuecomment-631922741
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
AmplabJenkins removed a comment on pull request #28534:
URL: https://github.com/apache/spark/pull/28534#issuecomment-631922879
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
AmplabJenkins removed a comment on pull request #28595:
URL: https://github.com/apache/spark/pull/28595#issuecomment-631922905
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
SparkQA commented on pull request #28556:
URL: https://github.com/apache/spark/pull/28556#issuecomment-631923918
**[Test build #122917 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122917/testReport)**
for PR 28556 at commit
Ngone51 opened a new pull request #28596:
URL: https://github.com/apache/spark/pull/28596
### What changes were proposed in this pull request?
Change from `messages.toList.iterator` to `Iterator.single(messages.toList)`.
### Why are the changes needed?
Ngone51 commented on pull request #28596:
URL: https://github.com/apache/spark/pull/28596#issuecomment-631953628
ping @sarthfrey @WeichenXu123 @jiangxb1987
This is an automated message from the Apache Git Service.
To
TJX2014 commented on a change in pull request #28534:
URL: https://github.com/apache/spark/pull/28534#discussion_r428512148
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
##
@@ -401,6 +401,78 @@ case class
SparkQA commented on pull request #28534:
URL: https://github.com/apache/spark/pull/28534#issuecomment-631955288
**[Test build #122921 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122921/testReport)**
for PR 28534 at commit
SparkQA commented on pull request #28596:
URL: https://github.com/apache/spark/pull/28596#issuecomment-631955215
**[Test build #122920 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122920/testReport)**
for PR 28596 at commit
AmplabJenkins removed a comment on pull request #28556:
URL: https://github.com/apache/spark/pull/28556#issuecomment-631962223
This is an automated message from the Apache Git Service.
To respond to the message, please log on
viirya commented on pull request #28556:
URL: https://github.com/apache/spark/pull/28556#issuecomment-631962148
@maropu I addressed your comments. Could you help take another look? Thanks.
This is an automated message from
AmplabJenkins commented on pull request #28556:
URL: https://github.com/apache/spark/pull/28556#issuecomment-631962223
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
HyukjinKwon commented on a change in pull request #28593:
URL: https://github.com/apache/spark/pull/28593#discussion_r428543986
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##
@@ -2586,6 +2586,22 @@ object SQLConf {
AmplabJenkins removed a comment on pull request #28525:
URL: https://github.com/apache/spark/pull/28525#issuecomment-631997557
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
AmplabJenkins removed a comment on pull request #28592:
URL: https://github.com/apache/spark/pull/28592#issuecomment-632010389
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #28596:
URL: https://github.com/apache/spark/pull/28596#issuecomment-632027308
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #28128:
URL: https://github.com/apache/spark/pull/28128#issuecomment-632038999
**[Test build #122929 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122929/testReport)**
for PR 28128 at commit
cloud-fan commented on a change in pull request #28592:
URL: https://github.com/apache/spark/pull/28592#discussion_r428605898
##
File path: sql/core/src/test/resources/sql-tests/inputs/datetime-corrected.sql
##
@@ -0,0 +1,2 @@
+--SET spark.sql.legacy.timeParserPolicy=CORRECTED
yaooqinn commented on a change in pull request #28592:
URL: https://github.com/apache/spark/pull/28592#discussion_r428606030
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateFormatter.scala
##
@@ -40,7 +43,23 @@ class Iso8601DateFormatter(
turboFei commented on pull request #28525:
URL: https://github.com/apache/spark/pull/28525#issuecomment-631996915
Thanks for the review. I have modified the solution and save the digests
into independent file.
This is an
AmplabJenkins commented on pull request #28525:
URL: https://github.com/apache/spark/pull/28525#issuecomment-631996898
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins removed a comment on pull request #28525:
URL: https://github.com/apache/spark/pull/28525#issuecomment-631996898
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins removed a comment on pull request #28525:
URL: https://github.com/apache/spark/pull/28525#issuecomment-632000589
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
AmplabJenkins removed a comment on pull request #28583:
URL: https://github.com/apache/spark/pull/28583#issuecomment-632004289
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
AmplabJenkins removed a comment on pull request #28583:
URL: https://github.com/apache/spark/pull/28583#issuecomment-632004284
Merged build finished. Test FAILed.
This is an automated message from the Apache Git Service.
To
SparkQA commented on pull request #28592:
URL: https://github.com/apache/spark/pull/28592#issuecomment-632021131
**[Test build #122926 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122926/testReport)**
for PR 28592 at commit
AmplabJenkins commented on pull request #28592:
URL: https://github.com/apache/spark/pull/28592#issuecomment-632021179
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins removed a comment on pull request #28596:
URL: https://github.com/apache/spark/pull/28596#issuecomment-632027308
This is an automated message from the Apache Git Service.
To respond to the message, please log on
SparkQA commented on pull request #28592:
URL: https://github.com/apache/spark/pull/28592#issuecomment-632032488
**[Test build #122928 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122928/testReport)**
for PR 28592 at commit
AmplabJenkins removed a comment on pull request #28592:
URL: https://github.com/apache/spark/pull/28592#issuecomment-632033075
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #28592:
URL: https://github.com/apache/spark/pull/28592#issuecomment-632033075
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
cloud-fan edited a comment on pull request #28523:
URL: https://github.com/apache/spark/pull/28523#issuecomment-631869094
I thought you have canceled your veto in
https://github.com/apache/spark/pull/28523#issuecomment-628164147 , as what you
agreed on is exactly what this PR is doing.
AmplabJenkins removed a comment on pull request #28128:
URL: https://github.com/apache/spark/pull/28128#issuecomment-632039530
This is an automated message from the Apache Git Service.
To respond to the message, please log on
cloud-fan commented on a change in pull request #28534:
URL: https://github.com/apache/spark/pull/28534#discussion_r428607554
##
File path: sql/core/src/test/resources/sql-tests/results/ansi/datetime.sql.out
##
@@ -1,5 +1,65 @@
-- Automatically generated by SQLQueryTestSuite
SparkQA removed a comment on pull request #28556:
URL: https://github.com/apache/spark/pull/28556#issuecomment-631923918
**[Test build #122917 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122917/testReport)**
for PR 28556 at commit
SparkQA commented on pull request #28556:
URL: https://github.com/apache/spark/pull/28556#issuecomment-632046065
**[Test build #122917 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122917/testReport)**
for PR 28556 at commit
AmplabJenkins commented on pull request #28598:
URL: https://github.com/apache/spark/pull/28598#issuecomment-632046310
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins removed a comment on pull request #28576:
URL: https://github.com/apache/spark/pull/28576#issuecomment-631990533
This is an automated message from the Apache Git Service.
To respond to the message, please log on
TJX2014 commented on a change in pull request #28534:
URL: https://github.com/apache/spark/pull/28534#discussion_r428553501
##
File path: sql/core/src/test/resources/sql-tests/results/ansi/datetime.sql.out
##
@@ -1,5 +1,65 @@
-- Automatically generated by SQLQueryTestSuite
AmplabJenkins removed a comment on pull request #28525:
URL: https://github.com/apache/spark/pull/28525#issuecomment-631997545
Merged build finished. Test FAILed.
This is an automated message from the Apache Git Service.
To
SparkQA removed a comment on pull request #28525:
URL: https://github.com/apache/spark/pull/28525#issuecomment-631996474
**[Test build #122924 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122924/testReport)**
for PR 28525 at commit
AmplabJenkins commented on pull request #28525:
URL: https://github.com/apache/spark/pull/28525#issuecomment-631997545
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #28525:
URL: https://github.com/apache/spark/pull/28525#issuecomment-631997529
**[Test build #122924 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122924/testReport)**
for PR 28525 at commit
SparkQA commented on pull request #28525:
URL: https://github.com/apache/spark/pull/28525#issuecomment-631999704
**[Test build #122925 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122925/testReport)**
for PR 28525 at commit
cfmcgrady commented on a change in pull request #23900:
URL: https://github.com/apache/spark/pull/23900#discussion_r428563913
##
File path: python/pyspark/sql/types.py
##
@@ -1616,6 +1616,12 @@ def to_arrow_type(dt):
if type(dt.elementType) == TimestampType:
1 - 100 of 558 matches
Mail list logo