[GitHub] [spark] AmplabJenkins commented on pull request #27983: [SPARK-32105][SQL]Refactor current ScriptTransformationExec code

2020-07-07 Thread GitBox
AmplabJenkins commented on pull request #27983: URL: https://github.com/apache/spark/pull/27983#issuecomment-655266121 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #27983: [SPARK-32105][SQL]Refactor current ScriptTransformationExec code

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #27983: URL: https://github.com/apache/spark/pull/27983#issuecomment-655266121 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] SparkQA removed a comment on pull request #27983: [SPARK-32105][SQL]Refactor current ScriptTransformationExec code

2020-07-07 Thread GitBox
SparkQA removed a comment on pull request #27983: URL: https://github.com/apache/spark/pull/27983#issuecomment-655258914 **[Test build #125291 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125291/testReport)** for PR 27983 at commit [`f52f376`](https://gi

[GitHub] [spark] SparkQA commented on pull request #27983: [SPARK-32105][SQL]Refactor current ScriptTransformationExec code

2020-07-07 Thread GitBox
SparkQA commented on pull request #27983: URL: https://github.com/apache/spark/pull/27983#issuecomment-655266066 **[Test build #125291 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125291/testReport)** for PR 27983 at commit [`f52f376`](https://github.co

[GitHub] [spark] LantaoJin closed pull request #28935: [SPARK-20680][SQL] Adding HiveVoidType in Spark to be compatible with Hive

2020-07-07 Thread GitBox
LantaoJin closed pull request #28935: URL: https://github.com/apache/spark/pull/28935 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [spark] LantaoJin commented on pull request #28935: [SPARK-20680][SQL] Adding HiveVoidType in Spark to be compatible with Hive

2020-07-07 Thread GitBox
LantaoJin commented on pull request #28935: URL: https://github.com/apache/spark/pull/28935#issuecomment-655264946 Close this since #28833 merged. Thank you! This is an automated message from the Apache Git Service. To respon

[GitHub] [spark] LantaoJin commented on pull request #28833: [SPARK-20680][SQL] Spark-sql do not support for creating table with void column datatype

2020-07-07 Thread GitBox
LantaoJin commented on pull request #28833: URL: https://github.com/apache/spark/pull/28833#issuecomment-655263937 Thank you for all kindly review. This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29021: [WIP][SPARK-32201][SQL] More general skew join pattern matching

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #29021: URL: https://github.com/apache/spark/pull/29021#issuecomment-655262982 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #25290: [SPARK-28551][SQL]Add a Checker Rule when CTAS SQL with LOCATION

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #25290: URL: https://github.com/apache/spark/pull/25290#issuecomment-655262820 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/125

[GitHub] [spark] AmplabJenkins commented on pull request #29021: [WIP][SPARK-32201][SQL] More general skew join pattern matching

2020-07-07 Thread GitBox
AmplabJenkins commented on pull request #29021: URL: https://github.com/apache/spark/pull/29021#issuecomment-655262982 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA removed a comment on pull request #25290: [SPARK-28551][SQL]Add a Checker Rule when CTAS SQL with LOCATION

2020-07-07 Thread GitBox
SparkQA removed a comment on pull request #25290: URL: https://github.com/apache/spark/pull/25290#issuecomment-655256853 **[Test build #125288 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125288/testReport)** for PR 25290 at commit [`6db1d49`](https://gi

[GitHub] [spark] AmplabJenkins removed a comment on pull request #25290: [SPARK-28551][SQL]Add a Checker Rule when CTAS SQL with LOCATION

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #25290: URL: https://github.com/apache/spark/pull/25290#issuecomment-655262815 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] AmplabJenkins commented on pull request #25290: [SPARK-28551][SQL]Add a Checker Rule when CTAS SQL with LOCATION

2020-07-07 Thread GitBox
AmplabJenkins commented on pull request #25290: URL: https://github.com/apache/spark/pull/25290#issuecomment-655262815 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #29021: [WIP][SPARK-32201][SQL] More general skew join pattern matching

2020-07-07 Thread GitBox
SparkQA commented on pull request #29021: URL: https://github.com/apache/spark/pull/29021#issuecomment-655262748 **[Test build #125293 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125293/testReport)** for PR 29021 at commit [`80bef0d`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #25290: [SPARK-28551][SQL]Add a Checker Rule when CTAS SQL with LOCATION

2020-07-07 Thread GitBox
SparkQA commented on pull request #25290: URL: https://github.com/apache/spark/pull/25290#issuecomment-655262790 **[Test build #125288 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125288/testReport)** for PR 25290 at commit [`6db1d49`](https://github.co

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29026: [SPARK-28067][SPARK-32018] Fix decimal overflow issues

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #29026: URL: https://github.com/apache/spark/pull/29026#issuecomment-655261181 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29026: [SPARK-28067][SPARK-32018] Fix decimal overflow issues

2020-07-07 Thread GitBox
AmplabJenkins commented on pull request #29026: URL: https://github.com/apache/spark/pull/29026#issuecomment-655261181 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #29026: [SPARK-28067][SPARK-32018] Fix decimal overflow issues

2020-07-07 Thread GitBox
SparkQA commented on pull request #29026: URL: https://github.com/apache/spark/pull/29026#issuecomment-655260805 **[Test build #125292 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125292/testReport)** for PR 29026 at commit [`3717fc6`](https://github.com

[GitHub] [spark] sarutak commented on pull request #28803: [SPARK-31971][WEBUI] Add pagination support for all jobs timeline

2020-07-07 Thread GitBox
sarutak commented on pull request #28803: URL: https://github.com/apache/spark/pull/28803#issuecomment-655260973 cc: @dongjoon-hyun This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] cloud-fan commented on a change in pull request #28983: [SPARK-32159][SQL] Fix integration between Aggregator[Array[_], _, _] and UnresolvedMapObjects

2020-07-07 Thread GitBox
cloud-fan commented on a change in pull request #28983: URL: https://github.com/apache/spark/pull/28983#discussion_r451261067 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala ## @@ -678,6 +678,13 @@ object MapObjects {

[GitHub] [spark] cloud-fan commented on a change in pull request #29022: [SPARK-32207][SQL] Support 'F'-suffixed Float Literals

2020-07-07 Thread GitBox
cloud-fan commented on a change in pull request #29022: URL: https://github.com/apache/spark/pull/29022#discussion_r451260686 ## File path: docs/sql-ref-literals.md ## @@ -239,6 +244,10 @@ E [ + | - ] digit [ ... ] Case insensitive, indicates `DOUBLE`, which is an 8-byte

[GitHub] [spark] sarutak commented on a change in pull request #29029: [SPARK-32214][SQL] The type conversion function generated in makeFromJava for "other" type uses a wrong variable.

2020-07-07 Thread GitBox
sarutak commented on a change in pull request #29029: URL: https://github.com/apache/spark/pull/29029#discussion_r451260580 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/python/EvaluatePython.scala ## @@ -198,7 +198,7 @@ object EvaluatePython { ca

[GitHub] [spark] HyukjinKwon commented on a change in pull request #29029: [SPARK-32214][SQL] The type conversion function generated in makeFromJava for "other" type uses a wrong variable.

2020-07-07 Thread GitBox
HyukjinKwon commented on a change in pull request #29029: URL: https://github.com/apache/spark/pull/29029#discussion_r451260651 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/python/EvaluatePython.scala ## @@ -198,7 +198,7 @@ object EvaluatePython {

[GitHub] [spark] sarutak commented on a change in pull request #29029: [SPARK-32214][SQL] The type conversion function generated in makeFromJava for "other" type uses a wrong variable.

2020-07-07 Thread GitBox
sarutak commented on a change in pull request #29029: URL: https://github.com/apache/spark/pull/29029#discussion_r451260580 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/python/EvaluatePython.scala ## @@ -198,7 +198,7 @@ object EvaluatePython { ca

[GitHub] [spark] cloud-fan commented on pull request #29026: [SPARK-28067][SPARK-32018] Fix decimal overflow issues

2020-07-07 Thread GitBox
cloud-fan commented on pull request #29026: URL: https://github.com/apache/spark/pull/29026#issuecomment-655259660 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28676: [SPARK-31869][SQL] BroadcastHashJoinExec can utilize the build side for its output partitioning

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #28676: URL: https://github.com/apache/spark/pull/28676#issuecomment-655259202 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #27983: [SPARK-32105][SQL]Refactor current ScriptTransformationExec code

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #27983: URL: https://github.com/apache/spark/pull/27983#issuecomment-655259164 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] imback82 commented on a change in pull request #28676: [SPARK-31869][SQL] BroadcastHashJoinExec can utilize the build side for its output partitioning

2020-07-07 Thread GitBox
imback82 commented on a change in pull request #28676: URL: https://github.com/apache/spark/pull/28676#discussion_r451259973 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/joins/BroadcastJoinSuite.scala ## @@ -415,6 +417,192 @@ abstract class BroadcastJoi

[GitHub] [spark] AmplabJenkins commented on pull request #27983: [SPARK-32105][SQL]Refactor current ScriptTransformationExec code

2020-07-07 Thread GitBox
AmplabJenkins commented on pull request #27983: URL: https://github.com/apache/spark/pull/27983#issuecomment-655259164 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] imback82 commented on a change in pull request #28676: [SPARK-31869][SQL] BroadcastHashJoinExec can utilize the build side for its output partitioning

2020-07-07 Thread GitBox
imback82 commented on a change in pull request #28676: URL: https://github.com/apache/spark/pull/28676#discussion_r451259932 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoinExec.scala ## @@ -60,6 +62,66 @@ case class BroadcastHashJoi

[GitHub] [spark] AmplabJenkins commented on pull request #28676: [SPARK-31869][SQL] BroadcastHashJoinExec can utilize the build side for its output partitioning

2020-07-07 Thread GitBox
AmplabJenkins commented on pull request #28676: URL: https://github.com/apache/spark/pull/28676#issuecomment-655259202 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28977: [WIP] Add all hive.execution suite in the parallel test group

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #28977: URL: https://github.com/apache/spark/pull/28977#issuecomment-655259150 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] cloud-fan commented on pull request #29026: [SPARK-28067][SPARK-32018] Fix decimal overflow issues

2020-07-07 Thread GitBox
cloud-fan commented on pull request #29026: URL: https://github.com/apache/spark/pull/29026#issuecomment-655259298 > So now we have UnsafeRow.setDecimal silently returns a null for an overflowed decimal value in setDecimal, but getDecimal throws error. There is inconsistency here. Why is t

[GitHub] [spark] SparkQA commented on pull request #27983: [SPARK-32105][SQL]Refactor current ScriptTransformationExec code

2020-07-07 Thread GitBox
SparkQA commented on pull request #27983: URL: https://github.com/apache/spark/pull/27983#issuecomment-655258914 **[Test build #125291 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125291/testReport)** for PR 27983 at commit [`f52f376`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #28977: [WIP] Add all hive.execution suite in the parallel test group

2020-07-07 Thread GitBox
SparkQA commented on pull request #28977: URL: https://github.com/apache/spark/pull/28977#issuecomment-655258899 **[Test build #125289 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125289/testReport)** for PR 28977 at commit [`0124cf3`](https://github.com

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28676: [SPARK-31869][SQL] BroadcastHashJoinExec can utilize the build side for its output partitioning

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #28676: URL: https://github.com/apache/spark/pull/28676#issuecomment-655258792 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] imback82 commented on a change in pull request #28676: [SPARK-31869][SQL] BroadcastHashJoinExec can utilize the build side for its output partitioning

2020-07-07 Thread GitBox
imback82 commented on a change in pull request #28676: URL: https://github.com/apache/spark/pull/28676#discussion_r451259886 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoinExec.scala ## @@ -60,6 +62,66 @@ case class BroadcastHashJoi

[GitHub] [spark] AmplabJenkins commented on pull request #28977: [WIP] Add all hive.execution suite in the parallel test group

2020-07-07 Thread GitBox
AmplabJenkins commented on pull request #28977: URL: https://github.com/apache/spark/pull/28977#issuecomment-655259150 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #28676: [SPARK-31869][SQL] BroadcastHashJoinExec can utilize the build side for its output partitioning

2020-07-07 Thread GitBox
SparkQA commented on pull request #28676: URL: https://github.com/apache/spark/pull/28676#issuecomment-655258874 **[Test build #125290 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125290/testReport)** for PR 28676 at commit [`126ee53`](https://github.com

[GitHub] [spark] xuanyuanking commented on pull request #28977: [WIP] Add all hive.execution suite in the parallel test group

2020-07-07 Thread GitBox
xuanyuanking commented on pull request #28977: URL: https://github.com/apache/spark/pull/28977#issuecomment-655258638 retest this please This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [spark] AmplabJenkins commented on pull request #28676: [SPARK-31869][SQL] BroadcastHashJoinExec can utilize the build side for its output partitioning

2020-07-07 Thread GitBox
AmplabJenkins commented on pull request #28676: URL: https://github.com/apache/spark/pull/28676#issuecomment-655258792 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] imback82 commented on a change in pull request #28676: [SPARK-31869][SQL] BroadcastHashJoinExec can utilize the build side for its output partitioning

2020-07-07 Thread GitBox
imback82 commented on a change in pull request #28676: URL: https://github.com/apache/spark/pull/28676#discussion_r451259594 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoinExec.scala ## @@ -60,6 +62,66 @@ case class BroadcastHashJoi

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28859: [SPARK-32024][WEBUI] Update ApplicationStoreInfo.size during HistoryServerDiskManager initializing

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #28859: URL: https://github.com/apache/spark/pull/28859#issuecomment-655257914 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/125

[GitHub] [spark] AngersZhuuuu commented on pull request #27983: [SPARK-32105][SQL]Refactor current ScriptTransformationExec code

2020-07-07 Thread GitBox
AngersZh commented on pull request #27983: URL: https://github.com/apache/spark/pull/27983#issuecomment-655258140 @dongjoon-hyun do you know why test failed a lot of times of https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125070/testReport/ In my local it's ok to

[GitHub] [spark] SparkQA removed a comment on pull request #28676: [SPARK-31869][SQL] BroadcastHashJoinExec can utilize the build side for its output partitioning

2020-07-07 Thread GitBox
SparkQA removed a comment on pull request #28676: URL: https://github.com/apache/spark/pull/28676#issuecomment-655125865 **[Test build #125255 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125255/testReport)** for PR 28676 at commit [`c5f4803`](https://gi

[GitHub] [spark] AmplabJenkins commented on pull request #28859: [SPARK-32024][WEBUI] Update ApplicationStoreInfo.size during HistoryServerDiskManager initializing

2020-07-07 Thread GitBox
AmplabJenkins commented on pull request #28859: URL: https://github.com/apache/spark/pull/28859#issuecomment-655257909 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #28676: [SPARK-31869][SQL] BroadcastHashJoinExec can utilize the build side for its output partitioning

2020-07-07 Thread GitBox
SparkQA commented on pull request #28676: URL: https://github.com/apache/spark/pull/28676#issuecomment-655257968 **[Test build #125255 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125255/testReport)** for PR 28676 at commit [`c5f4803`](https://github.co

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28859: [SPARK-32024][WEBUI] Update ApplicationStoreInfo.size during HistoryServerDiskManager initializing

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #28859: URL: https://github.com/apache/spark/pull/28859#issuecomment-655257909 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] AngersZhuuuu commented on pull request #27983: [SPARK-32105][SQL]Refactor current ScriptTransformationExec code

2020-07-07 Thread GitBox
AngersZh commented on pull request #27983: URL: https://github.com/apache/spark/pull/27983#issuecomment-655257972 retest this please This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29022: [SPARK-32207][SQL] Support 'F'-suffixed Float Literals

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #29022: URL: https://github.com/apache/spark/pull/29022#issuecomment-655257219 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #25290: [SPARK-28551][SQL]Add a Checker Rule when CTAS SQL with LOCATION

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #25290: URL: https://github.com/apache/spark/pull/25290#issuecomment-655257280 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29022: [SPARK-32207][SQL] Support 'F'-suffixed Float Literals

2020-07-07 Thread GitBox
AmplabJenkins commented on pull request #29022: URL: https://github.com/apache/spark/pull/29022#issuecomment-655257219 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins commented on pull request #25290: [SPARK-28551][SQL]Add a Checker Rule when CTAS SQL with LOCATION

2020-07-07 Thread GitBox
AmplabJenkins commented on pull request #25290: URL: https://github.com/apache/spark/pull/25290#issuecomment-655257280 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA removed a comment on pull request #28859: [SPARK-32024][WEBUI] Update ApplicationStoreInfo.size during HistoryServerDiskManager initializing

2020-07-07 Thread GitBox
SparkQA removed a comment on pull request #28859: URL: https://github.com/apache/spark/pull/28859#issuecomment-655193968 **[Test build #125267 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125267/testReport)** for PR 28859 at commit [`ed05872`](https://gi

[GitHub] [spark] SparkQA commented on pull request #28859: [SPARK-32024][WEBUI] Update ApplicationStoreInfo.size during HistoryServerDiskManager initializing

2020-07-07 Thread GitBox
SparkQA commented on pull request #28859: URL: https://github.com/apache/spark/pull/28859#issuecomment-655257055 **[Test build #125267 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125267/testReport)** for PR 28859 at commit [`ed05872`](https://github.co

[GitHub] [spark] cloud-fan commented on a change in pull request #29026: [SPARK-28067][SPARK-32018] Fix decimal overflow issues

2020-07-07 Thread GitBox
cloud-fan commented on a change in pull request #29026: URL: https://github.com/apache/spark/pull/29026#discussion_r451258078 ## File path: sql/core/src/test/scala/org/apache/spark/sql/UnsafeRowSuite.scala ## @@ -178,4 +178,14 @@ class UnsafeRowSuite extends SparkFunSuite {

[GitHub] [spark] SparkQA commented on pull request #29022: [SPARK-32207][SQL] Support 'F'-suffixed Float Literals

2020-07-07 Thread GitBox
SparkQA commented on pull request #29022: URL: https://github.com/apache/spark/pull/29022#issuecomment-655256843 **[Test build #125287 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125287/testReport)** for PR 29022 at commit [`4439bb6`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #25290: [SPARK-28551][SQL]Add a Checker Rule when CTAS SQL with LOCATION

2020-07-07 Thread GitBox
SparkQA commented on pull request #25290: URL: https://github.com/apache/spark/pull/25290#issuecomment-655256853 **[Test build #125288 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125288/testReport)** for PR 25290 at commit [`6db1d49`](https://github.com

[GitHub] [spark] cloud-fan commented on a change in pull request #29026: [SPARK-28067][SPARK-32018] Fix decimal overflow issues

2020-07-07 Thread GitBox
cloud-fan commented on a change in pull request #29026: URL: https://github.com/apache/spark/pull/29026#discussion_r451257595 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Sum.scala ## @@ -58,39 +58,50 @@ case class Sum(child: Ex

[GitHub] [spark] HyukjinKwon closed pull request #29023: local_connect_and_auth takes 2 arguments, 3 given

2020-07-07 Thread GitBox
HyukjinKwon closed pull request #29023: URL: https://github.com/apache/spark/pull/29023 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28363: [SPARK-27188][SS] FileStreamSink: provide a new option to have retention on output files

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #28363: URL: https://github.com/apache/spark/pull/28363#issuecomment-655255939 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/125

[GitHub] [spark] SparkQA removed a comment on pull request #28977: [WIP] Add all hive.execution suite in the parallel test group

2020-07-07 Thread GitBox
SparkQA removed a comment on pull request #28977: URL: https://github.com/apache/spark/pull/28977#issuecomment-655246106 **[Test build #125283 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125283/testReport)** for PR 28977 at commit [`0124cf3`](https://gi

[GitHub] [spark] AngersZhuuuu commented on pull request #25290: [SPARK-28551][SQL]Add a Checker Rule when CTAS SQL with LOCATION

2020-07-07 Thread GitBox
AngersZh commented on pull request #25290: URL: https://github.com/apache/spark/pull/25290#issuecomment-655256004 retest this please This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28363: [SPARK-27188][SS] FileStreamSink: provide a new option to have retention on output files

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #28363: URL: https://github.com/apache/spark/pull/28363#issuecomment-655255933 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] AmplabJenkins commented on pull request #28363: [SPARK-27188][SS] FileStreamSink: provide a new option to have retention on output files

2020-07-07 Thread GitBox
AmplabJenkins commented on pull request #28363: URL: https://github.com/apache/spark/pull/28363#issuecomment-655255933 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29022: [SPARK-32207][SQL] Support 'F'-suffixed Float Literals

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #29022: URL: https://github.com/apache/spark/pull/29022#issuecomment-655255187 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28986: [SPARK-32160][CORE][PYSPARK] Disallow to create SparkContext in executors.

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #28986: URL: https://github.com/apache/spark/pull/28986#issuecomment-655255367 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28986: [SPARK-32160][CORE][PYSPARK] Disallow to create SparkContext in executors.

2020-07-07 Thread GitBox
AmplabJenkins commented on pull request #28986: URL: https://github.com/apache/spark/pull/28986#issuecomment-655255367 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28969: [SPARK-32150][BUILD] Upgrade to ZStd 1.4.5-4

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #28969: URL: https://github.com/apache/spark/pull/28969#issuecomment-655255254 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28969: [SPARK-32150][BUILD] Upgrade to ZStd 1.4.5-4

2020-07-07 Thread GitBox
AmplabJenkins commented on pull request #28969: URL: https://github.com/apache/spark/pull/28969#issuecomment-655255254 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28977: [WIP] Add all hive.execution suite in the parallel test group

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #28977: URL: https://github.com/apache/spark/pull/28977#issuecomment-655255181 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #28977: [WIP] Add all hive.execution suite in the parallel test group

2020-07-07 Thread GitBox
SparkQA commented on pull request #28977: URL: https://github.com/apache/spark/pull/28977#issuecomment-655255136 **[Test build #125283 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125283/testReport)** for PR 28977 at commit [`0124cf3`](https://github.co

[GitHub] [spark] SparkQA removed a comment on pull request #28363: [SPARK-27188][SS] FileStreamSink: provide a new option to have retention on output files

2020-07-07 Thread GitBox
SparkQA removed a comment on pull request #28363: URL: https://github.com/apache/spark/pull/28363#issuecomment-655094394 **[Test build #125252 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125252/testReport)** for PR 28363 at commit [`b648156`](https://gi

[GitHub] [spark] AmplabJenkins commented on pull request #29022: [SPARK-32207][SQL] Support 'F'-suffixed Float Literals

2020-07-07 Thread GitBox
AmplabJenkins commented on pull request #29022: URL: https://github.com/apache/spark/pull/29022#issuecomment-655255187 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #28969: [SPARK-32150][BUILD] Upgrade to ZStd 1.4.5-4

2020-07-07 Thread GitBox
SparkQA commented on pull request #28969: URL: https://github.com/apache/spark/pull/28969#issuecomment-655254853 **[Test build #125286 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125286/testReport)** for PR 28969 at commit [`7abf2b5`](https://github.com

[GitHub] [spark] yaooqinn commented on pull request #29022: [SPARK-32207][SQL] Support 'F'-suffixed Float Literals

2020-07-07 Thread GitBox
yaooqinn commented on pull request #29022: URL: https://github.com/apache/spark/pull/29022#issuecomment-655254978 documentation updated, thanks for reminding me @maropu This is an automated message from the Apache Git Servic

[GitHub] [spark] SparkQA commented on pull request #28363: [SPARK-27188][SS] FileStreamSink: provide a new option to have retention on output files

2020-07-07 Thread GitBox
SparkQA commented on pull request #28363: URL: https://github.com/apache/spark/pull/28363#issuecomment-655255038 **[Test build #125252 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125252/testReport)** for PR 28363 at commit [`b648156`](https://github.co

[GitHub] [spark] SparkQA commented on pull request #28986: [SPARK-32160][CORE][PYSPARK] Disallow to create SparkContext in executors.

2020-07-07 Thread GitBox
SparkQA commented on pull request #28986: URL: https://github.com/apache/spark/pull/28986#issuecomment-655255039 **[Test build #125285 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125285/testReport)** for PR 28986 at commit [`0faac2a`](https://github.com

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28904: [SPARK-30462][SS] Streamline the logic on file stream source and sink metadata log to avoid memory issue

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #28904: URL: https://github.com/apache/spark/pull/28904#issuecomment-655253940 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/125

[GitHub] [spark] HyukjinKwon commented on pull request #28969: [SPARK-32150][BUILD] Upgrade to ZStd 1.4.5-4

2020-07-07 Thread GitBox
HyukjinKwon commented on pull request #28969: URL: https://github.com/apache/spark/pull/28969#issuecomment-655254120 retest this please This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28904: [SPARK-30462][SS] Streamline the logic on file stream source and sink metadata log to avoid memory issue

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #28904: URL: https://github.com/apache/spark/pull/28904#issuecomment-655253929 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] HyukjinKwon commented on pull request #28986: [SPARK-32160][CORE][PYSPARK] Disallow to create SparkContext in executors.

2020-07-07 Thread GitBox
HyukjinKwon commented on pull request #28986: URL: https://github.com/apache/spark/pull/28986#issuecomment-655254163 retest this please This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [spark] AmplabJenkins commented on pull request #28904: [SPARK-30462][SS] Streamline the logic on file stream source and sink metadata log to avoid memory issue

2020-07-07 Thread GitBox
AmplabJenkins commented on pull request #28904: URL: https://github.com/apache/spark/pull/28904#issuecomment-655253929 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA removed a comment on pull request #28904: [SPARK-30462][SS] Streamline the logic on file stream source and sink metadata log to avoid memory issue

2020-07-07 Thread GitBox
SparkQA removed a comment on pull request #28904: URL: https://github.com/apache/spark/pull/28904#issuecomment-655089674 **[Test build #125249 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125249/testReport)** for PR 28904 at commit [`8034ca4`](https://gi

[GitHub] [spark] AmplabJenkins commented on pull request #28983: [SPARK-32159][SQL] Fix integration between Aggregator[Array[_], _, _] and UnresolvedMapObjects

2020-07-07 Thread GitBox
AmplabJenkins commented on pull request #28983: URL: https://github.com/apache/spark/pull/28983#issuecomment-655253184 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] skambha commented on a change in pull request #29026: [SPARK-28067][SPARK-32018] Fix decimal overflow issues

2020-07-07 Thread GitBox
skambha commented on a change in pull request #29026: URL: https://github.com/apache/spark/pull/29026#discussion_r451254873 ## File path: sql/core/src/test/scala/org/apache/spark/sql/UnsafeRowSuite.scala ## @@ -178,4 +178,14 @@ class UnsafeRowSuite extends SparkFunSuite {

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28983: [SPARK-32159][SQL] Fix integration between Aggregator[Array[_], _, _] and UnresolvedMapObjects

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #28983: URL: https://github.com/apache/spark/pull/28983#issuecomment-655253184 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #28904: [SPARK-30462][SS] Streamline the logic on file stream source and sink metadata log to avoid memory issue

2020-07-07 Thread GitBox
SparkQA commented on pull request #28904: URL: https://github.com/apache/spark/pull/28904#issuecomment-655252709 **[Test build #125249 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125249/testReport)** for PR 28904 at commit [`8034ca4`](https://github.co

[GitHub] [spark] skambha edited a comment on pull request #29026: [SPARK-28067][SPARK-32018] Fix decimal overflow issues

2020-07-07 Thread GitBox
skambha edited a comment on pull request #29026: URL: https://github.com/apache/spark/pull/29026#issuecomment-655252629 @cloud-fan, Thanks for looking into covering some more cases. If we change the UnsafeRow.setDecimal overflow logic, I agree the implementation of the sum needs to change

[GitHub] [spark] skambha commented on pull request #29026: [SPARK-28067][SPARK-32018] Fix decimal overflow issues

2020-07-07 Thread GitBox
skambha commented on pull request #29026: URL: https://github.com/apache/spark/pull/29026#issuecomment-655252629 @cloud-fan, Thanks for looking into covering some more cases. If we change the UnsafeRow.setDecimal overflow logic, I agree the implementation of the sum needs to change. This

[GitHub] [spark] SparkQA commented on pull request #28983: [SPARK-32159][SQL] Fix integration between Aggregator[Array[_], _, _] and UnresolvedMapObjects

2020-07-07 Thread GitBox
SparkQA commented on pull request #28983: URL: https://github.com/apache/spark/pull/28983#issuecomment-655252499 **[Test build #125284 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125284/testReport)** for PR 28983 at commit [`ee96cc0`](https://github.com

[GitHub] [spark] maropu commented on pull request #28983: [SPARK-32159][SQL] Fix integration between Aggregator[Array[_], _, _] and UnresolvedMapObjects

2020-07-07 Thread GitBox
maropu commented on pull request #28983: URL: https://github.com/apache/spark/pull/28983#issuecomment-655252124 retest this please This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28969: [SPARK-32150][BUILD] Upgrade to ZStd 1.4.5-4

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #28969: URL: https://github.com/apache/spark/pull/28969#issuecomment-655251380 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/125

[GitHub] [spark] maropu commented on a change in pull request #28979: [SPARK-32154][SQL] Use ExpressionEncoder for the return type of ScalaUDF to convert to catalyst type

2020-07-07 Thread GitBox
maropu commented on a change in pull request #28979: URL: https://github.com/apache/spark/pull/28979#discussion_r451253446 ## File path: sql/core/src/test/scala/org/apache/spark/sql/UDFSuite.scala ## @@ -504,23 +510,83 @@ class UDFSuite extends QueryTest with SharedSparkSession

[GitHub] [spark] maropu commented on pull request #28979: [SPARK-32154][SQL] Use ExpressionEncoder for the return type of ScalaUDF to convert to catalyst type

2020-07-07 Thread GitBox
maropu commented on pull request #28979: URL: https://github.com/apache/spark/pull/28979#issuecomment-655251699 LGTM except for the minor comments. This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28969: [SPARK-32150][BUILD] Upgrade to ZStd 1.4.5-4

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #28969: URL: https://github.com/apache/spark/pull/28969#issuecomment-655251375 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] AmplabJenkins commented on pull request #28969: [SPARK-32150][BUILD] Upgrade to ZStd 1.4.5-4

2020-07-07 Thread GitBox
AmplabJenkins commented on pull request #28969: URL: https://github.com/apache/spark/pull/28969#issuecomment-655251375 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] maropu commented on a change in pull request #28979: [SPARK-32154][SQL] Use ExpressionEncoder for the return type of ScalaUDF to convert to catalyst type

2020-07-07 Thread GitBox
maropu commented on a change in pull request #28979: URL: https://github.com/apache/spark/pull/28979#discussion_r451252635 ## File path: sql/core/src/main/scala/org/apache/spark/sql/expressions/UserDefinedFunction.scala ## @@ -94,6 +94,7 @@ private[spark] case class SparkUserD

[GitHub] [spark] SparkQA removed a comment on pull request #28969: [SPARK-32150][BUILD] Upgrade to ZStd 1.4.5-4

2020-07-07 Thread GitBox
SparkQA removed a comment on pull request #28969: URL: https://github.com/apache/spark/pull/28969#issuecomment-655191653 **[Test build #125266 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125266/testReport)** for PR 28969 at commit [`7abf2b5`](https://gi

[GitHub] [spark] SparkQA commented on pull request #28969: [SPARK-32150][BUILD] Upgrade to ZStd 1.4.5-4

2020-07-07 Thread GitBox
SparkQA commented on pull request #28969: URL: https://github.com/apache/spark/pull/28969#issuecomment-655250543 **[Test build #125266 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125266/testReport)** for PR 28969 at commit [`7abf2b5`](https://github.co

<    1   2   3   4   5   6   7   8   9   10   >