SparkQA commented on pull request #28683:
URL: https://github.com/apache/spark/pull/28683#issuecomment-656184039
**[Test build #125488 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125488/testReport)**
for PR 28683 at commit
AmplabJenkins commented on pull request #29022:
URL: https://github.com/apache/spark/pull/29022#issuecomment-656183916
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
cloud-fan commented on pull request #29036:
URL: https://github.com/apache/spark/pull/29036#issuecomment-656183221
@yaooqinn can you take a look?
This is an automated message from the Apache Git Service.
To respond to the
cloud-fan commented on pull request #28683:
URL: https://github.com/apache/spark/pull/28683#issuecomment-656182036
retest this please
This is an automated message from the Apache Git Service.
To respond to the message,
warrenzhu25 commented on a change in pull request #29044:
URL: https://github.com/apache/spark/pull/29044#discussion_r452283691
##
File path: bin/load-spark-env.cmd
##
@@ -29,10 +29,7 @@ if [%SPARK_ENV_LOADED%] == [] (
set SPARK_CONF_DIR=%~dp0..\conf
)
- set
cloud-fan commented on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-656182156
retest this please
This is an automated message from the Apache Git Service.
To respond to the message,
SparkQA commented on pull request #29022:
URL: https://github.com/apache/spark/pull/29022#issuecomment-656181444
**[Test build #125443 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125443/testReport)**
for PR 29022 at commit
SparkQA removed a comment on pull request #29022:
URL: https://github.com/apache/spark/pull/29022#issuecomment-655948604
**[Test build #125443 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125443/testReport)**
for PR 29022 at commit
cloud-fan commented on a change in pull request #29055:
URL: https://github.com/apache/spark/pull/29055#discussion_r452286175
##
File path: docs/sql-ref-ansi-compliance.md
##
@@ -193,7 +193,7 @@ Below is a list of all the keywords in Spark SQL.
AmplabJenkins removed a comment on pull request #29055:
URL: https://github.com/apache/spark/pull/29055#issuecomment-656180949
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
AmplabJenkins removed a comment on pull request #29055:
URL: https://github.com/apache/spark/pull/29055#issuecomment-656180926
Merged build finished. Test FAILed.
This is an automated message from the Apache Git Service.
To
AmplabJenkins commented on pull request #29055:
URL: https://github.com/apache/spark/pull/29055#issuecomment-656180926
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins removed a comment on pull request #28972:
URL: https://github.com/apache/spark/pull/28972#issuecomment-656180723
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #28972:
URL: https://github.com/apache/spark/pull/28972#issuecomment-656180723
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA removed a comment on pull request #29055:
URL: https://github.com/apache/spark/pull/29055#issuecomment-656145164
**[Test build #125480 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125480/testReport)**
for PR 29055 at commit
SparkQA commented on pull request #28972:
URL: https://github.com/apache/spark/pull/28972#issuecomment-656180026
**[Test build #125486 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125486/testReport)**
for PR 28972 at commit
SparkQA commented on pull request #29055:
URL: https://github.com/apache/spark/pull/29055#issuecomment-656180303
**[Test build #125480 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125480/testReport)**
for PR 29055 at commit
warrenzhu25 commented on a change in pull request #29044:
URL: https://github.com/apache/spark/pull/29044#discussion_r452283691
##
File path: bin/load-spark-env.cmd
##
@@ -29,10 +29,7 @@ if [%SPARK_ENV_LOADED%] == [] (
set SPARK_CONF_DIR=%~dp0..\conf
)
- set
HyukjinKwon commented on a change in pull request #29057:
URL: https://github.com/apache/spark/pull/29057#discussion_r452282789
##
File path: python/run-tests.py
##
@@ -161,7 +161,7 @@ def run_individual_python_test(target_dir, test_name,
pyspark_python):
def
dongjoon-hyun commented on a change in pull request #29057:
URL: https://github.com/apache/spark/pull/29057#discussion_r452282186
##
File path: python/run-tests.py
##
@@ -161,7 +161,7 @@ def run_individual_python_test(target_dir, test_name,
pyspark_python):
def
AmplabJenkins removed a comment on pull request #28972:
URL: https://github.com/apache/spark/pull/28972#issuecomment-655817404
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
dongjoon-hyun commented on a change in pull request #29057:
URL: https://github.com/apache/spark/pull/29057#discussion_r452281919
##
File path: python/run-tests.py
##
@@ -161,7 +161,7 @@ def run_individual_python_test(target_dir, test_name,
pyspark_python):
def
tgravescs commented on pull request #28972:
URL: https://github.com/apache/spark/pull/28972#issuecomment-656177528
test this please
This is an automated message from the Apache Git Service.
To respond to the message, please
Ngone51 commented on pull request #28850:
URL: https://github.com/apache/spark/pull/28850#issuecomment-656175898
I see, change now may break users' code as well as libraries who depend on
Spark. cc @wankunde
This is an
tgravescs commented on a change in pull request #28911:
URL: https://github.com/apache/spark/pull/28911#discussion_r452276119
##
File path:
core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala
##
@@ -478,30 +475,43 @@ final class
HyukjinKwon commented on a change in pull request #29057:
URL: https://github.com/apache/spark/pull/29057#discussion_r452278579
##
File path: .github/workflows/master.yml
##
@@ -9,148 +9,233 @@ on:
- master
jobs:
+ # TODO(SPARK-32248): Recover JDK 11 builds
+ #
dongjoon-hyun commented on a change in pull request #29057:
URL: https://github.com/apache/spark/pull/29057#discussion_r452278013
##
File path: .github/workflows/master.yml
##
@@ -9,148 +9,233 @@ on:
- master
jobs:
+ # TODO(SPARK-32248): Recover JDK 11 builds
+ #
dongjoon-hyun commented on a change in pull request #29057:
URL: https://github.com/apache/spark/pull/29057#discussion_r452278013
##
File path: .github/workflows/master.yml
##
@@ -9,148 +9,233 @@ on:
- master
jobs:
+ # TODO(SPARK-32248): Recover JDK 11 builds
+ #
AmplabJenkins removed a comment on pull request #27983:
URL: https://github.com/apache/spark/pull/27983#issuecomment-656173367
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
AmplabJenkins removed a comment on pull request #28683:
URL: https://github.com/apache/spark/pull/28683#issuecomment-656173389
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
AmplabJenkins removed a comment on pull request #27983:
URL: https://github.com/apache/spark/pull/27983#issuecomment-656173357
Merged build finished. Test FAILed.
This is an automated message from the Apache Git Service.
To
AmplabJenkins removed a comment on pull request #28683:
URL: https://github.com/apache/spark/pull/28683#issuecomment-656173373
Merged build finished. Test FAILed.
This is an automated message from the Apache Git Service.
To
gengliangwang commented on pull request #29057:
URL: https://github.com/apache/spark/pull/29057#issuecomment-656173511
```
on:
push:
branches:
- master
```
I think we should disable the on push trigger if we are running all jobs
AmplabJenkins commented on pull request #27983:
URL: https://github.com/apache/spark/pull/27983#issuecomment-656173357
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins commented on pull request #28683:
URL: https://github.com/apache/spark/pull/28683#issuecomment-656173373
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
HyukjinKwon commented on a change in pull request #29057:
URL: https://github.com/apache/spark/pull/29057#discussion_r452274868
##
File path: .github/workflows/master.yml
##
@@ -9,148 +9,233 @@ on:
- master
Review comment:
Oh, BTW, @dongjoon-hyun. I happened to
HeartSaVioR edited a comment on pull request #28412:
URL: https://github.com/apache/spark/pull/28412#issuecomment-656158596
Yeah I’m OK either way. I think both ways wouldn’t bring major issues in
reality.
This is an
AmplabJenkins removed a comment on pull request #29057:
URL: https://github.com/apache/spark/pull/29057#issuecomment-656171780
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins removed a comment on pull request #28746:
URL: https://github.com/apache/spark/pull/28746#issuecomment-656167420
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins removed a comment on pull request #29041:
URL: https://github.com/apache/spark/pull/29041#issuecomment-656170572
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
AmplabJenkins commented on pull request #29057:
URL: https://github.com/apache/spark/pull/29057#issuecomment-656171780
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA removed a comment on pull request #27983:
URL: https://github.com/apache/spark/pull/27983#issuecomment-656056783
**[Test build #125461 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125461/testReport)**
for PR 27983 at commit
SparkQA commented on pull request #29057:
URL: https://github.com/apache/spark/pull/29057#issuecomment-656171138
**[Test build #125485 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125485/testReport)**
for PR 29057 at commit
AmplabJenkins removed a comment on pull request #29007:
URL: https://github.com/apache/spark/pull/29007#issuecomment-656167408
This is an automated message from the Apache Git Service.
To respond to the message, please log on
SparkQA commented on pull request #29041:
URL: https://github.com/apache/spark/pull/29041#issuecomment-656167511
**[Test build #125442 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125442/testReport)**
for PR 29041 at commit
SparkQA commented on pull request #27983:
URL: https://github.com/apache/spark/pull/27983#issuecomment-656171384
**[Test build #125461 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125461/testReport)**
for PR 27983 at commit
AmplabJenkins commented on pull request #29057:
URL: https://github.com/apache/spark/pull/29057#issuecomment-656167362
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins removed a comment on pull request #29041:
URL: https://github.com/apache/spark/pull/29041#issuecomment-656170564
Merged build finished. Test FAILed.
This is an automated message from the Apache Git Service.
To
AmplabJenkins commented on pull request #29007:
URL: https://github.com/apache/spark/pull/29007#issuecomment-656167408
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins commented on pull request #29041:
URL: https://github.com/apache/spark/pull/29041#issuecomment-656170564
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA removed a comment on pull request #28683:
URL: https://github.com/apache/spark/pull/28683#issuecomment-655956230
**[Test build #125449 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125449/testReport)**
for PR 28683 at commit
SparkQA commented on pull request #28683:
URL: https://github.com/apache/spark/pull/28683#issuecomment-656169166
**[Test build #125449 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125449/testReport)**
for PR 28683 at commit
SparkQA removed a comment on pull request #29041:
URL: https://github.com/apache/spark/pull/29041#issuecomment-655948609
**[Test build #125442 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125442/testReport)**
for PR 29041 at commit
srowen commented on pull request #28850:
URL: https://github.com/apache/spark/pull/28850#issuecomment-656168022
Yeah, but your change now means they cannot get this value at all. That
seems like it could break other code.
AmplabJenkins commented on pull request #28746:
URL: https://github.com/apache/spark/pull/28746#issuecomment-656167420
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins removed a comment on pull request #29057:
URL: https://github.com/apache/spark/pull/29057#issuecomment-656167362
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins removed a comment on pull request #29039:
URL: https://github.com/apache/spark/pull/29039#issuecomment-656166786
This is an automated message from the Apache Git Service.
To respond to the message, please log on
SparkQA commented on pull request #28746:
URL: https://github.com/apache/spark/pull/28746#issuecomment-656166583
**[Test build #125484 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125484/testReport)**
for PR 28746 at commit
SparkQA commented on pull request #29007:
URL: https://github.com/apache/spark/pull/29007#issuecomment-656166554
**[Test build #125483 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125483/testReport)**
for PR 29007 at commit
SparkQA removed a comment on pull request #29039:
URL: https://github.com/apache/spark/pull/29039#issuecomment-656123851
**[Test build #125475 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125475/testReport)**
for PR 29039 at commit
Ngone51 commented on pull request #28850:
URL: https://github.com/apache/spark/pull/28850#issuecomment-656166600
Those threads could be created by third-party libraries. They are not
controlled by neither Spark nor users. So I think it's hard to do something in
the first place.
AmplabJenkins commented on pull request #29039:
URL: https://github.com/apache/spark/pull/29039#issuecomment-656166786
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #29057:
URL: https://github.com/apache/spark/pull/29057#issuecomment-656166571
**[Test build #125482 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125482/testReport)**
for PR 29057 at commit
SparkQA commented on pull request #29039:
URL: https://github.com/apache/spark/pull/29039#issuecomment-656165757
**[Test build #125475 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125475/testReport)**
for PR 29039 at commit
srowen commented on pull request #29010:
URL: https://github.com/apache/spark/pull/29010#issuecomment-656164572
Merged to master
This is an automated message from the Apache Git Service.
To respond to the message, please log
srowen closed pull request #29010:
URL: https://github.com/apache/spark/pull/29010
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
AmplabJenkins removed a comment on pull request #29050:
URL: https://github.com/apache/spark/pull/29050#issuecomment-656163231
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
srowen commented on pull request #29007:
URL: https://github.com/apache/spark/pull/29007#issuecomment-656163770
Jenkins test this please
This is an automated message from the Apache Git Service.
To respond to the message,
AmplabJenkins removed a comment on pull request #29050:
URL: https://github.com/apache/spark/pull/29050#issuecomment-656163218
Merged build finished. Test FAILed.
This is an automated message from the Apache Git Service.
To
AmplabJenkins commented on pull request #29050:
URL: https://github.com/apache/spark/pull/29050#issuecomment-656163218
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
srowen commented on pull request #28850:
URL: https://github.com/apache/spark/pull/28850#issuecomment-656161953
This implies that some callers get a reference to this that they don't need
at all. Can we just not retrieve them or clear them in the first place?
AmplabJenkins removed a comment on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-656160676
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
AmplabJenkins removed a comment on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-656160661
Merged build finished. Test FAILed.
This is an automated message from the Apache Git Service.
To
AmplabJenkins commented on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-656160661
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA removed a comment on pull request #29050:
URL: https://github.com/apache/spark/pull/29050#issuecomment-655956198
**[Test build #125447 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125447/testReport)**
for PR 29050 at commit
SparkQA commented on pull request #29050:
URL: https://github.com/apache/spark/pull/29050#issuecomment-656159836
**[Test build #125447 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125447/testReport)**
for PR 29050 at commit
AmplabJenkins removed a comment on pull request #28904:
URL: https://github.com/apache/spark/pull/28904#issuecomment-656158267
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Ngone51 commented on pull request #29049:
URL: https://github.com/apache/spark/pull/29049#issuecomment-656158448
I'd like to continue the work and please also give more inputs if possible.
Thanks!
This is an
AmplabJenkins removed a comment on pull request #28904:
URL: https://github.com/apache/spark/pull/28904#issuecomment-656158252
Merged build finished. Test FAILed.
This is an automated message from the Apache Git Service.
To
HyukjinKwon removed a comment on pull request #29057:
URL: https://github.com/apache/spark/pull/29057#issuecomment-656149858
I already individually tested, and I am pretty sure it will show a green
light. See also https://github.com/HyukjinKwon/spark/runs/854113657
HeartSaVioR commented on pull request #28412:
URL: https://github.com/apache/spark/pull/28412#issuecomment-656158596
Yeah I’m OK either way. I think both ways wouldn’t bring issues in reality.
This is an automated message
SparkQA removed a comment on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-655972624
**[Test build #125454 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125454/testReport)**
for PR 28926 at commit
AmplabJenkins commented on pull request #28904:
URL: https://github.com/apache/spark/pull/28904#issuecomment-656158252
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #28926:
URL: https://github.com/apache/spark/pull/28926#issuecomment-656158035
**[Test build #125454 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125454/testReport)**
for PR 28926 at commit
AmplabJenkins removed a comment on pull request #29039:
URL: https://github.com/apache/spark/pull/29039#issuecomment-656156052
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #29039:
URL: https://github.com/apache/spark/pull/29039#issuecomment-656156052
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
HyukjinKwon commented on a change in pull request #29057:
URL: https://github.com/apache/spark/pull/29057#discussion_r452252752
##
File path: python/pyspark/sql/tests/test_types.py
##
@@ -725,7 +725,8 @@ def assertCollectSuccess(typecode, value):
if
AmplabJenkins commented on pull request #29057:
URL: https://github.com/apache/spark/pull/29057#issuecomment-656154811
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins removed a comment on pull request #29057:
URL: https://github.com/apache/spark/pull/29057#issuecomment-656154811
This is an automated message from the Apache Git Service.
To respond to the message, please log on
SparkQA removed a comment on pull request #29039:
URL: https://github.com/apache/spark/pull/29039#issuecomment-656115713
**[Test build #125473 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125473/testReport)**
for PR 29039 at commit
SparkQA removed a comment on pull request #28904:
URL: https://github.com/apache/spark/pull/28904#issuecomment-655948736
**[Test build #125445 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125445/testReport)**
for PR 28904 at commit
SparkQA commented on pull request #29039:
URL: https://github.com/apache/spark/pull/29039#issuecomment-656154842
**[Test build #125473 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125473/testReport)**
for PR 29039 at commit
HyukjinKwon commented on a change in pull request #29057:
URL: https://github.com/apache/spark/pull/29057#discussion_r452251691
##
File path: python/pyspark/sql/tests/test_arrow.py
##
@@ -435,12 +438,12 @@ def test_createDateFrame_with_category_type(self):
HyukjinKwon commented on a change in pull request #29057:
URL: https://github.com/apache/spark/pull/29057#discussion_r452250867
##
File path: project/SparkBuild.scala
##
@@ -1015,9 +1015,20 @@ object TestSettings {
sys.props.get("test.exclude.tags").map { tags =>
HyukjinKwon commented on a change in pull request #29057:
URL: https://github.com/apache/spark/pull/29057#discussion_r452251281
##
File path: project/SparkBuild.scala
##
@@ -1015,9 +1015,20 @@ object TestSettings {
sys.props.get("test.exclude.tags").map { tags =>
SparkQA commented on pull request #28904:
URL: https://github.com/apache/spark/pull/28904#issuecomment-656154418
**[Test build #125445 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125445/testReport)**
for PR 28904 at commit
Ngone51 commented on pull request #29002:
URL: https://github.com/apache/spark/pull/29002#issuecomment-656154660
> So If we reorder the initialization, it should be placed before the
registration, not after heartbeater started right?
Ideally, that way should work as well. However,
HyukjinKwon commented on a change in pull request #29057:
URL: https://github.com/apache/spark/pull/29057#discussion_r452249974
##
File path: dev/run-pip-tests
##
@@ -76,8 +76,12 @@ for python in "${PYTHON_EXECS[@]}"; do
VIRTUALENV_PATH="$VIRTUALENV_BASE"/$python
rm
HyukjinKwon commented on a change in pull request #29057:
URL: https://github.com/apache/spark/pull/29057#discussion_r452249751
##
File path: dev/run-pip-tests
##
@@ -76,8 +76,12 @@ for python in "${PYTHON_EXECS[@]}"; do
VIRTUALENV_PATH="$VIRTUALENV_BASE"/$python
rm
SparkQA commented on pull request #29057:
URL: https://github.com/apache/spark/pull/29057#issuecomment-656153300
**[Test build #125481 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125481/testReport)**
for PR 29057 at commit
701 - 800 of 1210 matches
Mail list logo
