maropu commented on a change in pull request #29270:
URL: https://github.com/apache/spark/pull/29270#discussion_r462681112
##
File path: sql/core/src/test/scala/org/apache/spark/sql/PlanStabilitySuite.scala
##
@@ -0,0 +1,306 @@
+/*
+ * Licensed to the Apache Software
SparkQA removed a comment on pull request #29296:
URL: https://github.com/apache/spark/pull/29296#issuecomment-666055382
**[Test build #126800 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126800/testReport)**
for PR 29296 at commit
jiangxb1987 commented on a change in pull request #29276:
URL: https://github.com/apache/spark/pull/29276#discussion_r462572658
##
File path: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala
##
@@ -695,7 +696,7 @@ private[spark] class TaskSetManager(
def
AmplabJenkins commented on pull request #29295:
URL: https://github.com/apache/spark/pull/29295#issuecomment-665995022
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
MaxGekk commented on a change in pull request #20176:
URL: https://github.com/apache/spark/pull/20176#discussion_r462546349
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
##
@@ -259,6 +259,29 @@ case class Cast(child:
yaooqinn commented on pull request #29204:
URL: https://github.com/apache/spark/pull/29204#issuecomment-666152601
gentle ping @cloud-fan
This is an automated message from the Apache Git Service.
To respond to the message,
WeichenXu123 commented on a change in pull request #29284:
URL: https://github.com/apache/spark/pull/29284#discussion_r462672906
##
File path: python/pyspark/sql/pandas/conversion.py
##
@@ -404,8 +404,10 @@ def _create_from_pandas_with_arrow(self, pdf, schema,
timezone):
SparkQA removed a comment on pull request #29278:
URL: https://github.com/apache/spark/pull/29278#issuecomment-665970816
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
HeartSaVioR commented on pull request #29289:
URL: https://github.com/apache/spark/pull/29289#issuecomment-665989611
I'll leave the PR a day to see any further input, and merge tomorrow. Please
take a look, or leave comment if anyone needs some time to review this.
SparkQA commented on pull request #29276:
URL: https://github.com/apache/spark/pull/29276#issuecomment-665902742
**[Test build #126786 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126786/testReport)**
for PR 29276 at commit
HyukjinKwon commented on pull request #29283:
URL: https://github.com/apache/spark/pull/29283#issuecomment-666146832
Merged to master and branch-3.0. Thanks @viirya.
This is an automated message from the Apache Git Service.
AmplabJenkins commented on pull request #29293:
URL: https://github.com/apache/spark/pull/29293#issuecomment-665942782
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
HyukjinKwon commented on pull request #28968:
URL: https://github.com/apache/spark/pull/28968#issuecomment-666017525
Merged to master.
This is an automated message from the Apache Git Service.
To respond to the message,
AmplabJenkins removed a comment on pull request #29146:
URL: https://github.com/apache/spark/pull/29146#issuecomment-665946574
This is an automated message from the Apache Git Service.
To respond to the message, please log on
dongjoon-hyun commented on pull request #29293:
URL: https://github.com/apache/spark/pull/29293#issuecomment-665942644
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
viirya commented on a change in pull request #29277:
URL: https://github.com/apache/spark/pull/29277#discussion_r462685419
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
##
@@ -903,6 +904,10 @@ case class
gemelen commented on pull request #29286:
URL: https://github.com/apache/spark/pull/29286#issuecomment-666101286
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
SparkQA commented on pull request #29293:
URL: https://github.com/apache/spark/pull/29293#issuecomment-665941955
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
AmplabJenkins commented on pull request #29146:
URL: https://github.com/apache/spark/pull/29146#issuecomment-665946574
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins commented on pull request #29296:
URL: https://github.com/apache/spark/pull/29296#issuecomment-666050019
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #29234:
URL: https://github.com/apache/spark/pull/29234#issuecomment-665941972
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
SparkQA removed a comment on pull request #29294:
URL: https://github.com/apache/spark/pull/29294#issuecomment-665989295
**[Test build #126794 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126794/testReport)**
for PR 29294 at commit
HeartSaVioR commented on pull request #29272:
URL: https://github.com/apache/spark/pull/29272#issuecomment-666223018
retest this, please
This is an automated message from the Apache Git Service.
To respond to the message,
AmplabJenkins removed a comment on pull request #29146:
URL: https://github.com/apache/spark/pull/29146#issuecomment-666231820
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
AmplabJenkins commented on pull request #29146:
URL: https://github.com/apache/spark/pull/29146#issuecomment-666231820
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/126802/
beliefer commented on pull request #29291:
URL: https://github.com/apache/spark/pull/29291#issuecomment-666240549
cc @cloud-fan
This is an automated message from the Apache Git Service.
To respond to the message, please log
itsvikramagr edited a comment on pull request #28904:
URL: https://github.com/apache/spark/pull/28904#issuecomment-666248758
@HeartSaVioR - This is a much-needed fix. Thanks for it.
I have an orthogonal question. Why do we need to worry about file sink
metadata files? I can think of
HyukjinKwon opened a new pull request #29306:
URL: https://github.com/apache/spark/pull/29306
### What changes were proposed in this pull request?
CRAN check fails due to the size of PDF manual as below:
{code}
...
WARNING
‘qpdf’ is needed for checks on size
cloud-fan commented on a change in pull request #29291:
URL: https://github.com/apache/spark/pull/29291#discussion_r462958983
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/RewriteDistinctAggregates.scala
##
@@ -184,8 +227,8 @@ object
beliefer commented on pull request #27429:
URL: https://github.com/apache/spark/pull/27429#issuecomment-666227176
retest this please.
This is an automated message from the Apache Git Service.
To respond to the message,
AmplabJenkins removed a comment on pull request #29146:
URL: https://github.com/apache/spark/pull/29146#issuecomment-666231024
Merged build finished. Test FAILed.
This is an automated message from the Apache Git Service.
To
AmplabJenkins commented on pull request #29146:
URL: https://github.com/apache/spark/pull/29146#issuecomment-666231024
Merged build finished. Test FAILed.
This is an automated message from the Apache Git Service.
To respond
liangz1 commented on pull request #29284:
URL: https://github.com/apache/spark/pull/29284#issuecomment-666238258
This is not a bug. Spark will always create `defaultParallelism` partitions;
there could be empty partitions. Closing this PR.
AmplabJenkins commented on pull request #29296:
URL: https://github.com/apache/spark/pull/29296#issuecomment-666254919
Merged build finished. Test PASSed.
This is an automated message from the Apache Git Service.
To respond
AmplabJenkins removed a comment on pull request #29296:
URL: https://github.com/apache/spark/pull/29296#issuecomment-666254919
Merged build finished. Test PASSed.
This is an automated message from the Apache Git Service.
To
AmplabJenkins commented on pull request #29296:
URL: https://github.com/apache/spark/pull/29296#issuecomment-666255678
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/126800/
maropu commented on a change in pull request #29146:
URL: https://github.com/apache/spark/pull/29146#discussion_r462884250
##
File path:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4
##
@@ -244,11 +258,31 @@ statement
| SET TIME ZONE
maropu commented on a change in pull request #29146:
URL: https://github.com/apache/spark/pull/29146#discussion_r462883994
##
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/SparkSqlParserSuite.scala
##
@@ -61,6 +63,64 @@ class SparkSqlParserSuite extends
maropu commented on a change in pull request #29146:
URL: https://github.com/apache/spark/pull/29146#discussion_r462884139
##
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/SparkSqlParserSuite.scala
##
@@ -61,6 +63,64 @@ class SparkSqlParserSuite extends
maropu commented on a change in pull request #29146:
URL: https://github.com/apache/spark/pull/29146#discussion_r462888722
##
File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
##
@@ -962,8 +962,8 @@ class SQLQuerySuite extends QueryTest with
HyukjinKwon opened a new pull request #29302:
URL: https://github.com/apache/spark/pull/29302
### What changes were proposed in this pull request?
This PR proposes to manually install R instead of using `setup-r` which
seems broken. Currently, GitHub Actions uses its default R 3.4.4
yaooqinn opened a new pull request #29303:
URL: https://github.com/apache/spark/pull/29303
### What changes were proposed in this pull request?
This PR fulfills some missing fields for SparkGetColumnsOperation
### Why are the changes needed?
make jdbc tools
cloud-fan commented on pull request #29199:
URL: https://github.com/apache/spark/pull/29199#issuecomment-666293972
> add default no serde IO schemas
ScriptTransformationIOSchema.defaultIOSchema
I think we will have a default native serde. So for now we just need a fake
one which
cloud-fan commented on pull request #29085:
URL: https://github.com/apache/spark/pull/29085#issuecomment-666293192
retest this please
This is an automated message from the Apache Git Service.
To respond to the message,
cloud-fan commented on a change in pull request #29291:
URL: https://github.com/apache/spark/pull/29291#discussion_r462957297
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/RewriteDistinctAggregates.scala
##
@@ -207,13 +256,35 @@ object
AmplabJenkins commented on pull request #29291:
URL: https://github.com/apache/spark/pull/29291#issuecomment-666222739
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
leanken commented on pull request #29301:
URL: https://github.com/apache/spark/pull/29301#issuecomment-666202715
@cloud-fan @maropu @agrawaldevesh
Could you guys have a look at this follow up, See if is it worth to do such
trade-off to support multi-column NAAJ.
liangz1 closed pull request #29284:
URL: https://github.com/apache/spark/pull/29284
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
AmplabJenkins removed a comment on pull request #29296:
URL: https://github.com/apache/spark/pull/29296#issuecomment-666255678
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
cloud-fan commented on pull request #29301:
URL: https://github.com/apache/spark/pull/29301#issuecomment-666264155
can you create a new jira ticket? It's a major feature that shouldn't be
treated as a followup.
This is an
HyukjinKwon commented on pull request #29300:
URL: https://github.com/apache/spark/pull/29300#issuecomment-666284461
I am going to merge unblock other PRs. Jenkins seems down as well.
This is an automated message from the
uncleGen commented on pull request #28781:
URL: https://github.com/apache/spark/pull/28781#issuecomment-666284455
retest this please.
This is an automated message from the Apache Git Service.
To respond to the message,
HyukjinKwon commented on pull request #29300:
URL: https://github.com/apache/spark/pull/29300#issuecomment-666284569
Merged to master.
This is an automated message from the Apache Git Service.
To respond to the message,
HyukjinKwon closed pull request #29300:
URL: https://github.com/apache/spark/pull/29300
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
beliefer commented on a change in pull request #29291:
URL: https://github.com/apache/spark/pull/29291#discussion_r462924626
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/RewriteDistinctAggregates.scala
##
@@ -144,28 +192,23 @@ import
beliefer commented on a change in pull request #29291:
URL: https://github.com/apache/spark/pull/29291#discussion_r462924626
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/RewriteDistinctAggregates.scala
##
@@ -144,28 +192,23 @@ import
HyukjinKwon commented on pull request #29305:
URL: https://github.com/apache/spark/pull/29305#issuecomment-666325261
Seems like CRAN check started to fail due to SPARK-32497. I am going to
merge to unblock the PRs - SparkR tests still fail. Let me know if there are
any comments
HyukjinKwon commented on pull request #29305:
URL: https://github.com/apache/spark/pull/29305#issuecomment-666325380
Merged to master.
This is an automated message from the Apache Git Service.
To respond to the message,
HyukjinKwon closed pull request #29305:
URL: https://github.com/apache/spark/pull/29305
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
cloud-fan commented on a change in pull request #29291:
URL: https://github.com/apache/spark/pull/29291#discussion_r462958305
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/RewriteDistinctAggregates.scala
##
@@ -144,28 +192,23 @@ import
cloud-fan commented on a change in pull request #29291:
URL: https://github.com/apache/spark/pull/29291#discussion_r462957711
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/RewriteDistinctAggregates.scala
##
@@ -144,28 +192,23 @@ import
beliefer commented on pull request #27507:
URL: https://github.com/apache/spark/pull/27507#issuecomment-666227396
retest this please.
This is an automated message from the Apache Git Service.
To respond to the message,
AmplabJenkins removed a comment on pull request #29291:
URL: https://github.com/apache/spark/pull/29291#issuecomment-666222739
Merged build finished. Test PASSed.
This is an automated message from the Apache Git Service.
To
beliefer commented on pull request #27429:
URL: https://github.com/apache/spark/pull/27429#issuecomment-666227176
retest this please.
This is an automated message from the Apache Git Service.
To respond to the message,
beliefer commented on pull request #27507:
URL: https://github.com/apache/spark/pull/27507#issuecomment-666227396
retest this please.
This is an automated message from the Apache Git Service.
To respond to the message,
AmplabJenkins removed a comment on pull request #29283:
URL: https://github.com/apache/spark/pull/29283#issuecomment-666233540
Merged build finished. Test PASSed.
This is an automated message from the Apache Git Service.
To
AmplabJenkins commented on pull request #29283:
URL: https://github.com/apache/spark/pull/29283#issuecomment-666233540
Merged build finished. Test PASSed.
This is an automated message from the Apache Git Service.
To respond
leanken commented on pull request #29301:
URL: https://github.com/apache/spark/pull/29301#issuecomment-666266144
PS. Need recreate JIRA and PR, close this one in advanced.
This is an automated message from the Apache Git
leanken closed pull request #29301:
URL: https://github.com/apache/spark/pull/29301
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
HyukjinKwon commented on pull request #29302:
URL: https://github.com/apache/spark/pull/29302#issuecomment-666301002
Thanks @cloud-fan. I am going to merge to unlock other PRs.
Merged to master.
This is an automated
HyukjinKwon closed pull request #29302:
URL: https://github.com/apache/spark/pull/29302
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
beliefer commented on a change in pull request #29291:
URL: https://github.com/apache/spark/pull/29291#discussion_r462925756
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/RewriteDistinctAggregates.scala
##
@@ -207,13 +256,35 @@ object
maropu commented on pull request #29146:
URL: https://github.com/apache/spark/pull/29146#issuecomment-666317097
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
AmplabJenkins commented on pull request #29283:
URL: https://github.com/apache/spark/pull/29283#issuecomment-666234409
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/126798/
AmplabJenkins removed a comment on pull request #29283:
URL: https://github.com/apache/spark/pull/29283#issuecomment-666234409
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
leanken commented on pull request #29301:
URL: https://github.com/apache/spark/pull/29301#issuecomment-666265832
> can you create a new jira ticket? It's a major feature that shouldn't be
treated as a followup.
OK, I will re-create JIRA Issue and PR.
leanken edited a comment on pull request #29301:
URL: https://github.com/apache/spark/pull/29301#issuecomment-666265832
> can you create a new jira ticket? It's a major feature that shouldn't be
treated as a followup.
OK, I will re-create JIRA Issue and PR. Close this PR first
maropu commented on a change in pull request #29146:
URL: https://github.com/apache/spark/pull/29146#discussion_r462884875
##
File path:
sql/core/src/test/scala/org/apache/spark/sql/internal/SQLConfEntrySuite.scala
##
@@ -107,7 +107,7 @@ class SQLConfEntrySuite extends
cloud-fan commented on a change in pull request #29291:
URL: https://github.com/apache/spark/pull/29291#discussion_r462917670
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/RewriteDistinctAggregates.scala
##
@@ -207,13 +256,35 @@ object
cloud-fan commented on a change in pull request #29067:
URL: https://github.com/apache/spark/pull/29067#discussion_r462960267
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/columnar/CachedBatchSerializer.scala
##
@@ -0,0 +1,344 @@
+/*
+ * Licensed to the Apache
c21 commented on a change in pull request #29277:
URL: https://github.com/apache/spark/pull/29277#discussion_r462830406
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/ShuffledHashJoinExec.scala
##
@@ -70,4 +74,54 @@ case class ShuffledHashJoinExec(
itsvikramagr commented on pull request #28904:
URL: https://github.com/apache/spark/pull/28904#issuecomment-666248758
@HeartSaVioR - This is a much-needed fix. Thanks for it.
I have an orthogonal question. Why do we need to worry about compacting the
file sink metadata? I can think
HyukjinKwon commented on pull request #29300:
URL: https://github.com/apache/spark/pull/29300#issuecomment-666268399
retest this please
This is an automated message from the Apache Git Service.
To respond to the message,
leanken opened a new pull request #29304:
URL: https://github.com/apache/spark/pull/29304
### What changes were proposed in this pull request?
In this PR, proposed a trade-off that can also support multi column to
perform hash lookup in buildSide, but required buildSide with extra
cloud-fan commented on pull request #29277:
URL: https://github.com/apache/spark/pull/29277#issuecomment-666290685
retest this please
This is an automated message from the Apache Git Service.
To respond to the message,
cloud-fan commented on a change in pull request #29291:
URL: https://github.com/apache/spark/pull/29291#discussion_r462915233
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/RewriteDistinctAggregates.scala
##
@@ -144,28 +192,23 @@ import
HyukjinKwon opened a new pull request #29305:
URL: https://github.com/apache/spark/pull/29305
### What changes were proposed in this pull request?
https://github.com/apache/spark/pull/26556 excluded
`.github/workflows/master.yml`. So tests are skipped if the GitHub Actions
leanken commented on pull request #29304:
URL: https://github.com/apache/spark/pull/29304#issuecomment-666310924
@cloud-fan @maropu @agrawaldevesh
This is an automated message from the Apache Git Service.
To respond to the
leanken edited a comment on pull request #29304:
URL: https://github.com/apache/spark/pull/29304#issuecomment-666310924
@cloud-fan @maropu @agrawaldevesh
New JIRA and PR re-created. Many thanks.
This is an automated
HeartSaVioR edited a comment on pull request #28904:
URL: https://github.com/apache/spark/pull/28904#issuecomment-666770668
> for exactly-once semantics, we can add make changes in
ManifestFileCommitter to delete files in the abort function. Or we can come up
with some other alternatives.
HeartSaVioR edited a comment on pull request #28904:
URL: https://github.com/apache/spark/pull/28904#issuecomment-666770668
> for exactly-once semantics, we can add make changes in
ManifestFileCommitter to delete files in the abort function. Or we can come up
with some other alternatives.
SparkQA commented on pull request #29279:
URL: https://github.com/apache/spark/pull/29279#issuecomment-666807231
**[Test build #126811 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126811/testReport)**
for PR 29279 at commit
AmplabJenkins commented on pull request #29146:
URL: https://github.com/apache/spark/pull/29146#issuecomment-666845339
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins removed a comment on pull request #29270:
URL: https://github.com/apache/spark/pull/29270#issuecomment-666849196
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
SparkQA removed a comment on pull request #29278:
URL: https://github.com/apache/spark/pull/29278#issuecomment-56234
**[Test build #126812 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126812/testReport)**
for PR 29278 at commit
AmplabJenkins removed a comment on pull request #29211:
URL: https://github.com/apache/spark/pull/29211#issuecomment-666849810
Merged build finished. Test FAILed.
This is an automated message from the Apache Git Service.
To
AmplabJenkins commented on pull request #29211:
URL: https://github.com/apache/spark/pull/29211#issuecomment-666849810
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #29278:
URL: https://github.com/apache/spark/pull/29278#issuecomment-666849737
**[Test build #126812 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126812/testReport)**
for PR 29278 at commit
AmplabJenkins removed a comment on pull request #29270:
URL: https://github.com/apache/spark/pull/29270#issuecomment-666849192
Merged build finished. Test FAILed.
This is an automated message from the Apache Git Service.
To
AmplabJenkins removed a comment on pull request #29313:
URL: https://github.com/apache/spark/pull/29313#issuecomment-666736981
This is an automated message from the Apache Git Service.
To respond to the message, please log on
101 - 200 of 776 matches
Mail list logo