[GitHub] [spark] AmplabJenkins removed a comment on pull request #29886: [SPARK-27951][SQL][FOLLOWUP] Improve the window function nth_value

2020-09-28 Thread GitBox
AmplabJenkins removed a comment on pull request #29886: URL: https://github.com/apache/spark/pull/29886#issuecomment-699802095 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29886: [SPARK-27951][SQL][FOLLOWUP] Improve the window function nth_value

2020-09-28 Thread GitBox
AmplabJenkins removed a comment on pull request #29886: URL: https://github.com/apache/spark/pull/29886#issuecomment-699802110 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] gaborgsomogyi commented on pull request #29024: [SPARK-32001][SQL]Create JDBC authentication provider developer API

2020-09-28 Thread GitBox
gaborgsomogyi commented on pull request #29024: URL: https://github.com/apache/spark/pull/29024#issuecomment-699818240 @HyukjinKwon thanks for your opinion. Based on the suggestion I'm going to add `@Unstable` or `@Evolving` until someone who can confirm the API will review it.

[GitHub] [spark] HyukjinKwon commented on pull request #29414: [SPARK-32106][SQL] Implement script transform in sql/core

2020-09-28 Thread GitBox
HyukjinKwon commented on pull request #29414: URL: https://github.com/apache/spark/pull/29414#issuecomment-699823318 I haven't checked it very closely but looks good to go. WDYT @wangyum? This is an automated message from

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #28032: [SPARK-31264][SQL] Repartition by dynamic partition columns before insert partition table

2020-09-28 Thread GitBox
AngersZh commented on a change in pull request #28032: URL: https://github.com/apache/spark/pull/28032#discussion_r495736123 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ## @@ -2038,6 +2038,15 @@ object SQLConf {

[GitHub] [spark] AmplabJenkins commented on pull request #29886: [SPARK-27951][SQL][FOLLOWUP] Improve the window function nth_value

2020-09-28 Thread GitBox
AmplabJenkins commented on pull request #29886: URL: https://github.com/apache/spark/pull/29886#issuecomment-699833101 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #29886: [SPARK-27951][SQL][FOLLOWUP] Improve the window function nth_value

2020-09-28 Thread GitBox
SparkQA commented on pull request #29886: URL: https://github.com/apache/spark/pull/29886#issuecomment-699833065 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33781/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29886: [SPARK-27951][SQL][FOLLOWUP] Improve the window function nth_value

2020-09-28 Thread GitBox
AmplabJenkins removed a comment on pull request #29886: URL: https://github.com/apache/spark/pull/29886#issuecomment-699833101 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] laflechejonathan opened a new pull request #29888: [SPARK-33012] Upgrade fabric8 to 4.10.3

2020-09-28 Thread GitBox
laflechejonathan opened a new pull request #29888: URL: https://github.com/apache/spark/pull/29888 ### What changes were proposed in this pull request? This PR aims to upgrade `kubernetes-client` library to track fabric8's declared compatibility for k8s 1.18.0:

[GitHub] [spark] HyukjinKwon commented on a change in pull request #29677: [SPARK-32820][SQL] Remove redundant shuffle exchanges inserted by EnsureRequirements

2020-09-28 Thread GitBox
HyukjinKwon commented on a change in pull request #29677: URL: https://github.com/apache/spark/pull/29677#discussion_r495754618 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/EnsureRequirements.scala ## @@ -52,7 +52,10 @@ case class

[GitHub] [spark] SparkQA commented on pull request #29886: [SPARK-27951][SQL][FOLLOWUP] Improve the window function nth_value

2020-09-28 Thread GitBox
SparkQA commented on pull request #29886: URL: https://github.com/apache/spark/pull/29886#issuecomment-699860245 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33785/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29677: [SPARK-32820][SQL] Remove redundant shuffle exchanges inserted by EnsureRequirements

2020-09-28 Thread GitBox
AmplabJenkins removed a comment on pull request #29677: URL: https://github.com/apache/spark/pull/29677#issuecomment-699865552 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29677: [SPARK-32820][SQL] Remove redundant shuffle exchanges inserted by EnsureRequirements

2020-09-28 Thread GitBox
AmplabJenkins commented on pull request #29677: URL: https://github.com/apache/spark/pull/29677#issuecomment-699865552 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #29677: [SPARK-32820][SQL] Remove redundant shuffle exchanges inserted by EnsureRequirements

2020-09-28 Thread GitBox
SparkQA commented on pull request #29677: URL: https://github.com/apache/spark/pull/29677#issuecomment-699865497 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33786/

[GitHub] [spark] LantaoJin commented on pull request #29869: [SPARK-32994][CORE] Update external heavy accumulators before they entering into listener event loop

2020-09-28 Thread GitBox
LantaoJin commented on pull request #29869: URL: https://github.com/apache/spark/pull/29869#issuecomment-699865449 ping @cloud-fan @HyukjinKwon @dongjoon-hyun This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on pull request #29890: [SPARK-33014][SQL] Support multiple bucket columns in DataSourceV2 table

2020-09-28 Thread GitBox
AmplabJenkins commented on pull request #29890: URL: https://github.com/apache/spark/pull/29890#issuecomment-699877189 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #29890: [SPARK-33014][SQL] Support multiple bucket columns in DataSourceV2 table

2020-09-28 Thread GitBox
AmplabJenkins commented on pull request #29890: URL: https://github.com/apache/spark/pull/29890#issuecomment-699881525 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #29890: [SPARK-33014][SQL] Support multiple bucket columns in DataSourceV2 table

2020-09-28 Thread GitBox
SparkQA commented on pull request #29890: URL: https://github.com/apache/spark/pull/29890#issuecomment-699881490 **[Test build #129176 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129176/testReport)** for PR 29890 at commit

[GitHub] [spark] SparkQA commented on pull request #29891: [WIP][SPARK-30796][SQL] Add parameter position for REGEXP_REPLACE

2020-09-28 Thread GitBox
SparkQA commented on pull request #29891: URL: https://github.com/apache/spark/pull/29891#issuecomment-699918221 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33792/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29891: [WIP][SPARK-30796][SQL] Add parameter position for REGEXP_REPLACE

2020-09-28 Thread GitBox
AmplabJenkins removed a comment on pull request #29891: URL: https://github.com/apache/spark/pull/29891#issuecomment-699918234 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #29890: [SPARK-33014][SQL] Support multiple bucket columns in DataSourceV2 table

2020-09-28 Thread GitBox
SparkQA commented on pull request #29890: URL: https://github.com/apache/spark/pull/29890#issuecomment-699918266 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33793/

[GitHub] [spark] AmplabJenkins commented on pull request #29891: [WIP][SPARK-30796][SQL] Add parameter position for REGEXP_REPLACE

2020-09-28 Thread GitBox
AmplabJenkins commented on pull request #29891: URL: https://github.com/apache/spark/pull/29891#issuecomment-699918234 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #29817: [SPARK-32850][CORE][K8S] Simplify the RPC message flow of decommission

2020-09-28 Thread GitBox
SparkQA removed a comment on pull request #29817: URL: https://github.com/apache/spark/pull/29817#issuecomment-699857383 **[Test build #129172 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129172/testReport)** for PR 29817 at commit

[GitHub] [spark] SparkQA commented on pull request #29886: [SPARK-27951][SQL][FOLLOWUP] Improve the window function nth_value

2020-09-28 Thread GitBox
SparkQA commented on pull request #29886: URL: https://github.com/apache/spark/pull/29886#issuecomment-699955392 **[Test build #129170 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129170/testReport)** for PR 29886 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #29886: [SPARK-27951][SQL][FOLLOWUP] Improve the window function nth_value

2020-09-28 Thread GitBox
SparkQA removed a comment on pull request #29886: URL: https://github.com/apache/spark/pull/29886#issuecomment-699826476 **[Test build #129170 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129170/testReport)** for PR 29886 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #29339: [SPARK-32512][SQL] add alter table add/drop partition command for datasourcev2

2020-09-28 Thread GitBox
SparkQA removed a comment on pull request #29339: URL: https://github.com/apache/spark/pull/29339#issuecomment-699821829 **[Test build #129169 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129169/testReport)** for PR 29339 at commit

[GitHub] [spark] SparkQA commented on pull request #29024: [SPARK-32001][SQL]Create JDBC authentication provider developer API

2020-09-28 Thread GitBox
SparkQA commented on pull request #29024: URL: https://github.com/apache/spark/pull/29024#issuecomment-699962933 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33794/

[GitHub] [spark] maropu commented on pull request #28991: [SPARK-26533][SQL][test-hive1.2][test-hadoop2.7] Support query auto timeout cancel on thriftserver

2020-09-28 Thread GitBox
maropu commented on pull request #28991: URL: https://github.com/apache/spark/pull/28991#issuecomment-699969600 kindly ping @leoluan2009 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] hvanhovell commented on pull request #29725: [SPARK-32096][SQL] Improve sorting performance of Spark SQL window function by removing window partition key from sort order

2020-09-28 Thread GitBox
hvanhovell commented on pull request #29725: URL: https://github.com/apache/spark/pull/29725#issuecomment-699973391 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29725: [SPARK-32096][SQL] Improve sorting performance of Spark SQL window function by removing window partition key from sort order

2020-09-28 Thread GitBox
AmplabJenkins removed a comment on pull request #29725: URL: https://github.com/apache/spark/pull/29725#issuecomment-690920657 Can one of the admins verify this patch? This is an automated message from the Apache Git

[GitHub] [spark] SparkQA commented on pull request #29074: [SPARK-32282][SQL] Improve EnsureRquirement.reorderJoinKeys to handle more scenarios such as PartitioningCollection

2020-09-28 Thread GitBox
SparkQA commented on pull request #29074: URL: https://github.com/apache/spark/pull/29074#issuecomment-699972650 **[Test build #129183 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129183/testReport)** for PR 29074 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #29891: [WIP][SPARK-30796][SQL] Add parameter position for REGEXP_REPLACE

2020-09-28 Thread GitBox
AmplabJenkins commented on pull request #29891: URL: https://github.com/apache/spark/pull/29891#issuecomment-61611 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29024: [SPARK-32001][SQL]Create JDBC authentication provider developer API

2020-09-28 Thread GitBox
AmplabJenkins removed a comment on pull request #29024: URL: https://github.com/apache/spark/pull/29024#issuecomment-74687 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29024: [SPARK-32001][SQL]Create JDBC authentication provider developer API

2020-09-28 Thread GitBox
AmplabJenkins removed a comment on pull request #29024: URL: https://github.com/apache/spark/pull/29024#issuecomment-74678 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29889: [SPARK-33015][SQL] Compute the current date only once

2020-09-28 Thread GitBox
AmplabJenkins removed a comment on pull request #29889: URL: https://github.com/apache/spark/pull/29889#issuecomment-74193 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29725: [SPARK-32096][SQL] Improve sorting performance of Spark SQL window function by removing window partition key from sort order

2020-09-28 Thread GitBox
AmplabJenkins commented on pull request #29725: URL: https://github.com/apache/spark/pull/29725#issuecomment-74940 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #29725: [SPARK-32096][SQL] Improve sorting performance of Spark SQL window function by removing window partition key from sort order

2020-09-28 Thread GitBox
SparkQA commented on pull request #29725: URL: https://github.com/apache/spark/pull/29725#issuecomment-74912 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33798/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29725: [SPARK-32096][SQL] Improve sorting performance of Spark SQL window function by removing window partition key from sort order

2020-09-28 Thread GitBox
AmplabJenkins removed a comment on pull request #29725: URL: https://github.com/apache/spark/pull/29725#issuecomment-74940 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on pull request #29024: [SPARK-32001][SQL]Create JDBC authentication provider developer API

2020-09-28 Thread GitBox
AmplabJenkins commented on pull request #29024: URL: https://github.com/apache/spark/pull/29024#issuecomment-74678 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29817: [SPARK-32850][CORE][K8S] Simplify the RPC message flow of decommission

2020-09-28 Thread GitBox
AmplabJenkins removed a comment on pull request #29817: URL: https://github.com/apache/spark/pull/29817#issuecomment-699914533 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29817: [SPARK-32850][CORE][K8S] Simplify the RPC message flow of decommission

2020-09-28 Thread GitBox
AmplabJenkins removed a comment on pull request #29817: URL: https://github.com/apache/spark/pull/29817#issuecomment-699914545 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on pull request #29890: [SPARK-33014][SQL] Support multiple bucket columns in DataSourceV2 table

2020-09-28 Thread GitBox
AmplabJenkins commented on pull request #29890: URL: https://github.com/apache/spark/pull/29890#issuecomment-699926147 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #29890: [SPARK-33014][SQL] Support multiple bucket columns in DataSourceV2 table

2020-09-28 Thread GitBox
SparkQA commented on pull request #29890: URL: https://github.com/apache/spark/pull/29890#issuecomment-699925690 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33793/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29817: [SPARK-32850][CORE][K8S] Simplify the RPC message flow of decommission

2020-09-28 Thread GitBox
AmplabJenkins removed a comment on pull request #29817: URL: https://github.com/apache/spark/pull/29817#issuecomment-699936668 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29817: [SPARK-32850][CORE][K8S] Simplify the RPC message flow of decommission

2020-09-28 Thread GitBox
AmplabJenkins commented on pull request #29817: URL: https://github.com/apache/spark/pull/29817#issuecomment-699936668 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] maropu commented on a change in pull request #29842: [SPARK-32970][TEST] Reduce the runtime of an UT for SPARK-32019

2020-09-28 Thread GitBox
maropu commented on a change in pull request #29842: URL: https://github.com/apache/spark/pull/29842#discussion_r495878125 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/FileSourceStrategySuite.scala ## @@ -529,37 +529,42 @@ class

[GitHub] [spark] GuoPhilipse commented on pull request #29883: [SPARK-31753][SQL][DOCS][FOLLOW-UP] Add missing keywords in the SQL docs

2020-09-28 Thread GitBox
GuoPhilipse commented on pull request #29883: URL: https://github.com/apache/spark/pull/29883#issuecomment-699956479 > Could you add the screenshots of the updated docs in the PR description? LGTM otherwise. @maropu Have updated the html screenshots :)

[GitHub] [spark] maropu commented on a change in pull request #29804: [SPARK-32859][SQL] Introduce physical rule to decide bucketing dynamically

2020-09-28 Thread GitBox
maropu commented on a change in pull request #29804: URL: https://github.com/apache/spark/pull/29804#discussion_r495886405 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/bucketing/DisableUnnecessaryBucketedScan.scala ## @@ -0,0 +1,147 @@ +/* + * Licensed

[GitHub] [spark] maropu commented on pull request #29074: [SPARK-32282][SQL] Improve EnsureRquirement.reorderJoinKeys to handle more scenarios such as PartitioningCollection

2020-09-28 Thread GitBox
maropu commented on pull request #29074: URL: https://github.com/apache/spark/pull/29074#issuecomment-699968879 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] leanken commented on a change in pull request #29882: [SPARK-33008][SQL] Division by zero on divide-like operations returns incorrect result

2020-09-28 Thread GitBox
leanken commented on a change in pull request #29882: URL: https://github.com/apache/spark/pull/29882#discussion_r495886838 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Average.scala ## @@ -77,11 +77,15 @@ case class

[GitHub] [spark] shockdm commented on a change in pull request #29496: [SPARK-24266][K8S][2.4] Restart the watcher when we receive a version changed from k8s

2020-09-28 Thread GitBox
shockdm commented on a change in pull request #29496: URL: https://github.com/apache/spark/pull/29496#discussion_r495896477 ## File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/LoggingPodStatusWatcher.scala ## @@ -177,4 +188,27 @@

[GitHub] [spark] maropu commented on a change in pull request #29871: [SPARK-32995][SQL] CostBasedJoinReorder optimizer rule should be idempotent

2020-09-28 Thread GitBox
maropu commented on a change in pull request #29871: URL: https://github.com/apache/spark/pull/29871#discussion_r495896705 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/CostBasedJoinReorder.scala ## @@ -206,13 +206,15 @@ object

[GitHub] [spark] SparkQA removed a comment on pull request #29804: [SPARK-32859][SQL] Introduce physical rule to decide bucketing dynamically

2020-09-28 Thread GitBox
SparkQA removed a comment on pull request #29804: URL: https://github.com/apache/spark/pull/29804#issuecomment-699857418 **[Test build #129173 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129173/testReport)** for PR 29804 at commit

[GitHub] [spark] SparkQA commented on pull request #29817: [SPARK-32850][CORE][K8S] Simplify the RPC message flow of decommission

2020-09-28 Thread GitBox
SparkQA commented on pull request #29817: URL: https://github.com/apache/spark/pull/29817#issuecomment-699988761 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33795/

[GitHub] [spark] SparkQA commented on pull request #29804: [SPARK-32859][SQL] Introduce physical rule to decide bucketing dynamically

2020-09-28 Thread GitBox
SparkQA commented on pull request #29804: URL: https://github.com/apache/spark/pull/29804#issuecomment-699988372 **[Test build #129173 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129173/testReport)** for PR 29804 at commit

[GitHub] [spark] yaooqinn opened a new pull request #29893: [WIP][SPARK-32976][SQL]Support column list in INSERT statement

2020-09-28 Thread GitBox
yaooqinn opened a new pull request #29893: URL: https://github.com/apache/spark/pull/29893 ### What changes were proposed in this pull request? INSERT currently does not support named column lists. INSERT INTO (col1, col2,…) VALUES( 'val1', 'val2', … ) Note, we

[GitHub] [spark] SparkQA commented on pull request #29892: [MINOR][DOCS] Document when `current_date` and `current_timestamp` are evaluated

2020-09-28 Thread GitBox
SparkQA commented on pull request #29892: URL: https://github.com/apache/spark/pull/29892#issuecomment-68434 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33797/

[GitHub] [spark] AmplabJenkins commented on pull request #29892: [MINOR][DOCS] Document when `current_date` and `current_timestamp` are evaluated

2020-09-28 Thread GitBox
AmplabJenkins commented on pull request #29892: URL: https://github.com/apache/spark/pull/29892#issuecomment-68949 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29891: [WIP][SPARK-30796][SQL] Add parameter position for REGEXP_REPLACE

2020-09-28 Thread GitBox
AmplabJenkins removed a comment on pull request #29891: URL: https://github.com/apache/spark/pull/29891#issuecomment-61611 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] SparkQA removed a comment on pull request #29891: [WIP][SPARK-30796][SQL] Add parameter position for REGEXP_REPLACE

2020-09-28 Thread GitBox
SparkQA removed a comment on pull request #29891: URL: https://github.com/apache/spark/pull/29891#issuecomment-699883973 **[Test build #129177 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129177/testReport)** for PR 29891 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29892: [MINOR][DOCS] Document when `current_date` and `current_timestamp` are evaluated

2020-09-28 Thread GitBox
AmplabJenkins removed a comment on pull request #29892: URL: https://github.com/apache/spark/pull/29892#issuecomment-68949 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29891: [WIP][SPARK-30796][SQL] Add parameter position for REGEXP_REPLACE

2020-09-28 Thread GitBox
AmplabJenkins removed a comment on pull request #29891: URL: https://github.com/apache/spark/pull/29891#issuecomment-61624 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA removed a comment on pull request #29790: [SPARK-32914][SQL] Avoid constructing dataType multiple times

2020-09-28 Thread GitBox
SparkQA removed a comment on pull request #29790: URL: https://github.com/apache/spark/pull/29790#issuecomment-699863097 **[Test build #129174 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129174/testReport)** for PR 29790 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #29024: [SPARK-32001][SQL]Create JDBC authentication provider developer API

2020-09-28 Thread GitBox
SparkQA removed a comment on pull request #29024: URL: https://github.com/apache/spark/pull/29024#issuecomment-699945018 **[Test build #129179 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129179/testReport)** for PR 29024 at commit

[GitHub] [spark] SparkQA commented on pull request #29790: [SPARK-32914][SQL] Avoid constructing dataType multiple times

2020-09-28 Thread GitBox
SparkQA commented on pull request #29790: URL: https://github.com/apache/spark/pull/29790#issuecomment-72852 **[Test build #129174 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129174/testReport)** for PR 29790 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #29889: [SPARK-33015][SQL] Compute the current date only once

2020-09-28 Thread GitBox
SparkQA removed a comment on pull request #29889: URL: https://github.com/apache/spark/pull/29889#issuecomment-699869805 **[Test build #129175 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129175/testReport)** for PR 29889 at commit

[GitHub] [spark] SparkQA commented on pull request #29893: [WIP][SPARK-32976][SQL]Support column list in INSERT statement

2020-09-28 Thread GitBox
SparkQA commented on pull request #29893: URL: https://github.com/apache/spark/pull/29893#issuecomment-72465 **[Test build #129185 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129185/testReport)** for PR 29893 at commit

[GitHub] [spark] SparkQA commented on pull request #29024: [SPARK-32001][SQL]Create JDBC authentication provider developer API

2020-09-28 Thread GitBox
SparkQA commented on pull request #29024: URL: https://github.com/apache/spark/pull/29024#issuecomment-73188 **[Test build #129179 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129179/testReport)** for PR 29024 at commit

[GitHub] [spark] akshatb1 commented on a change in pull request #29870: [MINOR][DOCS] Fixing log message for better clarity.

2020-09-28 Thread GitBox
akshatb1 commented on a change in pull request #29870: URL: https://github.com/apache/spark/pull/29870#discussion_r495842717 ## File path: core/src/main/scala/org/apache/spark/SparkConf.scala ## @@ -568,7 +568,7 @@ class SparkConf(loadDefaults: Boolean) extends Cloneable with

[GitHub] [spark] akshatb1 commented on pull request #29870: [MINOR][DOCS] Fixing log message for better clarity.

2020-09-28 Thread GitBox
akshatb1 commented on pull request #29870: URL: https://github.com/apache/spark/pull/29870#issuecomment-699924208 > Is it possible to make this value property driven?) These commits are already merged to master (with property driven), not sure why they are showing up in this PR,

[GitHub] [spark] maropu commented on a change in pull request #29869: [SPARK-32994][CORE] Update external heavy accumulators before they entering into listener event loop

2020-09-28 Thread GitBox
maropu commented on a change in pull request #29869: URL: https://github.com/apache/spark/pull/29869#discussion_r495871556 ## File path: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala ## @@ -274,8 +274,36 @@ private[spark] class DAGScheduler(

[GitHub] [spark] maropu commented on a change in pull request #29869: [SPARK-32994][CORE] Update external heavy accumulators before they entering into listener event loop

2020-09-28 Thread GitBox
maropu commented on a change in pull request #29869: URL: https://github.com/apache/spark/pull/29869#discussion_r495874746 ## File path: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala ## @@ -274,8 +274,36 @@ private[spark] class DAGScheduler(

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29677: [SPARK-32820][SQL] Remove redundant shuffle exchanges inserted by EnsureRequirements

2020-09-28 Thread GitBox
AmplabJenkins removed a comment on pull request #29677: URL: https://github.com/apache/spark/pull/29677#issuecomment-699954237 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29339: [SPARK-32512][SQL] add alter table add/drop partition command for datasourcev2

2020-09-28 Thread GitBox
AmplabJenkins commented on pull request #29339: URL: https://github.com/apache/spark/pull/29339#issuecomment-699956554 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond

[GitHub] [spark] AmplabJenkins commented on pull request #29886: [SPARK-27951][SQL][FOLLOWUP] Improve the window function nth_value

2020-09-28 Thread GitBox
AmplabJenkins commented on pull request #29886: URL: https://github.com/apache/spark/pull/29886#issuecomment-699957160 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #29339: [SPARK-32512][SQL] add alter table add/drop partition command for datasourcev2

2020-09-28 Thread GitBox
AmplabJenkins commented on pull request #29339: URL: https://github.com/apache/spark/pull/29339#issuecomment-699957002 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/129169/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29339: [SPARK-32512][SQL] add alter table add/drop partition command for datasourcev2

2020-09-28 Thread GitBox
AmplabJenkins removed a comment on pull request #29339: URL: https://github.com/apache/spark/pull/29339#issuecomment-699956554 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] SparkQA commented on pull request #29892: [MINOR][DOCS] Document when `current_date` and `current_timestamp` are evaluated

2020-09-28 Thread GitBox
SparkQA commented on pull request #29892: URL: https://github.com/apache/spark/pull/29892#issuecomment-699965686 **[Test build #129181 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129181/testReport)** for PR 29892 at commit

[GitHub] [spark] SparkQA commented on pull request #29817: [SPARK-32850][CORE][K8S] Simplify the RPC message flow of decommission

2020-09-28 Thread GitBox
SparkQA commented on pull request #29817: URL: https://github.com/apache/spark/pull/29817#issuecomment-699965753 **[Test build #129182 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129182/testReport)** for PR 29817 at commit

[GitHub] [spark] SparkQA commented on pull request #29024: [SPARK-32001][SQL]Create JDBC authentication provider developer API

2020-09-28 Thread GitBox
SparkQA commented on pull request #29024: URL: https://github.com/apache/spark/pull/29024#issuecomment-699970496 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33794/

[GitHub] [spark] leanken commented on a change in pull request #29882: [SPARK-33008][SQL] Division by zero on divide-like operations returns incorrect result

2020-09-28 Thread GitBox
leanken commented on a change in pull request #29882: URL: https://github.com/apache/spark/pull/29882#discussion_r495893654 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala ## @@ -360,22 +372,24 @@ trait DivModLike extends

[GitHub] [spark] SparkQA commented on pull request #29817: [SPARK-32850][CORE][K8S] Simplify the RPC message flow of decommission

2020-09-28 Thread GitBox
SparkQA commented on pull request #29817: URL: https://github.com/apache/spark/pull/29817#issuecomment-699978422 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33795/

[GitHub] [spark] SparkQA commented on pull request #29892: [MINOR][DOCS] Document when `current_date` and `current_timestamp` are evaluated

2020-09-28 Thread GitBox
SparkQA commented on pull request #29892: URL: https://github.com/apache/spark/pull/29892#issuecomment-699985640 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33797/

[GitHub] [spark] AmplabJenkins commented on pull request #29817: [SPARK-32850][CORE][K8S] Simplify the RPC message flow of decommission

2020-09-28 Thread GitBox
AmplabJenkins commented on pull request #29817: URL: https://github.com/apache/spark/pull/29817#issuecomment-699989257 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29817: [SPARK-32850][CORE][K8S] Simplify the RPC message flow of decommission

2020-09-28 Thread GitBox
AmplabJenkins removed a comment on pull request #29817: URL: https://github.com/apache/spark/pull/29817#issuecomment-699989257 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] tanelk commented on a change in pull request #29842: [SPARK-32970][SQL][TEST] Reduce the runtime of an UT for SPARK-32019

2020-09-28 Thread GitBox
tanelk commented on a change in pull request #29842: URL: https://github.com/apache/spark/pull/29842#discussion_r495932535 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/FileSourceStrategySuite.scala ## @@ -529,37 +529,42 @@ class

[GitHub] [spark] SparkQA commented on pull request #29889: [SPARK-33015][SQL] Compute the current date only once

2020-09-28 Thread GitBox
SparkQA commented on pull request #29889: URL: https://github.com/apache/spark/pull/29889#issuecomment-72296 **[Test build #129175 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129175/testReport)** for PR 29889 at commit

[GitHub] [spark] SparkQA commented on pull request #29024: [SPARK-32001][SQL]Create JDBC authentication provider developer API

2020-09-28 Thread GitBox
SparkQA commented on pull request #29024: URL: https://github.com/apache/spark/pull/29024#issuecomment-699958450 **[Test build #129180 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129180/testReport)** for PR 29024 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29339: [SPARK-32512][SQL] add alter table add/drop partition command for datasourcev2

2020-09-28 Thread GitBox
AmplabJenkins removed a comment on pull request #29339: URL: https://github.com/apache/spark/pull/29339#issuecomment-699957002 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29886: [SPARK-27951][SQL][FOLLOWUP] Improve the window function nth_value

2020-09-28 Thread GitBox
AmplabJenkins removed a comment on pull request #29886: URL: https://github.com/apache/spark/pull/29886#issuecomment-699957160 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29024: [SPARK-32001][SQL]Create JDBC authentication provider developer API

2020-09-28 Thread GitBox
AmplabJenkins commented on pull request #29024: URL: https://github.com/apache/spark/pull/29024#issuecomment-699970695 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29024: [SPARK-32001][SQL]Create JDBC authentication provider developer API

2020-09-28 Thread GitBox
AmplabJenkins removed a comment on pull request #29024: URL: https://github.com/apache/spark/pull/29024#issuecomment-699970695 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29790: [SPARK-32914][SQL] Avoid constructing dataType multiple times

2020-09-28 Thread GitBox
AmplabJenkins removed a comment on pull request #29790: URL: https://github.com/apache/spark/pull/29790#issuecomment-75941 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29725: [SPARK-32096][SQL] Improve sorting performance of Spark SQL window function by removing window partition key from sort order

2020-09-28 Thread GitBox
AmplabJenkins removed a comment on pull request #29725: URL: https://github.com/apache/spark/pull/29725#issuecomment-74950 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on pull request #29790: [SPARK-32914][SQL] Avoid constructing dataType multiple times

2020-09-28 Thread GitBox
AmplabJenkins commented on pull request #29790: URL: https://github.com/apache/spark/pull/29790#issuecomment-75928 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] HyukjinKwon commented on a change in pull request #28032: [SPARK-31264][SQL] Repartition by dynamic partition columns before insert partition table

2020-09-28 Thread GitBox
HyukjinKwon commented on a change in pull request #28032: URL: https://github.com/apache/spark/pull/28032#discussion_r495714771 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ## @@ -2038,6 +2038,15 @@ object SQLConf { .booleanConf

[GitHub] [spark] viirya commented on a change in pull request #29804: [SPARK-32859][SQL] Introduce physical rule to decide bucketing dynamically

2020-09-28 Thread GitBox
viirya commented on a change in pull request #29804: URL: https://github.com/apache/spark/pull/29804#discussion_r495714902 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ## @@ -951,6 +951,14 @@ object SQLConf { .checkValue(_ > 0,

[GitHub] [spark] viirya commented on a change in pull request #29804: [SPARK-32859][SQL] Introduce physical rule to decide bucketing dynamically

2020-09-28 Thread GitBox
viirya commented on a change in pull request #29804: URL: https://github.com/apache/spark/pull/29804#discussion_r495714902 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ## @@ -951,6 +951,14 @@ object SQLConf { .checkValue(_ > 0,

[GitHub] [spark] maropu commented on pull request #29884: [SPARK-32992][SQL] Map Oracle's ROWID type to StringType in read via JDBC

2020-09-28 Thread GitBox
maropu commented on pull request #29884: URL: https://github.com/apache/spark/pull/29884#issuecomment-699809729 Could you add tests in the Oracle integration test? This is an automated message from the Apache Git Service. To

[GitHub] [spark] gaborgsomogyi commented on pull request #29729: [SPARK-32032][SS] Avoid infinite wait in driver because of KafkaConsumer.poll(long) API

2020-09-28 Thread GitBox
gaborgsomogyi commented on pull request #29729: URL: https://github.com/apache/spark/pull/29729#issuecomment-699835649 @HeartSaVioR OK, I'm going to have another round w/ the Kafka guys in order to have exhaustive and exact answers. I would personally add this to the "SS migration note".

  1   2   3   4   5   6   7   >