[GitHub] [spark] Yikun commented on a change in pull request #35422: [SPARK-36061][K8S] Add `volcano` module and feature step

2022-02-11 Thread GitBox
Yikun commented on a change in pull request #35422: URL: https://github.com/apache/spark/pull/35422#discussion_r804558321 ## File path: resource-managers/kubernetes/core/pom.xml ## @@ -29,8 +29,25 @@ Spark Project Kubernetes kubernetes +**/*Volcano*.scala

[GitHub] [spark] LuciferYang opened a new pull request #35493: [SPAPRK-38192][TESTS] Fix potential resource leak in `kvstore.RocksDBSuite`

2022-02-11 Thread GitBox
LuciferYang opened a new pull request #35493: URL: https://github.com/apache/spark/pull/35493 ### What changes were proposed in this pull request? `countKeys` method in `kvstore.RocksDBSuite` use `db.db().newIterator()` to create a `RocksIterator` instance, but there is no way to close

[GitHub] [spark] LuciferYang commented on pull request #35493: [SPAPRK-38192][TESTS] Fix potential resource leak in `kvstore.RocksDBSuite`

2022-02-11 Thread GitBox
LuciferYang commented on pull request #35493: URL: https://github.com/apache/spark/pull/35493#issuecomment-1036262265 cc @dongjoon-hyun -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [spark] pralabhkumar commented on a change in pull request #35191: [SPARK-37491][PYTHON]Fix Series.asof for unsorted values

2022-02-11 Thread GitBox
pralabhkumar commented on a change in pull request #35191: URL: https://github.com/apache/spark/pull/35191#discussion_r804720550 ## File path: python/pyspark/pandas/tests/test_series.py ## @@ -2071,6 +2071,22 @@ def test_asof(self): with

[GitHub] [spark] pralabhkumar commented on a change in pull request #35191: [SPARK-37491][PYTHON]Fix Series.asof for unsorted values

2022-02-11 Thread GitBox
pralabhkumar commented on a change in pull request #35191: URL: https://github.com/apache/spark/pull/35191#discussion_r804720550 ## File path: python/pyspark/pandas/tests/test_series.py ## @@ -2071,6 +2071,22 @@ def test_asof(self): with

<    1   2