[GitHub] spark pull request: Support cross building for Scala 2.11

2014-11-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3159#issuecomment-62295971 [Test build #23115 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23115/consoleFull) for PR 3159 at commit

[GitHub] spark pull request: Support cross building for Scala 2.11

2014-11-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3159#issuecomment-62295972 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: Support cross building for Scala 2.11

2014-11-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3159#issuecomment-62296123 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: Support cross building for Scala 2.11

2014-11-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3159#issuecomment-62296120 [Test build #23114 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23114/consoleFull) for PR 3159 at commit

[GitHub] spark pull request: [SPARK-4237][BUILD] Fix MANIFEST.MF in maven a...

2014-11-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3103#issuecomment-62296677 [Test build #23116 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23116/consoleFull) for PR 3103 at commit

[GitHub] spark pull request: [SPARK-4237][BUILD] Fix MANIFEST.MF in maven a...

2014-11-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3103#issuecomment-62296681 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-3971][SQL] Backport #2843 to branch-1.1

2014-11-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3113#issuecomment-62297437 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23117/consoleFull) for PR 3113 at commit

[GitHub] spark pull request: Update RecoverableNetworkWordCount.scala

2014-11-09 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/2735#discussion_r20057909 --- Diff: examples/src/main/scala/org/apache/spark/examples/streaming/RecoverableNetworkWordCount.scala --- @@ -114,7 +115,7 @@ object

[GitHub] spark pull request: [WIP][SPARK-3530][MLLIB] pipeline and paramete...

2014-11-09 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/3099#issuecomment-62299039 @shivaram IMHO it would be good to have the developer API updates as well and test a couple of more pipelines before we push this out. I'll try to get a

[GitHub] spark pull request: [SPARK-3971][SQL] Backport #2843 to branch-1.1

2014-11-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3113#issuecomment-62299144 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23117/consoleFull) for PR 3113 at commit

[GitHub] spark pull request: [SPARK-3971][SQL] Backport #2843 to branch-1.1

2014-11-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3113#issuecomment-62299146 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-3971][SQL] Backport #2843 to branch-1.1

2014-11-09 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/3113#issuecomment-62299785 @marmbrus Backported #2164 to fix the Jenkins build failure (ParquetQuerySuite). Should be ready to go. --- If your project is set up for it, you can reply to this

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2014-11-09 Thread yu-iskw
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/2906#issuecomment-62302445 There is a few conflicts with master brach. I will rebase my PR branch, and then force push it. --- If your project is set up for it, you can reply to this email and

[GitHub] spark pull request: [SPARK-4253]Ignore spark.driver.host in yarn-c...

2014-11-09 Thread WangTaoTheTonic
Github user WangTaoTheTonic commented on the pull request: https://github.com/apache/spark/pull/3112#issuecomment-62302608 Additionally, I think spark.driver.host is useful in all client mode including standalone, mesos mode ( i don't know it very mych) and yarn-client mode. When the

[GitHub] spark pull request: [SPARK-4033][Examples]Input of the SparkPi too...

2014-11-09 Thread SaintBacchus
Github user SaintBacchus closed the pull request at: https://github.com/apache/spark/pull/2874 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark pull request: [SPARK-3971][SQL] Backport #2843 to branch-1.1

2014-11-09 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/3113#issuecomment-62304982 @marmbrus However, I didn't quite get why #2164 fixes those Parquet tests. Especially why did you say the original test cases are order dependent? --- If your project

[GitHub] spark pull request: Change the initial iteration num of ruleExecut...

2014-11-09 Thread DoingDone9
GitHub user DoingDone9 opened a pull request: https://github.com/apache/spark/pull/3174 Change the initial iteration num of ruleExecutor from 1 to 0 Change the initial iteration num of ruleExecutor from 1 to 0. You can merge this pull request into a Git repository by running:

[GitHub] spark pull request: Change the initial iteration num of ruleExecut...

2014-11-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3174#issuecomment-62305964 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-4122][STREAMING] Add a library that can...

2014-11-09 Thread helena
Github user helena commented on a diff in the pull request: https://github.com/apache/spark/pull/2994#discussion_r20059145 --- Diff: external/kafka/src/main/scala/org/apache/spark/streaming/kafka/KafkaOutputWriter.scala --- @@ -0,0 +1,126 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: Change the initial iteration num of ruleExecut...

2014-11-09 Thread DoingDone9
Github user DoingDone9 commented on the pull request: https://github.com/apache/spark/pull/3174#issuecomment-62306218 i am new, but i think it is should be 0 not 1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-4274] [SQL] Print informative message w...

2014-11-09 Thread chenghao-intel
Github user chenghao-intel commented on a diff in the pull request: https://github.com/apache/spark/pull/3139#discussion_r20059176 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveComparisonTest.scala --- @@ -341,12 +341,21 @@ abstract class

[GitHub] spark pull request: [SPARK-4274] [SQL] Print informative message w...

2014-11-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3139#issuecomment-62306341 [Test build #23118 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23118/consoleFull) for PR 3139 at commit

[GitHub] spark pull request: Sets SQL operation state to ERROR when excepti...

2014-11-09 Thread liancheng
GitHub user liancheng opened a pull request: https://github.com/apache/spark/pull/3175 Sets SQL operation state to ERROR when exception is thrown In `HiveThriftServer2`, when an exception is thrown during a SQL execution, the SQL operation state should be set to `ERROR`, but now it

[GitHub] spark pull request: [SPARK-4308][SQL] Sets SQL operation state to ...

2014-11-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3175#issuecomment-62306503 [Test build #23119 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23119/consoleFull) for PR 3175 at commit

[GitHub] spark pull request: [SPARK-4308][SQL] Follow up of #3175 for branc...

2014-11-09 Thread liancheng
GitHub user liancheng opened a pull request: https://github.com/apache/spark/pull/3176 [SPARK-4308][SQL] Follow up of #3175 for branch 1.1 The PR for master branch can't be backported to branch 1.1 directly because Hive 0.13.1 support. You can merge this pull request into a Git

[GitHub] spark pull request: [SPARK-2213][SQL] Sort Merge Join

2014-11-09 Thread chenghao-intel
Github user chenghao-intel commented on the pull request: https://github.com/apache/spark/pull/3173#issuecomment-62306671 That's really nice to have the Sort-Merge-Join, as we did meet some of join queries couldn't run completely in real cases. One high level comment on this,

[GitHub] spark pull request: [SPARK-4308][SQL] Follow up of #3175 for branc...

2014-11-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3176#issuecomment-62306835 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23120/consoleFull) for PR 3176 at commit

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2014-11-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2906#issuecomment-62307500 [Test build #23121 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23121/consoleFull) for PR 2906 at commit

[GitHub] spark pull request: [SPARK-4295][External]Fix exception in SparkSi...

2014-11-09 Thread maji2014
GitHub user maji2014 opened a pull request: https://github.com/apache/spark/pull/3177 [SPARK-4295][External]Fix exception in SparkSinkSuite Handle exception in SparkSinkSuite, please refer to [SPARK-4295] You can merge this pull request into a Git repository by running: $ git

[GitHub] spark pull request: [SPARK-4295][External]Fix exception in SparkSi...

2014-11-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3177#issuecomment-62308120 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-4274] [SQL] Print informative message w...

2014-11-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3139#issuecomment-62308752 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4274] [SQL] Print informative message w...

2014-11-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3139#issuecomment-62308750 [Test build #23118 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23118/consoleFull) for PR 3139 at commit

[GitHub] spark pull request: [SPARK-4308][SQL] Sets SQL operation state to ...

2014-11-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3175#issuecomment-62309229 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4308][SQL] Sets SQL operation state to ...

2014-11-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3175#issuecomment-62309225 [Test build #23119 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23119/consoleFull) for PR 3175 at commit

[GitHub] spark pull request: SPARK-2811 upgrade algebird to 0.8.1

2014-11-09 Thread ScrapCodes
Github user ScrapCodes commented on the pull request: https://github.com/apache/spark/pull/2947#issuecomment-62309276 Looks good then. On Nov 9, 2014 8:24 AM, Adam Pingel notificati...@github.com wrote: Algebird 0.8.1 for Scala 2.11 is on the central repo:

[GitHub] spark pull request: [SPARK-4309][SQL] Date type support for Thrift...

2014-11-09 Thread liancheng
GitHub user liancheng opened a pull request: https://github.com/apache/spark/pull/3178 [SPARK-4309][SQL] Date type support for Thrift server You can merge this pull request into a Git repository by running: $ git pull https://github.com/liancheng/spark date-for-thriftserver

[GitHub] spark pull request: [SPARK-4309][SQL] Date type support for Thrift...

2014-11-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3178#issuecomment-62309727 [Test build #23122 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23122/consoleFull) for PR 3178 at commit

[GitHub] spark pull request: [SPARK-4000][Build] Uploads HiveCompatibilityS...

2014-11-09 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/2993#issuecomment-62309812 @pwendell ping :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2014-11-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2906#issuecomment-62310159 [Test build #23121 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23121/consoleFull) for PR 2906 at commit

[GitHub] spark pull request: [SPARK-4205][SQL] Timestamp and Date with comp...

2014-11-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3158#issuecomment-62310177 [Test build #23123 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23123/consoleFull) for PR 3158 at commit

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2014-11-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2906#issuecomment-62310162 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4308][SQL] Follow up of #3175 for branc...

2014-11-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3176#issuecomment-62310223 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4308][SQL] Follow up of #3175 for branc...

2014-11-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3176#issuecomment-62310222 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23120/consoleFull) for PR 3176 at commit

[GitHub] spark pull request: [SPARK-4205][SQL] Timestamp and Date with comp...

2014-11-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3158#issuecomment-62311505 [Test build #23123 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23123/consoleFull) for PR 3158 at commit

[GitHub] spark pull request: [SPARK-4205][SQL] Timestamp and Date with comp...

2014-11-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3158#issuecomment-62311507 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4309][SQL] Date type support for Thrift...

2014-11-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3178#issuecomment-62312335 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4309][SQL] Date type support for Thrift...

2014-11-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3178#issuecomment-62312332 [Test build #23122 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23122/consoleFull) for PR 3178 at commit

[GitHub] spark pull request: SPARK-3648: Provide a script for fetching remo...

2014-11-09 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/3165#issuecomment-62313063 Okay i'm gonna close this. If one of you guys could quickly add docs on our wiki, that would be great. --- If your project is set up for it, you can reply to this

[GitHub] spark pull request: SPARK-3648: Provide a script for fetching remo...

2014-11-09 Thread pwendell
Github user pwendell closed the pull request at: https://github.com/apache/spark/pull/3165 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-4047] - Generate runtime warnings for e...

2014-11-09 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/2894#issuecomment-62313396 @varadharajan Good suggestion about documenting algs for LR; I'll make a note to do that for the upcoming release. Thank you for the PR! LGTM --- If your

[GitHub] spark pull request: SPARK-4156 [MLLIB] EM algorithm for GMMs

2014-11-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3022#issuecomment-62313507 [Test build #514 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/514/consoleFull) for PR 3022 at commit

[GitHub] spark pull request: [SPARK-4079] [CORE] Default to LZF if Snappy n...

2014-11-09 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/3119#issuecomment-62313527 Could this instead just throw an exception when Snappy is configured but not supported? We typically try not to silently mutate configs in the background in favor of

[GitHub] spark pull request: SPARK-4230. Doc for spark.default.parallelism ...

2014-11-09 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/3107#discussion_r20060444 --- Diff: docs/configuration.md --- @@ -563,8 +566,8 @@ Apart from these, the following properties are also available, and may be useful /ul

[GitHub] spark pull request: SPARK-4230. Doc for spark.default.parallelism ...

2014-11-09 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/3107#discussion_r20060453 --- Diff: docs/configuration.md --- @@ -556,6 +556,9 @@ Apart from these, the following properties are also available, and may be useful tr

[GitHub] spark pull request: SPARK-4230. Doc for spark.default.parallelism ...

2014-11-09 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/3107#issuecomment-62313723 Had some minor wording questions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: SPARK-4230. Doc for spark.default.parallelism ...

2014-11-09 Thread sryza
Github user sryza commented on a diff in the pull request: https://github.com/apache/spark/pull/3107#discussion_r20060629 --- Diff: docs/configuration.md --- @@ -556,6 +556,9 @@ Apart from these, the following properties are also available, and may be useful tr

[GitHub] spark pull request: SPARK-4230. Doc for spark.default.parallelism ...

2014-11-09 Thread sryza
Github user sryza commented on a diff in the pull request: https://github.com/apache/spark/pull/3107#discussion_r20060674 --- Diff: docs/configuration.md --- @@ -563,8 +566,8 @@ Apart from these, the following properties are also available, and may be useful /ul

[GitHub] spark pull request: SPARK-4156 [MLLIB] EM algorithm for GMMs

2014-11-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3022#issuecomment-62316919 [Test build #514 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/514/consoleFull) for PR 3022 at commit

[GitHub] spark pull request: SPARK-4276 fix for two working thread

2014-11-09 Thread squito
Github user squito commented on the pull request: https://github.com/apache/spark/pull/3141#issuecomment-62320554 I agress w/ TD, I don't think this change is necessary. I think we should close this and, @svar29 , maybe you can discuss the problem you are running into on the

[GitHub] spark pull request: [SPARK-4260] Httpbroadcast should set connecti...

2014-11-09 Thread squito
Github user squito commented on the pull request: https://github.com/apache/spark/pull/3122#issuecomment-62320949 This looks good, but could also explain what necessitates this change? Did you observe some error? If nothing else, just putting the error you observed in the JIRA

[GitHub] spark pull request: Change the initial iteration num of ruleExecut...

2014-11-09 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/3174#issuecomment-62321314 -1 This breaks the logic of the loop. For example if maxIterations is 1, now it will execute twice. --- If your project is set up for it, you can reply to this email and

[GitHub] spark pull request: [SPARK-4295][External]Fix exception in SparkSi...

2014-11-09 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/3177#issuecomment-62321381 Can you clarify how the tests pass if an exception is thrown? does that also need a fix? --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark pull request: [SPARK-3936] Add aggregateMessages, which supe...

2014-11-09 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/3100#discussion_r20062181 --- Diff: graphx/src/main/scala/org/apache/spark/graphx/TripletFields.scala --- @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request: SPARK-1344 [DOCS] Scala API docs for top metho...

2014-11-09 Thread squito
Github user squito commented on the pull request: https://github.com/apache/spark/pull/3168#issuecomment-62323279 lgtm --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request: SPARK-971 [DOCS] Link to Confluence wiki from ...

2014-11-09 Thread squito
Github user squito commented on the pull request: https://github.com/apache/spark/pull/3169#issuecomment-62323284 lgtm --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2014-11-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2906#issuecomment-62323346 [Test build #23124 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23124/consoleFull) for PR 2906 at commit

[GitHub] spark pull request: [SPARK-1021] Defer the data-driven computation...

2014-11-09 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/3079#discussion_r20062337 --- Diff: core/src/main/scala/org/apache/spark/Partitioner.scala --- @@ -113,8 +117,12 @@ class RangePartitioner[K : Ordering : ClassTag, V]( private

[GitHub] spark pull request: [SPARK-3936] Add aggregateMessages, which supe...

2014-11-09 Thread ankurdave
Github user ankurdave commented on a diff in the pull request: https://github.com/apache/spark/pull/3100#discussion_r20062658 --- Diff: graphx/src/main/scala/org/apache/spark/graphx/TripletFields.scala --- @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request: [SPARK-4000][Build] Uploads HiveCompatibilityS...

2014-11-09 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/2993#issuecomment-62325053 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2014-11-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2906#issuecomment-62325994 [Test build #23124 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23124/consoleFull) for PR 2906 at commit

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2014-11-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2906#issuecomment-62325997 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: SPARK-4230. Doc for spark.default.parallelism ...

2014-11-09 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/3107#discussion_r20063433 --- Diff: docs/configuration.md --- @@ -556,6 +556,9 @@ Apart from these, the following properties are also available, and may be useful tr

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2014-11-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2906#issuecomment-62328415 [Test build #23125 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23125/consoleFull) for PR 2906 at commit

[GitHub] spark pull request: SPARK-4230. Doc for spark.default.parallelism ...

2014-11-09 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/3107#discussion_r20063448 --- Diff: docs/configuration.md --- @@ -563,8 +566,8 @@ Apart from these, the following properties are also available, and may be useful /ul

[GitHub] spark pull request: SPARK-4156 [MLLIB] EM algorithm for GMMs

2014-11-09 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/3022#discussion_r20063810 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/GMMExpectationMaximization.scala --- @@ -0,0 +1,246 @@ +/* + * Licensed to the

[GitHub] spark pull request: [SPARK-4017] show progress bar in console and ...

2014-11-09 Thread squito
Github user squito commented on the pull request: https://github.com/apache/spark/pull/3029#issuecomment-62330615 this is awesome! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: Support cross building for Scala 2.11

2014-11-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3159#issuecomment-62330823 [Test build #23126 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23126/consoleFull) for PR 3159 at commit

[GitHub] spark pull request: SPARK-1344 [DOCS] Scala API docs for top metho...

2014-11-09 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/3168#issuecomment-62330950 Thanks I pulled this in. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-4087] use broadcast for task only when ...

2014-11-09 Thread squito
Github user squito commented on the pull request: https://github.com/apache/spark/pull/2933#issuecomment-62330965 I agree with @pwendell . It seems like the right thing to do is just fix Broadcast ... and if we can't, then wouldn't you also want to turn off Broadcast even for big

[GitHub] spark pull request: [SPARK-1957] [WIP] Pluggable Diskstore for Blo...

2014-11-09 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/907#issuecomment-62331200 Thit is useful as a prototype, I'd prefer to close this issue as an active review. We can use this as a starting point if we revisit the internal interfaces here. ---

[GitHub] spark pull request: Updates to shell globbing in run-example and s...

2014-11-09 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/449#issuecomment-62331162 This is stale so let's close this issue. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: SPARK-1972: Added support for tracking custom ...

2014-11-09 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/918#issuecomment-62331367 I'd like to close this issue for now and keep the JIRA around. This is a completely reasonable way to accomplish adding custom metrics, but this overlaps a good amount

[GitHub] spark pull request: [SPARK-2165] spark on yarn: add support for se...

2014-11-09 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/1279#issuecomment-62331405 Okay let's close this issue for now and he can reopen it if he has time. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: SPARK-971 [DOCS] Link to Confluence wiki from ...

2014-11-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/3169 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: SPARK-1344 [DOCS] Scala API docs for top metho...

2014-11-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/3168 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-3051] Support looking-up named accumula...

2014-11-09 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/2438#issuecomment-62332004 Hey @nfergu - I was looking for any older PR's that have fallen through the cracks and came across this. This is a very well written patch - kudos! When I suggested

[GitHub] spark pull request: [SPARK-3548] [WebUI] Display cache hit ratio o...

2014-11-09 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/2411#issuecomment-62332025 Let's close this issue for now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-3548] [WebUI] Display cache hit ratio o...

2014-11-09 Thread sarutak
Github user sarutak closed the pull request at: https://github.com/apache/spark/pull/2411 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-2671] BlockObjectWriter should create p...

2014-11-09 Thread sarutak
Github user sarutak closed the pull request at: https://github.com/apache/spark/pull/1580 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-3171] Don't print meaningless informati...

2014-11-09 Thread sarutak
Github user sarutak closed the pull request at: https://github.com/apache/spark/pull/2078 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-3551] Remove redundant putting FetchRes...

2014-11-09 Thread sarutak
Github user sarutak closed the pull request at: https://github.com/apache/spark/pull/2413 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-3106] Fix the race condition issue abou...

2014-11-09 Thread sarutak
Github user sarutak closed the pull request at: https://github.com/apache/spark/pull/2019 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-1888] enhance MEMORY_AND_DISK mode by d...

2014-11-09 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/791#issuecomment-62332299 This has mostly gone stale so I'd suggest we close this issue and revisit this later. This is a decent idea, but it does complicate things a good amount, and this

[GitHub] spark pull request: SPARK-1380: Add sort-merge based cogroup/joins...

2014-11-09 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/283#issuecomment-62332367 I'd suggest we close this issue for now and go to the JIRA to discuss whether the feature is needed and how high of a priority it is. --- If your project is set up for

[GitHub] spark pull request: SPARK-2083 Add support for spark.local.maxFail...

2014-11-09 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/1465#issuecomment-62332453 I'm going to close this issue as wontfix. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-1888] enhance MEMORY_AND_DISK mode by d...

2014-11-09 Thread liyezhang556520
Github user liyezhang556520 commented on the pull request: https://github.com/apache/spark/pull/791#issuecomment-62332899 @pwendell , I updated a [design doc](https://issues.apache.org/jira/secure/attachment/12679822/Spark-3000%20Design%20Doc.pdf) for

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2014-11-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2906#issuecomment-62332987 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2014-11-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2906#issuecomment-62332985 [Test build #23125 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23125/consoleFull) for PR 2906 at commit

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2014-11-09 Thread yu-iskw
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/2906#issuecomment-6214 @srowen and @rnowling , Sorry for my complicated commits. I modified my source code. Could you review my PR? - I modified what you pointed out. - I

[GitHub] spark pull request: [SPARK-4310][WebUI] Sort 'Submitted' column in...

2014-11-09 Thread zsxwing
GitHub user zsxwing opened a pull request: https://github.com/apache/spark/pull/3179 [SPARK-4310][WebUI] Sort 'Submitted' column in Stage page by time You can merge this pull request into a Git repository by running: $ git pull https://github.com/zsxwing/spark SPARK-4310

  1   2   >