[GitHub] spark pull request: [SPARK-4094][CORE] checkpoint should still be ...

2014-12-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2956#issuecomment-66246533 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24

[GitHub] spark pull request: [SPARK-4094][CORE] checkpoint should still be ...

2014-12-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2956#issuecomment-66246526 [Test build #24239 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24239/consoleFull) for PR 2956 at commit [`c73ee63`](https://gith

[GitHub] spark pull request: [SPARK-3154][STREAMING] Replace ConcurrentHash...

2014-12-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/3634 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-3154][STREAMING] Replace ConcurrentHash...

2014-12-08 Thread aarondav
Github user aarondav commented on a diff in the pull request: https://github.com/apache/spark/pull/3634#discussion_r21511496 --- Diff: external/flume-sink/src/main/scala/org/apache/spark/streaming/flume/sink/SparkAvroCallbackHandler.scala --- @@ -47,8 +47,8 @@ private[flume] class

[GitHub] spark pull request: [SPARK-3154][STREAMING] Replace ConcurrentHash...

2014-12-08 Thread aarondav
Github user aarondav commented on the pull request: https://github.com/apache/spark/pull/3634#issuecomment-66246264 Merging into master, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not hav

[GitHub] spark pull request: [SPARK-4785] [SQL] Support udf instance ser/de...

2014-12-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3640#issuecomment-66244346 [Test build #24240 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24240/consoleFull) for PR 3640 at commit [`396c0e1`](https://gith

[GitHub] spark pull request: [SPARK-4785] [SQL] Support udf instance ser/de...

2014-12-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3640#issuecomment-66244351 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24

[GitHub] spark pull request: [SPARK-4793] [Deploy] ensure .jar at end of li...

2014-12-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3641#issuecomment-66243872 [Test build #24241 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24241/consoleFull) for PR 3641 at commit [`45cbfd0`](https://githu

[GitHub] spark pull request: [SPARK-4793] [Deploy] ensure .jar at end of li...

2014-12-08 Thread adrian-wang
GitHub user adrian-wang opened a pull request: https://github.com/apache/spark/pull/3641 [SPARK-4793] [Deploy] ensure .jar at end of line sometimes I switch between different version and do not want to rebuild spark, so I rename assembly.jar into .jar.bak, but still caught by `comp

[GitHub] spark pull request: [SPARK-4785] [SQL] Support udf instance ser/de...

2014-12-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3640#issuecomment-66239947 [Test build #24240 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24240/consoleFull) for PR 3640 at commit [`396c0e1`](https://githu

[GitHub] spark pull request: [SPARK-4094][CORE] checkpoint should still be ...

2014-12-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2956#issuecomment-66239252 [Test build #24239 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24239/consoleFull) for PR 2956 at commit [`c73ee63`](https://githu

[GitHub] spark pull request: [SPARK-4772] Clear local copies of accumulator...

2014-12-08 Thread nkronenfeld
Github user nkronenfeld commented on the pull request: https://github.com/apache/spark/pull/3570#issuecomment-66238332 Any word on this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this f

[GitHub] spark pull request: [SPARK-1953][YARN]yarn client mode Application...

2014-12-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3607#issuecomment-66235605 [Test build #24236 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24236/consoleFull) for PR 3607 at commit [`b09c309`](https://gith

[GitHub] spark pull request: [SPARK-1953][YARN]yarn client mode Application...

2014-12-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3607#issuecomment-66235607 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24

[GitHub] spark pull request: [SPARK-4785] [SQL] Support udf instance ser/de...

2014-12-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3640#issuecomment-66234312 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24

[GitHub] spark pull request: [SPARK-4785] [SQL] Support udf instance ser/de...

2014-12-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3640#issuecomment-66234309 [Test build #24238 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24238/consoleFull) for PR 3640 at commit [`e9c3212`](https://gith

[GitHub] spark pull request: [SPARK-1953][YARN]yarn client mode Application...

2014-12-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3607#issuecomment-66234140 [Test build #24235 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24235/consoleFull) for PR 3607 at commit [`ab16bb5`](https://gith

[GitHub] spark pull request: [SPARK-1953][YARN]yarn client mode Application...

2014-12-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3607#issuecomment-66234144 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24

[GitHub] spark pull request: [SPARK-4785] [SQL] Support udf instance ser/de...

2014-12-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3640#issuecomment-66233507 [Test build #24237 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24237/consoleFull) for PR 3640 at commit [`19cbd46`](https://gith

[GitHub] spark pull request: [SPARK-4785] [SQL] Support udf instance ser/de...

2014-12-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3640#issuecomment-66233511 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24

[GitHub] spark pull request: [SPARK-4785] [SQL] Support udf instance ser/de...

2014-12-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3640#issuecomment-66232292 [Test build #24238 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24238/consoleFull) for PR 3640 at commit [`e9c3212`](https://githu

[GitHub] spark pull request: [SPARK-4785] [SQL] Support udf instance ser/de...

2014-12-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3640#issuecomment-66231529 [Test build #24237 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24237/consoleFull) for PR 3640 at commit [`19cbd46`](https://githu

[GitHub] spark pull request: [SPARK-4785] [SQL] Support udf instance ser/de...

2014-12-08 Thread chenghao-intel
GitHub user chenghao-intel opened a pull request: https://github.com/apache/spark/pull/3640 [SPARK-4785] [SQL] Support udf instance ser/de after initialization UDF contract change in Hive 0.13.1. In Hive 0.12.0, it's always safe to construct and initialize a fresh UDF object on work

[GitHub] spark pull request: [SPARK-4714][CORE]: Check block have removed o...

2014-12-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3574#issuecomment-66231241 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24

[GitHub] spark pull request: [SPARK-4714][CORE]: Check block have removed o...

2014-12-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3574#issuecomment-66231235 [Test build #24234 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24234/consoleFull) for PR 3574 at commit [`edb989d`](https://gith

[GitHub] spark pull request: [SPARK-1953][YARN]yarn client mode Application...

2014-12-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3607#issuecomment-66231049 [Test build #24236 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24236/consoleFull) for PR 3607 at commit [`b09c309`](https://githu

[GitHub] spark pull request: [SPARK-1953][YARN]yarn client mode Application...

2014-12-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3607#issuecomment-66229430 [Test build #24235 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24235/consoleFull) for PR 3607 at commit [`ab16bb5`](https://githu

[GitHub] spark pull request: [SPARK-3405] add subnet-id and vpc-id options ...

2014-12-08 Thread jeffsteinmetz
Github user jeffsteinmetz commented on the pull request: https://github.com/apache/spark/pull/2872#issuecomment-66229322 The EC2 docs could also be updated to include these new switches. --- If your project is set up for it, you can reply to this email and have your reply appear on Gi

[GitHub] spark pull request: [SPARK-4742][SQL] The name of Parquet File gen...

2014-12-08 Thread sarutak
Github user sarutak commented on the pull request: https://github.com/apache/spark/pull/3602#issuecomment-66226961 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled an

[GitHub] spark pull request: [SPARK-4714][CORE]: Check block have removed o...

2014-12-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3574#issuecomment-66225436 [Test build #24234 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24234/consoleFull) for PR 3574 at commit [`edb989d`](https://githu

[GitHub] spark pull request: [SPARK-4714][CORE]: Check block have removed o...

2014-12-08 Thread suyanNone
Github user suyanNone commented on the pull request: https://github.com/apache/spark/pull/3574#issuecomment-66224947 @JoshRosen I refine the code according your comments. If still have problem, it OK for you to fix up including the title and comments, and thanks for you to check m

[GitHub] spark pull request: [SPARK-3154][STREAMING] Replace ConcurrentHash...

2014-12-08 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/3634#discussion_r21503445 --- Diff: external/flume-sink/src/main/scala/org/apache/spark/streaming/flume/sink/SparkAvroCallbackHandler.scala --- @@ -47,8 +47,8 @@ private[flume] class

[GitHub] spark pull request: [Core]Remove duplicated code in DAGScheduler

2014-12-08 Thread CodEnFisH
Github user CodEnFisH commented on the pull request: https://github.com/apache/spark/pull/3421#issuecomment-66223296 Sure, we can close this PR first. I will spare more time next week to work on #3515 and keep you posted. --- If your project is set up for it, you can reply to thi

[GitHub] spark pull request: [Core]Remove duplicated code in DAGScheduler

2014-12-08 Thread CodEnFisH
Github user CodEnFisH closed the pull request at: https://github.com/apache/spark/pull/3421 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[GitHub] spark pull request: [SPARK-3967] don’t redundantly overwrite exe...

2014-12-08 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/2848#issuecomment-66222053 Left a couple more comments. This is looking _much_ better than the code that was there before; thanks for your patience with the really late review. I have to run no

[GitHub] spark pull request: [SPARK-4769] [SQL] CTAS does not work when rea...

2014-12-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/3336 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-3967] don’t redundantly overwrite exe...

2014-12-08 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/2848#discussion_r21502123 --- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala --- @@ -412,6 +408,85 @@ private[spark] object Utils extends Logging { }

[GitHub] spark pull request: [SPARK-3967] don’t redundantly overwrite exe...

2014-12-08 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/2848#discussion_r21501964 --- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala --- @@ -412,6 +408,85 @@ private[spark] object Utils extends Logging { }

[GitHub] spark pull request: [SQL] remove unnecessary import in spark-sql

2014-12-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/3630 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SQL] remove unnecessary import in spark-sql

2014-12-08 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/3630#issuecomment-66220273 Alright, merging this into `master`. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

[GitHub] spark pull request: [SPARK-3967] don’t redundantly overwrite exe...

2014-12-08 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/2848#discussion_r21501514 --- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala --- @@ -412,6 +408,85 @@ private[spark] object Utils extends Logging { }

[GitHub] spark pull request: [SPARK-2199] [mllib] topic modeling

2014-12-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1269#issuecomment-66219789 QA results for PR 1269:- This patch FAILED unit tests.For more information see test ouptut:https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/542/conso

[GitHub] spark pull request: [SPARK-3802][BUILD] Scala version is wrong in ...

2014-12-08 Thread sarutak
Github user sarutak commented on the pull request: https://github.com/apache/spark/pull/2661#issuecomment-66219684 O.K, I'll close this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have thi

[GitHub] spark pull request: [SPARK-3802][BUILD] Scala version is wrong in ...

2014-12-08 Thread sarutak
Github user sarutak closed the pull request at: https://github.com/apache/spark/pull/2661 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-3967] don’t redundantly overwrite exe...

2014-12-08 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/2848#discussion_r21501367 --- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala --- @@ -412,6 +408,85 @@ private[spark] object Utils extends Logging { }

[GitHub] spark pull request: [SPARK-3967] don’t redundantly overwrite exe...

2014-12-08 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/2848#discussion_r21501389 --- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala --- @@ -412,6 +408,85 @@ private[spark] object Utils extends Logging { }

[GitHub] spark pull request: [SQL] remove unnecessary import in spark-sql

2014-12-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3630#issuecomment-66218996 [Test build #24233 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24233/consoleFull) for PR 3630 at commit [`150e7e0`](https://gith

[GitHub] spark pull request: [SQL] remove unnecessary import in spark-sql

2014-12-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3630#issuecomment-66219000 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24

[GitHub] spark pull request: [SQL] remove unnecessary import in spark-sql

2014-12-08 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/3630#issuecomment-66214972 This LGTM, pending Jenkins. I just wanted to retest it to avoid a build-break. --- If your project is set up for it, you can reply to this email and have your reply a

[GitHub] spark pull request: SPARK-4770. [DOC] [YARN] spark.scheduler.minRe...

2014-12-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/3624 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-4789] [mllib] Standardize ML Prediction...

2014-12-08 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/3637#discussion_r21499038 --- Diff: mllib/src/main/scala/org/apache/spark/ml/LabeledPoint.scala --- @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

[GitHub] spark pull request: [SPARK-4789] [mllib] Standardize ML Prediction...

2014-12-08 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/3637#discussion_r21498969 --- Diff: mllib/src/main/scala/org/apache/spark/ml/LabeledPoint.scala --- @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

[GitHub] spark pull request: SPARK-4770. [DOC] [YARN] spark.scheduler.minRe...

2014-12-08 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/3624#issuecomment-66214551 I grepped through the code and this LGTM, too, so I'm going to merge this into `master` and `branch-1.2`. Thanks @sryza! --- If your project is set up for it, you can

[GitHub] spark pull request: [SPARK-1953][YARN]yarn client mode Application...

2014-12-08 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/3607#issuecomment-66214045 Hey @WangTaoTheTonic I left a few comments. Also, could you document this? Thanks. --- If your project is set up for it, you can reply to this email and have your rep

[GitHub] spark pull request: [SPARK-2141] Adding getPersistentRddIds and un...

2014-12-08 Thread kanzhang
Github user kanzhang closed the pull request at: https://github.com/apache/spark/pull/1082 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is en

[GitHub] spark pull request: [SPARK-3802][BUILD] Scala version is wrong in ...

2014-12-08 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/2661#issuecomment-66213955 Yeah, it looks like this has been subsumed by Andrew's changes in 723a86b04cfbc178fbd57bb78f4a2becc5cb1ef1, so do you mind closing this PR? Thanks! --- If your proje

[GitHub] spark pull request: [SPARK-2141] Adding getPersistentRddIds and un...

2014-12-08 Thread kanzhang
Github user kanzhang commented on the pull request: https://github.com/apache/spark/pull/1082#issuecomment-66213985 OK, closing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark pull request: [SPARK-1953][YARN]yarn client mode Application...

2014-12-08 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/3607#discussion_r21498649 --- Diff: yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ClientArguments.scala --- @@ -54,8 +46,25 @@ private[spark] class ClientArguments(args:

[GitHub] spark pull request: [DOC] update IntelliJ IDEA profile description

2014-12-08 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/3584#issuecomment-66213786 This looks good to me, although I wanted to note that we have some more detailed IntelliJ instructions over at https://cwiki.apache.org/confluence/display/SPARK/Useful+

[GitHub] spark pull request: [SPARK-1953][YARN]yarn client mode Application...

2014-12-08 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/3607#discussion_r21498553 --- Diff: yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ClientArguments.scala --- @@ -54,8 +46,25 @@ private[spark] class ClientArguments(args:

[GitHub] spark pull request: [SPARK-1953][YARN]yarn client mode Application...

2014-12-08 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/3607#discussion_r21498518 --- Diff: yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ClientArguments.scala --- @@ -54,8 +46,25 @@ private[spark] class ClientArguments(args:

[GitHub] spark pull request: [Core]Remove duplicated code in DAGScheduler

2014-12-08 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/3421#issuecomment-66213595 Do you mind closing this PR for now? I'd be happy to discuss more DAGScheudler refactorings later, but it would be nice get this out of the review queue for now unless

[GitHub] spark pull request: SPARK-3926 [CORE] Reopened: result of JavaRDD ...

2014-12-08 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/3587#issuecomment-66213344 Merged to `branch-1.1`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have th

[GitHub] spark pull request: [SPARK-4765] Make GC time always shown in UI.

2014-12-08 Thread kayousterhout
Github user kayousterhout commented on the pull request: https://github.com/apache/spark/pull/3622#issuecomment-66213467 @JoshRosen One thing I was wondering about here that I couldn't figure out: what does "private" actually mean in this context? I would have thought it meant that i

[GitHub] spark pull request: [SPARK-1953][YARN]yarn client mode Application...

2014-12-08 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/3607#discussion_r21498374 --- Diff: yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ClientArguments.scala --- @@ -54,8 +46,25 @@ private[spark] class ClientArguments(args:

[GitHub] spark pull request: SPARK-3926 [CORE] Reopened: result of JavaRDD ...

2014-12-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/3587 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: SPARK-3926 [CORE] Reopened: result of JavaRDD ...

2014-12-08 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/3587#issuecomment-66213074 LGTM, too. Merging into `master` and tagging for `branch-1.2` backport. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: [SPARK-4789] [mllib] Standardize ML Prediction...

2014-12-08 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/3637#discussion_r21498173 --- Diff: mllib/src/main/scala/org/apache/spark/ml/LabeledPoint.scala --- @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

[GitHub] spark pull request: [SQL] remove unnecessary import in spark-sql

2014-12-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3630#issuecomment-66212933 [Test build #24233 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24233/consoleFull) for PR 3630 at commit [`150e7e0`](https://githu

[GitHub] spark pull request: [SPARK-4765] Make GC time always shown in UI.

2014-12-08 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/3622#issuecomment-66212544 ``` [error] * method GC_TIME()java.lang.String in object org.apache.spark.ui.jobs.TaskDetailsClassNames does not have a correspondent in new version [error]

[GitHub] spark pull request: [SPARK-4461][YARN] pass extra java options to ...

2014-12-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3409#issuecomment-66212417 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24

[GitHub] spark pull request: [SQL] remove unnecessary import in spark-sql

2014-12-08 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/3630#issuecomment-66212396 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] spark pull request: [SPARK-4461][YARN] pass extra java options to ...

2014-12-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3409#issuecomment-66212407 [Test build #24232 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24232/consoleFull) for PR 3409 at commit [`e3f9abe`](https://gith

[GitHub] spark pull request: Add error message when making local dir unsucc...

2014-12-08 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/3635#issuecomment-66212364 Mind creating a JIRA for this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-4750] Dynamic allocation - synchronize ...

2014-12-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/3612 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-4789] [mllib] Standardize ML Prediction...

2014-12-08 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/3637#discussion_r21497595 --- Diff: mllib/src/main/scala/org/apache/spark/ml/LabeledPoint.scala --- @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

[GitHub] spark pull request: [SPARK-2199] [mllib] topic modeling

2014-12-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1269#issuecomment-66211199 QA tests have started for PR 1269. This patch DID NOT merge cleanly! View progress: https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/542/consoleFull

[GitHub] spark pull request: [SPARK-2199] [mllib] topic modeling

2014-12-08 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/1269#issuecomment-66210825 @akopich The test failure seems unrelated (from a Python SQL test). I'll re-run the tests. (2) Regular and Robust in the same class Would i

[GitHub] spark pull request: [SPARK-4774] [SQL] Makes HiveFromSpark more po...

2014-12-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/3628 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-4774] [SQL] Makes HiveFromSpark more po...

2014-12-08 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/3628#issuecomment-66209979 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled a

[GitHub] spark pull request: [SPARK-4789] [mllib] Standardize ML Prediction...

2014-12-08 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/3637#discussion_r21496412 --- Diff: mllib/src/main/scala/org/apache/spark/ml/LabeledPoint.scala --- @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

[GitHub] spark pull request: SPARK-4567. Make SparkJobInfo and SparkStageIn...

2014-12-08 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/3426#issuecomment-66208947 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled a

[GitHub] spark pull request: [SPARK-4750] Dynamic allocation - synchronize ...

2014-12-08 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/3612#issuecomment-66209014 LGTM. I'm going to merge this into `master` and add a `backport-needed` tag so we don't forget to merge this into `branch-1.2`. --- If your project is set up for it,

[GitHub] spark pull request: [SPARK-2309][MLlib] Generalize the binary logi...

2014-12-08 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/1379#issuecomment-66208868 @avulanov Nice tests! A few comments: * Computing accuracy: It would be good to test on the original MNIST test set, rather than a subset of the training set. The

[GitHub] spark pull request: [SPARK-4789] [mllib] Standardize ML Prediction...

2014-12-08 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/3637#discussion_r21495884 --- Diff: mllib/src/main/scala/org/apache/spark/ml/LabeledPoint.scala --- @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

[GitHub] spark pull request: [SPARK-4789] [mllib] Standardize ML Prediction...

2014-12-08 Thread Lewuathe
Github user Lewuathe commented on a diff in the pull request: https://github.com/apache/spark/pull/3637#discussion_r21494740 --- Diff: mllib/src/main/scala/org/apache/spark/ml/LabeledPoint.scala --- @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

[GitHub] spark pull request: [SPARK-4759] Avoid using empty string as defau...

2014-12-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3633#issuecomment-66204818 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24

[GitHub] spark pull request: [SPARK-4759] Avoid using empty string as defau...

2014-12-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3633#issuecomment-66204811 [Test build #24231 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24231/consoleFull) for PR 3633 at commit [`f370a4e`](https://gith

[GitHub] spark pull request: SPARK-4770. [DOC] [YARN] spark.scheduler.minRe...

2014-12-08 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/3624#issuecomment-66204351 @tgravescs It should be fine to pull docs-only changes into `branch-1.2`. We're trying to hold off on merging code changes that aren't addressing 1.2.0 release blocker

[GitHub] spark pull request: [SPARK-1953][YARN]yarn client mode Application...

2014-12-08 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/3607#discussion_r21493950 --- Diff: yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ClientArguments.scala --- @@ -54,8 +46,25 @@ private[spark] class ClientArguments(args:

[GitHub] spark pull request: [SPARK-3382] GradientDescent convergence toler...

2014-12-08 Thread Lewuathe
Github user Lewuathe commented on the pull request: https://github.com/apache/spark/pull/3636#issuecomment-66203442 @jkbradley Thank you for reviewing. I'll update these points soon. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark pull request: [SPARK-4789] [mllib] Standardize ML Prediction...

2014-12-08 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/3637#issuecomment-66203211 The test failure reveals an issue in Spark SQL (ScalaReflection.scala:121 in schemaFor) where it gets confused if the case class includes multiple constructors. The de

[GitHub] spark pull request: [SPARK-4461][YARN] pass extra java options to ...

2014-12-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3409#issuecomment-66202544 [Test build #24232 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24232/consoleFull) for PR 3409 at commit [`e3f9abe`](https://githu

[GitHub] spark pull request: [SPARK-4737] Task set manager properly handles...

2014-12-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3638#issuecomment-66201380 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24

[GitHub] spark pull request: [SPARK-4737] Task set manager properly handles...

2014-12-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3638#issuecomment-66201371 [Test build #24230 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24230/consoleFull) for PR 3638 at commit [`94844d7`](https://gith

[GitHub] spark pull request: [SPARK-4714][CORE]: Add checking info is null ...

2014-12-08 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/3574#issuecomment-66199309 Left one minor code organization comment; aside from that, this looks good to me and should be ready to merge after you fix that up (I can do it if you don't have time,

[GitHub] spark pull request: [SPARK-4714][CORE]: Add checking info is null ...

2014-12-08 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/3574#discussion_r21491375 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala --- @@ -1010,7 +1010,10 @@ private[spark] class BlockManager( info.sync

[GitHub] spark pull request: [WIP] SPARK-2450 Adds exeuctor log links to We...

2014-12-08 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/3486#discussion_r21491005 --- Diff: core/src/main/scala/org/apache/spark/scheduler/SparkListener.scala --- @@ -183,6 +193,16 @@ trait SparkListener { * Called when the driver re

[GitHub] spark pull request: [WIP] SPARK-2450 Adds exeuctor log links to We...

2014-12-08 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/3486#discussion_r21490919 --- Diff: core/src/main/scala/org/apache/spark/scheduler/SparkListener.scala --- @@ -183,6 +193,16 @@ trait SparkListener { * Called when the driver re

[GitHub] spark pull request: Cdh5

2014-12-08 Thread orenmazor
Github user orenmazor closed the pull request at: https://github.com/apache/spark/pull/3639 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

  1   2   >