[GitHub] spark pull request: [SPARK-12361][PYSPARK][TESTS] Should set PYSPA...

2015-12-16 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/10322#issuecomment-165221194 LGTM, so I'm going to merge this into master. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark pull request: [SPARK-9690][ML][PYTHON] pyspark CrossValidato...

2015-12-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10268#issuecomment-165221379 **[Test build #47844 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47844/consoleFull)** for PR 10268 at commit

[GitHub] spark pull request: [SPARK-12361][PYSPARK][TESTS] Should set PYSPA...

2015-12-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/10322 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-12054] [SQL] Consider nullability of ex...

2015-12-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10333#issuecomment-165224554 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11749][Streaming] Duplicate creating th...

2015-12-16 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/9765#discussion_r47823645 --- Diff: streaming/src/test/scala/org/apache/spark/streaming/CheckpointSuite.scala --- @@ -715,6 +736,35 @@ class CheckpointSuite extends TestSuiteBase with

[GitHub] spark pull request: [SPARK-11749][Streaming] Duplicate creating th...

2015-12-16 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/9765#discussion_r47823739 --- Diff: streaming/src/test/scala/org/apache/spark/streaming/CheckpointSuite.scala --- @@ -715,6 +736,35 @@ class CheckpointSuite extends TestSuiteBase with

[GitHub] spark pull request: [SPARK-12220][Core]Make Utils.fetchFile suppor...

2015-12-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10208#issuecomment-165226014 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12345] [CORE] Do not send SPARK_HOME th...

2015-12-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10329#issuecomment-165226009 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11100][SQL] HiveThriftServer not regist...

2015-12-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9113#issuecomment-165225983 **[Test build #47849 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47849/consoleFull)** for PR 9113 at commit

[GitHub] spark pull request: [SPARK-12345] [CORE] Do not send SPARK_HOME th...

2015-12-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10329#issuecomment-165226005 **[Test build #47845 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47845/consoleFull)** for PR 10329 at commit

[GitHub] spark pull request: [SPARK-12345] [CORE] Do not send SPARK_HOME th...

2015-12-16 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/10329#issuecomment-165225775 @skyluc looks like there is a style violation with this patch --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark pull request: [SPARK-12345][MESOS] Filter SPARK_HOME when su...

2015-12-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10332#issuecomment-165227460 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11608][MLLIB][DOC] Added migration guid...

2015-12-16 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/10235#issuecomment-165227363 OK thanks! Merging with master and branch-1.6 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [SPARK-12345][MESOS] Filter SPARK_HOME when su...

2015-12-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10332#issuecomment-165227299 **[Test build #47830 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47830/consoleFull)** for PR 10332 at commit

[GitHub] spark pull request: [SPARK-11100][SQL] HiveThriftServer not regist...

2015-12-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9113#issuecomment-165231454 **[Test build #47849 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47849/consoleFull)** for PR 9113 at commit

[GitHub] spark pull request: [SPARK-11100][SQL] HiveThriftServer not regist...

2015-12-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9113#issuecomment-165231601 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12054] [SQL] Consider nullability of ex...

2015-12-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10333#issuecomment-165233024 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [Spark-12374][SPARK-12150][SQL] Adding logical...

2015-12-16 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/10335#issuecomment-165238477 Sure, will do It! Thank you for your guidance! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [SPARK-5682][Core] Add encrypted shuffle in sp...

2015-12-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8880#issuecomment-165241236 **[Test build #47838 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47838/consoleFull)** for PR 8880 at commit

[GitHub] spark pull request: [SPARK-11097][Core]Add connectionEstablished c...

2015-12-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10301#issuecomment-165244297 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11097][Core]Add connectionEstablished c...

2015-12-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10301#issuecomment-165244293 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12350] [core] Don't log errors when req...

2015-12-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10337#issuecomment-165246287 **[Test build #47854 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47854/consoleFull)** for PR 10337 at commit

[GitHub] spark pull request: [SPARK-11749][Streaming] Duplicate creating th...

2015-12-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9765#issuecomment-165220595 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12345] [CORE] Do not send SPARK_HOME th...

2015-12-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10329#issuecomment-165223713 **[Test build #2221 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2221/consoleFull)** for PR 10329 at commit

[GitHub] spark pull request: [SPARK-11904] [PySpark] reduceByKeyAndWindow d...

2015-12-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9888#issuecomment-165225716 **[Test build #47848 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47848/consoleFull)** for PR 9888 at commit

[GitHub] spark pull request: [SPARK-11904] [PySpark] reduceByKeyAndWindow d...

2015-12-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9888#issuecomment-165225719 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12345] [CORE] Do not send SPARK_HOME th...

2015-12-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10329#issuecomment-165222829 **[Test build #47845 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47845/consoleFull)** for PR 10329 at commit

[GitHub] spark pull request: [SPARK-11904] [PySpark] reduceByKeyAndWindow d...

2015-12-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9888#issuecomment-165225722 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [Minor] Add missing interpolation in NettyRPCE...

2015-12-16 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/10334#issuecomment-165226512 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request: [SPARK-12054] [SQL] Consider nullability of ex...

2015-12-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10333#issuecomment-165230905 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [Spark-12374][SPARK-12150][SQL] Adding logical...

2015-12-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10335#issuecomment-165232112 **[Test build #47852 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47852/consoleFull)** for PR 10335 at commit

[GitHub] spark pull request: [Spark-12374][SPARK-12150][SQL] Adding logical...

2015-12-16 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/10335#discussion_r47829608 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/basicOperators.scala --- @@ -126,6 +127,69 @@ case class Sample( } }

[GitHub] spark pull request: [Spark-12374][SPARK-12150][SQL] Adding logical...

2015-12-16 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/10335#discussion_r47830240 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicOperators.scala --- @@ -210,6 +210,37 @@ case class Sort(

[GitHub] spark pull request: [SPARK-11097][Core]Add connectionEstablished c...

2015-12-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10301#issuecomment-165244012 **[Test build #47834 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47834/consoleFull)** for PR 10301 at commit

[GitHub] spark pull request: [SPARK-12350] [core] Don't log errors when req...

2015-12-16 Thread vanzin
GitHub user vanzin opened a pull request: https://github.com/apache/spark/pull/10337 [SPARK-12350] [core] Don't log errors when requested stream is not found. If a client requests a non-existent stream, just send a failure message back, without logging any error on the server

[GitHub] spark pull request: [Spark-12374][SPARK-12150][SQL] Adding logical...

2015-12-16 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/10335#discussion_r47834244 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicOperators.scala --- @@ -210,6 +210,37 @@ case class Sort(

[GitHub] spark pull request: [Minor] Add missing interpolation in NettyRPCE...

2015-12-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10334#issuecomment-165247391 **[Test build #47842 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47842/consoleFull)** for PR 10334 at commit

[GitHub] spark pull request: [SPARK-12321][SQL] JSON format for TreeNode (u...

2015-12-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10311#issuecomment-165175811 **[Test build #47819 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47819/consoleFull)** for PR 10311 at commit

[GitHub] spark pull request: [SPARK-10775][UI]add search keywords in histor...

2015-12-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8885#issuecomment-165184442 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12345][MESOS] Filter SPARK_HOME when su...

2015-12-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10332#issuecomment-165194859 **[Test build #47830 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47830/consoleFull)** for PR 10332 at commit

[GitHub] spark pull request: [SPARK-12345] [CORE] Do not send SPARK_HOME th...

2015-12-16 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/10329#issuecomment-165202252 I will go ahead and do a quick test on standalone cluster mode with this fix and report back. --- If your project is set up for it, you can reply to this email and

[GitHub] spark pull request: [SPARK-12345] [CORE] Do not send SPARK_HOME th...

2015-12-16 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/10329#issuecomment-165202088 This seems like a better place to filter it out. My only concern is that this one also affects standalone cluster mode, whereas #10332 is totally a Mesos thing.

[GitHub] spark pull request: [SPARK-12345][MESOS] Filter SPARK_HOME when su...

2015-12-16 Thread skyluc
Github user skyluc commented on the pull request: https://github.com/apache/spark/pull/10332#issuecomment-165204770 Code LGTM. Unfortunately, I cannot try it before a couple of hours. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: [SPARK-12054] [SQL] Consider nullability of ex...

2015-12-16 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/10333#issuecomment-165204839 cc @liancheng --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-12318][SPARKR] Save mode in SparkR shou...

2015-12-16 Thread shivaram
Github user shivaram commented on the pull request: https://github.com/apache/spark/pull/10290#issuecomment-165204897 LGTM. Merging into master (and not `branch-1.6` as we probably don't want to change the API in a minor release like 1.6.1). --- If your project is set up for it,

[GitHub] spark pull request: [SPARK-12345][MESOS] Filter SPARK_HOME when su...

2015-12-16 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/10332#issuecomment-165210134 LGTM merging into master and 1.6. Just FYI I might revert this patch in master because I believe #10329 is a better fix in the long run, but for now let's just

[GitHub] spark pull request: [SPARK-12345][MESOS] Filter SPARK_HOME when su...

2015-12-16 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/10332#discussion_r47816823 --- Diff: core/src/main/scala/org/apache/spark/deploy/rest/mesos/MesosRestServer.scala --- @@ -94,7 +94,12 @@ private[mesos] class

[GitHub] spark pull request: [SPARK-12321][SQL] JSON format for TreeNode (u...

2015-12-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10311#issuecomment-165209891 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12048][SQL] Part 2 Prevent to close JDB...

2015-12-16 Thread tedyu
Github user tedyu commented on the pull request: https://github.com/apache/spark/pull/10320#issuecomment-165209976 I compared JDBCRDD.scala with JdbcRDD.scala From what I can tell according to the usage of java.sql.Connection and java.sql.ResultSet, the proposed change is needed

[GitHub] spark pull request: [SPARK-6518][MLlib][Example][DOC] Add example ...

2015-12-16 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/9952#issuecomment-165210239 LGTM, merging with master and branch-1.6 Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark pull request: [SPARK-9690][ML][PYTHON] pyspark CrossValidato...

2015-12-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10268#issuecomment-165221624 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-9690][ML][PYTHON] pyspark CrossValidato...

2015-12-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10268#issuecomment-165221626 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4621][shuffle]Shuffle index can be cach...

2015-12-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10277#issuecomment-165221559 **[Test build #47827 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47827/consoleFull)** for PR 10277 at commit

[GitHub] spark pull request: [SPARK-10618] [Mesos] Refactoring scheduling c...

2015-12-16 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/10326#issuecomment-165224832 ok to test (@dragos you can also say this by the way) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-11749][Streaming] Duplicate creating th...

2015-12-16 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/9765#issuecomment-165224917 Just two nits. Otherwise LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-12365][CORE] Use ShutdownHookManager wh...

2015-12-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10325#issuecomment-165229350 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12365][CORE] Use ShutdownHookManager wh...

2015-12-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10325#issuecomment-165229169 **[Test build #47831 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47831/consoleFull)** for PR 10325 at commit

[GitHub] spark pull request: [SPARK-12054] [SQL] Consider nullability of ex...

2015-12-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10333#issuecomment-165232552 **[Test build # has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder//consoleFull)** for PR 10333 at commit

[GitHub] spark pull request: [SPARK-12054] [SQL] Consider nullability of ex...

2015-12-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10333#issuecomment-165232881 **[Test build #47835 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47835/consoleFull)** for PR 10333 at commit

[GitHub] spark pull request: [SPARK-12054] [SQL] Consider nullability of ex...

2015-12-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10333#issuecomment-165233027 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11171][SPARK-11237][SPARK-11241][ML] Tr...

2015-12-16 Thread holdenk
Github user holdenk commented on the pull request: https://github.com/apache/spark/pull/9207#issuecomment-165233108 ping @jkbradley --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [Spark-12374][SPARK-12150][SQL] Adding logical...

2015-12-16 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/10335#discussion_r47828090 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/basicOperators.scala --- @@ -126,6 +127,69 @@ case class Sample( } }

[GitHub] spark pull request: [SPARK-12186] [WEB UI] Send the complete reque...

2015-12-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10180#issuecomment-165233273 **[Test build #47839 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47839/consoleFull)** for PR 10180 at commit

[GitHub] spark pull request: [Spark-12374][SPARK-12150][SQL] Adding logical...

2015-12-16 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/10335#discussion_r47828506 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicOperators.scala --- @@ -210,6 +210,37 @@ case class Sort(

[GitHub] spark pull request: [SPARK-12186] [WEB UI] Send the complete reque...

2015-12-16 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/10180#issuecomment-165240392 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-12054] [SQL] Consider nullability of ex...

2015-12-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10333#issuecomment-165230907 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [Spark-12374][SPARK-12150][SQL] Adding logical...

2015-12-16 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/10335#discussion_r47827840 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/basicOperators.scala --- @@ -126,6 +127,69 @@ case class Sample( } }

[GitHub] spark pull request: [SPARK-12186] [WEB UI] Send the complete reque...

2015-12-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10180#issuecomment-165233362 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12376][TESTS] Spark Streaming Java8APIS...

2015-12-16 Thread evanyc15
GitHub user evanyc15 opened a pull request: https://github.com/apache/spark/pull/10336 [SPARK-12376][TESTS] Spark Streaming Java8APISuite fails in assertOrderInvariantEquals method org.apache.spark.streaming.Java8APISuite.java is failing due to trying to sort immutable list in

[GitHub] spark pull request: [Spark-12374][SPARK-12150][SQL] Adding logical...

2015-12-16 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/10335#discussion_r47829468 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicOperators.scala --- @@ -210,6 +210,37 @@ case class Sort(

[GitHub] spark pull request: [Spark-12374][SPARK-12150][SQL] Adding logical...

2015-12-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10335#issuecomment-165236262 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [Spark-12374][SPARK-12150][SQL] Adding logical...

2015-12-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10335#issuecomment-165236260 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12376][TESTS] Spark Streaming Java8APIS...

2015-12-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10336#issuecomment-165236230 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [Spark-12374][SPARK-12150][SQL] Adding logical...

2015-12-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10335#issuecomment-165236228 **[Test build #47852 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47852/consoleFull)** for PR 10335 at commit

[GitHub] spark pull request: [Spark-12374][SPARK-12150][SQL] Adding logical...

2015-12-16 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/10335#issuecomment-165238312 The high level structure of this look pretty good to me. Could you also post some numbers from a micro benchmark? It would be good to make sure we're actually

[GitHub] spark pull request: [SPARK-12364] [ML] [SparkR] Add ML example for...

2015-12-16 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/10324#issuecomment-165242279 LGTM, and it worked when I tested it locally. I'll go ahead and merge it with master and branch-1.6. Thanks! --- If your project is set up for it, you can

[GitHub] spark pull request: [SPARK-11904] [PySpark] reduceByKeyAndWindow d...

2015-12-16 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/9888#issuecomment-165222363 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-12220][Core]Make Utils.fetchFile suppor...

2015-12-16 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/10208#issuecomment-165222160 Okey. I just removed my last 2 commits. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-12220][Core]Make Utils.fetchFile suppor...

2015-12-16 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/10208#issuecomment-16557 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-11904] [PySpark] reduceByKeyAndWindow d...

2015-12-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9888#issuecomment-165225457 **[Test build #47848 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47848/consoleFull)** for PR 9888 at commit

[GitHub] spark pull request: [SPARK-11100][SQL] HiveThriftServer not regist...

2015-12-16 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/9113#issuecomment-165224194 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-12220][Core]Make Utils.fetchFile suppor...

2015-12-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10208#issuecomment-165227079 **[Test build #47847 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47847/consoleFull)** for PR 10208 at commit

[GitHub] spark pull request: [SPARK-10618] [Mesos] Refactoring scheduling c...

2015-12-16 Thread tnachen
Github user tnachen commented on the pull request: https://github.com/apache/spark/pull/10326#issuecomment-165229364 Don't have anything else to add besides what @dragos said, but seems like it takes a while to get this updated. I vote for trying to merge this first as this adds more

[GitHub] spark pull request: [SPARK-12365][CORE] Use ShutdownHookManager wh...

2015-12-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10325#issuecomment-165229352 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11749][Streaming] Duplicate creating th...

2015-12-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9765#issuecomment-165220327 **[Test build #47832 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47832/consoleFull)** for PR 9765 at commit

[GitHub] spark pull request: [SPARK-11749][Streaming] Duplicate creating th...

2015-12-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9765#issuecomment-165220591 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12054] [SQL] Consider nullability of ex...

2015-12-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10333#issuecomment-165224558 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12054] [SQL] Consider nullability of ex...

2015-12-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10333#issuecomment-165224493 **[Test build #47843 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47843/consoleFull)** for PR 10333 at commit

[GitHub] spark pull request: [SPARK-12220][Core]Make Utils.fetchFile suppor...

2015-12-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10208#issuecomment-165226020 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12345] [CORE] Do not send SPARK_HOME th...

2015-12-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10329#issuecomment-165226015 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-10618] [Mesos] Refactoring scheduling c...

2015-12-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10326#issuecomment-165226384 **[Test build #47850 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47850/consoleFull)** for PR 10326 at commit

[GitHub] spark pull request: [SPARK-12345][MESOS] Filter SPARK_HOME when su...

2015-12-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10332#issuecomment-165227464 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [Spark-12374][SPARK-12150][SQL] Adding logical...

2015-12-16 Thread gatorsmile
GitHub user gatorsmile opened a pull request: https://github.com/apache/spark/pull/10335 [Spark-12374][SPARK-12150][SQL] Adding logical/physical operators for Range Based on the suggestions from @marmbrus , added logical/physical operators for Range for improving the performance.

[GitHub] spark pull request: [Spark-12374][SPARK-12150][SQL] Adding logical...

2015-12-16 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/10335#discussion_r47830128 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicOperators.scala --- @@ -210,6 +210,37 @@ case class Sort(

[GitHub] spark pull request: [Spark-12374][SPARK-12150][SQL] Adding logical...

2015-12-16 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/10335#discussion_r47830108 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicOperators.scala --- @@ -210,6 +210,37 @@ case class Sort(

[GitHub] spark pull request: [Minor] Add missing interpolation in NettyRPCE...

2015-12-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10334#issuecomment-165247573 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [Minor] Add missing interpolation in NettyRPCE...

2015-12-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10334#issuecomment-165247566 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11562][SQL] Provide option to switch Sq...

2015-12-16 Thread tgravescs
Github user tgravescs commented on the pull request: https://github.com/apache/spark/pull/9553#issuecomment-165249868 The use case here is that I want to build one common spark that is used across many different clusters. Those clusters may not have Hive running yet, or perhaps I

[GitHub] spark pull request: [SPARK-12320][SQL] throw exception if the numb...

2015-12-16 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/10293#issuecomment-165249935 Okay, I'm going to merge this into master while removing the unnecessary deletion. Thanks. --- If your project is set up for it, you can reply to this email and

[GitHub] spark pull request: [SPARK-12153][MLlib]add support of arbitrary l...

2015-12-16 Thread ygcao
Github user ygcao commented on a diff in the pull request: https://github.com/apache/spark/pull/10152#discussion_r47822243 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala --- @@ -281,17 +295,28 @@ class Word2Vec extends Serializable with Logging {

  1   2   3   4   5   6   7   8   9   >