[GitHub] spark pull request: [SPARK-12409][SQL]JDBC AND operator push down

2015-12-18 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/10369#issuecomment-165716302 Can you combine and, or, in, and maybe other missing filters into a single PR? Every time I merge one the others conflict. --- If your project is set up for it, you can

[GitHub] spark pull request: [CORE][TESTS] minor fix of JavaSerializerSuite

2015-12-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/10371 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-12421][SQL] Fixed copy() method of Gene...

2015-12-18 Thread sarutak
Github user sarutak commented on the pull request: https://github.com/apache/spark/pull/10374#issuecomment-165728774 ok to test. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-7425] [ML] [WIP] spark.ml Predictor sho...

2015-12-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10355#issuecomment-165733583 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-7425] [ML] [WIP] spark.ml Predictor sho...

2015-12-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10355#issuecomment-165733582 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12400][Shuffle] Avoid generating temp s...

2015-12-18 Thread jerryshao
GitHub user jerryshao opened a pull request: https://github.com/apache/spark/pull/10376 [SPARK-12400][Shuffle] Avoid generating temp shuffle files for empty partitions This problem lies in `BypassMergeSortShuffleWriter`, empty partition will also generate a temp shuffle file with

[GitHub] spark pull request: [SPARK-12054] [SQL] Consider nullability of ex...

2015-12-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10333#issuecomment-165742356 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12054] [SQL] Consider nullability of ex...

2015-12-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10333#issuecomment-165742357 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12421][SQL] Fixed copy() method of Gene...

2015-12-18 Thread Apo1
Github user Apo1 commented on the pull request: https://github.com/apache/spark/pull/10374#issuecomment-165742336 @sarutak Do you mean the description of this pull-request? I added the link to the Jira. Ok? --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: [SPARK-12413] Fix Mesos ZK persistence

2015-12-18 Thread tnachen
Github user tnachen commented on the pull request: https://github.com/apache/spark/pull/10366#issuecomment-165742581 LGTM as well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-10427][SQL]Respect -S option for spark-...

2015-12-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8915#issuecomment-165735095 **[Test build #47992 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47992/consoleFull)** for PR 8915 at commit

[GitHub] spark pull request: [SPARK-10427][SQL]Respect -S option for spark-...

2015-12-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8915#issuecomment-165735390 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-10427][SQL]Respect -S option for spark-...

2015-12-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8915#issuecomment-165735392 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: SPARK-12417. [SQL] Orc bloom filter options ar...

2015-12-18 Thread rajeshbalamohan
GitHub user rajeshbalamohan opened a pull request: https://github.com/apache/spark/pull/10375 SPARK-12417. [SQL] Orc bloom filter options are not propagated during file … You can merge this pull request into a Git repository by running: $ git pull

[GitHub] spark pull request: [SPARK-12399] Display correct error message wh...

2015-12-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10352#issuecomment-165738049 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12218] [SQL] Invalid splitting of neste...

2015-12-18 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/10362#issuecomment-165737899 @gatorsmile Discussed with @yhuai offline, and here's my two cents: 1. Correctness The current master and 1.6 code is correct, but unfortunately

[GitHub] spark pull request: [SPARK-12399] Display correct error message wh...

2015-12-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10352#issuecomment-165737881 **[Test build #47990 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47990/consoleFull)** for PR 10352 at commit

[GitHub] spark pull request: [SPARK-12399] Display correct error message wh...

2015-12-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10352#issuecomment-165738050 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: SPARK-12417. [SQL] Orc bloom filter options ar...

2015-12-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10375#issuecomment-165738226 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-10427][SQL]Respect -S option for spark-...

2015-12-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8915#issuecomment-165739958 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-10427][SQL]Respect -S option for spark-...

2015-12-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8915#issuecomment-165739908 **[Test build #47994 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47994/consoleFull)** for PR 8915 at commit

[GitHub] spark pull request: [SPARK-12218] [SQL] Invalid splitting of neste...

2015-12-18 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/10362#issuecomment-165739980 And BTW, LGTM :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-10427][SQL]Respect -S option for spark-...

2015-12-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8915#issuecomment-165739956 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12054] [SQL] Consider nullability of ex...

2015-12-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10333#issuecomment-165742229 **[Test build #47993 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47993/consoleFull)** for PR 10333 at commit

[GitHub] spark pull request: [SPARK-10427][SQL]Respect -S option for spark-...

2015-12-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8915#issuecomment-165715613 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-10427][SQL]Respect -S option for spark-...

2015-12-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8915#issuecomment-165715568 **[Test build #47988 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47988/consoleFull)** for PR 8915 at commit

[GitHub] spark pull request: [SPARK-10427][SQL]Respect -S option for spark-...

2015-12-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8915#issuecomment-165715614 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [CORE][TESTS] minor fix of JavaSerializerSuite

2015-12-18 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/10371#issuecomment-165716175 Thanks - I've merged this in master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-12054] [SQL] Consider nullability of ex...

2015-12-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10333#issuecomment-165717428 **[Test build #47993 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47993/consoleFull)** for PR 10333 at commit

[GitHub] spark pull request: [SPARK-10427][SQL]Respect -S option for spark-...

2015-12-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8915#issuecomment-165718426 **[Test build #47994 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47994/consoleFull)** for PR 8915 at commit

[GitHub] spark pull request: [SPARK-12421][SQL] Fixed copy() method of Gene...

2015-12-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10374#issuecomment-165719708 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12421][SQL] Fixed copy() method of Gene...

2015-12-18 Thread Apo1
GitHub user Apo1 opened a pull request: https://github.com/apache/spark/pull/10374 [SPARK-12421][SQL] Fixed copy() method of GenericRow. You can merge this pull request into a Git repository by running: $ git pull https://github.com/Apo1/spark myBranch Alternatively you can

[GitHub] spark pull request: [SPARK-12054] [SQL] Consider nullability of ex...

2015-12-18 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/10333#discussion_r48007038 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrame.scala --- @@ -473,8 +472,8 @@ class DataFrame private[sql](

[GitHub] spark pull request: [SPARK-12010][SQL] Add columnMapping support

2015-12-18 Thread CK50
Github user CK50 closed the pull request at: https://github.com/apache/spark/pull/10312 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-12311][CORE] Restore previous value of ...

2015-12-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10289#issuecomment-165721057 **[Test build #47995 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47995/consoleFull)** for PR 10289 at commit

[GitHub] spark pull request: [SPARK-7425] [ML] [WIP] spark.ml Predictor sho...

2015-12-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10355#issuecomment-165720858 **[Test build #47996 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47996/consoleFull)** for PR 10355 at commit

[GitHub] spark pull request: [SPARK-4226][SQL]Add subquery (not) in/exists ...

2015-12-18 Thread roland-mendix
Github user roland-mendix commented on the pull request: https://github.com/apache/spark/pull/9055#issuecomment-165722584 We've added our own In/Exists - plus Subquery in Select - support to a partial fork of Spark SQL Catalyst (which we use in transformations from our own query

[GitHub] spark pull request: [SPARK-7425] [ML] [WIP] spark.ml Predictor sho...

2015-12-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10355#issuecomment-165726765 **[Test build #47997 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47997/consoleFull)** for PR 10355 at commit

[GitHub] spark pull request: [SPARK-12421][SQL] Fixed copy() method of Gene...

2015-12-18 Thread sarutak
Github user sarutak commented on the pull request: https://github.com/apache/spark/pull/10374#issuecomment-165729536 @Apo1 LGTM but could you make the description? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12399] Display correct error message wh...

2015-12-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10352#issuecomment-165710642 **[Test build #47990 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47990/consoleFull)** for PR 10352 at commit

[GitHub] spark pull request: [SPARK-12334][SQL][PYSPARK] Support read from ...

2015-12-18 Thread zjffdu
Github user zjffdu commented on a diff in the pull request: https://github.com/apache/spark/pull/10307#discussion_r48002910 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/OrcQuerySuite.scala --- @@ -164,6 +165,14 @@ class OrcQuerySuite extends QueryTest with

[GitHub] spark pull request: [SPARK-10427][SQL]Respect -S option for spark-...

2015-12-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8915#issuecomment-165713152 **[Test build #47992 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47992/consoleFull)** for PR 8915 at commit

[GitHub] spark pull request: [SPARK-10427][SQL]Respect -S option for spark-...

2015-12-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8915#issuecomment-165713110 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-10427][SQL]Respect -S option for spark-...

2015-12-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8915#issuecomment-165713109 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12010][SQL] Add columnMapping support

2015-12-18 Thread CK50
Github user CK50 commented on the pull request: https://github.com/apache/spark/pull/10312#issuecomment-165720594 Closing and going back to initial approach in new PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [SPARK-12335][SPARK-12336][SPARK-12341][SPARK-...

2015-12-18 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/10296#issuecomment-165720816 Closing this one since PR #10333 already covers all the nullability bugs fixed in this one. --- If your project is set up for it, you can reply to this email and

[GitHub] spark pull request: [SPARK-12335][SPARK-12336][SPARK-12341][SPARK-...

2015-12-18 Thread liancheng
Github user liancheng closed the pull request at: https://github.com/apache/spark/pull/10296 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-12413] Fix Mesos ZK persistence

2015-12-18 Thread dragos
Github user dragos commented on the pull request: https://github.com/apache/spark/pull/10366#issuecomment-165724968 LGTM. Thanks @mgummelt for catching and fixing this! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [SPARK-12345][Mesos] Properly filter out SPARK...

2015-12-18 Thread dragos
Github user dragos commented on a diff in the pull request: https://github.com/apache/spark/pull/10359#discussion_r48008374 --- Diff: core/src/main/scala/org/apache/spark/deploy/rest/mesos/MesosRestServer.scala --- @@ -99,7 +99,7 @@ private[mesos] class MesosSubmitRequestServlet(

[GitHub] spark pull request: [SPARK-7425] [ML] [WIP] spark.ml Predictor sho...

2015-12-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10355#issuecomment-165733530 **[Test build #47996 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47996/consoleFull)** for PR 10355 at commit

[GitHub] spark pull request: [SPARK-12421][SQL] Fixed copy() method of Gene...

2015-12-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10374#issuecomment-165733716 **[Test build #47998 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47998/consoleFull)** for PR 10374 at commit

[GitHub] spark pull request: [SPARK-12421][SQL] Fixed copy() method of Gene...

2015-12-18 Thread sarutak
Github user sarutak commented on the pull request: https://github.com/apache/spark/pull/10374#issuecomment-16579 OK, Thanks! Also, it's better if you add a test for change. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-12400][Shuffle] Avoid generating temp s...

2015-12-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10376#issuecomment-165744677 **[Test build #47999 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47999/consoleFull)** for PR 10376 at commit

[GitHub] spark pull request: [SPARK-7425] [ML] [WIP] spark.ml Predictor sho...

2015-12-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10355#issuecomment-165748680 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-7425] [ML] [WIP] spark.ml Predictor sho...

2015-12-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10355#issuecomment-165748572 **[Test build #47997 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47997/consoleFull)** for PR 10355 at commit

[GitHub] spark pull request: [SPARK-7425] [ML] [WIP] spark.ml Predictor sho...

2015-12-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10355#issuecomment-165748682 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12311][CORE] Restore previous value of ...

2015-12-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10289#issuecomment-165748813 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12311][CORE] Restore previous value of ...

2015-12-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10289#issuecomment-165748810 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12311][CORE] Restore previous value of ...

2015-12-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10289#issuecomment-165748707 **[Test build #47995 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47995/consoleFull)** for PR 10289 at commit

[GitHub] spark pull request: [SPARK-12421][SQL] Fixed copy() method of Gene...

2015-12-18 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/10374#discussion_r48015896 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/rows.scala --- @@ -201,7 +201,7 @@ class GenericRow(protected[sql] val

[GitHub] spark pull request: [SPARK-12218] [SQL] Invalid splitting of neste...

2015-12-18 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/10362#discussion_r48016024 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/OrcHadoopFsRelationSuite.scala --- @@ -60,4 +61,23 @@ class OrcHadoopFsRelationSuite

[GitHub] spark pull request: [SPARK-12218] [SQL] Invalid splitting of neste...

2015-12-18 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/10362#discussion_r48016016 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilterSuite.scala --- @@ -362,4 +362,23 @@ class

[GitHub] spark pull request: [SPARK-12413] Fix Mesos ZK persistence

2015-12-18 Thread sarutak
Github user sarutak commented on the pull request: https://github.com/apache/spark/pull/10366#issuecomment-165751308 LGTM. Merging into `master` and `branch-1.6`. Thanks @mgummelt ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark pull request: [SPARK-12413] Fix Mesos ZK persistence

2015-12-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/10366 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-12231][SQL]create a combineFilters' pro...

2015-12-18 Thread kevinyu98
Github user kevinyu98 commented on the pull request: https://github.com/apache/spark/pull/10299#issuecomment-165710284 The failure is because of the changed project, will submit an updated patch tomorrow. --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: [SPARK-12421][SQL] Fixed copy() method of Gene...

2015-12-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10374#issuecomment-165753253 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12421][SQL] Fixed copy() method of Gene...

2015-12-18 Thread Apo1
Github user Apo1 commented on a diff in the pull request: https://github.com/apache/spark/pull/10374#discussion_r48016931 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/rows.scala --- @@ -201,7 +201,7 @@ class GenericRow(protected[sql] val values:

[GitHub] spark pull request: [SPARK-12421][SQL] Fixed copy() method of Gene...

2015-12-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10374#issuecomment-165753256 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12218] [SQL] Invalid splitting of neste...

2015-12-18 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/10362#issuecomment-165763413 @yhuai Opened #10377 to fix the ORC issue we discussed offline (and mentioned in my last comment). To avoid merge conflicts, I copied your ORC fix to #10377. How

[GitHub] spark pull request: [SPARK-12393] [SparkR] Add read.text and write...

2015-12-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10348#issuecomment-165763432 **[Test build #48000 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48000/consoleFull)** for PR 10348 at commit

[GitHub] spark pull request: [SPARK-12218] Fixes ORC conjunction predicate ...

2015-12-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10377#issuecomment-165764622 **[Test build #48001 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48001/consoleFull)** for PR 10377 at commit

[GitHub] spark pull request: [SPARK-7727] [SQL] Avoid inner classes in Rule...

2015-12-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10174#issuecomment-165764973 **[Test build #48002 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48002/consoleFull)** for PR 10174 at commit

[GitHub] spark pull request: [SQL] Fix join type of dataframe.join doc

2015-12-18 Thread yanboliang
GitHub user yanboliang opened a pull request: https://github.com/apache/spark/pull/10378 [SQL] Fix join type of dataframe.join doc Fix mistake join type doc for dataframe.join. You can merge this pull request into a Git repository by running: $ git pull

[GitHub] spark pull request: [SPARK-12393] [SparkR] Add read.text and write...

2015-12-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10348#issuecomment-165766208 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12393] [SparkR] Add read.text and write...

2015-12-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10348#issuecomment-165766205 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12400][Shuffle] Avoid generating temp s...

2015-12-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10376#issuecomment-165766313 **[Test build #47999 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47999/consoleFull)** for PR 10376 at commit

[GitHub] spark pull request: [SQL] Fix mistake doc of join type for datafra...

2015-12-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10378#issuecomment-165766311 **[Test build #48003 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48003/consoleFull)** for PR 10378 at commit

[GitHub] spark pull request: [SPARK-12400][Shuffle] Avoid generating temp s...

2015-12-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10376#issuecomment-165766403 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12400][Shuffle] Avoid generating temp s...

2015-12-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10376#issuecomment-165766405 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12421][SQL] Fixed copy() method of Gene...

2015-12-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10374#issuecomment-165753015 **[Test build #47998 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47998/consoleFull)** for PR 10374 at commit

[GitHub] spark pull request: [SPARK-12218] Fixes ORC conjunction predicate ...

2015-12-18 Thread liancheng
GitHub user liancheng opened a pull request: https://github.com/apache/spark/pull/10377 [SPARK-12218] Fixes ORC conjunction predicate push down This PR is a follow-up of PR #10362. Two major changes: 1. The fix introduced in #10362 is OK for Parquet, but may

[GitHub] spark pull request: [SPARK-7727] [SQL] Avoid inner classes in Rule...

2015-12-18 Thread stephankessler
Github user stephankessler commented on a diff in the pull request: https://github.com/apache/spark/pull/10174#discussion_r48018543 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/DefaultOptimizerExtendableSuite.scala --- @@ -0,0 +1,45 @@ +/* + *

[GitHub] spark pull request: [SPARK-12393] [SparkR] Add read.text and write...

2015-12-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10348#issuecomment-165766132 **[Test build #48000 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48000/consoleFull)** for PR 10348 at commit

[GitHub] spark pull request: [SPARK-12421][SQL] Fixed copy() method of Gene...

2015-12-18 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/10374#discussion_r48020875 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/rows.scala --- @@ -201,7 +201,7 @@ class GenericRow(protected[sql] val

[GitHub] spark pull request: [SQL] Fix mistake doc of join type for datafra...

2015-12-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10378#issuecomment-165768918 **[Test build #48003 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48003/consoleFull)** for PR 10378 at commit

[GitHub] spark pull request: [SQL] Fix mistake doc of join type for datafra...

2015-12-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10378#issuecomment-165768996 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SQL] Fix mistake doc of join type for datafra...

2015-12-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10378#issuecomment-165768998 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-7727] [SQL] Avoid inner classes in Rule...

2015-12-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10174#issuecomment-165769694 **[Test build #48004 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48004/consoleFull)** for PR 10174 at commit

[GitHub] spark pull request: [SPARK-12218] Fixes ORC conjunction predicate ...

2015-12-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10377#issuecomment-165773766 **[Test build #48005 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48005/consoleFull)** for PR 10377 at commit

[GitHub] spark pull request: [SPARK-7727] [SQL] Avoid inner classes in Rule...

2015-12-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10174#issuecomment-165779961 **[Test build #48002 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48002/consoleFull)** for PR 10174 at commit

[GitHub] spark pull request: [SPARK-12218] Fixes ORC conjunction predicate ...

2015-12-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10377#issuecomment-165780487 **[Test build #48001 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48001/consoleFull)** for PR 10377 at commit

[GitHub] spark pull request: [SPARK-12218] Fixes ORC conjunction predicate ...

2015-12-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10377#issuecomment-165791655 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12218] [SQL] Invalid splitting of neste...

2015-12-18 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/10362#issuecomment-165804543 Thank you for the detailed explanation! @liancheng Actually, in the long term, I like the fix by @yhuai . : ) I do not like the tricky way. It took me a

[GitHub] spark pull request: [SPARK-12424][ML] The implementation of ParamM...

2015-12-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10381#issuecomment-165813374 **[Test build #48008 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48008/consoleFull)** for PR 10381 at commit

[GitHub] spark pull request: [SPARK-7425] [ML] [WIP] spark.ml Predictor sho...

2015-12-18 Thread BenFradet
Github user BenFradet commented on the pull request: https://github.com/apache/spark/pull/10355#issuecomment-165819097 I noticed [AFTSurvivalRegression](https://github.com/apache/spark/blob/master/mllib/src/main/scala/org/apache/spark/ml/regression/AFTSurvivalRegression.scala#L99)

[GitHub] spark pull request: [SPARK-7727] [SQL] Avoid inner classes in Rule...

2015-12-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10174#issuecomment-165788137 **[Test build #48004 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48004/consoleFull)** for PR 10174 at commit

[GitHub] spark pull request: [SPARK-12010][SQL] Spark JDBC requires support...

2015-12-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10380#issuecomment-165790130 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12218] [SPARK-11164] [SQL] Fixed the Pa...

2015-12-18 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/10278#issuecomment-165808370 @yhuai @liancheng Regarding this PR, should I keep it open? This PR also has another fix that can push down the filter `in`. Thanks! --- If your project is set up

[GitHub] spark pull request: [SPARK-9578] [ML] Stemmer feature transformer

2015-12-18 Thread jasonbaldridge
Github user jasonbaldridge commented on the pull request: https://github.com/apache/spark/pull/10272#issuecomment-165810877 @hhbyyh: I'm pretty slammed right now with other things, so if you'd like to go ahead and compare and choose whichever, that's totally fine with me. Thanks!

[GitHub] spark pull request: [SPARK-12330] [MESOS] Fix mesos coarse mode cl...

2015-12-18 Thread drcrallen
Github user drcrallen commented on the pull request: https://github.com/apache/spark/pull/10319#issuecomment-165814882 To clarify... That should solve the block cleanup issue. It will not solve the executor reporting incorrect status. If the executors are to exit "cleanly"

  1   2   3   4   5   >