[GitHub] spark pull request: [SPARK-6624][WIP] Draft of another alternative...

2015-12-23 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/10444#discussion_r48332590 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala --- @@ -47,6 +48,34 @@ trait Predicate extends

[GitHub] spark pull request: [SPARK-6624][WIP] Draft of another alternative...

2015-12-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10444#issuecomment-166850088 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-6624][WIP] Draft of another alternative...

2015-12-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10444#issuecomment-166850081 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-6624][WIP] Draft of another alternative...

2015-12-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10444#issuecomment-166850935 **[Test build #48236 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48236/consoleFull)** for PR 10444 at commit

[GitHub] spark pull request: [SPARK-6624][WIP] Draft of another alternative...

2015-12-23 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/10444#issuecomment-166852843 cc @nongli @rxin @marmbrus @yjshen --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-6624][SQL]Add CNF Normalization as part...

2015-12-23 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/8200#discussion_r48333880 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -464,6 +465,24 @@ object OptimizeIn extends

[GitHub] spark pull request: [Spark-10625] [SQL] Spark SQL JDBC read/write ...

2015-12-23 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/8785#issuecomment-166854056 @tribbloid let's wrap this up at last. Can you please review all the outstanding comments and address them or else close this? --- If your project is set up for it, you

[GitHub] spark pull request: Add more exceptions to Guava relocation

2015-12-23 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/10442#issuecomment-166853471 Why does this need to be added? The Guava exceptions are going away in 2.x anyway. This also doesn't follow

[GitHub] spark pull request: Add more exceptions to Guava relocation

2015-12-23 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/10442#discussion_r48333932 --- Diff: pom.xml --- @@ -99,14 +99,14 @@ sql/hive unsafe assembly -external/twitter -external/flume -

[GitHub] spark pull request: [SPARK-12317][SQL]Support configurable value i...

2015-12-23 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/10314#discussion_r48334101 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLConf.scala --- @@ -107,7 +135,7 @@ private[spark] object SQLConf { isPublic: Boolean =

[GitHub] spark pull request: [SPARK-12317][SQL]Support configurable value i...

2015-12-23 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/10314#discussion_r48334129 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLConf.scala --- @@ -100,6 +101,33 @@ private[spark] object SQLConf { } },

[GitHub] spark pull request: [SPARK-12317][SQL]Support configurable value i...

2015-12-23 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/10314#discussion_r48334144 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLConf.scala --- @@ -100,6 +101,33 @@ private[spark] object SQLConf { } },

[GitHub] spark pull request: [SPARK-12317][SQL]Support configurable value i...

2015-12-23 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/10314#discussion_r48334160 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLConf.scala --- @@ -100,6 +101,33 @@ private[spark] object SQLConf { } },

[GitHub] spark pull request: [SPARK-12317][SQL]Support configurable value i...

2015-12-23 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/10314#discussion_r48334198 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLConf.scala --- @@ -100,6 +101,33 @@ private[spark] object SQLConf { } },

[GitHub] spark pull request: [SPARK-12317][SQL]Support configurable value i...

2015-12-23 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/10314#discussion_r48334213 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLConf.scala --- @@ -100,6 +101,33 @@ private[spark] object SQLConf { } },

[GitHub] spark pull request: [SPARK-12317][SQL]Support configurable value i...

2015-12-23 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/10314#issuecomment-166855061 Are there other configs that should take a memory string? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-12311][CORE] Restore previous value of ...

2015-12-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10289#issuecomment-166856069 **[Test build #2251 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2251/consoleFull)** for PR 10289 at commit

[GitHub] spark pull request: [SPARK-6624][WIP] Draft of another alternative...

2015-12-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10444#issuecomment-166867696 **[Test build #48236 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48236/consoleFull)** for PR 10444 at commit

[GitHub] spark pull request: [SPARK-6624][WIP] Draft of another alternative...

2015-12-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10444#issuecomment-166868044 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-6624][WIP] Draft of another alternative...

2015-12-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10444#issuecomment-166868043 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12498][SQL][MINOR] BooleanSimplication ...

2015-12-23 Thread liancheng
GitHub user liancheng opened a pull request: https://github.com/apache/spark/pull/10445 [SPARK-12498][SQL][MINOR] BooleanSimplication simplification Scala syntax and existing Catalyst expression DSL allows us to refactor the `BooleanSimplification` optimization rule to a clearer

[GitHub] spark pull request: [SPARK-12439][SQL] Fix toCatalystArray and Map...

2015-12-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10391#issuecomment-166869105 **[Test build #48232 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48232/consoleFull)** for PR 10391 at commit

[GitHub] spark pull request: [SPARK-12439][SQL] Fix toCatalystArray and Map...

2015-12-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10391#issuecomment-166869266 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12439][SQL] Fix toCatalystArray and Map...

2015-12-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10391#issuecomment-166869262 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12498][SQL][MINOR] BooleanSimplication ...

2015-12-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10445#issuecomment-166870629 **[Test build #48237 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48237/consoleFull)** for PR 10445 at commit

[GitHub] spark pull request: [SPARK-6624][WIP] Draft of another alternative...

2015-12-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10444#issuecomment-166870843 **[Test build #48238 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48238/consoleFull)** for PR 10444 at commit

[GitHub] spark pull request: [SPARK-12311][CORE] Restore previous value of ...

2015-12-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10289#issuecomment-166878686 **[Test build #2251 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2251/consoleFull)** for PR 10289 at commit

[GitHub] spark pull request: [SPARK-12439][SQL] Fix toCatalystArray and Map...

2015-12-23 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/10391#issuecomment-166879266 retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-12495][SQL] use true as default value f...

2015-12-23 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/10443#discussion_r48346325 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects.scala --- @@ -241,7 +241,7 @@ case class NewInstance(

[GitHub] spark pull request: [SPARK-12439][SQL] Fix toCatalystArray and Map...

2015-12-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10391#issuecomment-166924872 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12439][SQL] Fix toCatalystArray and Map...

2015-12-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10391#issuecomment-166924875 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12499] [build] don't force MAVEN_OPTS

2015-12-23 Thread abridgett
GitHub user abridgett opened a pull request: https://github.com/apache/spark/pull/10448 [SPARK-12499] [build] don't force MAVEN_OPTS allow the user to override MAVEN_OPTS (2GB wasn't sufficient for me) You can merge this pull request into a Git repository by running: $ git

[GitHub] spark pull request: [SPARK-12495][SQL] use true as default value f...

2015-12-23 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/10443#discussion_r48344118 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects.scala --- @@ -231,7 +231,7 @@ case class NewInstance(

[GitHub] spark pull request: [SPARK-12495][SQL] use true as default value f...

2015-12-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10443#issuecomment-166916883 **[Test build #48242 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48242/consoleFull)** for PR 10443 at commit

[GitHub] spark pull request: [SPARK-12340][SQL] Fix overstep the bounds of ...

2015-12-23 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/10310#issuecomment-166918642 @QiangCai thanks that looks good, but this needs a rebase now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-12481] [CORE] [STREAMING] [SQL] Remove ...

2015-12-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10446#issuecomment-166923370 **[Test build #48243 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48243/consoleFull)** for PR 10446 at commit

[GitHub] spark pull request: [SPARK-12500] [CORE] Fix Tachyon deprecations;...

2015-12-23 Thread srowen
GitHub user srowen opened a pull request: https://github.com/apache/spark/pull/10449 [SPARK-12500] [CORE] Fix Tachyon deprecations; pull Tachyon dependency into one class Fix Tachyon deprecations; pull Tachyon dependency into `TachyonBlockManager` only CC @calvinjia as I

[GitHub] spark pull request: [SPARK-12439][SQL] Fix toCatalystArray and Map...

2015-12-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10391#issuecomment-166899721 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12439][SQL] Fix toCatalystArray and Map...

2015-12-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10391#issuecomment-166899666 **[Test build #48239 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48239/consoleFull)** for PR 10391 at commit

[GitHub] spark pull request: [SPARK-12439][SQL] Fix toCatalystArray and Map...

2015-12-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10391#issuecomment-166899720 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12480][SQL] add Hash expression that ca...

2015-12-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10435#issuecomment-166901054 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12480][SQL] add Hash expression that ca...

2015-12-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10435#issuecomment-166901014 **[Test build #48241 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48241/consoleFull)** for PR 10435 at commit

[GitHub] spark pull request: [SPARK-12498][SQL][MINOR] BooleanSimplication ...

2015-12-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10445#issuecomment-166891869 **[Test build #48237 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48237/consoleFull)** for PR 10445 at commit

[GitHub] spark pull request: [SPARK-6624][WIP] Draft of another alternative...

2015-12-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10444#issuecomment-166891798 **[Test build #48238 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48238/consoleFull)** for PR 10444 at commit

[GitHub] spark pull request: [SPARK-12495][SQL] use true as default value f...

2015-12-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10443#issuecomment-166896497 **[Test build #48242 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48242/consoleFull)** for PR 10443 at commit

[GitHub] spark pull request: [SPARK-12340][SQL] Fix overstep the bounds of ...

2015-12-23 Thread QiangCai
Github user QiangCai commented on the pull request: https://github.com/apache/spark/pull/10310#issuecomment-166912120 @srowen I have modified all the code, and try to keep them to be the same. At first, the var numPartsToTry and partsScanned have been set to Long.

[GitHub] spark pull request: [SPARK-12439][SQL] Fix toCatalystArray and Map...

2015-12-23 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/10391#issuecomment-166925236 retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-12499] [build] don't force MAVEN_OPTS

2015-12-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10448#issuecomment-166931510 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12498][SQL][MINOR] BooleanSimplication ...

2015-12-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10445#issuecomment-166891943 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-6624][WIP] Draft of another alternative...

2015-12-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10444#issuecomment-166891882 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12498][SQL][MINOR] BooleanSimplication ...

2015-12-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10445#issuecomment-166891946 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-6624][WIP] Draft of another alternative...

2015-12-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10444#issuecomment-166891883 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12495][SQL] use true as default value f...

2015-12-23 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/10443#discussion_r48346034 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects.scala --- @@ -231,7 +231,7 @@ case class NewInstance(

[GitHub] spark pull request: [SPARK-12495][SQL] use true as default value f...

2015-12-23 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/10443#discussion_r48350913 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects.scala --- @@ -241,7 +241,7 @@ case class NewInstance(

[GitHub] spark pull request: [SPARK-12331][ML] R^2 for regression through t...

2015-12-23 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/10384#discussion_r48355484 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/evaluation/RegressionMetrics.scala --- @@ -23,15 +23,23 @@ import org.apache.spark.Logging import

[GitHub] spark pull request: [SPARK-12500] [CORE] Fix Tachyon deprecations;...

2015-12-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10449#issuecomment-166934193 **[Test build #48247 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48247/consoleFull)** for PR 10449 at commit

[GitHub] spark pull request: [SPARK-12480][SQL] add Hash expression that ca...

2015-12-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10435#issuecomment-166901052 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12495][SQL] use true as default value f...

2015-12-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10443#issuecomment-166917017 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12495][SQL] use true as default value f...

2015-12-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10443#issuecomment-166917016 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12439][SQL] Fix toCatalystArray and Map...

2015-12-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10391#issuecomment-166926556 **[Test build #48245 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48245/consoleFull)** for PR 10391 at commit

[GitHub] spark pull request: [SPARK-12439][SQL] Fix toCatalystArray and Map...

2015-12-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10391#issuecomment-166928166 **[Test build #48246 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48246/consoleFull)** for PR 10391 at commit

[GitHub] spark pull request: [SPARK-12439][SQL] Fix toCatalystArray and Map...

2015-12-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10391#issuecomment-166948106 **[Test build #48246 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48246/consoleFull)** for PR 10391 at commit

[GitHub] spark pull request: [SPARK-7889] [CORE] HistoryServer to refresh c...

2015-12-23 Thread steveloughran
Github user steveloughran commented on a diff in the pull request: https://github.com/apache/spark/pull/6935#discussion_r48363721 --- Diff: core/src/main/scala/org/apache/spark/deploy/history/ApplicationCache.scala --- @@ -0,0 +1,658 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-7889] [CORE] HistoryServer to refresh c...

2015-12-23 Thread steveloughran
Github user steveloughran commented on a diff in the pull request: https://github.com/apache/spark/pull/6935#discussion_r48364543 --- Diff: core/src/test/scala/org/apache/spark/deploy/history/ApplicationCacheSuite.scala --- @@ -0,0 +1,476 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-12500] [CORE] Fix Tachyon deprecations;...

2015-12-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10449#issuecomment-166957539 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-7889] [CORE] HistoryServer to refresh c...

2015-12-23 Thread steveloughran
Github user steveloughran commented on a diff in the pull request: https://github.com/apache/spark/pull/6935#discussion_r48367142 --- Diff: docs/monitoring.md --- @@ -69,36 +83,53 @@ follows: +### Spark configuration options + Property

[GitHub] spark pull request: [SPARK-7889] [CORE] HistoryServer to refresh c...

2015-12-23 Thread steveloughran
Github user steveloughran commented on a diff in the pull request: https://github.com/apache/spark/pull/6935#discussion_r48368082 --- Diff: docs/monitoring.md --- @@ -69,36 +83,53 @@ follows: +### Spark configuration options + Property

[GitHub] spark pull request: [SPARK-10838][SPARK-11576][SQL] Incorrect resu...

2015-12-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10450#issuecomment-166950936 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-7889] [CORE] HistoryServer to refresh c...

2015-12-23 Thread steveloughran
Github user steveloughran commented on a diff in the pull request: https://github.com/apache/spark/pull/6935#discussion_r48364727 --- Diff: core/src/test/scala/org/apache/spark/deploy/history/ApplicationCacheSuite.scala --- @@ -0,0 +1,476 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-7889] [CORE] HistoryServer to refresh c...

2015-12-23 Thread steveloughran
Github user steveloughran commented on a diff in the pull request: https://github.com/apache/spark/pull/6935#discussion_r48364720 --- Diff: core/src/test/scala/org/apache/spark/deploy/history/ApplicationCacheSuite.scala --- @@ -0,0 +1,476 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-12481] [CORE] [STREAMING] [SQL] Remove ...

2015-12-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10446#issuecomment-166960152 **[Test build #2253 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2253/consoleFull)** for PR 10446 at commit

[GitHub] spark pull request: [SPARK-12503] [SQL] Pushing Limit Through Unio...

2015-12-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10451#issuecomment-166963932 **[Test build #48248 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48248/consoleFull)** for PR 10451 at commit

[GitHub] spark pull request: [SPARK-12486] Worker should kill the executors...

2015-12-23 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/10438#issuecomment-166969653 Looks good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-12396][Core] Modify the function schedu...

2015-12-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10447#issuecomment-166969718 **[Test build #48249 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48249/consoleFull)** for PR 10447 at commit

[GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...

2015-12-23 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/10368#discussion_r48372722 --- Diff: core/src/test/scala/org/apache/spark/serializer/KryoSerializerSuite.scala --- @@ -154,6 +155,19 @@ class KryoSerializerSuite extends SparkFunSuite

[GitHub] spark pull request: [SPARK-12481] [CORE] [STREAMING] [SQL] Remove ...

2015-12-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10446#issuecomment-166947653 **[Test build #48243 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48243/consoleFull)** for PR 10446 at commit

[GitHub] spark pull request: [SPARK-12481] [CORE] [STREAMING] [SQL] Remove ...

2015-12-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10446#issuecomment-166947721 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12481] [CORE] [STREAMING] [SQL] Remove ...

2015-12-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10446#issuecomment-166947723 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-7889] [CORE] HistoryServer to refresh c...

2015-12-23 Thread steveloughran
Github user steveloughran commented on a diff in the pull request: https://github.com/apache/spark/pull/6935#discussion_r48364439 --- Diff: core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala --- @@ -430,8 +517,55 @@ private[history] class

[GitHub] spark pull request: [SPARK-7889] [CORE] HistoryServer to refresh c...

2015-12-23 Thread steveloughran
Github user steveloughran commented on a diff in the pull request: https://github.com/apache/spark/pull/6935#discussion_r48364502 --- Diff: core/src/test/scala/org/apache/spark/deploy/history/ApplicationCacheSuite.scala --- @@ -0,0 +1,476 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-7889] [CORE] HistoryServer to refresh c...

2015-12-23 Thread steveloughran
Github user steveloughran commented on a diff in the pull request: https://github.com/apache/spark/pull/6935#discussion_r48366527 --- Diff: core/src/test/scala/org/apache/spark/deploy/history/HistoryServerSuite.scala --- @@ -21,15 +21,28 @@ import java.net.{HttpURLConnection, URL}

[GitHub] spark pull request: [SPARK-7889] [CORE] HistoryServer to refresh c...

2015-12-23 Thread steveloughran
Github user steveloughran commented on a diff in the pull request: https://github.com/apache/spark/pull/6935#discussion_r48366891 --- Diff: core/src/test/scala/org/apache/spark/deploy/history/HistoryServerSuite.scala --- @@ -281,6 +296,191 @@ class HistoryServerSuite extends

[GitHub] spark pull request: [SPARK-12396][Core] Modify the function schedu...

2015-12-23 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/10447#issuecomment-166967310 add to whitelist --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-12396][Core] Modify the function schedu...

2015-12-23 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/10447#issuecomment-166970244 Changes LGTM. I'll merge this once tests pass --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...

2015-12-23 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/10368#discussion_r48371027 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskResult.scala --- @@ -46,6 +46,26 @@ class DirectTaskResult[T](var valueBytes: ByteBuffer,

[GitHub] spark pull request: [SPARK-7889] [CORE] HistoryServer to refresh c...

2015-12-23 Thread steveloughran
Github user steveloughran commented on a diff in the pull request: https://github.com/apache/spark/pull/6935#discussion_r48363399 --- Diff: core/src/main/scala/org/apache/spark/deploy/history/ApplicationCache.scala --- @@ -0,0 +1,658 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-7889] [CORE] HistoryServer to refresh c...

2015-12-23 Thread steveloughran
Github user steveloughran commented on a diff in the pull request: https://github.com/apache/spark/pull/6935#discussion_r48364066 --- Diff: core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala --- @@ -430,8 +517,55 @@ private[history] class

[GitHub] spark pull request: [SPARK-12421][SQL] Fixed copy() method of Gene...

2015-12-23 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/10374#issuecomment-166949939 I would prefer to change the implementation of toSeq. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark pull request: [SPARK-7889] [CORE] HistoryServer to refresh c...

2015-12-23 Thread steveloughran
Github user steveloughran commented on a diff in the pull request: https://github.com/apache/spark/pull/6935#discussion_r48366085 --- Diff: core/src/test/scala/org/apache/spark/deploy/history/ApplicationCacheSuite.scala --- @@ -0,0 +1,476 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-7889] [CORE] HistoryServer to refresh c...

2015-12-23 Thread steveloughran
Github user steveloughran commented on a diff in the pull request: https://github.com/apache/spark/pull/6935#discussion_r48366097 --- Diff: core/src/test/scala/org/apache/spark/deploy/history/ApplicationCacheSuite.scala --- @@ -0,0 +1,476 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-12499] [build] don't force MAVEN_OPTS

2015-12-23 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/10448#issuecomment-166958625 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...

2015-12-23 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/10368#discussion_r48370672 --- Diff: core/src/main/scala/org/apache/spark/executor/TaskMetrics.scala --- @@ -215,6 +215,19 @@ class TaskMetrics extends Serializable {

[GitHub] spark pull request: [SPARK-12504][SQL] Masking credentials in the ...

2015-12-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10452#issuecomment-166970399 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...

2015-12-23 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/10368#discussion_r48372093 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskResult.scala --- @@ -46,6 +46,26 @@ class DirectTaskResult[T](var valueBytes: ByteBuffer, var

[GitHub] spark pull request: [SPARK-12439][SQL] Fix toCatalystArray and Map...

2015-12-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10391#issuecomment-166946807 **[Test build #48245 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48245/consoleFull)** for PR 10391 at commit

[GitHub] spark pull request: [SPARK-12439][SQL] Fix toCatalystArray and Map...

2015-12-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10391#issuecomment-166946901 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12439][SQL] Fix toCatalystArray and Map...

2015-12-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10391#issuecomment-166948261 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12439][SQL] Fix toCatalystArray and Map...

2015-12-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10391#issuecomment-166948262 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-10838][SPARK-11576][SQL] Incorrect resu...

2015-12-23 Thread yzhou2001
Github user yzhou2001 commented on the pull request: https://github.com/apache/spark/pull/10450#issuecomment-166974291 This change is actually very close to https://github.com/apache/spark/pull/9548. Sorry I did not look at the code changes carefully there, except for the detailed

[GitHub] spark pull request: [SPARK-10838][SPARK-11576][SQL] Incorrect resu...

2015-12-23 Thread yzhou2001
Github user yzhou2001 closed the pull request at: https://github.com/apache/spark/pull/10450 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

  1   2   3   4   5   >