Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/10368#discussion_r48370672
--- Diff: core/src/main/scala/org/apache/spark/executor/TaskMetrics.scala
---
@@ -215,6 +215,19 @@ class TaskMetrics extends Serializable {
inputMetrics.foreach(_.updateBytesRead())
}
+ override def equals(other: Any): Boolean = other match {
+ case that: TaskMetrics => {
+ if (this.executorDeserializeTime != that.executorDeserializeTime)
return false
+ if (this.executorRunTime != that.executorRunTime) return false
+ if (this.resultSize != that.resultSize) return false
+ if (this.jvmGCTime != that.jvmGCTime) return false
+ if (this.resultSerializationTime != that.resultSerializationTime)
return false
+ if (this.hostname == null && that.hostname != null) return false
+ if (this.hostname != null) this.hostname.equals(that.hostname) else
true
+ }
--- End diff --
it would be better if this looked like:
```
this.executorDeserializeTime == that.executorDeserializeTime &&
this.executorRunTime == that.executorRunTime &&
...
this.hostname == that.hostname
```
no need to check `equals` here because we're in scala
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
