[GitHub] spark pull request: [SPARK-12330] [MESOS] Fix mesos coarse mode cl...

2016-02-01 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/10319#discussion_r51470346 --- Diff: docs/running-on-mesos.md --- @@ -387,6 +387,13 @@ See the [configuration page](configuration.html) for information on Spark config

[GitHub] spark pull request: [SPARK-12330] [MESOS] Fix mesos coarse mode cl...

2016-02-01 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/10319#discussion_r51470296 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/CoarseMesosSchedulerBackend.scala --- @@ -60,6 +62,12 @@ private[spark] class

[GitHub] spark pull request: [SPARK-10605][SQL] Add structs to collect_list...

2016-02-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11004#issuecomment-178169233 **[Test build #50493 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50493/consoleFull)** for PR 11004 at commit

[GitHub] spark pull request: [SPARK-12798] [SQL] generated BroadcastHashJoi...

2016-02-01 Thread nongli
Github user nongli commented on the pull request: https://github.com/apache/spark/pull/10989#issuecomment-178179456 Can you include the generated code? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-12463][SPARK-12464][SPARK-12465][SPARK-...

2016-02-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/10057 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-10820][SQL] Support for the continuous ...

2016-02-01 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/11006#discussion_r51481347 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamProgress.scala --- @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-10820][SQL] Support for the continuous ...

2016-02-01 Thread marmbrus
GitHub user marmbrus opened a pull request: https://github.com/apache/spark/pull/11006 [SPARK-10820][SQL] Support for the continuous execution of structured queries This is a follow up to 9aadcffabd226557174f3ff566927f873c71672e that extends Spark SQL to allow users to

[GitHub] spark pull request: [SPARK-12798] [SQL] generated BroadcastHashJoi...

2016-02-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10989#issuecomment-178133344 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-7889] [CORE] HistoryServer to refresh c...

2016-02-01 Thread squito
Github user squito commented on the pull request: https://github.com/apache/spark/pull/6935#issuecomment-178139026 jenkins, add to whitelist --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-12705] [SPARK-10777] [SQL] Analyzer Rul...

2016-02-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/10678 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-10820][SQL] Support for the continuous ...

2016-02-01 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/11006#discussion_r51480080 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamProgress.scala --- @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-12798] [SQL] generated BroadcastHashJoi...

2016-02-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10989#issuecomment-178188600 **[Test build #2486 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2486/consoleFull)** for PR 10989 at commit

[GitHub] spark pull request: [SPARK-10749][MESOS] Support multiple roles wi...

2016-02-01 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/8872#discussion_r51481128 --- Diff: core/src/test/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterSchedulerSuite.scala --- @@ -0,0 +1,139 @@ +/* --- End diff --

[GitHub] spark pull request: [SPARK-12957][SQL] Initial support for constra...

2016-02-01 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/10844#discussion_r51482277 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicOperators.scala --- @@ -180,6 +221,46 @@ case class Join(

[GitHub] spark pull request: [SPARK-10820][SQL] Support for the continuous ...

2016-02-01 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/11006#discussion_r51483011 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/StreamTest.scala --- @@ -0,0 +1,346 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request: [SPARK-12506][SPARK-12126][SQL]use CatalystSca...

2016-02-01 Thread huaxingao
GitHub user huaxingao opened a pull request: https://github.com/apache/spark/pull/11005 [SPARK-12506][SPARK-12126][SQL]use CatalystScan for JDBCRelation As suggested

[GitHub] spark pull request: [SPARK-6847][Core][Streaming]Fix stack overflo...

2016-02-01 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/10934#issuecomment-178132065 I did not merge this into 1.6 or before because of 2 reasons: - It doesn't merge cleanly, and more importantly - This changes internal semantics and it's not

[GitHub] spark pull request: [Spark-12732][ML] bug fix in linear regression...

2016-02-01 Thread iyounus
Github user iyounus commented on the pull request: https://github.com/apache/spark/pull/10702#issuecomment-178134675 For the case (3), I'm assuming that the label and features are not standardized. So, in that case, the solution exists. Here is my perspective on this. The

[GitHub] spark pull request: [SPARK-12989] [SQL] Delaying Alias Cleanup aft...

2016-02-01 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/10963#issuecomment-178139377 Thanks, merging to master and 1.6. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-10820][SQL] Support for the continuous ...

2016-02-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11006#issuecomment-178146931 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12330] [MESOS] Fix mesos coarse mode cl...

2016-02-01 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/10319#discussion_r51470974 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/CoarseMesosSchedulerBackend.scala --- @@ -364,7 +379,27 @@ private[spark] class

[GitHub] spark pull request: [SPARK-12330] [MESOS] Fix mesos coarse mode cl...

2016-02-01 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/10319#discussion_r51470918 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/CoarseMesosSchedulerBackend.scala --- @@ -364,7 +379,27 @@ private[spark] class

[GitHub] spark pull request: [SPARK-12790][CORE] Remove HistoryServer old m...

2016-02-01 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/10860#discussion_r51472337 --- Diff: core/src/test/resources/spark-events/local-1425081759268/EVENT_LOG_1 --- @@ -0,0 +1,88 @@ +{"Event":"SparkListenerBlockManagerAdded","Block

[GitHub] spark pull request: [SPARK-12790][CORE] Remove HistoryServer old m...

2016-02-01 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/spark/pull/10860#issuecomment-178166829 sure - that was just to make sure it doesn't get picked up, as a negative test. I can purge all of that since it seems both you and @vanzin have the same feedback?

[GitHub] spark pull request: [SPARK-12951] [SQL] support spilling in genera...

2016-02-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10998#issuecomment-178166922 **[Test build #50494 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50494/consoleFull)** for PR 10998 at commit

[GitHub] spark pull request: [SPARK-10820][SQL] Support for the continuous ...

2016-02-01 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/11006#discussion_r51476814 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala --- @@ -0,0 +1,213 @@ +/* + * Licensed to the

[GitHub] spark pull request: [SPARK-10820][SQL] Support for the continuous ...

2016-02-01 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/11006#discussion_r51476822 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala --- @@ -0,0 +1,213 @@ +/* + * Licensed to the

[GitHub] spark pull request: [SPARK-10820][SQL] Support for the continuous ...

2016-02-01 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/11006#discussion_r51476807 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala --- @@ -0,0 +1,213 @@ +/* + * Licensed to the

[GitHub] spark pull request: [SPARK-10820][SQL] Support for the continuous ...

2016-02-01 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/11006#discussion_r51480355 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamProgress.scala --- @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-12832][MESOS] mesos scheduler respect a...

2016-02-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10949#issuecomment-178189170 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12832][MESOS] mesos scheduler respect a...

2016-02-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10949#issuecomment-178189155 **[Test build #50500 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50500/consoleFull)** for PR 10949 at commit

[GitHub] spark pull request: [test-maven] Shade protobuf-java

2016-02-01 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/10995#issuecomment-178197729 Since Hadoop doesn't shade `protobuf`, I think this won't fix the issue in the PR description. Right? --- If your project is set up for it, you can reply to this

[GitHub] spark pull request: [SPARK-12957][SQL] Initial support for constra...

2016-02-01 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/10844#discussion_r51482050 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicOperators.scala --- @@ -89,9 +89,27 @@ case class Generate(

[GitHub] spark pull request: [SPARK-12957][SQL] Initial support for constra...

2016-02-01 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/10844#discussion_r51482081 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicOperators.scala --- @@ -180,6 +221,46 @@ case class Join(

[GitHub] spark pull request: [SPARK-12265][Mesos] Spark calls System.exit i...

2016-02-01 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/10921#issuecomment-178204415 LGTM merging into master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-12951] [SQL] support spilling in genera...

2016-02-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10998#issuecomment-178128143 **[Test build #50494 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50494/consoleFull)** for PR 10998 at commit

[GitHub] spark pull request: [SPARK-6166] Limit number of concurrent outbou...

2016-02-01 Thread mridulm
Github user mridulm commented on the pull request: https://github.com/apache/spark/pull/10838#issuecomment-178141964 @zsxwing Other than the PR title - I think everything else says inflight in code/documentation. Did you see anything to the contrary ? --- If your project is set up

[GitHub] spark pull request: [SPARK-10820][SQL] Support for the continuous ...

2016-02-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11006#issuecomment-178143411 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-10820][SQL] Support for the continuous ...

2016-02-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11006#issuecomment-178143406 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-5095] [Mesos] Support launching multipl...

2016-02-01 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/10993#issuecomment-178151143 Looks like this is failing real tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12705] [SPARK-10777] [SQL] Analyzer Rul...

2016-02-01 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/10678#issuecomment-178161088 LGTM, thanks for adding a bunch of tests! Merging to master. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: [SPARK-12330] [MESOS] Fix mesos coarse mode cl...

2016-02-01 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/10319#discussion_r51471308 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/CoarseMesosSchedulerBackend.scala --- @@ -364,7 +379,27 @@ private[spark] class

[GitHub] spark pull request: [SPARK-11780][SQL] Add catalyst type aliases b...

2016-02-01 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/10915#issuecomment-178167383 Thanks, merged to branch-1.6. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-12951] [SQL] support spilling in genera...

2016-02-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10998#issuecomment-178167285 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12951] [SQL] support spilling in genera...

2016-02-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10998#issuecomment-178167283 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12951] [SQL] support spilling in genera...

2016-02-01 Thread nongli
Github user nongli commented on the pull request: https://github.com/apache/spark/pull/10998#issuecomment-178169324 Can you include the generated code? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-12790][CORE] Remove HistoryServer old m...

2016-02-01 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/10860#issuecomment-178169396 I see, that seems unnecessary. We deleted all the code path that would parse the format so it's pretty much impossible for it to be picked up right? --- If your

[GitHub] spark pull request: [SPARK-12299][CORE][WIP] Remove history servin...

2016-02-01 Thread BryanCutler
Github user BryanCutler commented on the pull request: https://github.com/apache/spark/pull/10991#issuecomment-178169443 cc @andrewor14, @squito for thoughts on above --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [SPARK-10605][SQL] Add structs to collect_list...

2016-02-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11004#issuecomment-178169641 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-10605][SQL] Add structs to collect_list...

2016-02-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11004#issuecomment-178169642 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [ML][MINOR] Invalid MulticlassClassification r...

2016-02-01 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/10996#issuecomment-178169426 LGTM. Merged into master. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-5095] [Mesos] Support launching multipl...

2016-02-01 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/10993#issuecomment-178173549 Also, follow-up question: have you tested this with cluster mode and/or with dynamic allocation? --- If your project is set up for it, you can reply to this email

[GitHub] spark pull request: [SPARK-12832][MESOS] mesos scheduler respect a...

2016-02-01 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/10949#issuecomment-178178205 By the way, I'd just like to point out that there is another patch that fixes the same issue #10768. @tnachen @dragos what's the difference and which one should we

[GitHub] spark pull request: [SPARK-12832][CORE] Fix dispatcher does not ha...

2016-02-01 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/10768#issuecomment-178178342 FYI #10949 is another patch for the same issue. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [SPARK-12265][Mesos] Spark calls System.exit i...

2016-02-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/10921 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-12992][SQL]: Update parquet reader to s...

2016-02-01 Thread nongli
Github user nongli commented on a diff in the pull request: https://github.com/apache/spark/pull/10908#discussion_r51462281 --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/VectorizedRleValuesReader.java --- @@ -180,6 +188,152 @@ public void

[GitHub] spark pull request: [SPARK-12992][SQL]: Update parquet reader to s...

2016-02-01 Thread nongli
Github user nongli commented on a diff in the pull request: https://github.com/apache/spark/pull/10908#discussion_r51462376 --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/VectorizedPlainValuesReader.java --- @@ -52,15 +55,49 @@ public void

[GitHub] spark pull request: [SPARK-6166] Limit number of concurrent outbou...

2016-02-01 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/10838#issuecomment-178129985 @tgravescs in general, this patch doesn't limit number of concurrent outbound connections. Instead, it just limits number of in flight blocks. Could you update the

[GitHub] spark pull request: [SPARK-10820][SQL] Support for the continuous ...

2016-02-01 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/11006#issuecomment-178144361 test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-12478][SQL] Bugfix: Dataset fields of p...

2016-02-01 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/10431#issuecomment-178158109 Yeah, since its labeled experimental, I'd like to fix as many Dataset bugs as we can for 1.6.1. --- If your project is set up for it, you can reply to this email and

[GitHub] spark pull request: [SPARK-12798] [SQL] generated BroadcastHashJoi...

2016-02-01 Thread nongli
Github user nongli commented on a diff in the pull request: https://github.com/apache/spark/pull/10989#discussion_r51477107 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/BufferedRowIterator.java --- @@ -54,13 +54,27 @@ public void setInput(Iterator iter) {

[GitHub] spark pull request: [SPARK-12832][MESOS] mesos scheduler respect a...

2016-02-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10949#issuecomment-178189166 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-10820][SQL] Support for the continuous ...

2016-02-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11006#issuecomment-178191589 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-10749][MESOS] Support multiple roles wi...

2016-02-01 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/8872#discussion_r51481006 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterScheduler.scala --- @@ -525,14 +531,14 @@ private[spark] class

[GitHub] spark pull request: [SPARK-10820][SQL] Support for the continuous ...

2016-02-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11006#issuecomment-178191582 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12957][SQL] Initial support for constra...

2016-02-01 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/10844#discussion_r51482488 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/plans/ConstraintPropagationSuite.scala --- @@ -0,0 +1,138 @@ +/* + * Licensed

[GitHub] spark pull request: [SPARK-6847][Core][Streaming]Fix stack overflo...

2016-02-01 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/10934#discussion_r51463360 --- Diff: streaming/src/test/scala/org/apache/spark/streaming/CheckpointSuite.scala --- @@ -821,6 +821,75 @@ class CheckpointSuite extends TestSuiteBase

[GitHub] spark pull request: [SPARK-6847][Core][Streaming]Fix stack overflo...

2016-02-01 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/10934#issuecomment-178130645 Merged into master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-12798] [SQL] generated BroadcastHashJoi...

2016-02-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10989#issuecomment-178133351 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12989] [SQL] Delaying Alias Cleanup aft...

2016-02-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/10963 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-10820][SQL] Support for the continuous ...

2016-02-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11006#issuecomment-178151805 **[Test build #50498 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50498/consoleFull)** for PR 11006 at commit

[GitHub] spark pull request: [Docs] Fix the jar location of datanucleus in ...

2016-02-01 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/10901#issuecomment-178163321 Merging to master and 1.6 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-12790][CORE] Remove HistoryServer old m...

2016-02-01 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/spark/pull/10860#issuecomment-178159771 Could we merge this please? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [Docs] Fix the jar location of datanucleus in ...

2016-02-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/10901 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-11780][SQL] Add catalyst type aliases b...

2016-02-01 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/10915#issuecomment-178172474 Can you close this PR now? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-12832][MESOS] mesos scheduler respect a...

2016-02-01 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/10949#issuecomment-178177036 Also cc @tnachen who wrote this code originally. From the JIRA: > CoarseMesosSchedulerBackend have constraints feature but dispacher deploy use

[GitHub] spark pull request: [SPARK-10749][MESOS] Support multiple roles wi...

2016-02-01 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/8872#discussion_r51480776 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterScheduler.scala --- @@ -497,28 +505,28 @@ private[spark] class

[GitHub] spark pull request: java mapwithstate, broken java mapping

2016-02-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11007#issuecomment-178190454 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12506][SPARK-12126][SQL]use CatalystSca...

2016-02-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11005#issuecomment-178126949 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-7889] [CORE] HistoryServer to refresh c...

2016-02-01 Thread squito
Github user squito commented on the pull request: https://github.com/apache/spark/pull/6935#issuecomment-178142661 hi @steveloughran sorry for another really long delay on my end. mostly this looks fine, there are some style nits and a couple of comments that need updating. I also

[GitHub] spark pull request: [SPARK-10820][SQL] Support for the continuous ...

2016-02-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11006#issuecomment-178146926 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-6166] Limit number of concurrent outbou...

2016-02-01 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/10838#issuecomment-178153656 Hm, I think `block` is also not `accurate`. Never mind, just update the title should be enough. --- If your project is set up for it, you can reply to this email and

[GitHub] spark pull request: [SPARK-13113][Core] Remove unnecessary bit ope...

2016-02-01 Thread holdenk
Github user holdenk commented on the pull request: https://github.com/apache/spark/pull/11002#issuecomment-178160294 This change looks good to me, maybe @JoshRosen who was the last to touch that line can take a look? --- If your project is set up for it, you can reply to this email

[GitHub] spark pull request: [SPARK-12992][SQL]: Update parquet reader to s...

2016-02-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10908#issuecomment-178168455 **[Test build #50499 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50499/consoleFull)** for PR 10908 at commit

[GitHub] spark pull request: [ML][MINOR] Invalid MulticlassClassification r...

2016-02-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/10996 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-12832][MESOS] mesos scheduler respect a...

2016-02-01 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/10949#issuecomment-178174598 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-12992][SQL]: Update parquet reader to s...

2016-02-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10908#issuecomment-178179904 **[Test build #50499 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50499/consoleFull)** for PR 10908 at commit

[GitHub] spark pull request: [SPARK-10749][MESOS] Support multiple roles wi...

2016-02-01 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/8872#discussion_r51480535 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterScheduler.scala --- @@ -456,34 +460,36 @@ private[spark] class

[GitHub] spark pull request: java mapwithstate, broken java mapping

2016-02-01 Thread gabrielenizzoli
GitHub user gabrielenizzoli opened a pull request: https://github.com/apache/spark/pull/11007 java mapwithstate, broken java mapping java mapwithstate with Function3 has wrong conversion of java Optional to scala Option, now code uses same conversion used in the mapwithstate call

[GitHub] spark pull request: [SPARK-12798] [SQL] generated BroadcastHashJoi...

2016-02-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10989#issuecomment-178147379 **[Test build #2486 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2486/consoleFull)** for PR 10989 at commit

[GitHub] spark pull request: [SPARK-12790][CORE] Remove HistoryServer old m...

2016-02-01 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/10860#discussion_r51472679 --- Diff: .rat-excludes --- @@ -63,14 +63,15 @@ logs .*dependency-reduced-pom.xml known_translations json_expectation

[GitHub] spark pull request: [SPARK-10820][SQL] Support for the continuous ...

2016-02-01 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/11006#discussion_r51476990 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala --- @@ -0,0 +1,213 @@ +/* + * Licensed to the

[GitHub] spark pull request: [SPARK-12957][SQL] Initial support for constra...

2016-02-01 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/10844#discussion_r51478445 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicOperators.scala --- @@ -180,6 +221,46 @@ case class Join(

[GitHub] spark pull request: [SPARK-12832][MESOS] mesos scheduler respect a...

2016-02-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10949#issuecomment-178181958 **[Test build #50500 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50500/consoleFull)** for PR 10949 at commit

[GitHub] spark pull request: [SPARK-10820][SQL] Support for the continuous ...

2016-02-01 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/11006#discussion_r51478334 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/memory.scala --- @@ -0,0 +1,138 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-10820][SQL] Support for the continuous ...

2016-02-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11006#issuecomment-178190775 **[Test build #50498 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50498/consoleFull)** for PR 11006 at commit

[GitHub] spark pull request: [SPARK-10749][MESOS] Support multiple roles wi...

2016-02-01 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/8872#issuecomment-178195492 @tnachen echoing my comment from another PR: it seems that this feature is already supported in client mode but not in cluster mode. Is there something we can do

[GitHub] spark pull request: [SPARK-10820][SQL] Support for the continuous ...

2016-02-01 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/11006#discussion_r51483601 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/StreamTest.scala --- @@ -0,0 +1,346 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request: [test-maven] Shade protobuf-java

2016-02-01 Thread tedyu
Github user tedyu commented on the pull request: https://github.com/apache/spark/pull/10995#issuecomment-178202908 This would still benefit Spark standalone and Spark on Mesos, right ? For Spark on YARN, status quo is maintained. --- If your project is set up for it, you can

[GitHub] spark pull request: [SPARK-10820][SQL] Support for the continuous ...

2016-02-01 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/11006#issuecomment-178205092 Looks great! Just some minor comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

  1   2   3   4   5   6   7   >