[GitHub] spark pull request: SPARK-11565 Replace deprecated DigestUtils.sha...

2016-02-06 Thread gliptak
Github user gliptak commented on the pull request: https://github.com/apache/spark/pull/9532#issuecomment-180853555 @srowen Yes I removed the pom.xml reference, and was successful building locally. Maven dependencies might have changed since I initially issued the patch ... --- If

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-06 Thread hvanhovell
Github user hvanhovell commented on the pull request: https://github.com/apache/spark/pull/11083#issuecomment-180870581 Retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-12725] [SQL] Resolving Name Conflicts i...

2016-02-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11050#issuecomment-180882339 **[Test build #50882 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50882/consoleFull)** for PR 11050 at commit

[GitHub] spark pull request: [SPARK-13186][Streaming]Migrate away from Sync...

2016-02-06 Thread holdenk
Github user holdenk commented on a diff in the pull request: https://github.com/apache/spark/pull/11104#discussion_r52109483 --- Diff: extras/kinesis-asl/src/test/scala/org/apache/spark/streaming/kinesis/KinesisStreamSuite.scala --- @@ -229,8 +231,7 @@ abstract class

[GitHub] spark pull request: [SPARK-13186][Streaming]Migrate away from Sync...

2016-02-06 Thread holdenk
Github user holdenk commented on the pull request: https://github.com/apache/spark/pull/11104#issuecomment-180889389 Thanks for the PR and getting started on this :) So the first minor thing we can update easily is import ordering in many of the files should follow the style

[GitHub] spark pull request: [SPARK-13171] [Core] Replace future calls with...

2016-02-06 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/11085#issuecomment-180847049 BTW, I also hit similar issues without this merge in my local environment. Thus, I do not know what is the root causes of this problem. --- If your project is set

[GitHub] spark pull request: SPARK-11565 Replace deprecated DigestUtils.sha...

2016-02-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9532#issuecomment-180854108 **[Test build #50877 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50877/consoleFull)** for PR 9532 at commit

[GitHub] spark pull request: [SPARK-9307] [CORE] Logging: Make it either st...

2016-02-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11103#issuecomment-180882900 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13186][Streaming]Migrate away from Sync...

2016-02-06 Thread huaxingao
GitHub user huaxingao opened a pull request: https://github.com/apache/spark/pull/11104 [SPARK-13186][Streaming]Migrate away from SynchronizedMap trait SynchronizedMap in package mutable is deprecated: Synchronization via traits is deprecated as it is inherently unreliable. Change

[GitHub] spark pull request: [SPARK-9307] [CORE] Logging: Make it either st...

2016-02-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11103#issuecomment-180882742 **[Test build #50880 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50880/consoleFull)** for PR 11103 at commit

[GitHub] spark pull request: [SPARK-9307] [CORE] Logging: Make it either st...

2016-02-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11103#issuecomment-180882901 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13186][Streaming]Migrate away from Sync...

2016-02-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11104#issuecomment-180882891 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12725] [SQL] Resolving Name Conflicts i...

2016-02-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11050#issuecomment-180894832 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-5865] [API DOC] Add doc warnings for me...

2016-02-06 Thread Wenpei
Github user Wenpei commented on the pull request: https://github.com/apache/spark/pull/10874#issuecomment-180884960 @srowen i add a comment in jira , which user name is Tommy Yu. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark pull request: [SPARK-9307] [CORE] Logging: Make it either st...

2016-02-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11103#issuecomment-180860208 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-9307] [CORE] Logging: Make it either st...

2016-02-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11103#issuecomment-180860126 **[Test build #50876 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50876/consoleFull)** for PR 11103 at commit

[GitHub] spark pull request: SPARK-11565 Replace deprecated DigestUtils.sha...

2016-02-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9532#issuecomment-180860193 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: SPARK-11565 Replace deprecated DigestUtils.sha...

2016-02-06 Thread gliptak
Github user gliptak commented on the pull request: https://github.com/apache/spark/pull/9532#issuecomment-180867438 OK, back to my initial confusion on this. So the pom.xml change is needed to make this work ... --- If your project is set up for it, you can reply to this email and

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11083#issuecomment-180866854 **[Test build #50879 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50879/consoleFull)** for PR 11083 at commit

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11083#issuecomment-180876912 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11083#issuecomment-180876910 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12725] [SQL] Resolving Name Conflicts i...

2016-02-06 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/11050#issuecomment-180879283 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11083#issuecomment-180886186 **[Test build #50883 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50883/consoleFull)** for PR 11083 at commit

[GitHub] spark pull request: [SPARK-12725] [SQL] Resolving Name Conflicts i...

2016-02-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11050#issuecomment-180894828 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12725] [SQL] Resolving Name Conflicts i...

2016-02-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11050#issuecomment-180894176 **[Test build #50882 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50882/consoleFull)** for PR 11050 at commit

[GitHub] spark pull request: [SPARK-9307] [CORE] Logging: Make it either st...

2016-02-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11103#issuecomment-180868814 **[Test build #50880 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50880/consoleFull)** for PR 11103 at commit

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11083#issuecomment-180879562 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11083#issuecomment-180879563 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11083#issuecomment-180879520 **[Test build #50881 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50881/consoleFull)** for PR 11083 at commit

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-06 Thread hvanhovell
Github user hvanhovell commented on the pull request: https://github.com/apache/spark/pull/11083#issuecomment-180885932 Retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-13186][Streaming]Migrate away from Sync...

2016-02-06 Thread holdenk
Github user holdenk commented on a diff in the pull request: https://github.com/apache/spark/pull/11104#discussion_r52109403 --- Diff: external/kafka/src/test/scala/org/apache/spark/streaming/kafka/KafkaStreamSuite.scala --- @@ -30,6 +30,9 @@ import org.apache.spark.{SparkConf,

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11083#issuecomment-180865748 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11083#issuecomment-180865744 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11083#issuecomment-180876599 **[Test build #50879 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50879/consoleFull)** for PR 11083 at commit

[GitHub] spark pull request: [SPARK-13186][Streaming]Migrate away from Sync...

2016-02-06 Thread holdenk
Github user holdenk commented on the pull request: https://github.com/apache/spark/pull/11104#issuecomment-180889472 @huaxingao did a first quick pass :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: SPARK-11565 Replace deprecated DigestUtils.sha...

2016-02-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9532#issuecomment-180860184 **[Test build #50877 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50877/consoleFull)** for PR 9532 at commit

[GitHub] spark pull request: SPARK-11565 Replace deprecated DigestUtils.sha...

2016-02-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9532#issuecomment-180860194 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-9307] [CORE] Logging: Make it either st...

2016-02-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11103#issuecomment-180860209 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-9307] [CORE] Logging: Make it either st...

2016-02-06 Thread hvanhovell
Github user hvanhovell commented on the pull request: https://github.com/apache/spark/pull/11103#issuecomment-180863942 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-9307] [CORE] Logging: Make it either st...

2016-02-06 Thread hvanhovell
Github user hvanhovell commented on the pull request: https://github.com/apache/spark/pull/11103#issuecomment-180864059 Test failure looks similar to the problems reported in https://issues.apache.org/jira/browse/SPARK-13171 Lets see what this build does. --- If your

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11083#issuecomment-180871268 **[Test build #50881 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50881/consoleFull)** for PR 11083 at commit

[GitHub] spark pull request: [SPARK-13186][Streaming]Migrate away from Sync...

2016-02-06 Thread huaxingao
Github user huaxingao commented on the pull request: https://github.com/apache/spark/pull/11104#issuecomment-180883943 @holdenk Could you please review? Thanks!! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [SPARK-13223] [ML] Add stratified sampling to ...

2016-02-06 Thread hhbyyh
GitHub user hhbyyh opened a pull request: https://github.com/apache/spark/pull/11102 [SPARK-13223] [ML] Add stratified sampling to ML feature engineering jira: https://issues.apache.org/jira/browse/SPARK-13223 I found it useful to add an sampling transformer during a case

[GitHub] spark pull request: [SPARK-13223] [ML] Add stratified sampling to ...

2016-02-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11102#issuecomment-180720697 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...

2016-02-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11100#issuecomment-180721464 **[Test build #50869 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50869/consoleFull)** for PR 11100 at commit

[GitHub] spark pull request: [SPARK-12792][SPARKR] Refactor RRDD to support...

2016-02-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10947#issuecomment-180753047 **[Test build #50870 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50870/consoleFull)** for PR 10947 at commit

[GitHub] spark pull request: [SPARK-11518] [Deploy, Windows] Handle spaces ...

2016-02-06 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/10789#issuecomment-180803089 The changes are mostly quoting and those look fine to me. There are a few cases where you removed %dp0 and I'm not entirely familiar with this, but I think you know

[GitHub] spark pull request: SPARK-11565 Replace deprecated DigestUtils.sha...

2016-02-06 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/9532#issuecomment-180826713 @gliptak yes obviously. But as per several comments in this discussion, I still don't see why you added the pom stanzas that you did. I think these should be removed.

[GitHub] spark pull request: SPARK-11565 Replace deprecated DigestUtils.sha...

2016-02-06 Thread gliptak
Github user gliptak commented on the pull request: https://github.com/apache/spark/pull/9532#issuecomment-180826210 The deprecated call was updated with this commit. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [SPARK-13176] [Core] Use java.nio.Files where ...

2016-02-06 Thread jodersky
Github user jodersky commented on the pull request: https://github.com/apache/spark/pull/11098#issuecomment-180843740 I can look for more uses of files. This pr was mainly to fix the deprecation warning caused by the use of process api On Feb 6, 2016 10:06 AM, "Sean Owen"

[GitHub] spark pull request: [SPARK-13171] [Core] Replace future calls with...

2016-02-06 Thread jodersky
Github user jodersky commented on the pull request: https://github.com/apache/spark/pull/11085#issuecomment-180845685 Someone else also reported that problem. Check out the discussion on the JIRA https://issues.apache.org/jira/browse/SPARK-13171 --- If your project is set up for it,

[GitHub] spark pull request: [SPARK-12725] [SQL] Resolving Name Conflicts i...

2016-02-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11050#issuecomment-180846515 **[Test build #50875 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50875/consoleFull)** for PR 11050 at commit

[GitHub] spark pull request: [SPARK-13171] [Core] Replace future calls with...

2016-02-06 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/11085#issuecomment-180846612 Thank you for your investigation! Maybe we can let the committers revert this merge or disable these Flaky tests? cc @rxin @JoshRosen @davies --- If your

[GitHub] spark pull request: [SPARK-12725] [SQL] Resolving Name Conflicts i...

2016-02-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11050#issuecomment-180846748 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12725] [SQL] Resolving Name Conflicts i...

2016-02-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11050#issuecomment-180846758 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-5865] [API DOC] Add doc warnings for me...

2016-02-06 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/10874#issuecomment-180815662 Merged to master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-12153][SPARK-7617][MLlib]add support of...

2016-02-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10152#issuecomment-180820174 **[Test build #50873 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50873/consoleFull)** for PR 10152 at commit

[GitHub] spark pull request: [SPARK-12153][SPARK-7617][MLlib]add support of...

2016-02-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10152#issuecomment-180820176 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12725] [SQL] Resolving Name Conflicts i...

2016-02-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11050#issuecomment-180828144 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12725] [SQL] Resolving Name Conflicts i...

2016-02-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11050#issuecomment-180828145 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12469][CORE][RFC/WIP] Add Consistent Ac...

2016-02-06 Thread holdenk
Github user holdenk closed the pull request at: https://github.com/apache/spark/pull/10841 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-13185][SQL] Improve the performance of ...

2016-02-06 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/11071#issuecomment-180793931 @adrian-wang but the `@transient` was applied to the whole reference to the `Map`. This doesn't make sense. The way to avoid a big cache is with weak keys, which has

[GitHub] spark pull request: [SPARK-13101][SQL] nullability of array type e...

2016-02-06 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/11035#issuecomment-180793590 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-13185][SQL] Reuse Calendar object in Da...

2016-02-06 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/11090#issuecomment-180795225 I'm not arguing with the optimization, just moaning at the use of `ThreadLocal`. This one at least isn't likely to cause a memory leak. Yes, I understand that the more

[GitHub] spark pull request: [SPARK-13101][SQL] nullability of array type e...

2016-02-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11035#issuecomment-180810979 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13101][SQL] nullability of array type e...

2016-02-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11035#issuecomment-180810976 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...

2016-02-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11100#issuecomment-180813023 **[Test build #50872 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50872/consoleFull)** for PR 11100 at commit

[GitHub] spark pull request: [SPARK-12995][GraphX] Remove deprecate APIs fr...

2016-02-06 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/10918#issuecomment-180817933 I'm back now. I'm almost ready to merge, but I noticed: should this not also remove `mapReduceTriplets`? Also the MiMa exclusions are correct but seem to be in the

[GitHub] spark pull request: [SPARK-12153][SPARK-7617][MLlib]add support of...

2016-02-06 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/10152#issuecomment-180817180 Jenkins, retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-9307] [CORE] Logging: Make it either st...

2016-02-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11103#issuecomment-180835085 **[Test build #50876 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50876/consoleFull)** for PR 11103 at commit

[GitHub] spark pull request: [SPARK-12469][CORE][RFC/WIP] Add Consistent Ac...

2016-02-06 Thread holdenk
Github user holdenk commented on the pull request: https://github.com/apache/spark/pull/10841#issuecomment-180844069 I'm going to close this and re-open one with the "full auto" type approach suggested. --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...

2016-02-06 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/11100#issuecomment-180792097 Test failures are caused by flaky tests. retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: [SPARK-13101][SQL] nullability of array type e...

2016-02-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11035#issuecomment-180796610 **[Test build #50871 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50871/consoleFull)** for PR 11035 at commit

[GitHub] spark pull request: SPARK-11565 Replace deprecated DigestUtils.sha...

2016-02-06 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/9532#issuecomment-180816087 Back online now. Actually, `commons-codec` is already declared at version 1.10 in the parent `pom.xml`. At this stage, we only need to change the deprecated call right?

[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...

2016-02-06 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/11100#issuecomment-180799710 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-11518] [Deploy, Windows] Handle spaces ...

2016-02-06 Thread tritab
Github user tritab commented on the pull request: https://github.com/apache/spark/pull/10789#issuecomment-180809864 @srowen Thank you for your review. The%~dp0 changes were to get the current directory working properly. I should mention I tested with spark-submit as well. I did not

[GitHub] spark pull request: [SPARK-13171] [Core] Replace future calls with...

2016-02-06 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/11085#issuecomment-180812541 I am afraid all the recent failure of test cases in `HiveSparkSubmitSuite` are caused by this merge. Since this merge, I saw the same errors repeat

[GitHub] spark pull request: [SPARK-5865] [API DOC] Add doc warnings for me...

2016-02-06 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/10874#issuecomment-180815866 @Wenpei if you have a JIRA handle I'll assign it to you --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark pull request: [SPARK-5865] [API DOC] Add doc warnings for me...

2016-02-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/10874 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-12153][SPARK-7617][MLlib]add support of...

2016-02-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10152#issuecomment-180820036 **[Test build #50873 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50873/consoleFull)** for PR 10152 at commit

[GitHub] spark pull request: [SPARK-12153][SPARK-7617][MLlib]add support of...

2016-02-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10152#issuecomment-180820177 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13176] [Core] Use java.nio.Files where ...

2016-02-06 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/11098#issuecomment-180824941 I think this is a good idea, though I suspect there are lots more places where the new files API can be used, either instead of custom code or instead of Guava. It'd be

[GitHub] spark pull request: [SPARK-9307] [CORE] Logging: Make it either st...

2016-02-06 Thread srowen
GitHub user srowen opened a pull request: https://github.com/apache/spark/pull/11103 [SPARK-9307] [CORE] Logging: Make it either stable or private[spark] Make Logging private[spark]. Pretty much all there is to it. You can merge this pull request into a Git repository by running:

[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...

2016-02-06 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/11100#issuecomment-180811258 test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-12725] [SQL] Resolving Name Conflicts i...

2016-02-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11050#issuecomment-180827424 **[Test build #50875 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50875/consoleFull)** for PR 11050 at commit

[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...

2016-02-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11100#issuecomment-180829601 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...

2016-02-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11100#issuecomment-180829600 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13040][Docs] Update JDBC deprecated SPA...

2016-02-06 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/10948#issuecomment-180829514 What if you try `spark.executor.extraClassPath`? out of curiosity --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...

2016-02-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11100#issuecomment-180829394 **[Test build #50872 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50872/consoleFull)** for PR 11100 at commit

[GitHub] spark pull request: [SPARK-13101][SQL] nullability of array type e...

2016-02-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11035#issuecomment-180810799 **[Test build #50871 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50871/consoleFull)** for PR 11035 at commit

[GitHub] spark pull request: [Core] Doc: PairRDDFunctions.reduceByKey shoul...

2016-02-06 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/11091#issuecomment-180836001 Yeah I think there similar statements about an 'associative' operation that really mean 'associative and commutative'. There are more occurrences in this file. There

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11083#issuecomment-180905120 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11083#issuecomment-180905064 **[Test build #50883 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50883/consoleFull)** for PR 11083 at commit

[GitHub] spark pull request: [SPARK-13225] [SQL] Support Intersect All/Dist...

2016-02-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11106#issuecomment-180928249 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13225] [SQL] Support Intersect All/Dist...

2016-02-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11106#issuecomment-180928248 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13225] [SQL] Support Intersect All/Dist...

2016-02-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11106#issuecomment-180928225 **[Test build #50885 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50885/consoleFull)** for PR 11106 at commit

[GitHub] spark pull request: [SPARK-12469][CORE][WIP/RFC] Consistent accumu...

2016-02-06 Thread holdenk
Github user holdenk commented on the pull request: https://github.com/apache/spark/pull/11105#issuecomment-180934147 Looks like the hive failure is probably unrelated, jenkins retest this please. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: [SPARK-13227] Risky apply() in OpenHashMap

2016-02-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11107#issuecomment-180969431 **[Test build #50888 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50888/consoleFull)** for PR 11107 at commit

[GitHub] spark pull request: [SPARK-12888][SQL][follow-up] benchmark the ne...

2016-02-06 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/10917#discussion_r52113377 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/HashBenchmark.scala --- @@ -70,7 +68,14 @@ object HashBenchmark { def main(args:

[GitHub] spark pull request: [SPARK-13131] [SQL] Use best and average time ...

2016-02-06 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/11018#discussion_r52113380 --- Diff: core/src/main/scala/org/apache/spark/util/Benchmark.scala --- @@ -59,17 +60,21 @@ private[spark] class Benchmark( } println

  1   2   >