[GitHub] spark pull request #13447: [SPARK-15706] [SQL] Fix Wrong Answer when using I...

2016-06-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/13447 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #13447: [SPARK-15706] [SQL] Fix Wrong Answer when using IF NOT E...

2016-06-16 Thread yhuai
Github user yhuai commented on the issue: https://github.com/apache/spark/pull/13447 Thanks. LGTM. Merging to master and branch 2.0. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request #13727: [SPARK-15982][SPARK-16009] Harmonize the behavior...

2016-06-16 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/13727#discussion_r67463353 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala --- @@ -276,7 +267,42 @@ class DataFrameReader private[sql](sparkSession:

[GitHub] spark issue #13721: [SPARK-16005][R] Add `randomSplit` to SparkR

2016-06-16 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/13721 Hi, @shivaram . The followings are updated and become ready for review again. - The param description is improved. - The size and ratio of returned list is compared with those of

[GitHub] spark issue #13728: [SPARK-16010] [SQL] Code Refactoring, Test Case Improvem...

2016-06-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13728 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60680/ Test PASSed. ---

[GitHub] spark issue #13728: [SPARK-16010] [SQL] Code Refactoring, Test Case Improvem...

2016-06-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13728 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13730: [SPARK-16006][SQL] Attemping to write empty DataFrame wi...

2016-06-16 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/13730 Hi, @tdas . This is the PR to care the reported corner case. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark issue #13728: [SPARK-16010] [SQL] Code Refactoring, Test Case Improvem...

2016-06-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13728 **[Test build #60680 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60680/consoleFull)** for PR 13728 at commit

[GitHub] spark pull request #13730: [SPARK-16006][SQL] Attemping to write empty DataF...

2016-06-16 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/13730#discussion_r67462488 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/PartitioningUtils.scala --- @@ -339,6 +339,9 @@ private[sql] object

[GitHub] spark issue #13730: [SPARK-16006][SQL] Attemping to write empty DataFrame wi...

2016-06-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13730 **[Test build #60686 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60686/consoleFull)** for PR 13730 at commit

[GitHub] spark pull request #13730: [SPARK-16006][SQL] Attemping to write empty DataF...

2016-06-16 Thread dongjoon-hyun
GitHub user dongjoon-hyun opened a pull request: https://github.com/apache/spark/pull/13730 [SPARK-16006][SQL] Attemping to write empty DataFrame with no fields throws non-intuitive exception ## What changes were proposed in this pull request? This PR fixes the error

[GitHub] spark pull request #13723: [SPARK-15822][SQL] Prevent byte array backed clas...

2016-06-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/13723 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #13727: [SPARK-15982][SPARK-16009] Harmonize the behavior of Dat...

2016-06-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13727 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13727: [SPARK-15982][SPARK-16009] Harmonize the behavior of Dat...

2016-06-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13727 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60679/ Test PASSed. ---

[GitHub] spark pull request #13707: [WIP][SPARK-15822][SQL] avoid UTF8String referenc...

2016-06-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/13707 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #13727: [SPARK-15982][SPARK-16009] Harmonize the behavior of Dat...

2016-06-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13727 **[Test build #60679 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60679/consoleFull)** for PR 13727 at commit

[GitHub] spark issue #13717: [SPARK-15811] [SQL] fix the Python UDF in Scala 2.10

2016-06-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13717 **[Test build #60685 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60685/consoleFull)** for PR 13717 at commit

[GitHub] spark issue #13723: [SPARK-15822][SQL] Prevent byte array backed classes fro...

2016-06-16 Thread davies
Github user davies commented on the issue: https://github.com/apache/spark/pull/13723 LGTM, Merging this into master and 2.0, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request #13722: [SPARK-15925][SPARKR] R DataFrame add back regist...

2016-06-16 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/13722#discussion_r67462006 --- Diff: R/pkg/R/DataFrame.R --- @@ -455,6 +455,17 @@ setMethod("createOrReplaceTempView", invisible(callJMethod(x@sdf,

[GitHub] spark issue #13652: [SPARK-15613] [SQL] Fix incorrect days to millis convers...

2016-06-16 Thread davies
Github user davies commented on the issue: https://github.com/apache/spark/pull/13652 @JoshRosen How does this look now? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #13721: [SPARK-16005][R] Add `randomSplit` to SparkR

2016-06-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13721 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13721: [SPARK-16005][R] Add `randomSplit` to SparkR

2016-06-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13721 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60684/ Test PASSed. ---

[GitHub] spark issue #13721: [SPARK-16005][R] Add `randomSplit` to SparkR

2016-06-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13721 **[Test build #60684 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60684/consoleFull)** for PR 13721 at commit

[GitHub] spark issue #13721: [SPARK-16005][R] Add `randomSplit` to SparkR

2016-06-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13721 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60682/ Test PASSed. ---

[GitHub] spark issue #13721: [SPARK-16005][R] Add `randomSplit` to SparkR

2016-06-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13721 **[Test build #60682 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60682/consoleFull)** for PR 13721 at commit

[GitHub] spark issue #13721: [SPARK-16005][R] Add `randomSplit` to SparkR

2016-06-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13721 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #13727: [SPARK-15982][SPARK-16009] Harmonize the behavior...

2016-06-16 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/13727#discussion_r67460691 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala --- @@ -276,7 +267,42 @@ class DataFrameReader private[sql](sparkSession:

[GitHub] spark pull request #13706: [SPARK-15988] [SQL] Implement DDL commands: Creat...

2016-06-16 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/13706#discussion_r67460632 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/macros.scala --- @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #13706: [SPARK-15988] [SQL] Implement DDL commands: Creat...

2016-06-16 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/13706#discussion_r67460610 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/macros.scala --- @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #13706: [SPARK-15988] [SQL] Implement DDL commands: Creat...

2016-06-16 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/13706#discussion_r67460540 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/macros.scala --- @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache

[GitHub] spark issue #13729: [SPARK-16008][ML] Remove unnecessary serialization in lo...

2016-06-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13729 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60681/ Test PASSed. ---

[GitHub] spark issue #13729: [SPARK-16008][ML] Remove unnecessary serialization in lo...

2016-06-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13729 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13729: [SPARK-16008][ML] Remove unnecessary serialization in lo...

2016-06-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13729 **[Test build #60681 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60681/consoleFull)** for PR 13729 at commit

[GitHub] spark issue #13721: [SPARK-16005][R] Add `randomSplit` to SparkR

2016-06-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13721 **[Test build #60684 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60684/consoleFull)** for PR 13721 at commit

[GitHub] spark pull request #13706: [SPARK-15988] [SQL] Implement DDL commands: Creat...

2016-06-16 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/13706#discussion_r67460480 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/macros.scala --- @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache

[GitHub] spark issue #13723: [SPARK-15822][SQL] Prevent byte array backed classes fro...

2016-06-16 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/13723 lgtm. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark pull request #13706: [SPARK-15988] [SQL] Implement DDL commands: Creat...

2016-06-16 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/13706#discussion_r67460323 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/macros.scala --- @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #13706: [SPARK-15988] [SQL] Implement DDL commands: Creat...

2016-06-16 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/13706#discussion_r67460344 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/macros.scala --- @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #13706: [SPARK-15988] [SQL] Implement DDL commands: Creat...

2016-06-16 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/13706#discussion_r67460294 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/macros.scala --- @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache

[GitHub] spark issue #13727: [SPARK-15982][SPARK-16009] Harmonize the behavior of Dat...

2016-06-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13727 **[Test build #60683 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60683/consoleFull)** for PR 13727 at commit

[GitHub] spark pull request #13706: [SPARK-15988] [SQL] Implement DDL commands: Creat...

2016-06-16 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/13706#discussion_r67460169 --- Diff: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 --- @@ -97,6 +97,9 @@ statement | CREATE TEMPORARY?

[GitHub] spark pull request #13706: [SPARK-15988] [SQL] Implement DDL commands: Creat...

2016-06-16 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/13706#discussion_r67460139 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala --- @@ -590,6 +591,38 @@ class SparkSqlAstBuilder(conf: SQLConf)

[GitHub] spark pull request #13706: [SPARK-15988] [SQL] Implement DDL commands: Creat...

2016-06-16 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/13706#discussion_r67460021 --- Diff: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 --- @@ -97,6 +97,9 @@ statement | CREATE TEMPORARY?

[GitHub] spark issue #13721: [SPARK-16005][R] Add `randomSplit` to SparkR

2016-06-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13721 **[Test build #60682 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60682/consoleFull)** for PR 13721 at commit

[GitHub] spark issue #10896: [SPARK-12978][SQL] Skip unnecessary final group-by when ...

2016-06-16 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/10896 @hvanhovell okay, I'll finish the fix soon. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13701: [SPARK-15639][SQL] Try to push down filter at RowGroups ...

2016-06-16 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/13701 @liancheng I've updated the benchmark. Please take a look. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark issue #13720: [SPARK-16004] [SQL] improve the display of CatalogTable ...

2016-06-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13720 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13720: [SPARK-16004] [SQL] improve the display of CatalogTable ...

2016-06-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13720 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60677/ Test PASSed. ---

[GitHub] spark issue #13720: [SPARK-16004] [SQL] improve the display of CatalogTable ...

2016-06-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13720 **[Test build #60677 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60677/consoleFull)** for PR 13720 at commit

[GitHub] spark issue #13729: [SPARK-16008][ML] Remove unnecessary serialization in lo...

2016-06-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13729 **[Test build #60681 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60681/consoleFull)** for PR 13729 at commit

[GitHub] spark issue #13729: [SPARK-16008][ML] Remove unnecessary serialization in lo...

2016-06-16 Thread sethah
Github user sethah commented on the issue: https://github.com/apache/spark/pull/13729 cc @jkbradley @dbtsai --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark pull request #13729: [SPARK-16008] Remove unnecessary serialization in...

2016-06-16 Thread sethah
GitHub user sethah opened a pull request: https://github.com/apache/spark/pull/13729 [SPARK-16008] Remove unnecessary serialization in logistic regression ## What changes were proposed in this pull request? `LogisticAggregator` stores references to two arrays of dimension

[GitHub] spark issue #13728: [SPARK-16010] [SQL] Code Refactoring, Test Case Improvem...

2016-06-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13728 **[Test build #60680 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60680/consoleFull)** for PR 13728 at commit

[GitHub] spark issue #13722: [SPARK-15925][SPARKR] R DataFrame add back registerTempT...

2016-06-16 Thread shivaram
Github user shivaram commented on the issue: https://github.com/apache/spark/pull/13722 LGTM. I just had a couple of points about the docs --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request #13728: [SPARK-16010] [SQL] Code Refactoring, Test Case I...

2016-06-16 Thread gatorsmile
GitHub user gatorsmile opened a pull request: https://github.com/apache/spark/pull/13728 [SPARK-16010] [SQL] Code Refactoring, Test Case Improvement and Description Updates for SQLConf spark.sql.parquet.filterPushdown What changes were proposed in this pull request?

[GitHub] spark pull request #13721: [SPARK-16005][R] Add `randomSplit` to SparkR

2016-06-16 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/13721#discussion_r67457739 --- Diff: R/pkg/inst/tests/testthat/test_sparkSQL.R --- @@ -2264,6 +2264,14 @@ test_that("createDataFrame sqlContext parameter backward

[GitHub] spark issue #13727: [SPARK-15982][SPARK-16009] Harmonize the behavior of Dat...

2016-06-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13727 **[Test build #60679 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60679/consoleFull)** for PR 13727 at commit

[GitHub] spark pull request #13721: [SPARK-16005][R] Add `randomSplit` to SparkR

2016-06-16 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/13721#discussion_r67457591 --- Diff: R/pkg/inst/tests/testthat/test_sparkSQL.R --- @@ -2264,6 +2264,14 @@ test_that("createDataFrame sqlContext parameter backward

[GitHub] spark pull request #13721: [SPARK-16005][R] Add `randomSplit` to SparkR

2016-06-16 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/13721#discussion_r67457577 --- Diff: R/pkg/R/DataFrame.R --- @@ -2884,3 +2884,39 @@ setMethod("write.jdbc", write <- callJMethod(write, "mode", jmode)

[GitHub] spark pull request #13721: [SPARK-16005][R] Add `randomSplit` to SparkR

2016-06-16 Thread shivaram
Github user shivaram commented on a diff in the pull request: https://github.com/apache/spark/pull/13721#discussion_r67457504 --- Diff: R/pkg/inst/tests/testthat/test_sparkSQL.R --- @@ -2264,6 +2264,14 @@ test_that("createDataFrame sqlContext parameter backward compatibility", {

[GitHub] spark pull request #13721: [SPARK-16005][R] Add `randomSplit` to SparkR

2016-06-16 Thread shivaram
Github user shivaram commented on a diff in the pull request: https://github.com/apache/spark/pull/13721#discussion_r67457476 --- Diff: R/pkg/inst/tests/testthat/test_sparkSQL.R --- @@ -2264,6 +2264,14 @@ test_that("createDataFrame sqlContext parameter backward compatibility", {

[GitHub] spark pull request #13721: [SPARK-16005][R] Add `randomSplit` to SparkR

2016-06-16 Thread shivaram
Github user shivaram commented on a diff in the pull request: https://github.com/apache/spark/pull/13721#discussion_r67457426 --- Diff: R/pkg/R/DataFrame.R --- @@ -2884,3 +2884,39 @@ setMethod("write.jdbc", write <- callJMethod(write, "mode", jmode)

[GitHub] spark issue #13727: [SPARK-15982][SPARK-16009] Harmonize the behavior of Dat...

2016-06-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13727 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13727: [SPARK-15982][SPARK-16009] Harmonize the behavior of Dat...

2016-06-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13727 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60678/ Test FAILed. ---

[GitHub] spark pull request #13727: [SPARK-15982][SPARK-16009] Harmonize the behavior...

2016-06-16 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/13727#discussion_r67457343 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala --- @@ -276,7 +267,42 @@ class DataFrameReader private[sql](sparkSession:

[GitHub] spark pull request #13727: [SPARK-15982][SPARK-16009] Harmonize the behavior...

2016-06-16 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/13727#discussion_r67457308 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala --- @@ -146,18 +140,15 @@ class DataFrameReader private[sql](sparkSession:

[GitHub] spark pull request #13722: [SPARK-15925][SPARKR] R DataFrame add back regist...

2016-06-16 Thread shivaram
Github user shivaram commented on a diff in the pull request: https://github.com/apache/spark/pull/13722#discussion_r67457292 --- Diff: R/pkg/R/DataFrame.R --- @@ -455,6 +455,17 @@ setMethod("createOrReplaceTempView", invisible(callJMethod(x@sdf,

[GitHub] spark issue #13684: [SPARK-15908][R] Add varargs-type dropDuplicates() funct...

2016-06-16 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/13684 Thank you, @shivaram ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark pull request #13727: [SPARK-15982][SPARK-16009] Harmonize the behavior...

2016-06-16 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/13727#discussion_r67457293 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala --- @@ -119,13 +119,7 @@ class DataFrameReader private[sql](sparkSession:

[GitHub] spark issue #13727: [SPARK-15982][SPARK-16009] Harmonize the behavior of Dat...

2016-06-16 Thread tdas
Github user tdas commented on the issue: https://github.com/apache/spark/pull/13727 @marmbrus @rxin --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] spark pull request #13727: [SPARK-15982][SPARK-16009] Harmonize the behavior...

2016-06-16 Thread tdas
GitHub user tdas opened a pull request: https://github.com/apache/spark/pull/13727 [SPARK-15982][SPARK-16009] Harmonize the behavior of DataFrameReader.text/csv/json/parquet/orc ## What changes were proposed in this pull request? Issues with current reader behavior. -

[GitHub] spark pull request #13722: [SPARK-15925][SPARKR] R DataFrame add back regist...

2016-06-16 Thread shivaram
Github user shivaram commented on a diff in the pull request: https://github.com/apache/spark/pull/13722#discussion_r67457183 --- Diff: R/pkg/R/DataFrame.R --- @@ -455,6 +455,17 @@ setMethod("createOrReplaceTempView", invisible(callJMethod(x@sdf,

[GitHub] spark pull request #13684: [SPARK-15908][R] Add varargs-type dropDuplicates(...

2016-06-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/13684 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #13617: [SPARK-10409] [ML] Add Multilayer Perceptron Regression ...

2016-06-16 Thread jkbradley
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/13617 Thanks for the PR (with a great description)! FYI review on a big new feature may need to wait until 2.0 QA is done. Also, @mengxr @avulanov have discussed regression before, and IIRC it

[GitHub] spark issue #13684: [SPARK-15908][R] Add varargs-type dropDuplicates() funct...

2016-06-16 Thread shivaram
Github user shivaram commented on the issue: https://github.com/apache/spark/pull/13684 LGTM. Merging into master, branch-2.0 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13486: [SPARK-15743][SQL] Prevent saving with all-column partit...

2016-06-16 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/13486 Oh, I see. I will fix tonight. Thank you, @tdas ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark issue #13726: Remove non-obvious conf settings from TPCDS benchmark

2016-06-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13726 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60675/ Test PASSed. ---

[GitHub] spark issue #13726: Remove non-obvious conf settings from TPCDS benchmark

2016-06-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13726 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13726: Remove non-obvious conf settings from TPCDS benchmark

2016-06-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13726 **[Test build #60675 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60675/consoleFull)** for PR 13726 at commit

[GitHub] spark issue #13486: [SPARK-15743][SQL] Prevent saving with all-column partit...

2016-06-16 Thread tdas
Github user tdas commented on the issue: https://github.com/apache/spark/pull/13486 @dongjoon-hyun There is a corner case that this check does not handle. When there are zero columns, the error is very non-intuitive. See https://issues.apache.org/jira/browse/SPARK-16006

[GitHub] spark pull request #13394: [SPARK-15490][R][DOC] SparkR 2.0 QA: New R APIs a...

2016-06-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/13394 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #13723: [SPARK-15822][SQL] Prevent byte array backed classes fro...

2016-06-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13723 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13723: [SPARK-15822][SQL] Prevent byte array backed classes fro...

2016-06-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13723 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60674/ Test PASSed. ---

[GitHub] spark issue #13723: [SPARK-15822][SQL] Prevent byte array backed classes fro...

2016-06-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13723 **[Test build #60674 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60674/consoleFull)** for PR 13723 at commit

[GitHub] spark issue #13394: [SPARK-15490][R][DOC] SparkR 2.0 QA: New R APIs and API ...

2016-06-16 Thread jkbradley
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/13394 LGTM Merging with master Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13725: [SPARK-15892][ML] Backport correctly merging AFTAggregat...

2016-06-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13725 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13725: [SPARK-15892][ML] Backport correctly merging AFTAggregat...

2016-06-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13725 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60676/ Test PASSed. ---

[GitHub] spark issue #13725: [SPARK-15892][ML] Backport correctly merging AFTAggregat...

2016-06-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13725 **[Test build #60676 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60676/consoleFull)** for PR 13725 at commit

[GitHub] spark pull request #13518: [WIP][SPARK-15472][SQL] Add support for writing i...

2016-06-16 Thread lw-lin
Github user lw-lin closed the pull request at: https://github.com/apache/spark/pull/13518 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #13620: [SPARK-15590] [WEBUI] Paginate Job Table in Jobs tab

2016-06-16 Thread nblintao
Github user nblintao commented on the issue: https://github.com/apache/spark/pull/13620 @ajbozarth Got it, that's a fatal bug. I will fix it in this PR. Thanks again! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark issue #13371: [SPARK-15639][SQL] Try to push down filter at RowGroups ...

2016-06-16 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/13371 @liancheng Thanks! I didn't notice that. I will rerun the benchmark. I've re-submitted this PR at #13701. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark issue #13620: [SPARK-15590] [WEBUI] Paginate Job Table in Jobs tab

2016-06-16 Thread ajbozarth
Github user ajbozarth commented on the issue: https://github.com/apache/spark/pull/13620 They actually share the core majority of their code so your pagination is already there, it just can't change pages or change the number of shown jobs. I think its has to do with how your calling

[GitHub] spark issue #13720: [SPARK-16004] [SQL] improve the display of CatalogTable ...

2016-06-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13720 **[Test build #60677 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60677/consoleFull)** for PR 13720 at commit

[GitHub] spark issue #13620: [SPARK-15590] [WEBUI] Paginate Job Table in Jobs tab

2016-06-16 Thread nblintao
Github user nblintao commented on the issue: https://github.com/apache/spark/pull/13620 @ajbozarth Thanks for your checking and reporting. I didn't notice that the UI for history servers are different and just changed the AllJobsPage. I will try to check the page for history

[GitHub] spark issue #13708: [SPARK-15591] [WEBUI] Paginate Stage Table in Stages tab

2016-06-16 Thread nblintao
Github user nblintao commented on the issue: https://github.com/apache/spark/pull/13708 @ajbozarth Thanks for pointing it out. It is true for both the stages page and the job page. It doesn't keep track of the status of other tables when one table is changed. I will try to

[GitHub] spark issue #13726: Remove non-obvious conf settings from TPCDS benchmark

2016-06-16 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/13726 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark issue #13726: Remove non-obvious conf settings from TPCDS benchmark

2016-06-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13726 **[Test build #60675 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60675/consoleFull)** for PR 13726 at commit

[GitHub] spark issue #13725: [SPARK-15892][ML] Backport correctly merging AFTAggregat...

2016-06-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13725 **[Test build #60676 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60676/consoleFull)** for PR 13725 at commit

[GitHub] spark issue #13726: Remove non-obvious conf settings from TPCDS benchmark

2016-06-16 Thread sameeragarwal
Github user sameeragarwal commented on the issue: https://github.com/apache/spark/pull/13726 cc @hvanhovell --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #13725: [SPARK-15892][ML] Backport correctly merging AFTAggregat...

2016-06-16 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/13725 cc @jkbradley I am sure that this tests this patch correctly anyway but less sure that checking `scale` is sensible. I am not familiar with ML although I know a bit. I will close it does not

  1   2   3   4   5   6   >