[GitHub] spark pull request #13765: [SPARK-16052][SQL] Improve `CollapseRepartition` ...

2016-07-07 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/13765#discussion_r70032947 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/dsl/package.scala --- @@ -370,8 +370,11 @@ package object dsl { case plan

[GitHub] spark issue #13680: [SPARK-15962][SQL] Introduce implementation with a dense...

2016-07-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13680 **[Test build #61972 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61972/consoleFull)** for PR 13680 at commit [`04d2e4b`](https://github.com/apache/spark/commit/0

[GitHub] spark issue #14012: [SPARK-16343][SQL] Improve the PushDownPredicate rule to...

2016-07-07 Thread liancheng
Github user liancheng commented on the issue: https://github.com/apache/spark/pull/14012 One more thing, please complete the PR title. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fea

[GitHub] spark issue #14012: [SPARK-16343][SQL] Improve the PushDownPredicate rule to...

2016-07-07 Thread liancheng
Github user liancheng commented on the issue: https://github.com/apache/spark/pull/14012 LGTM except for some minor comments. Thanks for improving this! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request #14012: [SPARK-16343][SQL] Improve the PushDownPredicate ...

2016-07-07 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/14012#discussion_r70032565 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -1135,11 +1146,16 @@ object PushDownPredicate extends

[GitHub] spark issue #14082: [SPARK-16381][SQL][SparkR] Update SQL examples and progr...

2016-07-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14082 **[Test build #61971 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61971/consoleFull)** for PR 14082 at commit [`7dca42d`](https://github.com/apache/spark/commit/7

[GitHub] spark pull request #14012: [SPARK-16343][SQL] Improve the PushDownPredicate ...

2016-07-07 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/14012#discussion_r70032005 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -1106,21 +1106,32 @@ object PushDownPredicate extends

[GitHub] spark issue #14082: [SPARK-16381][SQL][SparkR] Update SQL examples and progr...

2016-07-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14082 **[Test build #61970 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61970/consoleFull)** for PR 14082 at commit [`828b2cf`](https://github.com/apache/spark/commit/8

[GitHub] spark issue #14004: [SPARK-16285][SQL] Implement sentences SQL functions

2016-07-07 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14004 Thank you for review again! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled a

[GitHub] spark issue #14004: [SPARK-16285][SQL] Implement sentences SQL functions

2016-07-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14004 **[Test build #61969 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61969/consoleFull)** for PR 14004 at commit [`7912bf7`](https://github.com/apache/spark/commit/7

[GitHub] spark issue #14102: [SPARK-16434][SQL] Avoid record-per type dispatch in JSO...

2016-07-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14102 **[Test build #61968 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61968/consoleFull)** for PR 14102 at commit [`83a7ee9`](https://github.com/apache/spark/commit/8

[GitHub] spark issue #14004: [SPARK-16285][SQL] Implement sentences SQL functions

2016-07-07 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/14004 LGTM pending Jenkins. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] spark pull request #14103: [SPARK-16436][SQL] checkEvaluation should support...

2016-07-07 Thread petermaxlee
Github user petermaxlee commented on a diff in the pull request: https://github.com/apache/spark/pull/14103#discussion_r70030786 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala --- @@ -41,7 +41,12 @@ trait ExpressionEvalHe

[GitHub] spark pull request #14103: [SPARK-16436][SQL] checkEvaluation should support...

2016-07-07 Thread petermaxlee
Github user petermaxlee commented on a diff in the pull request: https://github.com/apache/spark/pull/14103#discussion_r70030804 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala --- @@ -41,7 +41,12 @@ trait ExpressionEvalHe

[GitHub] spark pull request #14014: [SPARK-16344][SQL] Decoding Parquet array of stru...

2016-07-07 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/14014#discussion_r70030627 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetRowConverter.scala --- @@ -482,13 +482,105 @@ private[parquet] cla

[GitHub] spark pull request #14014: [SPARK-16344][SQL] Decoding Parquet array of stru...

2016-07-07 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/14014#discussion_r70030569 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetRowConverter.scala --- @@ -482,13 +482,105 @@ private[parquet] cla

[GitHub] spark pull request #14103: [SPARK-16436][SQL] checkEvaluation should support...

2016-07-07 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14103#discussion_r70030535 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala --- @@ -41,7 +41,12 @@ trait ExpressionEvalHelp

[GitHub] spark issue #14008: [SPARK-16281][SQL] Implement parse_url SQL function

2016-07-07 Thread janplus
Github user janplus commented on the issue: https://github.com/apache/spark/pull/14008 cc @rxin @cloud-fan Thank you for review I add a new commit doing the following things: 1. Use ExpectsInputTypes instead of ImplicitCastInputTypes. 2. Add some cases for invalid-type

[GitHub] spark pull request #14014: [SPARK-16344][SQL] Decoding Parquet array of stru...

2016-07-07 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/14014#discussion_r70030381 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetRowConverter.scala --- @@ -482,13 +482,105 @@ private[parquet] cla

[GitHub] spark pull request #14014: [SPARK-16344][SQL] Decoding Parquet array of stru...

2016-07-07 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/14014#discussion_r70030343 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetRowConverter.scala --- @@ -482,13 +482,105 @@ private[parquet] cla

[GitHub] spark issue #14103: [SPARK-16436][SQL] checkEvaluation should support NaN

2016-07-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14103 **[Test build #61966 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61966/consoleFull)** for PR 14103 at commit [`ea0e91b`](https://github.com/apache/spark/commit/e

[GitHub] spark issue #13991: [SPARK-16318][SQL] Implement all remaining xpath functio...

2016-07-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13991 **[Test build #61967 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61967/consoleFull)** for PR 13991 at commit [`a86bc04`](https://github.com/apache/spark/commit/a

[GitHub] spark pull request #14014: [SPARK-16344][SQL] Decoding Parquet array of stru...

2016-07-07 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/14014#discussion_r70029947 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetRowConverter.scala --- @@ -482,13 +482,105 @@ private[parquet] cla

[GitHub] spark pull request #14014: [SPARK-16344][SQL] Decoding Parquet array of stru...

2016-07-07 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/14014#discussion_r70029907 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetRowConverter.scala --- @@ -482,13 +482,105 @@ private[parquet] cla

[GitHub] spark pull request #14094: [SPARK-16430][SQL][STREAMING] Add option maxFiles...

2016-07-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/14094 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request #14034: [SPARK-16355] [SPARK-16354] [SQL] Fix Bugs When L...

2016-07-07 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14034#discussion_r70029842 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala --- @@ -660,18 +660,39 @@ class SQLQuerySuite extends QueryTest with SharedSQLC

[GitHub] spark pull request #14014: [SPARK-16344][SQL] Decoding Parquet array of stru...

2016-07-07 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/14014#discussion_r70029843 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetRowConverter.scala --- @@ -482,13 +482,105 @@ private[parquet] cla

[GitHub] spark pull request #14008: [SPARK-16281][SQL] Implement parse_url SQL functi...

2016-07-07 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/14008#discussion_r70029620 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -652,6 +654,152 @@ case class StringRPad(str: Ex

[GitHub] spark issue #14094: [SPARK-16430][SQL][STREAMING] Add option maxFilesPerTrig...

2016-07-07 Thread tdas
Github user tdas commented on the issue: https://github.com/apache/spark/pull/14094 Merging this to master and 2.0 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wis

[GitHub] spark issue #14095: [SPARK-16429][SQL] Include `StringType` columns in `desc...

2016-07-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14095 **[Test build #61965 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61965/consoleFull)** for PR 14095 at commit [`fa4d3b4`](https://github.com/apache/spark/commit/f

[GitHub] spark pull request #14103: [SPARK-16436][SQL] checkEvaluation support NaN an...

2016-07-07 Thread petermaxlee
Github user petermaxlee commented on a diff in the pull request: https://github.com/apache/spark/pull/14103#discussion_r70029441 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala --- @@ -41,7 +41,12 @@ trait ExpressionEvalHe

[GitHub] spark pull request #14004: [SPARK-16285][SQL] Implement sentences SQL functi...

2016-07-07 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/14004#discussion_r70029429 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/regexpExpressions.scala --- @@ -17,10 +17,15 @@ package org

[GitHub] spark pull request #14102: [SPARK-16434][SQL] Avoid record-per type dispatch...

2016-07-07 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/14102#discussion_r70029359 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JSONOptions.scala --- @@ -51,7 +53,8 @@ private[sql] class JSONOptions

[GitHub] spark pull request #14004: [SPARK-16285][SQL] Implement sentences SQL functi...

2016-07-07 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/14004#discussion_r70029340 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/regexpExpressions.scala --- @@ -198,6 +203,67 @@ case class StringSpli

[GitHub] spark pull request #14102: [SPARK-16434][SQL] Avoid record-per type dispatch...

2016-07-07 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/14102#discussion_r70029253 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JacksonParser.scala --- @@ -35,184 +34,307 @@ import org.apache.spark.

[GitHub] spark issue #14099: [SPARK-16432] Empty blocks fail to serialize due to asse...

2016-07-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14099 **[Test build #3170 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3170/consoleFull)** for PR 14099 at commit [`9ce8146`](https://github.com/apache/spark/commit/

[GitHub] spark issue #14099: [SPARK-16432] Empty blocks fail to serialize due to asse...

2016-07-07 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/14099 LGTM pending Jenkins rerun. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishe

[GitHub] spark pull request #14004: [SPARK-16285][SQL] Implement sentences SQL functi...

2016-07-07 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/14004#discussion_r70029134 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/regexpExpressions.scala --- @@ -198,6 +203,67 @@ case class StringSpli

[GitHub] spark pull request #14103: [SPARK-16436][SQL] checkEvaluation support NaN an...

2016-07-07 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14103#discussion_r70029140 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala --- @@ -41,7 +41,12 @@ trait ExpressionEvalHelp

[GitHub] spark issue #14102: [SPARK-16434][SQL] Avoid record-per type dispatch in JSO...

2016-07-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14102 **[Test build #61964 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61964/consoleFull)** for PR 14102 at commit [`5d30f2b`](https://github.com/apache/spark/commit/5

[GitHub] spark issue #14004: [SPARK-16285][SQL] Implement sentences SQL functions

2016-07-07 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/14004 This looks alright. I left some minor comments. Please move this out of the regex file. Seems like it should go into stringExpressions file. --- If your project is set up for it, you can reply to thi

[GitHub] spark pull request #14095: [SPARK-16429][SQL] Include `StringType` columns i...

2016-07-07 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/14095#discussion_r70028963 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -1886,8 +1895,8 @@ class Dataset[T] private[sql]( } /**

[GitHub] spark pull request #14004: [SPARK-16285][SQL] Implement sentences SQL functi...

2016-07-07 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/14004#discussion_r70028972 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/regexpExpressions.scala --- @@ -17,10 +17,15 @@ package org.apache.s

[GitHub] spark issue #13701: [SPARK-15639][SQL] Try to push down filter at RowGroups ...

2016-07-07 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/13701 Agreed. This is the most common performance issue in Big Data. Filter push down will further deteriorate it. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request #14095: [SPARK-16429][SQL] Include `StringType` columns i...

2016-07-07 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/14095#discussion_r70028852 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -228,6 +228,15 @@ class Dataset[T] private[sql]( } }

[GitHub] spark pull request #14004: [SPARK-16285][SQL] Implement sentences SQL functi...

2016-07-07 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/14004#discussion_r70028864 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/regexpExpressions.scala --- @@ -198,6 +203,67 @@ case class StringSplit(str: Ex

[GitHub] spark pull request #14004: [SPARK-16285][SQL] Implement sentences SQL functi...

2016-07-07 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/14004#discussion_r70028809 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/regexpExpressions.scala --- @@ -198,6 +203,67 @@ case class StringSplit(str: Ex

[GitHub] spark issue #14034: [SPARK-16355] [SPARK-16354] [SQL] Fix Bugs When LIMIT/TA...

2016-07-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14034 **[Test build #61963 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61963/consoleFull)** for PR 14034 at commit [`f600ba4`](https://github.com/apache/spark/commit/f

[GitHub] spark pull request #14095: [SPARK-16429][SQL] Include `StringType` columns i...

2016-07-07 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/14095#discussion_r70028713 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -1886,8 +1895,8 @@ class Dataset[T] private[sql]( } /** - *

[GitHub] spark pull request #14095: [SPARK-16429][SQL] Include `StringType` columns i...

2016-07-07 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/14095#discussion_r70028704 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -228,6 +228,15 @@ class Dataset[T] private[sql]( } } + pri

[GitHub] spark pull request #14008: [SPARK-16281][SQL] Implement parse_url SQL functi...

2016-07-07 Thread janplus
Github user janplus commented on a diff in the pull request: https://github.com/apache/spark/pull/14008#discussion_r70028685 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -652,6 +654,152 @@ case class StringRPad(str:

[GitHub] spark issue #14102: [SPARK-16434][SQL] Avoid record-per type dispatch in JSO...

2016-07-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14102 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #14102: [SPARK-16434][SQL] Avoid record-per type dispatch in JSO...

2016-07-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14102 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61956/ Test PASSed. ---

[GitHub] spark pull request #14034: [SPARK-16355] [SPARK-16354] [SQL] Fix Bugs When L...

2016-07-07 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/14034#discussion_r70028525 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala --- @@ -660,7 +660,12 @@ case class GlobalL

[GitHub] spark issue #14102: [SPARK-16434][SQL] Avoid record-per type dispatch in JSO...

2016-07-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14102 **[Test build #61956 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61956/consoleFull)** for PR 14102 at commit [`9dbcec7`](https://github.com/apache/spark/commit/

[GitHub] spark issue #14095: [SPARK-16429][SQL] Include `StringType` columns in `desc...

2016-07-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14095 **[Test build #61962 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61962/consoleFull)** for PR 14095 at commit [`8915adb`](https://github.com/apache/spark/commit/8

[GitHub] spark issue #14004: [SPARK-16285][SQL] Implement sentences SQL functions

2016-07-07 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14004 Hi, @rxin . Could you review and merge this `sentences` PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark issue #14102: [SPARK-16434][SQL] Avoid record-per type dispatch in JSO...

2016-07-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14102 **[Test build #61961 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61961/consoleFull)** for PR 14102 at commit [`c5cce08`](https://github.com/apache/spark/commit/c

[GitHub] spark issue #14095: [SPARK-16429][SQL] Include `StringType` columns in `desc...

2016-07-07 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14095 I fixed Python/R and the docs accordingly, and tested locally. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project d

[GitHub] spark pull request #14034: [SPARK-16355] [SPARK-16354] [SQL] Fix Bugs When L...

2016-07-07 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/14034#discussion_r70028351 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala --- @@ -46,6 +46,20 @@ trait CheckAnalysis extends Predi

[GitHub] spark pull request #14008: [SPARK-16281][SQL] Implement parse_url SQL functi...

2016-07-07 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/14008#discussion_r70028288 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -652,6 +654,152 @@ case class StringRPad(str: Ex

[GitHub] spark issue #14083: [SPARK-16406][SQL] Improve performance of LogicalPlan.re...

2016-07-07 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14083 Finally! Congrat! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #14093: SPARK-16420: Ensure compression streams are closed.

2016-07-07 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/14093 cc @JoshRosen --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if th

[GitHub] spark pull request #14093: SPARK-16420: Ensure compression streams are close...

2016-07-07 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/14093#discussion_r70028149 --- Diff: core/src/main/java/org/apache/spark/shuffle/sort/UnsafeShuffleWriter.java --- @@ -349,12 +349,19 @@ void forceSorterToSpill() throws IOException {

[GitHub] spark pull request #14008: [SPARK-16281][SQL] Implement parse_url SQL functi...

2016-07-07 Thread janplus
Github user janplus commented on a diff in the pull request: https://github.com/apache/spark/pull/14008#discussion_r70028094 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -652,6 +654,152 @@ case class StringRPad(str:

[GitHub] spark pull request #14093: SPARK-16420: Ensure compression streams are close...

2016-07-07 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/14093#discussion_r70028071 --- Diff: common/network-common/src/main/java/org/apache/spark/network/util/LimitedInputStream.java --- @@ -102,4 +118,10 @@ public LimitedInputStream(InputStr

[GitHub] spark pull request #14008: [SPARK-16281][SQL] Implement parse_url SQL functi...

2016-07-07 Thread janplus
Github user janplus commented on a diff in the pull request: https://github.com/apache/spark/pull/14008#discussion_r70028081 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -652,6 +654,152 @@ case class StringRPad(str:

[GitHub] spark issue #14078: [SPARK-11857] [Mesos] [WIP] Deprecate fine grained

2016-07-07 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/14078 Still waiting? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if t

[GitHub] spark issue #14102: [SPARK-16434][SQL] Avoid record-per type dispatch in JSO...

2016-07-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14102 **[Test build #61960 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61960/consoleFull)** for PR 14102 at commit [`cd44ac5`](https://github.com/apache/spark/commit/c

[GitHub] spark issue #14102: [SPARK-16434][SQL] Avoid record-per type dispatch in JSO...

2016-07-07 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/14102 cc @yhuai @liancheng Do you mind if I ask a quick look for this as well please? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. I

[GitHub] spark pull request #14008: [SPARK-16281][SQL] Implement parse_url SQL functi...

2016-07-07 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/14008#discussion_r70027833 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -652,6 +654,152 @@ case class StringRPad(str: Ex

[GitHub] spark issue #13701: [SPARK-15639][SQL] Try to push down filter at RowGroups ...

2016-07-07 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/13701 @gatorsmile That depends. In practice, we have many solutions to deal with the case you mentioned. It is not making sense to keep so many tiny parquet files. --- If your project is set up for it, y

[GitHub] spark issue #14095: [SPARK-16429][SQL] Include `StringType` columns in `desc...

2016-07-07 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14095 Of course! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] spark issue #14103: [SPARK-16436][SQL] checkEvaluation support NaN and Runti...

2016-07-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14103 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #14068: enhanced simulate multiply

2016-07-07 Thread uzadude
Github user uzadude commented on the issue: https://github.com/apache/spark/pull/14068 Sure. The current method for multiplying distributed block matrices starts by deciding which block should be shuffled to which partition to do the actual multiplications. This stage is implement

[GitHub] spark issue #14103: [SPARK-16436][SQL] checkEvaluation support NaN and Runti...

2016-07-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14103 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61955/ Test PASSed. ---

[GitHub] spark issue #14103: [SPARK-16436][SQL] checkEvaluation support NaN and Runti...

2016-07-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14103 **[Test build #61955 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61955/consoleFull)** for PR 14103 at commit [`0278dea`](https://github.com/apache/spark/commit/

[GitHub] spark pull request #14008: [SPARK-16281][SQL] Implement parse_url SQL functi...

2016-07-07 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/14008#discussion_r70027483 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -652,6 +654,152 @@ case class StringRPad(str: Ex

[GitHub] spark pull request #14008: [SPARK-16281][SQL] Implement parse_url SQL functi...

2016-07-07 Thread janplus
Github user janplus commented on a diff in the pull request: https://github.com/apache/spark/pull/14008#discussion_r70027444 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -652,6 +654,152 @@ case class StringRPad(str:

[GitHub] spark issue #14075: [SPARK-16401] [SQL] Data Source API: Enable Extending Re...

2016-07-07 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/14075 cc @cloud-fan and @liancheng for review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enab

[GitHub] spark issue #11748: [SPARK-13921] Store serialized blocks as multiple chunks...

2016-07-07 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/11748 @bonitao here's a patch that fixes it https://github.com/apache/spark/pull/14099 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request #14057: [SPARK-15425][SQL] Disallow cross joins, even if ...

2016-07-07 Thread rxin
Github user rxin closed the pull request at: https://github.com/apache/spark/pull/14057 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] spark issue #14095: [SPARK-16429][SQL] Include `StringType` columns in `desc...

2016-07-07 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/14095 And also update the documentation. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled an

[GitHub] spark pull request #14008: [SPARK-16281][SQL] Implement parse_url SQL functi...

2016-07-07 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/14008#discussion_r70027201 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -652,6 +654,152 @@ case class StringRPad(str: Ex

[GitHub] spark pull request #14008: [SPARK-16281][SQL] Implement parse_url SQL functi...

2016-07-07 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/14008#discussion_r70027152 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -652,6 +654,152 @@ case class StringRPad(str: Ex

[GitHub] spark issue #14071: [SPARK-16397][SQL] make CatalogTable more general and le...

2016-07-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14071 **[Test build #61959 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61959/consoleFull)** for PR 14071 at commit [`b218bb7`](https://github.com/apache/spark/commit/b

[GitHub] spark pull request #14008: [SPARK-16281][SQL] Implement parse_url SQL functi...

2016-07-07 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14008#discussion_r70027089 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -652,6 +654,152 @@ case class StringRPad(st

[GitHub] spark issue #14083: [SPARK-16406][SQL] Improve performance of LogicalPlan.re...

2016-07-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14083 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61952/ Test PASSed. ---

[GitHub] spark issue #14083: [SPARK-16406][SQL] Improve performance of LogicalPlan.re...

2016-07-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14083 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #14083: [SPARK-16406][SQL] Improve performance of LogicalPlan.re...

2016-07-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14083 **[Test build #61952 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61952/consoleFull)** for PR 14083 at commit [`a5d1a4a`](https://github.com/apache/spark/commit/

[GitHub] spark issue #14095: [SPARK-16429][SQL] Include `StringType` columns in `desc...

2016-07-07 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14095 Oh, sure! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or i

[GitHub] spark issue #13991: [SPARK-16318][SQL] Implement all remaining xpath functio...

2016-07-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13991 **[Test build #61958 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61958/consoleFull)** for PR 13991 at commit [`48311bb`](https://github.com/apache/spark/commit/4

[GitHub] spark issue #13991: [SPARK-16318][SQL] Implement various xpath functions

2016-07-07 Thread petermaxlee
Github user petermaxlee commented on the issue: https://github.com/apache/spark/pull/13991 I just added the general xpath function that returns an array of string too. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If y

[GitHub] spark issue #13991: [SPARK-16318][SQL] Implement various xpath functions

2016-07-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13991 **[Test build #61957 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61957/consoleFull)** for PR 13991 at commit [`d7d5f8d`](https://github.com/apache/spark/commit/d

[GitHub] spark pull request #14008: [SPARK-16281][SQL] Implement parse_url SQL functi...

2016-07-07 Thread janplus
Github user janplus commented on a diff in the pull request: https://github.com/apache/spark/pull/14008#discussion_r70026365 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -652,6 +654,152 @@ case class StringRPad(str:

[GitHub] spark pull request #14008: [SPARK-16281][SQL] Implement parse_url SQL functi...

2016-07-07 Thread janplus
Github user janplus commented on a diff in the pull request: https://github.com/apache/spark/pull/14008#discussion_r70026344 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -652,6 +654,152 @@ case class StringRPad(str:

[GitHub] spark issue #13991: [SPARK-16318][SQL] Implement various xpath functions

2016-07-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13991 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61954/ Test FAILed. ---

[GitHub] spark issue #13991: [SPARK-16318][SQL] Implement various xpath functions

2016-07-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13991 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #13991: [SPARK-16318][SQL] Implement various xpath functions

2016-07-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13991 **[Test build #61954 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61954/consoleFull)** for PR 13991 at commit [`02df488`](https://github.com/apache/spark/commit/

[GitHub] spark issue #13991: [SPARK-16318][SQL] Implement various xpath functions

2016-07-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13991 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61953/ Test FAILed. ---

  1   2   3   4   5   6   7   >