[GitHub] spark issue #17415: [SPARK-19408][SQL] filter estimation on two columns of s...

2017-04-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17415 **[Test build #75472 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75472/testReport)** for PR 17415 at commit

[GitHub] spark pull request #17415: [SPARK-19408][SQL] filter estimation on two colum...

2017-04-02 Thread ron8hu
Github user ron8hu commented on a diff in the pull request: https://github.com/apache/spark/pull/17415#discussion_r109340165 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/FilterEstimation.scala --- @@ -550,6 +565,220 @@ case

[GitHub] spark pull request #17517: [MINOR][DOCS] Replace non-breaking space to norma...

2017-04-02 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/17517#discussion_r109336446 --- Diff: docs/building-spark.md --- @@ -154,7 +154,7 @@ Developers who compile Spark frequently may want to speed up compilation; e.g.,

[GitHub] spark pull request #17517: [MINOR][DOCS] Replace non-breaking space to norma...

2017-04-02 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/17517#discussion_r109336475 --- Diff: README.md --- @@ -97,7 +97,7 @@ building for particular Hive and Hive Thriftserver distributions. Please refer to the [Configuration

[GitHub] spark pull request #17517: [MINOR][DOCS] Replace non-breaking space to norma...

2017-04-02 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/17517#discussion_r109336405 --- Diff: docs/monitoring.md --- @@ -257,7 +257,7 @@ In the API, an application is referenced by its application ID, `[app-id]`. When running on

[GitHub] spark issue #17517: [MINOR][DOCS] Replace non-breaking space to normal space...

2017-04-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17517 **[Test build #75471 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75471/testReport)** for PR 17517 at commit

[GitHub] spark issue #17517: [MINOR][DOCS] Replace non-breaking space to normal space...

2017-04-02 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/17517 cc @srowen. Could you take a look please? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request #17517: [MINOR][DOCS] Replace non-breaking space to norma...

2017-04-02 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/17517#discussion_r109336173 --- Diff: docs/monitoring.md --- @@ -257,7 +257,7 @@ In the API, an application is referenced by its application ID, `[app-id]`. When running on

[GitHub] spark pull request #17517: [MINOR][DOCS] Replace non-breaking space to norma...

2017-04-02 Thread HyukjinKwon
GitHub user HyukjinKwon opened a pull request: https://github.com/apache/spark/pull/17517 [MINOR][DOCS] Replace non-breaking space to normal spaces that breaks rendering markdown ## What changes were proposed in this pull request? It seems there are several non-breaking

[GitHub] spark issue #17515: [SPARK-20197][SPARKR][BRANCH-2.1] CRAN check fail with p...

2017-04-02 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/17515 merged to branch-2.1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark pull request #17515: [SPARK-20197][SPARKR][BRANCH-2.1] CRAN check fail...

2017-04-02 Thread felixcheung
Github user felixcheung closed the pull request at: https://github.com/apache/spark/pull/17515 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark issue #17515: [SPARK-20197][SPARKR][BRANCH-2.1] CRAN check fail with p...

2017-04-02 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/17515 while we are skipping that one test here, the test actual will pass when run - it's just that when running as `R CMD check`, `SPARK_HOME = ~/.cache/spark/spark*` whereas `spark-warehouse` and

[GitHub] spark issue #17515: [SPARK-20197][SPARKR][BRANCH-2.1] CRAN check fail with p...

2017-04-02 Thread shivaram
Github user shivaram commented on the issue: https://github.com/apache/spark/pull/17515 LGTM. I think this fix is fine for 2.1 branch (though its a shame as this was one of the main changes we were trying to get in 2.1 ?) --- If your project is set up for it, you can reply to this

[GitHub] spark issue #17415: [SPARK-19408][SQL] filter estimation on two columns of s...

2017-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17415 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75470/ Test PASSed. ---

[GitHub] spark issue #17415: [SPARK-19408][SQL] filter estimation on two columns of s...

2017-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17415 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17415: [SPARK-19408][SQL] filter estimation on two columns of s...

2017-04-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17415 **[Test build #75470 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75470/testReport)** for PR 17415 at commit

[GitHub] spark issue #17516: [SPARK-20197][SPARKR][WIP] improve check for directory t...

2017-04-02 Thread shivaram
Github user shivaram commented on the issue: https://github.com/apache/spark/pull/17516 So does the current patch pass `R CMD check` when run on the master branch ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark issue #17516: [SPARK-20197][SPARKR][WIP] improve check for directory t...

2017-04-02 Thread shivaram
Github user shivaram commented on the issue: https://github.com/apache/spark/pull/17516 Looking at this now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark pull request #17415: [SPARK-19408][SQL] filter estimation on two colum...

2017-04-02 Thread ron8hu
Github user ron8hu commented on a diff in the pull request: https://github.com/apache/spark/pull/17415#discussion_r109326608 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/FilterEstimation.scala --- @@ -550,6 +565,225 @@ case

[GitHub] spark issue #17510: [SPARK-20194] Add support for partition pruning to in-me...

2017-04-02 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/17510 LGTM cc @cloud-fan @hvanhovell --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request #17483: [SPARK-20159][SPARKR][SQL] Support all catalog AP...

2017-04-02 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17483#discussion_r109325537 --- Diff: R/pkg/R/catalog.R --- @@ -0,0 +1,478 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor

[GitHub] spark issue #17487: [Spark-20145] Fix range case insensitive bug in SQL

2017-04-02 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/17487 See the [code changes](https://github.com/apache/spark/commit/d9c24b3dc5ca64cf8aecebf58f22a3a2e5aab821) I made in my private branch. To generate the new result file after you add the

[GitHub] spark pull request #17415: [SPARK-19408][SQL] filter estimation on two colum...

2017-04-02 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17415#discussion_r109324280 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/FilterEstimation.scala --- @@ -550,6 +565,220 @@ case

[GitHub] spark pull request #17415: [SPARK-19408][SQL] filter estimation on two colum...

2017-04-02 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17415#discussion_r109323975 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/FilterEstimation.scala --- @@ -550,6 +565,225 @@ case

[GitHub] spark issue #17415: [SPARK-19408][SQL] filter estimation on two columns of s...

2017-04-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17415 **[Test build #75470 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75470/testReport)** for PR 17415 at commit

[GitHub] spark issue #17516: [SPARK-20197][SPARKR][WIP] improve check for directory t...

2017-04-02 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/17516 unlike in Jenkins, R CMD check looks to be running each test R file with the current directory set to its directory (eg. spark/R/pkg/inst/tests/testthat/ for test_sparkSQL.R) unless

[GitHub] spark issue #17515: [SPARK-20197][SPARKR][BRANCH-2.1] CRAN check fail with p...

2017-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17515 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17515: [SPARK-20197][SPARKR][BRANCH-2.1] CRAN check fail with p...

2017-04-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17515 **[Test build #75468 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75468/testReport)** for PR 17515 at commit

[GitHub] spark issue #17515: [SPARK-20197][SPARKR][BRANCH-2.1] CRAN check fail with p...

2017-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17515 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75468/ Test PASSed. ---

[GitHub] spark issue #17515: [SPARK-20197][SPARKR][BRANCH-2.1] CRAN check fail with p...

2017-04-02 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/17515 AppVeyor doesn't run for branch-*, so the red mark is expected. This should be good to go to branch-2.1. --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark pull request #17415: [SPARK-19408][SQL] filter estimation on two colum...

2017-04-02 Thread ron8hu
Github user ron8hu commented on a diff in the pull request: https://github.com/apache/spark/pull/17415#discussion_r109323394 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/FilterEstimation.scala --- @@ -550,6 +565,225 @@ case

[GitHub] spark pull request #17415: [SPARK-19408][SQL] filter estimation on two colum...

2017-04-02 Thread ron8hu
Github user ron8hu commented on a diff in the pull request: https://github.com/apache/spark/pull/17415#discussion_r109323397 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/FilterEstimation.scala --- @@ -550,6 +565,225 @@ case

[GitHub] spark pull request #17415: [SPARK-19408][SQL] filter estimation on two colum...

2017-04-02 Thread ron8hu
Github user ron8hu commented on a diff in the pull request: https://github.com/apache/spark/pull/17415#discussion_r109323376 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/FilterEstimation.scala --- @@ -550,6 +565,225 @@ case

[GitHub] spark issue #17516: [SPARK-20197][SPARKR][WIP] improve check for directory t...

2017-04-02 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/17516 WIP - testing this out in Jenkins, AppVeyor. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #17516: [SPARK-20197][SPARKR][WIP] improve check for directory t...

2017-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17516 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17516: [SPARK-20197][SPARKR][WIP] improve check for directory t...

2017-04-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17516 **[Test build #75469 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75469/testReport)** for PR 17516 at commit

[GitHub] spark issue #17516: [SPARK-20197][SPARKR][WIP] improve check for directory t...

2017-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17516 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75469/ Test FAILed. ---

[GitHub] spark issue #17516: [SPARK-20197][SPARKR][WIP] improve check for directory t...

2017-04-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17516 **[Test build #75469 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75469/testReport)** for PR 17516 at commit

[GitHub] spark pull request #17516: [SPARK-20197][SPARKR][WIP] improve check for dire...

2017-04-02 Thread felixcheung
GitHub user felixcheung opened a pull request: https://github.com/apache/spark/pull/17516 [SPARK-20197][SPARKR][WIP] improve check for directory to cover differences with R CMD check ## What changes were proposed in this pull request? Check both SPARK_HOME and current

[GitHub] spark pull request #15326: [SPARK-17759] [CORE] Avoid adding duplicate sched...

2017-04-02 Thread kayousterhout
Github user kayousterhout commented on a diff in the pull request: https://github.com/apache/spark/pull/15326#discussion_r109322968 --- Diff: core/src/test/scala/org/apache/spark/scheduler/PoolSuite.scala --- @@ -292,7 +290,100 @@ class PoolSuite extends SparkFunSuite with

[GitHub] spark pull request #15326: [SPARK-17759] [CORE] Avoid adding duplicate sched...

2017-04-02 Thread kayousterhout
Github user kayousterhout commented on a diff in the pull request: https://github.com/apache/spark/pull/15326#discussion_r109323006 --- Diff: core/src/test/scala/org/apache/spark/scheduler/PoolSuite.scala --- @@ -292,7 +290,100 @@ class PoolSuite extends SparkFunSuite with

[GitHub] spark pull request #15326: [SPARK-17759] [CORE] Avoid adding duplicate sched...

2017-04-02 Thread kayousterhout
Github user kayousterhout commented on a diff in the pull request: https://github.com/apache/spark/pull/15326#discussion_r109322987 --- Diff: core/src/test/scala/org/apache/spark/scheduler/PoolSuite.scala --- @@ -292,7 +290,100 @@ class PoolSuite extends SparkFunSuite with

[GitHub] spark pull request #15326: [SPARK-17759] [CORE] Avoid adding duplicate sched...

2017-04-02 Thread kayousterhout
Github user kayousterhout commented on a diff in the pull request: https://github.com/apache/spark/pull/15326#discussion_r109322980 --- Diff: core/src/test/scala/org/apache/spark/scheduler/PoolSuite.scala --- @@ -292,7 +290,100 @@ class PoolSuite extends SparkFunSuite with

[GitHub] spark issue #15326: [SPARK-17759] [CORE] Avoid adding duplicate schedulables

2017-04-02 Thread kayousterhout
Github user kayousterhout commented on the issue: https://github.com/apache/spark/pull/15326 Jenkins this is OK to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #17515: [SPARK-20197][SPARKR][BRANCH-2.1] CRAN check fail with p...

2017-04-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17515 **[Test build #75468 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75468/testReport)** for PR 17515 at commit

[GitHub] spark pull request #17515: [SPARK-20197][SPARKR] CRAN check fail with packag...

2017-04-02 Thread felixcheung
GitHub user felixcheung opened a pull request: https://github.com/apache/spark/pull/17515 [SPARK-20197][SPARKR] CRAN check fail with package installation ## What changes were proposed in this pull request? Test failed because SPARK_HOME is not set before Spark is installed.

[GitHub] spark pull request #17514: [SPARK-20197][SPARKR] CRAN check fail with packag...

2017-04-02 Thread felixcheung
Github user felixcheung closed the pull request at: https://github.com/apache/spark/pull/17514 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark pull request #17514: [SPARK-20197][SPARKR] CRAN check fail with packag...

2017-04-02 Thread felixcheung
GitHub user felixcheung opened a pull request: https://github.com/apache/spark/pull/17514 [SPARK-20197][SPARKR] CRAN check fail with package installation Test failed because SPARK_HOME is not set before Spark is installed. Also current directory is not == SPARK_HOME when tests

[GitHub] spark pull request #17513: [SPARK-20197][SPARKR] CRAN check fail with packag...

2017-04-02 Thread felixcheung
Github user felixcheung closed the pull request at: https://github.com/apache/spark/pull/17513 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark pull request #17513: [SPARK-20197][SPARKR] CRAN check fail with packag...

2017-04-02 Thread felixcheung
GitHub user felixcheung opened a pull request: https://github.com/apache/spark/pull/17513 [SPARK-20197][SPARKR] CRAN check fail with package installation ## What changes were proposed in this pull request? Test failed because SPARK_HOME is not set before Spark is

[GitHub] spark issue #17512: [SPARK-20196][PYTHON][SQL] update doc for catalog functi...

2017-04-02 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/17512 @gatorsmile --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] spark issue #17459: [SPARK-20109][MLlib] Added toBlockMatrixDense to Indexed...

2017-04-02 Thread johnc1231
Github user johnc1231 commented on the issue: https://github.com/apache/spark/pull/17459 Addressed comments where everything was clear, replied to the last one about only having one toBlockMatrix. Back to you @viirya . Thanks for feedback. --- If your project is set up for it, you

[GitHub] spark issue #17512: [SPARK-20196][PYTHON][SQL] update doc for catalog functi...

2017-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17512 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17512: [SPARK-20196][PYTHON][SQL] update doc for catalog functi...

2017-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17512 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75466/ Test PASSed. ---

[GitHub] spark issue #17512: [SPARK-20196][PYTHON][SQL] update doc for catalog functi...

2017-04-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17512 **[Test build #75466 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75466/testReport)** for PR 17512 at commit

[GitHub] spark pull request #17459: [SPARK-20109][MLlib] Added toBlockMatrixDense to ...

2017-04-02 Thread johnc1231
Github user johnc1231 commented on a diff in the pull request: https://github.com/apache/spark/pull/17459#discussion_r109320701 --- Diff: mllib/src/test/scala/org/apache/spark/mllib/linalg/distributed/IndexedRowMatrixSuite.scala --- @@ -89,11 +89,42 @@ class IndexedRowMatrixSuite

[GitHub] spark pull request #17459: [SPARK-20109][MLlib] Added toBlockMatrixDense to ...

2017-04-02 Thread johnc1231
Github user johnc1231 commented on a diff in the pull request: https://github.com/apache/spark/pull/17459#discussion_r109320642 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/distributed/IndexedRowMatrix.scala --- @@ -113,6 +114,67 @@ class IndexedRowMatrix

[GitHub] spark pull request #17459: [SPARK-20109][MLlib] Added toBlockMatrixDense to ...

2017-04-02 Thread johnc1231
Github user johnc1231 commented on a diff in the pull request: https://github.com/apache/spark/pull/17459#discussion_r109320468 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/distributed/IndexedRowMatrix.scala --- @@ -113,6 +114,67 @@ class IndexedRowMatrix

[GitHub] spark pull request #17459: [SPARK-20109][MLlib] Added toBlockMatrixDense to ...

2017-04-02 Thread johnc1231
Github user johnc1231 commented on a diff in the pull request: https://github.com/apache/spark/pull/17459#discussion_r109320386 --- Diff: mllib/src/test/scala/org/apache/spark/mllib/linalg/distributed/IndexedRowMatrixSuite.scala --- @@ -89,11 +89,42 @@ class IndexedRowMatrixSuite

[GitHub] spark issue #17510: [SPARK-20194] Add support for partition pruning to in-me...

2017-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17510 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17510: [SPARK-20194] Add support for partition pruning to in-me...

2017-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17510 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75464/ Test PASSed. ---

[GitHub] spark issue #17510: [SPARK-20194] Add support for partition pruning to in-me...

2017-04-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17510 **[Test build #75464 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75464/testReport)** for PR 17510 at commit

[GitHub] spark issue #17511: [SPARK-20195][SPARKR][SQL] add createTable catalog API a...

2017-04-02 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/17511 @gatorsmile @shivaram --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #17511: [SPARK-20195][SPARKR][SQL] add createTable catalog API a...

2017-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17511 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75467/ Test PASSed. ---

[GitHub] spark issue #17511: [SPARK-20195][SPARKR][SQL] add createTable catalog API a...

2017-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17511 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17511: [SPARK-20195][SPARKR][SQL] add createTable catalog API a...

2017-04-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17511 **[Test build #75467 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75467/testReport)** for PR 17511 at commit

[GitHub] spark issue #17511: [SPARK-20195][SPARKR][SQL] add createTable catalog API a...

2017-04-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17511 **[Test build #75467 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75467/testReport)** for PR 17511 at commit

[GitHub] spark issue #17512: [SPARK-20196][PYTHON][SQL] update doc for catalog functi...

2017-04-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17512 **[Test build #75466 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75466/testReport)** for PR 17512 at commit

[GitHub] spark issue #17487: [Spark-20145] Fix range case insensitive bug in SQL

2017-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17487 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17487: [Spark-20145] Fix range case insensitive bug in SQL

2017-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17487 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75463/ Test PASSed. ---

[GitHub] spark issue #17487: [Spark-20145] Fix range case insensitive bug in SQL

2017-04-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17487 **[Test build #75463 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75463/testReport)** for PR 17487 at commit

[GitHub] spark pull request #17512: [SPARK-20196][PYTHON][SQL] update doc for catalog...

2017-04-02 Thread felixcheung
GitHub user felixcheung opened a pull request: https://github.com/apache/spark/pull/17512 [SPARK-20196][PYTHON][SQL] update doc for catalog functions, pyspark refreshByPath API ## What changes were proposed in this pull request? Update doc to remove external for

[GitHub] spark issue #17487: [Spark-20145] Fix range case insensitive bug in SQL

2017-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17487 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75462/ Test PASSed. ---

[GitHub] spark issue #17487: [Spark-20145] Fix range case insensitive bug in SQL

2017-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17487 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17487: [Spark-20145] Fix range case insensitive bug in SQL

2017-04-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17487 **[Test build #75462 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75462/testReport)** for PR 17487 at commit

[GitHub] spark issue #17511: [SPARK-20195][SPARKR][SQL] add createTable catalog API a...

2017-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17511 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75465/ Test FAILed. ---

[GitHub] spark issue #17511: [SPARK-20195][SPARKR][SQL] add createTable catalog API a...

2017-04-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17511 **[Test build #75465 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75465/testReport)** for PR 17511 at commit

[GitHub] spark issue #17511: [SPARK-20195][SPARKR][SQL] add createTable catalog API a...

2017-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17511 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17511: [SPARK-20195][SPARKR][SQL] add createTable catalog API a...

2017-04-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17511 **[Test build #75465 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75465/testReport)** for PR 17511 at commit

[GitHub] spark pull request #17511: [SPARK-20195][SPARKR][SQL] add createTable catalo...

2017-04-02 Thread felixcheung
GitHub user felixcheung opened a pull request: https://github.com/apache/spark/pull/17511 [SPARK-20195][SPARKR][SQL] add createTable catalog API and deprecate createExternalTable ## What changes were proposed in this pull request? Following up on #17483, add createTable

[GitHub] spark pull request #17483: [SPARK-20159][SPARKR][SQL] Support all catalog AP...

2017-04-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/17483 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #17483: [SPARK-20159][SPARKR][SQL] Support all catalog API in R

2017-04-02 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/17483 merged to master. thanks for the review! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #17510: [SPARK-20194] Add support for partition pruning to in-me...

2017-04-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17510 **[Test build #75464 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75464/testReport)** for PR 17510 at commit

[GitHub] spark issue #17510: [SPARK-20194] Add support for partition pruning to in-me...

2017-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17510 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17510: [SPARK-20194] Add support for partition pruning to in-me...

2017-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17510 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75461/ Test PASSed. ---

[GitHub] spark issue #17510: [SPARK-20194] Add support for partition pruning to in-me...

2017-04-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17510 **[Test build #75461 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75461/testReport)** for PR 17510 at commit

[GitHub] spark issue #17487: [Spark-20145] Fix range case insensitive bug in SQL

2017-04-02 Thread samelamin
Github user samelamin commented on the issue: https://github.com/apache/spark/pull/17487 FYI I can squash these commits to clean up the history once we agree on how best to approach the testing --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark issue #17487: [Spark-20145] Fix range case insensitive bug in SQL

2017-04-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17487 **[Test build #75463 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75463/testReport)** for PR 17487 at commit

[GitHub] spark issue #17510: [SPARK-20194] Add support for partition pruning to in-me...

2017-04-02 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/17510 Not related to this PR. It sounds like we have a bug in `HiveTableScans`. The predicate orders matter. We should not prune the partitions if there exists non-deterministic predicates that place

[GitHub] spark issue #17487: [Spark-20145] Fix range case insensitive bug in SQL

2017-04-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17487 **[Test build #75462 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75462/testReport)** for PR 17487 at commit

[GitHub] spark pull request #17510: [SPARK-20194] Add support for partition pruning t...

2017-04-02 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17510#discussion_r109314055 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalogUtils.scala --- @@ -125,6 +126,37 @@ object

[GitHub] spark pull request #17510: [SPARK-20194] Add support for partition pruning t...

2017-04-02 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17510#discussion_r109313930 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalogSuite.scala --- @@ -436,6 +438,37 @@ abstract class

[GitHub] spark pull request #17510: [SPARK-20194] Add support for partition pruning t...

2017-04-02 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17510#discussion_r109313904 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalogUtils.scala --- @@ -125,6 +126,37 @@ object

[GitHub] spark issue #17487: [Spark-20145] Fix range case insensitive bug in SQL

2017-04-02 Thread samelamin
Github user samelamin commented on the issue: https://github.com/apache/spark/pull/17487 Maybe @gatorsmile or @srowen have an idea. How can I test the case insensitive unresolvedTableValuedFunction without using a var for the functionName. I'm open to all ideas folks! introducing a

[GitHub] spark issue #17510: [SPARK-20194] Add support for partition pruning to in-me...

2017-04-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17510 **[Test build #75461 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75461/testReport)** for PR 17510 at commit

[GitHub] spark issue #17510: [SPARK-20194] Add support for partition pruning to in-me...

2017-04-02 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/17510 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] spark pull request #17394: [SPARK-20067] [SQL] Unify and Clean Up Desc Comma...

2017-04-02 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17394#discussion_r109311325 --- Diff: sql/core/src/test/resources/sql-tests/results/describe.sql.out --- @@ -1,205 +1,259 @@ -- Automatically generated by SQLQueryTestSuite

[GitHub] spark issue #17510: [SPARK-20194] Add support for partition pruning to in-me...

2017-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17510 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #17481: [SPARK-20157]In the menu ‘Storage’in Web UI, click t...

2017-04-02 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/17481 I'm sorry I still don't understand the issue. In your example, you just hit 'back' to go back from an unpaged view to paged. I think this should be closed given feedback. --- If your project is

[GitHub] spark pull request #17496: [SPARK-20173][SQL][hive-thriftserver] Throw NullP...

2017-04-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/17496 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

  1   2   >