[GitHub] spark issue #17679: [SPARK-20356][SQL] Pruned InMemoryTableScanExec should h...

2017-04-18 Thread dilipbiswal
Github user dilipbiswal commented on the issue: https://github.com/apache/spark/pull/17679 @viirya Thank you for a quick fix. The change looks good to me. I have a question. Before the fix, we changed the output partitioning of relation's child. But how come it was not reflected on

[GitHub] spark issue #17679: [SPARK-20356][SQL] Pruned InMemoryTableScanExec should h...

2017-04-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17679 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17679: [SPARK-20356][SQL] Pruned InMemoryTableScanExec should h...

2017-04-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17679 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75926/ Test PASSed. ---

[GitHub] spark issue #17679: [SPARK-20356][SQL] Pruned InMemoryTableScanExec should h...

2017-04-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17679 **[Test build #75926 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75926/testReport)** for PR 17679 at commit

[GitHub] spark issue #17679: [SPARK-20356][SQL] Pruned InMemoryTableScanExec should h...

2017-04-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17679 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75927/ Test PASSed. ---

[GitHub] spark issue #17679: [SPARK-20356][SQL] Pruned InMemoryTableScanExec should h...

2017-04-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17679 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17679: [SPARK-20356][SQL] Pruned InMemoryTableScanExec should h...

2017-04-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17679 **[Test build #75927 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75927/testReport)** for PR 17679 at commit

[GitHub] spark issue #17251: [SPARK-19910][SQL] `stack` should not reject NULL values...

2017-04-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17251 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75925/ Test PASSed. ---

[GitHub] spark issue #17251: [SPARK-19910][SQL] `stack` should not reject NULL values...

2017-04-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17251 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17251: [SPARK-19910][SQL] `stack` should not reject NULL values...

2017-04-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17251 **[Test build #75925 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75925/testReport)** for PR 17251 at commit

[GitHub] spark issue #17660: [SPARK-20359][SQL] Avoid unnecessary execution in Elimin...

2017-04-18 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/17660 As we don't know the details of UDF, shall we skip UDF for `canFilterOutNull` and directly return false? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request #17665: [SPARK-16742] Mesos Kerberos Support

2017-04-18 Thread mgummelt
Github user mgummelt commented on a diff in the pull request: https://github.com/apache/spark/pull/17665#discussion_r112117272 --- Diff: resource-managers/yarn/src/test/resources/META-INF/services/org.apache.spark.deploy.yarn.security.ServiceCredentialProvider --- @@ -1 +0,0 @@

[GitHub] spark issue #17669: [SPARK-20343][BUILD] Avoid Unidoc build only if Hadoop 2...

2017-04-18 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/17669 @srowen, could you take a look please? I think this is a simplest temp fix but might look a bit funny though. --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark issue #17669: [SPARK-20343][BUILD] Avoid Unidoc build only if Hadoop 2...

2017-04-18 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/17669 @srowen, could you take a look please? I think this is a simplest temp fix might look a bit funny though. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request #17660: [SPARK-20359][SQL] Avoid unnecessary execution in...

2017-04-18 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/17660#discussion_r112117203 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/joins.scala --- @@ -134,8 +134,8 @@ case class EliminateOuterJoin(conf:

[GitHub] spark pull request #17191: [SPARK-14471][SQL] Aliases in SELECT could be use...

2017-04-18 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/17191#discussion_r112116955 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -2349,7 +2350,22 @@ class Analyzer( }

[GitHub] spark issue #17669: [SPARK-20343][BUILD] Avoid Unidoc build only if Hadoop 2...

2017-04-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17669 **[Test build #75929 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75929/testReport)** for PR 17669 at commit

[GitHub] spark pull request #17191: [SPARK-14471][SQL] Aliases in SELECT could be use...

2017-04-18 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/17191#discussion_r112115780 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -2349,7 +2350,26 @@ class Analyzer( }

[GitHub] spark pull request #17191: [SPARK-14471][SQL] Aliases in SELECT could be use...

2017-04-18 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/17191#discussion_r112115405 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -2349,7 +2350,22 @@ class Analyzer( }

[GitHub] spark issue #17191: [SPARK-14471][SQL] Aliases in SELECT could be used in GR...

2017-04-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17191 **[Test build #75928 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75928/testReport)** for PR 17191 at commit

[GitHub] spark pull request #17191: [SPARK-14471][SQL] Aliases in SELECT could be use...

2017-04-18 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/17191#discussion_r112114553 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -2349,7 +2350,26 @@ class Analyzer( }

[GitHub] spark pull request #17191: [SPARK-14471][SQL] Aliases in SELECT could be use...

2017-04-18 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/17191#discussion_r112114110 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -1003,6 +1009,8 @@ class SQLConf extends Serializable with Logging

[GitHub] spark issue #17495: [SPARK-20172][Core] Add file permission check when listi...

2017-04-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17495 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17495: [SPARK-20172][Core] Add file permission check when listi...

2017-04-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17495 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75924/ Test PASSed. ---

[GitHub] spark issue #17495: [SPARK-20172][Core] Add file permission check when listi...

2017-04-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17495 **[Test build #75924 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75924/testReport)** for PR 17495 at commit

[GitHub] spark pull request #17191: [SPARK-14471][SQL] Aliases in SELECT could be use...

2017-04-18 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/17191#discussion_r112111971 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -2349,7 +2350,26 @@ class Analyzer( }

[GitHub] spark pull request #17191: [SPARK-14471][SQL] Aliases in SELECT could be use...

2017-04-18 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/17191#discussion_r112111734 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -1003,6 +1009,8 @@ class SQLConf extends Serializable with Logging

[GitHub] spark pull request #17191: [SPARK-14471][SQL] Aliases in SELECT could be use...

2017-04-18 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/17191#discussion_r112110655 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -161,6 +161,8 @@ class Analyzer(

[GitHub] spark pull request #17596: [SPARK-12837][CORE] Do not send the accumulator n...

2017-04-18 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/17596#discussion_r112110181 --- Diff: core/src/main/scala/org/apache/spark/executor/TaskMetrics.scala --- @@ -308,16 +305,17 @@ private[spark] object TaskMetrics extends Logging {

[GitHub] spark issue #16609: [SPARK-8480] [CORE] [PYSPARK] [SPARKR] Add setName for D...

2017-04-18 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/16609 ok, are we closing this one? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #17679: [SPARK-20356][SQL] Pruned InMemoryTableScanExec should h...

2017-04-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17679 **[Test build #75927 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75927/testReport)** for PR 17679 at commit

[GitHub] spark issue #17640: [SPARK-17608][SPARKR]:Long type has incorrect serializat...

2017-04-18 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/17640 @wangmiao1981 do you want to get this into 2.2? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request #17191: [SPARK-14471][SQL] Aliases in SELECT could be use...

2017-04-18 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/17191#discussion_r112109737 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -421,6 +421,12 @@ object SQLConf { .booleanConf

[GitHub] spark pull request #17191: [SPARK-14471][SQL] Aliases in SELECT could be use...

2017-04-18 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/17191#discussion_r112106597 --- Diff: sql/core/src/test/resources/sql-tests/inputs/group-by.sql --- @@ -35,3 +35,18 @@ FROM testData; -- Aggregate with foldable input and

[GitHub] spark pull request #17191: [SPARK-14471][SQL] Aliases in SELECT could be use...

2017-04-18 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/17191#discussion_r112109609 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisErrorSuite.scala --- @@ -164,7 +164,7 @@ class AnalysisErrorSuite

[GitHub] spark issue #17679: [SPARK-20356][SQL] Pruned InMemoryTableScanExec should h...

2017-04-18 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/17679 cc @cloud-fan @hvanhovell @dilipbiswal --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17679: [SPARK-20356][SQL] Pruned InMemoryTableScanExec should h...

2017-04-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17679 **[Test build #75926 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75926/testReport)** for PR 17679 at commit

[GitHub] spark pull request #17679: [SPARK-20356][SQL] Pruned InMemoryTableScanExec s...

2017-04-18 Thread viirya
GitHub user viirya opened a pull request: https://github.com/apache/spark/pull/17679 [SPARK-20356][SQL] Pruned InMemoryTableScanExec should have correct output partitioning and ordering ## What changes were proposed in this pull request? The output of

[GitHub] spark issue #15125: [SPARK-5484][GraphX] Periodically do checkpoint in Prege...

2017-04-18 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/15125 I think we want to bring GraphFrames to feature/performance parity with GraphX - @mallman would love to understand the challenges you have run into. Better yet, would be great to get some

[GitHub] spark pull request #15125: [SPARK-5484][GraphX] Periodically do checkpoint i...

2017-04-18 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/15125#discussion_r112108440 --- Diff: core/src/main/scala/org/apache/spark/util/PeriodicCheckpointer.scala --- @@ -128,6 +128,16 @@ private[mllib] abstract class

[GitHub] spark pull request #15125: [SPARK-5484][GraphX] Periodically do checkpoint i...

2017-04-18 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/15125#discussion_r112108549 --- Diff: core/src/main/scala/org/apache/spark/util/PeriodicRDDCheckpointer.scala --- @@ -15,7 +15,7 @@ * limitations under the License. */

[GitHub] spark pull request #15125: [SPARK-5484][GraphX] Periodically do checkpoint i...

2017-04-18 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/15125#discussion_r112108759 --- Diff: graphx/src/main/scala/org/apache/spark/graphx/Pregel.scala --- @@ -122,27 +125,39 @@ object Pregel extends Logging {

[GitHub] spark pull request #15125: [SPARK-5484][GraphX] Periodically do checkpoint i...

2017-04-18 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/15125#discussion_r112108958 --- Diff: graphx/src/main/scala/org/apache/spark/graphx/util/PeriodicGraphCheckpointer.scala --- @@ -87,10 +87,10 @@ private[mllib] class

[GitHub] spark issue #17251: [SPARK-19910][SQL] `stack` should not reject NULL values...

2017-04-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17251 **[Test build #75925 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75925/testReport)** for PR 17251 at commit

[GitHub] spark issue #17251: [SPARK-19910][SQL] `stack` should not reject NULL values...

2017-04-18 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/17251 Retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #17678: [SPARK-20381][SQL] Add SQL metrics of numOutputRows for ...

2017-04-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17678 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request #17678: [SPARK-20381][SQL] Add SQL metrics of numOutputRo...

2017-04-18 Thread yucai
GitHub user yucai opened a pull request: https://github.com/apache/spark/pull/17678 [SPARK-20381][SQL] Add SQL metrics of numOutputRows for ObjectHashAgg… ## What changes were proposed in this pull request? ObjectHashAggregateExec is missing numOutputRows, add this

[GitHub] spark pull request #17191: [SPARK-14471][SQL] Aliases in SELECT could be use...

2017-04-18 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17191#discussion_r112107602 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -161,6 +161,8 @@ class Analyzer(

[GitHub] spark issue #17596: [SPARK-12837][CORE] Do not send the accumulator name to ...

2017-04-18 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/17596 cc @mridulm any more comments on this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request #17568: [SPARK-20254][SQL] Remove unnecessary data conver...

2017-04-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/17568 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #17557: [SPARK-20208][R][DOCS] Document R fpGrowth suppor...

2017-04-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/17557 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #17557: [SPARK-20208][R][DOCS] Document R fpGrowth support

2017-04-18 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/17557 merged to master/2.2 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #17568: [SPARK-20254][SQL] Remove unnecessary data conversion fo...

2017-04-18 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/17568 thanks, merging to master/2.2! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request #17641: [SPARK-20329][SQL] Make timezone aware expression...

2017-04-18 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17641#discussion_r112106741 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/internal/BaseSessionStateBuilder.scala --- @@ -156,6 +156,7 @@ abstract class

[GitHub] spark pull request #17641: [SPARK-20329][SQL] Make timezone aware expression...

2017-04-18 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17641#discussion_r112106631 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala --- @@ -98,11 +98,12 @@ case class

[GitHub] spark pull request #17674: [SPARK-20375][R] R wrappers for array and map

2017-04-18 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/17674#discussion_r112106253 --- Diff: R/pkg/R/functions.R --- @@ -3652,3 +3652,56 @@ setMethod("posexplode", jc <- callJStatic("org.apache.spark.sql.functions",

[GitHub] spark pull request #17674: [SPARK-20375][R] R wrappers for array and map

2017-04-18 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/17674#discussion_r112106499 --- Diff: R/pkg/R/generics.R --- @@ -942,6 +942,14 @@ setGeneric("countDistinct", function(x, ...) { standardGeneric("countDistinct") #' @export

[GitHub] spark pull request #17674: [SPARK-20375][R] R wrappers for array and map

2017-04-18 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/17674#discussion_r112105680 --- Diff: R/pkg/R/functions.R --- @@ -3652,3 +3652,56 @@ setMethod("posexplode", jc <- callJStatic("org.apache.spark.sql.functions",

[GitHub] spark pull request #17641: [SPARK-20329][SQL] Make timezone aware expression...

2017-04-18 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17641#discussion_r112106542 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CastSuite.scala --- @@ -41,13 +41,17 @@ class CastSuite extends

[GitHub] spark pull request #17674: [SPARK-20375][R] R wrappers for array and map

2017-04-18 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/17674#discussion_r112106243 --- Diff: R/pkg/R/functions.R --- @@ -3652,3 +3652,56 @@ setMethod("posexplode", jc <- callJStatic("org.apache.spark.sql.functions",

[GitHub] spark pull request #17674: [SPARK-20375][R] R wrappers for array and map

2017-04-18 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/17674#discussion_r112106399 --- Diff: R/pkg/R/functions.R --- @@ -3652,3 +3652,56 @@ setMethod("posexplode", jc <- callJStatic("org.apache.spark.sql.functions",

[GitHub] spark pull request #17674: [SPARK-20375][R] R wrappers for array and map

2017-04-18 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/17674#discussion_r112106422 --- Diff: R/pkg/R/functions.R --- @@ -3652,3 +3652,56 @@ setMethod("posexplode", jc <- callJStatic("org.apache.spark.sql.functions",

[GitHub] spark pull request #17641: [SPARK-20329][SQL] Make timezone aware expression...

2017-04-18 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17641#discussion_r112106304 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveInlineTables.scala --- @@ -99,12 +99,9 @@ case class

[GitHub] spark pull request #17191: [SPARK-14471][SQL] Aliases in SELECT could be use...

2017-04-18 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/17191#discussion_r112106251 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -161,6 +161,8 @@ class Analyzer(

[GitHub] spark pull request #17641: [SPARK-20329][SQL] Make timezone aware expression...

2017-04-18 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/17641#discussion_r112105799 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveInlineTables.scala --- @@ -99,12 +99,9 @@ case class

[GitHub] spark pull request #17660: [SPARK-20359][SQL] Avoid unnecessary execution in...

2017-04-18 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17660#discussion_r112105721 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/joins.scala --- @@ -134,8 +134,8 @@ case class EliminateOuterJoin(conf:

[GitHub] spark pull request #17672: [SPARK-20371][R] Add wrappers for collect_list an...

2017-04-18 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/17672#discussion_r112105361 --- Diff: R/pkg/R/functions.R --- @@ -3652,3 +3652,43 @@ setMethod("posexplode", jc <- callJStatic("org.apache.spark.sql.functions",

[GitHub] spark pull request #17672: [SPARK-20371][R] Add wrappers for collect_list an...

2017-04-18 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/17672#discussion_r112105500 --- Diff: R/pkg/inst/tests/testthat/test_sparkSQL.R --- @@ -1714,6 +1714,28 @@ test_that("group by, agg functions", { expect_true(abs(sd(1:2) -

[GitHub] spark pull request #17672: [SPARK-20371][R] Add wrappers for collect_list an...

2017-04-18 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/17672#discussion_r112105477 --- Diff: R/pkg/R/generics.R --- @@ -918,6 +918,14 @@ setGeneric("cbrt", function(x) { standardGeneric("cbrt") }) #' @export

[GitHub] spark pull request #17672: [SPARK-20371][R] Add wrappers for collect_list an...

2017-04-18 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/17672#discussion_r112105238 --- Diff: R/pkg/R/functions.R --- @@ -3652,3 +3652,43 @@ setMethod("posexplode", jc <- callJStatic("org.apache.spark.sql.functions",

[GitHub] spark pull request #17191: [SPARK-14471][SQL] Aliases in SELECT could be use...

2017-04-18 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17191#discussion_r112105346 --- Diff: sql/core/src/test/resources/sql-tests/inputs/group-by.sql --- @@ -35,3 +35,18 @@ FROM testData; -- Aggregate with foldable input and

[GitHub] spark pull request #17191: [SPARK-14471][SQL] Aliases in SELECT could be use...

2017-04-18 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17191#discussion_r112105286 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisErrorSuite.scala --- @@ -164,7 +164,7 @@ class AnalysisErrorSuite

[GitHub] spark pull request #17191: [SPARK-14471][SQL] Aliases in SELECT could be use...

2017-04-18 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17191#discussion_r112105230 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -421,6 +421,12 @@ object SQLConf { .booleanConf

[GitHub] spark pull request #17191: [SPARK-14471][SQL] Aliases in SELECT could be use...

2017-04-18 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17191#discussion_r112105172 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -161,6 +161,8 @@ class Analyzer(

[GitHub] spark pull request #17191: [SPARK-14471][SQL] Aliases in SELECT could be use...

2017-04-18 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17191#discussion_r112105086 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -2349,7 +2350,26 @@ class Analyzer( }

[GitHub] spark issue #17582: [SPARK-20239][Core] Improve HistoryServer's ACL mechanis...

2017-04-18 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/17582 Thanks @tgravescs for your reply. > on the history server I would expect spark.acls.enable=false and spark.history.ui.acls.enable=true, I can see where that could be confusing, perhaps

[GitHub] spark issue #17191: [SPARK-14471][SQL] Aliases in SELECT could be used in GR...

2017-04-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17191 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17191: [SPARK-14471][SQL] Aliases in SELECT could be used in GR...

2017-04-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17191 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75922/ Test PASSed. ---

[GitHub] spark issue #17191: [SPARK-14471][SQL] Aliases in SELECT could be used in GR...

2017-04-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17191 **[Test build #75922 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75922/testReport)** for PR 17191 at commit

[GitHub] spark issue #17191: [SPARK-14471][SQL] Aliases in SELECT could be used in GR...

2017-04-18 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/17191 @gatorsmile Could you check again? Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17191: [SPARK-14471][SQL] Aliases in SELECT could be used in GR...

2017-04-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17191 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75921/ Test PASSed. ---

[GitHub] spark issue #17191: [SPARK-14471][SQL] Aliases in SELECT could be used in GR...

2017-04-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17191 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17191: [SPARK-14471][SQL] Aliases in SELECT could be used in GR...

2017-04-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17191 **[Test build #75921 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75921/testReport)** for PR 17191 at commit

[GitHub] spark issue #17673: [SPARK-20372] [ML] Word2Vec Continuous Bag of Words mode...

2017-04-18 Thread hhbyyh
Github user hhbyyh commented on the issue: https://github.com/apache/spark/pull/17673 Thanks for sharing the work. To help make the review easier, I would recommend: 1. Provide some background info. Is the new algorithm better than the existing one and in which cases?

[GitHub] spark issue #17495: [SPARK-20172][Core] Add file permission check when listi...

2017-04-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17495 **[Test build #75924 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75924/testReport)** for PR 17495 at commit

[GitHub] spark issue #17677: [SPARK-20379][core] Allow reading SSL-related passwords ...

2017-04-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17677 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75920/ Test PASSed. ---

[GitHub] spark issue #17677: [SPARK-20379][core] Allow reading SSL-related passwords ...

2017-04-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17677 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17677: [SPARK-20379][core] Allow reading SSL-related passwords ...

2017-04-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17677 **[Test build #75920 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75920/testReport)** for PR 17677 at commit

[GitHub] spark pull request #17665: [SPARK-16742] Mesos Kerberos Support

2017-04-18 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/17665#discussion_r112096685 --- Diff: resource-managers/yarn/src/test/resources/META-INF/services/org.apache.spark.deploy.yarn.security.ServiceCredentialProvider --- @@ -1 +0,0 @@

[GitHub] spark pull request #17665: [SPARK-16742] Mesos Kerberos Support

2017-04-18 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/17665#discussion_r112096515 --- Diff: resource-managers/yarn/src/test/resources/META-INF/services/org.apache.spark.deploy.yarn.security.ServiceCredentialProvider --- @@ -1 +0,0 @@

[GitHub] spark pull request #17665: [SPARK-16742] Mesos Kerberos Support

2017-04-18 Thread mgummelt
Github user mgummelt commented on a diff in the pull request: https://github.com/apache/spark/pull/17665#discussion_r112096284 --- Diff: resource-managers/yarn/src/test/resources/META-INF/services/org.apache.spark.deploy.yarn.security.ServiceCredentialProvider --- @@ -1 +0,0 @@

[GitHub] spark pull request #17665: [SPARK-16742] Mesos Kerberos Support

2017-04-18 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/17665#discussion_r112095984 --- Diff: resource-managers/yarn/src/test/resources/META-INF/services/org.apache.spark.deploy.yarn.security.ServiceCredentialProvider --- @@ -1 +0,0 @@

[GitHub] spark pull request #17665: [SPARK-16742] Mesos Kerberos Support

2017-04-18 Thread mgummelt
Github user mgummelt commented on a diff in the pull request: https://github.com/apache/spark/pull/17665#discussion_r112095876 --- Diff: resource-managers/yarn/src/test/resources/META-INF/services/org.apache.spark.deploy.yarn.security.ServiceCredentialProvider --- @@ -1 +0,0 @@

[GitHub] spark pull request #17495: [SPARK-20172][Core] Add file permission check whe...

2017-04-18 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/17495#discussion_r112095408 --- Diff: core/src/test/scala/org/apache/spark/deploy/SparkHadoopUtilSuite.scala --- @@ -0,0 +1,83 @@ +/* + * Licensed to the Apache Software

[GitHub] spark issue #13440: [SPARK-15699] [ML] Implement a Chi-Squared test statisti...

2017-04-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13440 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75923/ Test FAILed. ---

[GitHub] spark issue #13440: [SPARK-15699] [ML] Implement a Chi-Squared test statisti...

2017-04-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13440 **[Test build #75923 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75923/testReport)** for PR 13440 at commit

[GitHub] spark issue #13440: [SPARK-15699] [ML] Implement a Chi-Squared test statisti...

2017-04-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13440 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13440: [SPARK-15699] [ML] Implement a Chi-Squared test statisti...

2017-04-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13440 **[Test build #75923 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75923/testReport)** for PR 13440 at commit

[GitHub] spark issue #17665: [SPARK-16742] Mesos Kerberos Support

2017-04-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17665 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75918/ Test FAILed. ---

[GitHub] spark issue #17665: [SPARK-16742] Mesos Kerberos Support

2017-04-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17665 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

  1   2   3   4   >