[GitHub] spark issue #18157: [MINOR][SQL] Fix a few function description error.

2017-05-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18157 **[Test build #77577 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77577/testReport)** for PR 18157 at commit [`50fda83`](https://github.com/apache/spark/commit/50

[GitHub] spark issue #18151: [SPARK-20929][ML] LinearSVC should use its own threshold...

2017-05-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18151 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77574/ Test PASSed. ---

[GitHub] spark issue #18151: [SPARK-20929][ML] LinearSVC should use its own threshold...

2017-05-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18151 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #18151: [SPARK-20929][ML] LinearSVC should use its own threshold...

2017-05-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18151 **[Test build #77574 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77574/testReport)** for PR 18151 at commit [`98ffd16`](https://github.com/apache/spark/commit/9

[GitHub] spark pull request #18157: [MINOR][SQL] Fix a few function description error...

2017-05-30 Thread wangyum
GitHub user wangyum opened a pull request: https://github.com/apache/spark/pull/18157 [MINOR][SQL] Fix a few function description error. ## What changes were proposed in this pull request? Fix a few function description error. ## How was this patch tested?

[GitHub] spark issue #18156: [SPARK-20933][SQL]when the input parameter is float type...

2017-05-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18156 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] spark pull request #18156: [SPARK-20933][SQL]when the input parameter is flo...

2017-05-30 Thread 10110346
GitHub user 10110346 opened a pull request: https://github.com/apache/spark/pull/18156 [SPARK-20933][SQL]when the input parameter is float type,the ’round ’ or ‘bround’ function can't work well ## What changes were proposed in this pull request? spark-sql>select round

[GitHub] spark issue #18108: [SPARK-20884] Spark' masters will be both standby due to...

2017-05-30 Thread liu-zhaokun
Github user liu-zhaokun commented on the issue: https://github.com/apache/spark/pull/18108 @srowen I have tested it in my cluster with modify the version of curator,spark works normally,and the problem I encountered was resolved. --- If your project is set up for it, you can re

[GitHub] spark issue #18151: [SPARK-20929][ML] LinearSVC should use its own threshold...

2017-05-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18151 **[Test build #3769 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3769/testReport)** for PR 18151 at commit [`98ffd16`](https://github.com/apache/spark/commit/9

[GitHub] spark issue #18015: [SAPRK-20785][WEB-UI][SQL]Spark should provide jump link...

2017-05-30 Thread guoxiaolongzte
Github user guoxiaolongzte commented on the issue: https://github.com/apache/spark/pull/18015 @srowen I think the style exists to provide links that jump to Running Queries or Completed Queries because it may be well below the fold if there are many workers.Job page, stage page,

[GitHub] spark issue #18015: [SAPRK-20785][WEB-UI][SQL]Spark should provide jump link...

2017-05-30 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/18015 I don't think those links are worth the vertical space they chew up --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project doe

[GitHub] spark issue #18108: [SPARK-20884] Spark' masters will be both standby due to...

2017-05-30 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/18108 Generally you need to evaluate the impact of updating a minor version of a dependency. Does it cause any compatibility problems? What version does Hadoop use? Does it add new transitive deps? You did

[GitHub] spark pull request #18143: [SPARK-20919][SS] Simplificaiton of CachedKafkaCo...

2017-05-30 Thread ScrapCodes
Github user ScrapCodes commented on a diff in the pull request: https://github.com/apache/spark/pull/18143#discussion_r119277567 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/CachedKafkaConsumer.scala --- @@ -310,62 +308,45 @@ private[kafka010] obj

[GitHub] spark issue #18129: [SPARK-20365][YARN] Remove LocalSchem when add path to C...

2017-05-30 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/18129 CC @vanzin to take a review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #18153: [SPARK-20931][SQL] ABS function support string type.

2017-05-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18153 **[Test build #77576 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77576/testReport)** for PR 18153 at commit [`1b70f29`](https://github.com/apache/spark/commit/1b

[GitHub] spark pull request #18129: [SPARK-20365][YARN] Remove LocalSchem when add pa...

2017-05-30 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/18129#discussion_r119277116 --- Diff: resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/ClientSuite.scala --- @@ -116,15 +116,16 @@ class ClientSuite extends SparkF

[GitHub] spark pull request #17617: [SPARK-20244][Core] Handle incorrect bytesRead me...

2017-05-30 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/17617#discussion_r119276245 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkHadoopUtil.scala --- @@ -143,14 +144,18 @@ class SparkHadoopUtil extends Logging { * Re

[GitHub] spark pull request #17617: [SPARK-20244][Core] Handle incorrect bytesRead me...

2017-05-30 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/17617#discussion_r119275824 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkHadoopUtil.scala --- @@ -143,14 +144,18 @@ class SparkHadoopUtil extends Logging { * Re

[GitHub] spark issue #17113: [SPARK-13669][Core] Improve the blacklist mechanism to h...

2017-05-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17113 **[Test build #77575 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77575/testReport)** for PR 17113 at commit [`9a14105`](https://github.com/apache/spark/commit/9a

[GitHub] spark pull request #12646: [SPARK-14878][SQL] Trim characters string functio...

2017-05-30 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/12646#discussion_r119275552 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala --- @@ -1077,7 +1080,8 @@ class AstBuilder(conf: SQLConf) extends

[GitHub] spark pull request #17617: [SPARK-20244][Core] Handle incorrect bytesRead me...

2017-05-30 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17617#discussion_r119275510 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkHadoopUtil.scala --- @@ -143,14 +144,18 @@ class SparkHadoopUtil extends Logging { * Re

[GitHub] spark pull request #18151: [SPARK-20929][ML] LinearSVC should use its own th...

2017-05-30 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/18151#discussion_r119275319 --- Diff: mllib/src/test/scala/org/apache/spark/ml/classification/LinearSVCSuite.scala --- @@ -127,6 +127,14 @@ class LinearSVCSuite extends SparkFunSuite wi

[GitHub] spark issue #18151: [SPARK-20929][ML] LinearSVC should use its own threshold...

2017-05-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18151 **[Test build #77574 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77574/testReport)** for PR 18151 at commit [`98ffd16`](https://github.com/apache/spark/commit/98

[GitHub] spark pull request #17617: [SPARK-20244][Core] Handle incorrect bytesRead me...

2017-05-30 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17617#discussion_r119275374 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkHadoopUtil.scala --- @@ -143,14 +144,18 @@ class SparkHadoopUtil extends Logging { * Re

[GitHub] spark issue #17603: [SPARK-20288] Avoid generating the MapStatus by stageId ...

2017-05-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17603 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #17603: [SPARK-20288] Avoid generating the MapStatus by stageId ...

2017-05-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17603 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77569/ Test PASSed. ---

[GitHub] spark pull request #18151: [SPARK-20929][ML] LinearSVC should use its own th...

2017-05-30 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/18151#discussion_r119275003 --- Diff: R/pkg/R/mllib_classification.R --- @@ -62,7 +62,7 @@ setClass("NaiveBayesModel", representation(jobj = "jobj")) #'of

[GitHub] spark issue #17603: [SPARK-20288] Avoid generating the MapStatus by stageId ...

2017-05-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17603 **[Test build #77569 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77569/testReport)** for PR 17603 at commit [`831de22`](https://github.com/apache/spark/commit/8

[GitHub] spark issue #18153: [SPARK-20931][SQL] ABS function support string type.

2017-05-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18153 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77571/ Test FAILed. ---

[GitHub] spark issue #18153: [SPARK-20931][SQL] ABS function support string type.

2017-05-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18153 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #18153: [SPARK-20931][SQL] ABS function support string type.

2017-05-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18153 **[Test build #77571 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77571/testReport)** for PR 18153 at commit [`209dbaf`](https://github.com/apache/spark/commit/2

[GitHub] spark pull request #17617: [SPARK-20244][Core] Handle incorrect bytesRead me...

2017-05-30 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17617#discussion_r119274153 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkHadoopUtil.scala --- @@ -143,14 +144,18 @@ class SparkHadoopUtil extends Logging { * Re

[GitHub] spark pull request #18104: [SPARK-20877][SPARKR][WIP] add timestamps to test...

2017-05-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/18104 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark issue #17617: [SPARK-20244][Core] Handle incorrect bytesRead metrics w...

2017-05-30 Thread jiangxb1987
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/17617 LGTM, cc @cloud-fan @ueshin --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #17617: [SPARK-20244][Core] Handle incorrect bytesRead metrics w...

2017-05-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17617 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #17617: [SPARK-20244][Core] Handle incorrect bytesRead metrics w...

2017-05-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17617 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77567/ Test PASSed. ---

[GitHub] spark issue #17617: [SPARK-20244][Core] Handle incorrect bytesRead metrics w...

2017-05-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17617 **[Test build #77567 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77567/testReport)** for PR 17617 at commit [`8b16017`](https://github.com/apache/spark/commit/8

[GitHub] spark issue #18147: [SPARK-19236][SQL][FOLLOW-UP] Added createOrReplaceGloba...

2017-05-30 Thread ueshin
Github user ueshin commented on the issue: https://github.com/apache/spark/pull/18147 LGTM except for @cloud-fan's comment. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabl

[GitHub] spark issue #18154: [SPARK-20932][ML]CountVectorizer support handle persiste...

2017-05-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18154 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #18154: [SPARK-20932][ML]CountVectorizer support handle persiste...

2017-05-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18154 **[Test build #77572 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77572/testReport)** for PR 18154 at commit [`f7c5442`](https://github.com/apache/spark/commit/f

[GitHub] spark issue #18154: [SPARK-20932][ML]CountVectorizer support handle persiste...

2017-05-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18154 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77572/ Test PASSed. ---

[GitHub] spark pull request #18118: SPARK-20199 : Provided featureSubsetStrategy to G...

2017-05-30 Thread mpjlu
Github user mpjlu commented on a diff in the pull request: https://github.com/apache/spark/pull/18118#discussion_r119271935 --- Diff: project/MimaExcludes.scala --- @@ -37,11 +37,15 @@ object MimaExcludes { // Exclude rules for 2.3.x lazy val v23excludes = v22excludes

[GitHub] spark issue #18104: [SPARK-20877][SPARKR][WIP] add timestamps to test runs

2017-05-30 Thread shivaram
Github user shivaram commented on the issue: https://github.com/apache/spark/pull/18104 LGTM. Thanks @felixcheung for the update and @marmbrus for the ping --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project d

[GitHub] spark pull request #18118: SPARK-20199 : Provided featureSubsetStrategy to G...

2017-05-30 Thread mpjlu
Github user mpjlu commented on a diff in the pull request: https://github.com/apache/spark/pull/18118#discussion_r119271662 --- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/treeParams.scala --- @@ -441,12 +415,44 @@ private[ml] trait RandomForestParams extends TreeEnsemblePa

[GitHub] spark pull request #18118: SPARK-20199 : Provided featureSubsetStrategy to G...

2017-05-30 Thread mpjlu
Github user mpjlu commented on a diff in the pull request: https://github.com/apache/spark/pull/18118#discussion_r119271607 --- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/treeParams.scala --- @@ -420,18 +394,18 @@ private[ml] trait RandomForestParams extends TreeEnsemblePa

[GitHub] spark pull request #18118: SPARK-20199 : Provided featureSubsetStrategy to G...

2017-05-30 Thread mpjlu
Github user mpjlu commented on a diff in the pull request: https://github.com/apache/spark/pull/18118#discussion_r119271552 --- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/treeParams.scala --- @@ -305,7 +305,7 @@ private[ml] object TreeRegressorParams { } pri

[GitHub] spark pull request #18153: [SPARK-20931][SQL] ABS function support string ty...

2017-05-30 Thread wangyum
Github user wangyum commented on a diff in the pull request: https://github.com/apache/spark/pull/18153#discussion_r119271567 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala --- @@ -97,20 +97,30 @@ case class UnaryPositive(child: Ex

[GitHub] spark pull request #18086: [SPARK-20854][SQL] Extend hint syntax to support ...

2017-05-30 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/18086#discussion_r119271262 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala --- @@ -533,13 +533,16 @@ class AstBuilder(conf: SQLConf) extends

[GitHub] spark pull request #18118: SPARK-20199 : Provided featureSubsetStrategy to G...

2017-05-30 Thread mpjlu
Github user mpjlu commented on a diff in the pull request: https://github.com/apache/spark/pull/18118#discussion_r119271063 --- Diff: mllib/src/main/scala/org/apache/spark/ml/regression/DecisionTreeRegressor.scala --- @@ -99,6 +99,8 @@ class DecisionTreeRegressor @Since("1.4.0")

[GitHub] spark pull request #18118: SPARK-20199 : Provided featureSubsetStrategy to G...

2017-05-30 Thread mpjlu
Github user mpjlu commented on a diff in the pull request: https://github.com/apache/spark/pull/18118#discussion_r119270999 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/GBTClassifier.scala --- @@ -136,12 +136,20 @@ class GBTClassifier @Since("1.4.0") ( @

[GitHub] spark issue #18118: SPARK-20199 : Provided featureSubsetStrategy to GBTClass...

2017-05-30 Thread pralabhkumar
Github user pralabhkumar commented on the issue: https://github.com/apache/spark/pull/18118 can any one of admin ,please review the pull request. It would be really helpful. Thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHu

[GitHub] spark issue #18155: [SPARK-20876][SQL][Backport-2.2]If the input parameter i...

2017-05-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18155 **[Test build #77573 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77573/testReport)** for PR 18155 at commit [`5ab4a96`](https://github.com/apache/spark/commit/5a

[GitHub] spark issue #18155: [SPARK-20876][SQL][Backport-2.2]If the input parameter i...

2017-05-30 Thread ueshin
Github user ueshin commented on the issue: https://github.com/apache/spark/pull/18155 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark pull request #12646: [SPARK-14878][SQL] Trim characters string functio...

2017-05-30 Thread kevinyu98
Github user kevinyu98 commented on a diff in the pull request: https://github.com/apache/spark/pull/12646#discussion_r119269498 --- Diff: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 --- @@ -569,7 +569,9 @@ primaryExpression | '(' namedExpre

[GitHub] spark pull request #12646: [SPARK-14878][SQL] Trim characters string functio...

2017-05-30 Thread kevinyu98
Github user kevinyu98 commented on a diff in the pull request: https://github.com/apache/spark/pull/12646#discussion_r119269209 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala --- @@ -1077,7 +1080,8 @@ class AstBuilder(conf: SQLConf) ext

[GitHub] spark pull request #18153: [SPARK-20931][SQL] ABS function support string ty...

2017-05-30 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/18153#discussion_r119269154 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala --- @@ -97,20 +97,30 @@ case class UnaryPositive(child: Expr

[GitHub] spark issue #18152: [SPARK-20930][ML] Destroy broadcasted centers after comp...

2017-05-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18152 **[Test build #77570 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77570/testReport)** for PR 18152 at commit [`3736992`](https://github.com/apache/spark/commit/3

[GitHub] spark issue #18152: [SPARK-20930][ML] Destroy broadcasted centers after comp...

2017-05-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18152 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #18152: [SPARK-20930][ML] Destroy broadcasted centers after comp...

2017-05-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18152 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77570/ Test PASSed. ---

[GitHub] spark pull request #18086: [SPARK-20854][SQL] Extend hint syntax to support ...

2017-05-30 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18086#discussion_r119268299 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameHintSuite.scala --- @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Found

[GitHub] spark issue #18155: [SPARK-20876][SQL][Backport-2.2]If the input parameter i...

2017-05-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18155 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] spark issue #17770: [SPARK-20392][SQL] Set barrier to prevent re-entering a ...

2017-05-30 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/17770 reverted, thanks for your understanding! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #18155: [SPARK-20876][SQL][Backport-2.2]If the input para...

2017-05-30 Thread 10110346
GitHub user 10110346 opened a pull request: https://github.com/apache/spark/pull/18155 [SPARK-20876][SQL][Backport-2.2]If the input parameter is float type for ceil or floor,the result is not we expected ## What changes were proposed in this pull request? This PR is to back

[GitHub] spark issue #18154: [SPARK-20932][ML]CountVectorizer support handle persiste...

2017-05-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18154 **[Test build #77572 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77572/testReport)** for PR 18154 at commit [`f7c5442`](https://github.com/apache/spark/commit/f7

[GitHub] spark pull request #18147: [SPARK-19236][SQL][FOLLOW-UP] Added createOrRepla...

2017-05-30 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18147#discussion_r119267756 --- Diff: python/pyspark/sql/dataframe.py --- @@ -191,6 +191,23 @@ def createGlobalTempView(self, name): """ self._jdf.createGlob

[GitHub] spark pull request #18086: [SPARK-20854][SQL] Extend hint syntax to support ...

2017-05-30 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18086#discussion_r119267579 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala --- @@ -407,7 +407,7 @@ class AstBuilder(conf: SQLConf) exten

[GitHub] spark pull request #18086: [SPARK-20854][SQL] Extend hint syntax to support ...

2017-05-30 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18086#discussion_r119267472 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameHintSuite.scala --- @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Found

[GitHub] spark pull request #18154: [SPARK-20932][ML]CountVectorizer support handle p...

2017-05-30 Thread zhengruifeng
GitHub user zhengruifeng opened a pull request: https://github.com/apache/spark/pull/18154 [SPARK-20932][ML]CountVectorizer support handle persistence ## What changes were proposed in this pull request? unpersist RDDs `input` & `wordCounts` after computation ## How was t

[GitHub] spark pull request #18086: [SPARK-20854][SQL] Extend hint syntax to support ...

2017-05-30 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18086#discussion_r119266987 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/PlanParserSuite.scala --- @@ -525,47 +525,117 @@ class PlanParserSuite extends

[GitHub] spark pull request #18086: [SPARK-20854][SQL] Extend hint syntax to support ...

2017-05-30 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18086#discussion_r119266645 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/DSLHintSuite.scala --- @@ -0,0 +1,59 @@ +/* + * Licensed to the Apac

[GitHub] spark pull request #18086: [SPARK-20854][SQL] Extend hint syntax to support ...

2017-05-30 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18086#discussion_r119266598 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/DSLHintSuite.scala --- @@ -0,0 +1,59 @@ +/* + * Licensed to the Apac

[GitHub] spark pull request #18086: [SPARK-20854][SQL] Extend hint syntax to support ...

2017-05-30 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18086#discussion_r119266605 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/DSLHintSuite.scala --- @@ -0,0 +1,59 @@ +/* + * Licensed to the Apac

[GitHub] spark issue #18147: [SPARK-19236][SQL][FOLLOW-UP] Added createOrReplaceGloba...

2017-05-30 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/18147 cc @cloud-fan @ueshin --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wish

[GitHub] spark issue #18153: [SPARK-20931][SQL] ABS function support string type.

2017-05-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18153 **[Test build #77571 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77571/testReport)** for PR 18153 at commit [`209dbaf`](https://github.com/apache/spark/commit/20

[GitHub] spark pull request #18153: [SPARK-20931][SQL] ABS function support string ty...

2017-05-30 Thread wangyum
GitHub user wangyum opened a pull request: https://github.com/apache/spark/pull/18153 [SPARK-20931][SQL] ABS function support string type. ## What changes were proposed in this pull request? ABS function support string type. Hive/MySQL support this feature. Ref: ht

[GitHub] spark pull request #12646: [SPARK-14878][SQL] Trim characters string functio...

2017-05-30 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/12646#discussion_r119265202 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala --- @@ -1077,7 +1080,8 @@ class AstBuilder(conf: SQLConf) extends

[GitHub] spark pull request #12646: [SPARK-14878][SQL] Trim characters string functio...

2017-05-30 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/12646#discussion_r119265297 --- Diff: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 --- @@ -569,7 +569,9 @@ primaryExpression | '(' namedExpressio

[GitHub] spark issue #17936: [SPARK-20638][Core]Optimize the CartesianRDD to reduce r...

2017-05-30 Thread ConeyLiu
Github user ConeyLiu commented on the issue: https://github.com/apache/spark/pull/17936 Hi @rxin, would you mind take a look? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enab

[GitHub] spark issue #17995: [SPARK-20762][ML]Make String Params Case-Insensitive

2017-05-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17995 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #17995: [SPARK-20762][ML]Make String Params Case-Insensitive

2017-05-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17995 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77568/ Test PASSed. ---

[GitHub] spark issue #17995: [SPARK-20762][ML]Make String Params Case-Insensitive

2017-05-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17995 **[Test build #77568 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77568/testReport)** for PR 17995 at commit [`0db3a52`](https://github.com/apache/spark/commit/0

[GitHub] spark issue #17770: [SPARK-20392][SQL] Set barrier to prevent re-entering a ...

2017-05-30 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/17770 @cloud-fan Ok. No problem for me. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature en

[GitHub] spark issue #17770: [SPARK-20392][SQL] Set barrier to prevent re-entering a ...

2017-05-30 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/17770 Hi @viirya , as this PR already missed the Spark 2.2 release, I'd like to revert it and re-merge it at the end of Spark 2.3, so that future analyzer related PRs won't get conflicted when backporti

[GitHub] spark pull request #17588: [SPARK-20275][UI] Do not display "Completed" colu...

2017-05-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/17588 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark issue #17588: [SPARK-20275][UI] Do not display "Completed" column for ...

2017-05-30 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/17588 LGTM, merging to master/2.2! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #18104: [SPARK-20877][SPARKR][WIP] add timestamps to test runs

2017-05-30 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/18104 ok passes. @shivaram what do you think about this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have t

[GitHub] spark pull request #18139: [SPARK-20787][PYTHON] PySpark can't handle dateti...

2017-05-30 Thread facaiy
Github user facaiy commented on a diff in the pull request: https://github.com/apache/spark/pull/18139#discussion_r119263608 --- Diff: python/pyspark/sql/types.py --- @@ -187,8 +187,11 @@ def needConversion(self): def toInternal(self, dt): if dt is not No

[GitHub] spark issue #18152: [SPARK-20930][ML] Destroy broadcasted centers after comp...

2017-05-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18152 **[Test build #77570 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77570/testReport)** for PR 18152 at commit [`3736992`](https://github.com/apache/spark/commit/37

[GitHub] spark pull request #17998: [SPARK-20703][SQL][WIP] Add an operator for writi...

2017-05-30 Thread viirya
Github user viirya closed the pull request at: https://github.com/apache/spark/pull/17998 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark issue #17998: [SPARK-20703][SQL][WIP] Add an operator for writing data...

2017-05-30 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/17998 #18064 is merged. Since it changes relative classes and code paths a lot. And seems an alternative approach for showing the metrics of writing data out is better. I'd close this and create a new PR f

[GitHub] spark pull request #18152: [SPARK-20930][ML] Destroy broadcasted centers aft...

2017-05-30 Thread zhengruifeng
GitHub user zhengruifeng opened a pull request: https://github.com/apache/spark/pull/18152 [SPARK-20930][ML] Destroy broadcasted centers after computing cost in KMeans ## What changes were proposed in this pull request? Destroy broadcasted centers after computing cost ## H

[GitHub] spark pull request #18064: [SPARK-20213][SQL] Fix DataFrameWriter operations...

2017-05-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/18064 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request #17540: [SPARK-20213][SQL][UI] Fix DataFrameWriter operat...

2017-05-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/17540 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark issue #18064: [SPARK-20213][SQL] Fix DataFrameWriter operations in SQL...

2017-05-30 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/18064 thanks for the review, merging to master! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18041: [SPARK-20816][CORE] MetricsConfig doen't trim the proper...

2017-05-30 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/18041 @srowen , this issue existed when reading from metrics.properties conf file, I think we should fix this part. As for SparkConf part, I don't think it is necessary to fix. --- If your project is

[GitHub] spark pull request #12646: [SPARK-14878][SQL] Trim characters string functio...

2017-05-30 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/12646#discussion_r119261589 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala --- @@ -2616,4 +2617,66 @@ class SQLQuerySuite extends QueryTest with SharedSQLCon

[GitHub] spark pull request #12646: [SPARK-14878][SQL] Trim characters string functio...

2017-05-30 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/12646#discussion_r119261484 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -461,68 +462,269 @@ case class FindInSet(left:

[GitHub] spark issue #18120: [SPARK-20498][PYSPARK][ML] Expose getMaxDepth for ensemb...

2017-05-30 Thread facaiy
Github user facaiy commented on the issue: https://github.com/apache/spark/pull/18120 Thanks, @BryanCutler. It seems that #17849 copys `Params` from `Estimator` to `Model` automatically, which is pretty useful. However, `getter` method is still missing and need to be added manuall

[GitHub] spark issue #17603: [SPARK-20288] Avoid generating the MapStatus by stageId ...

2017-05-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17603 **[Test build #77569 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77569/testReport)** for PR 17603 at commit [`831de22`](https://github.com/apache/spark/commit/83

[GitHub] spark issue #17603: [SPARK-20288] Avoid generating the MapStatus by stageId ...

2017-05-30 Thread jinxing64
Github user jinxing64 commented on the issue: https://github.com/apache/spark/pull/17603 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

  1   2   3   4   5   >