Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/18322
@jiangxb1987 can you please help to review this PR? This is a simple code
improvement to avoid some unnecessary code execution when left cores is not
enough for one executor.
I don't
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17113
**[Test build #78431 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78431/testReport)**
for PR 17113 at commit
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/17113
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/9518#discussion_r123420182
--- Diff:
core/src/main/scala/org/apache/spark/metrics/sink/StatsdReporter.scala ---
@@ -0,0 +1,160 @@
+/*
+ * Licensed to the Apache Software
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/9518#discussion_r123425292
--- Diff:
core/src/main/scala/org/apache/spark/metrics/sink/StatsdReporter.scala ---
@@ -0,0 +1,160 @@
+/*
+ * Licensed to the Apache Software
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/9518#discussion_r123424723
--- Diff:
core/src/main/scala/org/apache/spark/metrics/sink/StatsdReporter.scala ---
@@ -0,0 +1,160 @@
+/*
+ * Licensed to the Apache Software
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18371
**[Test build #78430 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78430/testReport)**
for PR 18371 at commit
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18378#discussion_r123425404
--- Diff: python/pyspark/sql/dataframe.py ---
@@ -1721,7 +1721,14 @@ def toPandas(self):
15Bob
"""
import
Github user actuaryzhang commented on a diff in the pull request:
https://github.com/apache/spark/pull/18371#discussion_r123425200
--- Diff: R/pkg/R/functions.R ---
@@ -34,6 +34,30 @@ NULL
#' df <- createDataFrame(cbind(model = rownames(mtcars), mtcars))}
NULL
Github user actuaryzhang commented on the issue:
https://github.com/apache/spark/pull/18371
Made another commit that addresses your comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user actuaryzhang commented on a diff in the pull request:
https://github.com/apache/spark/pull/18371#discussion_r123425179
--- Diff: R/pkg/R/functions.R ---
@@ -1405,18 +1309,12 @@ setMethod("sha1",
column(jc)
})
-#' signum
-#'
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18378
**[Test build #78429 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78429/testReport)**
for PR 18378 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/18378
It sounds ok to me just except missing `_have_pandas = False` above `try:` .
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17519#discussion_r123424505
--- Diff: docs/configuration.md ---
@@ -1004,14 +1004,48 @@ Apart from these, the following properties are also
available, and may be useful
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17519#discussion_r123424493
--- Diff: docs/configuration.md ---
@@ -1004,14 +1004,48 @@ Apart from these, the following properties are also
available, and may be useful
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18382
**[Test build #78428 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78428/testReport)**
for PR 18382 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/18382
Thank you @felixcheung. I checked docs and the same thing in the PR
description.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18162#discussion_r123424121
--- Diff:
core/src/main/scala/org/apache/spark/internal/config/package.scala ---
@@ -295,4 +295,12 @@ package object config {
"above this
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18378
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78427/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18378
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18378
**[Test build #78427 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78427/testReport)**
for PR 18378 at commit
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18162#discussion_r123424029
--- Diff:
core/src/main/scala/org/apache/spark/ui/jobs/JobProgressListener.scala ---
@@ -528,7 +528,13 @@ class JobProgressListener(conf: SparkConf)
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/18377
thanks, merging to 2.2!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/18354
thanks, merging to 2.1!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18362#discussion_r123423356
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala
---
@@ -454,6 +464,12 @@ class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18362#discussion_r123423287
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala ---
@@ -569,6 +569,12 @@ private[spark] class TaskSchedulerImpl
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18362#discussion_r123423207
--- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
---
@@ -1432,6 +1439,26 @@ class DAGScheduler(
}
}
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18384
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18378
**[Test build #78427 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78427/testReport)**
for PR 18378 at commit
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18362#discussion_r123423005
--- Diff: core/src/main/scala/org/apache/spark/deploy/DeployMessage.scala
---
@@ -158,6 +158,8 @@ private[deploy] object DeployMessages {
GitHub user devaraj-kavali opened a pull request:
https://github.com/apache/spark/pull/18384
[SPARK-21170] [CORE] Utils.tryWithSafeFinallyAndFailureCallbacks throws
IllegalArgumentException: Self-suppression not permitted
## What changes were proposed in this pull request?
Github user pralabhkumar commented on a diff in the pull request:
https://github.com/apache/spark/pull/18118#discussion_r123422892
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/GBTClassifier.scala ---
@@ -192,6 +196,9 @@ object GBTClassifier extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15417#discussion_r12342
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisTest.scala
---
@@ -55,6 +55,14 @@ trait AnalysisTest extends
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18378
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78426/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18378
**[Test build #78426 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78426/testReport)**
for PR 18378 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18378
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18378
**[Test build #78426 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78426/testReport)**
for PR 18378 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18118
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18118
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78420/
Test PASSed.
---
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/18382#discussion_r123420890
--- Diff: R/pkg/R/context.R ---
@@ -295,6 +295,23 @@ setCheckpointDirSC <- function(sc, dirName) {
invisible(callJMethod(sc, "setCheckpointDir",
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/18382#discussion_r123420666
--- Diff: R/pkg/NAMESPACE ---
@@ -403,6 +403,7 @@ export("as.DataFrame",
"refreshTable",
"setCheckpointDir",
Github user eatoncys commented on a diff in the pull request:
https://github.com/apache/spark/pull/18322#discussion_r123420930
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -258,23 +256,7 @@ private[deploy] class SparkSubmitArguments(args:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18118
**[Test build #78420 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78420/testReport)**
for PR 18118 at commit
Github user eatoncys commented on a diff in the pull request:
https://github.com/apache/spark/pull/18322#discussion_r123420644
--- Diff: core/src/main/scala/org/apache/spark/SparkConf.scala ---
@@ -543,6 +545,42 @@ class SparkConf(loadDefaults: Boolean) extends
Cloneable with
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18300
**[Test build #78425 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78425/testReport)**
for PR 18300 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18347
**[Test build #78424 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78424/testReport)**
for PR 18347 at commit
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/18300#discussion_r123420282
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -1764,6 +1765,70 @@ class Dataset[T] private[sql](
}
/**
Github user eatoncys commented on a diff in the pull request:
https://github.com/apache/spark/pull/18322#discussion_r123420083
--- Diff:
core/src/test/scala/org/apache/spark/deploy/master/MasterSuite.scala ---
@@ -704,6 +707,43 @@ class MasterSuite extends SparkFunSuite
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/18320#discussion_r123417186
--- Diff: R/pkg/inst/worker/daemon.R ---
@@ -47,9 +79,11 @@ while (TRUE) {
close(inputCon)
--- End diff --
please add comment
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/18320#discussion_r123416154
--- Diff: R/pkg/inst/worker/daemon.R ---
@@ -30,8 +30,40 @@ port <- as.integer(Sys.getenv("SPARKR_WORKER_PORT"))
inputCon <- socketConnection(
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/18320#discussion_r123416771
--- Diff: R/pkg/inst/worker/daemon.R ---
@@ -30,8 +30,40 @@ port <- as.integer(Sys.getenv("SPARKR_WORKER_PORT"))
inputCon <- socketConnection(
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/18320#discussion_r123419616
--- Diff: R/pkg/inst/worker/daemon.R ---
@@ -30,8 +30,40 @@ port <- as.integer(Sys.getenv("SPARKR_WORKER_PORT"))
inputCon <- socketConnection(
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/18114#discussion_r123419433
--- Diff: R/pkg/R/functions.R ---
@@ -2414,20 +2396,23 @@ setMethod("from_json", signature(x = "Column",
schema = "structType"),
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/18114#discussion_r123419080
--- Diff: R/pkg/R/functions.R ---
@@ -2414,20 +2396,23 @@ setMethod("from_json", signature(x = "Column",
schema = "structType"),
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/18329#discussion_r123418793
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/streaming/DataStreamWriter.scala
---
@@ -264,12 +281,12 @@ final class DataStreamWriter[T]
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18327
**[Test build #78423 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78423/testReport)**
for PR 18327 at commit
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/18114#discussion_r123416302
--- Diff: R/pkg/R/functions.R ---
@@ -2414,20 +2396,23 @@ setMethod("from_json", signature(x = "Column",
schema = "structType"),
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/18114#discussion_r123416414
--- Diff: R/pkg/R/functions.R ---
@@ -2414,20 +2396,23 @@ setMethod("from_json", signature(x = "Column",
schema = "structType"),
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/18114#discussion_r123417000
--- Diff: R/pkg/R/functions.R ---
@@ -34,6 +34,58 @@ NULL
#' df <- createDataFrame(cbind(model = rownames(mtcars), mtcars))}
NULL
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/18114#discussion_r123416202
--- Diff: R/pkg/R/functions.R ---
@@ -34,6 +34,58 @@ NULL
#' df <- createDataFrame(cbind(model = rownames(mtcars), mtcars))}
NULL
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/18329#discussion_r123417606
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/streaming/DataStreamWriter.scala
---
@@ -235,6 +237,21 @@ final class DataStreamWriter[T]
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/18329#discussion_r123416837
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/streaming/DataStreamWriter.scala
---
@@ -17,8 +17,10 @@
package
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/18300#discussion_r123416779
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -1764,6 +1765,70 @@ class Dataset[T] private[sql](
}
/**
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17713
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78418/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18228
**[Test build #78422 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78422/testReport)**
for PR 18228 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17713
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17713
**[Test build #78418 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78418/testReport)**
for PR 17713 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/18114
@felixcheung, would you give me a moment to double check? I am interested
in this and want to help double check.
---
If your project is set up for it, you can reply to this email and have your
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18382
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78421/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18382
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18382
**[Test build #78421 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78421/testReport)**
for PR 18382 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18383
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/18322#discussion_r123415327
--- Diff: core/src/main/scala/org/apache/spark/SparkConf.scala ---
@@ -543,6 +545,42 @@ class SparkConf(loadDefaults: Boolean) extends
Cloneable with
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/18322#discussion_r123415688
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -258,23 +256,7 @@ private[deploy] class
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/18128
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/18128
merged to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
GitHub user dijingran opened a pull request:
https://github.com/apache/spark/pull/18383
[SPARK-21167][SS] Set kafka clientId while fetch messages
## What changes were proposed in this pull request?
Change KafkaRDD to set kafka clientId while fetch messages, as in our case
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/18114
hmm, waiting for AppVeyor
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/18322#discussion_r123413523
--- Diff:
core/src/test/scala/org/apache/spark/deploy/master/MasterSuite.scala ---
@@ -704,6 +707,43 @@ class MasterSuite extends SparkFunSuite
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18382
**[Test build #78421 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78421/testReport)**
for PR 18382 at commit
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/18382#discussion_r123412816
--- Diff: R/pkg/R/context.R ---
@@ -295,6 +295,23 @@ setCheckpointDirSC <- function(sc, dirName) {
invisible(callJMethod(sc, "setCheckpointDir",
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18362
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78415/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18327
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78416/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18362
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18327
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18362
**[Test build #78415 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78415/testReport)**
for PR 18362 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18327
**[Test build #78416 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78416/testReport)**
for PR 18327 at commit
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18300#discussion_r123412488
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -1764,6 +1765,70 @@ class Dataset[T] private[sql](
}
/**
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/18323#discussion_r123408655
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala
---
@@ -1186,3 +1186,51 @@ case class BRound(child:
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/18323#discussion_r123409892
--- Diff: sql/core/src/test/resources/sql-tests/inputs/operators.sql ---
@@ -92,3 +92,8 @@ select abs(-3.13), abs('-2.19');
-- positive/negative
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/18323#discussion_r123401825
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala
---
@@ -631,3 +631,109 @@ abstract class TernaryExpression
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/18323#discussion_r123410671
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/MathUtils.scala
---
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/18323#discussion_r123411306
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/MathUtils.scala
---
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/18323#discussion_r123411090
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/MathUtils.scala
---
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/18323#discussion_r123410649
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/MathUtils.scala
---
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/18323#discussion_r123402665
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala
---
@@ -631,3 +631,109 @@ abstract class TernaryExpression
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/18323#discussion_r123408856
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/MathUtils.scala
---
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/18323#discussion_r123409716
--- Diff: sql/core/src/test/resources/sql-tests/inputs/operators.sql ---
@@ -92,3 +92,8 @@ select abs(-3.13), abs('-2.19');
-- positive/negative
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/18323#discussion_r123410449
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/MathUtils.scala
---
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/18323#discussion_r123412204
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/MathUtilsSuite.scala
---
@@ -0,0 +1,37 @@
+/*
+ * Licensed to the Apache
1 - 100 of 536 matches
Mail list logo
