[GitHub] spark pull request #18971: [SPARK-21764][TESTS] Fix tests failures on Window...

2017-08-25 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/18971#discussion_r135382352 --- Diff: core/src/test/scala/org/apache/spark/deploy/SparkSubmitSuite.scala --- @@ -824,7 +824,7 @@ class SparkSubmitSuite val hadoopConf =

[GitHub] spark pull request #18971: [SPARK-21764][TESTS] Fix tests failures on Window...

2017-08-25 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/18971#discussion_r135382393 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/StatisticsSuite.scala --- @@ -203,7 +203,7 @@ class StatisticsSuite extends

[GitHub] spark pull request #18971: [SPARK-21764][TESTS] Fix tests failures on Window...

2017-08-25 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/18971#discussion_r135382374 --- Diff: core/src/test/scala/org/apache/spark/scheduler/ReplayListenerSuite.scala --- @@ -221,12 +226,14 @@ class ReplayListenerSuite extends

[GitHub] spark pull request #18971: [SPARK-21764][TESTS] Fix tests failures on Window...

2017-08-25 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/18971#discussion_r135382209 --- Diff: core/src/test/scala/org/apache/spark/deploy/RPackageUtilsSuite.scala --- @@ -137,9 +137,10 @@ class RPackageUtilsSuite

[GitHub] spark pull request #18971: [SPARK-21764][TESTS] Fix tests failures on Window...

2017-08-25 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/18971#discussion_r135382368 --- Diff: core/src/test/scala/org/apache/spark/scheduler/ReplayListenerSuite.scala --- @@ -112,17 +112,19 @@ class ReplayListenerSuite extends

[GitHub] spark issue #18971: [SPARK-21764][TESTS] Fix tests failures on Windows: reso...

2017-08-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18971 **[Test build #81151 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81151/testReport)** for PR 18971 at commit

[GitHub] spark pull request #19019: [MINOR][DOCS] Minor doc fixes related with doc bu...

2017-08-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/19019 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #18581: [SPARK-21289][SQL][ML] Supports custom line separator fo...

2017-08-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18581 **[Test build #81150 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81150/testReport)** for PR 18581 at commit

[GitHub] spark issue #19019: [MINOR][DOCS] Minor doc fixes related with doc build and...

2017-08-25 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/19019 Merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark pull request #18581: [SPARK-21289][SQL][ML] Supports custom line separ...

2017-08-25 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/18581#discussion_r135381676 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/HadoopFileLinesReader.scala --- @@ -32,7 +32,9 @@ import

[GitHub] spark pull request #18966: [SPARK-21751][SQL] CodeGeneraor.splitExpressions ...

2017-08-25 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/18966#discussion_r135381627 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala --- @@ -769,16 +769,21 @@ class CodegenContext {

[GitHub] spark issue #18989: [SPARK-21781][SQL] Modify DataSourceScanExec to use conc...

2017-08-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18989 **[Test build #81149 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81149/testReport)** for PR 18989 at commit

[GitHub] spark issue #18989: [SPARK-21781][SQL] Modify DataSourceScanExec to use conc...

2017-08-25 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/18989 Jenkins, retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark pull request #18966: [SPARK-21751][SQL] CodeGeneraor.splitExpressions ...

2017-08-25 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/18966#discussion_r135380779 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala --- @@ -769,16 +769,21 @@ class CodegenContext {

[GitHub] spark issue #19043: [SPARK-21831][TEST] Remove `spark.sql.hive.convertMetast...

2017-08-25 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/19043 Thank you for reviewing and merging! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #19043: [SPARK-21831][TEST] Remove `spark.sql.hive.conver...

2017-08-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/19043 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #19043: [SPARK-21831][TEST] Remove `spark.sql.hive.convertMetast...

2017-08-25 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/19043 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark issue #19048: [SPARK-21834] Incorrect executor request in case of dyna...

2017-08-25 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/19048 > May be it would be cleaner if we provide a new api like this - killExecutorsAndNotUpdateTotal? I think the main thing that bothers me is that adding anything to the API is making all this

[GitHub] spark issue #18953: [SPARK-20682][SQL] Update ORC data source based on Apach...

2017-08-25 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/18953 Now, it becomes `+432 −98`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #19048: [SPARK-21834] Incorrect executor request in case of dyna...

2017-08-25 Thread sitalkedia
Github user sitalkedia commented on the issue: https://github.com/apache/spark/pull/19048 >> this code in the EAM: Should be changed to account for the current number of executors, so that the EAM doesn't tell the CGSB that it wants less executors than currently exist.

[GitHub] spark pull request #18966: [SPARK-21751][SQL] CodeGeneraor.splitExpressions ...

2017-08-25 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/18966#discussion_r135378299 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala --- @@ -769,16 +769,21 @@ class CodegenContext {

[GitHub] spark pull request #18488: [SPARK-21255][SQL][WIP] Fixed NPE when creating e...

2017-08-25 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18488#discussion_r135377225 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/JavaTypeInference.scala --- @@ -118,6 +119,10 @@ object JavaTypeInference {

[GitHub] spark issue #18645: [SPARK-14280][BUILD][WIP] Update change-version.sh and p...

2017-08-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18645 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18645: [SPARK-14280][BUILD][WIP] Update change-version.sh and p...

2017-08-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18645 **[Test build #81143 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81143/testReport)** for PR 18645 at commit

[GitHub] spark issue #18645: [SPARK-14280][BUILD][WIP] Update change-version.sh and p...

2017-08-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18645 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81143/ Test FAILed. ---

[GitHub] spark issue #19057: SPARK-21843: testNameNote should be (minNumPostShufflePa...

2017-08-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19057 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request #19057: SPARK-21843: testNameNote should be (minNumPostSh...

2017-08-25 Thread iamhumanbeing
GitHub user iamhumanbeing opened a pull request: https://github.com/apache/spark/pull/19057 SPARK-21843: testNameNote should be (minNumPostShufflePartitions: 5)" in ExchangeCoordinatorSuitegi ## What changes were proposed in this pull request? testNameNote =

[GitHub] spark issue #19056: [SPARK-21765] Check that optimization doesn't affect isS...

2017-08-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19056 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81147/ Test PASSed. ---

[GitHub] spark issue #19056: [SPARK-21765] Check that optimization doesn't affect isS...

2017-08-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19056 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #19056: [SPARK-21765] Check that optimization doesn't affect isS...

2017-08-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19056 **[Test build #81147 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81147/testReport)** for PR 19056 at commit

[GitHub] spark issue #18953: [SPARK-20682][SQL] Update ORC data source based on Apach...

2017-08-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18953 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81148/ Test PASSed. ---

[GitHub] spark issue #18953: [SPARK-20682][SQL] Update ORC data source based on Apach...

2017-08-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18953 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18953: [SPARK-20682][SQL] Update ORC data source based on Apach...

2017-08-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18953 **[Test build #81148 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81148/testReport)** for PR 18953 at commit

[GitHub] spark issue #19048: [SPARK-21834] Incorrect executor request in case of dyna...

2017-08-25 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/19048 I think I see what you're saying. But I still think it's the fault of the EAM. > But please note that while killing 2 executors the EAM did not reduce its target to 3, it is still 5.

[GitHub] spark issue #18805: [SPARK-19112][CORE] Support for ZStandard codec

2017-08-25 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/18805 Yes, licenses have to be updated, that's the one type of thing that's not optional. But Marcelo is right that the library actually doesn't yet include the newer dependency with the right

[GitHub] spark issue #18805: [SPARK-19112][CORE] Support for ZStandard codec

2017-08-25 Thread sitalkedia
Github user sitalkedia commented on the issue: https://github.com/apache/spark/pull/18805 >> I think this will be OK but we do need to add these two licenses to licenses/ (see the convention there) and also add a line for each in LICENSE here. @srowen - Does that need to be

[GitHub] spark issue #19056: [SPARK-21765] Check that optimization doesn't affect isS...

2017-08-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19056 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81145/ Test PASSed. ---

[GitHub] spark issue #19056: [SPARK-21765] Check that optimization doesn't affect isS...

2017-08-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19056 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #19056: [SPARK-21765] Check that optimization doesn't affect isS...

2017-08-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19056 **[Test build #81145 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81145/testReport)** for PR 19056 at commit

[GitHub] spark issue #19048: [SPARK-21834] Incorrect executor request in case of dyna...

2017-08-25 Thread sitalkedia
Github user sitalkedia commented on the issue: https://github.com/apache/spark/pull/19048 >> Why? Because of the idle timeout? If that's your point, then the change I referenced above should avoid that. Yes because of idle timeout. Note that the `numExecutorsTarget` is 5 and

[GitHub] spark issue #19048: [SPARK-21834] Incorrect executor request in case of dyna...

2017-08-25 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/19048 If you can actually provide logs that show what you're trying to say that would probably be easier. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark issue #19048: [SPARK-21834] Incorrect executor request in case of dyna...

2017-08-25 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/19048 > but the EAM asks the scheduler to kill 2 of them. Why? Because of the idle timeout? If that's your point, then the change I referenced above should avoid that. > The scheduler

[GitHub] spark issue #19048: [SPARK-21834] Incorrect executor request in case of dyna...

2017-08-25 Thread sitalkedia
Github user sitalkedia commented on the issue: https://github.com/apache/spark/pull/19048 To be clear there is no issue on EAM side. Consider the following situation - - 10 executors are running, each executor can run 4 tasks at max. - 20 tasks are running so EAM sets the

[GitHub] spark issue #19056: [SPARK-21765] Check that optimization doesn't affect isS...

2017-08-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19056 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81144/ Test PASSed. ---

[GitHub] spark issue #19056: [SPARK-21765] Check that optimization doesn't affect isS...

2017-08-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19056 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #19056: [SPARK-21765] Check that optimization doesn't affect isS...

2017-08-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19056 **[Test build #81144 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81144/testReport)** for PR 19056 at commit

[GitHub] spark issue #18953: [SPARK-20682][SQL] Update ORC data source based on Apach...

2017-08-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18953 **[Test build #81148 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81148/testReport)** for PR 18953 at commit

[GitHub] spark issue #19047: [SPARK-21798]: No config to replace deprecated SPARK_CLA...

2017-08-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19047 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #19047: [SPARK-21798]: No config to replace deprecated SPARK_CLA...

2017-08-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19047 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81141/ Test PASSed. ---

[GitHub] spark issue #19047: [SPARK-21798]: No config to replace deprecated SPARK_CLA...

2017-08-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19047 **[Test build #81141 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81141/testReport)** for PR 19047 at commit

[GitHub] spark issue #18098: [SPARK-16944][Mesos] Improve data locality when launchin...

2017-08-25 Thread gpang
Github user gpang commented on the issue: https://github.com/apache/spark/pull/18098 @mgummelt @lins05 @skonto The tests passed with SparkQA, but something on AppVeyor failed. The AppVeyor output also shows the tests pass but it timed out with something. Do you know how to re-trigger

[GitHub] spark issue #19055: [SPARK-21839][SQL] Support SQL config for ORC compressio...

2017-08-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19055 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81140/ Test PASSed. ---

[GitHub] spark issue #19055: [SPARK-21839][SQL] Support SQL config for ORC compressio...

2017-08-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19055 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #19055: [SPARK-21839][SQL] Support SQL config for ORC compressio...

2017-08-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19055 **[Test build #81140 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81140/testReport)** for PR 19055 at commit

[GitHub] spark issue #18953: [SPARK-20682][SQL] Update ORC data source based on Apach...

2017-08-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18953 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18953: [SPARK-20682][SQL] Update ORC data source based on Apach...

2017-08-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18953 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81142/ Test FAILed. ---

[GitHub] spark issue #18953: [SPARK-20682][SQL] Update ORC data source based on Apach...

2017-08-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18953 **[Test build #81142 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81142/testReport)** for PR 18953 at commit

[GitHub] spark issue #19056: [SPARK-21765] Check that optimization doesn't affect isS...

2017-08-25 Thread joseph-torres
Github user joseph-torres commented on the issue: https://github.com/apache/spark/pull/19056 Addressed all comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #19056: [SPARK-21765] Check that optimization doesn't affect isS...

2017-08-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19056 **[Test build #81147 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81147/testReport)** for PR 19056 at commit

[GitHub] spark issue #19055: [SPARK-21839][SQL] Support SQL config for ORC compressio...

2017-08-25 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/19055 Hi, @cloud-fan and @gatorsmile . Could you review this ORC option PR? This is spun off from #18953 in order to reduce the review burden. --- If your project is set up for it, you can

[GitHub] spark issue #19055: [SPARK-21839][SQL] Support SQL config for ORC compressio...

2017-08-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19055 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #19055: [SPARK-21839][SQL] Support SQL config for ORC compressio...

2017-08-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19055 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81139/ Test PASSed. ---

[GitHub] spark issue #19055: [SPARK-21839][SQL] Support SQL config for ORC compressio...

2017-08-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19055 **[Test build #81139 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81139/testReport)** for PR 19055 at commit

[GitHub] spark issue #19056: [SPARK-21765] Check that optimization doesn't affect isS...

2017-08-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19056 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #19056: [SPARK-21765] Check that optimization doesn't affect isS...

2017-08-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19056 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81146/ Test FAILed. ---

[GitHub] spark issue #19056: [SPARK-21765] Check that optimization doesn't affect isS...

2017-08-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19056 **[Test build #81146 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81146/testReport)** for PR 19056 at commit

[GitHub] spark pull request #19056: [SPARK-21765] Check that optimization doesn't aff...

2017-08-25 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19056#discussion_r135360845 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/PropagateEmptyRelation.scala --- @@ -65,11 +66,12 @@ object

[GitHub] spark issue #19056: [SPARK-21765] Check that optimization doesn't affect isS...

2017-08-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19056 **[Test build #81146 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81146/testReport)** for PR 19056 at commit

[GitHub] spark pull request #19056: [SPARK-21765] Check that optimization doesn't aff...

2017-08-25 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19056#discussion_r135360650 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/PropagateEmptyRelation.scala --- @@ -65,11 +66,12 @@ object

[GitHub] spark issue #19056: [SPARK-21765] Check that optimization doesn't affect isS...

2017-08-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19056 **[Test build #81145 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81145/testReport)** for PR 19056 at commit

[GitHub] spark pull request #19056: [SPARK-21765] Check that optimization doesn't aff...

2017-08-25 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19056#discussion_r135358693 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/rules/RuleExecutor.scala --- @@ -63,6 +63,11 @@ abstract class RuleExecutor[TreeType <:

[GitHub] spark pull request #19056: [SPARK-21765] Check that optimization doesn't aff...

2017-08-25 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19056#discussion_r135358635 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/rules/RuleExecutor.scala --- @@ -86,6 +91,8 @@ abstract class RuleExecutor[TreeType <:

[GitHub] spark pull request #19056: [SPARK-21765] Check that optimization doesn't aff...

2017-08-25 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19056#discussion_r135358597 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -39,6 +39,15 @@ abstract class Optimizer(sessionCatalog:

[GitHub] spark pull request #19032: [SPARK-17321][YARN] Avoid writing shuffle metadat...

2017-08-25 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/19032#discussion_r135356694 --- Diff: common/network-yarn/src/main/java/org/apache/spark/network/yarn/YarnShuffleService.java --- @@ -170,7 +178,7 @@ protected void

[GitHub] spark pull request #19032: [SPARK-17321][YARN] Avoid writing shuffle metadat...

2017-08-25 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/19032#discussion_r135356403 --- Diff: common/network-yarn/src/main/java/org/apache/spark/network/yarn/YarnShuffleService.java --- @@ -73,6 +75,8 @@ public class

[GitHub] spark issue #18659: [SPARK-21404][PYSPARK][WIP] Simple Python Vectorized UDF...

2017-08-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18659 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18659: [SPARK-21404][PYSPARK][WIP] Simple Python Vectorized UDF...

2017-08-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18659 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81138/ Test PASSed. ---

[GitHub] spark issue #18659: [SPARK-21404][PYSPARK][WIP] Simple Python Vectorized UDF...

2017-08-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18659 **[Test build #81138 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81138/testReport)** for PR 18659 at commit

[GitHub] spark pull request #18837: [Spark-20812][Mesos] Add secrets support to the d...

2017-08-25 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/18837#discussion_r135353557 --- Diff: resource-managers/mesos/src/main/scala/org/apache/spark/deploy/mesos/config.scala --- @@ -58,13 +58,40 @@ package object config {

[GitHub] spark pull request #18837: [Spark-20812][Mesos] Add secrets support to the d...

2017-08-25 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/18837#discussion_r135353586 --- Diff: resource-managers/mesos/src/main/scala/org/apache/spark/deploy/mesos/config.scala --- @@ -58,13 +58,40 @@ package object config {

[GitHub] spark pull request #18837: [Spark-20812][Mesos] Add secrets support to the d...

2017-08-25 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/18837#discussion_r135353454 --- Diff: resource-managers/mesos/src/main/scala/org/apache/spark/deploy/mesos/config.scala --- @@ -58,13 +58,40 @@ package object config {

[GitHub] spark pull request #18837: [Spark-20812][Mesos] Add secrets support to the d...

2017-08-25 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/18837#discussion_r135353607 --- Diff: resource-managers/mesos/src/main/scala/org/apache/spark/deploy/mesos/config.scala --- @@ -58,13 +58,40 @@ package object config {

[GitHub] spark issue #19056: [SPARK-21765] Check that optimization doesn't affect isS...

2017-08-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19056 **[Test build #81144 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81144/testReport)** for PR 19056 at commit

[GitHub] spark pull request #19056: [SPARK-21765] Check that optimization doesn't aff...

2017-08-25 Thread joseph-torres
GitHub user joseph-torres opened a pull request: https://github.com/apache/spark/pull/19056 [SPARK-21765] Check that optimization doesn't affect isStreaming bit. ## What changes were proposed in this pull request? Add an assert in logical plan optimization that the

[GitHub] spark pull request #19038: [SPARK-21806][MLLIB] BinaryClassificationMetrics ...

2017-08-25 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/19038#discussion_r135348933 --- Diff: mllib/src/test/scala/org/apache/spark/mllib/evaluation/BinaryClassificationMetricsSuite.scala --- @@ -111,7 +109,7 @@ class

[GitHub] spark issue #18645: [SPARK-14280][BUILD][WIP] Update change-version.sh and p...

2017-08-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18645 **[Test build #81143 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81143/testReport)** for PR 18645 at commit

[GitHub] spark issue #19013: [SPARK-21728][core] Allow SparkSubmit to use Logging.

2017-08-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19013 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #19013: [SPARK-21728][core] Allow SparkSubmit to use Logging.

2017-08-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19013 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81135/ Test PASSed. ---

[GitHub] spark issue #19013: [SPARK-21728][core] Allow SparkSubmit to use Logging.

2017-08-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19013 **[Test build #81135 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81135/testReport)** for PR 19013 at commit

[GitHub] spark pull request #19053: [SPARK-21837][SQL][TESTS] UserDefinedTypeSuite Lo...

2017-08-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/19053 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #18953: [SPARK-20682][SQL] Update ORC data source based on Apach...

2017-08-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18953 **[Test build #81142 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81142/testReport)** for PR 18953 at commit

[GitHub] spark issue #19053: [SPARK-21837][SQL][TESTS] UserDefinedTypeSuite Local UDT...

2017-08-25 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/19053 Thanks! Merging to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #19053: [SPARK-21837][SQL][TESTS] UserDefinedTypeSuite Local UDT...

2017-08-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19053 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81137/ Test PASSed. ---

[GitHub] spark pull request #18581: [SPARK-21289][SQL][ML] Supports custom line separ...

2017-08-25 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18581#discussion_r135346452 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/HadoopFileLinesReader.scala --- @@ -32,7 +32,9 @@ import

[GitHub] spark issue #19053: [SPARK-21837][SQL][TESTS] UserDefinedTypeSuite Local UDT...

2017-08-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19053 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #19053: [SPARK-21837][SQL][TESTS] UserDefinedTypeSuite Local UDT...

2017-08-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19053 **[Test build #81137 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81137/testReport)** for PR 19053 at commit

[GitHub] spark issue #19053: [SPARK-21837][SQL][TESTS] UserDefinedTypeSuite Local UDT...

2017-08-25 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/19053 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark issue #19047: [SPARK-21798]: No config to replace deprecated SPARK_CLA...

2017-08-25 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/19047 LGTM. I'd like to see these daemons start using normal Spark configs like the applications do, but that's a separate, larger change... --- If your project is set up for it, you can reply to this

[GitHub] spark issue #19055: [SPARK-21839][SQL] Support SQL config for ORC compressio...

2017-08-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19055 **[Test build #81140 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81140/testReport)** for PR 19055 at commit

[GitHub] spark issue #19047: [SPARK-21798]: No config to replace deprecated SPARK_CLA...

2017-08-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19047 **[Test build #81141 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81141/testReport)** for PR 19047 at commit

  1   2   3   4   >