Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18971#discussion_r135382352
  
    --- Diff: 
core/src/test/scala/org/apache/spark/deploy/SparkSubmitSuite.scala ---
    @@ -824,7 +824,7 @@ class SparkSubmitSuite
         val hadoopConf = new Configuration()
         val tmpDir = Files.createTempDirectory("tmp").toFile
         updateConfWithFakeS3Fs(hadoopConf)
    -    val sourcePath = s"s3a://${jarFile.getAbsolutePath}"
    +    val sourcePath = s"s3a://${jarFile.toURI.getPath}"
    --- End diff --
    
    **Windows:**
    
    Before:
    
    ```
    scala> f.toURI.getPath
    res1: String = /C:/a/b/c
    ```
    
    After:
    
    ```
    scala> f.getAbsolutePath
    res2: String = C:\a\b\c
    ```
    
    **Linux:**
    
    Before:
    
    ```
    scala> new File("/a/b/c").getAbsolutePath
    res0: String = /a/b/c
    ```
    
    After:
    
    ```
    scala> new File("/a/b/c").toURI.getPath
    res1: String = /a/b/c
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to