[GitHub] spark issue #20230: [SPARK-23038][TEST] Update docker/spark-test (JDK/OS)

2018-01-13 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/20230 Thank you, @felixcheung and @srowen . --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20263: [SPARK-23069][DOCS][SPARKR] fix R doc for describe missi...

2018-01-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20263 **[Test build #86114 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86114/testReport)** for PR 20263 at commit

[GitHub] spark issue #20249: [SPARK-23057][SPARK-19235][SQL] SET LOCATION should chan...

2018-01-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20249 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20249: [SPARK-23057][SPARK-19235][SQL] SET LOCATION should chan...

2018-01-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20249 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86111/ Test PASSed. ---

[GitHub] spark issue #20249: [SPARK-23057][SPARK-19235][SQL] SET LOCATION should chan...

2018-01-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20249 **[Test build #86111 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86111/testReport)** for PR 20249 at commit

[GitHub] spark issue #20263: [SPARK-23069][DOCS][SPARKR] fix R doc for describe missi...

2018-01-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20263 **[Test build #86112 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86112/testReport)** for PR 20263 at commit

[GitHub] spark issue #20263: [SPARK-23069][DOCS][SPARKR] fix R doc for describe missi...

2018-01-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20263 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86112/ Test FAILed. ---

[GitHub] spark issue #20263: [SPARK-23069][DOCS][SPARKR] fix R doc for describe missi...

2018-01-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20263 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20230: [SPARK-23038][TEST] Update docker/spark-test (JDK/OS)

2018-01-13 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/20230 merged to master/2.3/2.2 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #20230: [SPARK-23038][TEST] Update docker/spark-test (JDK...

2018-01-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20230 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #20227: [SPARK-23035][SQL] Fix warning: TEMPORARY TABLE ... USIN...

2018-01-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20227 **[Test build #86113 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86113/testReport)** for PR 20227 at commit

[GitHub] spark issue #20254: [SPARK-23062][SQL] Improve EXCEPT documentation

2018-01-13 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/20254 @henryr could you update this PR to only include EXCEPT DISTINCT without the notes --- - To unsubscribe, e-mail:

[GitHub] spark issue #20263: [SPARK-23069] fix R doc for describe missing text

2018-01-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20263 **[Test build #86112 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86112/testReport)** for PR 20263 at commit

[GitHub] spark pull request #20263: [SPARK-23069] fix R doc for describe missing text

2018-01-13 Thread felixcheung
GitHub user felixcheung opened a pull request: https://github.com/apache/spark/pull/20263 [SPARK-23069] fix R doc for describe missing text ## What changes were proposed in this pull request? fix doc truncated ## How was this patch tested? manually You

[GitHub] spark issue #20262: Branch 2.2

2018-01-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20262 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #20262: Branch 2.2

2018-01-13 Thread alanyeok
GitHub user alanyeok opened a pull request: https://github.com/apache/spark/pull/20262 Branch 2.2 ## What changes were proposed in this pull request? (Please fill in changes proposed in this fix) ## How was this patch tested? (Please explain how this patch

[GitHub] spark issue #20227: [SPARK-23035][SQL] Fix warning: TEMPORARY TABLE ... USIN...

2018-01-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20227 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86110/ Test FAILed. ---

[GitHub] spark issue #20227: [SPARK-23035][SQL] Fix warning: TEMPORARY TABLE ... USIN...

2018-01-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20227 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20227: [SPARK-23035][SQL] Fix warning: TEMPORARY TABLE ... USIN...

2018-01-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20227 **[Test build #86110 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86110/testReport)** for PR 20227 at commit

[GitHub] spark pull request #20256: [SPARK-23063][K8S] K8s changes for publishing scr...

2018-01-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20256 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #20256: [SPARK-23063][K8S] K8s changes for publishing scripts (a...

2018-01-13 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/20256 thanks! merged to master/2.3 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark pull request #19247: [Spark-21996][SQL] read files with space in name ...

2018-01-13 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/19247#discussion_r161387225 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/FileStreamSource.scala --- @@ -233,7 +233,7 @@ class FileStreamSource(

[GitHub] spark pull request #19247: [Spark-21996][SQL] read files with space in name ...

2018-01-13 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/19247#discussion_r161387193 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/FileStreamSource.scala --- @@ -233,7 +233,7 @@ class FileStreamSource(

[GitHub] spark issue #20249: [SPARK-23057][SPARK-19235][SQL] SET LOCATION should chan...

2018-01-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20249 **[Test build #86111 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86111/testReport)** for PR 20249 at commit

[GitHub] spark pull request #20224: [SPARK-23032][SQL] Add a per-query codegenStageId...

2018-01-13 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/20224#discussion_r161387055 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala --- @@ -575,7 +609,10 @@ case class

[GitHub] spark issue #20227: [SPARK-23035][SQL] Fix warning: TEMPORARY TABLE ... USIN...

2018-01-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20227 **[Test build #86110 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86110/testReport)** for PR 20227 at commit

[GitHub] spark pull request #20227: [SPARK-23035][SQL] Fix warning: TEMPORARY TABLE ....

2018-01-13 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/spark/pull/20227#discussion_r161386989 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala --- @@ -883,6 +908,41 @@ abstract class DDLSuite extends QueryTest

[GitHub] spark issue #20184: [SPARK-22987][Core] UnsafeExternalSorter cases OOM when ...

2018-01-13 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/20184 Thanks, let me try to reproduce it locally. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20247: [SPARK-23021][SQL] AnalysisBarrier should override inner...

2018-01-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20247 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86108/ Test PASSed. ---

[GitHub] spark issue #20247: [SPARK-23021][SQL] AnalysisBarrier should override inner...

2018-01-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20247 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20247: [SPARK-23021][SQL] AnalysisBarrier should override inner...

2018-01-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20247 **[Test build #86108 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86108/testReport)** for PR 20247 at commit

[GitHub] spark pull request #20151: [SPARK-22959][PYTHON] Configuration to select the...

2018-01-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20151 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #20151: [SPARK-22959][PYTHON] Configuration to select the module...

2018-01-13 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20151 Merged to master. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20261: [SPARK-22885][ML][TEST] ML test for StructuredStreaming:...

2018-01-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20261 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20261: [SPARK-22885][ML][TEST] ML test for StructuredStreaming:...

2018-01-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20261 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86109/ Test PASSed. ---

[GitHub] spark issue #20261: [SPARK-22885][ML][TEST] ML test for StructuredStreaming:...

2018-01-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20261 **[Test build #86109 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86109/testReport)** for PR 20261 at commit

[GitHub] spark issue #20240: [SPARK-23049][SQL] `spark.sql.files.ignoreCorruptFiles` ...

2018-01-13 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20240 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #19340: [SPARK-22119][ML] Add cosine distance to KMeans

2018-01-13 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/19340#discussion_r161385721 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/KMeans.scala --- @@ -546,10 +577,111 @@ object KMeans { .run(data) }

[GitHub] spark pull request #19340: [SPARK-22119][ML] Add cosine distance to KMeans

2018-01-13 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/19340#discussion_r161385643 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/KMeans.scala --- @@ -573,44 +705,45 @@ object KMeans { } /** - *

[GitHub] spark pull request #20171: [SPARK-22978] [PySpark] Register Vectorized UDFs ...

2018-01-13 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20171#discussion_r161385548 --- Diff: python/pyspark/sql/tests.py --- @@ -380,10 +380,16 @@ def test_udf2(self): def test_udf3(self): twoargs =

[GitHub] spark pull request #20171: [SPARK-22978] [PySpark] Register Vectorized UDFs ...

2018-01-13 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20171#discussion_r161385502 --- Diff: python/pyspark/sql/catalog.py --- @@ -256,27 +258,56 @@ def registerFunction(self, name, f, returnType=StringType()): >>>

[GitHub] spark pull request #20171: [SPARK-22978] [PySpark] Register Vectorized UDFs ...

2018-01-13 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20171#discussion_r161385427 --- Diff: python/pyspark/sql/catalog.py --- @@ -256,27 +258,56 @@ def registerFunction(self, name, f, returnType=StringType()): >>>

[GitHub] spark pull request #20171: [SPARK-22978] [PySpark] Register Vectorized UDFs ...

2018-01-13 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20171#discussion_r161385482 --- Diff: python/pyspark/sql/context.py --- @@ -204,15 +206,31 @@ def registerFunction(self, name, f, returnType=StringType()): >>>

[GitHub] spark pull request #20171: [SPARK-22978] [PySpark] Register Vectorized UDFs ...

2018-01-13 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20171#discussion_r161385554 --- Diff: python/pyspark/sql/tests.py --- @@ -3616,6 +3622,21 @@ def test_vectorized_udf_basic(self): bool_f(col('bool')))

[GitHub] spark pull request #20171: [SPARK-22978] [PySpark] Register Vectorized UDFs ...

2018-01-13 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20171#discussion_r161385504 --- Diff: python/pyspark/sql/catalog.py --- @@ -256,27 +258,56 @@ def registerFunction(self, name, f, returnType=StringType()): >>>

[GitHub] spark pull request #20171: [SPARK-22978] [PySpark] Register Vectorized UDFs ...

2018-01-13 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20171#discussion_r161385550 --- Diff: python/pyspark/sql/tests.py --- @@ -3616,6 +3622,21 @@ def test_vectorized_udf_basic(self): bool_f(col('bool')))

[GitHub] spark pull request #20171: [SPARK-22978] [PySpark] Register Vectorized UDFs ...

2018-01-13 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20171#discussion_r161385602 --- Diff: python/pyspark/sql/tests.py --- @@ -4037,6 +4075,21 @@ def test_simple(self): expected =

[GitHub] spark issue #20085: [SPARK-22739][Catalyst][WIP] Additional Expression Suppo...

2018-01-13 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/20085 Seems to me this doesn't need to be urgent to be in 2.3. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark issue #20085: [SPARK-22739][Catalyst][WIP] Additional Expression Suppo...

2018-01-13 Thread sameeragarwal
Github user sameeragarwal commented on the issue: https://github.com/apache/spark/pull/20085 @bdrillard @viirya @cloud-fan are we still targeting this for 2.3? --- - To unsubscribe, e-mail:

[GitHub] spark issue #20256: [SPARK-23063][K8S] K8s changes for publishing scripts (a...

2018-01-13 Thread sameeragarwal
Github user sameeragarwal commented on the issue: https://github.com/apache/spark/pull/20256 verified changes to the release scripts and a did simple grep check -- both LGTM. Thanks! --- - To unsubscribe, e-mail:

[GitHub] spark issue #20261: [SPARK-22885][ML][TEST] ML test for StructuredStreaming:...

2018-01-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20261 **[Test build #86109 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86109/testReport)** for PR 20261 at commit

[GitHub] spark pull request #20261: [SPARK-22885][ML][TEST] ML test for StructuredStr...

2018-01-13 Thread WeichenXu123
GitHub user WeichenXu123 opened a pull request: https://github.com/apache/spark/pull/20261 [SPARK-22885][ML][TEST] ML test for StructuredStreaming: spark.ml.tuning ## What changes were proposed in this pull request? ML test for StructuredStreaming: spark.ml.tuning

[GitHub] spark issue #20167: Allow providing Mesos principal & secret via files (SPAR...

2018-01-13 Thread ArtRand
Github user ArtRand commented on the issue: https://github.com/apache/spark/pull/20167 Hello @rvesse thanks for this patch! With Mesos having [reference secrets](https://github.com/apache/mesos/blob/master/include/mesos/mesos.proto#L2596) now I think providing this as a file is a

[GitHub] spark pull request #20167: Allow providing Mesos principal & secret via file...

2018-01-13 Thread ArtRand
Github user ArtRand commented on a diff in the pull request: https://github.com/apache/spark/pull/20167#discussion_r161385124 --- Diff: resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala --- @@ -80,10 +80,27 @@ trait

[GitHub] spark pull request #20167: Allow providing Mesos principal & secret via file...

2018-01-13 Thread ArtRand
Github user ArtRand commented on a diff in the pull request: https://github.com/apache/spark/pull/20167#discussion_r161385080 --- Diff: resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala --- @@ -80,10 +80,27 @@ trait

[GitHub] spark issue #20240: [SPARK-23049][SQL] `spark.sql.files.ignoreCorruptFiles` ...

2018-01-13 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/20240 Hi, @HyukjinKwon and @gatorsmile . It's ready for review again. Thanks! --- - To unsubscribe, e-mail:

[GitHub] spark issue #20247: [SPARK-23021][SQL] AnalysisBarrier should override inner...

2018-01-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20247 **[Test build #86108 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86108/testReport)** for PR 20247 at commit

[GitHub] spark issue #20240: [SPARK-23049][SQL] `spark.sql.files.ignoreCorruptFiles` ...

2018-01-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20240 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20240: [SPARK-23049][SQL] `spark.sql.files.ignoreCorruptFiles` ...

2018-01-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20240 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86107/ Test PASSed. ---

[GitHub] spark issue #20240: [SPARK-23049][SQL] `spark.sql.files.ignoreCorruptFiles` ...

2018-01-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20240 **[Test build #86107 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86107/testReport)** for PR 20240 at commit

[GitHub] spark issue #20253: [SPARK-22908][SS] Roll forward continuous processing Kaf...

2018-01-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20253 **[Test build #4051 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4051/testReport)** for PR 20253 at commit

[GitHub] spark issue #20253: [SPARK-22908][SS] Roll forward continuous processing Kaf...

2018-01-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20253 **[Test build #4052 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4052/testReport)** for PR 20253 at commit

[GitHub] spark issue #20237: [SPARK-22980][PYTHON][SQL] Clarify the length of each se...

2018-01-13 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20237 Mind if I ask what you expect to fix @gatorsmile? It's clear and explans the results. --- - To unsubscribe, e-mail:

[GitHub] spark pull request #20245: [SPARK-21213][SQL][FOLLOWUP] Use compatible types...

2018-01-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20245 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19635: [SPARK-22413][SQL] Type coercion for IN is not coherent ...

2018-01-13 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/19635 the tests which are failing are because of the tests added about the current behavior of Spark (which are introduced looking forward to introduce a Hive compliant mode). Therefore, before

[GitHub] spark issue #19635: [SPARK-22413][SQL] Type coercion for IN is not coherent ...

2018-01-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19635 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19635: [SPARK-22413][SQL] Type coercion for IN is not coherent ...

2018-01-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19635 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86106/ Test FAILed. ---

[GitHub] spark issue #19635: [SPARK-22413][SQL] Type coercion for IN is not coherent ...

2018-01-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19635 **[Test build #86106 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86106/testReport)** for PR 19635 at commit

[GitHub] spark issue #20247: [SPARK-23021][SQL] AnalysisBarrier should override inner...

2018-01-13 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/20247 LGTM except a minor comment. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark pull request #20247: [SPARK-23021][SQL] AnalysisBarrier should overrid...

2018-01-13 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20247#discussion_r161381695 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala --- @@ -2228,4 +2228,21 @@ class DataFrameSuite extends QueryTest with

[GitHub] spark issue #20224: [SPARK-23032][SQL] Add a per-query codegenStageId to Who...

2018-01-13 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/20224 Overall, the proposal looks good to me. We need a test case in `HiveExplainSuite` --- - To unsubscribe, e-mail:

[GitHub] spark pull request #20224: [SPARK-23032][SQL] Add a per-query codegenStageId...

2018-01-13 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20224#discussion_r161381362 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala --- @@ -312,6 +313,24 @@ case class InputAdapter(child:

[GitHub] spark issue #19001: [SPARK-19256][SQL] Hive bucketing support

2018-01-13 Thread tejasapatil
Github user tejasapatil commented on the issue: https://github.com/apache/spark/pull/19001 cc @cloud-fan @gatorsmile @sameeragarwal for review --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark issue #20249: [SPARK-23057][SPARK-19235][SQL] SET LOCATION should chan...

2018-01-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20249 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20249: [SPARK-23057][SPARK-19235][SQL] SET LOCATION should chan...

2018-01-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20249 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86105/ Test FAILed. ---

[GitHub] spark issue #20249: [SPARK-23057][SPARK-19235][SQL] SET LOCATION should chan...

2018-01-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20249 **[Test build #86105 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86105/testReport)** for PR 20249 at commit

[GitHub] spark issue #20240: [SPARK-23049][SQL] `spark.sql.files.ignoreCorruptFiles` ...

2018-01-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20240 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20240: [SPARK-23049][SQL] `spark.sql.files.ignoreCorruptFiles` ...

2018-01-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20240 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86102/ Test PASSed. ---

[GitHub] spark issue #20240: [SPARK-23049][SQL] `spark.sql.files.ignoreCorruptFiles` ...

2018-01-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20240 **[Test build #86102 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86102/testReport)** for PR 20240 at commit

[GitHub] spark issue #20240: [SPARK-23049][SQL] `spark.sql.files.ignoreCorruptFiles` ...

2018-01-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20240 **[Test build #86107 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86107/testReport)** for PR 20240 at commit

[GitHub] spark pull request #19340: [SPARK-22119][ML] Add cosine distance to KMeans

2018-01-13 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/19340#discussion_r161380797 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/KMeans.scala --- @@ -546,10 +577,109 @@ object KMeans { .run(data) }

[GitHub] spark issue #20023: [SPARK-22036][SQL] Decimal multiplication with high prec...

2018-01-13 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/20023 @gatorsmile as far as I know, Hive implementation is consistent with MS SQL Server 2006 and the implementation is taken by the description of its behavior in MSDN blogs. DB2 implementation I think

[GitHub] spark issue #20260: [SPARK-23039][SQL] Finish TODO work in alter table set l...

2018-01-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20260 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20260: [SPARK-23039][SQL] Finish TODO work in alter table set l...

2018-01-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20260 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86103/ Test FAILed. ---

[GitHub] spark issue #20237: [SPARK-22980][PYTHON][SQL] Clarify the length of each se...

2018-01-13 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/20237 The newly added description is not clear to most Spark users. I think the descriptions added by this PR does not explain the common error cases pointed out in the JIRA. ---

[GitHub] spark issue #20260: [SPARK-23039][SQL] Finish TODO work in alter table set l...

2018-01-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20260 **[Test build #86103 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86103/testReport)** for PR 20260 at commit

[GitHub] spark issue #20023: [SPARK-22036][SQL] Decimal multiplication with high prec...

2018-01-13 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/20023 The proposal of this PR is to follow Hive instead of MS SQL Server and DB2. I read the comments in HIVE-15331. Nobody pointed out why Hive decided to introduce new behaviors which are actually

[GitHub] spark issue #19001: [SPARK-19256][SQL] Hive bucketing support

2018-01-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19001 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86097/ Test PASSed. ---

[GitHub] spark issue #19001: [SPARK-19256][SQL] Hive bucketing support

2018-01-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19001 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19001: [SPARK-19256][SQL] Hive bucketing support

2018-01-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19001 **[Test build #86097 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86097/testReport)** for PR 19001 at commit

[GitHub] spark issue #20208: [SPARK-23007][SQL][TEST] Add schema evolution test suite...

2018-01-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20208 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86099/ Test PASSed. ---

[GitHub] spark issue #20208: [SPARK-23007][SQL][TEST] Add schema evolution test suite...

2018-01-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20208 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20208: [SPARK-23007][SQL][TEST] Add schema evolution test suite...

2018-01-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20208 **[Test build #86099 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86099/testReport)** for PR 20208 at commit

[GitHub] spark issue #20240: [SPARK-23049][SQL] `spark.sql.files.ignoreCorruptFiles` ...

2018-01-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20240 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86098/ Test PASSed. ---

[GitHub] spark issue #20240: [SPARK-23049][SQL] `spark.sql.files.ignoreCorruptFiles` ...

2018-01-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20240 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20240: [SPARK-23049][SQL] `spark.sql.files.ignoreCorruptFiles` ...

2018-01-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20240 **[Test build #86098 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86098/testReport)** for PR 20240 at commit

[GitHub] spark issue #20251: [Spark-23051][core] Fix for broken job description in Sp...

2018-01-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20251 **[Test build #4050 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4050/testReport)** for PR 20251 at commit

[GitHub] spark pull request #19340: [SPARK-22119][ML] Add cosine distance to KMeans

2018-01-13 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/19340#discussion_r161379528 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/KMeans.scala --- @@ -546,10 +577,109 @@ object KMeans { .run(data) }

[GitHub] spark pull request #19340: [SPARK-22119][ML] Add cosine distance to KMeans

2018-01-13 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/19340#discussion_r161379537 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/KMeans.scala --- @@ -546,10 +577,109 @@ object KMeans { .run(data) }

[GitHub] spark pull request #19340: [SPARK-22119][ML] Add cosine distance to KMeans

2018-01-13 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/19340#discussion_r161379568 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/KMeansModel.scala --- @@ -149,4 +173,38 @@ object KMeansModel extends Loader[KMeansModel] {

  1   2   3   >