[GitHub] [spark] SparkQA commented on issue #24805: [SPARK-27798][SQL] from_avro shouldn't produces same value when converted to local relation

2019-06-06 Thread GitBox
SparkQA commented on issue #24805: [SPARK-27798][SQL] from_avro shouldn't produces same value when converted to local relation URL: https://github.com/apache/spark/pull/24805#issuecomment-499767122 **[Test build #106266 has

[GitHub] [spark] ketank-new commented on issue #24788: [SPARK-26985] [core]

2019-06-06 Thread GitBox
ketank-new commented on issue #24788: [SPARK-26985] [core] URL: https://github.com/apache/spark/pull/24788#issuecomment-499766766 > If that's the exact same problem, please link that JIRA to the PR title (see https://spark.apache.org/contributing.html). Linked by changing the Title

[GitHub] [spark] ketank-new commented on issue #24788: [SPARK-26985] [core]

2019-06-06 Thread GitBox
ketank-new commented on issue #24788: [SPARK-26985] [core] URL: https://github.com/apache/spark/pull/24788#issuecomment-499765576 > Could you please add JIRA number `[SPARK-]` and `[core]` as a prefix of the title? done

[GitHub] [spark] AmplabJenkins removed a comment on issue #24335: [SPARK-27425][SQL] Add count_if function

2019-06-06 Thread GitBox
AmplabJenkins removed a comment on issue #24335: [SPARK-27425][SQL] Add count_if function URL: https://github.com/apache/spark/pull/24335#issuecomment-499764312 Merged build finished. Test PASSed. This is an automated

[GitHub] [spark] AmplabJenkins removed a comment on issue #24335: [SPARK-27425][SQL] Add count_if function

2019-06-06 Thread GitBox
AmplabJenkins removed a comment on issue #24335: [SPARK-27425][SQL] Add count_if function URL: https://github.com/apache/spark/pull/24335#issuecomment-499764318 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] zsxwing commented on issue #24796: [SPARK-27900][CORE] Add uncaught exception handler to the driver

2019-06-06 Thread GitBox
zsxwing commented on issue #24796: [SPARK-27900][CORE] Add uncaught exception handler to the driver URL: https://github.com/apache/spark/pull/24796#issuecomment-499764530 > `onReceive()` is interrupted before `onStop()` But there will be a race condition if removing `join`. We

[GitHub] [spark] AmplabJenkins commented on issue #24335: [SPARK-27425][SQL] Add count_if function

2019-06-06 Thread GitBox
AmplabJenkins commented on issue #24335: [SPARK-27425][SQL] Add count_if function URL: https://github.com/apache/spark/pull/24335#issuecomment-499764312 Merged build finished. Test PASSed. This is an automated message from

[GitHub] [spark] AmplabJenkins commented on issue #24335: [SPARK-27425][SQL] Add count_if function

2019-06-06 Thread GitBox
AmplabJenkins commented on issue #24335: [SPARK-27425][SQL] Add count_if function URL: https://github.com/apache/spark/pull/24335#issuecomment-499764318 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] gatorsmile commented on a change in pull request #24800: [SPARK-27947][SQL] ParsedStatement subclass toString may throw ClassCastException

2019-06-06 Thread GitBox
gatorsmile commented on a change in pull request #24800: [SPARK-27947][SQL] ParsedStatement subclass toString may throw ClassCastException URL: https://github.com/apache/spark/pull/24800#discussion_r291457845 ## File path:

[GitHub] [spark] gatorsmile commented on a change in pull request #24800: [SPARK-27947][SQL] ParsedStatement subclass toString may throw ClassCastException

2019-06-06 Thread GitBox
gatorsmile commented on a change in pull request #24800: [SPARK-27947][SQL] ParsedStatement subclass toString may throw ClassCastException URL: https://github.com/apache/spark/pull/24800#discussion_r291457845 ## File path:

[GitHub] [spark] SparkQA commented on issue #24335: [SPARK-27425][SQL] Add count_if function

2019-06-06 Thread GitBox
SparkQA commented on issue #24335: [SPARK-27425][SQL] Add count_if function URL: https://github.com/apache/spark/pull/24335#issuecomment-499763307 **[Test build #106269 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/106269/testReport)** for PR 24335 at

[GitHub] [spark] cryeo commented on issue #24335: [SPARK-27425][SQL] Add count_if function

2019-06-06 Thread GitBox
cryeo commented on issue #24335: [SPARK-27425][SQL] Add count_if function URL: https://github.com/apache/spark/pull/24335#issuecomment-499763393 @dongjoon-hyun Thanks for your review. I just modified code and PR description. Could you confirm it?

[GitHub] [spark] AmplabJenkins removed a comment on issue #24688: [SPARK-27970][SQL] Support Hive 3.0 metastore

2019-06-06 Thread GitBox
AmplabJenkins removed a comment on issue #24688: [SPARK-27970][SQL] Support Hive 3.0 metastore URL: https://github.com/apache/spark/pull/24688#issuecomment-499762988 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #24688: [SPARK-27970][SQL] Support Hive 3.0 metastore

2019-06-06 Thread GitBox
AmplabJenkins removed a comment on issue #24688: [SPARK-27970][SQL] Support Hive 3.0 metastore URL: https://github.com/apache/spark/pull/24688#issuecomment-499762981 Merged build finished. Test PASSed. This is an automated

[GitHub] [spark] AmplabJenkins removed a comment on issue #24815: [SPARK-27961][SQL] DataSourceV2Relation should not have refresh method

2019-06-06 Thread GitBox
AmplabJenkins removed a comment on issue #24815: [SPARK-27961][SQL] DataSourceV2Relation should not have refresh method URL: https://github.com/apache/spark/pull/24815#issuecomment-499762964 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #24815: [SPARK-27961][SQL] DataSourceV2Relation should not have refresh method

2019-06-06 Thread GitBox
AmplabJenkins removed a comment on issue #24815: [SPARK-27961][SQL] DataSourceV2Relation should not have refresh method URL: https://github.com/apache/spark/pull/24815#issuecomment-499762968 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #24688: [SPARK-27970][SQL] Support Hive 3.0 metastore

2019-06-06 Thread GitBox
AmplabJenkins commented on issue #24688: [SPARK-27970][SQL] Support Hive 3.0 metastore URL: https://github.com/apache/spark/pull/24688#issuecomment-499762988 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #24688: [SPARK-27970][SQL] Support Hive 3.0 metastore

2019-06-06 Thread GitBox
AmplabJenkins commented on issue #24688: [SPARK-27970][SQL] Support Hive 3.0 metastore URL: https://github.com/apache/spark/pull/24688#issuecomment-499762981 Merged build finished. Test PASSed. This is an automated message

[GitHub] [spark] AmplabJenkins commented on issue #24815: [SPARK-27961][SQL] DataSourceV2Relation should not have refresh method

2019-06-06 Thread GitBox
AmplabJenkins commented on issue #24815: [SPARK-27961][SQL] DataSourceV2Relation should not have refresh method URL: https://github.com/apache/spark/pull/24815#issuecomment-499762968 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #24815: [SPARK-27961][SQL] DataSourceV2Relation should not have refresh method

2019-06-06 Thread GitBox
AmplabJenkins commented on issue #24815: [SPARK-27961][SQL] DataSourceV2Relation should not have refresh method URL: https://github.com/apache/spark/pull/24815#issuecomment-499762964 Merged build finished. Test PASSed. This

[GitHub] [spark] HyukjinKwon commented on issue #24788: s390x specific changes

2019-06-06 Thread GitBox
HyukjinKwon commented on issue #24788: s390x specific changes URL: https://github.com/apache/spark/pull/24788#issuecomment-499762117 If that's the exact same problem, please link that JIRA to the PR title (see https://spark.apache.org/contributing.html). Also, please clarify why

[GitHub] [spark] SparkQA commented on issue #24815: [SPARK-27961][SQL] DataSourceV2Relation should not have refresh method

2019-06-06 Thread GitBox
SparkQA commented on issue #24815: [SPARK-27961][SQL] DataSourceV2Relation should not have refresh method URL: https://github.com/apache/spark/pull/24815#issuecomment-499762010 **[Test build #106267 has

[GitHub] [spark] SparkQA commented on issue #24688: [SPARK-27970][SQL] Support Hive 3.0 metastore

2019-06-06 Thread GitBox
SparkQA commented on issue #24688: [SPARK-27970][SQL] Support Hive 3.0 metastore URL: https://github.com/apache/spark/pull/24688#issuecomment-499762009 **[Test build #106268 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/106268/testReport)** for PR 24688

[GitHub] [spark] wangyum commented on a change in pull request #24688: [SPARK-27970][SQL] Support Hive 3.0 metastore

2019-06-06 Thread GitBox
wangyum commented on a change in pull request #24688: [SPARK-27970][SQL] Support Hive 3.0 metastore URL: https://github.com/apache/spark/pull/24688#discussion_r291456525 ## File path: docs/sql-data-sources-hive-tables.md ## @@ -130,7 +130,7 @@ The following options can be

[GitHub] [spark] AmplabJenkins removed a comment on issue #24819: [SPARK-27973][MINOR] [EXAMPLES]correct DirectKafkaWordCount usage text with groupId

2019-06-06 Thread GitBox
AmplabJenkins removed a comment on issue #24819: [SPARK-27973][MINOR] [EXAMPLES]correct DirectKafkaWordCount usage text with groupId URL: https://github.com/apache/spark/pull/24819#issuecomment-499757833 Can one of the admins verify this patch?

[GitHub] [spark] AmplabJenkins commented on issue #24819: [SPARK-27973][MINOR] [EXAMPLES]correct DirectKafkaWordCount usage text with groupId

2019-06-06 Thread GitBox
AmplabJenkins commented on issue #24819: [SPARK-27973][MINOR] [EXAMPLES]correct DirectKafkaWordCount usage text with groupId URL: https://github.com/apache/spark/pull/24819#issuecomment-499758184 Can one of the admins verify this patch?

[GitHub] [spark] AmplabJenkins removed a comment on issue #24819: [SPARK-27973][MINOR] [EXAMPLES]correct DirectKafkaWordCount usage text with groupId

2019-06-06 Thread GitBox
AmplabJenkins removed a comment on issue #24819: [SPARK-27973][MINOR] [EXAMPLES]correct DirectKafkaWordCount usage text with groupId URL: https://github.com/apache/spark/pull/24819#issuecomment-499757749 Can one of the admins verify this patch?

[GitHub] [spark] AmplabJenkins commented on issue #24819: [SPARK-27973][MINOR] [EXAMPLES]correct DirectKafkaWordCount usage text with groupId

2019-06-06 Thread GitBox
AmplabJenkins commented on issue #24819: [SPARK-27973][MINOR] [EXAMPLES]correct DirectKafkaWordCount usage text with groupId URL: https://github.com/apache/spark/pull/24819#issuecomment-499757833 Can one of the admins verify this patch?

[GitHub] [spark] AmplabJenkins commented on issue #24819: [SPARK-27973][MINOR] [EXAMPLES]correct DirectKafkaWordCount usage text with groupId

2019-06-06 Thread GitBox
AmplabJenkins commented on issue #24819: [SPARK-27973][MINOR] [EXAMPLES]correct DirectKafkaWordCount usage text with groupId URL: https://github.com/apache/spark/pull/24819#issuecomment-499757749 Can one of the admins verify this patch?

[GitHub] [spark] AmplabJenkins removed a comment on issue #24818: [SPARK-27971[SQL][R] MapPartitionsInRWithArrowExec.evaluate shouldn't eagerly read the first batch

2019-06-06 Thread GitBox
AmplabJenkins removed a comment on issue #24818: [SPARK-27971[SQL][R] MapPartitionsInRWithArrowExec.evaluate shouldn't eagerly read the first batch URL: https://github.com/apache/spark/pull/24818#issuecomment-499757129 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #24818: [SPARK-27971[SQL][R] MapPartitionsInRWithArrowExec.evaluate shouldn't eagerly read the first batch

2019-06-06 Thread GitBox
AmplabJenkins removed a comment on issue #24818: [SPARK-27971[SQL][R] MapPartitionsInRWithArrowExec.evaluate shouldn't eagerly read the first batch URL: https://github.com/apache/spark/pull/24818#issuecomment-499757133 Test PASSed. Refer to this link for build results (access rights to

[GitHub] [spark] cnZach opened a new pull request #24819: [SPARK-27973][MINOR] [EXAMPLES]correct DirectKafkaWordCount usage text with groupId

2019-06-06 Thread GitBox
cnZach opened a new pull request #24819: [SPARK-27973][MINOR] [EXAMPLES]correct DirectKafkaWordCount usage text with groupId URL: https://github.com/apache/spark/pull/24819 ## What changes were proposed in this pull request? Usage: DirectKafkaWordCount -- is a list of

[GitHub] [spark] AmplabJenkins commented on issue #24818: [SPARK-27971[SQL][R] MapPartitionsInRWithArrowExec.evaluate shouldn't eagerly read the first batch

2019-06-06 Thread GitBox
AmplabJenkins commented on issue #24818: [SPARK-27971[SQL][R] MapPartitionsInRWithArrowExec.evaluate shouldn't eagerly read the first batch URL: https://github.com/apache/spark/pull/24818#issuecomment-499757129 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #24818: [SPARK-27971[SQL][R] MapPartitionsInRWithArrowExec.evaluate shouldn't eagerly read the first batch

2019-06-06 Thread GitBox
AmplabJenkins commented on issue #24818: [SPARK-27971[SQL][R] MapPartitionsInRWithArrowExec.evaluate shouldn't eagerly read the first batch URL: https://github.com/apache/spark/pull/24818#issuecomment-499757133 Test PASSed. Refer to this link for build results (access rights to CI

[GitHub] [spark] SparkQA removed a comment on issue #24818: [SPARK-27971[SQL][R] MapPartitionsInRWithArrowExec.evaluate shouldn't eagerly read the first batch

2019-06-06 Thread GitBox
SparkQA removed a comment on issue #24818: [SPARK-27971[SQL][R] MapPartitionsInRWithArrowExec.evaluate shouldn't eagerly read the first batch URL: https://github.com/apache/spark/pull/24818#issuecomment-499732479 **[Test build #106264 has

[GitHub] [spark] SparkQA commented on issue #24818: [SPARK-27971[SQL][R] MapPartitionsInRWithArrowExec.evaluate shouldn't eagerly read the first batch

2019-06-06 Thread GitBox
SparkQA commented on issue #24818: [SPARK-27971[SQL][R] MapPartitionsInRWithArrowExec.evaluate shouldn't eagerly read the first batch URL: https://github.com/apache/spark/pull/24818#issuecomment-499756844 **[Test build #106264 has

[GitHub] [spark] Udbhav30 commented on issue #24601: [SPARK-27702][K8S] Allow using some alternatives for service accounts

2019-06-06 Thread GitBox
Udbhav30 commented on issue #24601: [SPARK-27702][K8S] Allow using some alternatives for service accounts URL: https://github.com/apache/spark/pull/24601#issuecomment-499756451 Gentle ping, @dongjoon-hyun This is an

[GitHub] [spark] ketank-new commented on issue #24788: s390x specific changes

2019-06-06 Thread GitBox
ketank-new commented on issue #24788: s390x specific changes URL: https://github.com/apache/spark/pull/24788#issuecomment-499754058 @HyukjinKwon : I do not mind raising a new JIRA for the above changes But let me inform you that we have been continuously in discussion on JIRA regarding

[GitHub] [spark] cryeo commented on a change in pull request #24335: [SPARK-27425][SQL] Add count_if function

2019-06-06 Thread GitBox
cryeo commented on a change in pull request #24335: [SPARK-27425][SQL] Add count_if function URL: https://github.com/apache/spark/pull/24335#discussion_r291444380 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/CountIf.scala

[GitHub] [spark] HyukjinKwon commented on a change in pull request #24797: Detecting key in map type when value type is complex

2019-06-06 Thread GitBox
HyukjinKwon commented on a change in pull request #24797: Detecting key in map type when value type is complex URL: https://github.com/apache/spark/pull/24797#discussion_r291443140 ## File path: R/pkg/R/schema.R ## @@ -162,7 +162,7 @@ checkType <- function(type) {

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #24795: [SPARK-27945][SQL] Minimal changes to support columnar processing

2019-06-06 Thread GitBox
dongjoon-hyun commented on a change in pull request #24795: [SPARK-27945][SQL] Minimal changes to support columnar processing URL: https://github.com/apache/spark/pull/24795#discussion_r291442978 ## File path: NOTICE-binary ## @@ -73,6 +73,10 @@ Copyright 2005-2015 The

[GitHub] [spark] HyukjinKwon commented on a change in pull request #24800: [SPARK-27947][SQL] ParsedStatement subclass toString may throw ClassCastException

2019-06-06 Thread GitBox
HyukjinKwon commented on a change in pull request #24800: [SPARK-27947][SQL] ParsedStatement subclass toString may throw ClassCastException URL: https://github.com/apache/spark/pull/24800#discussion_r291442243 ## File path:

[GitHub] [spark] viirya commented on a change in pull request #24806: [SPARK-27856][SQL] Only allow type upcasting when inserting table

2019-06-06 Thread GitBox
viirya commented on a change in pull request #24806: [SPARK-27856][SQL] Only allow type upcasting when inserting table URL: https://github.com/apache/spark/pull/24806#discussion_r291439699 ## File path:

[GitHub] [spark] viirya commented on a change in pull request #24806: [SPARK-27856][SQL] Only allow type upcasting when inserting table

2019-06-06 Thread GitBox
viirya commented on a change in pull request #24806: [SPARK-27856][SQL] Only allow type upcasting when inserting table URL: https://github.com/apache/spark/pull/24806#discussion_r291441249 ## File path:

[GitHub] [spark] viirya commented on a change in pull request #24806: [SPARK-27856][SQL] Only allow type upcasting when inserting table

2019-06-06 Thread GitBox
viirya commented on a change in pull request #24806: [SPARK-27856][SQL] Only allow type upcasting when inserting table URL: https://github.com/apache/spark/pull/24806#discussion_r291440948 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/rules.scala

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #24805: [SPARK-27798][SQL] from_avro shouldn't produces same value when converted to local relation

2019-06-06 Thread GitBox
dongjoon-hyun commented on a change in pull request #24805: [SPARK-27798][SQL] from_avro shouldn't produces same value when converted to local relation URL: https://github.com/apache/spark/pull/24805#discussion_r291440164 ## File path:

[GitHub] [spark] dongjoon-hyun edited a comment on issue #24335: [SPARK-27425][SQL] Add count_if function

2019-06-06 Thread GitBox
dongjoon-hyun edited a comment on issue #24335: [SPARK-27425][SQL] Add count_if function URL: https://github.com/apache/spark/pull/24335#issuecomment-499741465 I also support this feature and @HyukjinKwon . cc @gatorsmile

[GitHub] [spark] HyukjinKwon commented on issue #24788: s390x specific changes

2019-06-06 Thread GitBox
HyukjinKwon commented on issue #24788: s390x specific changes URL: https://github.com/apache/spark/pull/24788#issuecomment-499741691 @ketank-new, please file a JIRA with error message with problem analysis and describe how this PR fixes in PR description. Otherwise, no one knows what's

[GitHub] [spark] dongjoon-hyun commented on issue #24335: [SPARK-27425][SQL] Add count_if function

2019-06-06 Thread GitBox
dongjoon-hyun commented on issue #24335: [SPARK-27425][SQL] Add count_if function URL: https://github.com/apache/spark/pull/24335#issuecomment-499741465 cc @gatorsmile This is an automated message from the Apache Git

[GitHub] [spark] dongjoon-hyun commented on issue #24335: [SPARK-27425][SQL] Add count_if function

2019-06-06 Thread GitBox
dongjoon-hyun commented on issue #24335: [SPARK-27425][SQL] Add count_if function URL: https://github.com/apache/spark/pull/24335#issuecomment-499741306 @cryeo . Please update the PR description with more SQL references. You already told us `Presto/BigQuery/Excel` references. That will

[GitHub] [spark] HyukjinKwon commented on a change in pull request #24805: [SPARK-27798][SQL] from_avro shouldn't produces same value when converted to local relation

2019-06-06 Thread GitBox
HyukjinKwon commented on a change in pull request #24805: [SPARK-27798][SQL] from_avro shouldn't produces same value when converted to local relation URL: https://github.com/apache/spark/pull/24805#discussion_r291439572 ## File path:

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #24335: [SPARK-27425][SQL] Add count_if function

2019-06-06 Thread GitBox
dongjoon-hyun commented on a change in pull request #24335: [SPARK-27425][SQL] Add count_if function URL: https://github.com/apache/spark/pull/24335#discussion_r291439473 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/CountIf.scala

[GitHub] [spark] SparkQA commented on issue #24805: [SPARK-27798][SQL] from_avro shouldn't produces same value when converted to local relation

2019-06-06 Thread GitBox
SparkQA commented on issue #24805: [SPARK-27798][SQL] from_avro shouldn't produces same value when converted to local relation URL: https://github.com/apache/spark/pull/24805#issuecomment-499740453 **[Test build #106266 has

[GitHub] [spark] AmplabJenkins removed a comment on issue #24805: [SPARK-27798][SQL] from_avro shouldn't produces same value when converted to local relation

2019-06-06 Thread GitBox
AmplabJenkins removed a comment on issue #24805: [SPARK-27798][SQL] from_avro shouldn't produces same value when converted to local relation URL: https://github.com/apache/spark/pull/24805#issuecomment-499740154 Test PASSed. Refer to this link for build results (access rights to CI

[GitHub] [spark] AmplabJenkins removed a comment on issue #24805: [SPARK-27798][SQL] from_avro shouldn't produces same value when converted to local relation

2019-06-06 Thread GitBox
AmplabJenkins removed a comment on issue #24805: [SPARK-27798][SQL] from_avro shouldn't produces same value when converted to local relation URL: https://github.com/apache/spark/pull/24805#issuecomment-499740151 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #24805: [SPARK-27798][SQL] from_avro shouldn't produces same value when converted to local relation

2019-06-06 Thread GitBox
AmplabJenkins commented on issue #24805: [SPARK-27798][SQL] from_avro shouldn't produces same value when converted to local relation URL: https://github.com/apache/spark/pull/24805#issuecomment-499740154 Test PASSed. Refer to this link for build results (access rights to CI server

[GitHub] [spark] AmplabJenkins commented on issue #24805: [SPARK-27798][SQL] from_avro shouldn't produces same value when converted to local relation

2019-06-06 Thread GitBox
AmplabJenkins commented on issue #24805: [SPARK-27798][SQL] from_avro shouldn't produces same value when converted to local relation URL: https://github.com/apache/spark/pull/24805#issuecomment-499740151 Merged build finished. Test PASSed.

[GitHub] [spark] viirya commented on a change in pull request #24805: [SPARK-27798][SQL] from_avro shouldn't produces same value when converted to local relation

2019-06-06 Thread GitBox
viirya commented on a change in pull request #24805: [SPARK-27798][SQL] from_avro shouldn't produces same value when converted to local relation URL: https://github.com/apache/spark/pull/24805#discussion_r291438298 ## File path:

[GitHub] [spark] HyukjinKwon commented on a change in pull request #24807: [SPARK-27958] Stopping a SparkSession should not always stop Spark Context

2019-06-06 Thread GitBox
HyukjinKwon commented on a change in pull request #24807: [SPARK-27958] Stopping a SparkSession should not always stop Spark Context URL: https://github.com/apache/spark/pull/24807#discussion_r291438274 ## File path: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala

[GitHub] [spark] AmplabJenkins removed a comment on issue #24811: [SPARK-27962][R][CORE] Propagate subprocess stdout in deploy.RRunner in exception

2019-06-06 Thread GitBox
AmplabJenkins removed a comment on issue #24811: [SPARK-27962][R][CORE] Propagate subprocess stdout in deploy.RRunner in exception URL: https://github.com/apache/spark/pull/24811#issuecomment-499739443 Test FAILed. Refer to this link for build results (access rights to CI server

[GitHub] [spark] AmplabJenkins removed a comment on issue #24811: [SPARK-27962][R][CORE] Propagate subprocess stdout in deploy.RRunner in exception

2019-06-06 Thread GitBox
AmplabJenkins removed a comment on issue #24811: [SPARK-27962][R][CORE] Propagate subprocess stdout in deploy.RRunner in exception URL: https://github.com/apache/spark/pull/24811#issuecomment-499739438 Merged build finished. Test FAILed.

[GitHub] [spark] SparkQA removed a comment on issue #24811: [SPARK-27962][R][CORE] Propagate subprocess stdout in deploy.RRunner in exception

2019-06-06 Thread GitBox
SparkQA removed a comment on issue #24811: [SPARK-27962][R][CORE] Propagate subprocess stdout in deploy.RRunner in exception URL: https://github.com/apache/spark/pull/24811#issuecomment-499739362 **[Test build #106265 has

[GitHub] [spark] AmplabJenkins commented on issue #24811: [SPARK-27962][R][CORE] Propagate subprocess stdout in deploy.RRunner in exception

2019-06-06 Thread GitBox
AmplabJenkins commented on issue #24811: [SPARK-27962][R][CORE] Propagate subprocess stdout in deploy.RRunner in exception URL: https://github.com/apache/spark/pull/24811#issuecomment-499739443 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #24811: [SPARK-27962][R][CORE] Propagate subprocess stdout in deploy.RRunner in exception

2019-06-06 Thread GitBox
AmplabJenkins commented on issue #24811: [SPARK-27962][R][CORE] Propagate subprocess stdout in deploy.RRunner in exception URL: https://github.com/apache/spark/pull/24811#issuecomment-499739438 Merged build finished. Test FAILed.

[GitHub] [spark] SparkQA commented on issue #24811: [SPARK-27962][R][CORE] Propagate subprocess stdout in deploy.RRunner in exception

2019-06-06 Thread GitBox
SparkQA commented on issue #24811: [SPARK-27962][R][CORE] Propagate subprocess stdout in deploy.RRunner in exception URL: https://github.com/apache/spark/pull/24811#issuecomment-499739434 **[Test build #106265 has

[GitHub] [spark] SparkQA commented on issue #24811: [SPARK-27962][R][CORE] Propagate subprocess stdout in deploy.RRunner in exception

2019-06-06 Thread GitBox
SparkQA commented on issue #24811: [SPARK-27962][R][CORE] Propagate subprocess stdout in deploy.RRunner in exception URL: https://github.com/apache/spark/pull/24811#issuecomment-499739362 **[Test build #106265 has

[GitHub] [spark] AmplabJenkins removed a comment on issue #24811: [SPARK-27962][R][CORE] Propagate subprocess stdout in deploy.RRunner in exception

2019-06-06 Thread GitBox
AmplabJenkins removed a comment on issue #24811: [SPARK-27962][R][CORE] Propagate subprocess stdout in deploy.RRunner in exception URL: https://github.com/apache/spark/pull/24811#issuecomment-499739047 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #24811: [SPARK-27962][R][CORE] Propagate subprocess stdout in deploy.RRunner in exception

2019-06-06 Thread GitBox
AmplabJenkins commented on issue #24811: [SPARK-27962][R][CORE] Propagate subprocess stdout in deploy.RRunner in exception URL: https://github.com/apache/spark/pull/24811#issuecomment-499739056 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #24811: [SPARK-27962][R][CORE] Propagate subprocess stdout in deploy.RRunner in exception

2019-06-06 Thread GitBox
AmplabJenkins commented on issue #24811: [SPARK-27962][R][CORE] Propagate subprocess stdout in deploy.RRunner in exception URL: https://github.com/apache/spark/pull/24811#issuecomment-499739047 Merged build finished. Test PASSed.

[GitHub] [spark] HyukjinKwon commented on a change in pull request #24811: [SPARK-27962][R][CORE] Propagate subprocess stdout in deploy.RRunner in exception

2019-06-06 Thread GitBox
HyukjinKwon commented on a change in pull request #24811: [SPARK-27962][R][CORE] Propagate subprocess stdout in deploy.RRunner in exception URL: https://github.com/apache/spark/pull/24811#discussion_r291437663 ## File path: core/src/main/scala/org/apache/spark/deploy/RRunner.scala

[GitHub] [spark] AmplabJenkins removed a comment on issue #24811: [SPARK-27962][R][CORE] Propagate subprocess stdout in deploy.RRunner in exception

2019-06-06 Thread GitBox
AmplabJenkins removed a comment on issue #24811: [SPARK-27962][R][CORE] Propagate subprocess stdout in deploy.RRunner in exception URL: https://github.com/apache/spark/pull/24811#issuecomment-499739056 Test PASSed. Refer to this link for build results (access rights to CI server

[GitHub] [spark] HyukjinKwon commented on a change in pull request #24811: [SPARK-27962][R][CORE] Propagate subprocess stdout in deploy.RRunner in exception

2019-06-06 Thread GitBox
HyukjinKwon commented on a change in pull request #24811: [SPARK-27962][R][CORE] Propagate subprocess stdout in deploy.RRunner in exception URL: https://github.com/apache/spark/pull/24811#discussion_r291437528 ## File path: core/src/main/scala/org/apache/spark/deploy/RRunner.scala

[GitHub] [spark] AmplabJenkins removed a comment on issue #24811: [SPARK-27962][R][CORE] Propagate subprocess stdout in deploy.RRunner in exception

2019-06-06 Thread GitBox
AmplabJenkins removed a comment on issue #24811: [SPARK-27962][R][CORE] Propagate subprocess stdout in deploy.RRunner in exception URL: https://github.com/apache/spark/pull/24811#issuecomment-499240743 Can one of the admins verify this patch?

[GitHub] [spark] HyukjinKwon commented on issue #24811: [SPARK-27962][R][CORE] Propagate subprocess stdout in deploy.RRunner in exception

2019-06-06 Thread GitBox
HyukjinKwon commented on issue #24811: [SPARK-27962][R][CORE] Propagate subprocess stdout in deploy.RRunner in exception URL: https://github.com/apache/spark/pull/24811#issuecomment-499738236 ok to test This is an automated

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #24335: [SPARK-27425][SQL] Add count_if functions

2019-06-06 Thread GitBox
dongjoon-hyun commented on a change in pull request #24335: [SPARK-27425][SQL] Add count_if functions URL: https://github.com/apache/spark/pull/24335#discussion_r291436969 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/CountIf.scala

[GitHub] [spark] HyukjinKwon commented on a change in pull request #24814: set Int MaxValue

2019-06-06 Thread GitBox
HyukjinKwon commented on a change in pull request #24814: set Int MaxValue URL: https://github.com/apache/spark/pull/24814#discussion_r291436506 ## File path: mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ## @@ -233,7 +233,7 @@ class Word2Vec extends

[GitHub] [spark] HyukjinKwon commented on issue #24814: set Int MaxValue

2019-06-06 Thread GitBox
HyukjinKwon commented on issue #24814: set Int MaxValue URL: https://github.com/apache/spark/pull/24814#issuecomment-499737601 Please review https://spark.apache.org/contributing.html before opening a pull request. This is

[GitHub] [spark] HyukjinKwon closed pull request #24784: [SPARK-27938][SQL] Remove feature flag LEGACY_PASS_PARTITION_BY_AS_OPTIONS

2019-06-06 Thread GitBox
HyukjinKwon closed pull request #24784: [SPARK-27938][SQL] Remove feature flag LEGACY_PASS_PARTITION_BY_AS_OPTIONS URL: https://github.com/apache/spark/pull/24784 This is an automated message from the Apache Git Service. To

[GitHub] [spark] HyukjinKwon commented on a change in pull request #24784: [SPARK-27938][SQL] Remove feature flag LEGACY_PASS_PARTITION_BY_AS_OPTIONS

2019-06-06 Thread GitBox
HyukjinKwon commented on a change in pull request #24784: [SPARK-27938][SQL] Remove feature flag LEGACY_PASS_PARTITION_BY_AS_OPTIONS URL: https://github.com/apache/spark/pull/24784#discussion_r291435639 ## File path:

[GitHub] [spark] HyukjinKwon commented on issue #24784: [SPARK-27938][SQL] Remove feature flag LEGACY_PASS_PARTITION_BY_AS_OPTIONS

2019-06-06 Thread GitBox
HyukjinKwon commented on issue #24784: [SPARK-27938][SQL] Remove feature flag LEGACY_PASS_PARTITION_BY_AS_OPTIONS URL: https://github.com/apache/spark/pull/24784#issuecomment-499736700 LGTM too. strictly https://github.com/apache/spark/pull/24784#discussion_r291435639 can be done

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #24335: [SPARK-27425][SQL] Add count_if functions

2019-06-06 Thread GitBox
dongjoon-hyun commented on a change in pull request #24335: [SPARK-27425][SQL] Add count_if functions URL: https://github.com/apache/spark/pull/24335#discussion_r291433907 ## File path: sql/core/src/test/scala/org/apache/spark/sql/DataFrameAggregateSuite.scala ## @@

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #24335: [SPARK-27425][SQL] Add count_if functions

2019-06-06 Thread GitBox
dongjoon-hyun commented on a change in pull request #24335: [SPARK-27425][SQL] Add count_if functions URL: https://github.com/apache/spark/pull/24335#discussion_r291433432 ## File path: sql/core/src/test/scala/org/apache/spark/sql/DataFrameAggregateSuite.scala ## @@

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #24335: [SPARK-27425][SQL] Add count_if functions

2019-06-06 Thread GitBox
dongjoon-hyun commented on a change in pull request #24335: [SPARK-27425][SQL] Add count_if functions URL: https://github.com/apache/spark/pull/24335#discussion_r291433282 ## File path: sql/core/src/test/scala/org/apache/spark/sql/DataFrameAggregateSuite.scala ## @@

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #24335: [SPARK-27425][SQL] Add count_if functions

2019-06-06 Thread GitBox
dongjoon-hyun commented on a change in pull request #24335: [SPARK-27425][SQL] Add count_if functions URL: https://github.com/apache/spark/pull/24335#discussion_r291432774 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/CountIf.scala

[GitHub] [spark] AmplabJenkins removed a comment on issue #24818: [SPARK-27971[SQL][R] MapPartitionsInRWithArrowExec.evaluate shouldn't eagerly read the first batch

2019-06-06 Thread GitBox
AmplabJenkins removed a comment on issue #24818: [SPARK-27971[SQL][R] MapPartitionsInRWithArrowExec.evaluate shouldn't eagerly read the first batch URL: https://github.com/apache/spark/pull/24818#issuecomment-499732132 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #24818: [SPARK-27971[SQL][R] MapPartitionsInRWithArrowExec.evaluate shouldn't eagerly read the first batch

2019-06-06 Thread GitBox
AmplabJenkins removed a comment on issue #24818: [SPARK-27971[SQL][R] MapPartitionsInRWithArrowExec.evaluate shouldn't eagerly read the first batch URL: https://github.com/apache/spark/pull/24818#issuecomment-499732137 Test PASSed. Refer to this link for build results (access rights to

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #24335: [SPARK-27425][SQL] Add count_if functions

2019-06-06 Thread GitBox
dongjoon-hyun commented on a change in pull request #24335: [SPARK-27425][SQL] Add count_if functions URL: https://github.com/apache/spark/pull/24335#discussion_r291431861 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/CountIf.scala

[GitHub] [spark] SparkQA commented on issue #24818: [SPARK-27971[SQL][R] MapPartitionsInRWithArrowExec.evaluate shouldn't eagerly read the first batch

2019-06-06 Thread GitBox
SparkQA commented on issue #24818: [SPARK-27971[SQL][R] MapPartitionsInRWithArrowExec.evaluate shouldn't eagerly read the first batch URL: https://github.com/apache/spark/pull/24818#issuecomment-499732479 **[Test build #106264 has

[GitHub] [spark] AmplabJenkins commented on issue #24818: [SPARK-27971[SQL][R] MapPartitionsInRWithArrowExec.evaluate shouldn't eagerly read the first batch

2019-06-06 Thread GitBox
AmplabJenkins commented on issue #24818: [SPARK-27971[SQL][R] MapPartitionsInRWithArrowExec.evaluate shouldn't eagerly read the first batch URL: https://github.com/apache/spark/pull/24818#issuecomment-499732132 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #24818: [SPARK-27971[SQL][R] MapPartitionsInRWithArrowExec.evaluate shouldn't eagerly read the first batch

2019-06-06 Thread GitBox
AmplabJenkins commented on issue #24818: [SPARK-27971[SQL][R] MapPartitionsInRWithArrowExec.evaluate shouldn't eagerly read the first batch URL: https://github.com/apache/spark/pull/24818#issuecomment-499732137 Test PASSed. Refer to this link for build results (access rights to CI

[GitHub] [spark] HyukjinKwon opened a new pull request #24818: [SPARK-27971[SQL][R] MapPartitionsInRWithArrowExec.evaluate shouldn't eagerly read the first batch

2019-06-06 Thread GitBox
HyukjinKwon opened a new pull request #24818: [SPARK-27971[SQL][R] MapPartitionsInRWithArrowExec.evaluate shouldn't eagerly read the first batch URL: https://github.com/apache/spark/pull/24818 ## What changes were proposed in this pull request? This PR is the same fix as

[GitHub] [spark] AmplabJenkins removed a comment on issue #24734: [SPARK-27870][SQL][PySpark] Flush batch timely for pandas UDF (for improving pandas UDFs pipeline)

2019-06-06 Thread GitBox
AmplabJenkins removed a comment on issue #24734: [SPARK-27870][SQL][PySpark] Flush batch timely for pandas UDF (for improving pandas UDFs pipeline) URL: https://github.com/apache/spark/pull/24734#issuecomment-499730842 Test PASSed. Refer to this link for build results (access rights to

[GitHub] [spark] AmplabJenkins removed a comment on issue #24734: [SPARK-27870][SQL][PySpark] Flush batch timely for pandas UDF (for improving pandas UDFs pipeline)

2019-06-06 Thread GitBox
AmplabJenkins removed a comment on issue #24734: [SPARK-27870][SQL][PySpark] Flush batch timely for pandas UDF (for improving pandas UDFs pipeline) URL: https://github.com/apache/spark/pull/24734#issuecomment-499730835 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #24734: [SPARK-27870][SQL][PySpark] Flush batch timely for pandas UDF (for improving pandas UDFs pipeline)

2019-06-06 Thread GitBox
AmplabJenkins commented on issue #24734: [SPARK-27870][SQL][PySpark] Flush batch timely for pandas UDF (for improving pandas UDFs pipeline) URL: https://github.com/apache/spark/pull/24734#issuecomment-499730842 Test PASSed. Refer to this link for build results (access rights to CI

[GitHub] [spark] AmplabJenkins commented on issue #24734: [SPARK-27870][SQL][PySpark] Flush batch timely for pandas UDF (for improving pandas UDFs pipeline)

2019-06-06 Thread GitBox
AmplabJenkins commented on issue #24734: [SPARK-27870][SQL][PySpark] Flush batch timely for pandas UDF (for improving pandas UDFs pipeline) URL: https://github.com/apache/spark/pull/24734#issuecomment-499730835 Merged build finished. Test PASSed.

[GitHub] [spark] SparkQA removed a comment on issue #24734: [SPARK-27870][SQL][PySpark] Flush batch timely for pandas UDF (for improving pandas UDFs pipeline)

2019-06-06 Thread GitBox
SparkQA removed a comment on issue #24734: [SPARK-27870][SQL][PySpark] Flush batch timely for pandas UDF (for improving pandas UDFs pipeline) URL: https://github.com/apache/spark/pull/24734#issuecomment-499697138 **[Test build #106262 has

[GitHub] [spark] SparkQA commented on issue #24734: [SPARK-27870][SQL][PySpark] Flush batch timely for pandas UDF (for improving pandas UDFs pipeline)

2019-06-06 Thread GitBox
SparkQA commented on issue #24734: [SPARK-27870][SQL][PySpark] Flush batch timely for pandas UDF (for improving pandas UDFs pipeline) URL: https://github.com/apache/spark/pull/24734#issuecomment-499730555 **[Test build #106262 has

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #24815: [SPARK-27961][SQL] DataSourceV2Relation should not have refresh method

2019-06-06 Thread GitBox
dongjoon-hyun commented on a change in pull request #24815: [SPARK-27961][SQL] DataSourceV2Relation should not have refresh method URL: https://github.com/apache/spark/pull/24815#discussion_r291424651 ## File path:

[GitHub] [spark] AmplabJenkins removed a comment on issue #24817: [WIP][SPARK-27963][core] Allow dynamic allocation without a shuffle service.

2019-06-06 Thread GitBox
AmplabJenkins removed a comment on issue #24817: [WIP][SPARK-27963][core] Allow dynamic allocation without a shuffle service. URL: https://github.com/apache/spark/pull/24817#issuecomment-499728669 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #24817: [WIP][SPARK-27963][core] Allow dynamic allocation without a shuffle service.

2019-06-06 Thread GitBox
AmplabJenkins removed a comment on issue #24817: [WIP][SPARK-27963][core] Allow dynamic allocation without a shuffle service. URL: https://github.com/apache/spark/pull/24817#issuecomment-499728668 Merged build finished. Test FAILed.

  1   2   3   4   5   6   7   >