[GitHub] [spark] maropu commented on issue #25109: [SPARK-28343][SQL][TEST] PostgreSQL test should enable cartesian product

2019-07-10 Thread GitBox
maropu commented on issue #25109: [SPARK-28343][SQL][TEST] PostgreSQL test should enable cartesian product URL: https://github.com/apache/spark/pull/25109#issuecomment-510356646 ur, looks bad I checkd the reserved keywords in Postgresql again; https://www.postgresql.org/docs/current/

[GitHub] [spark] peter-toth commented on a change in pull request #25029: [SPARK-28228][SQL] Fix substitution order of nested WITH clauses

2019-07-10 Thread GitBox
peter-toth commented on a change in pull request #25029: [SPARK-28228][SQL] Fix substitution order of nested WITH clauses URL: https://github.com/apache/spark/pull/25029#discussion_r302389500 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CTESubsti

[GitHub] [spark] beliefer commented on a change in pull request #25074: [SPARK-27924]Support ANSI SQL Boolean-Predicate syntax

2019-07-10 Thread GitBox
beliefer commented on a change in pull request #25074: [SPARK-27924]Support ANSI SQL Boolean-Predicate syntax URL: https://github.com/apache/spark/pull/25074#discussion_r302389418 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/booleanExpression

[GitHub] [spark] zhengruifeng commented on issue #24793: [SPARK-27944][ML] Unify the behavior of checking empty output column names

2019-07-10 Thread GitBox
zhengruifeng commented on issue #24793: [SPARK-27944][ML] Unify the behavior of checking empty output column names URL: https://github.com/apache/spark/pull/24793#issuecomment-510356140 ping @srowen , would you mind help reviewing this? -

[GitHub] [spark] SparkQA commented on issue #24860: [SPARK-28034][SQL][TEST] Port with.sql

2019-07-10 Thread GitBox
SparkQA commented on issue #24860: [SPARK-28034][SQL][TEST] Port with.sql URL: https://github.com/apache/spark/pull/24860#issuecomment-510355699 **[Test build #107515 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/107515/testReport)** for PR 24860 at commit

[GitHub] [spark] SparkQA commented on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax

2019-07-10 Thread GitBox
SparkQA commented on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax URL: https://github.com/apache/spark/pull/25001#issuecomment-510355679 **[Test build #107514 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/107514/testReport)** for PR 250

[GitHub] [spark] AmplabJenkins removed a comment on issue #24860: [SPARK-28034][SQL][TEST] Port with.sql

2019-07-10 Thread GitBox
AmplabJenkins removed a comment on issue #24860: [SPARK-28034][SQL][TEST] Port with.sql URL: https://github.com/apache/spark/pull/24860#issuecomment-510355155 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkin

[GitHub] [spark] AmplabJenkins removed a comment on issue #24860: [SPARK-28034][SQL][TEST] Port with.sql

2019-07-10 Thread GitBox
AmplabJenkins removed a comment on issue #24860: [SPARK-28034][SQL][TEST] Port with.sql URL: https://github.com/apache/spark/pull/24860#issuecomment-510355151 Merged build finished. Test PASSed. This is an automated message f

[GitHub] [spark] AmplabJenkins commented on issue #24860: [SPARK-28034][SQL][TEST] Port with.sql

2019-07-10 Thread GitBox
AmplabJenkins commented on issue #24860: [SPARK-28034][SQL][TEST] Port with.sql URL: https://github.com/apache/spark/pull/24860#issuecomment-510355151 Merged build finished. Test PASSed. This is an automated message from the A

[GitHub] [spark] AmplabJenkins removed a comment on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax

2019-07-10 Thread GitBox
AmplabJenkins removed a comment on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax URL: https://github.com/apache/spark/pull/25001#issuecomment-510355071 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley

[GitHub] [spark] AmplabJenkins commented on issue #24860: [SPARK-28034][SQL][TEST] Port with.sql

2019-07-10 Thread GitBox
AmplabJenkins commented on issue #24860: [SPARK-28034][SQL][TEST] Port with.sql URL: https://github.com/apache/spark/pull/24860#issuecomment-510355155 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/te

[GitHub] [spark] AmplabJenkins commented on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax

2019-07-10 Thread GitBox
AmplabJenkins commented on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax URL: https://github.com/apache/spark/pull/25001#issuecomment-510355063 Merged build finished. Test PASSed. This is an automated messag

[GitHub] [spark] AmplabJenkins removed a comment on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax

2019-07-10 Thread GitBox
AmplabJenkins removed a comment on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax URL: https://github.com/apache/spark/pull/25001#issuecomment-510355063 Merged build finished. Test PASSed. This is an automate

[GitHub] [spark] AmplabJenkins commented on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax

2019-07-10 Thread GitBox
AmplabJenkins commented on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax URL: https://github.com/apache/spark/pull/25001#issuecomment-510355071 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jen

[GitHub] [spark] HyukjinKwon commented on a change in pull request #25101: [SPARK-28277][SQL][PYTHON][TESTS] Convert and port 'except.sql' into UDF test base

2019-07-10 Thread GitBox
HyukjinKwon commented on a change in pull request #25101: [SPARK-28277][SQL][PYTHON][TESTS] Convert and port 'except.sql' into UDF test base URL: https://github.com/apache/spark/pull/25101#discussion_r302387733 ## File path: sql/core/src/test/resources/sql-tests/inputs/udf/udf-exce

[GitHub] [spark] cloud-fan commented on issue #25111: [SPARK-28346][SQL] clone the query plan between analyzer, optimizer and planner

2019-07-10 Thread GitBox
cloud-fan commented on issue #25111: [SPARK-28346][SQL] clone the query plan between analyzer, optimizer and planner URL: https://github.com/apache/spark/pull/25111#issuecomment-510354304 cc @hvanhovell @maryannxue @viirya @gatorsmile @HyukjinKwon -

[GitHub] [spark] cloud-fan commented on a change in pull request #25111: [SPARK-28346][SQL] clone the query plan between analyzer, optimizer and planner

2019-07-10 Thread GitBox
cloud-fan commented on a change in pull request #25111: [SPARK-28346][SQL] clone the query plan between analyzer, optimizer and planner URL: https://github.com/apache/spark/pull/25111#discussion_r302386994 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasou

[GitHub] [spark] HyukjinKwon commented on issue #25110: [SPARK-28270][SQL][FOLLOW-UP] Explicitly cast into integer/long in udf-aggregates_part1.sql to avoid Python float limitation

2019-07-10 Thread GitBox
HyukjinKwon commented on issue #25110: [SPARK-28270][SQL][FOLLOW-UP] Explicitly cast into integer/long in udf-aggregates_part1.sql to avoid Python float limitation URL: https://github.com/apache/spark/pull/25110#issuecomment-510353989 Yea Let me fix that one while I'm here. --

[GitHub] [spark] AmplabJenkins removed a comment on issue #25111: [SPARK-28346][SQL] clone the query plan between analyzer, optimizer and planner

2019-07-10 Thread GitBox
AmplabJenkins removed a comment on issue #25111: [SPARK-28346][SQL] clone the query plan between analyzer, optimizer and planner URL: https://github.com/apache/spark/pull/25111#issuecomment-510352855 Merged build finished. Test PASSed. --

[GitHub] [spark] cloud-fan commented on a change in pull request #25111: [SPARK-28346][SQL] clone the query plan between analyzer, optimizer and planner

2019-07-10 Thread GitBox
cloud-fan commented on a change in pull request #25111: [SPARK-28346][SQL] clone the query plan between analyzer, optimizer and planner URL: https://github.com/apache/spark/pull/25111#discussion_r302386743 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command

[GitHub] [spark] AmplabJenkins removed a comment on issue #25111: [SPARK-28346][SQL] clone the query plan between analyzer, optimizer and planner

2019-07-10 Thread GitBox
AmplabJenkins removed a comment on issue #25111: [SPARK-28346][SQL] clone the query plan between analyzer, optimizer and planner URL: https://github.com/apache/spark/pull/25111#issuecomment-510352863 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] cloud-fan commented on a change in pull request #25111: [SPARK-28346][SQL] clone the query plan between analyzer, optimizer and planner

2019-07-10 Thread GitBox
cloud-fan commented on a change in pull request #25111: [SPARK-28346][SQL] clone the query plan between analyzer, optimizer and planner URL: https://github.com/apache/spark/pull/25111#discussion_r302386541 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/columna

[GitHub] [spark] cloud-fan commented on a change in pull request #25111: [SPARK-28346][SQL] clone the query plan between analyzer, optimizer and planner

2019-07-10 Thread GitBox
cloud-fan commented on a change in pull request #25111: [SPARK-28346][SQL] clone the query plan between analyzer, optimizer and planner URL: https://github.com/apache/spark/pull/25111#discussion_r302386462 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plan

[GitHub] [spark] maropu commented on a change in pull request #25029: [SPARK-28228][SQL] Fix substitution order of nested WITH clauses

2019-07-10 Thread GitBox
maropu commented on a change in pull request #25029: [SPARK-28228][SQL] Fix substitution order of nested WITH clauses URL: https://github.com/apache/spark/pull/25029#discussion_r302386540 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CTESubstituti

[GitHub] [spark] beliefer commented on a change in pull request #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax

2019-07-10 Thread GitBox
beliefer commented on a change in pull request #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax URL: https://github.com/apache/spark/pull/25001#discussion_r302386285 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/RegexpExpressionsSuite.

[GitHub] [spark] SparkQA commented on issue #25111: [SPARK-28346][SQL] clone the query plan between analyzer, optimizer and planner

2019-07-10 Thread GitBox
SparkQA commented on issue #25111: [SPARK-28346][SQL] clone the query plan between analyzer, optimizer and planner URL: https://github.com/apache/spark/pull/25111#issuecomment-510353507 **[Test build #107513 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/10

[GitHub] [spark] maropu commented on a change in pull request #25029: [SPARK-28228][SQL] Fix substitution order of nested WITH clauses

2019-07-10 Thread GitBox
maropu commented on a change in pull request #25029: [SPARK-28228][SQL] Fix substitution order of nested WITH clauses URL: https://github.com/apache/spark/pull/25029#discussion_r302385954 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CTESubstituti

[GitHub] [spark] maropu commented on a change in pull request #25029: [SPARK-28228][SQL] Fix substitution order of nested WITH clauses

2019-07-10 Thread GitBox
maropu commented on a change in pull request #25029: [SPARK-28228][SQL] Fix substitution order of nested WITH clauses URL: https://github.com/apache/spark/pull/25029#discussion_r302385954 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CTESubstituti

[GitHub] [spark] AmplabJenkins commented on issue #25111: [SPARK-xxx][SQL] clone the query plan between analyzer, optimizer and planner

2019-07-10 Thread GitBox
AmplabJenkins commented on issue #25111: [SPARK-xxx][SQL] clone the query plan between analyzer, optimizer and planner URL: https://github.com/apache/spark/pull/25111#issuecomment-510352863 Test PASSed. Refer to this link for build results (access rights to CI server needed): https:

[GitHub] [spark] AmplabJenkins commented on issue #25111: [SPARK-xxx][SQL] clone the query plan between analyzer, optimizer and planner

2019-07-10 Thread GitBox
AmplabJenkins commented on issue #25111: [SPARK-xxx][SQL] clone the query plan between analyzer, optimizer and planner URL: https://github.com/apache/spark/pull/25111#issuecomment-510352855 Merged build finished. Test PASSed.

[GitHub] [spark] dongjoon-hyun commented on issue #25110: [SPARK-28270][SQL][FOLLOW-UP] Explicitly cast into integer/long in udf-aggregates_part1.sql to avoid Python float limitation

2019-07-10 Thread GitBox
dongjoon-hyun commented on issue #25110: [SPARK-28270][SQL][FOLLOW-UP] Explicitly cast into integer/long in udf-aggregates_part1.sql to avoid Python float limitation URL: https://github.com/apache/spark/pull/25110#issuecomment-510352914 Nit. Can we use Decimal instead? In case of 'corr', i

[GitHub] [spark] cloud-fan opened a new pull request #25111: [SPARK-xxx][SQL] clone the query plan between analyzer, optimizer and planner

2019-07-10 Thread GitBox
cloud-fan opened a new pull request #25111: [SPARK-xxx][SQL] clone the query plan between analyzer, optimizer and planner URL: https://github.com/apache/spark/pull/25111 ## What changes were proposed in this pull request? query plan was designed to be immutable, but sometimes we do a

[GitHub] [spark] huaxingao commented on a change in pull request #25101: [SPARK-28277][SQL][PYTHON][TESTS] Convert and port 'except.sql' into UDF test base

2019-07-10 Thread GitBox
huaxingao commented on a change in pull request #25101: [SPARK-28277][SQL][PYTHON][TESTS] Convert and port 'except.sql' into UDF test base URL: https://github.com/apache/spark/pull/25101#discussion_r302384736 ## File path: sql/core/src/test/resources/sql-tests/inputs/udf/udf-except

[GitHub] [spark] huaxingao commented on a change in pull request #25101: [SPARK-28277][SQL][PYTHON][TESTS] Convert and port 'except.sql' into UDF test base

2019-07-10 Thread GitBox
huaxingao commented on a change in pull request #25101: [SPARK-28277][SQL][PYTHON][TESTS] Convert and port 'except.sql' into UDF test base URL: https://github.com/apache/spark/pull/25101#discussion_r302384711 ## File path: sql/core/src/test/resources/sql-tests/inputs/udf/udf-except

[GitHub] [spark] huaxingao commented on a change in pull request #25101: [SPARK-28277][SQL][PYTHON][TESTS] Convert and port 'except.sql' into UDF test base

2019-07-10 Thread GitBox
huaxingao commented on a change in pull request #25101: [SPARK-28277][SQL][PYTHON][TESTS] Convert and port 'except.sql' into UDF test base URL: https://github.com/apache/spark/pull/25101#discussion_r302384662 ## File path: sql/core/src/test/resources/sql-tests/inputs/udf/udf-except

[GitHub] [spark] HyukjinKwon commented on issue #25110: [SPARK-28270][SQL][FOLLOW-UP] Explicitly cast into integer/long in udf-aggregates_part1.sql to avoid Python float limitation

2019-07-10 Thread GitBox
HyukjinKwon commented on issue #25110: [SPARK-28270][SQL][FOLLOW-UP] Explicitly cast into integer/long in udf-aggregates_part1.sql to avoid Python float limitation URL: https://github.com/apache/spark/pull/25110#issuecomment-510352059 I double checked that it works with JDK 11 just for dou

[GitHub] [spark] SparkQA commented on issue #25029: [SPARK-28228][SQL] Fix substitution order of nested WITH clauses

2019-07-10 Thread GitBox
SparkQA commented on issue #25029: [SPARK-28228][SQL] Fix substitution order of nested WITH clauses URL: https://github.com/apache/spark/pull/25029#issuecomment-510351413 **[Test build #107512 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/107512/testReport

[GitHub] [spark] maropu edited a comment on issue #24860: [SPARK-28034][SQL][TEST] Port with.sql

2019-07-10 Thread GitBox
maropu edited a comment on issue #24860: [SPARK-28034][SQL][TEST] Port with.sql URL: https://github.com/apache/spark/pull/24860#issuecomment-510350433 ~Looks nice, will do now~ oh, @wangyum seems to be working on it. This i

[GitHub] [spark] AmplabJenkins removed a comment on issue #25029: [SPARK-28228][SQL] Fix substitution order of nested WITH clauses

2019-07-10 Thread GitBox
AmplabJenkins removed a comment on issue #25029: [SPARK-28228][SQL] Fix substitution order of nested WITH clauses URL: https://github.com/apache/spark/pull/25029#issuecomment-510350780 Merged build finished. Test PASSed. This

[GitHub] [spark] AmplabJenkins removed a comment on issue #25029: [SPARK-28228][SQL] Fix substitution order of nested WITH clauses

2019-07-10 Thread GitBox
AmplabJenkins removed a comment on issue #25029: [SPARK-28228][SQL] Fix substitution order of nested WITH clauses URL: https://github.com/apache/spark/pull/25029#issuecomment-510350787 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amp

[GitHub] [spark] AmplabJenkins commented on issue #25029: [SPARK-28228][SQL] Fix substitution order of nested WITH clauses

2019-07-10 Thread GitBox
AmplabJenkins commented on issue #25029: [SPARK-28228][SQL] Fix substitution order of nested WITH clauses URL: https://github.com/apache/spark/pull/25029#issuecomment-510350780 Merged build finished. Test PASSed. This is an a

[GitHub] [spark] AmplabJenkins commented on issue #25029: [SPARK-28228][SQL] Fix substitution order of nested WITH clauses

2019-07-10 Thread GitBox
AmplabJenkins commented on issue #25029: [SPARK-28228][SQL] Fix substitution order of nested WITH clauses URL: https://github.com/apache/spark/pull/25029#issuecomment-510350787 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.b

[GitHub] [spark] maropu commented on issue #24860: [SPARK-28034][SQL][TEST] Port with.sql

2019-07-10 Thread GitBox
maropu commented on issue #24860: [SPARK-28034][SQL][TEST] Port with.sql URL: https://github.com/apache/spark/pull/24860#issuecomment-510350433 Looks nice, will do now This is an automated message from the Apache Git Service.

[GitHub] [spark] peter-toth commented on a change in pull request #25029: [SPARK-28228][SQL] Fix substitution order of nested WITH clauses

2019-07-10 Thread GitBox
peter-toth commented on a change in pull request #25029: [SPARK-28228][SQL] Fix substitution order of nested WITH clauses URL: https://github.com/apache/spark/pull/25029#discussion_r302382497 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CTESubsti

[GitHub] [spark] AmplabJenkins removed a comment on issue #25110: [SPARK-28270][SQL][FOLLOW-UP] Explicitly cast into integer/long in udf-aggregates_part1.sql to avoid Python float limitation

2019-07-10 Thread GitBox
AmplabJenkins removed a comment on issue #25110: [SPARK-28270][SQL][FOLLOW-UP] Explicitly cast into integer/long in udf-aggregates_part1.sql to avoid Python float limitation URL: https://github.com/apache/spark/pull/25110#issuecomment-510348570 Merged build finished. Test PASSed.

[GitHub] [spark] SparkQA commented on issue #25110: [SPARK-28270][SQL][FOLLOW-UP] Explicitly cast into integer/long in udf-aggregates_part1.sql to avoid Python float limitation

2019-07-10 Thread GitBox
SparkQA commented on issue #25110: [SPARK-28270][SQL][FOLLOW-UP] Explicitly cast into integer/long in udf-aggregates_part1.sql to avoid Python float limitation URL: https://github.com/apache/spark/pull/25110#issuecomment-510349217 **[Test build #107511 has started](https://amplab.cs.berke

[GitHub] [spark] AmplabJenkins commented on issue #25110: [SPARK-28270][SQL][FOLLOW-UP] Explicitly cast into integer/long in udf-aggregates_part1.sql to avoid Python float limitation

2019-07-10 Thread GitBox
AmplabJenkins commented on issue #25110: [SPARK-28270][SQL][FOLLOW-UP] Explicitly cast into integer/long in udf-aggregates_part1.sql to avoid Python float limitation URL: https://github.com/apache/spark/pull/25110#issuecomment-510348570 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #25110: [SPARK-28270][SQL][FOLLOW-UP] Explicitly cast into integer/long in udf-aggregates_part1.sql to avoid Python float limitation

2019-07-10 Thread GitBox
AmplabJenkins commented on issue #25110: [SPARK-28270][SQL][FOLLOW-UP] Explicitly cast into integer/long in udf-aggregates_part1.sql to avoid Python float limitation URL: https://github.com/apache/spark/pull/25110#issuecomment-510348576 Test PASSed. Refer to this link for build results

[GitHub] [spark] maropu commented on a change in pull request #25096: [SPARK-28334][SQL][TEST] Port select.sql

2019-07-10 Thread GitBox
maropu commented on a change in pull request #25096: [SPARK-28334][SQL][TEST] Port select.sql URL: https://github.com/apache/spark/pull/25096#discussion_r302379700 ## File path: sql/core/src/test/resources/sql-tests/inputs/pgSQL/select.sql ## @@ -0,0 +1,282 @@ +-- +-- Port

[GitHub] [spark] maropu edited a comment on issue #25096: [SPARK-28334][SQL][TEST] Port select.sql

2019-07-10 Thread GitBox
maropu edited a comment on issue #25096: [SPARK-28334][SQL][TEST] Port select.sql URL: https://github.com/apache/spark/pull/25096#issuecomment-510344390 I left one comment though, it looks ok to me. This is an automated messa

[GitHub] [spark] AmplabJenkins removed a comment on issue #25110: [SPARK-28270][SQL][FOLLOW-UP] Explicitly cast into integer/long in udf-aggregates_part1.sql to avoid Python float limitation

2019-07-10 Thread GitBox
AmplabJenkins removed a comment on issue #25110: [SPARK-28270][SQL][FOLLOW-UP] Explicitly cast into integer/long in udf-aggregates_part1.sql to avoid Python float limitation URL: https://github.com/apache/spark/pull/25110#issuecomment-510346586 Merged build finished. Test PASSed.

[GitHub] [spark] SparkQA commented on issue #25110: [SPARK-28270][SQL][FOLLOW-UP] Explicitly cast into integer/long in udf-aggregates_part1.sql to avoid Python float limitation

2019-07-10 Thread GitBox
SparkQA commented on issue #25110: [SPARK-28270][SQL][FOLLOW-UP] Explicitly cast into integer/long in udf-aggregates_part1.sql to avoid Python float limitation URL: https://github.com/apache/spark/pull/25110#issuecomment-510347086 **[Test build #107510 has started](https://amplab.cs.berke

[GitHub] [spark] AmplabJenkins removed a comment on issue #25110: [SPARK-28270][SQL][FOLLOW-UP] Explicitly cast into integer/long in udf-aggregates_part1.sql to avoid Python float limitation

2019-07-10 Thread GitBox
AmplabJenkins removed a comment on issue #25110: [SPARK-28270][SQL][FOLLOW-UP] Explicitly cast into integer/long in udf-aggregates_part1.sql to avoid Python float limitation URL: https://github.com/apache/spark/pull/25110#issuecomment-510346597 Test PASSed. Refer to this link for build

[GitHub] [spark] maropu commented on a change in pull request #25096: [SPARK-28334][SQL][TEST] Port select.sql

2019-07-10 Thread GitBox
maropu commented on a change in pull request #25096: [SPARK-28334][SQL][TEST] Port select.sql URL: https://github.com/apache/spark/pull/25096#discussion_r302379700 ## File path: sql/core/src/test/resources/sql-tests/inputs/pgSQL/select.sql ## @@ -0,0 +1,282 @@ +-- +-- Port

[GitHub] [spark] AmplabJenkins commented on issue #25110: [SPARK-28270][SQL][FOLLOW-UP] Explicitly cast into integer/long in udf-aggregates_part1.sql to avoid Python float limitation

2019-07-10 Thread GitBox
AmplabJenkins commented on issue #25110: [SPARK-28270][SQL][FOLLOW-UP] Explicitly cast into integer/long in udf-aggregates_part1.sql to avoid Python float limitation URL: https://github.com/apache/spark/pull/25110#issuecomment-510346586 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #25110: [SPARK-28270][SQL][FOLLOW-UP] Explicitly cast into integer/long in udf-aggregates_part1.sql to avoid Python float limitation

2019-07-10 Thread GitBox
AmplabJenkins commented on issue #25110: [SPARK-28270][SQL][FOLLOW-UP] Explicitly cast into integer/long in udf-aggregates_part1.sql to avoid Python float limitation URL: https://github.com/apache/spark/pull/25110#issuecomment-510346597 Test PASSed. Refer to this link for build results

[GitHub] [spark] HyukjinKwon commented on issue #25110: [SPARK-28270][SQL][FOLLOW-UP] Explicitly cast into integer/long in udf-aggregates_part1.sql to avoid Python float limitation

2019-07-10 Thread GitBox
HyukjinKwon commented on issue #25110: [SPARK-28270][SQL][FOLLOW-UP] Explicitly cast into integer/long in udf-aggregates_part1.sql to avoid Python float limitation URL: https://github.com/apache/spark/pull/25110#issuecomment-510345861 FYI @viirya, @skonto, @imback82, @huaxingao, @vinodkc,

[GitHub] [spark] HyukjinKwon commented on issue #25110: [SPARK-28270][SQL][FOLLOW-UP] Explicitly cast into integer/long in udf-aggregates_part1.sql to avoid Python float limitation

2019-07-10 Thread GitBox
HyukjinKwon commented on issue #25110: [SPARK-28270][SQL][FOLLOW-UP] Explicitly cast into integer/long in udf-aggregates_part1.sql to avoid Python float limitation URL: https://github.com/apache/spark/pull/25110#issuecomment-510345469 cc @dongjoon-hyun

[GitHub] [spark] HyukjinKwon opened a new pull request #25110: [SPARK-28270][SQL][FOLLOW-UP] Explicitly cast into integer/long in udf-aggregates_part1.sql to avoid Python float limitation

2019-07-10 Thread GitBox
HyukjinKwon opened a new pull request #25110: [SPARK-28270][SQL][FOLLOW-UP] Explicitly cast into integer/long in udf-aggregates_part1.sql to avoid Python float limitation URL: https://github.com/apache/spark/pull/25110 ## What changes were proposed in this pull request? The tests ad

[GitHub] [spark] maropu commented on issue #25096: [SPARK-28334][SQL][TEST] Port select.sql

2019-07-10 Thread GitBox
maropu commented on issue #25096: [SPARK-28334][SQL][TEST] Port select.sql URL: https://github.com/apache/spark/pull/25096#issuecomment-510344390 sure, I'll check This is an automated message from the Apache Git Service. To re

[GitHub] [spark] beliefer commented on a change in pull request #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax

2019-07-10 Thread GitBox
beliefer commented on a change in pull request #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax URL: https://github.com/apache/spark/pull/25001#discussion_r302342786 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/regexpExpressions.scala

[GitHub] [spark] AmplabJenkins removed a comment on issue #25109: [SPARK-28343][SQL][TEST] PostgreSQL test should enable cartesian product

2019-07-10 Thread GitBox
AmplabJenkins removed a comment on issue #25109: [SPARK-28343][SQL][TEST] PostgreSQL test should enable cartesian product URL: https://github.com/apache/spark/pull/25109#issuecomment-510340877 Merged build finished. Test PASSed. -

[GitHub] [spark] SparkQA commented on issue #25109: [SPARK-28343][SQL][TEST] PostgreSQL test should enable cartesian product

2019-07-10 Thread GitBox
SparkQA commented on issue #25109: [SPARK-28343][SQL][TEST] PostgreSQL test should enable cartesian product URL: https://github.com/apache/spark/pull/25109#issuecomment-510341474 **[Test build #107509 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/107509/te

[GitHub] [spark] AmplabJenkins removed a comment on issue #25109: [SPARK-28343][SQL][TEST] PostgreSQL test should enable cartesian product

2019-07-10 Thread GitBox
AmplabJenkins removed a comment on issue #25109: [SPARK-28343][SQL][TEST] PostgreSQL test should enable cartesian product URL: https://github.com/apache/spark/pull/25109#issuecomment-510340883 Test PASSed. Refer to this link for build results (access rights to CI server needed): htt

[GitHub] [spark] AmplabJenkins commented on issue #25090: [SPARK-28278][SQL][PYTHON][TESTS] Convert and port 'except-all.sql' into UDF test base

2019-07-10 Thread GitBox
AmplabJenkins commented on issue #25090: [SPARK-28278][SQL][PYTHON][TESTS] Convert and port 'except-all.sql' into UDF test base URL: https://github.com/apache/spark/pull/25090#issuecomment-510341195 Merged build finished. Test PASSed. ---

[GitHub] [spark] AmplabJenkins removed a comment on issue #25090: [SPARK-28278][SQL][PYTHON][TESTS] Convert and port 'except-all.sql' into UDF test base

2019-07-10 Thread GitBox
AmplabJenkins removed a comment on issue #25090: [SPARK-28278][SQL][PYTHON][TESTS] Convert and port 'except-all.sql' into UDF test base URL: https://github.com/apache/spark/pull/25090#issuecomment-510341202 Test PASSed. Refer to this link for build results (access rights to CI server ne

[GitHub] [spark] AmplabJenkins removed a comment on issue #25090: [SPARK-28278][SQL][PYTHON][TESTS] Convert and port 'except-all.sql' into UDF test base

2019-07-10 Thread GitBox
AmplabJenkins removed a comment on issue #25090: [SPARK-28278][SQL][PYTHON][TESTS] Convert and port 'except-all.sql' into UDF test base URL: https://github.com/apache/spark/pull/25090#issuecomment-510341195 Merged build finished. Test PASSed. --

[GitHub] [spark] AmplabJenkins commented on issue #25090: [SPARK-28278][SQL][PYTHON][TESTS] Convert and port 'except-all.sql' into UDF test base

2019-07-10 Thread GitBox
AmplabJenkins commented on issue #25090: [SPARK-28278][SQL][PYTHON][TESTS] Convert and port 'except-all.sql' into UDF test base URL: https://github.com/apache/spark/pull/25090#issuecomment-510341202 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] wangyum commented on issue #25109: [SPARK-28343][SQL][TEST] PostgreSQL test should enable cartesian product

2019-07-10 Thread GitBox
wangyum commented on issue #25109: [SPARK-28343][SQL][TEST] PostgreSQL test should enable cartesian product URL: https://github.com/apache/spark/pull/25109#issuecomment-510341125 @maropu I didn't enable `spark.sql.parser.ansi.enabled` because: ```sql spark-sql> set spark.sql.parser.an

[GitHub] [spark] maropu commented on a change in pull request #25074: [SPARK-27924]Support ANSI SQL Boolean-Predicate syntax

2019-07-10 Thread GitBox
maropu commented on a change in pull request #25074: [SPARK-27924]Support ANSI SQL Boolean-Predicate syntax URL: https://github.com/apache/spark/pull/25074#discussion_r302374072 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/booleanExpressions.

[GitHub] [spark] SparkQA removed a comment on issue #25090: [SPARK-28278][SQL][PYTHON][TESTS] Convert and port 'except-all.sql' into UDF test base

2019-07-10 Thread GitBox
SparkQA removed a comment on issue #25090: [SPARK-28278][SQL][PYTHON][TESTS] Convert and port 'except-all.sql' into UDF test base URL: https://github.com/apache/spark/pull/25090#issuecomment-510303053 **[Test build #107501 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRe

[GitHub] [spark] AmplabJenkins commented on issue #25109: [SPARK-28343][SQL][TEST] PostgreSQL test should enable cartesian product

2019-07-10 Thread GitBox
AmplabJenkins commented on issue #25109: [SPARK-28343][SQL][TEST] PostgreSQL test should enable cartesian product URL: https://github.com/apache/spark/pull/25109#issuecomment-510340877 Merged build finished. Test PASSed. This

[GitHub] [spark] AmplabJenkins commented on issue #25109: [SPARK-28343][SQL][TEST] PostgreSQL test should enable cartesian product

2019-07-10 Thread GitBox
AmplabJenkins commented on issue #25109: [SPARK-28343][SQL][TEST] PostgreSQL test should enable cartesian product URL: https://github.com/apache/spark/pull/25109#issuecomment-510340883 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amp

[GitHub] [spark] SparkQA commented on issue #25090: [SPARK-28278][SQL][PYTHON][TESTS] Convert and port 'except-all.sql' into UDF test base

2019-07-10 Thread GitBox
SparkQA commented on issue #25090: [SPARK-28278][SQL][PYTHON][TESTS] Convert and port 'except-all.sql' into UDF test base URL: https://github.com/apache/spark/pull/25090#issuecomment-510340755 **[Test build #107501 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBu

[GitHub] [spark] dongjoon-hyun commented on issue #25069: [SPARK-28270][SQL][PYTHON] Convert and port 'pgSQL/aggregates_part1.sql' into UDF test base

2019-07-10 Thread GitBox
dongjoon-hyun commented on issue #25069: [SPARK-28270][SQL][PYTHON] Convert and port 'pgSQL/aggregates_part1.sql' into UDF test base URL: https://github.com/apache/spark/pull/25069#issuecomment-510340656 Thanks a lot! This is

[GitHub] [spark] wangyum opened a new pull request #25109: [SPARK-28343][SQL][TEST] PostgreSQL test should enable cartesian product

2019-07-10 Thread GitBox
wangyum opened a new pull request #25109: [SPARK-28343][SQL][TEST] PostgreSQL test should enable cartesian product URL: https://github.com/apache/spark/pull/25109 ## What changes were proposed in this pull request? This pr enables cartesian product for PostgreSQL test. ## How

[GitHub] [spark] SparkQA commented on issue #24637: [SPARK-27707][SQL] Prune unnecessary nested fields from Generate in explode

2019-07-10 Thread GitBox
SparkQA commented on issue #24637: [SPARK-27707][SQL] Prune unnecessary nested fields from Generate in explode URL: https://github.com/apache/spark/pull/24637#issuecomment-510339651 **[Test build #107508 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/107508

[GitHub] [spark] AmplabJenkins removed a comment on issue #25108: [SPARK-28321][SQL] 0-args Java UDF should not be called only once

2019-07-10 Thread GitBox
AmplabJenkins removed a comment on issue #25108: [SPARK-28321][SQL] 0-args Java UDF should not be called only once URL: https://github.com/apache/spark/pull/25108#issuecomment-510339208 Merged build finished. Test PASSed. Thi

[GitHub] [spark] AmplabJenkins removed a comment on issue #24637: [SPARK-27707][SQL] Prune unnecessary nested fields from Generate in explode

2019-07-10 Thread GitBox
AmplabJenkins removed a comment on issue #24637: [SPARK-27707][SQL] Prune unnecessary nested fields from Generate in explode URL: https://github.com/apache/spark/pull/24637#issuecomment-510339171 Merged build finished. Test PASSed. --

[GitHub] [spark] SparkQA commented on issue #25108: [SPARK-28321][SQL] 0-args Java UDF should not be called only once

2019-07-10 Thread GitBox
SparkQA commented on issue #25108: [SPARK-28321][SQL] 0-args Java UDF should not be called only once URL: https://github.com/apache/spark/pull/25108#issuecomment-510339633 **[Test build #107507 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/107507/testRepor

[GitHub] [spark] HyukjinKwon commented on issue #25069: [SPARK-28270][SQL][PYTHON] Convert and port 'pgSQL/aggregates_part1.sql' into UDF test base

2019-07-10 Thread GitBox
HyukjinKwon commented on issue #25069: [SPARK-28270][SQL][PYTHON] Convert and port 'pgSQL/aggregates_part1.sql' into UDF test base URL: https://github.com/apache/spark/pull/25069#issuecomment-510339534 It actually passed in my local as well.. but seems dependent on specific Python version

[GitHub] [spark] AmplabJenkins removed a comment on issue #24637: [SPARK-27707][SQL] Prune unnecessary nested fields from Generate in explode

2019-07-10 Thread GitBox
AmplabJenkins removed a comment on issue #24637: [SPARK-27707][SQL] Prune unnecessary nested fields from Generate in explode URL: https://github.com/apache/spark/pull/24637#issuecomment-510339180 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] dongjoon-hyun commented on issue #25069: [SPARK-28270][SQL][PYTHON] Convert and port 'pgSQL/aggregates_part1.sql' into UDF test base

2019-07-10 Thread GitBox
dongjoon-hyun commented on issue #25069: [SPARK-28270][SQL][PYTHON] Convert and port 'pgSQL/aggregates_part1.sql' into UDF test base URL: https://github.com/apache/spark/pull/25069#issuecomment-510339155 Ya. Please check locally first because the above report is on JDK11~ -

[GitHub] [spark] AmplabJenkins commented on issue #24637: [SPARK-27707][SQL] Prune unnecessary nested fields from Generate in explode

2019-07-10 Thread GitBox
AmplabJenkins commented on issue #24637: [SPARK-27707][SQL] Prune unnecessary nested fields from Generate in explode URL: https://github.com/apache/spark/pull/24637#issuecomment-510339171 Merged build finished. Test PASSed. T

[GitHub] [spark] AmplabJenkins commented on issue #25108: [SPARK-28321][SQL] 0-args Java UDF should not be called only once

2019-07-10 Thread GitBox
AmplabJenkins commented on issue #25108: [SPARK-28321][SQL] 0-args Java UDF should not be called only once URL: https://github.com/apache/spark/pull/25108#issuecomment-510339214 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.

[GitHub] [spark] dongjoon-hyun edited a comment on issue #25069: [SPARK-28270][SQL][PYTHON] Convert and port 'pgSQL/aggregates_part1.sql' into UDF test base

2019-07-10 Thread GitBox
dongjoon-hyun edited a comment on issue #25069: [SPARK-28270][SQL][PYTHON] Convert and port 'pgSQL/aggregates_part1.sql' into UDF test base URL: https://github.com/apache/spark/pull/25069#issuecomment-510339155 Thanks. Ya. Please check locally first because the above report is on JDK11~ --

[GitHub] [spark] AmplabJenkins commented on issue #25108: [SPARK-28321][SQL] 0-args Java UDF should not be called only once

2019-07-10 Thread GitBox
AmplabJenkins commented on issue #25108: [SPARK-28321][SQL] 0-args Java UDF should not be called only once URL: https://github.com/apache/spark/pull/25108#issuecomment-510339208 Merged build finished. Test PASSed. This is an

[GitHub] [spark] AmplabJenkins commented on issue #24637: [SPARK-27707][SQL] Prune unnecessary nested fields from Generate in explode

2019-07-10 Thread GitBox
AmplabJenkins commented on issue #24637: [SPARK-27707][SQL] Prune unnecessary nested fields from Generate in explode URL: https://github.com/apache/spark/pull/24637#issuecomment-510339180 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://

[GitHub] [spark] HyukjinKwon commented on issue #25069: [SPARK-28270][SQL][PYTHON] Convert and port 'pgSQL/aggregates_part1.sql' into UDF test base

2019-07-10 Thread GitBox
HyukjinKwon commented on issue #25069: [SPARK-28270][SQL][PYTHON] Convert and port 'pgSQL/aggregates_part1.sql' into UDF test base URL: https://github.com/apache/spark/pull/25069#issuecomment-510339061 Will take a look and revert it's going to take longer. -

[GitHub] [spark] HyukjinKwon opened a new pull request #25069: [SPARK-28270][SQL][PYTHON] Convert and port 'pgSQL/aggregates_part1.sql' into UDF test base

2019-07-10 Thread GitBox
HyukjinKwon opened a new pull request #25069: [SPARK-28270][SQL][PYTHON] Convert and port 'pgSQL/aggregates_part1.sql' into UDF test base URL: https://github.com/apache/spark/pull/25069 ## What changes were proposed in this pull request? This PR adds some tests converted from `pgSQL/

[GitHub] [spark] HyukjinKwon closed pull request #25069: [SPARK-28270][SQL][PYTHON] Convert and port 'pgSQL/aggregates_part1.sql' into UDF test base

2019-07-10 Thread GitBox
HyukjinKwon closed pull request #25069: [SPARK-28270][SQL][PYTHON] Convert and port 'pgSQL/aggregates_part1.sql' into UDF test base URL: https://github.com/apache/spark/pull/25069 This is an automated message from the Apache

[GitHub] [spark] HyukjinKwon commented on issue #25108: [SPARK-28321][SQL] 0-args Java UDF should not be called only once

2019-07-10 Thread GitBox
HyukjinKwon commented on issue #25108: [SPARK-28321][SQL] 0-args Java UDF should not be called only once URL: https://github.com/apache/spark/pull/25108#issuecomment-510338860 cc @cloud-fan This is an automated message from t

[GitHub] [spark] dongjoon-hyun edited a comment on issue #25069: [SPARK-28270][SQL][PYTHON] Convert and port 'pgSQL/aggregates_part1.sql' into UDF test base

2019-07-10 Thread GitBox
dongjoon-hyun edited a comment on issue #25069: [SPARK-28270][SQL][PYTHON] Convert and port 'pgSQL/aggregates_part1.sql' into UDF test base URL: https://github.com/apache/spark/pull/25069#issuecomment-510338586 Could you investigate this? For the others, this commit is still on testings. -

[GitHub] [spark] dongjoon-hyun commented on issue #25069: [SPARK-28270][SQL][PYTHON] Convert and port 'pgSQL/aggregates_part1.sql' into UDF test base

2019-07-10 Thread GitBox
dongjoon-hyun commented on issue #25069: [SPARK-28270][SQL][PYTHON] Convert and port 'pgSQL/aggregates_part1.sql' into UDF test base URL: https://github.com/apache/spark/pull/25069#issuecomment-510338586 Could you investigate this? --

[GitHub] [spark] HyukjinKwon opened a new pull request #25108: [SPARK-28321][SQL] 0-args Java UDF should not be called only once

2019-07-10 Thread GitBox
HyukjinKwon opened a new pull request #25108: [SPARK-28321][SQL] 0-args Java UDF should not be called only once URL: https://github.com/apache/spark/pull/25108 ## What changes were proposed in this pull request? 0-args Java UDF alone calls the function even before making it as an ex

[GitHub] [spark] dongjoon-hyun commented on issue #25069: [SPARK-28270][SQL][PYTHON] Convert and port 'pgSQL/aggregates_part1.sql' into UDF test base

2019-07-10 Thread GitBox
dongjoon-hyun commented on issue #25069: [SPARK-28270][SQL][PYTHON] Convert and port 'pgSQL/aggregates_part1.sql' into UDF test base URL: https://github.com/apache/spark/pull/25069#issuecomment-510338469 @HyukjinKwon . This `udf/pgSQL/udf-aggregates_part1.sql - Regular Python UDF` failed t

[GitHub] [spark] maropu commented on a change in pull request #25074: [SPARK-27924]Support ANSI SQL Boolean-Predicate syntax

2019-07-10 Thread GitBox
maropu commented on a change in pull request #25074: [SPARK-27924]Support ANSI SQL Boolean-Predicate syntax URL: https://github.com/apache/spark/pull/25074#discussion_r302371689 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/booleanExpressions.

[GitHub] [spark] SparkQA commented on issue #25107: [SPARK-28344][SQL] detect ambiguous self-join and fail the query

2019-07-10 Thread GitBox
SparkQA commented on issue #25107: [SPARK-28344][SQL] detect ambiguous self-join and fail the query URL: https://github.com/apache/spark/pull/25107#issuecomment-510336280 **[Test build #107505 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/107505/testReport

[GitHub] [spark] dongjoon-hyun commented on issue #24637: [SPARK-27707][SQL] Prune unnecessary nested fields from Generate in explode

2019-07-10 Thread GitBox
dongjoon-hyun commented on issue #24637: [SPARK-27707][SQL] Prune unnecessary nested fields from Generate in explode URL: https://github.com/apache/spark/pull/24637#issuecomment-510336289 I made a PR to you which reverts all the other benchmark result to the master and adds the newly added

[GitHub] [spark] SparkQA commented on issue #24637: [SPARK-27707][SQL] Prune unnecessary nested fields from Generate in explode

2019-07-10 Thread GitBox
SparkQA commented on issue #24637: [SPARK-27707][SQL] Prune unnecessary nested fields from Generate in explode URL: https://github.com/apache/spark/pull/24637#issuecomment-510336276 **[Test build #107506 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/107506

  1   2   3   4   5   6   7   8   9   10   >