[GitHub] [spark] sandeep-katta commented on a change in pull request #25542: [SPARK-28840][SQL][test-hadoop3.2][test-maven] conf.getClassLoader in SparkSQLCLIDriver should be avoided as it returns the

2019-09-02 Thread GitBox
sandeep-katta commented on a change in pull request #25542: [SPARK-28840][SQL][test-hadoop3.2][test-maven] conf.getClassLoader in SparkSQLCLIDriver should be avoided as it returns the UDFClassLoader which is created by Hive URL: https://github.com/apache/spark/pull/25542#discussion_r320111874

[GitHub] [spark] advancedxy commented on a change in pull request #25616: [SPARK-28907][CORE] Review invalid usage of new Configuration()

2019-09-02 Thread GitBox
advancedxy commented on a change in pull request #25616: [SPARK-28907][CORE] Review invalid usage of new Configuration() URL: https://github.com/apache/spark/pull/25616#discussion_r320109590 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/HadoopFile

[GitHub] [spark] SparkQA commented on issue #25530: [SPARK-28805][DOCS][SQL] Document DESCRIBE FUNCTION in SQL Reference

2019-09-02 Thread GitBox
SparkQA commented on issue #25530: [SPARK-28805][DOCS][SQL] Document DESCRIBE FUNCTION in SQL Reference URL: https://github.com/apache/spark/pull/25530#issuecomment-527322376 **[Test build #110030 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/110030/testR

[GitHub] [spark] AmplabJenkins removed a comment on issue #25531: [SPARK-28806][DOCS][SQL] Document SHOW COLUMNS in SQL Reference

2019-09-02 Thread GitBox
AmplabJenkins removed a comment on issue #25531: [SPARK-28806][DOCS][SQL] Document SHOW COLUMNS in SQL Reference URL: https://github.com/apache/spark/pull/25531#issuecomment-527322399 Merged build finished. Test PASSed. This

[GitHub] [spark] AmplabJenkins commented on issue #25531: [SPARK-28806][DOCS][SQL] Document SHOW COLUMNS in SQL Reference

2019-09-02 Thread GitBox
AmplabJenkins commented on issue #25531: [SPARK-28806][DOCS][SQL] Document SHOW COLUMNS in SQL Reference URL: https://github.com/apache/spark/pull/25531#issuecomment-527322399 Merged build finished. Test PASSed. This is an au

[GitHub] [spark] AmplabJenkins commented on issue #25530: [SPARK-28805][DOCS][SQL] Document DESCRIBE FUNCTION in SQL Reference

2019-09-02 Thread GitBox
AmplabJenkins commented on issue #25530: [SPARK-28805][DOCS][SQL] Document DESCRIBE FUNCTION in SQL Reference URL: https://github.com/apache/spark/pull/25530#issuecomment-527322450 Merged build finished. Test PASSed. This is

[GitHub] [spark] AmplabJenkins removed a comment on issue #25531: [SPARK-28806][DOCS][SQL] Document SHOW COLUMNS in SQL Reference

2019-09-02 Thread GitBox
AmplabJenkins removed a comment on issue #25531: [SPARK-28806][DOCS][SQL] Document SHOW COLUMNS in SQL Reference URL: https://github.com/apache/spark/pull/25531#issuecomment-527322406 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://ampla

[GitHub] [spark] AmplabJenkins removed a comment on issue #25530: [SPARK-28805][DOCS][SQL] Document DESCRIBE FUNCTION in SQL Reference

2019-09-02 Thread GitBox
AmplabJenkins removed a comment on issue #25530: [SPARK-28805][DOCS][SQL] Document DESCRIBE FUNCTION in SQL Reference URL: https://github.com/apache/spark/pull/25530#issuecomment-527322455 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://

[GitHub] [spark] AmplabJenkins removed a comment on issue #25530: [SPARK-28805][DOCS][SQL] Document DESCRIBE FUNCTION in SQL Reference

2019-09-02 Thread GitBox
AmplabJenkins removed a comment on issue #25530: [SPARK-28805][DOCS][SQL] Document DESCRIBE FUNCTION in SQL Reference URL: https://github.com/apache/spark/pull/25530#issuecomment-527322450 Merged build finished. Test PASSed.

[GitHub] [spark] SparkQA removed a comment on issue #25531: [SPARK-28806][DOCS][SQL] Document SHOW COLUMNS in SQL Reference

2019-09-02 Thread GitBox
SparkQA removed a comment on issue #25531: [SPARK-28806][DOCS][SQL] Document SHOW COLUMNS in SQL Reference URL: https://github.com/apache/spark/pull/25531#issuecomment-527319802 **[Test build #110029 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/110029/tes

[GitHub] [spark] AmplabJenkins commented on issue #25530: [SPARK-28805][DOCS][SQL] Document DESCRIBE FUNCTION in SQL Reference

2019-09-02 Thread GitBox
AmplabJenkins commented on issue #25530: [SPARK-28805][DOCS][SQL] Document DESCRIBE FUNCTION in SQL Reference URL: https://github.com/apache/spark/pull/25530#issuecomment-527322455 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.c

[GitHub] [spark] SparkQA removed a comment on issue #25530: [SPARK-28805][DOCS][SQL] Document DESCRIBE FUNCTION in SQL Reference

2019-09-02 Thread GitBox
SparkQA removed a comment on issue #25530: [SPARK-28805][DOCS][SQL] Document DESCRIBE FUNCTION in SQL Reference URL: https://github.com/apache/spark/pull/25530#issuecomment-527319794 **[Test build #110030 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/11003

[GitHub] [spark] AmplabJenkins commented on issue #25531: [SPARK-28806][DOCS][SQL] Document SHOW COLUMNS in SQL Reference

2019-09-02 Thread GitBox
AmplabJenkins commented on issue #25531: [SPARK-28806][DOCS][SQL] Document SHOW COLUMNS in SQL Reference URL: https://github.com/apache/spark/pull/25531#issuecomment-527322406 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.ber

[GitHub] [spark] SparkQA commented on issue #25531: [SPARK-28806][DOCS][SQL] Document SHOW COLUMNS in SQL Reference

2019-09-02 Thread GitBox
SparkQA commented on issue #25531: [SPARK-28806][DOCS][SQL] Document SHOW COLUMNS in SQL Reference URL: https://github.com/apache/spark/pull/25531#issuecomment-527322312 **[Test build #110029 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/110029/testReport

[GitHub] [spark] 19kka commented on issue #25450: [SPARK-23793][SQL]Handle database names in spark.udf.register()

2019-09-02 Thread GitBox
19kka commented on issue #25450: [SPARK-23793][SQL]Handle database names in spark.udf.register() URL: https://github.com/apache/spark/pull/25450#issuecomment-527322171 hello @dongjoon-hyun , Thank you for your reply In this commit I have modified `test("Temp function has dots in

[GitHub] [spark] AmplabJenkins removed a comment on issue #25530: [SPARK-28805][DOCS][SQL] Document DESCRIBE FUNCTION in SQL Reference

2019-09-02 Thread GitBox
AmplabJenkins removed a comment on issue #25530: [SPARK-28805][DOCS][SQL] Document DESCRIBE FUNCTION in SQL Reference URL: https://github.com/apache/spark/pull/25530#issuecomment-527321118 Test PASSed. Refer to this link for build results (access rights to CI server needed): https:/

[GitHub] [spark] AmplabJenkins removed a comment on issue #25530: [SPARK-28805][DOCS][SQL] Document DESCRIBE FUNCTION in SQL Reference

2019-09-02 Thread GitBox
AmplabJenkins removed a comment on issue #25530: [SPARK-28805][DOCS][SQL] Document DESCRIBE FUNCTION in SQL Reference URL: https://github.com/apache/spark/pull/25530#issuecomment-527321113 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #25530: [SPARK-28805][DOCS][SQL] Document DESCRIBE FUNCTION in SQL Reference

2019-09-02 Thread GitBox
AmplabJenkins commented on issue #25530: [SPARK-28805][DOCS][SQL] Document DESCRIBE FUNCTION in SQL Reference URL: https://github.com/apache/spark/pull/25530#issuecomment-527321113 Merged build finished. Test PASSed. This is

[GitHub] [spark] AmplabJenkins commented on issue #25530: [SPARK-28805][DOCS][SQL] Document DESCRIBE FUNCTION in SQL Reference

2019-09-02 Thread GitBox
AmplabJenkins commented on issue #25530: [SPARK-28805][DOCS][SQL] Document DESCRIBE FUNCTION in SQL Reference URL: https://github.com/apache/spark/pull/25530#issuecomment-527321118 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.

[GitHub] [spark] cloud-fan commented on issue #25620: [SPARK-25341][Core] Support rolling back a shuffle map stage and re-generate the shuffle files

2019-09-02 Thread GitBox
cloud-fan commented on issue #25620: [SPARK-25341][Core] Support rolling back a shuffle map stage and re-generate the shuffle files URL: https://github.com/apache/spark/pull/25620#issuecomment-527320076 I agree with @squito that `mapId` is vague now. How about `mapTID` and `mapIndex`? ---

[GitHub] [spark] cloud-fan edited a comment on issue #25620: [SPARK-25341][Core] Support rolling back a shuffle map stage and re-generate the shuffle files

2019-09-02 Thread GitBox
cloud-fan edited a comment on issue #25620: [SPARK-25341][Core] Support rolling back a shuffle map stage and re-generate the shuffle files URL: https://github.com/apache/spark/pull/25620#issuecomment-527320076 I agree with @squito that `mapId` is vague now. How about `mapTaskId` and `mapIn

[GitHub] [spark] SparkQA commented on issue #25450: [SPARK-23793][SQL]Handle database names in spark.udf.register()

2019-09-02 Thread GitBox
SparkQA commented on issue #25450: [SPARK-23793][SQL]Handle database names in spark.udf.register() URL: https://github.com/apache/spark/pull/25450#issuecomment-527319808 **[Test build #110031 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/110031/testReport)

[GitHub] [spark] SparkQA commented on issue #25530: [SPARK-28805][DOCS][SQL] Document DESCRIBE FUNCTION in SQL Reference

2019-09-02 Thread GitBox
SparkQA commented on issue #25530: [SPARK-28805][DOCS][SQL] Document DESCRIBE FUNCTION in SQL Reference URL: https://github.com/apache/spark/pull/25530#issuecomment-527319794 **[Test build #110030 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/110030/testRe

[GitHub] [spark] SparkQA commented on issue #25531: [SPARK-28806][DOCS][SQL] Document SHOW COLUMNS in SQL Reference

2019-09-02 Thread GitBox
SparkQA commented on issue #25531: [SPARK-28806][DOCS][SQL] Document SHOW COLUMNS in SQL Reference URL: https://github.com/apache/spark/pull/25531#issuecomment-527319802 **[Test build #110029 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/110029/testReport)

[GitHub] [spark] AmplabJenkins removed a comment on issue #25531: [SPARK-28806][DOCS][SQL] Document SHOW COLUMNS in SQL Reference

2019-09-02 Thread GitBox
AmplabJenkins removed a comment on issue #25531: [SPARK-28806][DOCS][SQL] Document SHOW COLUMNS in SQL Reference URL: https://github.com/apache/spark/pull/25531#issuecomment-527319295 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://ampl

[GitHub] [spark] AmplabJenkins removed a comment on issue #25450: [SPARK-23793][SQL]Handle database names in spark.udf.register()

2019-09-02 Thread GitBox
AmplabJenkins removed a comment on issue #25450: [SPARK-23793][SQL]Handle database names in spark.udf.register() URL: https://github.com/apache/spark/pull/25450#issuecomment-527319251 Merged build finished. Test PASSed. This

[GitHub] [spark] AmplabJenkins removed a comment on issue #25531: [SPARK-28806][DOCS][SQL] Document SHOW COLUMNS in SQL Reference

2019-09-02 Thread GitBox
AmplabJenkins removed a comment on issue #25531: [SPARK-28806][DOCS][SQL] Document SHOW COLUMNS in SQL Reference URL: https://github.com/apache/spark/pull/25531#issuecomment-527319286 Merged build finished. Test PASSed. This

[GitHub] [spark] AmplabJenkins removed a comment on issue #25450: [SPARK-23793][SQL]Handle database names in spark.udf.register()

2019-09-02 Thread GitBox
AmplabJenkins removed a comment on issue #25450: [SPARK-23793][SQL]Handle database names in spark.udf.register() URL: https://github.com/apache/spark/pull/25450#issuecomment-527319253 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://ampl

[GitHub] [spark] AmplabJenkins commented on issue #25450: [SPARK-23793][SQL]Handle database names in spark.udf.register()

2019-09-02 Thread GitBox
AmplabJenkins commented on issue #25450: [SPARK-23793][SQL]Handle database names in spark.udf.register() URL: https://github.com/apache/spark/pull/25450#issuecomment-527319251 Merged build finished. Test PASSed. This is an au

[GitHub] [spark] AmplabJenkins commented on issue #25531: [SPARK-28806][DOCS][SQL] Document SHOW COLUMNS in SQL Reference

2019-09-02 Thread GitBox
AmplabJenkins commented on issue #25531: [SPARK-28806][DOCS][SQL] Document SHOW COLUMNS in SQL Reference URL: https://github.com/apache/spark/pull/25531#issuecomment-527319295 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.be

[GitHub] [spark] AmplabJenkins commented on issue #25531: [SPARK-28806][DOCS][SQL] Document SHOW COLUMNS in SQL Reference

2019-09-02 Thread GitBox
AmplabJenkins commented on issue #25531: [SPARK-28806][DOCS][SQL] Document SHOW COLUMNS in SQL Reference URL: https://github.com/apache/spark/pull/25531#issuecomment-527319286 Merged build finished. Test PASSed. This is an au

[GitHub] [spark] AmplabJenkins commented on issue #25450: [SPARK-23793][SQL]Handle database names in spark.udf.register()

2019-09-02 Thread GitBox
AmplabJenkins commented on issue #25450: [SPARK-23793][SQL]Handle database names in spark.udf.register() URL: https://github.com/apache/spark/pull/25450#issuecomment-527319253 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.be

[GitHub] [spark] HyukjinKwon commented on issue #25647: [SPARK-28946][R][DOCS] Add some more information about building SparkR on Windows

2019-09-02 Thread GitBox
HyukjinKwon commented on issue #25647: [SPARK-28946][R][DOCS] Add some more information about building SparkR on Windows URL: https://github.com/apache/spark/pull/25647#issuecomment-527317840 Merged to master. Thanks for review @dongjoon-hyun and @felixcheung. --

[GitHub] [spark] HyukjinKwon closed pull request #25647: [SPARK-28946][R][DOCS] Add some more information about building SparkR on Windows

2019-09-02 Thread GitBox
HyukjinKwon closed pull request #25647: [SPARK-28946][R][DOCS] Add some more information about building SparkR on Windows URL: https://github.com/apache/spark/pull/25647 This is an automated message from the Apache Git Servi

[GitHub] [spark] SparkQA commented on issue #25450: [SPARK-23793][SQL]Handle database names in spark.udf.register()

2019-09-02 Thread GitBox
SparkQA commented on issue #25450: [SPARK-23793][SQL]Handle database names in spark.udf.register() URL: https://github.com/apache/spark/pull/25450#issuecomment-527317820 **[Test build #110028 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/110028/testReport)

[GitHub] [spark] AmplabJenkins removed a comment on issue #25450: [SPARK-23793][SQL]Handle database names in spark.udf.register()

2019-09-02 Thread GitBox
AmplabJenkins removed a comment on issue #25450: [SPARK-23793][SQL]Handle database names in spark.udf.register() URL: https://github.com/apache/spark/pull/25450#issuecomment-527317284 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://ampl

[GitHub] [spark] AmplabJenkins removed a comment on issue #25450: [SPARK-23793][SQL]Handle database names in spark.udf.register()

2019-09-02 Thread GitBox
AmplabJenkins removed a comment on issue #25450: [SPARK-23793][SQL]Handle database names in spark.udf.register() URL: https://github.com/apache/spark/pull/25450#issuecomment-527317280 Merged build finished. Test PASSed. This

[GitHub] [spark] AmplabJenkins commented on issue #25450: [SPARK-23793][SQL]Handle database names in spark.udf.register()

2019-09-02 Thread GitBox
AmplabJenkins commented on issue #25450: [SPARK-23793][SQL]Handle database names in spark.udf.register() URL: https://github.com/apache/spark/pull/25450#issuecomment-527317280 Merged build finished. Test PASSed. This is an au

[GitHub] [spark] AmplabJenkins commented on issue #25450: [SPARK-23793][SQL]Handle database names in spark.udf.register()

2019-09-02 Thread GitBox
AmplabJenkins commented on issue #25450: [SPARK-23793][SQL]Handle database names in spark.udf.register() URL: https://github.com/apache/spark/pull/25450#issuecomment-527317284 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.be

[GitHub] [spark] wangyum commented on a change in pull request #25542: [SPARK-28840][SQL][test-hadoop3.2][test-maven] conf.getClassLoader in SparkSQLCLIDriver should be avoided as it returns the UDFCl

2019-09-02 Thread GitBox
wangyum commented on a change in pull request #25542: [SPARK-28840][SQL][test-hadoop3.2][test-maven] conf.getClassLoader in SparkSQLCLIDriver should be avoided as it returns the UDFClassLoader which is created by Hive URL: https://github.com/apache/spark/pull/25542#discussion_r320100674 ##

[GitHub] [spark] wangyum commented on a change in pull request #25542: [SPARK-28840][SQL][test-hadoop3.2][test-maven] conf.getClassLoader in SparkSQLCLIDriver should be avoided as it returns the UDFCl

2019-09-02 Thread GitBox
wangyum commented on a change in pull request #25542: [SPARK-28840][SQL][test-hadoop3.2][test-maven] conf.getClassLoader in SparkSQLCLIDriver should be avoided as it returns the UDFClassLoader which is created by Hive URL: https://github.com/apache/spark/pull/25542#discussion_r320100972 ##

[GitHub] [spark] wangyum commented on a change in pull request #25542: [SPARK-28840][SQL][test-hadoop3.2][test-maven] conf.getClassLoader in SparkSQLCLIDriver should be avoided as it returns the UDFCl

2019-09-02 Thread GitBox
wangyum commented on a change in pull request #25542: [SPARK-28840][SQL][test-hadoop3.2][test-maven] conf.getClassLoader in SparkSQLCLIDriver should be avoided as it returns the UDFClassLoader which is created by Hive URL: https://github.com/apache/spark/pull/25542#discussion_r320100674 ##

[GitHub] [spark] SparkQA commented on issue #25651: [SPARK-28948][SQL] support data source v2 in CREATE TABLE USING

2019-09-02 Thread GitBox
SparkQA commented on issue #25651: [SPARK-28948][SQL] support data source v2 in CREATE TABLE USING URL: https://github.com/apache/spark/pull/25651#issuecomment-527314270 **[Test build #110027 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/110027/testReport)

[GitHub] [spark] AmplabJenkins removed a comment on issue #25651: [SPARK-28948][SQL] support data source v2 in CREATE TABLE USING

2019-09-02 Thread GitBox
AmplabJenkins removed a comment on issue #25651: [SPARK-28948][SQL] support data source v2 in CREATE TABLE USING URL: https://github.com/apache/spark/pull/25651#issuecomment-527313252 Merged build finished. Test PASSed. This

[GitHub] [spark] AmplabJenkins removed a comment on issue #25651: [SPARK-28948][SQL] support data source v2 in CREATE TABLE USING

2019-09-02 Thread GitBox
AmplabJenkins removed a comment on issue #25651: [SPARK-28948][SQL] support data source v2 in CREATE TABLE USING URL: https://github.com/apache/spark/pull/25651#issuecomment-527313256 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://ampl

[GitHub] [spark] AmplabJenkins commented on issue #25651: [SPARK-28948][SQL] support data source v2 in CREATE TABLE USING

2019-09-02 Thread GitBox
AmplabJenkins commented on issue #25651: [SPARK-28948][SQL] support data source v2 in CREATE TABLE USING URL: https://github.com/apache/spark/pull/25651#issuecomment-527313256 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.be

[GitHub] [spark] AmplabJenkins commented on issue #25651: [SPARK-28948][SQL] support data source v2 in CREATE TABLE USING

2019-09-02 Thread GitBox
AmplabJenkins commented on issue #25651: [SPARK-28948][SQL] support data source v2 in CREATE TABLE USING URL: https://github.com/apache/spark/pull/25651#issuecomment-527313252 Merged build finished. Test PASSed. This is an au

[GitHub] [spark] cloud-fan closed pull request #25306: [SPARK-28573][SQL] Convert InsertIntoTable(HiveTableRelation) to DataSource inserting for partitioned table

2019-09-02 Thread GitBox
cloud-fan closed pull request #25306: [SPARK-28573][SQL] Convert InsertIntoTable(HiveTableRelation) to DataSource inserting for partitioned table URL: https://github.com/apache/spark/pull/25306 This is an automated message f

[GitHub] [spark] cloud-fan commented on issue #25306: [SPARK-28573][SQL] Convert InsertIntoTable(HiveTableRelation) to DataSource inserting for partitioned table

2019-09-02 Thread GitBox
cloud-fan commented on issue #25306: [SPARK-28573][SQL] Convert InsertIntoTable(HiveTableRelation) to DataSource inserting for partitioned table URL: https://github.com/apache/spark/pull/25306#issuecomment-527312070 thanks, merging to master! ---

[GitHub] [spark] cloud-fan commented on a change in pull request #25626: [SPARK-28892][SQL] Add UPDATE support for DataSource V2

2019-09-02 Thread GitBox
cloud-fan commented on a change in pull request #25626: [SPARK-28892][SQL] Add UPDATE support for DataSource V2 URL: https://github.com/apache/spark/pull/25626#discussion_r320095937 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOp

[GitHub] [spark] AmplabJenkins removed a comment on issue #25653: [SPARK-28954][SQL] In SparkSQL CLI, pass extra jar through hive hive conf HIVEAUXJARS, we just use SessionResourceLoader API to cover

2019-09-02 Thread GitBox
AmplabJenkins removed a comment on issue #25653: [SPARK-28954][SQL] In SparkSQL CLI, pass extra jar through hive hive conf HIVEAUXJARS, we just use SessionResourceLoader API to cover multi-version problem URL: https://github.com/apache/spark/pull/25653#issuecomment-527197196 Can one of th

[GitHub] [spark] wangyum commented on issue #25653: [SPARK-28954][SQL] In SparkSQL CLI, pass extra jar through hive hive conf HIVEAUXJARS, we just use SessionResourceLoader API to cover multi-version

2019-09-02 Thread GitBox
wangyum commented on issue #25653: [SPARK-28954][SQL] In SparkSQL CLI, pass extra jar through hive hive conf HIVEAUXJARS, we just use SessionResourceLoader API to cover multi-version problem URL: https://github.com/apache/spark/pull/25653#issuecomment-527310354 ok to test ---

[GitHub] [spark] cloud-fan commented on a change in pull request #25626: [SPARK-28892][SQL] Add UPDATE support for DataSource V2

2019-09-02 Thread GitBox
cloud-fan commented on a change in pull request #25626: [SPARK-28892][SQL] Add UPDATE support for DataSource V2 URL: https://github.com/apache/spark/pull/25626#discussion_r320095359 ## File path: sql/core/src/test/scala/org/apache/spark/sql/sources/v2/DataSourceV2SQLSuite.scala ##

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #25611: [SPARK-28901][SQL] SparkThriftServer's Cancel SQL Operation show it in JDBC Tab UI

2019-09-02 Thread GitBox
AngersZh commented on a change in pull request #25611: [SPARK-28901][SQL] SparkThriftServer's Cancel SQL Operation show it in JDBC Tab UI URL: https://github.com/apache/spark/pull/25611#discussion_r320095042 ## File path: sql/hive-thriftserver/src/main/scala/org/apache/spark/sq

[GitHub] [spark] cloud-fan commented on a change in pull request #25626: [SPARK-28892][SQL] Add UPDATE support for DataSource V2

2019-09-02 Thread GitBox
cloud-fan commented on a change in pull request #25626: [SPARK-28892][SQL] Add UPDATE support for DataSource V2 URL: https://github.com/apache/spark/pull/25626#discussion_r320095143 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Stra

[GitHub] [spark] cloud-fan commented on a change in pull request #25626: [SPARK-28892][SQL] Add UPDATE support for DataSource V2

2019-09-02 Thread GitBox
cloud-fan commented on a change in pull request #25626: [SPARK-28892][SQL] Add UPDATE support for DataSource V2 URL: https://github.com/apache/spark/pull/25626#discussion_r320095086 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Stra

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #25611: [SPARK-28901][SQL] SparkThriftServer's Cancel SQL Operation show it in JDBC Tab UI

2019-09-02 Thread GitBox
AngersZh commented on a change in pull request #25611: [SPARK-28901][SQL] SparkThriftServer's Cancel SQL Operation show it in JDBC Tab UI URL: https://github.com/apache/spark/pull/25611#discussion_r320094261 ## File path: sql/hive-thriftserver/src/main/scala/org/apache/spark/sq

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #25611: [SPARK-28901][SQL] SparkThriftServer's Cancel SQL Operation show it in JDBC Tab UI

2019-09-02 Thread GitBox
AngersZh commented on a change in pull request #25611: [SPARK-28901][SQL] SparkThriftServer's Cancel SQL Operation show it in JDBC Tab UI URL: https://github.com/apache/spark/pull/25611#discussion_r320094261 ## File path: sql/hive-thriftserver/src/main/scala/org/apache/spark/sq

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #25611: [SPARK-28901][SQL] SparkThriftServer's Cancel SQL Operation show it in JDBC Tab UI

2019-09-02 Thread GitBox
AngersZh commented on a change in pull request #25611: [SPARK-28901][SQL] SparkThriftServer's Cancel SQL Operation show it in JDBC Tab UI URL: https://github.com/apache/spark/pull/25611#discussion_r320094276 ## File path: sql/hive-thriftserver/src/main/scala/org/apache/spark/sq

[GitHub] [spark] cloud-fan commented on a change in pull request #25626: [SPARK-28892][SQL] Add UPDATE support for DataSource V2

2019-09-02 Thread GitBox
cloud-fan commented on a change in pull request #25626: [SPARK-28892][SQL] Add UPDATE support for DataSource V2 URL: https://github.com/apache/spark/pull/25626#discussion_r320093967 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala ###

[GitHub] [spark] HyukjinKwon commented on a change in pull request #25654: [SPARK-28912][STREAMING] Fixed MatchError in getCheckpointFiles()

2019-09-02 Thread GitBox
HyukjinKwon commented on a change in pull request #25654: [SPARK-28912][STREAMING] Fixed MatchError in getCheckpointFiles() URL: https://github.com/apache/spark/pull/25654#discussion_r320091518 ## File path: streaming/src/main/scala/org/apache/spark/streaming/Checkpoint.scala #

[GitHub] [spark] HyukjinKwon commented on issue #25628: [SPARK-28897][Core]'coalesce' error when executing dataframe.na.fill

2019-09-02 Thread GitBox
HyukjinKwon commented on issue #25628: [SPARK-28897][Core]'coalesce' error when executing dataframe.na.fill URL: https://github.com/apache/spark/pull/25628#issuecomment-527302709 That works because you backquoted but the change seems removing the backquotes. --

[GitHub] [spark] cloud-fan commented on a change in pull request #25512: [SPARK-28782][SQL] Generator support in aggregate expressions

2019-09-02 Thread GitBox
cloud-fan commented on a change in pull request #25512: [SPARK-28782][SQL] Generator support in aggregate expressions URL: https://github.com/apache/spark/pull/25512#discussion_r320089158 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scal

[GitHub] [spark] PavithraRamachandran commented on issue #25628: [SPARK-28897][Core]'coalesce' error when executing dataframe.na.fill

2019-09-02 Thread GitBox
PavithraRamachandran commented on issue #25628: [SPARK-28897][Core]'coalesce' error when executing dataframe.na.fill URL: https://github.com/apache/spark/pull/25628#issuecomment-527300788 @HyukjinKwon i tested this case too.. It works fine. ![Screenshot from 2019-09-03 10-04-40](https:/

[GitHub] [spark] AmplabJenkins removed a comment on issue #22138: [SPARK-25151][SS] Apply Apache Commons Pool to KafkaDataConsumer

2019-09-02 Thread GitBox
AmplabJenkins removed a comment on issue #22138: [SPARK-25151][SS] Apply Apache Commons Pool to KafkaDataConsumer URL: https://github.com/apache/spark/pull/22138#issuecomment-527288814 Merged build finished. Test PASSed. This

[GitHub] [spark] AmplabJenkins removed a comment on issue #22138: [SPARK-25151][SS] Apply Apache Commons Pool to KafkaDataConsumer

2019-09-02 Thread GitBox
AmplabJenkins removed a comment on issue #22138: [SPARK-25151][SS] Apply Apache Commons Pool to KafkaDataConsumer URL: https://github.com/apache/spark/pull/22138#issuecomment-527288818 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://ampl

[GitHub] [spark] AmplabJenkins commented on issue #22138: [SPARK-25151][SS] Apply Apache Commons Pool to KafkaDataConsumer

2019-09-02 Thread GitBox
AmplabJenkins commented on issue #22138: [SPARK-25151][SS] Apply Apache Commons Pool to KafkaDataConsumer URL: https://github.com/apache/spark/pull/22138#issuecomment-527288814 Merged build finished. Test PASSed. This is an a

[GitHub] [spark] AmplabJenkins commented on issue #22138: [SPARK-25151][SS] Apply Apache Commons Pool to KafkaDataConsumer

2019-09-02 Thread GitBox
AmplabJenkins commented on issue #22138: [SPARK-25151][SS] Apply Apache Commons Pool to KafkaDataConsumer URL: https://github.com/apache/spark/pull/22138#issuecomment-527288818 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.be

[GitHub] [spark] SparkQA removed a comment on issue #22138: [SPARK-25151][SS] Apply Apache Commons Pool to KafkaDataConsumer

2019-09-02 Thread GitBox
SparkQA removed a comment on issue #22138: [SPARK-25151][SS] Apply Apache Commons Pool to KafkaDataConsumer URL: https://github.com/apache/spark/pull/22138#issuecomment-527266434 **[Test build #110026 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/110026/te

[GitHub] [spark] SparkQA commented on issue #22138: [SPARK-25151][SS] Apply Apache Commons Pool to KafkaDataConsumer

2019-09-02 Thread GitBox
SparkQA commented on issue #22138: [SPARK-25151][SS] Apply Apache Commons Pool to KafkaDataConsumer URL: https://github.com/apache/spark/pull/22138#issuecomment-527288424 **[Test build #110026 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/110026/testRepor

[GitHub] [spark] gatorsmile commented on issue #24881: [SPARK-23160][SQL][TEST] Port window.sql

2019-09-02 Thread GitBox
gatorsmile commented on issue #24881: [SPARK-23160][SQL][TEST] Port window.sql URL: https://github.com/apache/spark/pull/24881#issuecomment-527287290 @DylanGuedes any update? This is an automated message from the Apache Git S

[GitHub] [spark] sharangk commented on issue #25595: [SPARK-28792][SQL][DOC] Document CREATE DATABASE statement in SQL Reference.

2019-09-02 Thread GitBox
sharangk commented on issue #25595: [SPARK-28792][SQL][DOC] Document CREATE DATABASE statement in SQL Reference. URL: https://github.com/apache/spark/pull/25595#issuecomment-527286839 Thanks for the timely review. I will work the comments and resubmit the PR. --

[GitHub] [spark] cloud-fan commented on a change in pull request #25363: [SPARK-28628][SQL] Implement SupportsNamespaces in V2SessionCatalog

2019-09-02 Thread GitBox
cloud-fan commented on a change in pull request #25363: [SPARK-28628][SQL] Implement SupportsNamespaces in V2SessionCatalog URL: https://github.com/apache/spark/pull/25363#discussion_r320075731 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/v2/V2Se

[GitHub] [spark] cloud-fan commented on a change in pull request #25363: [SPARK-28628][SQL] Implement SupportsNamespaces in V2SessionCatalog

2019-09-02 Thread GitBox
cloud-fan commented on a change in pull request #25363: [SPARK-28628][SQL] Implement SupportsNamespaces in V2SessionCatalog URL: https://github.com/apache/spark/pull/25363#discussion_r320074529 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/V2Se

[GitHub] [spark] AmplabJenkins removed a comment on issue #25657: [SPARK-28050][SQL]DataFrameWriter support insertInto a specific table partition

2019-09-02 Thread GitBox
AmplabJenkins removed a comment on issue #25657: [SPARK-28050][SQL]DataFrameWriter support insertInto a specific table partition URL: https://github.com/apache/spark/pull/25657#issuecomment-527277300 Can one of the admins verify this patch? -

[GitHub] [spark] AmplabJenkins commented on issue #25657: [SPARK-28050][SQL]DataFrameWriter support insertInto a specific table partition

2019-09-02 Thread GitBox
AmplabJenkins commented on issue #25657: [SPARK-28050][SQL]DataFrameWriter support insertInto a specific table partition URL: https://github.com/apache/spark/pull/25657#issuecomment-527277648 Can one of the admins verify this patch? -

[GitHub] [spark] AmplabJenkins removed a comment on issue #25657: [SPARK-28050][SQL]DataFrameWriter support insertInto a specific table partition

2019-09-02 Thread GitBox
AmplabJenkins removed a comment on issue #25657: [SPARK-28050][SQL]DataFrameWriter support insertInto a specific table partition URL: https://github.com/apache/spark/pull/25657#issuecomment-527277202 Can one of the admins verify this patch? -

[GitHub] [spark] AmplabJenkins commented on issue #25657: [SPARK-28050][SQL]DataFrameWriter support insertInto a specific table partition

2019-09-02 Thread GitBox
AmplabJenkins commented on issue #25657: [SPARK-28050][SQL]DataFrameWriter support insertInto a specific table partition URL: https://github.com/apache/spark/pull/25657#issuecomment-527277300 Can one of the admins verify this patch? -

[GitHub] [spark] AmplabJenkins commented on issue #25657: [SPARK-28050][SQL]DataFrameWriter support insertInto a specific table partition

2019-09-02 Thread GitBox
AmplabJenkins commented on issue #25657: [SPARK-28050][SQL]DataFrameWriter support insertInto a specific table partition URL: https://github.com/apache/spark/pull/25657#issuecomment-527277202 Can one of the admins verify this patch? -

[GitHub] [spark] MrDLontheway closed pull request #25650: [SPARK-28050][SQL]DataFrameWriter support insertInto a specific table partition

2019-09-02 Thread GitBox
MrDLontheway closed pull request #25650: [SPARK-28050][SQL]DataFrameWriter support insertInto a specific table partition URL: https://github.com/apache/spark/pull/25650 This is an automated message from the Apache Git Servic

[GitHub] [spark] MrDLontheway opened a new pull request #25657: [SPARK-28050][SQL]DataFrameWriter support insertInto a specific table partition

2019-09-02 Thread GitBox
MrDLontheway opened a new pull request #25657: [SPARK-28050][SQL]DataFrameWriter support insertInto a specific table partition URL: https://github.com/apache/spark/pull/25657 ### What changes were proposed in this pull request? support insertInto a specific table partition

[GitHub] [spark] MrDLontheway commented on issue #25650: [SPARK-28050][SQL]DataFrameWriter support insertInto a specific table partition

2019-09-02 Thread GitBox
MrDLontheway commented on issue #25650: [SPARK-28050][SQL]DataFrameWriter support insertInto a specific table partition URL: https://github.com/apache/spark/pull/25650#issuecomment-527276503 @dongjoon-hyun i create a new branch to make PR --

[GitHub] [spark] kiszk commented on a change in pull request #25655: [SPARK-28906][Build] Fix incorrect information in bin/spark-submit --version

2019-09-02 Thread GitBox
kiszk commented on a change in pull request #25655: [SPARK-28906][Build] Fix incorrect information in bin/spark-submit --version URL: https://github.com/apache/spark/pull/25655#discussion_r320066049 ## File path: dev/create-release/release-build.sh ## @@ -164,7 +164,6 @@ D

[GitHub] [spark] hddong commented on a change in pull request #25649: [SPARK-28694][EXAMPLES]Add Java/Scala StructuredKerberizedKafkaWordCount examples

2019-09-02 Thread GitBox
hddong commented on a change in pull request #25649: [SPARK-28694][EXAMPLES]Add Java/Scala StructuredKerberizedKafkaWordCount examples URL: https://github.com/apache/spark/pull/25649#discussion_r320065744 ## File path: examples/src/main/java/org/apache/spark/examples/sql/streaming/

[GitHub] [spark] kiszk commented on a change in pull request #25655: [SPARK-28906][Build] Fix incorrect information in bin/spark-submit --version

2019-09-02 Thread GitBox
kiszk commented on a change in pull request #25655: [SPARK-28906][Build] Fix incorrect information in bin/spark-submit --version URL: https://github.com/apache/spark/pull/25655#discussion_r320065272 ## File path: dev/create-release/release-build.sh ## @@ -164,7 +164,6 @@ D

[GitHub] [spark] zzcclp commented on issue #25439: [SPARK-28709][DSTREAMS] Fix StreamingContext leak through Streaming

2019-09-02 Thread GitBox
zzcclp commented on issue #25439: [SPARK-28709][DSTREAMS] Fix StreamingContext leak through Streaming URL: https://github.com/apache/spark/pull/25439#issuecomment-527269181 @choojoyq @srowen @dongjoon-hyun 2.4.4 was released, do you plan to merge this pr into branch-2.4? -

[GitHub] [spark] zzcclp commented on issue #25511: [SPARK-22955][DSTREAMS] - graceful shutdown shouldn't lead to job gen…

2019-09-02 Thread GitBox
zzcclp commented on issue #25511: [SPARK-22955][DSTREAMS] - graceful shutdown shouldn't lead to job gen… URL: https://github.com/apache/spark/pull/25511#issuecomment-527269151 @choojoyq @srowen 2.4.4 was released, do you plan to merge this pr into branch-2.4? -

[GitHub] [spark] hddong commented on issue #23952: [SPARK-26929][SQL]fix table owner use user instead of principal when create table through spark-sql or beeline

2019-09-02 Thread GitBox
hddong commented on issue #23952: [SPARK-26929][SQL]fix table owner use user instead of principal when create table through spark-sql or beeline URL: https://github.com/apache/spark/pull/23952#issuecomment-527268064 > I'm not sure whether it's easy or challenging, but if possible could we

[GitHub] [spark] SparkQA commented on issue #22138: [SPARK-25151][SS] Apply Apache Commons Pool to KafkaDataConsumer

2019-09-02 Thread GitBox
SparkQA commented on issue #22138: [SPARK-25151][SS] Apply Apache Commons Pool to KafkaDataConsumer URL: https://github.com/apache/spark/pull/22138#issuecomment-527266434 **[Test build #110026 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/110026/testReport

[GitHub] [spark] HeartSaVioR commented on issue #22138: [SPARK-25151][SS] Apply Apache Commons Pool to KafkaDataConsumer

2019-09-02 Thread GitBox
HeartSaVioR commented on issue #22138: [SPARK-25151][SS] Apply Apache Commons Pool to KafkaDataConsumer URL: https://github.com/apache/spark/pull/22138#issuecomment-527265942 retest this, please This is an automated message f

[GitHub] [spark] HeartSaVioR commented on issue #22138: [SPARK-25151][SS] Apply Apache Commons Pool to KafkaDataConsumer

2019-09-02 Thread GitBox
HeartSaVioR commented on issue #22138: [SPARK-25151][SS] Apply Apache Commons Pool to KafkaDataConsumer URL: https://github.com/apache/spark/pull/22138#issuecomment-527265922 ``` Running build tests ==

[GitHub] [spark] AmplabJenkins removed a comment on issue #22138: [SPARK-25151][SS] Apply Apache Commons Pool to KafkaDataConsumer

2019-09-02 Thread GitBox
AmplabJenkins removed a comment on issue #22138: [SPARK-25151][SS] Apply Apache Commons Pool to KafkaDataConsumer URL: https://github.com/apache/spark/pull/22138#issuecomment-527264737 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://ampl

[GitHub] [spark] AmplabJenkins removed a comment on issue #25647: [SPARK-28946][R][DOCS] Add some more information about building SparkR on Windows

2019-09-02 Thread GitBox
AmplabJenkins removed a comment on issue #25647: [SPARK-28946][R][DOCS] Add some more information about building SparkR on Windows URL: https://github.com/apache/spark/pull/25647#issuecomment-527264678 Merged build finished. Test PASSed.

[GitHub] [spark] SparkQA removed a comment on issue #22138: [SPARK-25151][SS] Apply Apache Commons Pool to KafkaDataConsumer

2019-09-02 Thread GitBox
SparkQA removed a comment on issue #22138: [SPARK-25151][SS] Apply Apache Commons Pool to KafkaDataConsumer URL: https://github.com/apache/spark/pull/22138#issuecomment-527264540 **[Test build #110025 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/110025/te

[GitHub] [spark] SparkQA removed a comment on issue #25647: [SPARK-28946][R][DOCS] Add some more information about building SparkR on Windows

2019-09-02 Thread GitBox
SparkQA removed a comment on issue #25647: [SPARK-28946][R][DOCS] Add some more information about building SparkR on Windows URL: https://github.com/apache/spark/pull/25647#issuecomment-527261203 **[Test build #110024 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequest

[GitHub] [spark] AmplabJenkins removed a comment on issue #25647: [SPARK-28946][R][DOCS] Add some more information about building SparkR on Windows

2019-09-02 Thread GitBox
AmplabJenkins removed a comment on issue #25647: [SPARK-28946][R][DOCS] Add some more information about building SparkR on Windows URL: https://github.com/apache/spark/pull/25647#issuecomment-527264680 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #22138: [SPARK-25151][SS] Apply Apache Commons Pool to KafkaDataConsumer

2019-09-02 Thread GitBox
AmplabJenkins removed a comment on issue #22138: [SPARK-25151][SS] Apply Apache Commons Pool to KafkaDataConsumer URL: https://github.com/apache/spark/pull/22138#issuecomment-527264734 Merged build finished. Test FAILed. This

[GitHub] [spark] SparkQA commented on issue #22138: [SPARK-25151][SS] Apply Apache Commons Pool to KafkaDataConsumer

2019-09-02 Thread GitBox
SparkQA commented on issue #22138: [SPARK-25151][SS] Apply Apache Commons Pool to KafkaDataConsumer URL: https://github.com/apache/spark/pull/22138#issuecomment-527264730 **[Test build #110025 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/110025/testRepor

[GitHub] [spark] AmplabJenkins commented on issue #22138: [SPARK-25151][SS] Apply Apache Commons Pool to KafkaDataConsumer

2019-09-02 Thread GitBox
AmplabJenkins commented on issue #22138: [SPARK-25151][SS] Apply Apache Commons Pool to KafkaDataConsumer URL: https://github.com/apache/spark/pull/22138#issuecomment-527264734 Merged build finished. Test FAILed. This is an a

[GitHub] [spark] AmplabJenkins commented on issue #22138: [SPARK-25151][SS] Apply Apache Commons Pool to KafkaDataConsumer

2019-09-02 Thread GitBox
AmplabJenkins commented on issue #22138: [SPARK-25151][SS] Apply Apache Commons Pool to KafkaDataConsumer URL: https://github.com/apache/spark/pull/22138#issuecomment-527264737 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.be

  1   2   3   4   5   6   >