[GitHub] [spark] AmplabJenkins commented on issue #25294: [WIP][SPARK-28476][SQL] Support ALTER DATABASE SET LOCATION

2019-09-20 Thread GitBox
AmplabJenkins commented on issue #25294: [WIP][SPARK-28476][SQL] Support ALTER DATABASE SET LOCATION URL: https://github.com/apache/spark/pull/25294#issuecomment-533768183 Merged build finished. Test PASSed. This is an

[GitHub] [spark] AmplabJenkins removed a comment on issue #25294: [WIP][SPARK-28476][SQL] Support ALTER DATABASE SET LOCATION

2019-09-20 Thread GitBox
AmplabJenkins removed a comment on issue #25294: [WIP][SPARK-28476][SQL] Support ALTER DATABASE SET LOCATION URL: https://github.com/apache/spark/pull/25294#issuecomment-533768185 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #25294: [WIP][SPARK-28476][SQL] Support ALTER DATABASE SET LOCATION

2019-09-20 Thread GitBox
AmplabJenkins commented on issue #25294: [WIP][SPARK-28476][SQL] Support ALTER DATABASE SET LOCATION URL: https://github.com/apache/spark/pull/25294#issuecomment-533768185 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #25294: [WIP][SPARK-28476][SQL] Support ALTER DATABASE SET LOCATION

2019-09-20 Thread GitBox
AmplabJenkins removed a comment on issue #25294: [WIP][SPARK-28476][SQL] Support ALTER DATABASE SET LOCATION URL: https://github.com/apache/spark/pull/25294#issuecomment-533768183 Merged build finished. Test PASSed. This is

[GitHub] [spark] SparkQA commented on issue #25294: [WIP][SPARK-28476][SQL] Support ALTER DATABASE SET LOCATION

2019-09-20 Thread GitBox
SparkQA commented on issue #25294: [WIP][SPARK-28476][SQL] Support ALTER DATABASE SET LOCATION URL: https://github.com/apache/spark/pull/25294#issuecomment-533768110 **[Test build #10 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/10/testReport)**

[GitHub] [spark] dongjoon-hyun commented on issue #25746: [WIP][SPARK-28292][SQL] Enable Injection of User-defined Hint

2019-09-20 Thread GitBox
dongjoon-hyun commented on issue #25746: [WIP][SPARK-28292][SQL] Enable Injection of User-defined Hint URL: https://github.com/apache/spark/pull/25746#issuecomment-533768107 Got it. Thank you for making this change, @gatorsmile !

[GitHub] [spark] wangyum commented on issue #25294: [WIP][SPARK-28476][SQL] Support ALTER DATABASE SET LOCATION

2019-09-20 Thread GitBox
wangyum commented on issue #25294: [WIP][SPARK-28476][SQL] Support ALTER DATABASE SET LOCATION URL: https://github.com/apache/spark/pull/25294#issuecomment-533768021 retest this please This is an automated message from the

[GitHub] [spark] AmplabJenkins removed a comment on issue #25863: [WIP][SPARK-29037][CORE][SQL] For static partition overwrite, spark may give duplicate result.

2019-09-20 Thread GitBox
AmplabJenkins removed a comment on issue #25863: [WIP][SPARK-29037][CORE][SQL] For static partition overwrite, spark may give duplicate result. URL: https://github.com/apache/spark/pull/25863#issuecomment-533767809 Test PASSed. Refer to this link for build results (access rights to CI

[GitHub] [spark] AmplabJenkins removed a comment on issue #25863: [WIP][SPARK-29037][CORE][SQL] For static partition overwrite, spark may give duplicate result.

2019-09-20 Thread GitBox
AmplabJenkins removed a comment on issue #25863: [WIP][SPARK-29037][CORE][SQL] For static partition overwrite, spark may give duplicate result. URL: https://github.com/apache/spark/pull/25863#issuecomment-533767808 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #25863: [WIP][SPARK-29037][CORE][SQL] For static partition overwrite, spark may give duplicate result.

2019-09-20 Thread GitBox
AmplabJenkins commented on issue #25863: [WIP][SPARK-29037][CORE][SQL] For static partition overwrite, spark may give duplicate result. URL: https://github.com/apache/spark/pull/25863#issuecomment-533767809 Test PASSed. Refer to this link for build results (access rights to CI server

[GitHub] [spark] AmplabJenkins commented on issue #25863: [WIP][SPARK-29037][CORE][SQL] For static partition overwrite, spark may give duplicate result.

2019-09-20 Thread GitBox
AmplabJenkins commented on issue #25863: [WIP][SPARK-29037][CORE][SQL] For static partition overwrite, spark may give duplicate result. URL: https://github.com/apache/spark/pull/25863#issuecomment-533767808 Merged build finished. Test PASSed.

[GitHub] [spark] SparkQA commented on issue #25863: [WIP][SPARK-29037][CORE][SQL] For static partition overwrite, spark may give duplicate result.

2019-09-20 Thread GitBox
SparkQA commented on issue #25863: [WIP][SPARK-29037][CORE][SQL] For static partition overwrite, spark may give duplicate result. URL: https://github.com/apache/spark/pull/25863#issuecomment-533767738 **[Test build #09 has

[GitHub] [spark] dongjoon-hyun commented on issue #25877: [NO-NOT-MERGE][test-maven] Verify timeout for maven SparkPullRequestBuilder

2019-09-20 Thread GitBox
dongjoon-hyun commented on issue #25877: [NO-NOT-MERGE][test-maven] Verify timeout for maven SparkPullRequestBuilder URL: https://github.com/apache/spark/pull/25877#issuecomment-533767588 @wangyum . Do you need to increase this to pass your https://github.com/apache/spark/pull/25690?

[GitHub] [spark] turboFei commented on issue #25863: [WIP][SPARK-29037][CORE][SQL] For static partition overwrite, spark may give duplicate result.

2019-09-20 Thread GitBox
turboFei commented on issue #25863: [WIP][SPARK-29037][CORE][SQL] For static partition overwrite, spark may give duplicate result. URL: https://github.com/apache/spark/pull/25863#issuecomment-533767506 retest this please

[GitHub] [spark] dongjoon-hyun edited a comment on issue #25879: [SPARK-29199][INFRA] Add linters and license/dependency checkers to GitHub Action

2019-09-20 Thread GitBox
dongjoon-hyun edited a comment on issue #25879: [SPARK-29199][INFRA] Add linters and license/dependency checkers to GitHub Action URL: https://github.com/apache/spark/pull/25879#issuecomment-533767464 `Linters` job passed in `9 min` already and this PR is irrelevant to Jenkins.

[GitHub] [spark] dongjoon-hyun commented on issue #25879: [SPARK-29199][INFRA] Add linters and license/dependency checkers to GitHub Action

2019-09-20 Thread GitBox
dongjoon-hyun commented on issue #25879: [SPARK-29199][INFRA] Add linters and license/dependency checkers to GitHub Action URL: https://github.com/apache/spark/pull/25879#issuecomment-533767464 `Linters` job passed in `9 min` already.

[GitHub] [spark] AmplabJenkins removed a comment on issue #25879: [SPARK-29199][INFRA] Add linters and license/dependency checkers to GitHub Action

2019-09-20 Thread GitBox
AmplabJenkins removed a comment on issue #25879: [SPARK-29199][INFRA] Add linters and license/dependency checkers to GitHub Action URL: https://github.com/apache/spark/pull/25879#issuecomment-533767093 Test PASSed. Refer to this link for build results (access rights to CI server

[GitHub] [spark] AmplabJenkins removed a comment on issue #25879: [SPARK-29199][INFRA] Add linters and license/dependency checkers to GitHub Action

2019-09-20 Thread GitBox
AmplabJenkins removed a comment on issue #25879: [SPARK-29199][INFRA] Add linters and license/dependency checkers to GitHub Action URL: https://github.com/apache/spark/pull/25879#issuecomment-533767092 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #25879: [SPARK-29199][INFRA] Add linters and license/dependency checkers to GitHub Action

2019-09-20 Thread GitBox
AmplabJenkins commented on issue #25879: [SPARK-29199][INFRA] Add linters and license/dependency checkers to GitHub Action URL: https://github.com/apache/spark/pull/25879#issuecomment-533767092 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #25879: [SPARK-29199][INFRA] Add linters and license/dependency checkers to GitHub Action

2019-09-20 Thread GitBox
AmplabJenkins commented on issue #25879: [SPARK-29199][INFRA] Add linters and license/dependency checkers to GitHub Action URL: https://github.com/apache/spark/pull/25879#issuecomment-533767093 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #25827: [SPARK-29128][SQL] Split predicate code in OR expressions

2019-09-20 Thread GitBox
AmplabJenkins removed a comment on issue #25827: [SPARK-29128][SQL] Split predicate code in OR expressions URL: https://github.com/apache/spark/pull/25827#issuecomment-533767013 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #25827: [SPARK-29128][SQL] Split predicate code in OR expressions

2019-09-20 Thread GitBox
AmplabJenkins removed a comment on issue #25827: [SPARK-29128][SQL] Split predicate code in OR expressions URL: https://github.com/apache/spark/pull/25827#issuecomment-533767011 Merged build finished. Test PASSed. This is an

[GitHub] [spark] SparkQA commented on issue #25879: [SPARK-29199][INFRA] Add linters and license/dependency checkers to GitHub Action

2019-09-20 Thread GitBox
SparkQA commented on issue #25879: [SPARK-29199][INFRA] Add linters and license/dependency checkers to GitHub Action URL: https://github.com/apache/spark/pull/25879#issuecomment-533767026 **[Test build #08 has

[GitHub] [spark] AmplabJenkins commented on issue #25827: [SPARK-29128][SQL] Split predicate code in OR expressions

2019-09-20 Thread GitBox
AmplabJenkins commented on issue #25827: [SPARK-29128][SQL] Split predicate code in OR expressions URL: https://github.com/apache/spark/pull/25827#issuecomment-533767011 Merged build finished. Test PASSed. This is an

[GitHub] [spark] AmplabJenkins commented on issue #25827: [SPARK-29128][SQL] Split predicate code in OR expressions

2019-09-20 Thread GitBox
AmplabJenkins commented on issue #25827: [SPARK-29128][SQL] Split predicate code in OR expressions URL: https://github.com/apache/spark/pull/25827#issuecomment-533767013 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA removed a comment on issue #25827: [SPARK-29128][SQL] Split predicate code in OR expressions

2019-09-20 Thread GitBox
SparkQA removed a comment on issue #25827: [SPARK-29128][SQL] Split predicate code in OR expressions URL: https://github.com/apache/spark/pull/25827#issuecomment-533747209 **[Test build #111099 has

[GitHub] [spark] SparkQA commented on issue #25827: [SPARK-29128][SQL] Split predicate code in OR expressions

2019-09-20 Thread GitBox
SparkQA commented on issue #25827: [SPARK-29128][SQL] Split predicate code in OR expressions URL: https://github.com/apache/spark/pull/25827#issuecomment-533766923 **[Test build #111099 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/111099/testReport)**

[GitHub] [spark] AmplabJenkins removed a comment on issue #25879: [SPARK-29199][INFRA] Add linters and license/dependency checkers to GitHub Action

2019-09-20 Thread GitBox
AmplabJenkins removed a comment on issue #25879: [SPARK-29199][INFRA] Add linters and license/dependency checkers to GitHub Action URL: https://github.com/apache/spark/pull/25879#issuecomment-533766766 Test PASSed. Refer to this link for build results (access rights to CI server

[GitHub] [spark] AmplabJenkins removed a comment on issue #25879: [SPARK-29199][INFRA] Add linters and license/dependency checkers to GitHub Action

2019-09-20 Thread GitBox
AmplabJenkins removed a comment on issue #25879: [SPARK-29199][INFRA] Add linters and license/dependency checkers to GitHub Action URL: https://github.com/apache/spark/pull/25879#issuecomment-533766764 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #25879: [SPARK-29199][INFRA] Add linters and license/dependency checkers to GitHub Action

2019-09-20 Thread GitBox
AmplabJenkins commented on issue #25879: [SPARK-29199][INFRA] Add linters and license/dependency checkers to GitHub Action URL: https://github.com/apache/spark/pull/25879#issuecomment-533766766 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #25879: [SPARK-29199][INFRA] Add linters and license/dependency checkers to GitHub Action

2019-09-20 Thread GitBox
AmplabJenkins commented on issue #25879: [SPARK-29199][INFRA] Add linters and license/dependency checkers to GitHub Action URL: https://github.com/apache/spark/pull/25879#issuecomment-533766764 Merged build finished. Test PASSed.

[GitHub] [spark] SparkQA commented on issue #25879: [SPARK-29199][INFRA] Add linters and license/dependency checkers to GitHub Action

2019-09-20 Thread GitBox
SparkQA commented on issue #25879: [SPARK-29199][INFRA] Add linters and license/dependency checkers to GitHub Action URL: https://github.com/apache/spark/pull/25879#issuecomment-533766701 **[Test build #07 has

[GitHub] [spark] AmplabJenkins removed a comment on issue #25878: [SPARK-29162][SQL]Simplify NOT(IsNull(x)) and NOT(IsNotNull(x))

2019-09-20 Thread GitBox
AmplabJenkins removed a comment on issue #25878: [SPARK-29162][SQL]Simplify NOT(IsNull(x)) and NOT(IsNotNull(x)) URL: https://github.com/apache/spark/pull/25878#issuecomment-533766427 Can one of the admins verify this patch?

[GitHub] [spark] AmplabJenkins commented on issue #25878: [SPARK-29162][SQL]Simplify NOT(IsNull(x)) and NOT(IsNotNull(x))

2019-09-20 Thread GitBox
AmplabJenkins commented on issue #25878: [SPARK-29162][SQL]Simplify NOT(IsNull(x)) and NOT(IsNotNull(x)) URL: https://github.com/apache/spark/pull/25878#issuecomment-533766680 Can one of the admins verify this patch? This is

[GitHub] [spark] dongjoon-hyun opened a new pull request #25879: [SPARK-29199][INFRA] Add linters and license/dependency checkers to GitHub Action

2019-09-20 Thread GitBox
dongjoon-hyun opened a new pull request #25879: [SPARK-29199][INFRA] Add linters and license/dependency checkers to GitHub Action URL: https://github.com/apache/spark/pull/25879 ### What changes were proposed in this pull request? This PR aims to add linters and license/dependency

[GitHub] [spark] AmplabJenkins commented on issue #25878: [SPARK-29162][SQL]Simplify NOT(IsNull(x)) and NOT(IsNotNull(x))

2019-09-20 Thread GitBox
AmplabJenkins commented on issue #25878: [SPARK-29162][SQL]Simplify NOT(IsNull(x)) and NOT(IsNotNull(x)) URL: https://github.com/apache/spark/pull/25878#issuecomment-533766427 Can one of the admins verify this patch? This is

[GitHub] [spark] AngersZhuuuu commented on issue #25878: [SPARK-29162][SQL]Simplify NOT(IsNull(x)) and NOT(IsNotNull(x))

2019-09-20 Thread GitBox
AngersZh commented on issue #25878: [SPARK-29162][SQL]Simplify NOT(IsNull(x)) and NOT(IsNotNull(x)) URL: https://github.com/apache/spark/pull/25878#issuecomment-533766516 gentle ping @juliuszsompolski I agree a lot that we should simplify these expression. It's really useful for

[GitHub] [spark] AngersZhuuuu opened a new pull request #25878: [SPARK-29162][SQL]Simplify NOT(IsNull(x)) and NOT(IsNotNull(x))

2019-09-20 Thread GitBox
AngersZh opened a new pull request #25878: [SPARK-29162][SQL]Simplify NOT(IsNull(x)) and NOT(IsNotNull(x)) URL: https://github.com/apache/spark/pull/25878 ### What changes were proposed in this pull request? Rewrite ``` NOT isnull(x) -> isnotnull(x) NOT isnotnull(x)

[GitHub] [spark] AmplabJenkins removed a comment on issue #25811: [SPARK-29111][CORE] Support snapshot/restore on KVStore

2019-09-20 Thread GitBox
AmplabJenkins removed a comment on issue #25811: [SPARK-29111][CORE] Support snapshot/restore on KVStore URL: https://github.com/apache/spark/pull/25811#issuecomment-533764924 Merged build finished. Test PASSed. This is an

[GitHub] [spark] AmplabJenkins commented on issue #25811: [SPARK-29111][CORE] Support snapshot/restore on KVStore

2019-09-20 Thread GitBox
AmplabJenkins commented on issue #25811: [SPARK-29111][CORE] Support snapshot/restore on KVStore URL: https://github.com/apache/spark/pull/25811#issuecomment-533764926 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #25811: [SPARK-29111][CORE] Support snapshot/restore on KVStore

2019-09-20 Thread GitBox
AmplabJenkins commented on issue #25811: [SPARK-29111][CORE] Support snapshot/restore on KVStore URL: https://github.com/apache/spark/pull/25811#issuecomment-533764924 Merged build finished. Test PASSed. This is an automated

[GitHub] [spark] AmplabJenkins removed a comment on issue #25811: [SPARK-29111][CORE] Support snapshot/restore on KVStore

2019-09-20 Thread GitBox
AmplabJenkins removed a comment on issue #25811: [SPARK-29111][CORE] Support snapshot/restore on KVStore URL: https://github.com/apache/spark/pull/25811#issuecomment-533764926 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA commented on issue #25845: [SPARK-29160][CORE] Use UTF-8 explicitly for reading/writing event log file

2019-09-20 Thread GitBox
SparkQA commented on issue #25845: [SPARK-29160][CORE] Use UTF-8 explicitly for reading/writing event log file URL: https://github.com/apache/spark/pull/25845#issuecomment-533764872 **[Test build #06 has

[GitHub] [spark] SparkQA removed a comment on issue #25811: [SPARK-29111][CORE] Support snapshot/restore on KVStore

2019-09-20 Thread GitBox
SparkQA removed a comment on issue #25811: [SPARK-29111][CORE] Support snapshot/restore on KVStore URL: https://github.com/apache/spark/pull/25811#issuecomment-533756236 **[Test build #02 has

[GitHub] [spark] SparkQA commented on issue #25811: [SPARK-29111][CORE] Support snapshot/restore on KVStore

2019-09-20 Thread GitBox
SparkQA commented on issue #25811: [SPARK-29111][CORE] Support snapshot/restore on KVStore URL: https://github.com/apache/spark/pull/25811#issuecomment-533764838 **[Test build #02 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/02/testReport)**

[GitHub] [spark] dongjoon-hyun commented on issue #25845: [SPARK-29160][CORE] Use UTF-8 explicitly for reading/writing event log file

2019-09-20 Thread GitBox
dongjoon-hyun commented on issue #25845: [SPARK-29160][CORE] Use UTF-8 explicitly for reading/writing event log file URL: https://github.com/apache/spark/pull/25845#issuecomment-533764555 Ya. I agree with you. This is an

[GitHub] [spark] HeartSaVioR edited a comment on issue #25845: [SPARK-29160][CORE] Use UTF-8 explicitly for reading/writing event log file

2019-09-20 Thread GitBox
HeartSaVioR edited a comment on issue #25845: [SPARK-29160][CORE] Use UTF-8 explicitly for reading/writing event log file URL: https://github.com/apache/spark/pull/25845#issuecomment-533764134 Yeah I thought someone may say it should worth to provide backward-compatible option so waited

[GitHub] [spark] HeartSaVioR commented on issue #25845: [SPARK-29160][CORE] Use UTF-8 explicitly for reading/writing event log file

2019-09-20 Thread GitBox
HeartSaVioR commented on issue #25845: [SPARK-29160][CORE] Use UTF-8 explicitly for reading/writing event log file URL: https://github.com/apache/spark/pull/25845#issuecomment-533764134 Yeah I thought someone may say it should worth to provide backward-compatible option so waited for

[GitHub] [spark] HeartSaVioR commented on a change in pull request #25853: [SPARK-21869][SS] Apply Apache Commons Pool to Kafka producer

2019-09-20 Thread GitBox
HeartSaVioR commented on a change in pull request #25853: [SPARK-21869][SS] Apply Apache Commons Pool to Kafka producer URL: https://github.com/apache/spark/pull/25853#discussion_r326550365 ## File path:

[GitHub] [spark] HeartSaVioR commented on a change in pull request #25853: [SPARK-21869][SS] Apply Apache Commons Pool to Kafka producer

2019-09-20 Thread GitBox
HeartSaVioR commented on a change in pull request #25853: [SPARK-21869][SS] Apply Apache Commons Pool to Kafka producer URL: https://github.com/apache/spark/pull/25853#discussion_r326844741 ## File path:

[GitHub] [spark] HeartSaVioR commented on a change in pull request #25853: [SPARK-21869][SS] Apply Apache Commons Pool to Kafka producer

2019-09-20 Thread GitBox
HeartSaVioR commented on a change in pull request #25853: [SPARK-21869][SS] Apply Apache Commons Pool to Kafka producer URL: https://github.com/apache/spark/pull/25853#discussion_r326844932 ## File path:

[GitHub] [spark] HeartSaVioR commented on a change in pull request #25853: [SPARK-21869][SS] Apply Apache Commons Pool to Kafka producer

2019-09-20 Thread GitBox
HeartSaVioR commented on a change in pull request #25853: [SPARK-21869][SS] Apply Apache Commons Pool to Kafka producer URL: https://github.com/apache/spark/pull/25853#discussion_r326845315 ## File path:

[GitHub] [spark] HeartSaVioR commented on a change in pull request #25853: [SPARK-21869][SS] Apply Apache Commons Pool to Kafka producer

2019-09-20 Thread GitBox
HeartSaVioR commented on a change in pull request #25853: [SPARK-21869][SS] Apply Apache Commons Pool to Kafka producer URL: https://github.com/apache/spark/pull/25853#discussion_r326844878 ## File path:

[GitHub] [spark] HeartSaVioR commented on a change in pull request #25853: [SPARK-21869][SS] Apply Apache Commons Pool to Kafka producer

2019-09-20 Thread GitBox
HeartSaVioR commented on a change in pull request #25853: [SPARK-21869][SS] Apply Apache Commons Pool to Kafka producer URL: https://github.com/apache/spark/pull/25853#discussion_r326844478 ## File path:

[GitHub] [spark] HeartSaVioR commented on a change in pull request #25853: [SPARK-21869][SS] Apply Apache Commons Pool to Kafka producer

2019-09-20 Thread GitBox
HeartSaVioR commented on a change in pull request #25853: [SPARK-21869][SS] Apply Apache Commons Pool to Kafka producer URL: https://github.com/apache/spark/pull/25853#discussion_r326845097 ## File path:

[GitHub] [spark] HeartSaVioR commented on a change in pull request #25853: [SPARK-21869][SS] Apply Apache Commons Pool to Kafka producer

2019-09-20 Thread GitBox
HeartSaVioR commented on a change in pull request #25853: [SPARK-21869][SS] Apply Apache Commons Pool to Kafka producer URL: https://github.com/apache/spark/pull/25853#discussion_r326845141 ## File path:

[GitHub] [spark] HeartSaVioR commented on a change in pull request #25853: [SPARK-21869][SS] Apply Apache Commons Pool to Kafka producer

2019-09-20 Thread GitBox
HeartSaVioR commented on a change in pull request #25853: [SPARK-21869][SS] Apply Apache Commons Pool to Kafka producer URL: https://github.com/apache/spark/pull/25853#discussion_r326844638 ## File path:

[GitHub] [spark] HeartSaVioR commented on a change in pull request #25853: [SPARK-21869][SS] Apply Apache Commons Pool to Kafka producer

2019-09-20 Thread GitBox
HeartSaVioR commented on a change in pull request #25853: [SPARK-21869][SS] Apply Apache Commons Pool to Kafka producer URL: https://github.com/apache/spark/pull/25853#discussion_r326844478 ## File path:

[GitHub] [spark] HeartSaVioR commented on a change in pull request #25853: [SPARK-21869][SS] Apply Apache Commons Pool to Kafka producer

2019-09-20 Thread GitBox
HeartSaVioR commented on a change in pull request #25853: [SPARK-21869][SS] Apply Apache Commons Pool to Kafka producer URL: https://github.com/apache/spark/pull/25853#discussion_r326845411 ## File path:

[GitHub] [spark] HeartSaVioR commented on a change in pull request #25853: [SPARK-21869][SS] Apply Apache Commons Pool to Kafka producer

2019-09-20 Thread GitBox
HeartSaVioR commented on a change in pull request #25853: [SPARK-21869][SS] Apply Apache Commons Pool to Kafka producer URL: https://github.com/apache/spark/pull/25853#discussion_r326844184 ## File path:

[GitHub] [spark] AmplabJenkins removed a comment on issue #25830: [SPARK-29140][SQL] Handle parameters having "array" of javaType properly in splitAggregateExpressions

2019-09-20 Thread GitBox
AmplabJenkins removed a comment on issue #25830: [SPARK-29140][SQL] Handle parameters having "array" of javaType properly in splitAggregateExpressions URL: https://github.com/apache/spark/pull/25830#issuecomment-533763719 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #25830: [SPARK-29140][SQL] Handle parameters having "array" of javaType properly in splitAggregateExpressions

2019-09-20 Thread GitBox
AmplabJenkins removed a comment on issue #25830: [SPARK-29140][SQL] Handle parameters having "array" of javaType properly in splitAggregateExpressions URL: https://github.com/apache/spark/pull/25830#issuecomment-533763721 Test PASSed. Refer to this link for build results (access rights

[GitHub] [spark] dongjoon-hyun closed pull request #25874: [SPARK-28772][BUILD][MLLIB] Update breeze to 1.0

2019-09-20 Thread GitBox
dongjoon-hyun closed pull request #25874: [SPARK-28772][BUILD][MLLIB] Update breeze to 1.0 URL: https://github.com/apache/spark/pull/25874 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] AmplabJenkins commented on issue #25830: [SPARK-29140][SQL] Handle parameters having "array" of javaType properly in splitAggregateExpressions

2019-09-20 Thread GitBox
AmplabJenkins commented on issue #25830: [SPARK-29140][SQL] Handle parameters having "array" of javaType properly in splitAggregateExpressions URL: https://github.com/apache/spark/pull/25830#issuecomment-533763719 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #25830: [SPARK-29140][SQL] Handle parameters having "array" of javaType properly in splitAggregateExpressions

2019-09-20 Thread GitBox
AmplabJenkins commented on issue #25830: [SPARK-29140][SQL] Handle parameters having "array" of javaType properly in splitAggregateExpressions URL: https://github.com/apache/spark/pull/25830#issuecomment-533763721 Test PASSed. Refer to this link for build results (access rights to CI

[GitHub] [spark] dongjoon-hyun commented on issue #25874: [SPARK-28772][BUILD][MLLIB] Update breeze to 1.0

2019-09-20 Thread GitBox
dongjoon-hyun commented on issue #25874: [SPARK-28772][BUILD][MLLIB] Update breeze to 1.0 URL: https://github.com/apache/spark/pull/25874#issuecomment-533763726 Merged to master. Thank you, @srowen . This is an automated

[GitHub] [spark] dongjoon-hyun closed pull request #25865: [SPARK-29187][SQL] Return null from `date_part()` for the null `field`

2019-09-20 Thread GitBox
dongjoon-hyun closed pull request #25865: [SPARK-29187][SQL] Return null from `date_part()` for the null `field` URL: https://github.com/apache/spark/pull/25865 This is an automated message from the Apache Git Service. To

[GitHub] [spark] imback82 commented on a change in pull request #25771: [SPARK-28970][SQL] Implement USE CATALOG/NAMESPACE for Data Source V2

2019-09-20 Thread GitBox
imback82 commented on a change in pull request #25771: [SPARK-28970][SQL] Implement USE CATALOG/NAMESPACE for Data Source V2 URL: https://github.com/apache/spark/pull/25771#discussion_r326845256 ## File path:

[GitHub] [spark] SparkQA removed a comment on issue #25830: [SPARK-29140][SQL] Handle parameters having "array" of javaType properly in splitAggregateExpressions

2019-09-20 Thread GitBox
SparkQA removed a comment on issue #25830: [SPARK-29140][SQL] Handle parameters having "array" of javaType properly in splitAggregateExpressions URL: https://github.com/apache/spark/pull/25830#issuecomment-533743421 **[Test build #111096 has

[GitHub] [spark] dongjoon-hyun commented on issue #25865: [SPARK-29187][SQL] Return null from `date_part()` for the null `field`

2019-09-20 Thread GitBox
dongjoon-hyun commented on issue #25865: [SPARK-29187][SQL] Return null from `date_part()` for the null `field` URL: https://github.com/apache/spark/pull/25865#issuecomment-533763676 Also, thank you for review, @adrian-wang .

[GitHub] [spark] SparkQA commented on issue #25830: [SPARK-29140][SQL] Handle parameters having "array" of javaType properly in splitAggregateExpressions

2019-09-20 Thread GitBox
SparkQA commented on issue #25830: [SPARK-29140][SQL] Handle parameters having "array" of javaType properly in splitAggregateExpressions URL: https://github.com/apache/spark/pull/25830#issuecomment-533763611 **[Test build #111096 has

[GitHub] [spark] dongjoon-hyun commented on issue #25807: [SPARK-25153][SQL] Improve error messages for columns with dots/periods

2019-09-20 Thread GitBox
dongjoon-hyun commented on issue #25807: [SPARK-25153][SQL] Improve error messages for columns with dots/periods URL: https://github.com/apache/spark/pull/25807#issuecomment-533763283 BTW, thank you for making a PR, @jeff303 .

[GitHub] [spark] dongjoon-hyun commented on issue #25807: [SPARK-25153][SQL] Improve error messages for columns with dots/periods

2019-09-20 Thread GitBox
dongjoon-hyun commented on issue #25807: [SPARK-25153][SQL] Improve error messages for columns with dots/periods URL: https://github.com/apache/spark/pull/25807#issuecomment-533763244 It would be good to ping @holdenk since she is the reporter of this issue.

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25807: [SPARK-25153][SQL] Improve error messages for columns with dots/periods

2019-09-20 Thread GitBox
dongjoon-hyun commented on a change in pull request #25807: [SPARK-25153][SQL] Improve error messages for columns with dots/periods URL: https://github.com/apache/spark/pull/25807#discussion_r326844592 ## File path: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala

[GitHub] [spark] AmplabJenkins removed a comment on issue #25807: [SPARK-25153][SQL] Improve error messages for columns with dots/periods

2019-09-20 Thread GitBox
AmplabJenkins removed a comment on issue #25807: [SPARK-25153][SQL] Improve error messages for columns with dots/periods URL: https://github.com/apache/spark/pull/25807#issuecomment-533762438 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #25807: [SPARK-25153][SQL] Improve error messages for columns with dots/periods

2019-09-20 Thread GitBox
AmplabJenkins commented on issue #25807: [SPARK-25153][SQL] Improve error messages for columns with dots/periods URL: https://github.com/apache/spark/pull/25807#issuecomment-533762437 Merged build finished. Test PASSed. This

[GitHub] [spark] AmplabJenkins commented on issue #25807: [SPARK-25153][SQL] Improve error messages for columns with dots/periods

2019-09-20 Thread GitBox
AmplabJenkins commented on issue #25807: [SPARK-25153][SQL] Improve error messages for columns with dots/periods URL: https://github.com/apache/spark/pull/25807#issuecomment-533762438 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #25807: [SPARK-25153][SQL] Improve error messages for columns with dots/periods

2019-09-20 Thread GitBox
AmplabJenkins removed a comment on issue #25807: [SPARK-25153][SQL] Improve error messages for columns with dots/periods URL: https://github.com/apache/spark/pull/25807#issuecomment-533762437 Merged build finished. Test PASSed.

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25807: [SPARK-25153][SQL] Improve error messages for columns with dots/periods

2019-09-20 Thread GitBox
dongjoon-hyun commented on a change in pull request #25807: [SPARK-25153][SQL] Improve error messages for columns with dots/periods URL: https://github.com/apache/spark/pull/25807#discussion_r326844541 ## File path: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala

[GitHub] [spark] SparkQA commented on issue #25807: [SPARK-25153][SQL] Improve error messages for columns with dots/periods

2019-09-20 Thread GitBox
SparkQA commented on issue #25807: [SPARK-25153][SQL] Improve error messages for columns with dots/periods URL: https://github.com/apache/spark/pull/25807#issuecomment-533762372 **[Test build #05 has

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25807: [SPARK-25153][SQL] Improve error messages for columns with dots/periods

2019-09-20 Thread GitBox
dongjoon-hyun commented on a change in pull request #25807: [SPARK-25153][SQL] Improve error messages for columns with dots/periods URL: https://github.com/apache/spark/pull/25807#discussion_r326844486 ## File path: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala

[GitHub] [spark] dongjoon-hyun commented on issue #25807: [SPARK-25153][SQL] Improve error messages for columns with dots/periods

2019-09-20 Thread GitBox
dongjoon-hyun commented on issue #25807: [SPARK-25153][SQL] Improve error messages for columns with dots/periods URL: https://github.com/apache/spark/pull/25807#issuecomment-533762035 Oh, sorry for missing the ping here, @HyukjinKwon . I'll review today~

[GitHub] [spark] AmplabJenkins commented on issue #25874: [SPARK-28772][BUILD][MLLIB] Update breeze to 1.0

2019-09-20 Thread GitBox
AmplabJenkins commented on issue #25874: [SPARK-28772][BUILD][MLLIB] Update breeze to 1.0 URL: https://github.com/apache/spark/pull/25874#issuecomment-533762051 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #25874: [SPARK-28772][BUILD][MLLIB] Update breeze to 1.0

2019-09-20 Thread GitBox
AmplabJenkins commented on issue #25874: [SPARK-28772][BUILD][MLLIB] Update breeze to 1.0 URL: https://github.com/apache/spark/pull/25874#issuecomment-533762048 Merged build finished. Test PASSed. This is an automated

[GitHub] [spark] dongjoon-hyun commented on issue #25807: [SPARK-25153][SQL] Improve error messages for columns with dots/periods

2019-09-20 Thread GitBox
dongjoon-hyun commented on issue #25807: [SPARK-25153][SQL] Improve error messages for columns with dots/periods URL: https://github.com/apache/spark/pull/25807#issuecomment-533762043 Retest this please. This is an automated

[GitHub] [spark] AmplabJenkins removed a comment on issue #25874: [SPARK-28772][BUILD][MLLIB] Update breeze to 1.0

2019-09-20 Thread GitBox
AmplabJenkins removed a comment on issue #25874: [SPARK-28772][BUILD][MLLIB] Update breeze to 1.0 URL: https://github.com/apache/spark/pull/25874#issuecomment-533762051 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #25874: [SPARK-28772][BUILD][MLLIB] Update breeze to 1.0

2019-09-20 Thread GitBox
AmplabJenkins removed a comment on issue #25874: [SPARK-28772][BUILD][MLLIB] Update breeze to 1.0 URL: https://github.com/apache/spark/pull/25874#issuecomment-533762048 Merged build finished. Test PASSed. This is an

[GitHub] [spark] SparkQA removed a comment on issue #25874: [SPARK-28772][BUILD][MLLIB] Update breeze to 1.0

2019-09-20 Thread GitBox
SparkQA removed a comment on issue #25874: [SPARK-28772][BUILD][MLLIB] Update breeze to 1.0 URL: https://github.com/apache/spark/pull/25874#issuecomment-533748253 **[Test build #00 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/00/testReport)**

[GitHub] [spark] dongjoon-hyun edited a comment on issue #25845: [SPARK-29160][CORE] Use UTF-8 explicitly for reading/writing event log file

2019-09-20 Thread GitBox
dongjoon-hyun edited a comment on issue #25845: [SPARK-29160][CORE] Use UTF-8 explicitly for reading/writing event log file URL: https://github.com/apache/spark/pull/25845#issuecomment-533761894 For me, the only remaining thing looks like a note at the migration guide to give prior

[GitHub] [spark] SparkQA commented on issue #25874: [SPARK-28772][BUILD][MLLIB] Update breeze to 1.0

2019-09-20 Thread GitBox
SparkQA commented on issue #25874: [SPARK-28772][BUILD][MLLIB] Update breeze to 1.0 URL: https://github.com/apache/spark/pull/25874#issuecomment-533761934 **[Test build #00 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/00/testReport)** for PR

[GitHub] [spark] dongjoon-hyun commented on issue #25845: [SPARK-29160][CORE] Use UTF-8 explicitly for reading/writing event log file

2019-09-20 Thread GitBox
dongjoon-hyun commented on issue #25845: [SPARK-29160][CORE] Use UTF-8 explicitly for reading/writing event log file URL: https://github.com/apache/spark/pull/25845#issuecomment-533761894 For me, the only remaining thing is a note at the migration guide to give prior warning to users,

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25816: [SPARK-29107][SQL][TESTS] Port window.sql (Part 1)

2019-09-20 Thread GitBox
dongjoon-hyun commented on a change in pull request #25816: [SPARK-29107][SQL][TESTS] Port window.sql (Part 1) URL: https://github.com/apache/spark/pull/25816#discussion_r326844126 ## File path: sql/core/src/test/resources/sql-tests/inputs/pgSQL/window_part1.sql ## @@

[GitHub] [spark] SparkQA commented on issue #25788: [SPARK-29084][SQL][TESTS] Check method bytecode size in BenchmarkQueryTest

2019-09-20 Thread GitBox
SparkQA commented on issue #25788: [SPARK-29084][SQL][TESTS] Check method bytecode size in BenchmarkQueryTest URL: https://github.com/apache/spark/pull/25788#issuecomment-533761615 **[Test build #04 has

[GitHub] [spark] AmplabJenkins removed a comment on issue #25788: [SPARK-29084][SQL][TESTS] Check method bytecode size in BenchmarkQueryTest

2019-09-20 Thread GitBox
AmplabJenkins removed a comment on issue #25788: [SPARK-29084][SQL][TESTS] Check method bytecode size in BenchmarkQueryTest URL: https://github.com/apache/spark/pull/25788#issuecomment-533761321 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #25788: [SPARK-29084][SQL][TESTS] Check method bytecode size in BenchmarkQueryTest

2019-09-20 Thread GitBox
AmplabJenkins commented on issue #25788: [SPARK-29084][SQL][TESTS] Check method bytecode size in BenchmarkQueryTest URL: https://github.com/apache/spark/pull/25788#issuecomment-533761321 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #25788: [SPARK-29084][SQL][TESTS] Check method bytecode size in BenchmarkQueryTest

2019-09-20 Thread GitBox
AmplabJenkins removed a comment on issue #25788: [SPARK-29084][SQL][TESTS] Check method bytecode size in BenchmarkQueryTest URL: https://github.com/apache/spark/pull/25788#issuecomment-533761324 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #25788: [SPARK-29084][SQL][TESTS] Check method bytecode size in BenchmarkQueryTest

2019-09-20 Thread GitBox
AmplabJenkins commented on issue #25788: [SPARK-29084][SQL][TESTS] Check method bytecode size in BenchmarkQueryTest URL: https://github.com/apache/spark/pull/25788#issuecomment-533761324 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] maropu commented on issue #25788: [SPARK-29084][SQL][TESTS] Check method bytecode size in BenchmarkQueryTest

2019-09-20 Thread GitBox
maropu commented on issue #25788: [SPARK-29084][SQL][TESTS] Check method bytecode size in BenchmarkQueryTest URL: https://github.com/apache/spark/pull/25788#issuecomment-533761190 retest this please This is an automated

[GitHub] [spark] dongjoon-hyun closed pull request #25873: [SPARK-29192][TESTS] Extend BenchmarkBase to write JDK9+ results separately

2019-09-20 Thread GitBox
dongjoon-hyun closed pull request #25873: [SPARK-29192][TESTS] Extend BenchmarkBase to write JDK9+ results separately URL: https://github.com/apache/spark/pull/25873 This is an automated message from the Apache Git Service.

[GitHub] [spark] xuanyuanking commented on issue #25768: [SPARK-29063][SQL] Modify fillValue approach to support joined dataframe

2019-09-20 Thread GitBox
xuanyuanking commented on issue #25768: [SPARK-29063][SQL] Modify fillValue approach to support joined dataframe URL: https://github.com/apache/spark/pull/25768#issuecomment-533761030 Thanks for reviewing. This is an

  1   2   3   4   5   6   7   8   9   10   >