[GitHub] [spark] AmplabJenkins removed a comment on issue #22038: [SPARK-25056][SQL] Unify the InConversion and BinaryComparison behavior
AmplabJenkins removed a comment on issue #22038: [SPARK-25056][SQL] Unify the InConversion and BinaryComparison behavior URL: https://github.com/apache/spark/pull/22038#issuecomment-553770885 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #22038: [SPARK-25056][SQL] Unify the InConversion and BinaryComparison behavior
AmplabJenkins removed a comment on issue #22038: [SPARK-25056][SQL] Unify the InConversion and BinaryComparison behavior URL: https://github.com/apache/spark/pull/22038#issuecomment-553770893 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18637/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #22038: [SPARK-25056][SQL] Unify the InConversion and BinaryComparison behavior
AmplabJenkins commented on issue #22038: [SPARK-25056][SQL] Unify the InConversion and BinaryComparison behavior URL: https://github.com/apache/spark/pull/22038#issuecomment-553770885 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #22038: [SPARK-25056][SQL] Unify the InConversion and BinaryComparison behavior
AmplabJenkins commented on issue #22038: [SPARK-25056][SQL] Unify the InConversion and BinaryComparison behavior URL: https://github.com/apache/spark/pull/22038#issuecomment-553770893 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18637/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #22038: [SPARK-25056][SQL] Unify the InConversion and BinaryComparison behavior
SparkQA commented on issue #22038: [SPARK-25056][SQL] Unify the InConversion and BinaryComparison behavior URL: https://github.com/apache/spark/pull/22038#issuecomment-553770391 **[Test build #113763 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/113763/testReport)** for PR 22038 at commit [`20bdc95`](https://github.com/apache/spark/commit/20bdc954da598fe83e96ef55dbc783534d0668cf). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26513: [SPARK-29834][SQL]DESC DATABASE should look up catalog like v2 commands
SparkQA commented on issue #26513: [SPARK-29834][SQL]DESC DATABASE should look up catalog like v2 commands URL: https://github.com/apache/spark/pull/26513#issuecomment-553770308 **[Test build #113762 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/113762/testReport)** for PR 26513 at commit [`827cac1`](https://github.com/apache/spark/commit/827cac1de70d233c08d7d052f59e1aa48f944e4f). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #25728: [SPARK-29020][SQL] Improving array_sort behaviour
AmplabJenkins removed a comment on issue #25728: [SPARK-29020][SQL] Improving array_sort behaviour URL: https://github.com/apache/spark/pull/25728#issuecomment-553768868 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113749/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #25728: [SPARK-29020][SQL] Improving array_sort behaviour
AmplabJenkins removed a comment on issue #25728: [SPARK-29020][SQL] Improving array_sort behaviour URL: https://github.com/apache/spark/pull/25728#issuecomment-553768856 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26513: [SPARK-29834][SQL]DESC DATABASE should look up catalog like v2 commands
AmplabJenkins removed a comment on issue #26513: [SPARK-29834][SQL]DESC DATABASE should look up catalog like v2 commands URL: https://github.com/apache/spark/pull/26513#issuecomment-553768527 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #25728: [SPARK-29020][SQL] Improving array_sort behaviour
SparkQA removed a comment on issue #25728: [SPARK-29020][SQL] Improving array_sort behaviour URL: https://github.com/apache/spark/pull/25728#issuecomment-553714655 **[Test build #113749 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/113749/testReport)** for PR 25728 at commit [`7c38b8a`](https://github.com/apache/spark/commit/7c38b8a11ae22f32603084fe0e0992e4303a944f). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #25728: [SPARK-29020][SQL] Improving array_sort behaviour
AmplabJenkins commented on issue #25728: [SPARK-29020][SQL] Improving array_sort behaviour URL: https://github.com/apache/spark/pull/25728#issuecomment-553768868 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113749/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26513: [SPARK-29834][SQL]DESC DATABASE should look up catalog like v2 commands
AmplabJenkins removed a comment on issue #26513: [SPARK-29834][SQL]DESC DATABASE should look up catalog like v2 commands URL: https://github.com/apache/spark/pull/26513#issuecomment-553768533 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18636/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #25728: [SPARK-29020][SQL] Improving array_sort behaviour
AmplabJenkins commented on issue #25728: [SPARK-29020][SQL] Improving array_sort behaviour URL: https://github.com/apache/spark/pull/25728#issuecomment-553768856 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26513: [SPARK-29834][SQL]DESC DATABASE should look up catalog like v2 commands
AmplabJenkins commented on issue #26513: [SPARK-29834][SQL]DESC DATABASE should look up catalog like v2 commands URL: https://github.com/apache/spark/pull/26513#issuecomment-553768527 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] fuwhu commented on issue #26513: [SPARK-29834][SQL]DESC DATABASE should look up catalog like v2 commands
fuwhu commented on issue #26513: [SPARK-29834][SQL]DESC DATABASE should look up catalog like v2 commands URL: https://github.com/apache/spark/pull/26513#issuecomment-553768465 @cloud-fan This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #25728: [SPARK-29020][SQL] Improving array_sort behaviour
SparkQA commented on issue #25728: [SPARK-29020][SQL] Improving array_sort behaviour URL: https://github.com/apache/spark/pull/25728#issuecomment-553768329 **[Test build #113749 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/113749/testReport)** for PR 25728 at commit [`7c38b8a`](https://github.com/apache/spark/commit/7c38b8a11ae22f32603084fe0e0992e4303a944f). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26513: [SPARK-29834][SQL]DESC DATABASE should look up catalog like v2 commands
AmplabJenkins commented on issue #26513: [SPARK-29834][SQL]DESC DATABASE should look up catalog like v2 commands URL: https://github.com/apache/spark/pull/26513#issuecomment-553768533 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18636/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #26429: [SPARK-29777][SparkR] SparkR::cleanClosure aggressively removes a function required by user function
HyukjinKwon commented on a change in pull request #26429: [SPARK-29777][SparkR]
SparkR::cleanClosure aggressively removes a function required by user function
URL: https://github.com/apache/spark/pull/26429#discussion_r346162361
##
File path: R/pkg/tests/fulltests/test_utils.R
##
@@ -110,6 +110,15 @@ test_that("cleanClosure on R functions", {
actual <- get("y", envir = env, inherits = FALSE)
expect_equal(actual, y)
+ # Test for combination for nested and sequenctial functions in a closure
+ f1 <- function(x) x + 1
+ f2 <- function(x) f1(x) + 2
+ user_func <- function(x) { f1(x); f2(x) }
+ c_user_func_env <- environment(cleanClosure(user_func))
Review comment:
BTW, I think naming `c_user_func_env` is not preferred (it was discussed
here https://github.com/apache/spark/pull/17590#issuecomment-293732796) before.
I think it should rather be `cUserFuncEnv`.
Google guide seems updated rapidly
(https://google.github.io/styleguide/Rguide.html).. We will have to update the
guide ...
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26514: [SPARK-29888][SQL] new interval string parser shall handle numeric with on fractional part
SparkQA commented on issue #26514: [SPARK-29888][SQL] new interval string parser shall handle numeric with on fractional part URL: https://github.com/apache/spark/pull/26514#issuecomment-553765579 **[Test build #113761 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/113761/testReport)** for PR 26514 at commit [`314829d`](https://github.com/apache/spark/commit/314829d7e8e894fec8b34266e5f3bdaeef750af3). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #26509: [SPARK-29427][SQL] Add API to convert RelationalGroupedDataset to KeyValueGroupedDataset
cloud-fan commented on a change in pull request #26509: [SPARK-29427][SQL] Add
API to convert RelationalGroupedDataset to KeyValueGroupedDataset
URL: https://github.com/apache/spark/pull/26509#discussion_r346161482
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/RelationalGroupedDataset.scala
##
@@ -129,6 +132,32 @@ class RelationalGroupedDataset protected[sql](
(inputExpr: Expression) => exprToFunc(inputExpr)
}
+ /**
+ * Returns a `KeyValueGroupedDataset` where the data is grouped by the
grouping expressions
+ * of current `RelationalGroupedDataset`.
+ *
+ * @since 3.0.0
+ */
+ def keyAs[U : Encoder]: KeyValueGroupedDataset[U, T] = {
+val keyEncoder = encoderFor[U]
+val aliasedGrps = groupingExprs.map { g =>
+ g.transformDown {
+ case u: UnresolvedAttribute => df.resolve(u.name)
+ }
+}.map(alias)
+val additionalCols = aliasedGrps.filter(g =>
!df.logicalPlan.outputSet.contains(g.toAttribute))
+val qe = Dataset.ofRows(
+ df.sparkSession,
+ Project(df.logicalPlan.output ++ additionalCols,
df.logicalPlan)).queryExecution
Review comment:
This seems inefficient. Can we make
`KeyValueGroupedDataset.groupingAttributes` a `Seq[Expression]`?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26509: [SPARK-29427][SQL] Add API to convert RelationalGroupedDataset to KeyValueGroupedDataset
AmplabJenkins removed a comment on issue #26509: [SPARK-29427][SQL] Add API to convert RelationalGroupedDataset to KeyValueGroupedDataset URL: https://github.com/apache/spark/pull/26509#issuecomment-553763951 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26509: [SPARK-29427][SQL] Add API to convert RelationalGroupedDataset to KeyValueGroupedDataset
AmplabJenkins removed a comment on issue #26509: [SPARK-29427][SQL] Add API to convert RelationalGroupedDataset to KeyValueGroupedDataset URL: https://github.com/apache/spark/pull/26509#issuecomment-553763956 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113748/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26509: [SPARK-29427][SQL] Add API to convert RelationalGroupedDataset to KeyValueGroupedDataset
AmplabJenkins commented on issue #26509: [SPARK-29427][SQL] Add API to convert RelationalGroupedDataset to KeyValueGroupedDataset URL: https://github.com/apache/spark/pull/26509#issuecomment-553763951 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26509: [SPARK-29427][SQL] Add API to convert RelationalGroupedDataset to KeyValueGroupedDataset
AmplabJenkins commented on issue #26509: [SPARK-29427][SQL] Add API to convert RelationalGroupedDataset to KeyValueGroupedDataset URL: https://github.com/apache/spark/pull/26509#issuecomment-553763956 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113748/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26514: [SPARK-29888][SQL] new interval string parser shall handle numeric with on fractional part
AmplabJenkins removed a comment on issue #26514: [SPARK-29888][SQL] new interval string parser shall handle numeric with on fractional part URL: https://github.com/apache/spark/pull/26514#issuecomment-553763621 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26514: [SPARK-29888][SQL] new interval string parser shall handle numeric with on fractional part
AmplabJenkins removed a comment on issue #26514: [SPARK-29888][SQL] new interval string parser shall handle numeric with on fractional part URL: https://github.com/apache/spark/pull/26514#issuecomment-553763625 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18635/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #26509: [SPARK-29427][SQL] Add API to convert RelationalGroupedDataset to KeyValueGroupedDataset
cloud-fan commented on a change in pull request #26509: [SPARK-29427][SQL] Add
API to convert RelationalGroupedDataset to KeyValueGroupedDataset
URL: https://github.com/apache/spark/pull/26509#discussion_r346160710
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/RelationalGroupedDataset.scala
##
@@ -46,11 +47,13 @@ import org.apache.spark.sql.types.{NumericType, StructType}
* @since 2.0.0
*/
@Stable
-class RelationalGroupedDataset protected[sql](
-private[sql] val df: DataFrame,
+class RelationalGroupedDataset[T] protected[sql](
Review comment:
This is a stable API, is it OK to add type parameter? @srowen @dongjoon-hyun
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26514: [SPARK-29888][SQL] new interval string parser shall handle numeric with on fractional part
AmplabJenkins commented on issue #26514: [SPARK-29888][SQL] new interval string parser shall handle numeric with on fractional part URL: https://github.com/apache/spark/pull/26514#issuecomment-553763621 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #26509: [SPARK-29427][SQL] Add API to convert RelationalGroupedDataset to KeyValueGroupedDataset
SparkQA removed a comment on issue #26509: [SPARK-29427][SQL] Add API to convert RelationalGroupedDataset to KeyValueGroupedDataset URL: https://github.com/apache/spark/pull/26509#issuecomment-553713033 **[Test build #113748 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/113748/testReport)** for PR 26509 at commit [`c5f2e26`](https://github.com/apache/spark/commit/c5f2e2663179b8b6cc0cba77df12a98612fbbc05). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26514: [SPARK-29888][SQL] new interval string parser shall handle numeric with on fractional part
AmplabJenkins commented on issue #26514: [SPARK-29888][SQL] new interval string parser shall handle numeric with on fractional part URL: https://github.com/apache/spark/pull/26514#issuecomment-553763625 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18635/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] yaooqinn commented on a change in pull request #26491: [SPARK-29870][SQL] Unify the logic of multi-units interval string to CalendarInterval
yaooqinn commented on a change in pull request #26491: [SPARK-29870][SQL] Unify
the logic of multi-units interval string to CalendarInterval
URL: https://github.com/apache/spark/pull/26491#discussion_r346160208
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/IntervalUtils.scala
##
@@ -505,28 +442,27 @@ object IntervalUtils {
i += 1
case _ if '0' <= b && b <= '9' =>
isNegative = false
-case _ => return null
+case '.' =>
Review comment:
https://github.com/apache/spark/pull/26514
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26509: [SPARK-29427][SQL] Add API to convert RelationalGroupedDataset to KeyValueGroupedDataset
SparkQA commented on issue #26509: [SPARK-29427][SQL] Add API to convert RelationalGroupedDataset to KeyValueGroupedDataset URL: https://github.com/apache/spark/pull/26509#issuecomment-553763476 **[Test build #113748 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/113748/testReport)** for PR 26509 at commit [`c5f2e26`](https://github.com/apache/spark/commit/c5f2e2663179b8b6cc0cba77df12a98612fbbc05). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26514: [SPARK-29888][SQL] new interval string parser shall handle numeric with on fractional part
SparkQA commented on issue #26514: [SPARK-29888][SQL] new interval string parser shall handle numeric with on fractional part URL: https://github.com/apache/spark/pull/26514#issuecomment-553763093 **[Test build #113760 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/113760/testReport)** for PR 26514 at commit [`74f8435`](https://github.com/apache/spark/commit/74f84350770a420f143562bc3d2f6e3e551c185d). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #26429: [SPARK-29777][SparkR] SparkR::cleanClosure aggressively removes a function required by user function
HyukjinKwon commented on a change in pull request #26429: [SPARK-29777][SparkR]
SparkR::cleanClosure aggressively removes a function required by user function
URL: https://github.com/apache/spark/pull/26429#discussion_r346158731
##
File path: R/pkg/R/utils.R
##
@@ -546,8 +546,11 @@ processClosure <- function(node, oldEnv, defVars,
checkedFuncs, newEnv) {
ifelse(identical(func, obj), TRUE, FALSE)
})
if (sum(found) > 0) {
-# If function has been examined, ignore.
-break
+# If function has been examined
+if (identical(parent.env(environment(funcList[found][[1]])),
func.env)) {
Review comment:
Sorry I wasn't clear. It looks actually able to break a valid case.
```r
df <- createDataFrame(list(list(n=1)))
ff <- function(n) { ifelse(n == 1, 1, n * ff(n-1)) }
collect(dapply(df, function(x) {
data.frame(a=ff(x$n))
}, structType("a double")))
```
Before:
```
a
1 1
```
After:
```
Error: node stack overflow
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] yaooqinn commented on issue #26514: [SPARK-29888][SQL] new interval string parser shall handle numeric with on fractional part
yaooqinn commented on issue #26514: [SPARK-29888][SQL] new interval string parser shall handle numeric with on fractional part URL: https://github.com/apache/spark/pull/26514#issuecomment-553761719 cc @cloud-fan @MaxGekk, thanks in advance. this pr is raised via comment @ https://github.com/apache/spark/pull/26491#discussion_r346151299 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] yaooqinn opened a new pull request #26514: [SPARK-29888][SQL] new interval string parser shall handle numeric with on fractional part
yaooqinn opened a new pull request #26514: [SPARK-29888][SQL] new interval
string parser shall handle numeric with on fractional part
URL: https://github.com/apache/spark/pull/26514
### What changes were proposed in this pull request?
Current string to interval cast logic does not support i.e. cast('.111
second' as interval) which will fail in SIGN state and return null, actually,
it is 00:00:00.111.
```scala
-- !query 63
select interval '.111 seconds'
-- !query 63 schema
struct<0.111 seconds:interval>
-- !query 63 output
0.111 seconds
-- !query 64
select cast('.111 seconds' as interval)
-- !query 64 schema
struct
-- !query 64 output
NULL
### Why are the changes needed?
bug fix.
### Does this PR introduce any user-facing change?
no
### How was this patch tested?
add ut
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] LantaoJin commented on issue #26499: [SPARK-29869][SQL] Make error message more meaningful when HiveMetastoreCatalog#convertToLogicalRelation throws AssertionError
LantaoJin commented on issue #26499: [SPARK-29869][SQL] Make error message more meaningful when HiveMetastoreCatalog#convertToLogicalRelation throws AssertionError URL: https://github.com/apache/spark/pull/26499#issuecomment-553760856 This issue caused by `PartitioningAwareFileIndex#inferPartitioning()`. For non-HiveMetastore Spark (maybe databricks runtime), it's useful. But for Hive table, it shouldn't infer partition if Hive tell us it's a non partitioned table. I think it should be fix by adding a variable in `DataSource#resolveRelation`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26416: [SPARK-29779][CORE] Compact old event log files and cleanup
AmplabJenkins removed a comment on issue #26416: [SPARK-29779][CORE] Compact old event log files and cleanup URL: https://github.com/apache/spark/pull/26416#issuecomment-553759714 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26416: [SPARK-29779][CORE] Compact old event log files and cleanup
AmplabJenkins removed a comment on issue #26416: [SPARK-29779][CORE] Compact old event log files and cleanup URL: https://github.com/apache/spark/pull/26416#issuecomment-553759732 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113753/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26416: [SPARK-29779][CORE] Compact old event log files and cleanup
AmplabJenkins commented on issue #26416: [SPARK-29779][CORE] Compact old event log files and cleanup URL: https://github.com/apache/spark/pull/26416#issuecomment-553759714 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] LantaoJin removed a comment on issue #26499: [SPARK-29869][SQL] Make error message more meaningful when HiveMetastoreCatalog#convertToLogicalRelation throws AssertionError
LantaoJin removed a comment on issue #26499: [SPARK-29869][SQL] Make error message more meaningful when HiveMetastoreCatalog#convertToLogicalRelation throws AssertionError URL: https://github.com/apache/spark/pull/26499#issuecomment-553752358 Hi @wangyum , do you think should we block the creation of non-partitioned table which LOCATION/path contains "=". This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] LantaoJin removed a comment on issue #26499: [SPARK-29869][SQL] Make error message more meaningful when HiveMetastoreCatalog#convertToLogicalRelation throws AssertionError
LantaoJin removed a comment on issue #26499: [SPARK-29869][SQL] Make error message more meaningful when HiveMetastoreCatalog#convertToLogicalRelation throws AssertionError URL: https://github.com/apache/spark/pull/26499#issuecomment-553753688 > Hi @wangyum , do you think should we block the creation of non-partitioned table which LOCATION/path contains "=". But we cannot ban the creation by Hive. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26416: [SPARK-29779][CORE] Compact old event log files and cleanup
AmplabJenkins commented on issue #26416: [SPARK-29779][CORE] Compact old event log files and cleanup URL: https://github.com/apache/spark/pull/26416#issuecomment-553759732 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113753/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26492: [SPARK-28885][SQL][FOLLOW-UP] Re-enable the ported PgSQL regression tests of SQLQueryTestSuite
AmplabJenkins removed a comment on issue #26492: [SPARK-28885][SQL][FOLLOW-UP] Re-enable the ported PgSQL regression tests of SQLQueryTestSuite URL: https://github.com/apache/spark/pull/26492#issuecomment-553759042 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18634/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #26416: [SPARK-29779][CORE] Compact old event log files and cleanup
SparkQA removed a comment on issue #26416: [SPARK-29779][CORE] Compact old event log files and cleanup URL: https://github.com/apache/spark/pull/26416#issuecomment-553724834 **[Test build #113753 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/113753/testReport)** for PR 26416 at commit [`f64388a`](https://github.com/apache/spark/commit/f64388a37fb61bf042b9df002cf48fd51b07c351). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26492: [SPARK-28885][SQL][FOLLOW-UP] Re-enable the ported PgSQL regression tests of SQLQueryTestSuite
AmplabJenkins commented on issue #26492: [SPARK-28885][SQL][FOLLOW-UP] Re-enable the ported PgSQL regression tests of SQLQueryTestSuite URL: https://github.com/apache/spark/pull/26492#issuecomment-553759042 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18634/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26492: [SPARK-28885][SQL][FOLLOW-UP] Re-enable the ported PgSQL regression tests of SQLQueryTestSuite
AmplabJenkins commented on issue #26492: [SPARK-28885][SQL][FOLLOW-UP] Re-enable the ported PgSQL regression tests of SQLQueryTestSuite URL: https://github.com/apache/spark/pull/26492#issuecomment-553759037 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26416: [SPARK-29779][CORE] Compact old event log files and cleanup
SparkQA commented on issue #26416: [SPARK-29779][CORE] Compact old event log files and cleanup URL: https://github.com/apache/spark/pull/26416#issuecomment-553759124 **[Test build #113753 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/113753/testReport)** for PR 26416 at commit [`f64388a`](https://github.com/apache/spark/commit/f64388a37fb61bf042b9df002cf48fd51b07c351). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26492: [SPARK-28885][SQL][FOLLOW-UP] Re-enable the ported PgSQL regression tests of SQLQueryTestSuite
AmplabJenkins removed a comment on issue #26492: [SPARK-28885][SQL][FOLLOW-UP] Re-enable the ported PgSQL regression tests of SQLQueryTestSuite URL: https://github.com/apache/spark/pull/26492#issuecomment-553759037 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26492: [SPARK-28885][SQL][FOLLOW-UP] Re-enable the ported PgSQL regression tests of SQLQueryTestSuite
SparkQA commented on issue #26492: [SPARK-28885][SQL][FOLLOW-UP] Re-enable the ported PgSQL regression tests of SQLQueryTestSuite URL: https://github.com/apache/spark/pull/26492#issuecomment-553758687 **[Test build #113759 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/113759/testReport)** for PR 26492 at commit [`202988b`](https://github.com/apache/spark/commit/202988bb41222b0de4055402cce07bcbab48c560). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] maropu commented on issue #26497: [SPARK-29873][SQL][TESTS] Support `--import` directive to load queries from another test case in SQLQueryTestSuite
maropu commented on issue #26497: [SPARK-29873][SQL][TESTS] Support `--import` directive to load queries from another test case in SQLQueryTestSuite URL: https://github.com/apache/spark/pull/26497#issuecomment-553757017 Thanks for merging! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #26497: [SPARK-29873][SQL][TESTS] Support `--import` directive to load queries from another test case in SQLQueryTestSuite
maropu commented on a change in pull request #26497: [SPARK-29873][SQL][TESTS] Support `--import` directive to load queries from another test case in SQLQueryTestSuite URL: https://github.com/apache/spark/pull/26497#discussion_r346153955 ## File path: sql/core/src/test/resources/sql-tests/inputs/ansi/decimalArithmeticOperations.sql ## @@ -0,0 +1,32 @@ +-- SPARK-23179: SQL ANSI 2011 states that in case of overflow during arithmetic operations, +-- an exception should be thrown instead of returning NULL. +-- This is what most of the SQL DBs do (eg. SQLServer, DB2). + Review comment: Yea, I have no idea, too. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #26497: [SPARK-29873][SQL][TESTS] Support `--import` directive to load queries from another test case in SQLQueryTestSuite
maropu commented on a change in pull request #26497: [SPARK-29873][SQL][TESTS] Support `--import` directive to load queries from another test case in SQLQueryTestSuite URL: https://github.com/apache/spark/pull/26497#discussion_r346153955 ## File path: sql/core/src/test/resources/sql-tests/inputs/ansi/decimalArithmeticOperations.sql ## @@ -0,0 +1,32 @@ +-- SPARK-23179: SQL ANSI 2011 states that in case of overflow during arithmetic operations, +-- an exception should be thrown instead of returning NULL. +-- This is what most of the SQL DBs do (eg. SQLServer, DB2). + Review comment: Yea, I think so, too. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on issue #26301: [SPARK-29644][SQL] Corrected ShortType and ByteType mapping to SmallInt and TinyInt in JDBCUtils
dongjoon-hyun commented on issue #26301: [SPARK-29644][SQL] Corrected ShortType and ByteType mapping to SmallInt and TinyInt in JDBCUtils URL: https://github.com/apache/spark/pull/26301#issuecomment-553756139 Sure. Thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #26492: [SPARK-28885][SQL][FOLLOW-UP] Re-enable the ported PgSQL regression tests of SQLQueryTestSuite
maropu commented on a change in pull request #26492:
[SPARK-28885][SQL][FOLLOW-UP] Re-enable the ported PgSQL regression tests of
SQLQueryTestSuite
URL: https://github.com/apache/spark/pull/26492#discussion_r346153158
##
File path:
sql/core/src/test/resources/sql-tests/inputs/postgreSQL/timestamp.sql
##
@@ -18,7 +18,7 @@ CREATE TABLE TIMESTAMP_TBL (d1 timestamp) USING parquet;
-- PostgreSQL implicitly casts string literals to data with timestamp types,
but
-- Spark does not support that kind of implicit casts.
-INSERT INTO TIMESTAMP_TBL VALUES timestamp(('now'));
+INSERT INTO TIMESTAMP_TBL VALUES (timestamp('now'));
Review comment:
Oh... I got it.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #26492: [SPARK-28885][SQL][FOLLOW-UP] Re-enable the ported PgSQL regression tests of SQLQueryTestSuite
dongjoon-hyun commented on a change in pull request #26492:
[SPARK-28885][SQL][FOLLOW-UP] Re-enable the ported PgSQL regression tests of
SQLQueryTestSuite
URL: https://github.com/apache/spark/pull/26492#discussion_r346153144
##
File path:
sql/core/src/test/resources/sql-tests/results/postgreSQL/timestamp.sql.out
##
@@ -11,55 +11,55 @@ struct<>
-- !query 1
-INSERT INTO TIMESTAMP_TBL VALUES ('now')
+INSERT INTO TIMESTAMP_TBL VALUES timestamp(('now'))
Review comment:
I mean this one~
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #26492: [SPARK-28885][SQL][FOLLOW-UP] Re-enable the ported PgSQL regression tests of SQLQueryTestSuite
dongjoon-hyun commented on a change in pull request #26492:
[SPARK-28885][SQL][FOLLOW-UP] Re-enable the ported PgSQL regression tests of
SQLQueryTestSuite
URL: https://github.com/apache/spark/pull/26492#discussion_r346152973
##
File path:
sql/core/src/test/resources/sql-tests/inputs/postgreSQL/timestamp.sql
##
@@ -18,7 +18,7 @@ CREATE TABLE TIMESTAMP_TBL (d1 timestamp) USING parquet;
-- PostgreSQL implicitly casts string literals to data with timestamp types,
but
-- Spark does not support that kind of implicit casts.
-INSERT INTO TIMESTAMP_TBL VALUES timestamp(('now'));
+INSERT INTO TIMESTAMP_TBL VALUES (timestamp('now'));
Review comment:
Did we regenerate `timestamp.sql.out`?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on issue #26492: [SPARK-28885][SQL][FOLLOW-UP] Re-enable the ported PgSQL regression tests of SQLQueryTestSuite
dongjoon-hyun commented on issue #26492: [SPARK-28885][SQL][FOLLOW-UP] Re-enable the ported PgSQL regression tests of SQLQueryTestSuite URL: https://github.com/apache/spark/pull/26492#issuecomment-553755260 `ThriftServerQueryTestSuite` reuses the queries. It seems that we need to regenerate them too, @maropu . (Also, cc @wangyum ). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #26513: [SPARK-29834][SQL]DESC DATABASE should look up catalog like v2 commands
cloud-fan commented on a change in pull request #26513: [SPARK-29834][SQL]DESC
DATABASE should look up catalog like v2 commands
URL: https://github.com/apache/spark/pull/26513#discussion_r346152101
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DescribeNamespaceExec.scala
##
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.execution.datasources.v2
+
+import scala.collection.JavaConverters._
+import scala.collection.mutable.ArrayBuffer
+
+import org.apache.spark.sql.catalyst.InternalRow
+import org.apache.spark.sql.catalyst.encoders.RowEncoder
+import org.apache.spark.sql.catalyst.expressions.{Attribute,
GenericRowWithSchema}
+import org.apache.spark.sql.connector.catalog.CatalogPlugin
+import
org.apache.spark.sql.execution.datasources.v2.V2SessionCatalog.COMMENT_TABLE_PROP
+import
org.apache.spark.sql.execution.datasources.v2.V2SessionCatalog.LOCATION_TABLE_PROP
+import
org.apache.spark.sql.execution.datasources.v2.V2SessionCatalog.RESERVED_PROPERTIES
+import org.apache.spark.sql.types.StructType
+
+/**
+ * Physical plan node for describing a namespace.
+ */
+case class DescribeNamespaceExec(
+output: Seq[Attribute],
+catalog: CatalogPlugin,
+namespace: Seq[String],
+isExtended: Boolean) extends V2CommandExec {
+
+ private val encoder =
RowEncoder(StructType.fromAttributes(output)).resolveAndBind()
+
+ override protected def run(): Seq[InternalRow] = {
+import org.apache.spark.sql.connector.catalog.CatalogV2Implicits._
+
+val rows = new ArrayBuffer[InternalRow]()
+val nsCatalog = catalog.asNamespaceCatalog
+val ns = namespace.toArray
+val nsMetadata = nsCatalog.loadNamespaceMetadata(ns)
+val properties = nsMetadata.asScala.toSeq.filter(p =>
!RESERVED_PROPERTIES.contains(p._1))
+
+rows += toCatalystRow("Namespace Name", ns.head)
Review comment:
nit: `ns.last` instead of `ns.head`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #26513: [SPARK-29834][SQL]DESC DATABASE should look up catalog like v2 commands
cloud-fan commented on a change in pull request #26513: [SPARK-29834][SQL]DESC
DATABASE should look up catalog like v2 commands
URL: https://github.com/apache/spark/pull/26513#discussion_r346152508
##
File path:
sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2SQLSuite.scala
##
@@ -116,6 +116,23 @@ class DataSourceV2SQLSuite
Row("data", "string", "")))
}
+ test("DescribeNamespace using v2 catalog") {
+spark.sql("CREATE NAMESPACE IF NOT EXISTS testcat.ns_name COMMENT " +
Review comment:
can we test `testcat.ns1.ns2`?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] yaooqinn commented on a change in pull request #26491: [SPARK-29870][SQL] Unify the logic of multi-units interval string to CalendarInterval
yaooqinn commented on a change in pull request #26491: [SPARK-29870][SQL] Unify
the logic of multi-units interval string to CalendarInterval
URL: https://github.com/apache/spark/pull/26491#discussion_r346152182
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/IntervalUtils.scala
##
@@ -505,28 +442,27 @@ object IntervalUtils {
i += 1
case _ if '0' <= b && b <= '9' =>
isNegative = false
-case _ => return null
+case '.' =>
Review comment:
OK, i'd fix this bug first
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #26513: [SPARK-29834][SQL]DESC DATABASE should look up catalog like v2 commands
cloud-fan commented on a change in pull request #26513: [SPARK-29834][SQL]DESC
DATABASE should look up catalog like v2 commands
URL: https://github.com/apache/spark/pull/26513#discussion_r346152101
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DescribeNamespaceExec.scala
##
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.execution.datasources.v2
+
+import scala.collection.JavaConverters._
+import scala.collection.mutable.ArrayBuffer
+
+import org.apache.spark.sql.catalyst.InternalRow
+import org.apache.spark.sql.catalyst.encoders.RowEncoder
+import org.apache.spark.sql.catalyst.expressions.{Attribute,
GenericRowWithSchema}
+import org.apache.spark.sql.connector.catalog.CatalogPlugin
+import
org.apache.spark.sql.execution.datasources.v2.V2SessionCatalog.COMMENT_TABLE_PROP
+import
org.apache.spark.sql.execution.datasources.v2.V2SessionCatalog.LOCATION_TABLE_PROP
+import
org.apache.spark.sql.execution.datasources.v2.V2SessionCatalog.RESERVED_PROPERTIES
+import org.apache.spark.sql.types.StructType
+
+/**
+ * Physical plan node for describing a namespace.
+ */
+case class DescribeNamespaceExec(
+output: Seq[Attribute],
+catalog: CatalogPlugin,
+namespace: Seq[String],
+isExtended: Boolean) extends V2CommandExec {
+
+ private val encoder =
RowEncoder(StructType.fromAttributes(output)).resolveAndBind()
+
+ override protected def run(): Seq[InternalRow] = {
+import org.apache.spark.sql.connector.catalog.CatalogV2Implicits._
+
+val rows = new ArrayBuffer[InternalRow]()
+val nsCatalog = catalog.asNamespaceCatalog
+val ns = namespace.toArray
+val nsMetadata = nsCatalog.loadNamespaceMetadata(ns)
+val properties = nsMetadata.asScala.toSeq.filter(p =>
!RESERVED_PROPERTIES.contains(p._1))
+
+rows += toCatalystRow("Namespace Name", ns.head)
Review comment:
nit: `ns.quoted` instead of `ns.head`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26485: [SPARK-29860][SQL] Fix dataType mismatch issue for InSubquery.
AmplabJenkins removed a comment on issue #26485: [SPARK-29860][SQL] Fix dataType mismatch issue for InSubquery. URL: https://github.com/apache/spark/pull/26485#issuecomment-553754308 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113745/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26280: [SPARK-14922][SPARK-17732][SPARK-23866][SQL] Support partition filter in ALTER TABLE DROP PARTITION and batch dropping PARTITIONS
AmplabJenkins removed a comment on issue #26280: [SPARK-14922][SPARK-17732][SPARK-23866][SQL] Support partition filter in ALTER TABLE DROP PARTITION and batch dropping PARTITIONS URL: https://github.com/apache/spark/pull/26280#issuecomment-553753864 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113757/ Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26485: [SPARK-29860][SQL] Fix dataType mismatch issue for InSubquery.
AmplabJenkins commented on issue #26485: [SPARK-29860][SQL] Fix dataType mismatch issue for InSubquery. URL: https://github.com/apache/spark/pull/26485#issuecomment-553754308 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113745/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #26513: [SPARK-29834][SQL]DESC DATABASE should look up catalog like v2 commands
cloud-fan commented on a change in pull request #26513: [SPARK-29834][SQL]DESC DATABASE should look up catalog like v2 commands URL: https://github.com/apache/spark/pull/26513#discussion_r346151710 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statements.scala ## @@ -269,6 +269,13 @@ case class DescribeTableStatement( partitionSpec: TablePartitionSpec, isExtended: Boolean) extends ParsedStatement +/** + * A DESCRIBE NAMESPACE statement, as parsed from SQL. + */ +case class DescribeNamespaceStatement( +dbName: Seq[String], Review comment: nit: `namespace` not `dbName` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26485: [SPARK-29860][SQL] Fix dataType mismatch issue for InSubquery.
AmplabJenkins removed a comment on issue #26485: [SPARK-29860][SQL] Fix dataType mismatch issue for InSubquery. URL: https://github.com/apache/spark/pull/26485#issuecomment-553754305 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26485: [SPARK-29860][SQL] Fix dataType mismatch issue for InSubquery.
AmplabJenkins commented on issue #26485: [SPARK-29860][SQL] Fix dataType mismatch issue for InSubquery. URL: https://github.com/apache/spark/pull/26485#issuecomment-553754305 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26280: [SPARK-14922][SPARK-17732][SPARK-23866][SQL] Support partition filter in ALTER TABLE DROP PARTITION and batch dropping PARTITIONS
AmplabJenkins removed a comment on issue #26280: [SPARK-14922][SPARK-17732][SPARK-23866][SQL] Support partition filter in ALTER TABLE DROP PARTITION and batch dropping PARTITIONS URL: https://github.com/apache/spark/pull/26280#issuecomment-553753858 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #26513: [SPARK-29834][SQL]DESC DATABASE should look up catalog like v2 commands
cloud-fan commented on a change in pull request #26513: [SPARK-29834][SQL]DESC
DATABASE should look up catalog like v2 commands
URL: https://github.com/apache/spark/pull/26513#discussion_r346151606
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/DescribeNamespaceSchema.scala
##
@@ -0,0 +1,29 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.catalyst.plans
+
+import org.apache.spark.sql.catalyst.expressions.AttributeReference
+import org.apache.spark.sql.types.{MetadataBuilder, StringType}
+
+private[sql] object DescribeNamespaceSchema {
Review comment:
It's only used once, can we inline it?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #26485: [SPARK-29860][SQL] Fix dataType mismatch issue for InSubquery.
SparkQA removed a comment on issue #26485: [SPARK-29860][SQL] Fix dataType mismatch issue for InSubquery. URL: https://github.com/apache/spark/pull/26485#issuecomment-553702868 **[Test build #113745 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/113745/testReport)** for PR 26485 at commit [`1a67c8d`](https://github.com/apache/spark/commit/1a67c8d846865565b94c4d362c2f53b79250a36b). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #26280: [SPARK-14922][SPARK-17732][SPARK-23866][SQL] Support partition filter in ALTER TABLE DROP PARTITION and batch dropping PARTITIONS
SparkQA removed a comment on issue #26280: [SPARK-14922][SPARK-17732][SPARK-23866][SQL] Support partition filter in ALTER TABLE DROP PARTITION and batch dropping PARTITIONS URL: https://github.com/apache/spark/pull/26280#issuecomment-553750174 **[Test build #113757 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/113757/testReport)** for PR 26280 at commit [`21cd780`](https://github.com/apache/spark/commit/21cd7805ef79b9606ae06077f0514e1fefde377c). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26280: [SPARK-14922][SPARK-17732][SPARK-23866][SQL] Support partition filter in ALTER TABLE DROP PARTITION and batch dropping PARTITIONS
AmplabJenkins removed a comment on issue #26280: [SPARK-14922][SPARK-17732][SPARK-23866][SQL] Support partition filter in ALTER TABLE DROP PARTITION and batch dropping PARTITIONS URL: https://github.com/apache/spark/pull/26280#issuecomment-553750607 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18632/ Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26485: [SPARK-29860][SQL] Fix dataType mismatch issue for InSubquery.
SparkQA commented on issue #26485: [SPARK-29860][SQL] Fix dataType mismatch issue for InSubquery. URL: https://github.com/apache/spark/pull/26485#issuecomment-553753811 **[Test build #113745 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/113745/testReport)** for PR 26485 at commit [`1a67c8d`](https://github.com/apache/spark/commit/1a67c8d846865565b94c4d362c2f53b79250a36b). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26280: [SPARK-14922][SPARK-17732][SPARK-23866][SQL] Support partition filter in ALTER TABLE DROP PARTITION and batch dropping PARTITIONS
SparkQA commented on issue #26280: [SPARK-14922][SPARK-17732][SPARK-23866][SQL] Support partition filter in ALTER TABLE DROP PARTITION and batch dropping PARTITIONS URL: https://github.com/apache/spark/pull/26280#issuecomment-553753834 **[Test build #113757 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/113757/testReport)** for PR 26280 at commit [`21cd780`](https://github.com/apache/spark/commit/21cd7805ef79b9606ae06077f0514e1fefde377c). * This patch **fails to generate documentation**. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_: * `case class PartitioningAttribute(` * ` case class ExpressionBuilder(val table: MetaStoreApiTable,` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26280: [SPARK-14922][SPARK-17732][SPARK-23866][SQL] Support partition filter in ALTER TABLE DROP PARTITION and batch dropping PARTITIONS
AmplabJenkins commented on issue #26280: [SPARK-14922][SPARK-17732][SPARK-23866][SQL] Support partition filter in ALTER TABLE DROP PARTITION and batch dropping PARTITIONS URL: https://github.com/apache/spark/pull/26280#issuecomment-553753858 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #26491: [SPARK-29870][SQL] Unify the logic of multi-units interval string to CalendarInterval
cloud-fan commented on a change in pull request #26491: [SPARK-29870][SQL]
Unify the logic of multi-units interval string to CalendarInterval
URL: https://github.com/apache/spark/pull/26491#discussion_r346151299
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/IntervalUtils.scala
##
@@ -505,28 +442,27 @@ object IntervalUtils {
i += 1
case _ if '0' <= b && b <= '9' =>
isNegative = false
-case _ => return null
+case '.' =>
Review comment:
can we have a separated PR to fix bug? Now it's a little hard to review with
everything mixed together.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26280: [SPARK-14922][SPARK-17732][SPARK-23866][SQL] Support partition filter in ALTER TABLE DROP PARTITION and batch dropping PARTITIONS
AmplabJenkins commented on issue #26280: [SPARK-14922][SPARK-17732][SPARK-23866][SQL] Support partition filter in ALTER TABLE DROP PARTITION and batch dropping PARTITIONS URL: https://github.com/apache/spark/pull/26280#issuecomment-553753864 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113757/ Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] LantaoJin commented on issue #26499: [SPARK-29869][SQL] Make error message more meaningful when HiveMetastoreCatalog#convertToLogicalRelation throws AssertionError
LantaoJin commented on issue #26499: [SPARK-29869][SQL] Make error message more meaningful when HiveMetastoreCatalog#convertToLogicalRelation throws AssertionError URL: https://github.com/apache/spark/pull/26499#issuecomment-553753688 > Hi @wangyum , do you think should we block the creation of non-partitioned table which LOCATION/path contains "=". But we cannot ban the creation by Hive. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on issue #26441: [SPARK-29682][SQL] Resolve conflicting attributes in Expand correctly
dongjoon-hyun commented on issue #26441: [SPARK-29682][SQL] Resolve conflicting attributes in Expand correctly URL: https://github.com/apache/spark/pull/26441#issuecomment-553753614 Thank you so much! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #26491: [SPARK-29870][SQL] Unify the logic of multi-units interval string to CalendarInterval
cloud-fan commented on a change in pull request #26491: [SPARK-29870][SQL]
Unify the logic of multi-units interval string to CalendarInterval
URL: https://github.com/apache/spark/pull/26491#discussion_r346150599
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/IntervalUtils.scala
##
@@ -452,20 +359,40 @@ object IntervalUtils {
private final val millisStr = unitToUtf8(MILLISECOND)
private final val microsStr = unitToUtf8(MICROSECOND)
+ /**
+ * A safe version of `stringToInterval`. It returns null for invalid input
string.
+ */
+ def safeStringToInterval(input: UTF8String): CalendarInterval = {
+try {
+ stringToInterval(input)
+} catch {
+ case _: IllegalArgumentException => null
+}
+ }
+
+ /**
+ * Converts a string to [[CalendarInterval]] case-insensitively.
+ *
+ * @throws IllegalArgumentException if the input string is not in valid
interval format.
+ */
def stringToInterval(input: UTF8String): CalendarInterval = {
import ParseState._
+var state = PREFIX
+def exceptionWithState(msg: String, e: Exception = null) = {
+ throw new IllegalArgumentException(s"Error parsing interval in state
'$state', $msg", e)
Review comment:
This is user-facing error, I don't think we should put the state in the
message.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26499: [SPARK-29869][SQL] Make error message more meaningful when HiveMetastoreCatalog#convertToLogicalRelation throws AssertionError
AmplabJenkins removed a comment on issue #26499: [SPARK-29869][SQL] Make error message more meaningful when HiveMetastoreCatalog#convertToLogicalRelation throws AssertionError URL: https://github.com/apache/spark/pull/26499#issuecomment-553753153 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18633/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26499: [SPARK-29869][SQL] Make error message more meaningful when HiveMetastoreCatalog#convertToLogicalRelation throws AssertionError
AmplabJenkins removed a comment on issue #26499: [SPARK-29869][SQL] Make error message more meaningful when HiveMetastoreCatalog#convertToLogicalRelation throws AssertionError URL: https://github.com/apache/spark/pull/26499#issuecomment-553753146 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26499: [SPARK-29869][SQL] Make error message more meaningful when HiveMetastoreCatalog#convertToLogicalRelation throws AssertionError
AmplabJenkins commented on issue #26499: [SPARK-29869][SQL] Make error message more meaningful when HiveMetastoreCatalog#convertToLogicalRelation throws AssertionError URL: https://github.com/apache/spark/pull/26499#issuecomment-553753146 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26499: [SPARK-29869][SQL] Make error message more meaningful when HiveMetastoreCatalog#convertToLogicalRelation throws AssertionError
AmplabJenkins commented on issue #26499: [SPARK-29869][SQL] Make error message more meaningful when HiveMetastoreCatalog#convertToLogicalRelation throws AssertionError URL: https://github.com/apache/spark/pull/26499#issuecomment-553753153 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18633/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] kevinyu98 commented on a change in pull request #25573: [SPARK-28833][DOCS][SQL] Document ALTER VIEW command
kevinyu98 commented on a change in pull request #25573:
[SPARK-28833][DOCS][SQL] Document ALTER VIEW command
URL: https://github.com/apache/spark/pull/25573#discussion_r346150272
##
File path: docs/sql-ref-syntax-ddl-alter-view.md
##
@@ -19,4 +19,222 @@ license: |
limitations under the License.
---
-**This page is under construction**
+### Description
+
+The `ALTER VIEW` statement can alter metadata associated with the view. It can
change the definition of the view, change
+the name of a view to a different name, set and unset the metadata of the view
by setting `TBLPROPERTIES`.
+
+ RENAME View
+Renames the existing view. If the new view name already exists in the source
database, a `TableAlreadyExistsException` is thrown. This operation
+does not support moving the views across databases.
+
+ Syntax
+{% highlight sql %}
+ALTER VIEW view_identifier RENAME TO view_identifier
+{% endhighlight %}
+
+ Parameters
+
+ view_identifier
+
+Specifies a view name, which may be optionally qualified with a database
name.
+ Syntax:
+
+[database_name.]view_name
+
+
+
+
+ SET View Properties
+Set one or more properties of an existing view. The properties are the key
value pairs. If the properties' keys exist,
+the values are replaced with the new values. If the properties' keys do not
exist, the key value pairs are added into
+the properties.
+
+ Syntax
+{% highlight sql %}
+ALTER VIEW view_identifier SET TBLPROPERTIES
+ (property_key=property_val [, ...])
+{% endhighlight %}
+
+ Parameters
+
+ view_identifier
+
+Specifies a view name, which may be optionally qualified with a database
name.
+ Syntax:
+
+[database_name.]view_name
+
+
+ property_key
+
+Specifies the property key. The key may consists of multiple parts
separated by dot.
+Syntax:
+
+[key_part1][.key_part2][...]
+
+
+
+
+ UNSET View Properties
+Drop one or more properties of an existing view. If the specified keys do not
exist, an exception is thrown. Use
+`IF EXISTS` to avoid the exception.
+
+ Syntax
+{% highlight sql %}
+ALTER VIEW view_identifier UNSET TBLPROPERTIES [IF EXISTS]
+ (property_key [, ...])
+{% endhighlight %}
+
+ Parameters
+
+ view_identifier
+
+Specifies a view name, which may be optionally qualified with a database
name.
+ Syntax:
+
+[database_name.]view_name
+
+
+ property_key
+
+Specifies the property key. The key may consists of multiple parts
separated by dot.
+Syntax:
+
+[key_part1][.key_part2][...]
+
+
+
+
+ ALTER View AS SELECT
+`ALTER VIEW view_identifier AS SELECT` statement changes the definition of a
view, the `SELECT` statement must be valid,
+and the `view_identifier` must exist.
+
+ Syntax
+{% highlight sql %}
+ALTER VIEW view_identifier AS select_statement
+{% endhighlight %}
+
+ Parameters
+
+ view_identifier
+
+Specifies a view name, which may be optionally qualified with a database
name.
+ Syntax:
+
+[database_name.]view_name
+
+
+ select_statement
+
+Specifies the definition of the view, detail check
[select_statement](sql-ref-syntax-qry-select.html)
+
+
+
+### Examples
+
+{% highlight sql %}
+-- Rename only changes the view name.
+-- The source and target databases of the view have to be the same.
+-- Use qualified or unqualified name for the source and target view
+ALTER VIEW tempdb1.v1 RENAME TO tempdb1.v2;
+
+-- Verify that the new view is created.
+DESCRIBE TABLE EXTENDED tempdb1.v2;
+
+++--+---+
+|col_name|data_type |comment|
+++--+---+
+|c1 |int |null |
+|c2 |string|null |
+|| | |
+|# Detailed Table Information| | |
+|Database|tempdb1 | |
+|Table |v2| |
+++--+---+
+
+-- Use `DESC TABLE EXTENDED tempdb1.v2` before and after the `ALTER VIEW`
statement to verify the changes.
Review comment:
Thanks, changed.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] imback82 commented on issue #26441: [SPARK-29682][SQL] Resolve conflicting attributes in Expand correctly
imback82 commented on issue #26441: [SPARK-29682][SQL] Resolve conflicting attributes in Expand correctly URL: https://github.com/apache/spark/pull/26441#issuecomment-553752400 thanks @cloud-fan @maropu @viirya @dongjoon-hyun for review and help! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] LantaoJin commented on issue #26499: [SPARK-29869][SQL] Make error message more meaningful when HiveMetastoreCatalog#convertToLogicalRelation throws AssertionError
LantaoJin commented on issue #26499: [SPARK-29869][SQL] Make error message more meaningful when HiveMetastoreCatalog#convertToLogicalRelation throws AssertionError URL: https://github.com/apache/spark/pull/26499#issuecomment-553752358 Hi @wangyum , do you think we should block the creation of non-partitioned table which LOCATION/path contains "=". This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] LantaoJin edited a comment on issue #26499: [SPARK-29869][SQL] Make error message more meaningful when HiveMetastoreCatalog#convertToLogicalRelation throws AssertionError
LantaoJin edited a comment on issue #26499: [SPARK-29869][SQL] Make error message more meaningful when HiveMetastoreCatalog#convertToLogicalRelation throws AssertionError URL: https://github.com/apache/spark/pull/26499#issuecomment-553752358 Hi @wangyum , do you think should we block the creation of non-partitioned table which LOCATION/path contains "=". This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26499: [SPARK-29869][SQL] Make error message more meaningful when HiveMetastoreCatalog#convertToLogicalRelation throws AssertionError
SparkQA commented on issue #26499: [SPARK-29869][SQL] Make error message more meaningful when HiveMetastoreCatalog#convertToLogicalRelation throws AssertionError URL: https://github.com/apache/spark/pull/26499#issuecomment-553752316 **[Test build #113758 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/113758/testReport)** for PR 26499 at commit [`363afb6`](https://github.com/apache/spark/commit/363afb6ec6624a9630ad7175d5ecb2bc753af581). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26280: [SPARK-14922][SPARK-17732][SPARK-23866][SQL] Support partition filter in ALTER TABLE DROP PARTITION and batch dropping PARTITIONS
AmplabJenkins commented on issue #26280: [SPARK-14922][SPARK-17732][SPARK-23866][SQL] Support partition filter in ALTER TABLE DROP PARTITION and batch dropping PARTITIONS URL: https://github.com/apache/spark/pull/26280#issuecomment-553750607 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18632/ Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26280: [SPARK-14922][SPARK-17732][SPARK-23866][SQL] Support partition filter in ALTER TABLE DROP PARTITION and batch dropping PARTITIONS
AmplabJenkins removed a comment on issue #26280: [SPARK-14922][SPARK-17732][SPARK-23866][SQL] Support partition filter in ALTER TABLE DROP PARTITION and batch dropping PARTITIONS URL: https://github.com/apache/spark/pull/26280#issuecomment-553750596 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26280: [SPARK-14922][SPARK-17732][SPARK-23866][SQL] Support partition filter in ALTER TABLE DROP PARTITION and batch dropping PARTITIONS
AmplabJenkins commented on issue #26280: [SPARK-14922][SPARK-17732][SPARK-23866][SQL] Support partition filter in ALTER TABLE DROP PARTITION and batch dropping PARTITIONS URL: https://github.com/apache/spark/pull/26280#issuecomment-553750596 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] cloud-fan commented on issue #26441: [SPARK-29682][SQL] Resolve conflicting attributes in Expand correctly
cloud-fan commented on issue #26441: [SPARK-29682][SQL] Resolve conflicting attributes in Expand correctly URL: https://github.com/apache/spark/pull/26441#issuecomment-553750711 thanks, merging to master/2.4! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #26441: [SPARK-29682][SQL] Resolve conflicting attributes in Expand correctly
cloud-fan closed pull request #26441: [SPARK-29682][SQL] Resolve conflicting attributes in Expand correctly URL: https://github.com/apache/spark/pull/26441 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26280: [SPARK-14922][SPARK-17732][SPARK-23866][SQL] Support partition filter in ALTER TABLE DROP PARTITION and batch dropping PARTITIONS
SparkQA commented on issue #26280: [SPARK-14922][SPARK-17732][SPARK-23866][SQL] Support partition filter in ALTER TABLE DROP PARTITION and batch dropping PARTITIONS URL: https://github.com/apache/spark/pull/26280#issuecomment-553750174 **[Test build #113757 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/113757/testReport)** for PR 26280 at commit [`21cd780`](https://github.com/apache/spark/commit/21cd7805ef79b9606ae06077f0514e1fefde377c). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] cloud-fan commented on issue #26497: [SPARK-29873][SQL][TESTS] Support `--import` directive to load queries from another test case in SQLQueryTestSuite
cloud-fan commented on issue #26497: [SPARK-29873][SQL][TESTS] Support `--import` directive to load queries from another test case in SQLQueryTestSuite URL: https://github.com/apache/spark/pull/26497#issuecomment-553748090 thanks, merging to master! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #26497: [SPARK-29873][SQL][TESTS] Support `--import` directive to load queries from another test case in SQLQueryTestSuite
cloud-fan closed pull request #26497: [SPARK-29873][SQL][TESTS] Support `--import` directive to load queries from another test case in SQLQueryTestSuite URL: https://github.com/apache/spark/pull/26497 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] weixiuli commented on issue #26280: [SPARK-14922][SPARK-17732][SPARK-23866][SQL] Support partition filter in ALTER TABLE DROP PARTITION and batch dropping PARTITIONS
weixiuli commented on issue #26280: [SPARK-14922][SPARK-17732][SPARK-23866][SQL] Support partition filter in ALTER TABLE DROP PARTITION and batch dropping PARTITIONS URL: https://github.com/apache/spark/pull/26280#issuecomment-553747020 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26513: [SPARK-29834][SQL]DESC DATABASE should look up catalog like v2 commands
AmplabJenkins removed a comment on issue #26513: [SPARK-29834][SQL]DESC DATABASE should look up catalog like v2 commands URL: https://github.com/apache/spark/pull/26513#issuecomment-553746291 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
