[GitHub] [spark] AmplabJenkins removed a comment on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
AmplabJenkins removed a comment on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy URL: https://github.com/apache/spark/pull/27668#issuecomment-589926613 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
AmplabJenkins removed a comment on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy URL: https://github.com/apache/spark/pull/27668#issuecomment-589926617 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118811/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
AmplabJenkins commented on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy URL: https://github.com/apache/spark/pull/27668#issuecomment-589926613 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
AmplabJenkins commented on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy URL: https://github.com/apache/spark/pull/27668#issuecomment-589926617 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118811/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
SparkQA removed a comment on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy URL: https://github.com/apache/spark/pull/27668#issuecomment-589915746 **[Test build #118811 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118811/testReport)** for PR 27668 at commit [`bd6416b`](https://github.com/apache/spark/commit/bd6416b4b015c5f9fd81f6ff4ccf838536bbfb9c). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
SparkQA commented on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy URL: https://github.com/apache/spark/pull/27668#issuecomment-589926472 **[Test build #118811 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118811/testReport)** for PR 27668 at commit [`bd6416b`](https://github.com/apache/spark/commit/bd6416b4b015c5f9fd81f6ff4ccf838536bbfb9c). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27673: [SPARK-30922] [SQL] remove the max splits config in skewed join
AmplabJenkins commented on issue #27673: [SPARK-30922] [SQL] remove the max splits config in skewed join URL: https://github.com/apache/spark/pull/27673#issuecomment-589926386 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118808/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27673: [SPARK-30922] [SQL] remove the max splits config in skewed join
AmplabJenkins removed a comment on issue #27673: [SPARK-30922] [SQL] remove the max splits config in skewed join URL: https://github.com/apache/spark/pull/27673#issuecomment-589926381 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27673: [SPARK-30922] [SQL] remove the max splits config in skewed join
AmplabJenkins removed a comment on issue #27673: [SPARK-30922] [SQL] remove the max splits config in skewed join URL: https://github.com/apache/spark/pull/27673#issuecomment-589926386 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118808/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27673: [SPARK-30922] [SQL] remove the max splits config in skewed join
AmplabJenkins commented on issue #27673: [SPARK-30922] [SQL] remove the max splits config in skewed join URL: https://github.com/apache/spark/pull/27673#issuecomment-589926381 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27673: [SPARK-30922] [SQL] remove the max splits config in skewed join
SparkQA removed a comment on issue #27673: [SPARK-30922] [SQL] remove the max splits config in skewed join URL: https://github.com/apache/spark/pull/27673#issuecomment-589908532 **[Test build #118808 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118808/testReport)** for PR 27673 at commit [`8bbfe24`](https://github.com/apache/spark/commit/8bbfe24d8265c1d7af6553c865dd72b87339d827). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27673: [SPARK-30922] [SQL] remove the max splits config in skewed join
SparkQA commented on issue #27673: [SPARK-30922] [SQL] remove the max splits config in skewed join URL: https://github.com/apache/spark/pull/27673#issuecomment-589926249 **[Test build #118808 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118808/testReport)** for PR 27673 at commit [`8bbfe24`](https://github.com/apache/spark/commit/8bbfe24d8265c1d7af6553c865dd72b87339d827). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27150: [SPARK-30471][SQL] Fix issue when comparing String and IntegerType
AmplabJenkins removed a comment on issue #27150: [SPARK-30471][SQL] Fix issue when comparing String and IntegerType URL: https://github.com/apache/spark/pull/27150#issuecomment-589923861 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118812/ Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27150: [SPARK-30471][SQL] Fix issue when comparing String and IntegerType
AmplabJenkins commented on issue #27150: [SPARK-30471][SQL] Fix issue when comparing String and IntegerType URL: https://github.com/apache/spark/pull/27150#issuecomment-589923860 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27150: [SPARK-30471][SQL] Fix issue when comparing String and IntegerType
AmplabJenkins commented on issue #27150: [SPARK-30471][SQL] Fix issue when comparing String and IntegerType URL: https://github.com/apache/spark/pull/27150#issuecomment-589923861 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118812/ Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27150: [SPARK-30471][SQL] Fix issue when comparing String and IntegerType
AmplabJenkins removed a comment on issue #27150: [SPARK-30471][SQL] Fix issue when comparing String and IntegerType URL: https://github.com/apache/spark/pull/27150#issuecomment-589923860 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27150: [SPARK-30471][SQL] Fix issue when comparing String and IntegerType
SparkQA removed a comment on issue #27150: [SPARK-30471][SQL] Fix issue when comparing String and IntegerType URL: https://github.com/apache/spark/pull/27150#issuecomment-589916199 **[Test build #118812 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118812/testReport)** for PR 27150 at commit [`cf6d9ec`](https://github.com/apache/spark/commit/cf6d9ec9c97454a22c02229bb338ef0789b1593f). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27150: [SPARK-30471][SQL] Fix issue when comparing String and IntegerType
SparkQA commented on issue #27150: [SPARK-30471][SQL] Fix issue when comparing String and IntegerType URL: https://github.com/apache/spark/pull/27150#issuecomment-589923800 **[Test build #118812 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118812/testReport)** for PR 27150 at commit [`cf6d9ec`](https://github.com/apache/spark/commit/cf6d9ec9c97454a22c02229bb338ef0789b1593f). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] deshanxiao commented on issue #27647: [SPARK-30883][TEST] Cancel the tests when setReadable and setExecutable don't work
deshanxiao commented on issue #27647: [SPARK-30883][TEST] Cancel the tests when setReadable and setExecutable don't work URL: https://github.com/apache/spark/pull/27647#issuecomment-589923654 I agree. Is it necessary to add some code to prevent running as root? @jiangxb1987 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
AmplabJenkins removed a comment on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy URL: https://github.com/apache/spark/pull/27668#issuecomment-589921623 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118810/ Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
AmplabJenkins commented on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy URL: https://github.com/apache/spark/pull/27668#issuecomment-589921623 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118810/ Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
AmplabJenkins removed a comment on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy URL: https://github.com/apache/spark/pull/27668#issuecomment-589921622 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
AmplabJenkins commented on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy URL: https://github.com/apache/spark/pull/27668#issuecomment-589921622 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
SparkQA commented on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy URL: https://github.com/apache/spark/pull/27668#issuecomment-589921563 **[Test build #118810 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118810/testReport)** for PR 27668 at commit [`ee3cdd2`](https://github.com/apache/spark/commit/ee3cdd27c1e05a10dc851f6e6ef8252b6395bd39). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
SparkQA removed a comment on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy URL: https://github.com/apache/spark/pull/27668#issuecomment-589913547 **[Test build #118810 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118810/testReport)** for PR 27668 at commit [`ee3cdd2`](https://github.com/apache/spark/commit/ee3cdd27c1e05a10dc851f6e6ef8252b6395bd39). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get
AmplabJenkins removed a comment on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get URL: https://github.com/apache/spark/pull/27657#issuecomment-589919839 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118807/ Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get
AmplabJenkins removed a comment on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get URL: https://github.com/apache/spark/pull/27657#issuecomment-589919835 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get
AmplabJenkins commented on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get URL: https://github.com/apache/spark/pull/27657#issuecomment-589919839 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118807/ Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get
AmplabJenkins commented on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get URL: https://github.com/apache/spark/pull/27657#issuecomment-589919835 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get
SparkQA commented on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get URL: https://github.com/apache/spark/pull/27657#issuecomment-589919754 **[Test build #118807 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118807/testReport)** for PR 27657 at commit [`689722a`](https://github.com/apache/spark/commit/689722afbb426fa42ae7370e1cd5e59006ef2b4b). * This patch **fails PySpark unit tests**. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get
SparkQA removed a comment on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get URL: https://github.com/apache/spark/pull/27657#issuecomment-589897858 **[Test build #118807 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118807/testReport)** for PR 27657 at commit [`689722a`](https://github.com/apache/spark/commit/689722afbb426fa42ae7370e1cd5e59006ef2b4b). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] wangyum commented on issue #27654: [SPARK-30904][SQL] Thrift RowBasedSet serialization throws NullPointerException on NULL BigDecimal
wangyum commented on issue #27654: [SPARK-30904][SQL] Thrift RowBasedSet serialization throws NullPointerException on NULL BigDecimal URL: https://github.com/apache/spark/pull/27654#issuecomment-589918021 Merged to master and branch-3.0. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] wangyum closed pull request #27654: [SPARK-30904][SQL] Thrift RowBasedSet serialization throws NullPointerException on NULL BigDecimal
wangyum closed pull request #27654: [SPARK-30904][SQL] Thrift RowBasedSet serialization throws NullPointerException on NULL BigDecimal URL: https://github.com/apache/spark/pull/27654 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] turboFei edited a comment on issue #27150: [SPARK-30471][SQL] Fix issue when comparing String and IntegerType
turboFei edited a comment on issue #27150: [SPARK-30471][SQL] Fix issue when comparing String and IntegerType URL: https://github.com/apache/spark/pull/27150#issuecomment-589916541 1. Spark allows cast like "2.34" to Long/Int before. 2. If we cast String to Long when comparing String and Integer, we need throw NumberFormatException when this String is invalid. 3. Without ansi enabled, select 2.3 = "2.34" would return true if we cast String to Decimal when comparing String and decimal. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] turboFei edited a comment on issue #27150: [SPARK-30471][SQL] Fix issue when comparing String and IntegerType
turboFei edited a comment on issue #27150: [SPARK-30471][SQL] Fix issue when comparing String and IntegerType URL: https://github.com/apache/spark/pull/27150#issuecomment-589916541 1. Spark allows cast like "2.34" to Long/Int before. 2. If we cast String to Long when comparing String and Integer, we need throw NumberFormatException when this String is invalid. 3. Without ansi enabled, `select 2.3 = '2.34'` would return true if we cast String to Decimal when comparing String and decimal. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] beliefer edited a comment on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
beliefer edited a comment on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy URL: https://github.com/apache/spark/pull/27668#issuecomment-589915646 @HyukjinKwon `spark.deploy.recoveryMode.factory` appears in branch-1.3, but the version number in the `pom.xml` file corresponding to the commit is 1.2.0-SNAPSHOT. Is the since version of this configuration 1.2.0 or 1.3.0? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] turboFei commented on issue #27150: [SPARK-30471][SQL] Fix issue when comparing String and IntegerType
turboFei commented on issue #27150: [SPARK-30471][SQL] Fix issue when comparing String and IntegerType URL: https://github.com/apache/spark/pull/27150#issuecomment-589916541 1. Spark allows cast like "2.34" to Long/Int before. 2. If we cast String to Long when comparing String and Integer, we need throw NumberFormatException when this String is invalid. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27150: [SPARK-30471][SQL] Fix issue when comparing String and IntegerType
AmplabJenkins removed a comment on issue #27150: [SPARK-30471][SQL] Fix issue when comparing String and IntegerType URL: https://github.com/apache/spark/pull/27150#issuecomment-589916298 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23562/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27150: [SPARK-30471][SQL] Fix issue when comparing String and IntegerType
AmplabJenkins removed a comment on issue #27150: [SPARK-30471][SQL] Fix issue when comparing String and IntegerType URL: https://github.com/apache/spark/pull/27150#issuecomment-589916296 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27150: [SPARK-30471][SQL] Fix issue when comparing String and IntegerType
AmplabJenkins commented on issue #27150: [SPARK-30471][SQL] Fix issue when comparing String and IntegerType URL: https://github.com/apache/spark/pull/27150#issuecomment-589916296 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27150: [SPARK-30471][SQL] Fix issue when comparing String and IntegerType
AmplabJenkins commented on issue #27150: [SPARK-30471][SQL] Fix issue when comparing String and IntegerType URL: https://github.com/apache/spark/pull/27150#issuecomment-589916298 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23562/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27150: [SPARK-30471][SQL] Fix issue when comparing String and IntegerType
SparkQA commented on issue #27150: [SPARK-30471][SQL] Fix issue when comparing String and IntegerType URL: https://github.com/apache/spark/pull/27150#issuecomment-589916199 **[Test build #118812 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118812/testReport)** for PR 27150 at commit [`cf6d9ec`](https://github.com/apache/spark/commit/cf6d9ec9c97454a22c02229bb338ef0789b1593f). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
AmplabJenkins removed a comment on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy URL: https://github.com/apache/spark/pull/27668#issuecomment-589915815 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
AmplabJenkins commented on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy URL: https://github.com/apache/spark/pull/27668#issuecomment-589915815 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
AmplabJenkins removed a comment on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy URL: https://github.com/apache/spark/pull/27668#issuecomment-589915816 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23561/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
AmplabJenkins commented on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy URL: https://github.com/apache/spark/pull/27668#issuecomment-589915816 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23561/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
SparkQA commented on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy URL: https://github.com/apache/spark/pull/27668#issuecomment-589915746 **[Test build #118811 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118811/testReport)** for PR 27668 at commit [`bd6416b`](https://github.com/apache/spark/commit/bd6416b4b015c5f9fd81f6ff4ccf838536bbfb9c). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] beliefer commented on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
beliefer commented on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy URL: https://github.com/apache/spark/pull/27668#issuecomment-589915646 @HyukjinKwon `spark.deploy.recoveryMode.factory` appears in branch-1.3, but the version number in the pom.xml file corresponding to the commit is 1.2.0-SNAPSHOT. Is the since version of this configuration 1.2.0 or 1.3.0? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
AmplabJenkins removed a comment on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy URL: https://github.com/apache/spark/pull/27668#issuecomment-589912374 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118806/ Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
AmplabJenkins removed a comment on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy URL: https://github.com/apache/spark/pull/27668#issuecomment-589913656 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27654: [SPARK-30904][SQL][test-hive1.2] Thrift RowBasedSet serialization throws NullPointerException on NULL BigDecimal
SparkQA removed a comment on issue #27654: [SPARK-30904][SQL][test-hive1.2] Thrift RowBasedSet serialization throws NullPointerException on NULL BigDecimal URL: https://github.com/apache/spark/pull/27654#issuecomment-589908537 **[Test build #118809 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118809/testReport)** for PR 27654 at commit [`5442bf7`](https://github.com/apache/spark/commit/5442bf73032abfe46308e1e88e84eba9d259aeb2). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
AmplabJenkins removed a comment on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy URL: https://github.com/apache/spark/pull/27668#issuecomment-589913660 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23560/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27654: [SPARK-30904][SQL][test-hive1.2] Thrift RowBasedSet serialization throws NullPointerException on NULL BigDecimal
AmplabJenkins removed a comment on issue #27654: [SPARK-30904][SQL][test-hive1.2] Thrift RowBasedSet serialization throws NullPointerException on NULL BigDecimal URL: https://github.com/apache/spark/pull/27654#issuecomment-589911289 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118809/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
AmplabJenkins removed a comment on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy URL: https://github.com/apache/spark/pull/27668#issuecomment-589912369 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27654: [SPARK-30904][SQL][test-hive1.2] Thrift RowBasedSet serialization throws NullPointerException on NULL BigDecimal
AmplabJenkins removed a comment on issue #27654: [SPARK-30904][SQL][test-hive1.2] Thrift RowBasedSet serialization throws NullPointerException on NULL BigDecimal URL: https://github.com/apache/spark/pull/27654#issuecomment-589911286 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
SparkQA removed a comment on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy URL: https://github.com/apache/spark/pull/27668#issuecomment-589897852 **[Test build #118806 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118806/testReport)** for PR 27668 at commit [`4e7ff54`](https://github.com/apache/spark/commit/4e7ff542c6398ad24bd5761a90341a04d3bfcdb0). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
AmplabJenkins commented on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy URL: https://github.com/apache/spark/pull/27668#issuecomment-589913660 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23560/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
AmplabJenkins commented on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy URL: https://github.com/apache/spark/pull/27668#issuecomment-589913656 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
SparkQA commented on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy URL: https://github.com/apache/spark/pull/27668#issuecomment-589913547 **[Test build #118810 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118810/testReport)** for PR 27668 at commit [`ee3cdd2`](https://github.com/apache/spark/commit/ee3cdd27c1e05a10dc851f6e6ef8252b6395bd39). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] samsetegne commented on issue #27567: [SPARK-30822][SQL] Remove semicolon at the end of a sql query
samsetegne commented on issue #27567: [SPARK-30822][SQL] Remove semicolon at the end of a sql query URL: https://github.com/apache/spark/pull/27567#issuecomment-589912823 @dongjoon-hyun sure thing! I'll update the PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
AmplabJenkins commented on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy URL: https://github.com/apache/spark/pull/27668#issuecomment-589912369 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
AmplabJenkins commented on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy URL: https://github.com/apache/spark/pull/27668#issuecomment-589912374 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118806/ Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
SparkQA commented on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy URL: https://github.com/apache/spark/pull/27668#issuecomment-589912272 **[Test build #118806 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118806/testReport)** for PR 27668 at commit [`4e7ff54`](https://github.com/apache/spark/commit/4e7ff542c6398ad24bd5761a90341a04d3bfcdb0). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] maryannxue commented on a change in pull request #27669: [SPARK-30918][SQL] improve the splitting of skewed partitions
maryannxue commented on a change in pull request #27669: [SPARK-30918][SQL]
improve the splitting of skewed partitions
URL: https://github.com/apache/spark/pull/27669#discussion_r382881205
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##
@@ -445,6 +445,7 @@ object SQLConf {
" this factor multiple the median partition size and also larger than
" +
s" ${ADAPTIVE_EXECUTION_SKEWED_PARTITION_SIZE_THRESHOLD.key}")
.intConf
+ .checkValue(_ > 0, "The skew factor must be positive.")
Review comment:
We are using
https://github.com/apache/spark/pull/27669/files#diff-2d6bea6eed43ca6f37fe3531cb574069R93
now, as we are trying to make the same target partition size for both
coalesced non-skew partitions and skew partitions after split if the avg
non-skew size is small.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27654: [SPARK-30904][SQL][test-hive1.2] Thrift RowBasedSet serialization throws NullPointerException on NULL BigDecimal
AmplabJenkins commented on issue #27654: [SPARK-30904][SQL][test-hive1.2] Thrift RowBasedSet serialization throws NullPointerException on NULL BigDecimal URL: https://github.com/apache/spark/pull/27654#issuecomment-589911289 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118809/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27654: [SPARK-30904][SQL][test-hive1.2] Thrift RowBasedSet serialization throws NullPointerException on NULL BigDecimal
AmplabJenkins commented on issue #27654: [SPARK-30904][SQL][test-hive1.2] Thrift RowBasedSet serialization throws NullPointerException on NULL BigDecimal URL: https://github.com/apache/spark/pull/27654#issuecomment-589911286 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27654: [SPARK-30904][SQL][test-hive1.2] Thrift RowBasedSet serialization throws NullPointerException on NULL BigDecimal
SparkQA commented on issue #27654: [SPARK-30904][SQL][test-hive1.2] Thrift RowBasedSet serialization throws NullPointerException on NULL BigDecimal URL: https://github.com/apache/spark/pull/27654#issuecomment-589911256 **[Test build #118809 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118809/testReport)** for PR 27654 at commit [`5442bf7`](https://github.com/apache/spark/commit/5442bf73032abfe46308e1e88e84eba9d259aeb2). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27654: [SPARK-30904][SQL][test-hive1.2] Thrift RowBasedSet serialization throws NullPointerException on NULL BigDecimal
AmplabJenkins removed a comment on issue #27654: [SPARK-30904][SQL][test-hive1.2] Thrift RowBasedSet serialization throws NullPointerException on NULL BigDecimal URL: https://github.com/apache/spark/pull/27654#issuecomment-589908631 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27673: [SPARK-30922] [SQL] remove the max splits config in skewed join
AmplabJenkins removed a comment on issue #27673: [SPARK-30922] [SQL] remove the max splits config in skewed join URL: https://github.com/apache/spark/pull/27673#issuecomment-589908638 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23558/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27654: [SPARK-30904][SQL][test-hive1.2] Thrift RowBasedSet serialization throws NullPointerException on NULL BigDecimal
AmplabJenkins removed a comment on issue #27654: [SPARK-30904][SQL][test-hive1.2] Thrift RowBasedSet serialization throws NullPointerException on NULL BigDecimal URL: https://github.com/apache/spark/pull/27654#issuecomment-589908635 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23559/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27673: [SPARK-30922] [SQL] remove the max splits config in skewed join
AmplabJenkins removed a comment on issue #27673: [SPARK-30922] [SQL] remove the max splits config in skewed join URL: https://github.com/apache/spark/pull/27673#issuecomment-589908637 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27673: [SPARK-30922] [SQL] remove the max splits config in skewed join
AmplabJenkins commented on issue #27673: [SPARK-30922] [SQL] remove the max splits config in skewed join URL: https://github.com/apache/spark/pull/27673#issuecomment-589908637 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27654: [SPARK-30904][SQL][test-hive1.2] Thrift RowBasedSet serialization throws NullPointerException on NULL BigDecimal
AmplabJenkins commented on issue #27654: [SPARK-30904][SQL][test-hive1.2] Thrift RowBasedSet serialization throws NullPointerException on NULL BigDecimal URL: https://github.com/apache/spark/pull/27654#issuecomment-589908635 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23559/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27654: [SPARK-30904][SQL][test-hive1.2] Thrift RowBasedSet serialization throws NullPointerException on NULL BigDecimal
AmplabJenkins commented on issue #27654: [SPARK-30904][SQL][test-hive1.2] Thrift RowBasedSet serialization throws NullPointerException on NULL BigDecimal URL: https://github.com/apache/spark/pull/27654#issuecomment-589908631 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27673: [SPARK-30922] [SQL] remove the max splits config in skewed join
AmplabJenkins commented on issue #27673: [SPARK-30922] [SQL] remove the max splits config in skewed join URL: https://github.com/apache/spark/pull/27673#issuecomment-589908638 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23558/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27673: [SPARK-30922] [SQL] remove the max splits config in skewed join
SparkQA commented on issue #27673: [SPARK-30922] [SQL] remove the max splits config in skewed join URL: https://github.com/apache/spark/pull/27673#issuecomment-589908532 **[Test build #118808 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118808/testReport)** for PR 27673 at commit [`8bbfe24`](https://github.com/apache/spark/commit/8bbfe24d8265c1d7af6553c865dd72b87339d827). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27654: [SPARK-30904][SQL][test-hive1.2] Thrift RowBasedSet serialization throws NullPointerException on NULL BigDecimal
SparkQA commented on issue #27654: [SPARK-30904][SQL][test-hive1.2] Thrift RowBasedSet serialization throws NullPointerException on NULL BigDecimal URL: https://github.com/apache/spark/pull/27654#issuecomment-589908537 **[Test build #118809 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118809/testReport)** for PR 27654 at commit [`5442bf7`](https://github.com/apache/spark/commit/5442bf73032abfe46308e1e88e84eba9d259aeb2). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] JkSelf commented on a change in pull request #27669: [SPARK-30918][SQL] improve the splitting of skewed partitions
JkSelf commented on a change in pull request #27669: [SPARK-30918][SQL] improve
the splitting of skewed partitions
URL: https://github.com/apache/spark/pull/27669#discussion_r382878634
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/OptimizeSkewedJoin.scala
##
@@ -72,14 +108,16 @@ case class OptimizeSkewedJoin(conf: SQLConf) extends
Rule[SparkPlan] {
/**
* Split the skewed partition based on the map size and the max split number.
*/
- private def getMapStartIndices(stage: ShuffleQueryStageExec, partitionId:
Int): Array[Int] = {
+ private def getMapStartIndices(
+ stage: ShuffleQueryStageExec,
+ partitionId: Int,
+ targetSize: Long): Array[Int] = {
val shuffleId = stage.shuffle.shuffleDependency.shuffleHandle.shuffleId
val mapPartitionSizes = getMapSizesForReduceId(shuffleId, partitionId)
val maxSplits = math.min(conf.getConf(
SQLConf.ADAPTIVE_EXECUTION_SKEWED_PARTITION_MAX_SPLITS),
mapPartitionSizes.length)
val avgPartitionSize = mapPartitionSizes.sum / maxSplits
-val advisoryPartitionSize = math.max(avgPartitionSize,
Review comment:
remove the max splits in
[PR#27673](https://github.com/apache/spark/pull/27673)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] JkSelf commented on a change in pull request #27669: [SPARK-30918][SQL] improve the splitting of skewed partitions
JkSelf commented on a change in pull request #27669: [SPARK-30918][SQL] improve
the splitting of skewed partitions
URL: https://github.com/apache/spark/pull/27669#discussion_r382878571
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##
@@ -445,6 +445,7 @@ object SQLConf {
" this factor multiple the median partition size and also larger than
" +
s" ${ADAPTIVE_EXECUTION_SKEWED_PARTITION_SIZE_THRESHOLD.key}")
.intConf
+ .checkValue(_ > 0, "The skew factor must be positive.")
Review comment:
When the `nonSkewSizes ` is very small. The `targetSize ` will be small
without this config. Then it will split more small task when handling skewed
partition? So we may need this config.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] wangyum commented on issue #27654: [SPARK-30904][SQL][test-hive1.2] Thrift RowBasedSet serialization throws NullPointerException on NULL BigDecimal
wangyum commented on issue #27654: [SPARK-30904][SQL][test-hive1.2] Thrift RowBasedSet serialization throws NullPointerException on NULL BigDecimal URL: https://github.com/apache/spark/pull/27654#issuecomment-589908429 retest this please. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] JkSelf commented on issue #27673: [SPARK-30922] [SQL] remove the max splits config in skewed join
JkSelf commented on issue #27673: [SPARK-30922] [SQL] remove the max splits config in skewed join URL: https://github.com/apache/spark/pull/27673#issuecomment-589908396 @cloud-fan @maryannxue This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] JkSelf opened a new pull request #27673: [SPARK-30922] [SQL] remove the max splits config in skewed join
JkSelf opened a new pull request #27673: [SPARK-30922] [SQL] remove the max splits config in skewed join URL: https://github.com/apache/spark/pull/27673 ### What changes were proposed in this pull request? When skewed join optimization split more skewed readers, the plan may be very large and can not be shown in ui quickly. The config `spark.sql.adaptive.skewedJoinOptimization.skewedPartitionMaxSplits` is to resolve the above ui shown issue. And after [PR#27493](https://github.com/apache/spark/pull/27493) combined the skewed readers into one, we not need this config. ### Why are the changes needed? remove the unnecessary config ### Does this PR introduce any user-facing change? No ### How was this patch tested? existing test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
beliefer commented on a change in pull request #27668: [SPARK-30887][CORE][DOC]
Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#discussion_r382876122
##
File path: core/src/main/scala/org/apache/spark/internal/config/Deploy.scala
##
@@ -19,48 +19,59 @@ package org.apache.spark.internal.config
private[spark] object Deploy {
val RECOVERY_MODE = ConfigBuilder("spark.deploy.recoveryMode")
+.version("0.8.1")
Review comment:
OK
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
HyukjinKwon commented on a change in pull request #27668:
[SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#discussion_r382874015
##
File path: core/src/main/scala/org/apache/spark/internal/config/Deploy.scala
##
@@ -19,48 +19,59 @@ package org.apache.spark.internal.config
private[spark] object Deploy {
val RECOVERY_MODE = ConfigBuilder("spark.deploy.recoveryMode")
+.version("0.8.1")
Review comment:
yeah just commit url or hash anything is fine.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] yuchenhuo commented on a change in pull request #27642: [SPARK-30885][SQL] V1 table name should be fully qualified if catalog name is provided
yuchenhuo commented on a change in pull request #27642: [SPARK-30885][SQL] V1
table name should be fully qualified if catalog name is provided
URL: https://github.com/apache/spark/pull/27642#discussion_r382865667
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveSessionCatalog.scala
##
@@ -449,8 +454,17 @@ class ResolveSessionCatalog(
partitionSpec)
case ShowColumnsStatement(tbl, ns) =>
+ if (ns.isDefined && ns.get.length > 1) {
+throw new AnalysisException(
+ s"Namespace name should have only one part if specified:
${ns.get.quoted}")
+ }
+ val nameParts = if (ns.isDefined && tbl.length == 1) {
Review comment:
Can we perhaps add a comment here why this `tbl.length == 1` is necessary?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] yuchenhuo commented on a change in pull request #27642: [SPARK-30885][SQL] V1 table name should be fully qualified if catalog name is provided
yuchenhuo commented on a change in pull request #27642: [SPARK-30885][SQL] V1 table name should be fully qualified if catalog name is provided URL: https://github.com/apache/spark/pull/27642#discussion_r382866793 ## File path: sql/core/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveSessionCatalog.scala ## @@ -396,7 +397,7 @@ class ResolveSessionCatalog( } case AnalyzeColumnStatement(tbl, columnNames, allColumns) => - val v1TableName = parseV1Table(tbl, "ANALYZE TABLE") + val v1TableName = parseTempViewOrV1Table(tbl, "ANALYZE TABLE") Review comment: Just want to check if I understand this correctly. This reason why we need to make this change is that `parseV1Table` would accidentally add currentName as the namespace for a temp view which is incorrect because temp view shouldn't have a namespace? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] beliefer commented on issue #27592: [SPARK-30840][CORE][SQL] Add version property for ConfigEntry and ConfigBuilder
beliefer commented on issue #27592: [SPARK-30840][CORE][SQL] Add version property for ConfigEntry and ConfigBuilder URL: https://github.com/apache/spark/pull/27592#issuecomment-589899591 @HyukjinKwon @maropu @cloud-fan @Ngone51 @dongjoon-hyun @gatorsmile @jiangxb1987 @HeartSaVioR Thanks for all your help! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
beliefer commented on a change in pull request #27668: [SPARK-30887][CORE][DOC]
Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#discussion_r382870232
##
File path: core/src/main/scala/org/apache/spark/internal/config/Deploy.scala
##
@@ -19,48 +19,59 @@ package org.apache.spark.internal.config
private[spark] object Deploy {
val RECOVERY_MODE = ConfigBuilder("spark.deploy.recoveryMode")
+.version("0.8.1")
Review comment:
OK. But commit log is too long. Can I just add the URL corresponding to the
commit?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get
AmplabJenkins removed a comment on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get URL: https://github.com/apache/spark/pull/27657#issuecomment-589898014 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23557/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
AmplabJenkins removed a comment on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy URL: https://github.com/apache/spark/pull/27668#issuecomment-589898021 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23556/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
AmplabJenkins removed a comment on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy URL: https://github.com/apache/spark/pull/27668#issuecomment-589898015 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
HyukjinKwon commented on a change in pull request #27668:
[SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#discussion_r382869792
##
File path: core/src/main/scala/org/apache/spark/internal/config/Deploy.scala
##
@@ -19,48 +19,59 @@ package org.apache.spark.internal.config
private[spark] object Deploy {
val RECOVERY_MODE = ConfigBuilder("spark.deploy.recoveryMode")
+.version("0.8.1")
Review comment:
You can show the commit log too. That should deduplicate the review overhead
because probably reviewers should do exactly the same thing as you did to
verify :-).
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get
AmplabJenkins removed a comment on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get URL: https://github.com/apache/spark/pull/27657#issuecomment-589898013 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27668: [WIP][SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
beliefer commented on a change in pull request #27668:
[WIP][SPARK-30887][CORE][DOC] Add version information to the configuration of
Deploy
URL: https://github.com/apache/spark/pull/27668#discussion_r382869658
##
File path: core/src/main/scala/org/apache/spark/internal/config/Deploy.scala
##
@@ -19,48 +19,59 @@ package org.apache.spark.internal.config
private[spark] object Deploy {
val RECOVERY_MODE = ConfigBuilder("spark.deploy.recoveryMode")
+.version("0.8.1")
Review comment:
Many early commits did not have a jira ID.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27668: [WIP][SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
AmplabJenkins commented on issue #27668: [WIP][SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy URL: https://github.com/apache/spark/pull/27668#issuecomment-589898021 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23556/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get
AmplabJenkins commented on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get URL: https://github.com/apache/spark/pull/27657#issuecomment-589898013 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get
AmplabJenkins commented on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get URL: https://github.com/apache/spark/pull/27657#issuecomment-589898014 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23557/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27668: [WIP][SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
AmplabJenkins commented on issue #27668: [WIP][SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy URL: https://github.com/apache/spark/pull/27668#issuecomment-589898015 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27668: [WIP][SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
beliefer commented on a change in pull request #27668:
[WIP][SPARK-30887][CORE][DOC] Add version information to the configuration of
Deploy
URL: https://github.com/apache/spark/pull/27668#discussion_r382869658
##
File path: core/src/main/scala/org/apache/spark/internal/config/Deploy.scala
##
@@ -19,48 +19,59 @@ package org.apache.spark.internal.config
private[spark] object Deploy {
val RECOVERY_MODE = ConfigBuilder("spark.deploy.recoveryMode")
+.version("0.8.1")
Review comment:
Many early commits did not have a JIRA ID.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get
SparkQA commented on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get URL: https://github.com/apache/spark/pull/27657#issuecomment-589897858 **[Test build #118807 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118807/testReport)** for PR 27657 at commit [`689722a`](https://github.com/apache/spark/commit/689722afbb426fa42ae7370e1cd5e59006ef2b4b). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
