[GitHub] [spark] MaxGekk commented on pull request #28531: [SPARK-31712][SQL][TESTS] Check casting timestamps before the epoch to Byte/Short/Int/Long types

2020-05-14 Thread GitBox
MaxGekk commented on pull request #28531: URL: https://github.com/apache/spark/pull/28531#issuecomment-629066132 @cloud-fan @rednaxelafx @hvanhovell @gatorsmile @HyukjinKwon I would like to propose to backport the test to 2.4 too, if you don't mind. ---

[GitHub] [spark] dongjoon-hyun edited a comment on pull request #28536: [SPARK-31716][SQL] Use fallback versions in HiveExternalCatalogVersionsSuite

2020-05-14 Thread GitBox
dongjoon-hyun edited a comment on pull request #28536: URL: https://github.com/apache/spark/pull/28536#issuecomment-629065007 The real download is okay. As you see on the result, the download logic have a fallback logic. The network issue happens differently on the URL, @viirya and @cloud-

[GitHub] [spark] dongjoon-hyun edited a comment on pull request #28536: [SPARK-31716][SQL] Use fallback versions in HiveExternalCatalogVersionsSuite

2020-05-14 Thread GitBox
dongjoon-hyun edited a comment on pull request #28536: URL: https://github.com/apache/spark/pull/28536#issuecomment-629065007 The real download is okay. As you see on the result, the download logic have a fallback logic. The network issue happens differently on the URL, @viirya and @cloud-

[GitHub] [spark] dongjoon-hyun commented on pull request #28536: [SPARK-31716][SQL] Use fallback versions in HiveExternalCatalogVersionsSuite

2020-05-14 Thread GitBox
dongjoon-hyun commented on pull request #28536: URL: https://github.com/apache/spark/pull/28536#issuecomment-629065007 As you see on the result, the download logic have a fallback logic. The network issue happens differently, @viirya and @cloud-fan . --

[GitHub] [spark] cloud-fan commented on pull request #28523: [SPARK-31706][SQL] add back the support of streaming update mode

2020-05-14 Thread GitBox
cloud-fan commented on pull request #28523: URL: https://github.com/apache/spark/pull/28523#issuecomment-629062885 Thanks for the good discussion! It will be great if you can create a JIRA ticket for the better output mode design and put the insights there. This PR is just to keep th

[GitHub] [spark] HeartSaVioR commented on pull request #28537: [SPARK-31715][SQL][TEST] Fix flaky SparkSQLEnvSuite that sometimes varies single derby instance standard

2020-05-14 Thread GitBox
HeartSaVioR commented on pull request #28537: URL: https://github.com/apache/spark/pull/28537#issuecomment-629062997 Late +1. This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] HeartSaVioR edited a comment on pull request #28537: [SPARK-31715][SQL][TEST] Fix flaky SparkSQLEnvSuite that sometimes varies single derby instance standard

2020-05-14 Thread GitBox
HeartSaVioR edited a comment on pull request #28537: URL: https://github.com/apache/spark/pull/28537#issuecomment-629062997 Late LGTM. This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [spark] cloud-fan closed pull request #28537: [SPARK-31715][SQL][TEST] Fix flaky SparkSQLEnvSuite that sometimes varies single derby instance standard

2020-05-14 Thread GitBox
cloud-fan closed pull request #28537: URL: https://github.com/apache/spark/pull/28537 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [spark] cloud-fan commented on pull request #28537: [SPARK-31715][SQL][TEST] Fix flaky SparkSQLEnvSuite that sometimes varies single derby instance standard

2020-05-14 Thread GitBox
cloud-fan commented on pull request #28537: URL: https://github.com/apache/spark/pull/28537#issuecomment-629057400 thanks, merging to master/3.0! This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [spark] cloud-fan commented on pull request #28536: [SPARK-31716][SQL] Use fallback versions in HiveExternalCatalogVersionsSuite

2020-05-14 Thread GitBox
cloud-fan commented on pull request #28536: URL: https://github.com/apache/spark/pull/28536#issuecomment-629056740 same question with @viirya This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [spark] AngersZhuuuu commented on pull request #27983: [SPARK-15694][SQL]Implement ScriptTransformation in sql/core

2020-05-14 Thread GitBox
AngersZh commented on pull request #27983: URL: https://github.com/apache/spark/pull/27983#issuecomment-629053898 > **[Test build #122637 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122637/testReport)** for PR 27983 at commit [`aea128b`](https://gi

[GitHub] [spark] AmplabJenkins removed a comment on pull request #27983: [SPARK-15694][SQL]Implement ScriptTransformation in sql/core

2020-05-14 Thread GitBox
AmplabJenkins removed a comment on pull request #27983: URL: https://github.com/apache/spark/pull/27983#issuecomment-629052114 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/122

[GitHub] [spark] AmplabJenkins commented on pull request #27983: [SPARK-15694][SQL]Implement ScriptTransformation in sql/core

2020-05-14 Thread GitBox
AmplabJenkins commented on pull request #27983: URL: https://github.com/apache/spark/pull/27983#issuecomment-629052107 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #27983: [SPARK-15694][SQL]Implement ScriptTransformation in sql/core

2020-05-14 Thread GitBox
AmplabJenkins removed a comment on pull request #27983: URL: https://github.com/apache/spark/pull/27983#issuecomment-629052107 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] SparkQA removed a comment on pull request #27983: [SPARK-15694][SQL]Implement ScriptTransformation in sql/core

2020-05-14 Thread GitBox
SparkQA removed a comment on pull request #27983: URL: https://github.com/apache/spark/pull/27983#issuecomment-628981046 **[Test build #122637 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122637/testReport)** for PR 27983 at commit [`aea128b`](https://gi

[GitHub] [spark] AmplabJenkins commented on pull request #28537: [SPARK-31715][SQL][TEST] Fix flaky SparkSQLEnvSuite that sometimes varies single derby instance standard

2020-05-14 Thread GitBox
AmplabJenkins commented on pull request #28537: URL: https://github.com/apache/spark/pull/28537#issuecomment-629051617 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #27983: [SPARK-15694][SQL]Implement ScriptTransformation in sql/core

2020-05-14 Thread GitBox
SparkQA commented on pull request #27983: URL: https://github.com/apache/spark/pull/27983#issuecomment-629051646 **[Test build #122637 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122637/testReport)** for PR 27983 at commit [`aea128b`](https://github.co

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28537: [SPARK-31715][SQL][TEST] Fix flaky SparkSQLEnvSuite that sometimes varies single derby instance standard

2020-05-14 Thread GitBox
AmplabJenkins removed a comment on pull request #28537: URL: https://github.com/apache/spark/pull/28537#issuecomment-629051617 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA removed a comment on pull request #28537: [SPARK-31715][SQL][TEST] Fix flaky SparkSQLEnvSuite that sometimes varies single derby instance standard

2020-05-14 Thread GitBox
SparkQA removed a comment on pull request #28537: URL: https://github.com/apache/spark/pull/28537#issuecomment-629038184 **[Test build #122653 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122653/testReport)** for PR 28537 at commit [`97597ac`](https://gi

[GitHub] [spark] SparkQA commented on pull request #28537: [SPARK-31715][SQL][TEST] Fix flaky SparkSQLEnvSuite that sometimes varies single derby instance standard

2020-05-14 Thread GitBox
SparkQA commented on pull request #28537: URL: https://github.com/apache/spark/pull/28537#issuecomment-629051322 **[Test build #122653 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122653/testReport)** for PR 28537 at commit [`97597ac`](https://github.co

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28506: [SPARK-31655][BUILD][2.4] Upgrade snappy-java to 1.1.7.5

2020-05-14 Thread GitBox
AmplabJenkins removed a comment on pull request #28506: URL: https://github.com/apache/spark/pull/28506#issuecomment-629048693 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28506: [SPARK-31655][BUILD][2.4] Upgrade snappy-java to 1.1.7.5

2020-05-14 Thread GitBox
AmplabJenkins commented on pull request #28506: URL: https://github.com/apache/spark/pull/28506#issuecomment-629048693 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #28506: [SPARK-31655][BUILD][2.4] Upgrade snappy-java to 1.1.7.5

2020-05-14 Thread GitBox
SparkQA commented on pull request #28506: URL: https://github.com/apache/spark/pull/28506#issuecomment-629048254 **[Test build #122654 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122654/testReport)** for PR 28506 at commit [`42f0c98`](https://github.com

[GitHub] [spark] AngersZhuuuu commented on pull request #27983: [SPARK-15694][SQL]Implement ScriptTransformation in sql/core

2020-05-14 Thread GitBox
AngersZh commented on pull request #27983: URL: https://github.com/apache/spark/pull/27983#issuecomment-629048503 cc @cloud-fan Can you take a look? This is an automated message from the Apache Git Service. To respond to

[GitHub] [spark] iRakson commented on pull request #28512: [SPARK-31688][WEBUI] Refactor Pagination framework

2020-05-14 Thread GitBox
iRakson commented on pull request #28512: URL: https://github.com/apache/spark/pull/28512#issuecomment-629047922 retest this please This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [spark] AngersZhuuuu commented on pull request #28506: [SPARK-31655][BUILD][2.4] Upgrade snappy-java to 1.1.7.5

2020-05-14 Thread GitBox
AngersZh commented on pull request #28506: URL: https://github.com/apache/spark/pull/28506#issuecomment-629047289 Retest this please This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [spark] dongjoon-hyun commented on pull request #28536: [SPARK-31716][SQL] Use a fallback version in HiveExternalCatalogVersionsSuite

2020-05-14 Thread GitBox
dongjoon-hyun commented on pull request #28536: URL: https://github.com/apache/spark/pull/28536#issuecomment-629044913 Hi, @cloud-fan and @HyukjinKwon . Could you review this PR? This PR is providing a fallback Spark versions instead of failing. AFAIK, this is the only way to recover our

[GitHub] [spark] xccui commented on pull request #28523: [SPARK-31706][SQL] add back the support of streaming update mode

2020-05-14 Thread GitBox
xccui commented on pull request #28523: URL: https://github.com/apache/spark/pull/28523#issuecomment-629043813 @HeartSaVioR Yes. It seems the output mode option was mainly designed for stateful aggregations, which means it actually works in a restricted way. Ideally, to support compl

[GitHub] [spark] yaooqinn commented on pull request #28537: [SPARK-31715][SQL][TEST] Fix flaky SparkSQLEnvSuite that sometimes varies single derby instance standard

2020-05-14 Thread GitBox
yaooqinn commented on pull request #28537: URL: https://github.com/apache/spark/pull/28537#issuecomment-629040211 cc @cloud-fan @HeartSaVioR thanks This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [spark] dongjoon-hyun commented on pull request #25870: [SPARK-27936][K8S] Support python deps

2020-05-14 Thread GitBox
dongjoon-hyun commented on pull request #25870: URL: https://github.com/apache/spark/pull/25870#issuecomment-629039005 It's still assigned to `amp-jenkins-worker-05`. This is an automated message from the Apache Git Service.

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28537: [SPARK-31715][SQL][TEST] Fix flaky SparkSQLEnvSuite that sometimes varies single derby instance standard

2020-05-14 Thread GitBox
AmplabJenkins removed a comment on pull request #28537: URL: https://github.com/apache/spark/pull/28537#issuecomment-629038579 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28537: [SPARK-31715][SQL][TEST] Fix flaky SparkSQLEnvSuite that sometimes varies single derby instance standard

2020-05-14 Thread GitBox
AmplabJenkins commented on pull request #28537: URL: https://github.com/apache/spark/pull/28537#issuecomment-629038579 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #28537: [SPARK-31715][SQL][TEST] Fix flaky SparkSQLEnvSuite that sometimes varies single derby instance standard

2020-05-14 Thread GitBox
SparkQA commented on pull request #28537: URL: https://github.com/apache/spark/pull/28537#issuecomment-629038184 **[Test build #122653 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122653/testReport)** for PR 28537 at commit [`97597ac`](https://github.com

[GitHub] [spark] AmplabJenkins removed a comment on pull request #25870: [SPARK-27936][K8S] Support python deps

2020-05-14 Thread GitBox
AmplabJenkins removed a comment on pull request #25870: URL: https://github.com/apache/spark/pull/25870#issuecomment-629036880 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/122

[GitHub] [spark] SparkQA commented on pull request #25870: [SPARK-27936][K8S] Support python deps

2020-05-14 Thread GitBox
SparkQA commented on pull request #25870: URL: https://github.com/apache/spark/pull/25870#issuecomment-629036862 **[Test build #122650 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122650/testReport)** for PR 25870 at commit [`a9f055b`](https://github.co

[GitHub] [spark] AmplabJenkins removed a comment on pull request #25870: [SPARK-27936][K8S] Support python deps

2020-05-14 Thread GitBox
AmplabJenkins removed a comment on pull request #25870: URL: https://github.com/apache/spark/pull/25870#issuecomment-629036875 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] SparkQA removed a comment on pull request #25870: [SPARK-27936][K8S] Support python deps

2020-05-14 Thread GitBox
SparkQA removed a comment on pull request #25870: URL: https://github.com/apache/spark/pull/25870#issuecomment-629033573 **[Test build #122650 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122650/testReport)** for PR 25870 at commit [`a9f055b`](https://gi

[GitHub] [spark] AmplabJenkins commented on pull request #25870: [SPARK-27936][K8S] Support python deps

2020-05-14 Thread GitBox
AmplabJenkins commented on pull request #25870: URL: https://github.com/apache/spark/pull/25870#issuecomment-629036875 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28528: [SPARK-31711][CORE] Register the executor source with the metrics system when running in local mode.

2020-05-14 Thread GitBox
AmplabJenkins removed a comment on pull request #28528: URL: https://github.com/apache/spark/pull/28528#issuecomment-629036335 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28509: [SPARK-31655][BUILD][3.0] Upgrade snappy-java to 1.1.7.5

2020-05-14 Thread GitBox
AmplabJenkins commented on pull request #28509: URL: https://github.com/apache/spark/pull/28509#issuecomment-629036386 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins commented on pull request #28528: [SPARK-31711][CORE] Register the executor source with the metrics system when running in local mode.

2020-05-14 Thread GitBox
AmplabJenkins commented on pull request #28528: URL: https://github.com/apache/spark/pull/28528#issuecomment-629036335 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28509: [SPARK-31655][BUILD][3.0] Upgrade snappy-java to 1.1.7.5

2020-05-14 Thread GitBox
AmplabJenkins removed a comment on pull request #28509: URL: https://github.com/apache/spark/pull/28509#issuecomment-629036386 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #28528: [SPARK-31711][CORE] Register the executor source with the metrics system when running in local mode.

2020-05-14 Thread GitBox
SparkQA commented on pull request #28528: URL: https://github.com/apache/spark/pull/28528#issuecomment-629035880 **[Test build #122651 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122651/testReport)** for PR 28528 at commit [`52c22ce`](https://github.com

[GitHub] [spark] dongjoon-hyun commented on pull request #28509: [SPARK-31655][BUILD][3.0] Upgrade snappy-java to 1.1.7.5

2020-05-14 Thread GitBox
dongjoon-hyun commented on pull request #28509: URL: https://github.com/apache/spark/pull/28509#issuecomment-629035653 Retest this please. This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [spark] SparkQA commented on pull request #28509: [SPARK-31655][BUILD][3.0] Upgrade snappy-java to 1.1.7.5

2020-05-14 Thread GitBox
SparkQA commented on pull request #28509: URL: https://github.com/apache/spark/pull/28509#issuecomment-629035863 **[Test build #122652 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122652/testReport)** for PR 28509 at commit [`692db6a`](https://github.com

[GitHub] [spark] dongjoon-hyun commented on pull request #28528: [SPARK-31711][CORE] Register the executor source with the metrics system when running in local mode.

2020-05-14 Thread GitBox
dongjoon-hyun commented on pull request #28528: URL: https://github.com/apache/spark/pull/28528#issuecomment-629035487 Retest this please. This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [spark] dongjoon-hyun edited a comment on pull request #28526: [SPARK-31405][SQL][3.0] Fail by default when reading/writing legacy datetime values from/to Parquet/Avro files

2020-05-14 Thread GitBox
dongjoon-hyun edited a comment on pull request #28526: URL: https://github.com/apache/spark/pull/28526#issuecomment-629034425 Ya. The failure jobs are on the same broken Jenkins machine, `amp-jenkins-worker-05`. And, the running jobs are on `amp-jenkins-worker-03` and `amp-jenkins-worke

[GitHub] [spark] dongjoon-hyun commented on pull request #28526: [SPARK-31405][SQL][3.0] Fail by default when reading/writing legacy datetime values from/to Parquet/Avro files

2020-05-14 Thread GitBox
dongjoon-hyun commented on pull request #28526: URL: https://github.com/apache/spark/pull/28526#issuecomment-629034425 Ya. The failure jobs are on the same broken Jenkins machine, `amp-jenkins-worker-05`. This is an automate

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28517: [SPARK-31707][SQL] Revert SPARK-30098 Use default datasource as provider for CREATE TABLE syntax

2020-05-14 Thread GitBox
AmplabJenkins removed a comment on pull request #28517: URL: https://github.com/apache/spark/pull/28517#issuecomment-629033855 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28517: [SPARK-31707][SQL] Revert SPARK-30098 Use default datasource as provider for CREATE TABLE syntax

2020-05-14 Thread GitBox
AmplabJenkins commented on pull request #28517: URL: https://github.com/apache/spark/pull/28517#issuecomment-629033855 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #25870: [SPARK-27936][K8S] Support python deps

2020-05-14 Thread GitBox
SparkQA commented on pull request #25870: URL: https://github.com/apache/spark/pull/25870#issuecomment-629033573 **[Test build #122650 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122650/testReport)** for PR 25870 at commit [`a9f055b`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #28517: [SPARK-31707][SQL] Revert SPARK-30098 Use default datasource as provider for CREATE TABLE syntax

2020-05-14 Thread GitBox
SparkQA commented on pull request #28517: URL: https://github.com/apache/spark/pull/28517#issuecomment-629033574 **[Test build #122649 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122649/testReport)** for PR 28517 at commit [`84c172f`](https://github.com

[GitHub] [spark] HeartSaVioR commented on a change in pull request #28517: [SPARK-31707][SQL] Revert SPARK-30098 Use default datasource as provider for CREATE TABLE syntax

2020-05-14 Thread GitBox
HeartSaVioR commented on a change in pull request #28517: URL: https://github.com/apache/spark/pull/28517#discussion_r425571232 ## File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala ## @@ -2706,33 +2706,6 @@ class HiveDDLSuite } }

[GitHub] [spark] dongjoon-hyun commented on pull request #25870: [SPARK-27936][K8S] Support python deps

2020-05-14 Thread GitBox
dongjoon-hyun commented on pull request #25870: URL: https://github.com/apache/spark/pull/25870#issuecomment-629032842 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] xuanyuanking commented on a change in pull request #28501: [SPARK-31663][SQL] Grouping sets with having clause returns the wrong result

2020-05-14 Thread GitBox
xuanyuanking commented on a change in pull request #28501: URL: https://github.com/apache/spark/pull/28501#discussion_r425571365 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala ## @@ -629,12 +629,7 @@ class AstBuilder(conf: SQLCo

[GitHub] [spark] AmplabJenkins removed a comment on pull request #25870: [SPARK-27936][K8S] Support python deps

2020-05-14 Thread GitBox
AmplabJenkins removed a comment on pull request #25870: URL: https://github.com/apache/spark/pull/25870#issuecomment-629031989 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/122

[GitHub] [spark] SparkQA removed a comment on pull request #25870: [SPARK-27936][K8S] Support python deps

2020-05-14 Thread GitBox
SparkQA removed a comment on pull request #25870: URL: https://github.com/apache/spark/pull/25870#issuecomment-629028801 **[Test build #122647 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122647/testReport)** for PR 25870 at commit [`a9f055b`](https://gi

[GitHub] [spark] SparkQA commented on pull request #25870: [SPARK-27936][K8S] Support python deps

2020-05-14 Thread GitBox
SparkQA commented on pull request #25870: URL: https://github.com/apache/spark/pull/25870#issuecomment-629031965 **[Test build #122647 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122647/testReport)** for PR 25870 at commit [`a9f055b`](https://github.co

[GitHub] [spark] AmplabJenkins commented on pull request #25870: [SPARK-27936][K8S] Support python deps

2020-05-14 Thread GitBox
AmplabJenkins commented on pull request #25870: URL: https://github.com/apache/spark/pull/25870#issuecomment-629031981 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #25870: [SPARK-27936][K8S] Support python deps

2020-05-14 Thread GitBox
AmplabJenkins removed a comment on pull request #25870: URL: https://github.com/apache/spark/pull/25870#issuecomment-629031981 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] xuanyuanking commented on a change in pull request #28501: [SPARK-31663][SQL] Grouping sets with having clause returns the wrong result

2020-05-14 Thread GitBox
xuanyuanking commented on a change in pull request #28501: URL: https://github.com/apache/spark/pull/28501#discussion_r425570419 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -2163,22 +2235,29 @@ class Analyzer(

[GitHub] [spark] AmplabJenkins commented on pull request #28501: [SPARK-31663][SQL] Grouping sets with having clause returns the wrong result

2020-05-14 Thread GitBox
AmplabJenkins commented on pull request #28501: URL: https://github.com/apache/spark/pull/28501#issuecomment-629031566 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28501: [SPARK-31663][SQL] Grouping sets with having clause returns the wrong result

2020-05-14 Thread GitBox
AmplabJenkins removed a comment on pull request #28501: URL: https://github.com/apache/spark/pull/28501#issuecomment-629031566 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] xuanyuanking commented on a change in pull request #28501: [SPARK-31663][SQL] Grouping sets with having clause returns the wrong result

2020-05-14 Thread GitBox
xuanyuanking commented on a change in pull request #28501: URL: https://github.com/apache/spark/pull/28501#discussion_r425570468 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala ## @@ -540,11 +540,12 @@ case class UnresolvedOrdi

[GitHub] [spark] xuanyuanking commented on a change in pull request #28501: [SPARK-31663][SQL] Grouping sets with having clause returns the wrong result

2020-05-14 Thread GitBox
xuanyuanking commented on a change in pull request #28501: URL: https://github.com/apache/spark/pull/28501#discussion_r425570296 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -2125,13 +2196,14 @@ class Analyzer( co

[GitHub] [spark] xuanyuanking commented on a change in pull request #28501: [SPARK-31663][SQL] Grouping sets with having clause returns the wrong result

2020-05-14 Thread GitBox
xuanyuanking commented on a change in pull request #28501: URL: https://github.com/apache/spark/pull/28501#discussion_r425570127 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -595,8 +601,73 @@ class Analyzer( }

[GitHub] [spark] xuanyuanking commented on a change in pull request #28501: [SPARK-31663][SQL] Grouping sets with having clause returns the wrong result

2020-05-14 Thread GitBox
xuanyuanking commented on a change in pull request #28501: URL: https://github.com/apache/spark/pull/28501#discussion_r425569841 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -595,8 +601,73 @@ class Analyzer( }

[GitHub] [spark] SparkQA commented on pull request #28501: [SPARK-31663][SQL] Grouping sets with having clause returns the wrong result

2020-05-14 Thread GitBox
SparkQA commented on pull request #28501: URL: https://github.com/apache/spark/pull/28501#issuecomment-629031174 **[Test build #122648 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122648/testReport)** for PR 28501 at commit [`3b48e38`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #25870: [SPARK-27936][K8S] Support python deps

2020-05-14 Thread GitBox
SparkQA commented on pull request #25870: URL: https://github.com/apache/spark/pull/25870#issuecomment-629028801 **[Test build #122647 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122647/testReport)** for PR 25870 at commit [`a9f055b`](https://github.com

[GitHub] [spark] dongjoon-hyun commented on pull request #25870: [SPARK-27936][K8S] Support python deps

2020-05-14 Thread GitBox
dongjoon-hyun commented on pull request #25870: URL: https://github.com/apache/spark/pull/25870#issuecomment-629027123 The dependency issue is fixed. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] dongjoon-hyun commented on pull request #25870: [SPARK-27936][K8S] Support python deps

2020-05-14 Thread GitBox
dongjoon-hyun commented on pull request #25870: URL: https://github.com/apache/spark/pull/25870#issuecomment-629027156 Retest this please. This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28526: [SPARK-31405][SQL][3.0] Fail by default when reading/writing legacy datetime values from/to Parquet/Avro files

2020-05-14 Thread GitBox
AmplabJenkins removed a comment on pull request #28526: URL: https://github.com/apache/spark/pull/28526#issuecomment-629022492 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/122

[GitHub] [spark] SparkQA removed a comment on pull request #28526: [SPARK-31405][SQL][3.0] Fail by default when reading/writing legacy datetime values from/to Parquet/Avro files

2020-05-14 Thread GitBox
SparkQA removed a comment on pull request #28526: URL: https://github.com/apache/spark/pull/28526#issuecomment-629020341 **[Test build #5006 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/5006/testReport)** for PR 28526 at commit [`9f14144`](https://git

[GitHub] [spark] SparkQA commented on pull request #28526: [SPARK-31405][SQL][3.0] Fail by default when reading/writing legacy datetime values from/to Parquet/Avro files

2020-05-14 Thread GitBox
SparkQA commented on pull request #28526: URL: https://github.com/apache/spark/pull/28526#issuecomment-629022933 **[Test build #5006 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/5006/testReport)** for PR 28526 at commit [`9f14144`](https://github.com

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28537: [SPARK-31715][SQL][TEST] Fix flaky SparkSQLEnvSuite that sometimes varies single derby instance standard

2020-05-14 Thread GitBox
AmplabJenkins removed a comment on pull request #28537: URL: https://github.com/apache/spark/pull/28537#issuecomment-629022582 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/122

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28537: [SPARK-31715][SQL][TEST] Fix flaky SparkSQLEnvSuite that sometimes varies single derby instance standard

2020-05-14 Thread GitBox
AmplabJenkins removed a comment on pull request #28537: URL: https://github.com/apache/spark/pull/28537#issuecomment-629022578 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] SparkQA removed a comment on pull request #28526: [SPARK-31405][SQL][3.0] Fail by default when reading/writing legacy datetime values from/to Parquet/Avro files

2020-05-14 Thread GitBox
SparkQA removed a comment on pull request #28526: URL: https://github.com/apache/spark/pull/28526#issuecomment-629019973 **[Test build #122646 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122646/testReport)** for PR 28526 at commit [`9f14144`](https://gi

[GitHub] [spark] SparkQA removed a comment on pull request #28537: [SPARK-31715][SQL][TEST] Fix flaky SparkSQLEnvSuite that sometimes varies single derby instance standard

2020-05-14 Thread GitBox
SparkQA removed a comment on pull request #28537: URL: https://github.com/apache/spark/pull/28537#issuecomment-629012577 **[Test build #122645 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122645/testReport)** for PR 28537 at commit [`31d032e`](https://gi

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28526: [SPARK-31405][SQL][3.0] Fail by default when reading/writing legacy datetime values from/to Parquet/Avro files

2020-05-14 Thread GitBox
AmplabJenkins removed a comment on pull request #28526: URL: https://github.com/apache/spark/pull/28526#issuecomment-629022488 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] SparkQA commented on pull request #28526: [SPARK-31405][SQL][3.0] Fail by default when reading/writing legacy datetime values from/to Parquet/Avro files

2020-05-14 Thread GitBox
SparkQA commented on pull request #28526: URL: https://github.com/apache/spark/pull/28526#issuecomment-629022481 **[Test build #122646 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122646/testReport)** for PR 28526 at commit [`9f14144`](https://github.co

[GitHub] [spark] AmplabJenkins commented on pull request #28526: [SPARK-31405][SQL][3.0] Fail by default when reading/writing legacy datetime values from/to Parquet/Avro files

2020-05-14 Thread GitBox
AmplabJenkins commented on pull request #28526: URL: https://github.com/apache/spark/pull/28526#issuecomment-629022488 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #28537: [SPARK-31715][SQL][TEST] Fix flaky SparkSQLEnvSuite that sometimes varies single derby instance standard

2020-05-14 Thread GitBox
SparkQA commented on pull request #28537: URL: https://github.com/apache/spark/pull/28537#issuecomment-629022542 **[Test build #122645 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122645/testReport)** for PR 28537 at commit [`31d032e`](https://github.co

[GitHub] [spark] AmplabJenkins commented on pull request #28537: [SPARK-31715][SQL][TEST] Fix flaky SparkSQLEnvSuite that sometimes varies single derby instance standard

2020-05-14 Thread GitBox
AmplabJenkins commented on pull request #28537: URL: https://github.com/apache/spark/pull/28537#issuecomment-629022578 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] HyukjinKwon edited a comment on pull request #28526: [SPARK-31405][SQL][3.0] Fail by default when reading/writing legacy datetime values from/to Parquet/Avro files

2020-05-14 Thread GitBox
HyukjinKwon edited a comment on pull request #28526: URL: https://github.com/apache/spark/pull/28526#issuecomment-629021118 FYI, the issue seems not completely fixed yet due to the cached `.m2/repository`, see also https://issues.apache.org/jira/browse/SPARK-31693?focusedCommentId=17107856

[GitHub] [spark] HyukjinKwon commented on pull request #28526: [SPARK-31405][SQL][3.0] Fail by default when reading/writing legacy datetime values from/to Parquet/Avro files

2020-05-14 Thread GitBox
HyukjinKwon commented on pull request #28526: URL: https://github.com/apache/spark/pull/28526#issuecomment-629021118 FYI,tThis seems not completely fixed yet due to the cached `.m2/repository`, see also https://issues.apache.org/jira/browse/SPARK-31693?focusedCommentId=17107856&page=com.at

[GitHub] [spark] HeartSaVioR commented on a change in pull request #28517: [SPARK-31707][SQL] Revert SPARK-30098 Use default datasource as provider for CREATE TABLE syntax

2020-05-14 Thread GitBox
HeartSaVioR commented on a change in pull request #28517: URL: https://github.com/apache/spark/pull/28517#discussion_r425561029 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/DDLParserSuite.scala ## @@ -2195,22 +2195,4 @@ class DDLParserSuite ex

[GitHub] [spark] SparkQA commented on pull request #28526: [SPARK-31405][SQL][3.0] Fail by default when reading/writing legacy datetime values from/to Parquet/Avro files

2020-05-14 Thread GitBox
SparkQA commented on pull request #28526: URL: https://github.com/apache/spark/pull/28526#issuecomment-629020394 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [spark] SparkQA commented on pull request #28526: [SPARK-31405][SQL][3.0] Fail by default when reading/writing legacy datetime values from/to Parquet/Avro files

2020-05-14 Thread GitBox
SparkQA commented on pull request #28526: URL: https://github.com/apache/spark/pull/28526#issuecomment-629020341 **[Test build #5006 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/5006/testReport)** for PR 28526 at commit [`9f14144`](https://github.com/

[GitHub] [spark] AmplabJenkins commented on pull request #28526: [SPARK-31405][SQL][3.0] Fail by default when reading/writing legacy datetime values from/to Parquet/Avro files

2020-05-14 Thread GitBox
AmplabJenkins commented on pull request #28526: URL: https://github.com/apache/spark/pull/28526#issuecomment-629020204 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28526: [SPARK-31405][SQL][3.0] Fail by default when reading/writing legacy datetime values from/to Parquet/Avro files

2020-05-14 Thread GitBox
AmplabJenkins removed a comment on pull request #28526: URL: https://github.com/apache/spark/pull/28526#issuecomment-629020204 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #28526: [SPARK-31405][SQL][3.0] Fail by default when reading/writing legacy datetime values from/to Parquet/Avro files

2020-05-14 Thread GitBox
SparkQA commented on pull request #28526: URL: https://github.com/apache/spark/pull/28526#issuecomment-629019973 **[Test build #122646 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122646/testReport)** for PR 28526 at commit [`9f14144`](https://github.com

[GitHub] [spark] HeartSaVioR commented on a change in pull request #28517: [SPARK-31707][SQL] Revert SPARK-30098 Use default datasource as provider for CREATE TABLE syntax

2020-05-14 Thread GitBox
HeartSaVioR commented on a change in pull request #28517: URL: https://github.com/apache/spark/pull/28517#discussion_r425560435 ## File path: docs/sql-ref-syntax-ddl-create-table-datasource.md ## @@ -40,7 +40,7 @@ CREATE TABLE [ IF NOT EXISTS ] table_identifier [ AS select

[GitHub] [spark] cloud-fan commented on pull request #28526: [SPARK-31405][SQL][3.0] Fail by default when reading/writing legacy datetime values from/to Parquet/Avro files

2020-05-14 Thread GitBox
cloud-fan commented on pull request #28526: URL: https://github.com/apache/spark/pull/28526#issuecomment-629019709 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] cloud-fan commented on pull request #28501: [SPARK-31663][SQL] Grouping sets with having clause returns the wrong result

2020-05-14 Thread GitBox
cloud-fan commented on pull request #28501: URL: https://github.com/apache/spark/pull/28501#issuecomment-629019390 It's a long-standing bug, so it doesn't block 2.4.6. I'll see if I can merge it today. This is an automated m

[GitHub] [spark] cloud-fan commented on a change in pull request #28517: [SPARK-31707][SQL] Revert SPARK-30098 Use default datasource as provider for CREATE TABLE syntax

2020-05-14 Thread GitBox
cloud-fan commented on a change in pull request #28517: URL: https://github.com/apache/spark/pull/28517#discussion_r425559542 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/DDLParserSuite.scala ## @@ -2195,22 +2195,4 @@ class DDLParserSuite exte

[GitHub] [spark] cloud-fan commented on a change in pull request #28517: [SPARK-31707][SQL] Revert SPARK-30098 Use default datasource as provider for CREATE TABLE syntax

2020-05-14 Thread GitBox
cloud-fan commented on a change in pull request #28517: URL: https://github.com/apache/spark/pull/28517#discussion_r425559216 ## File path: docs/sql-ref-syntax-ddl-create-table-datasource.md ## @@ -40,7 +40,7 @@ CREATE TABLE [ IF NOT EXISTS ] table_identifier [ AS select_s

[GitHub] [spark] HeartSaVioR commented on a change in pull request #28517: [SPARK-31707][SQL] Revert SPARK-30098 Use default datasource as provider for CREATE TABLE syntax

2020-05-14 Thread GitBox
HeartSaVioR commented on a change in pull request #28517: URL: https://github.com/apache/spark/pull/28517#discussion_r425558929 ## File path: docs/sql-ref-syntax-ddl-create-table-datasource.md ## @@ -40,7 +40,7 @@ CREATE TABLE [ IF NOT EXISTS ] table_identifier [ AS select

[GitHub] [spark] cloud-fan closed pull request #28531: [SPARK-31712][SQL][TESTS] Check casting timestamps before the epoch to Byte/Short/Int/Long types

2020-05-14 Thread GitBox
cloud-fan closed pull request #28531: URL: https://github.com/apache/spark/pull/28531 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [spark] HeartSaVioR commented on a change in pull request #28517: [SPARK-31707][SQL] Revert SPARK-30098 Use default datasource as provider for CREATE TABLE syntax

2020-05-14 Thread GitBox
HeartSaVioR commented on a change in pull request #28517: URL: https://github.com/apache/spark/pull/28517#discussion_r425558612 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/DDLParserSuite.scala ## @@ -2195,22 +2195,4 @@ class DDLParserSuite ex

[GitHub] [spark] cloud-fan commented on pull request #28531: [SPARK-31712][SQL][TESTS] Check casting timestamps before the epoch to Byte/Short/Int/Long types

2020-05-14 Thread GitBox
cloud-fan commented on pull request #28531: URL: https://github.com/apache/spark/pull/28531#issuecomment-629018056 thanks, merging to master/3.0! This is an automated message from the Apache Git Service. To respond to the mes

  1   2   3   4   5   6   >