[GitHub] [spark] HyukjinKwon commented on pull request #28771: [2.4][SPARK-31935][SQL] Hadoop file system config should be effective in data source options

2020-06-30 Thread GitBox
HyukjinKwon commented on pull request #28771: URL: https://github.com/apache/spark/pull/28771#issuecomment-652231653 Yeah, it should be best to have LGTM or at least some positive comments. This is an automated message from t

[GitHub] [spark] LantaoJin commented on a change in pull request #28833: [SPARK-20680][SQL] Spark-sql do not support for creating table with void column datatype

2020-06-30 Thread GitBox
LantaoJin commented on a change in pull request #28833: URL: https://github.com/apache/spark/pull/28833#discussion_r448149646 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/rules.scala ## @@ -292,6 +293,8 @@ case class PreprocessTableCreation(

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28953: [SPARK-32013][SQL] Support query execution before/after reading/writing DataFrame over JDBC

2020-06-30 Thread GitBox
AmplabJenkins removed a comment on pull request #28953: URL: https://github.com/apache/spark/pull/28953#issuecomment-652230833 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124

[GitHub] [spark] LantaoJin commented on a change in pull request #28833: [SPARK-20680][SQL] Spark-sql do not support for creating table with void column datatype

2020-06-30 Thread GitBox
LantaoJin commented on a change in pull request #28833: URL: https://github.com/apache/spark/pull/28833#discussion_r448149646 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/rules.scala ## @@ -292,6 +293,8 @@ case class PreprocessTableCreation(

[GitHub] [spark] dongjoon-hyun edited a comment on pull request #28771: [2.4][SPARK-31935][SQL] Hadoop file system config should be effective in data source options

2020-06-30 Thread GitBox
dongjoon-hyun edited a comment on pull request #28771: URL: https://github.com/apache/spark/pull/28771#issuecomment-652230135 Note that I'm fine with that backporting because it seems that you were confident with this and it looked urgent to you. --

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28953: [SPARK-32013][SQL] Support query execution before/after reading/writing DataFrame over JDBC

2020-06-30 Thread GitBox
AmplabJenkins removed a comment on pull request #28953: URL: https://github.com/apache/spark/pull/28953#issuecomment-652230826 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] cloud-fan commented on a change in pull request #28833: [SPARK-20680][SQL] Spark-sql do not support for creating table with void column datatype

2020-06-30 Thread GitBox
cloud-fan commented on a change in pull request #28833: URL: https://github.com/apache/spark/pull/28833#discussion_r448154450 ## File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala ## @@ -2309,6 +2309,108 @@ class HiveDDLSuite } }

[GitHub] [spark] AmplabJenkins commented on pull request #28953: [SPARK-32013][SQL] Support query execution before/after reading/writing DataFrame over JDBC

2020-06-30 Thread GitBox
AmplabJenkins commented on pull request #28953: URL: https://github.com/apache/spark/pull/28953#issuecomment-652230826 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] dongjoon-hyun commented on pull request #28771: [2.4][SPARK-31935][SQL] Hadoop file system config should be effective in data source options

2020-06-30 Thread GitBox
dongjoon-hyun commented on pull request #28771: URL: https://github.com/apache/spark/pull/28771#issuecomment-652230135 Note that I'm fine with this because it seems that you were confident with this and it looked urgent to you. -

[GitHub] [spark] SparkQA removed a comment on pull request #28953: [SPARK-32013][SQL] Support query execution before/after reading/writing DataFrame over JDBC

2020-06-30 Thread GitBox
SparkQA removed a comment on pull request #28953: URL: https://github.com/apache/spark/pull/28953#issuecomment-652136148 **[Test build #124715 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124715/testReport)** for PR 28953 at commit [`f2e68a2`](https://gi

[GitHub] [spark] LantaoJin commented on a change in pull request #28833: [SPARK-20680][SQL] Spark-sql do not support for creating table with void column datatype

2020-06-30 Thread GitBox
LantaoJin commented on a change in pull request #28833: URL: https://github.com/apache/spark/pull/28833#discussion_r448153666 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala ## @@ -2211,6 +2211,8 @@ class AstBuilder(conf: SQLConf

[GitHub] [spark] SparkQA commented on pull request #28953: [SPARK-32013][SQL] Support query execution before/after reading/writing DataFrame over JDBC

2020-06-30 Thread GitBox
SparkQA commented on pull request #28953: URL: https://github.com/apache/spark/pull/28953#issuecomment-652229722 **[Test build #124715 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124715/testReport)** for PR 28953 at commit [`f2e68a2`](https://github.co

[GitHub] [spark] dongjoon-hyun commented on pull request #28771: [2.4][SPARK-31935][SQL] Hadoop file system config should be effective in data source options

2020-06-30 Thread GitBox
dongjoon-hyun commented on pull request #28771: URL: https://github.com/apache/spark/pull/28771#issuecomment-652228985 Hi, @gengliangwang . Did you merge this without any LGTM from other committers? cc @gatorsmile , @cloud-fan , @HyukjinKwon ---

[GitHub] [spark] LantaoJin commented on a change in pull request #28833: [SPARK-20680][SQL] Spark-sql do not support for creating table with void column datatype

2020-06-30 Thread GitBox
LantaoJin commented on a change in pull request #28833: URL: https://github.com/apache/spark/pull/28833#discussion_r448150865 ## File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveStrategies.scala ## @@ -106,7 +107,7 @@ class ResolveHiveSerdeTable(session: SparkS

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28962: [SPARK-32136][SQL] NormalizeFloatingNumbers should work on null struct

2020-06-30 Thread GitBox
dongjoon-hyun commented on a change in pull request #28962: URL: https://github.com/apache/spark/pull/28962#discussion_r448150897 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/NormalizeFloatingNumbers.scala ## @@ -123,7 +123,8 @@ object Norm

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28962: [SPARK-32136][SQL] NormalizeFloatingNumbers should work on null struct

2020-06-30 Thread GitBox
dongjoon-hyun commented on a change in pull request #28962: URL: https://github.com/apache/spark/pull/28962#discussion_r448150338 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/NormalizeFloatingNumbers.scala ## @@ -123,7 +123,8 @@ object Norm

[GitHub] [spark] LantaoJin commented on a change in pull request #28833: [SPARK-20680][SQL] Spark-sql do not support for creating table with void column datatype

2020-06-30 Thread GitBox
LantaoJin commented on a change in pull request #28833: URL: https://github.com/apache/spark/pull/28833#discussion_r448149646 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/rules.scala ## @@ -292,6 +293,8 @@ case class PreprocessTableCreation(

[GitHub] [spark] LantaoJin commented on a change in pull request #28833: [SPARK-20680][SQL] Spark-sql do not support for creating table with void column datatype

2020-06-30 Thread GitBox
LantaoJin commented on a change in pull request #28833: URL: https://github.com/apache/spark/pull/28833#discussion_r448149646 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/rules.scala ## @@ -292,6 +293,8 @@ case class PreprocessTableCreation(

[GitHub] [spark] LantaoJin commented on a change in pull request #28833: [SPARK-20680][SQL] Spark-sql do not support for creating table with void column datatype

2020-06-30 Thread GitBox
LantaoJin commented on a change in pull request #28833: URL: https://github.com/apache/spark/pull/28833#discussion_r448149646 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/rules.scala ## @@ -292,6 +293,8 @@ case class PreprocessTableCreation(

[GitHub] [spark] LantaoJin commented on a change in pull request #28833: [SPARK-20680][SQL] Spark-sql do not support for creating table with void column datatype

2020-06-30 Thread GitBox
LantaoJin commented on a change in pull request #28833: URL: https://github.com/apache/spark/pull/28833#discussion_r448149646 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/rules.scala ## @@ -292,6 +293,8 @@ case class PreprocessTableCreation(

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28951: [SPARK-32131][SQL] Fix AnalysisException messages at UNION/EXCEPT/MINUS operations

2020-06-30 Thread GitBox
AmplabJenkins removed a comment on pull request #28951: URL: https://github.com/apache/spark/pull/28951#issuecomment-652225009 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28951: [SPARK-32131][SQL] Fix AnalysisException messages at UNION/EXCEPT/MINUS operations

2020-06-30 Thread GitBox
AmplabJenkins commented on pull request #28951: URL: https://github.com/apache/spark/pull/28951#issuecomment-652225009 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28956: [SPARK-31797][SQL][FOLLOWUP] TIMESTAMP_SECONDS supports fractional input

2020-06-30 Thread GitBox
AmplabJenkins removed a comment on pull request #28956: URL: https://github.com/apache/spark/pull/28956#issuecomment-652224005 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] dongjoon-hyun commented on pull request #28951: [SPARK-32131][SQL] Fix AnalysisException messages at UNION/EXCEPT/MINUS operations

2020-06-30 Thread GitBox
dongjoon-hyun commented on pull request #28951: URL: https://github.com/apache/spark/pull/28951#issuecomment-652224404 Thank you all! This lands at `master/3.0/2.4`. This is an automated message from the Apache Git Service. T

[GitHub] [spark] AmplabJenkins commented on pull request #28956: [SPARK-31797][SQL][FOLLOWUP] TIMESTAMP_SECONDS supports fractional input

2020-06-30 Thread GitBox
AmplabJenkins commented on pull request #28956: URL: https://github.com/apache/spark/pull/28956#issuecomment-652224005 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #28956: [SPARK-31797][SQL][FOLLOWUP] TIMESTAMP_SECONDS supports fractional input

2020-06-30 Thread GitBox
SparkQA commented on pull request #28956: URL: https://github.com/apache/spark/pull/28956#issuecomment-652223503 **[Test build #124747 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124747/testReport)** for PR 28956 at commit [`e41095d`](https://github.com

[GitHub] [spark] SparkQA removed a comment on pull request #28951: [SPARK-32131][SQL] Fix AnalysisException messages at UNION/EXCEPT/MINUS operations

2020-06-30 Thread GitBox
SparkQA removed a comment on pull request #28951: URL: https://github.com/apache/spark/pull/28951#issuecomment-652109787 **[Test build #124704 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124704/testReport)** for PR 28951 at commit [`984c652`](https://gi

[GitHub] [spark] SparkQA commented on pull request #28951: [SPARK-32131][SQL] Fix AnalysisException messages at UNION/EXCEPT/MINUS operations

2020-06-30 Thread GitBox
SparkQA commented on pull request #28951: URL: https://github.com/apache/spark/pull/28951#issuecomment-652223150 **[Test build #124704 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124704/testReport)** for PR 28951 at commit [`984c652`](https://github.co

[GitHub] [spark] LantaoJin commented on a change in pull request #28833: [SPARK-20680][SQL] Spark-sql do not support for creating table with void column datatype

2020-06-30 Thread GitBox
LantaoJin commented on a change in pull request #28833: URL: https://github.com/apache/spark/pull/28833#discussion_r448145159 ## File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala ## @@ -2309,6 +2309,108 @@ class HiveDDLSuite } }

[GitHub] [spark] dongjoon-hyun closed pull request #28951: [SPARK-32131][SQL] Fix AnalysisException messages at UNION/EXCEPT/MINUS operations

2020-06-30 Thread GitBox
dongjoon-hyun closed pull request #28951: URL: https://github.com/apache/spark/pull/28951 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [spark] gengliangwang commented on a change in pull request #28805: [SPARK-28169][SQL] Convert scan predicate condition to CNF

2020-06-30 Thread GitBox
gengliangwang commented on a change in pull request #28805: URL: https://github.com/apache/spark/pull/28805#discussion_r448143683 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala ## @@ -249,8 +251,36 @@ trait PredicateHelper

[GitHub] [spark] gengliangwang commented on a change in pull request #28805: [SPARK-28169][SQL] Convert scan predicate condition to CNF

2020-06-30 Thread GitBox
gengliangwang commented on a change in pull request #28805: URL: https://github.com/apache/spark/pull/28805#discussion_r448143802 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala ## @@ -249,8 +251,36 @@ trait PredicateHelper

[GitHub] [spark] LantaoJin commented on a change in pull request #28833: [SPARK-20680][SQL] Spark-sql do not support for creating table with void column datatype

2020-06-30 Thread GitBox
LantaoJin commented on a change in pull request #28833: URL: https://github.com/apache/spark/pull/28833#discussion_r448143565 ## File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala ## @@ -2309,6 +2309,108 @@ class HiveDDLSuite } }

[GitHub] [spark] MaxGekk commented on pull request #27366: [SPARK-30648][SQL] Support filters pushdown in JSON datasource

2020-06-30 Thread GitBox
MaxGekk commented on pull request #27366: URL: https://github.com/apache/spark/pull/27366#issuecomment-652220337 @HyukjinKwon @cloud-fan Please, have a look at this PR. This is an automated message from the Apache Git Service

[GitHub] [spark] cloud-fan commented on a change in pull request #28956: [SPARK-31797][SQL][FOLLOWUP] TIMESTAMP_SECONDS supports fractional input

2020-06-30 Thread GitBox
cloud-fan commented on a change in pull request #28956: URL: https://github.com/apache/spark/pull/28956#discussion_r448142644 ## File path: sql/core/src/test/resources/sql-tests/inputs/datetime.sql ## @@ -2,13 +2,16 @@ -- [SPARK-31710] TIMESTAMP_SECONDS, TIMESTAMP_MILLISECON

[GitHub] [spark] cloud-fan edited a comment on pull request #28954: [SPARK-32083][SQL] Apply CoalesceShufflePartitions when input RDD has 0 partitions with AQE

2020-06-30 Thread GitBox
cloud-fan edited a comment on pull request #28954: URL: https://github.com/apache/spark/pull/28954#issuecomment-652219037 After more thoughts, maybe a better way is to add a new rule in `AdaptiveSparkPlanExec.optimizer`, which converts `LogicalQueryStage` to empty `LocalRelation` if the si

[GitHub] [spark] LantaoJin commented on a change in pull request #28833: [SPARK-20680][SQL] Spark-sql do not support for creating table with void column datatype

2020-06-30 Thread GitBox
LantaoJin commented on a change in pull request #28833: URL: https://github.com/apache/spark/pull/28833#discussion_r448138143 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/connector/catalog/CatalogV2Util.scala ## @@ -346,4 +346,17 @@ private[sql] object Catalo

[GitHub] [spark] cloud-fan commented on pull request #28954: [SPARK-32083][SQL] Apply CoalesceShufflePartitions when input RDD has 0 partitions with AQE

2020-06-30 Thread GitBox
cloud-fan commented on pull request #28954: URL: https://github.com/apache/spark/pull/28954#issuecomment-652219037 After more thoughts, maybe a better way is to add a new rule in `AdaptiveSparkPlanExec.optimizer`, which converts `LogicalQueryStage` to empty `LocalRelation` if the size is 0

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28833: [SPARK-20680][SQL] Spark-sql do not support for creating table with void column datatype

2020-06-30 Thread GitBox
AmplabJenkins removed a comment on pull request #28833: URL: https://github.com/apache/spark/pull/28833#issuecomment-652217235 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28833: [SPARK-20680][SQL] Spark-sql do not support for creating table with void column datatype

2020-06-30 Thread GitBox
AmplabJenkins removed a comment on pull request #28833: URL: https://github.com/apache/spark/pull/28833#issuecomment-652217228 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] SparkQA removed a comment on pull request #28833: [SPARK-20680][SQL] Spark-sql do not support for creating table with void column datatype

2020-06-30 Thread GitBox
SparkQA removed a comment on pull request #28833: URL: https://github.com/apache/spark/pull/28833#issuecomment-652160085 **[Test build #124734 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124734/testReport)** for PR 28833 at commit [`fdf57bf`](https://gi

[GitHub] [spark] AmplabJenkins commented on pull request #28833: [SPARK-20680][SQL] Spark-sql do not support for creating table with void column datatype

2020-06-30 Thread GitBox
AmplabJenkins commented on pull request #28833: URL: https://github.com/apache/spark/pull/28833#issuecomment-652217228 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #28833: [SPARK-20680][SQL] Spark-sql do not support for creating table with void column datatype

2020-06-30 Thread GitBox
SparkQA commented on pull request #28833: URL: https://github.com/apache/spark/pull/28833#issuecomment-652217007 **[Test build #124734 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124734/testReport)** for PR 28833 at commit [`fdf57bf`](https://github.co

[GitHub] [spark] zhli1142015 commented on pull request #28859: [SPARK-32024][WEBUI] Update ApplicationStoreInfo.size during HistoryServerDiskManager initializing

2020-06-30 Thread GitBox
zhli1142015 commented on pull request #28859: URL: https://github.com/apache/spark/pull/28859#issuecomment-652215562 Gently ping, @jiangxb1987 , @dongjoon-hyun , @ueshin , @gengliangwang , could you please help to review? Th

[GitHub] [spark] LantaoJin commented on a change in pull request #28833: [SPARK-20680][SQL] Spark-sql do not support for creating table with void column datatype

2020-06-30 Thread GitBox
LantaoJin commented on a change in pull request #28833: URL: https://github.com/apache/spark/pull/28833#discussion_r448138143 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/connector/catalog/CatalogV2Util.scala ## @@ -346,4 +346,17 @@ private[sql] object Catalo

[GitHub] [spark] dongjoon-hyun commented on pull request #28962: [SPARK-32136][SQL] NormalizeFloatingNumbers should work on null struct

2020-06-30 Thread GitBox
dongjoon-hyun commented on pull request #28962: URL: https://github.com/apache/spark/pull/28962#issuecomment-652214503 Thank you so much, @viirya . This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [spark] dongjoon-hyun closed pull request #28949: [SPARK-32028][WEBUI][2.4] fix app id link for multi attempts app in history summary page

2020-06-30 Thread GitBox
dongjoon-hyun closed pull request #28949: URL: https://github.com/apache/spark/pull/28949 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [spark] manuzhang commented on a change in pull request #28954: [SPARK-32083][SQL] Apply CoalesceShufflePartitions when input RDD has 0 partitions with AQE

2020-06-30 Thread GitBox
manuzhang commented on a change in pull request #28954: URL: https://github.com/apache/spark/pull/28954#discussion_r448135495 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/CoalesceShufflePartitions.scala ## @@ -79,8 +66,29 @@ case class Coalesce

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28962: [SPARK-32136][SQL] NormalizeFloatingNumbers should work on null struct

2020-06-30 Thread GitBox
AmplabJenkins removed a comment on pull request #28962: URL: https://github.com/apache/spark/pull/28962#issuecomment-652210749 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #28962: [SPARK-32136][SQL] NormalizeFloatingNumbers should work on null struct

2020-06-30 Thread GitBox
SparkQA commented on pull request #28962: URL: https://github.com/apache/spark/pull/28962#issuecomment-652212688 **[Test build #124746 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124746/testReport)** for PR 28962 at commit [`41a318e`](https://github.com

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28833: [SPARK-20680][SQL] Spark-sql do not support for creating table with void column datatype

2020-06-30 Thread GitBox
AmplabJenkins removed a comment on pull request #28833: URL: https://github.com/apache/spark/pull/28833#issuecomment-652211295 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28962: [SPARK-32136][SQL] NormalizeFloatingNumbers should work on null struct

2020-06-30 Thread GitBox
AmplabJenkins commented on pull request #28962: URL: https://github.com/apache/spark/pull/28962#issuecomment-652210749 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA removed a comment on pull request #28833: [SPARK-20680][SQL] Spark-sql do not support for creating table with void column datatype

2020-06-30 Thread GitBox
SparkQA removed a comment on pull request #28833: URL: https://github.com/apache/spark/pull/28833#issuecomment-652114014 **[Test build #124706 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124706/testReport)** for PR 28833 at commit [`5aa4c1a`](https://gi

[GitHub] [spark] SparkQA commented on pull request #28833: [SPARK-20680][SQL] Spark-sql do not support for creating table with void column datatype

2020-06-30 Thread GitBox
SparkQA commented on pull request #28833: URL: https://github.com/apache/spark/pull/28833#issuecomment-652210408 **[Test build #124706 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124706/testReport)** for PR 28833 at commit [`5aa4c1a`](https://github.co

[GitHub] [spark] viirya commented on pull request #28962: [SPARK-32136][SQL] NormalizeFloatingNumbers should work on null struct

2020-06-30 Thread GitBox
viirya commented on pull request #28962: URL: https://github.com/apache/spark/pull/28962#issuecomment-652210688 cc @cloud-fan @HyukjinKwon This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28940: [SPARK-32121][SHUFFLE] Support Windows OS in ExecutorDiskUtils

2020-06-30 Thread GitBox
AmplabJenkins removed a comment on pull request #28940: URL: https://github.com/apache/spark/pull/28940#issuecomment-652209724 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124

[GitHub] [spark] viirya opened a new pull request #28962: [SPARK-32136][SQL] NormalizeFloatingNumbers should work on null struct

2020-06-30 Thread GitBox
viirya opened a new pull request #28962: URL: https://github.com/apache/spark/pull/28962 ### What changes were proposed in this pull request? This patch fixes wrong groupBy result if the grouping key is a null-value struct. ### Why are the changes needed?

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28940: [SPARK-32121][SHUFFLE] Support Windows OS in ExecutorDiskUtils

2020-06-30 Thread GitBox
AmplabJenkins removed a comment on pull request #28940: URL: https://github.com/apache/spark/pull/28940#issuecomment-652209718 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] dongjoon-hyun commented on pull request #28957: [WIP][SPARK-32138] Drop Python 2.7, 3.4 and 3.5

2020-06-30 Thread GitBox
dongjoon-hyun commented on pull request #28957: URL: https://github.com/apache/spark/pull/28957#issuecomment-652210013 Wow, nice investigation, @Fokko ! Thanks. This is an automated message from the Apache Git Service. To res

[GitHub] [spark] AmplabJenkins commented on pull request #28940: [SPARK-32121][SHUFFLE] Support Windows OS in ExecutorDiskUtils

2020-06-30 Thread GitBox
AmplabJenkins commented on pull request #28940: URL: https://github.com/apache/spark/pull/28940#issuecomment-652209724 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA removed a comment on pull request #28940: [SPARK-32121][SHUFFLE] Support Windows OS in ExecutorDiskUtils

2020-06-30 Thread GitBox
SparkQA removed a comment on pull request #28940: URL: https://github.com/apache/spark/pull/28940#issuecomment-652142021 **[Test build #124722 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124722/testReport)** for PR 28940 at commit [`aac01ca`](https://gi

[GitHub] [spark] SparkQA commented on pull request #28940: [SPARK-32121][SHUFFLE] Support Windows OS in ExecutorDiskUtils

2020-06-30 Thread GitBox
SparkQA commented on pull request #28940: URL: https://github.com/apache/spark/pull/28940#issuecomment-652207766 **[Test build #124722 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124722/testReport)** for PR 28940 at commit [`aac01ca`](https://github.co

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28953: [SPARK-32013][SQL] Support query execution before/after reading/writing DataFrame over JDBC

2020-06-30 Thread GitBox
AmplabJenkins removed a comment on pull request #28953: URL: https://github.com/apache/spark/pull/28953#issuecomment-652202419 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28953: [SPARK-32013][SQL] Support query execution before/after reading/writing DataFrame over JDBC

2020-06-30 Thread GitBox
AmplabJenkins removed a comment on pull request #28953: URL: https://github.com/apache/spark/pull/28953#issuecomment-652202412 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] AmplabJenkins commented on pull request #28953: [SPARK-32013][SQL] Support query execution before/after reading/writing DataFrame over JDBC

2020-06-30 Thread GitBox
AmplabJenkins commented on pull request #28953: URL: https://github.com/apache/spark/pull/28953#issuecomment-652202412 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #28953: [SPARK-32013][SQL] Support query execution before/after reading/writing DataFrame over JDBC

2020-06-30 Thread GitBox
SparkQA commented on pull request #28953: URL: https://github.com/apache/spark/pull/28953#issuecomment-652202383 **[Test build #124745 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124745/testReport)** for PR 28953 at commit [`0db0376`](https://github.co

[GitHub] [spark] SparkQA removed a comment on pull request #28953: [SPARK-32013][SQL] Support query execution before/after reading/writing DataFrame over JDBC

2020-06-30 Thread GitBox
SparkQA removed a comment on pull request #28953: URL: https://github.com/apache/spark/pull/28953#issuecomment-652196837 **[Test build #124745 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124745/testReport)** for PR 28953 at commit [`0db0376`](https://gi

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28647: [SPARK-31828][SQL] Retain table properties at CreateTableLikeCommand

2020-06-30 Thread GitBox
AmplabJenkins removed a comment on pull request #28647: URL: https://github.com/apache/spark/pull/28647#issuecomment-652202127 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124

[GitHub] [spark] SparkQA removed a comment on pull request #28647: [SPARK-31828][SQL] Retain table properties at CreateTableLikeCommand

2020-06-30 Thread GitBox
SparkQA removed a comment on pull request #28647: URL: https://github.com/apache/spark/pull/28647#issuecomment-652174626 **[Test build #124739 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124739/testReport)** for PR 28647 at commit [`7f9f685`](https://gi

[GitHub] [spark] AmplabJenkins commented on pull request #28647: [SPARK-31828][SQL] Retain table properties at CreateTableLikeCommand

2020-06-30 Thread GitBox
AmplabJenkins commented on pull request #28647: URL: https://github.com/apache/spark/pull/28647#issuecomment-652202119 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28647: [SPARK-31828][SQL] Retain table properties at CreateTableLikeCommand

2020-06-30 Thread GitBox
AmplabJenkins removed a comment on pull request #28647: URL: https://github.com/apache/spark/pull/28647#issuecomment-652202119 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] SparkQA commented on pull request #28647: [SPARK-31828][SQL] Retain table properties at CreateTableLikeCommand

2020-06-30 Thread GitBox
SparkQA commented on pull request #28647: URL: https://github.com/apache/spark/pull/28647#issuecomment-652201843 **[Test build #124739 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124739/testReport)** for PR 28647 at commit [`7f9f685`](https://github.co

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28947: [SPARK-32129][SQL] Support AQE skew join with Union

2020-06-30 Thread GitBox
AmplabJenkins removed a comment on pull request #28947: URL: https://github.com/apache/spark/pull/28947#issuecomment-652199044 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28947: [SPARK-32129][SQL] Support AQE skew join with Union

2020-06-30 Thread GitBox
AmplabJenkins removed a comment on pull request #28947: URL: https://github.com/apache/spark/pull/28947#issuecomment-652199037 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] SparkQA removed a comment on pull request #28947: [SPARK-32129][SQL] Support AQE skew join with Union

2020-06-30 Thread GitBox
SparkQA removed a comment on pull request #28947: URL: https://github.com/apache/spark/pull/28947#issuecomment-652182370 **[Test build #124740 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124740/testReport)** for PR 28947 at commit [`d011e9a`](https://gi

[GitHub] [spark] AmplabJenkins commented on pull request #28947: [SPARK-32129][SQL] Support AQE skew join with Union

2020-06-30 Thread GitBox
AmplabJenkins commented on pull request #28947: URL: https://github.com/apache/spark/pull/28947#issuecomment-652199037 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #28947: [SPARK-32129][SQL] Support AQE skew join with Union

2020-06-30 Thread GitBox
SparkQA commented on pull request #28947: URL: https://github.com/apache/spark/pull/28947#issuecomment-652198809 **[Test build #124740 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124740/testReport)** for PR 28947 at commit [`d011e9a`](https://github.co

[GitHub] [spark] maropu commented on a change in pull request #28676: [SPARK-31869][SQL] BroadcastHashJoinExec can utilize the build side for its output partitioning

2020-06-30 Thread GitBox
maropu commented on a change in pull request #28676: URL: https://github.com/apache/spark/pull/28676#discussion_r448120574 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoinExec.scala ## @@ -60,6 +60,26 @@ case class BroadcastHashJoinE

[GitHub] [spark] SparkQA commented on pull request #28953: [SPARK-32013][SQL] Support query execution before/after reading/writing DataFrame over JDBC

2020-06-30 Thread GitBox
SparkQA commented on pull request #28953: URL: https://github.com/apache/spark/pull/28953#issuecomment-652196837 **[Test build #124745 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124745/testReport)** for PR 28953 at commit [`0db0376`](https://github.com

[GitHub] [spark] HyukjinKwon commented on pull request #28955: [SPARK-32142][SQL][TESTS] Keep the original tests and codes to avoid potential conflicts in dev

2020-06-30 Thread GitBox
HyukjinKwon commented on pull request #28955: URL: https://github.com/apache/spark/pull/28955#issuecomment-652196123 Thank you guys. Merged to master and branch-3.0. This is an automated message from the Apache Git Service. T

[GitHub] [spark] HyukjinKwon closed pull request #28955: [SPARK-32142][SQL][TESTS] Keep the original tests and codes to avoid potential conflicts in dev

2020-06-30 Thread GitBox
HyukjinKwon closed pull request #28955: URL: https://github.com/apache/spark/pull/28955 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28953: [SPARK-32013][SQL] Support query execution before/after reading/writing DataFrame over JDBC

2020-06-30 Thread GitBox
AmplabJenkins removed a comment on pull request #28953: URL: https://github.com/apache/spark/pull/28953#issuecomment-652195101 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28953: [SPARK-32013][SQL] Support query execution before/after reading/writing DataFrame over JDBC

2020-06-30 Thread GitBox
AmplabJenkins commented on pull request #28953: URL: https://github.com/apache/spark/pull/28953#issuecomment-652195101 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] sarutak edited a comment on pull request #28803: [SPARK-31971][WEBUI] Add pagination support for all jobs timeline

2020-06-30 Thread GitBox
sarutak edited a comment on pull request #28803: URL: https://github.com/apache/spark/pull/28803#issuecomment-652154162 Hi @gengliangwang, shall we restart discussion? This is an automated message from the Apache Git Service.

[GitHub] [spark] AmplabJenkins commented on pull request #28955: [SPARK-32142][SQL][TESTS] Keep the original tests and codes to avoid potential conflicts in dev

2020-06-30 Thread GitBox
AmplabJenkins commented on pull request #28955: URL: https://github.com/apache/spark/pull/28955#issuecomment-652193469 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28955: [SPARK-32142][SQL][TESTS] Keep the original tests and codes to avoid potential conflicts in dev

2020-06-30 Thread GitBox
AmplabJenkins removed a comment on pull request #28955: URL: https://github.com/apache/spark/pull/28955#issuecomment-652193469 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #28955: [SPARK-32142][SQL][TESTS] Keep the original tests and codes to avoid potential conflicts in dev

2020-06-30 Thread GitBox
SparkQA commented on pull request #28955: URL: https://github.com/apache/spark/pull/28955#issuecomment-652192426 **[Test build #124700 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124700/testReport)** for PR 28955 at commit [`7a36dd3`](https://github.co

[GitHub] [spark] SparkQA removed a comment on pull request #28955: [SPARK-32142][SQL][TESTS] Keep the original tests and codes to avoid potential conflicts in dev

2020-06-30 Thread GitBox
SparkQA removed a comment on pull request #28955: URL: https://github.com/apache/spark/pull/28955#issuecomment-652101599 **[Test build #124700 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124700/testReport)** for PR 28955 at commit [`7a36dd3`](https://gi

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28956: [SPARK-31797][SQL][FOLLOWUP] TIMESTAMP_SECONDS supports fractional input

2020-06-30 Thread GitBox
dongjoon-hyun commented on a change in pull request #28956: URL: https://github.com/apache/spark/pull/28956#discussion_r448115259 ## File path: sql/core/src/test/resources/sql-tests/inputs/datetime.sql ## @@ -2,13 +2,16 @@ -- [SPARK-31710] TIMESTAMP_SECONDS, TIMESTAMP_MILLIS

[GitHub] [spark] cloud-fan commented on a change in pull request #28833: [SPARK-20680][SQL] Spark-sql do not support for creating table with void column datatype

2020-06-30 Thread GitBox
cloud-fan commented on a change in pull request #28833: URL: https://github.com/apache/spark/pull/28833#discussion_r448115666 ## File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala ## @@ -2309,6 +2309,108 @@ class HiveDDLSuite } }

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28956: [SPARK-31797][SQL][FOLLOWUP] TIMESTAMP_SECONDS supports fractional input

2020-06-30 Thread GitBox
dongjoon-hyun commented on a change in pull request #28956: URL: https://github.com/apache/spark/pull/28956#discussion_r448115408 ## File path: sql/core/src/test/resources/sql-tests/inputs/datetime.sql ## @@ -2,13 +2,16 @@ -- [SPARK-31710] TIMESTAMP_SECONDS, TIMESTAMP_MILLIS

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28956: [SPARK-31797][SQL][FOLLOWUP] TIMESTAMP_SECONDS supports fractional input

2020-06-30 Thread GitBox
dongjoon-hyun commented on a change in pull request #28956: URL: https://github.com/apache/spark/pull/28956#discussion_r448115259 ## File path: sql/core/src/test/resources/sql-tests/inputs/datetime.sql ## @@ -2,13 +2,16 @@ -- [SPARK-31710] TIMESTAMP_SECONDS, TIMESTAMP_MILLIS

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28956: [SPARK-31797][SQL][FOLLOWUP] TIMESTAMP_SECONDS supports fractional input

2020-06-30 Thread GitBox
dongjoon-hyun commented on a change in pull request #28956: URL: https://github.com/apache/spark/pull/28956#discussion_r448114383 ## File path: sql/core/src/test/resources/sql-tests/inputs/datetime.sql ## @@ -2,13 +2,16 @@ -- [SPARK-31710] TIMESTAMP_SECONDS, TIMESTAMP_MILLIS

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28940: [SPARK-32121][SHUFFLE] Support Windows OS in ExecutorDiskUtils

2020-06-30 Thread GitBox
AmplabJenkins removed a comment on pull request #28940: URL: https://github.com/apache/spark/pull/28940#issuecomment-652188385 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28940: [SPARK-32121][SHUFFLE] Support Windows OS in ExecutorDiskUtils

2020-06-30 Thread GitBox
AmplabJenkins commented on pull request #28940: URL: https://github.com/apache/spark/pull/28940#issuecomment-652188378 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #28940: [SPARK-32121][SHUFFLE] Support Windows OS in ExecutorDiskUtils

2020-06-30 Thread GitBox
SparkQA commented on pull request #28940: URL: https://github.com/apache/spark/pull/28940#issuecomment-652188033 **[Test build #124744 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124744/testReport)** for PR 28940 at commit [`a80bd6c`](https://github.com

[GitHub] [spark] pan3793 commented on a change in pull request #28940: [SPARK-32121][SHUFFLE] Support Windows OS in ExecutorDiskUtils

2020-06-30 Thread GitBox
pan3793 commented on a change in pull request #28940: URL: https://github.com/apache/spark/pull/28940#discussion_r448112801 ## File path: common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExecutorDiskUtils.java ## @@ -50,14 +58,18 @@ public static File getF

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28942: [SPARK-32125][UI] Support get taskList by status in Web UI and SHS Rest API

2020-06-30 Thread GitBox
AmplabJenkins removed a comment on pull request #28942: URL: https://github.com/apache/spark/pull/28942#issuecomment-652186162 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124

[GitHub] [spark] cloud-fan commented on a change in pull request #28833: [SPARK-20680][SQL] Spark-sql do not support for creating table with void column datatype

2020-06-30 Thread GitBox
cloud-fan commented on a change in pull request #28833: URL: https://github.com/apache/spark/pull/28833#discussion_r448111898 ## File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala ## @@ -2309,6 +2309,108 @@ class HiveDDLSuite } }

[GitHub] [spark] cloud-fan commented on a change in pull request #28833: [SPARK-20680][SQL] Spark-sql do not support for creating table with void column datatype

2020-06-30 Thread GitBox
cloud-fan commented on a change in pull request #28833: URL: https://github.com/apache/spark/pull/28833#discussion_r448111771 ## File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala ## @@ -2309,6 +2309,108 @@ class HiveDDLSuite } }

  1   2   3   4   5   6   7   8   9   >