[GitHub] [spark] AmplabJenkins removed a comment on pull request #28761: [SPARK-25557][SQL] Nested column predicate pushdown for ORC

2020-08-06 Thread GitBox
AmplabJenkins removed a comment on pull request #28761: URL: https://github.com/apache/spark/pull/28761#issuecomment-670341337 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28761: [SPARK-25557][SQL] Nested column predicate pushdown for ORC

2020-08-06 Thread GitBox
AmplabJenkins commented on pull request #28761: URL: https://github.com/apache/spark/pull/28761#issuecomment-670341337 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] viirya commented on a change in pull request #29349: [SPARK-32528][SQL][TEST] The analyze method should make sure the plan is analyzed

2020-08-06 Thread GitBox
viirya commented on a change in pull request #29349: URL: https://github.com/apache/spark/pull/29349#discussion_r466836729 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/FilterPushdownSuite.scala ## @@ -1149,75 +1149,60 @@ class

[GitHub] [spark] SparkQA commented on pull request #29370: [SPARK-32526][SQL]Pass DataSourceV2AnalysisBaseSuite and TreeNodeSuite related test cases in scala 2.13

2020-08-06 Thread GitBox
SparkQA commented on pull request #29370: URL: https://github.com/apache/spark/pull/29370#issuecomment-670340921 **[Test build #127179 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127179/testReport)** for PR 29370 at commit

[GitHub] [spark] SparkQA commented on pull request #28761: [SPARK-25557][SQL] Nested column predicate pushdown for ORC

2020-08-06 Thread GitBox
SparkQA commented on pull request #28761: URL: https://github.com/apache/spark/pull/28761#issuecomment-670340959 **[Test build #127180 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127180/testReport)** for PR 28761 at commit

[GitHub] [spark] dongjoon-hyun commented on pull request #29352: [SPARK-32531][SQL][TEST] Add benchmarks for nested structs and arrays for different file formats

2020-08-06 Thread GitBox
dongjoon-hyun commented on pull request #29352: URL: https://github.com/apache/spark/pull/29352#issuecomment-670340881 Thank you for your first contribution, @msamirkhan ! This is an automated message from the Apache Git

[GitHub] [spark] cloud-fan commented on a change in pull request #29328: [SPARK-32516][SQL] 'path' option cannot co-exist with load()'s path parameters

2020-08-06 Thread GitBox
cloud-fan commented on a change in pull request #29328: URL: https://github.com/apache/spark/pull/29328#discussion_r466836253 ## File path: sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala ## @@ -229,6 +229,7 @@ class DataFrameReader

[GitHub] [spark] viirya commented on pull request #29328: [SPARK-32516][SQL] 'path' option cannot co-exist with load()'s path parameters

2020-08-06 Thread GitBox
viirya commented on pull request #29328: URL: https://github.com/apache/spark/pull/29328#issuecomment-670340337 Btw, could this be a breaking change? If existing query already use `spark.read.option("path", "...").format("parquet").load("...")`, this will break the query, right?

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29353: [SPARK-32532][SQL] Improve ORC read/write performance on nested structs and array of structs

2020-08-06 Thread GitBox
dongjoon-hyun commented on a change in pull request #29353: URL: https://github.com/apache/spark/pull/29353#discussion_r466835600 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcSerializer.scala ## @@ -27,12 +27,19 @@ import

[GitHub] [spark] imback82 commented on a change in pull request #29328: [SPARK-32516][SQL] 'path' option cannot co-exist with load()'s path parameters

2020-08-06 Thread GitBox
imback82 commented on a change in pull request #29328: URL: https://github.com/apache/spark/pull/29328#discussion_r466835388 ## File path: sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala ## @@ -229,7 +229,7 @@ class DataFrameReader private[sql](sparkSession:

[GitHub] [spark] viirya commented on pull request #28761: [SPARK-25557][SQL] Nested column predicate pushdown for ORC

2020-08-06 Thread GitBox
viirya commented on pull request #28761: URL: https://github.com/apache/spark/pull/28761#issuecomment-670339615 Thanks @dongjoon-hyun for the review. Except for https://github.com/apache/spark/pull/28761#discussion_r466710704, I think all other comments were addressed. I will add test

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29370: [SPARK-32526][SQL]Pass DataSourceV2AnalysisBaseSuite and TreeNodeSuite related test cases in scala 2.13

2020-08-06 Thread GitBox
AmplabJenkins removed a comment on pull request #29370: URL: https://github.com/apache/spark/pull/29370#issuecomment-670339108 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29370: [SPARK-32526][SQL]Pass DataSourceV2AnalysisBaseSuite and TreeNodeSuite related test cases in scala 2.13

2020-08-06 Thread GitBox
AmplabJenkins commented on pull request #29370: URL: https://github.com/apache/spark/pull/29370#issuecomment-670339108 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29370: [SPARK-32526][SQL]Pass DataSourceV2AnalysisBaseSuite and TreeNodeSuite related test cases in scala 2.13

2020-08-06 Thread GitBox
AmplabJenkins removed a comment on pull request #29370: URL: https://github.com/apache/spark/pull/29370#issuecomment-669699869 Can one of the admins verify this patch? This is an automated message from the Apache Git

[GitHub] [spark] SparkQA commented on pull request #29360: [SPARK-32542][SQL]Add a Batch in Optimizer to improve performance in multidimensional analysis

2020-08-06 Thread GitBox
SparkQA commented on pull request #29360: URL: https://github.com/apache/spark/pull/29360#issuecomment-670338755 **[Test build #127178 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127178/testReport)** for PR 29360 at commit

[GitHub] [spark] dongjoon-hyun commented on pull request #29370: [SPARK-32526][SQL]Pass DataSourceV2AnalysisBaseSuite and TreeNodeSuite related test cases in scala 2.13

2020-08-06 Thread GitBox
dongjoon-hyun commented on pull request #29370: URL: https://github.com/apache/spark/pull/29370#issuecomment-670338662 ok to test This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] dongjoon-hyun edited a comment on pull request #29066: [WIP][SPARK-23889] DataSourceV2: required sorting and clustering for writes

2020-08-06 Thread GitBox
dongjoon-hyun edited a comment on pull request #29066: URL: https://github.com/apache/spark/pull/29066#issuecomment-670338157 Hi, @aokolnychyi . I know that you've been waiting for a long time in WIP status. How do you want to proceed this proposal? - Is there any updates from your

[GitHub] [spark] dongjoon-hyun commented on pull request #29066: [WIP][SPARK-23889] DataSourceV2: required sorting and clustering for writes

2020-08-06 Thread GitBox
dongjoon-hyun commented on pull request #29066: URL: https://github.com/apache/spark/pull/29066#issuecomment-670338157 Hi, @aokolnychyi . I know that you've been waiting for a long time in WIP status. How do you want to proceed this proposal? Is there any updates from your side?

[GitHub] [spark] ScrapCodes commented on pull request #29371: [SPARK-32556][INFRA][2.4] Fix release script to URL encode the user provided passwords.

2020-08-06 Thread GitBox
ScrapCodes commented on pull request #29371: URL: https://github.com/apache/spark/pull/29371#issuecomment-670338237 @HyukjinKwon @dongjoon-hyun Thank you for taking a look, somehow I have made the RC1 for voting available already. So, it can be merged, now. Or I should say, Merging it

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29360: [SPARK-32542][SQL]Add a Batch in Optimizer to improve performance in multidimensional analysis

2020-08-06 Thread GitBox
AmplabJenkins removed a comment on pull request #29360: URL: https://github.com/apache/spark/pull/29360#issuecomment-670336836 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29360: [SPARK-32542][SQL]Add a Batch in Optimizer to improve performance in multidimensional analysis

2020-08-06 Thread GitBox
AmplabJenkins commented on pull request #29360: URL: https://github.com/apache/spark/pull/29360#issuecomment-670336836 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28761: [SPARK-25557][SQL] Nested column predicate pushdown for ORC

2020-08-06 Thread GitBox
dongjoon-hyun commented on a change in pull request #28761: URL: https://github.com/apache/spark/pull/28761#discussion_r466831167 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcFiltersBase.scala ## @@ -37,12 +40,44 @@ trait

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29360: [SPARK-32542][SQL]Add a Batch in Optimizer to improve performance in multidimensional analysis

2020-08-06 Thread GitBox
AmplabJenkins removed a comment on pull request #29360: URL: https://github.com/apache/spark/pull/29360#issuecomment-670334933 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA removed a comment on pull request #29360: [SPARK-32542][SQL]Add a Batch in Optimizer to improve performance in multidimensional analysis

2020-08-06 Thread GitBox
SparkQA removed a comment on pull request #29360: URL: https://github.com/apache/spark/pull/29360#issuecomment-670334251 **[Test build #127177 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127177/testReport)** for PR 29360 at commit

[GitHub] [spark] viirya commented on a change in pull request #28761: [SPARK-25557][SQL] Nested column predicate pushdown for ORC

2020-08-06 Thread GitBox
viirya commented on a change in pull request #28761: URL: https://github.com/apache/spark/pull/28761#discussion_r466830881 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcFiltersBase.scala ## @@ -37,12 +40,44 @@ trait OrcFiltersBase {

[GitHub] [spark] SparkQA commented on pull request #29360: [SPARK-32542][SQL]Add a Batch in Optimizer to improve performance in multidimensional analysis

2020-08-06 Thread GitBox
SparkQA commented on pull request #29360: URL: https://github.com/apache/spark/pull/29360#issuecomment-670334913 **[Test build #127177 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127177/testReport)** for PR 29360 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29360: [SPARK-32542][SQL]Add a Batch in Optimizer to improve performance in multidimensional analysis

2020-08-06 Thread GitBox
AmplabJenkins removed a comment on pull request #29360: URL: https://github.com/apache/spark/pull/29360#issuecomment-670334926 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] viirya commented on a change in pull request #29328: [SPARK-32516][SQL] 'path' option cannot co-exist with load()'s path parameters

2020-08-06 Thread GitBox
viirya commented on a change in pull request #29328: URL: https://github.com/apache/spark/pull/29328#discussion_r466830497 ## File path: sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala ## @@ -229,6 +229,7 @@ class DataFrameReader private[sql](sparkSession:

[GitHub] [spark] AmplabJenkins commented on pull request #29360: [SPARK-32542][SQL]Add a Batch in Optimizer to improve performance in multidimensional analysis

2020-08-06 Thread GitBox
AmplabJenkins commented on pull request #29360: URL: https://github.com/apache/spark/pull/29360#issuecomment-670334926 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29360: [SPARK-32542][SQL]Add a Batch in Optimizer to improve performance in multidimensional analysis

2020-08-06 Thread GitBox
AmplabJenkins removed a comment on pull request #29360: URL: https://github.com/apache/spark/pull/29360#issuecomment-670334551 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29360: [SPARK-32542][SQL]Add a Batch in Optimizer to improve performance in multidimensional analysis

2020-08-06 Thread GitBox
AmplabJenkins commented on pull request #29360: URL: https://github.com/apache/spark/pull/29360#issuecomment-670334551 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #29360: [SPARK-32542][SQL]Add a Batch in Optimizer to improve performance in multidimensional analysis

2020-08-06 Thread GitBox
SparkQA commented on pull request #29360: URL: https://github.com/apache/spark/pull/29360#issuecomment-670334251 **[Test build #127177 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127177/testReport)** for PR 29360 at commit

[GitHub] [spark] HyukjinKwon commented on pull request #29376: [SPARK-32560][SQL]Improve exception message at InsertIntoHiveTable.processInsert

2020-08-06 Thread GitBox
HyukjinKwon commented on pull request #29376: URL: https://github.com/apache/spark/pull/29376#issuecomment-670332896 cc @ScrapCodes and @zhengruifeng. This is very trivial but I cc'ed you guys since RC1 2.4 came out and you guys will probably be keen about the changes coming :-).

[GitHub] [spark] cloud-fan commented on a change in pull request #29328: [SPARK-32516][SQL] 'path' option cannot co-exist with load()'s path parameters

2020-08-06 Thread GitBox
cloud-fan commented on a change in pull request #29328: URL: https://github.com/apache/spark/pull/29328#discussion_r466829121 ## File path: sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala ## @@ -229,7 +229,7 @@ class DataFrameReader

[GitHub] [spark] cloud-fan commented on a change in pull request #29328: [SPARK-32516][SQL] 'path' option cannot co-exist with load()'s path parameters

2020-08-06 Thread GitBox
cloud-fan commented on a change in pull request #29328: URL: https://github.com/apache/spark/pull/29328#discussion_r466829121 ## File path: sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala ## @@ -229,7 +229,7 @@ class DataFrameReader

[GitHub] [spark] HyukjinKwon commented on pull request #29376: [SPARK-32560][SQL]Improve exception message at InsertIntoHiveTable.processInsert

2020-08-06 Thread GitBox
HyukjinKwon commented on pull request #29376: URL: https://github.com/apache/spark/pull/29376#issuecomment-670331488 Merged to master, branch-3.0 and branch-2.4. This is an automated message from the Apache Git Service. To

[GitHub] [spark] HyukjinKwon commented on pull request #29376: [SPARK-32560][SQL]Improve exception message at InsertIntoHiveTable.processInsert

2020-08-06 Thread GitBox
HyukjinKwon commented on pull request #29376: URL: https://github.com/apache/spark/pull/29376#issuecomment-670330913 The tests passed at https://github.com/apache/spark/pull/29376#issuecomment-670320905. This is an

[GitHub] [spark] HyukjinKwon closed pull request #29376: [SPARK-32560][SQL]Improve exception message at InsertIntoHiveTable.processInsert

2020-08-06 Thread GitBox
HyukjinKwon closed pull request #29376: URL: https://github.com/apache/spark/pull/29376 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28761: [SPARK-25557][SQL] Nested column predicate pushdown for ORC

2020-08-06 Thread GitBox
dongjoon-hyun commented on a change in pull request #28761: URL: https://github.com/apache/spark/pull/28761#discussion_r466828786 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcFiltersBase.scala ## @@ -37,12 +40,44 @@ trait

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28761: [SPARK-25557][SQL] Nested column predicate pushdown for ORC

2020-08-06 Thread GitBox
dongjoon-hyun commented on a change in pull request #28761: URL: https://github.com/apache/spark/pull/28761#discussion_r466828593 ## File path: sql/core/v2.3/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcFilterSuite.scala ## @@ -93,155 +92,200 @@ class

[GitHub] [spark] AmplabJenkins commented on pull request #29359: [SPARK-32537][SQL][TEST] Add a CTEHintSuite for test coverage

2020-08-06 Thread GitBox
AmplabJenkins commented on pull request #29359: URL: https://github.com/apache/spark/pull/29359#issuecomment-670329485 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29359: [SPARK-32537][SQL][TEST] Add a CTEHintSuite for test coverage

2020-08-06 Thread GitBox
AmplabJenkins removed a comment on pull request #29359: URL: https://github.com/apache/spark/pull/29359#issuecomment-670329485 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] cloud-fan commented on pull request #29349: [SPARK-32528][SQL][TEST] The analyze method should make sure the plan is analyzed

2020-08-06 Thread GitBox
cloud-fan commented on pull request #29349: URL: https://github.com/apache/spark/pull/29349#issuecomment-670329370 It's ready for review. @viirya @maropu @dongjoon-hyun This is an automated message from the Apache Git

[GitHub] [spark] SparkQA commented on pull request #29359: [SPARK-32537][SQL][TEST] Add a CTEHintSuite for test coverage

2020-08-06 Thread GitBox
SparkQA commented on pull request #29359: URL: https://github.com/apache/spark/pull/29359#issuecomment-670329082 **[Test build #127176 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127176/testReport)** for PR 29359 at commit

[GitHub] [spark] LantaoJin commented on a change in pull request #29359: [SPARK-32537][SQL][TEST] Add a CTEHintSuite for test coverage

2020-08-06 Thread GitBox
LantaoJin commented on a change in pull request #29359: URL: https://github.com/apache/spark/pull/29359#discussion_r466827455 ## File path: sql/core/src/test/scala/org/apache/spark/sql/CTEHintSuite.scala ## @@ -0,0 +1,178 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [spark] LantaoJin commented on a change in pull request #29359: [SPARK-32537][SQL][TEST] Add a CTEHintSuite for test coverage

2020-08-06 Thread GitBox
LantaoJin commented on a change in pull request #29359: URL: https://github.com/apache/spark/pull/29359#discussion_r466824955 ## File path: sql/core/src/test/scala/org/apache/spark/sql/CTEHintSuite.scala ## @@ -0,0 +1,178 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [spark] imback82 commented on a change in pull request #29328: [SPARK-32516][SQL] 'path' option cannot co-exist with load()'s path parameters

2020-08-06 Thread GitBox
imback82 commented on a change in pull request #29328: URL: https://github.com/apache/spark/pull/29328#discussion_r466824972 ## File path: sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala ## @@ -229,7 +229,7 @@ class DataFrameReader private[sql](sparkSession:

[GitHub] [spark] cloud-fan commented on pull request #29375: [SPARK-32559][SQL]Fix the trim logic in UTF8String.toInt/toLong did't handle non-ASCII characters correctly

2020-08-06 Thread GitBox
cloud-fan commented on pull request #29375: URL: https://github.com/apache/spark/pull/29375#issuecomment-670322771 thanks, merging to master! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] cloud-fan commented on pull request #29375: [SPARK-32559][SQL]Fix the trim logic in UTF8String.toInt/toLong did't handle non-ASCII characters correctly

2020-08-06 Thread GitBox
cloud-fan commented on pull request #29375: URL: https://github.com/apache/spark/pull/29375#issuecomment-670322909 @WangGuangxin can you open a backport PR for 3.0? This is an automated message from the Apache Git Service.

[GitHub] [spark] cloud-fan closed pull request #29375: [SPARK-32559][SQL]Fix the trim logic in UTF8String.toInt/toLong did't handle non-ASCII characters correctly

2020-08-06 Thread GitBox
cloud-fan closed pull request #29375: URL: https://github.com/apache/spark/pull/29375 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29376: [SPARK-32560][SQL]Improve exception message

2020-08-06 Thread GitBox
AmplabJenkins removed a comment on pull request #29376: URL: https://github.com/apache/spark/pull/29376#issuecomment-670321413 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29376: [SPARK-32560][SQL]Improve exception message

2020-08-06 Thread GitBox
AmplabJenkins commented on pull request #29376: URL: https://github.com/apache/spark/pull/29376#issuecomment-670321413 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] cloud-fan commented on pull request #29125: [SPARK-32018][SQL][3.0] UnsafeRow.setDecimal should set null with overflowed value

2020-08-06 Thread GitBox
cloud-fan commented on pull request #29125: URL: https://github.com/apache/spark/pull/29125#issuecomment-670321237 OK let me clarify a few things: 1. I agree with you that making Spark more likely to return incorrect results is not acceptable. 2. I hope you understand that having a

[GitHub] [spark] SparkQA removed a comment on pull request #29376: [SPARK-32560][SQL]Improve exception message

2020-08-06 Thread GitBox
SparkQA removed a comment on pull request #29376: URL: https://github.com/apache/spark/pull/29376#issuecomment-670291453 **[Test build #127168 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127168/testReport)** for PR 29376 at commit

[GitHub] [spark] SparkQA commented on pull request #29376: [SPARK-32560][SQL]Improve exception message

2020-08-06 Thread GitBox
SparkQA commented on pull request #29376: URL: https://github.com/apache/spark/pull/29376#issuecomment-670320987 **[Test build #127175 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127175/testReport)** for PR 29376 at commit

[GitHub] [spark] SparkQA commented on pull request #29376: [SPARK-32560][SQL]Improve exception message

2020-08-06 Thread GitBox
SparkQA commented on pull request #29376: URL: https://github.com/apache/spark/pull/29376#issuecomment-670320905 **[Test build #127168 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127168/testReport)** for PR 29376 at commit

[GitHub] [spark] cloud-fan commented on a change in pull request #29328: [SPARK-32516][SQL] 'path' option cannot co-exist with load()'s path parameters

2020-08-06 Thread GitBox
cloud-fan commented on a change in pull request #29328: URL: https://github.com/apache/spark/pull/29328#discussion_r466818655 ## File path: sql/core/src/test/scala/org/apache/spark/sql/test/DataFrameReaderWriterSuite.scala ## @@ -224,15 +224,15 @@ class

[GitHub] [spark] AmplabJenkins commented on pull request #29376: [SPARK-32560][SQL]Improve exception message

2020-08-06 Thread GitBox
AmplabJenkins commented on pull request #29376: URL: https://github.com/apache/spark/pull/29376#issuecomment-670319479 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29376: [SPARK-32560][SQL]Improve exception message

2020-08-06 Thread GitBox
AmplabJenkins removed a comment on pull request #29376: URL: https://github.com/apache/spark/pull/29376#issuecomment-670319479 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] cloud-fan commented on a change in pull request #29328: [SPARK-32516][SQL] 'path' option cannot co-exist with load()'s path parameters

2020-08-06 Thread GitBox
cloud-fan commented on a change in pull request #29328: URL: https://github.com/apache/spark/pull/29328#discussion_r466818465 ## File path: sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala ## @@ -229,7 +229,7 @@ class DataFrameReader

[GitHub] [spark] cloud-fan commented on pull request #29137: [SPARK-32337][SQL] Show initial plan in AQE plan tree string

2020-08-06 Thread GitBox
cloud-fan commented on pull request #29137: URL: https://github.com/apache/spark/pull/29137#issuecomment-670315562 The PR itself LGTM. Can we highlight the difference between `Current Plan` and `Final Plan` in the PR description? This is an important information of the AQE query plan.

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29368: [SPARK-32554][K8S][DOCS] Update the k8s document according to the current development status

2020-08-06 Thread GitBox
AmplabJenkins removed a comment on pull request #29368: URL: https://github.com/apache/spark/pull/29368#issuecomment-670309894 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29368: [SPARK-32554][K8S][DOCS] Update the k8s document according to the current development status

2020-08-06 Thread GitBox
AmplabJenkins commented on pull request #29368: URL: https://github.com/apache/spark/pull/29368#issuecomment-670309894 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #29368: [SPARK-32554][K8S][DOCS] Update the k8s document according to the current development status

2020-08-06 Thread GitBox
SparkQA commented on pull request #29368: URL: https://github.com/apache/spark/pull/29368#issuecomment-670309888 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/31792/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29031: [SPARK-32216][SQL] Remove redundant ProjectExec

2020-08-06 Thread GitBox
AmplabJenkins removed a comment on pull request #29031: URL: https://github.com/apache/spark/pull/29031#issuecomment-670309030 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29031: [SPARK-32216][SQL] Remove redundant ProjectExec

2020-08-06 Thread GitBox
AmplabJenkins commented on pull request #29031: URL: https://github.com/apache/spark/pull/29031#issuecomment-670309030 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #29031: [SPARK-32216][SQL] Remove redundant ProjectExec

2020-08-06 Thread GitBox
SparkQA removed a comment on pull request #29031: URL: https://github.com/apache/spark/pull/29031#issuecomment-670242001 **[Test build #127159 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127159/testReport)** for PR 29031 at commit

[GitHub] [spark] SparkQA commented on pull request #29031: [SPARK-32216][SQL] Remove redundant ProjectExec

2020-08-06 Thread GitBox
SparkQA commented on pull request #29031: URL: https://github.com/apache/spark/pull/29031#issuecomment-670308413 **[Test build #127159 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127159/testReport)** for PR 29031 at commit

[GitHub] [spark] SparkQA commented on pull request #29368: [SPARK-32554][K8S][DOCS] Update the k8s document according to the current development status

2020-08-06 Thread GitBox
SparkQA commented on pull request #29368: URL: https://github.com/apache/spark/pull/29368#issuecomment-670305440 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/31792/

[GitHub] [spark] HeartSaVioR closed pull request #28611: [DO-NOT-MERGE][SPARK-XXXXX][SQL] Count only R/W (getter/setter) properties as columns for Java Beans

2020-08-06 Thread GitBox
HeartSaVioR closed pull request #28611: URL: https://github.com/apache/spark/pull/28611 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [spark] HeartSaVioR closed pull request #29011: [WIP][SPARK-XXXXX][SQL] Parallelize HashAggregationQueryWithControlledFallbackSuite

2020-08-06 Thread GitBox
HeartSaVioR closed pull request #29011: URL: https://github.com/apache/spark/pull/29011 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29339: [Spark-32512][SQL] add alter table add/drop partition command for datasourcev2

2020-08-06 Thread GitBox
AmplabJenkins removed a comment on pull request #29339: URL: https://github.com/apache/spark/pull/29339#issuecomment-670303671 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29376: [SPARK-32560][SQL]Improve exception message

2020-08-06 Thread GitBox
AmplabJenkins commented on pull request #29376: URL: https://github.com/apache/spark/pull/29376#issuecomment-670303752 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29376: [SPARK-32560][SQL]Improve exception message

2020-08-06 Thread GitBox
AmplabJenkins removed a comment on pull request #29376: URL: https://github.com/apache/spark/pull/29376#issuecomment-670303752 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29339: [Spark-32512][SQL] add alter table add/drop partition command for datasourcev2

2020-08-06 Thread GitBox
AmplabJenkins commented on pull request #29339: URL: https://github.com/apache/spark/pull/29339#issuecomment-670303671 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #29339: [Spark-32512][SQL] add alter table add/drop partition command for datasourcev2

2020-08-06 Thread GitBox
SparkQA commented on pull request #29339: URL: https://github.com/apache/spark/pull/29339#issuecomment-670303402 **[Test build #127174 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127174/testReport)** for PR 29339 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #29376: [SPARK-32560][SQL]Improve exception message

2020-08-06 Thread GitBox
SparkQA removed a comment on pull request #29376: URL: https://github.com/apache/spark/pull/29376#issuecomment-670271926 **[Test build #127162 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127162/testReport)** for PR 29376 at commit

[GitHub] [spark] SparkQA commented on pull request #29376: [SPARK-32560][SQL]Improve exception message

2020-08-06 Thread GitBox
SparkQA commented on pull request #29376: URL: https://github.com/apache/spark/pull/29376#issuecomment-670303325 **[Test build #127162 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127162/testReport)** for PR 29376 at commit

[GitHub] [spark] maropu edited a comment on pull request #29356: [SPARK-32538][CORE][TEST] Use local time zone for the timestamp logged in unit-tests.log

2020-08-06 Thread GitBox
maropu edited a comment on pull request #29356: URL: https://github.com/apache/spark/pull/29356#issuecomment-670287074 Thanks! Merged to master/branch-3.0. (NOTE: I manually checked this change could fix the issue) This is

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29371: [SPARK-32556][INFRA][2.4] Fix release script to URL encode the user provided passwords.

2020-08-06 Thread GitBox
AmplabJenkins removed a comment on pull request #29371: URL: https://github.com/apache/spark/pull/29371#issuecomment-670300042 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29371: [SPARK-32556][INFRA][2.4] Fix release script to URL encode the user provided passwords.

2020-08-06 Thread GitBox
AmplabJenkins removed a comment on pull request #29371: URL: https://github.com/apache/spark/pull/29371#issuecomment-670300037 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29368: [SPARK-32554][K8S][DOCS] Update the k8s document according to the current development status

2020-08-06 Thread GitBox
AmplabJenkins removed a comment on pull request #29368: URL: https://github.com/apache/spark/pull/29368#issuecomment-670300193 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA removed a comment on pull request #29371: [SPARK-32556][INFRA][2.4] Fix release script to URL encode the user provided passwords.

2020-08-06 Thread GitBox
SparkQA removed a comment on pull request #29371: URL: https://github.com/apache/spark/pull/29371#issuecomment-670299605 **[Test build #127173 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127173/testReport)** for PR 29371 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #29368: [SPARK-32554][K8S][DOCS] Update the k8s document according to the current development status

2020-08-06 Thread GitBox
SparkQA removed a comment on pull request #29368: URL: https://github.com/apache/spark/pull/29368#issuecomment-670295596 **[Test build #127170 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127170/testReport)** for PR 29368 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29371: [SPARK-32556][INFRA][2.4] Fix release script to URL encode the user provided passwords.

2020-08-06 Thread GitBox
AmplabJenkins removed a comment on pull request #29371: URL: https://github.com/apache/spark/pull/29371#issuecomment-670299895 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29368: [SPARK-32554][K8S][DOCS] Update the k8s document according to the current development status

2020-08-06 Thread GitBox
AmplabJenkins commented on pull request #29368: URL: https://github.com/apache/spark/pull/29368#issuecomment-670300193 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #29371: [SPARK-32556][INFRA][2.4] Fix release script to URL encode the user provided passwords.

2020-08-06 Thread GitBox
SparkQA commented on pull request #29371: URL: https://github.com/apache/spark/pull/29371#issuecomment-670300024 **[Test build #127173 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127173/testReport)** for PR 29371 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29372: [SPARK-32555][SQL] Add unique ID on query execution

2020-08-06 Thread GitBox
AmplabJenkins removed a comment on pull request #29372: URL: https://github.com/apache/spark/pull/29372#issuecomment-670299911 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29371: [SPARK-32556][INFRA][2.4] Fix release script to URL encode the user provided passwords.

2020-08-06 Thread GitBox
AmplabJenkins commented on pull request #29371: URL: https://github.com/apache/spark/pull/29371#issuecomment-670299895 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #29371: [SPARK-32556][INFRA][2.4] Fix release script to URL encode the user provided passwords.

2020-08-06 Thread GitBox
AmplabJenkins commented on pull request #29371: URL: https://github.com/apache/spark/pull/29371#issuecomment-670300037 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #29368: [SPARK-32554][K8S][DOCS] Update the k8s document according to the current development status

2020-08-06 Thread GitBox
SparkQA commented on pull request #29368: URL: https://github.com/apache/spark/pull/29368#issuecomment-670299904 **[Test build #127170 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127170/testReport)** for PR 29368 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #29372: [SPARK-32555][SQL] Add unique ID on query execution

2020-08-06 Thread GitBox
AmplabJenkins commented on pull request #29372: URL: https://github.com/apache/spark/pull/29372#issuecomment-670299911 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #29371: [SPARK-32556][INFRA][2.4] Fix release script to URL encode the user provided passwords.

2020-08-06 Thread GitBox
SparkQA commented on pull request #29371: URL: https://github.com/apache/spark/pull/29371#issuecomment-670299605 **[Test build #127173 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127173/testReport)** for PR 29371 at commit

[GitHub] [spark] SparkQA commented on pull request #29372: [SPARK-32555][SQL] Add unique ID on query execution

2020-08-06 Thread GitBox
SparkQA commented on pull request #29372: URL: https://github.com/apache/spark/pull/29372#issuecomment-670299570 **[Test build #127172 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127172/testReport)** for PR 29372 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29372: [SPARK-32555][SQL] Add unique ID on query execution

2020-08-06 Thread GitBox
AmplabJenkins removed a comment on pull request #29372: URL: https://github.com/apache/spark/pull/29372#issuecomment-670297459 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] HyukjinKwon commented on pull request #29371: [SPARK-32556][INFRA][2.4] Fix release script to URL encode the user provided passwords.

2020-08-06 Thread GitBox
HyukjinKwon commented on pull request #29371: URL: https://github.com/apache/spark/pull/29371#issuecomment-670297776 Since the PR builders don't run the tests related to the changes here, I think it's good to go. This is an

[GitHub] [spark] HyukjinKwon commented on pull request #29371: [SPARK-32556][INFRA][2.4] Fix release script to URL encode the user provided passwords.

2020-08-06 Thread GitBox
HyukjinKwon commented on pull request #29371: URL: https://github.com/apache/spark/pull/29371#issuecomment-670297670 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] SparkQA removed a comment on pull request #29372: [SPARK-32555][SQL] Add unique ID on query execution

2020-08-06 Thread GitBox
SparkQA removed a comment on pull request #29372: URL: https://github.com/apache/spark/pull/29372#issuecomment-670295554 **[Test build #127169 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127169/testReport)** for PR 29372 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29372: [SPARK-32555][SQL] Add unique ID on query execution

2020-08-06 Thread GitBox
AmplabJenkins removed a comment on pull request #29372: URL: https://github.com/apache/spark/pull/29372#issuecomment-670297455 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] SparkQA commented on pull request #29366: [SPARK-32550][SQL] Make SpecificInternalRow constructors faster by using while loops instead of maps

2020-08-06 Thread GitBox
SparkQA commented on pull request #29366: URL: https://github.com/apache/spark/pull/29366#issuecomment-670297510 **[Test build #127171 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127171/testReport)** for PR 29366 at commit

  1   2   3   4   5   6   7   >