AmplabJenkins removed a comment on pull request #30154:
URL: https://github.com/apache/spark/pull/30154#issuecomment-722936128
This is an automated message from the Apache Git Service.
To respond to the message, please log on
SparkQA commented on pull request #30154:
URL: https://github.com/apache/spark/pull/30154#issuecomment-722936114
Kubernetes integration test status success
URL:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35306/
HeartSaVioR commented on pull request #30186:
URL: https://github.com/apache/spark/pull/30186#issuecomment-722936210
Never mind. I tried your Github account and found it. Please let me know if
I misassigned.
This is an
SparkQA commented on pull request #30251:
URL: https://github.com/apache/spark/pull/30251#issuecomment-722936109
**[Test build #130701 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130701/testReport)**
for PR 30251 at commit
AmplabJenkins commented on pull request #30154:
URL: https://github.com/apache/spark/pull/30154#issuecomment-722936128
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
HeartSaVioR commented on pull request #30186:
URL: https://github.com/apache/spark/pull/30186#issuecomment-722935367
Thanks! Merged into master.
@warrenzhu25 Could you please let me know your JIRA ID? I'm not 100% sure so
I left the assignee as unassigned. Once I get the information
dongjoon-hyun commented on a change in pull request #30276:
URL: https://github.com/apache/spark/pull/30276#discussion_r518577972
##
File path:
mllib-local/src/test/scala/org/apache/spark/ml/linalg/MatricesSuite.scala
##
@@ -862,10 +862,10 @@ class MatricesSuite extends
AmplabJenkins removed a comment on pull request #30255:
URL: https://github.com/apache/spark/pull/30255#issuecomment-722934583
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #30255:
URL: https://github.com/apache/spark/pull/30255#issuecomment-722934583
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
HeartSaVioR closed pull request #30186:
URL: https://github.com/apache/spark/pull/30186
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
AmplabJenkins removed a comment on pull request #30276:
URL: https://github.com/apache/spark/pull/30276#issuecomment-722933731
This is an automated message from the Apache Git Service.
To respond to the message, please log on
SparkQA removed a comment on pull request #30255:
URL: https://github.com/apache/spark/pull/30255#issuecomment-722817107
**[Test build #130688 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130688/testReport)**
for PR 30255 at commit
SparkQA commented on pull request #30276:
URL: https://github.com/apache/spark/pull/30276#issuecomment-722933702
Kubernetes integration test status success
URL:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35308/
maropu commented on a change in pull request #30212:
URL: https://github.com/apache/spark/pull/30212#discussion_r518576347
##
File path:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4
##
@@ -587,13 +587,26 @@ fromClause
;
HeartSaVioR commented on pull request #30251:
URL: https://github.com/apache/spark/pull/30251#issuecomment-722933580
retest this, please
This is an automated message from the Apache Git Service.
To respond to the message,
AmplabJenkins commented on pull request #30276:
URL: https://github.com/apache/spark/pull/30276#issuecomment-722933731
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #30255:
URL: https://github.com/apache/spark/pull/30255#issuecomment-722933391
**[Test build #130688 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130688/testReport)**
for PR 30255 at commit
maropu commented on a change in pull request #30276:
URL: https://github.com/apache/spark/pull/30276#discussion_r518573436
##
File path:
mllib-local/src/test/scala/org/apache/spark/ml/linalg/MatricesSuite.scala
##
@@ -862,10 +862,10 @@ class MatricesSuite extends
maropu commented on a change in pull request #30276:
URL: https://github.com/apache/spark/pull/30276#discussion_r518573436
##
File path:
mllib-local/src/test/scala/org/apache/spark/ml/linalg/MatricesSuite.scala
##
@@ -862,10 +862,10 @@ class MatricesSuite extends
viirya commented on a change in pull request #30245:
URL: https://github.com/apache/spark/pull/30245#discussion_r518571332
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/EquivalentExpressions.scala
##
@@ -65,11 +65,46 @@ class
SparkQA commented on pull request #30276:
URL: https://github.com/apache/spark/pull/30276#issuecomment-722929230
Kubernetes integration test starting
URL:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35308/
SparkQA commented on pull request #30154:
URL: https://github.com/apache/spark/pull/30154#issuecomment-722927854
Kubernetes integration test starting
URL:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35306/
maropu commented on a change in pull request #29170:
URL: https://github.com/apache/spark/pull/29170#discussion_r518567508
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
##
@@ -116,7 +116,8 @@ abstract class
SparkQA commented on pull request #30255:
URL: https://github.com/apache/spark/pull/30255#issuecomment-722925083
**[Test build #130700 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130700/testReport)**
for PR 30255 at commit
AmplabJenkins removed a comment on pull request #30222:
URL: https://github.com/apache/spark/pull/30222#issuecomment-722919383
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins removed a comment on pull request #30274:
URL: https://github.com/apache/spark/pull/30274#issuecomment-722920533
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins removed a comment on pull request #30255:
URL: https://github.com/apache/spark/pull/30255#issuecomment-722917895
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins removed a comment on pull request #30275:
URL: https://github.com/apache/spark/pull/30275#issuecomment-722917000
Can one of the admins verify this patch?
This is an automated message from the Apache Git
SparkQA removed a comment on pull request #30255:
URL: https://github.com/apache/spark/pull/30255#issuecomment-722917156
**[Test build #130697 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130697/testReport)**
for PR 30255 at commit
maropu commented on pull request #29170:
URL: https://github.com/apache/spark/pull/29170#issuecomment-722922863
> @navinvishy, @maropu, @cloud-fan, @gatorsmile do you think you can revisit
this PR?
Revisiting this looks fine to me. Are you still here? @navinvishy
SparkQA commented on pull request #30255:
URL: https://github.com/apache/spark/pull/30255#issuecomment-722922482
**[Test build #130699 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130699/testReport)**
for PR 30255 at commit
SparkQA commented on pull request #30276:
URL: https://github.com/apache/spark/pull/30276#issuecomment-722922445
**[Test build #130698 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130698/testReport)**
for PR 30276 at commit
dongjoon-hyun opened a new pull request #30276:
URL: https://github.com/apache/spark/pull/30276
### What changes were proposed in this pull request?
### Why are the changes needed?
### Does this PR introduce _any_ user-facing change?
###
AmplabJenkins commented on pull request #30274:
URL: https://github.com/apache/spark/pull/30274#issuecomment-722920533
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #30274:
URL: https://github.com/apache/spark/pull/30274#issuecomment-722920519
Kubernetes integration test status success
URL:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35305/
AmplabJenkins commented on pull request #30222:
URL: https://github.com/apache/spark/pull/30222#issuecomment-722919383
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #30222:
URL: https://github.com/apache/spark/pull/30222#issuecomment-722919375
Kubernetes integration test status success
URL:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35304/
AmplabJenkins commented on pull request #30255:
URL: https://github.com/apache/spark/pull/30255#issuecomment-722918725
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #30255:
URL: https://github.com/apache/spark/pull/30255#issuecomment-722918708
**[Test build #130697 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130697/testReport)**
for PR 30255 at commit
AmplabJenkins commented on pull request #30255:
URL: https://github.com/apache/spark/pull/30255#issuecomment-722917895
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins commented on pull request #30275:
URL: https://github.com/apache/spark/pull/30275#issuecomment-722917362
Can one of the admins verify this patch?
This is an automated message from the Apache Git Service.
To
SparkQA commented on pull request #30255:
URL: https://github.com/apache/spark/pull/30255#issuecomment-722917156
**[Test build #130697 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130697/testReport)**
for PR 30255 at commit
AmplabJenkins commented on pull request #30275:
URL: https://github.com/apache/spark/pull/30275#issuecomment-722917000
Can one of the admins verify this patch?
This is an automated message from the Apache Git Service.
To
dongjoon-hyun edited a comment on pull request #30275:
URL: https://github.com/apache/spark/pull/30275#issuecomment-722915891
Thank you for your contribution, @huangtianhua . Could you recover the
original PR description style please? Please see a PR like
AmplabJenkins removed a comment on pull request #30270:
URL: https://github.com/apache/spark/pull/30270#issuecomment-722915893
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #30270:
URL: https://github.com/apache/spark/pull/30270#issuecomment-722915893
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
dongjoon-hyun commented on pull request #30275:
URL: https://github.com/apache/spark/pull/30275#issuecomment-722915891
Thank you for your contribution, @huangtianhua . Could you recover the
original PR description style please?
SparkQA commented on pull request #30270:
URL: https://github.com/apache/spark/pull/30270#issuecomment-722915879
Kubernetes integration test status success
URL:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35303/
huangtianhua opened a new pull request #30275:
URL: https://github.com/apache/spark/pull/30275
The package commons-crypto-1.0.0 doesn't support aarch64 platform, it lead
the tests of replication failed due to crypto timeout, bump up to v1.1.0
which
support aarch64.
See:
dongjoon-hyun commented on pull request #30222:
URL: https://github.com/apache/spark/pull/30222#issuecomment-722914471
This seems to fail still.
This is an automated message from the Apache Git Service.
To respond to the
AmplabJenkins removed a comment on pull request #30267:
URL: https://github.com/apache/spark/pull/30267#issuecomment-722914033
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #30267:
URL: https://github.com/apache/spark/pull/30267#issuecomment-722914033
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #30267:
URL: https://github.com/apache/spark/pull/30267#issuecomment-722914004
Kubernetes integration test status success
URL:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35302/
SparkQA commented on pull request #30274:
URL: https://github.com/apache/spark/pull/30274#issuecomment-722911327
Kubernetes integration test starting
URL:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35305/
SparkQA commented on pull request #30154:
URL: https://github.com/apache/spark/pull/30154#issuecomment-722909952
**[Test build #130696 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130696/testReport)**
for PR 30154 at commit
AngersZh commented on pull request #30212:
URL: https://github.com/apache/spark/pull/30212#issuecomment-722909968
gentle ping @maropu @cloud-fan Do you have any suggestion for this one. A
series of PR changes need to be made to accommodate this support
SparkQA commented on pull request #30222:
URL: https://github.com/apache/spark/pull/30222#issuecomment-722909905
Kubernetes integration test starting
URL:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35304/
AngersZh removed a comment on pull request #30212:
URL: https://github.com/apache/spark/pull/30212#issuecomment-721586653
Any suggestion?
This is an automated message from the Apache Git Service.
To respond to the
AngersZh commented on pull request #30145:
URL: https://github.com/apache/spark/pull/30145#issuecomment-722909286
> > Sure, Postgres SQL support this
> > Tera DB support too.
>
> Could you add this info in the PR description?
Yea, later for. a more detail. desc
HyukjinKwon commented on pull request #30242:
URL: https://github.com/apache/spark/pull/30242#issuecomment-722908940
cc @zsxwing too
This is an automated message from the Apache Git Service.
To respond to the message, please
AmplabJenkins removed a comment on pull request #30222:
URL: https://github.com/apache/spark/pull/30222#issuecomment-722907809
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
AmplabJenkins removed a comment on pull request #30222:
URL: https://github.com/apache/spark/pull/30222#issuecomment-722907801
Merged build finished. Test FAILed.
This is an automated message from the Apache Git Service.
To
SparkQA removed a comment on pull request #30222:
URL: https://github.com/apache/spark/pull/30222#issuecomment-722863678
**[Test build #130694 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130694/testReport)**
for PR 30222 at commit
AmplabJenkins commented on pull request #30222:
URL: https://github.com/apache/spark/pull/30222#issuecomment-722907801
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #30222:
URL: https://github.com/apache/spark/pull/30222#issuecomment-722907690
**[Test build #130694 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130694/testReport)**
for PR 30222 at commit
maropu commented on pull request #30145:
URL: https://github.com/apache/spark/pull/30145#issuecomment-722907461
> Sure, Postgres SQL support this
> Tera DB support too.
Could you add this info in the PR description?
maropu commented on pull request #30260:
URL: https://github.com/apache/spark/pull/30260#issuecomment-722906769
Thanks for the request, @gengliangwang ! I'll review this later.
This is an automated message from the Apache
AmplabJenkins removed a comment on pull request #30273:
URL: https://github.com/apache/spark/pull/30273#issuecomment-722906405
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #30273:
URL: https://github.com/apache/spark/pull/30273#issuecomment-722906405
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #30273:
URL: https://github.com/apache/spark/pull/30273#issuecomment-722906390
Kubernetes integration test status success
URL:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35301/
maropu commented on a change in pull request #26319:
URL: https://github.com/apache/spark/pull/26319#discussion_r518551221
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala
##
@@ -543,6 +543,13 @@ object ScalaReflection extends
SparkQA commented on pull request #30270:
URL: https://github.com/apache/spark/pull/30270#issuecomment-722901987
Kubernetes integration test starting
URL:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35303/
otterc commented on a change in pull request #30062:
URL: https://github.com/apache/spark/pull/30062#discussion_r518548353
##
File path:
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/RemoteBlockPushResolver.java
##
@@ -0,0 +1,959 @@
+/*
+ * Licensed to
maropu commented on pull request #30251:
URL: https://github.com/apache/spark/pull/30251#issuecomment-722896647
> What does "binary compatibility check" do? Can you explain it for me
@dongjoon-hyun ? Thx ~
NOTE: Since the MiMa plugin checks binary compatibility, you need to update
SparkQA commented on pull request #30267:
URL: https://github.com/apache/spark/pull/30267#issuecomment-722894610
Kubernetes integration test starting
URL:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35302/
AngersZh edited a comment on pull request #30243:
URL: https://github.com/apache/spark/pull/30243#issuecomment-722892310
> Probably, `arrays_contains(array(1, 2, 3), 2) AND arrays_contains(array(1,
2, 3), 3) `?
First, if `arrays_contains_array(array(1, 2, 3, ), array(1, 2,
AngersZh commented on pull request #30243:
URL: https://github.com/apache/spark/pull/30243#issuecomment-722892310
> Probably, `arrays_contains(array(1, 2, 3), 2) AND arrays_contains(array(1,
2, 3), 3) `?
First, if `arrays_contains_array(array(1, 2, 3, ), array(1, 2, 3, 4,
maropu commented on pull request #30243:
URL: https://github.com/apache/spark/pull/30243#issuecomment-722884428
> ArrayOverlap checks if the two arrays contain at least one common element.
Ah, I see. You need to describe the clear behaivour in the section, too.
Probably,
AngersZh edited a comment on pull request #30243:
URL: https://github.com/apache/spark/pull/30243#issuecomment-722875681
> arrays_overlap(array(1, 2, 3), array(2, 3))?
ArrayOverlap checks if the two arrays contain at least one common element.
> Anyway, I think you need to
SparkQA commented on pull request #30273:
URL: https://github.com/apache/spark/pull/30273#issuecomment-722880326
Kubernetes integration test starting
URL:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35301/
HyukjinKwon commented on a change in pull request #30274:
URL: https://github.com/apache/spark/pull/30274#discussion_r518543627
##
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/Encoders.scala
##
@@ -146,7 +146,8 @@ object Encoders {
* - String
* -
SparkQA commented on pull request #30274:
URL: https://github.com/apache/spark/pull/30274#issuecomment-72281
**[Test build #130695 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130695/testReport)**
for PR 30274 at commit
AngersZh commented on pull request #30243:
URL: https://github.com/apache/spark/pull/30243#issuecomment-722875681
> arrays_overlap(array(1, 2, 3), array(2, 3))?
ArrayOverlap checks if the two arrays contain at least one common element.
> Anyway, I think you need to
AmplabJenkins removed a comment on pull request #30267:
URL: https://github.com/apache/spark/pull/30267#issuecomment-722875102
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #30267:
URL: https://github.com/apache/spark/pull/30267#issuecomment-722875102
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #30267:
URL: https://github.com/apache/spark/pull/30267#issuecomment-722875077
Kubernetes integration test status success
URL:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35300/
imback82 commented on pull request #30267:
URL: https://github.com/apache/spark/pull/30267#issuecomment-722874348
Thanks @dongjoon-hyun / @cloud-fan for the review!
This is an automated message from the Apache Git Service.
AmplabJenkins removed a comment on pull request #30274:
URL: https://github.com/apache/spark/pull/30274#issuecomment-722841479
Can one of the admins verify this patch?
This is an automated message from the Apache Git
HyukjinKwon commented on pull request #30274:
URL: https://github.com/apache/spark/pull/30274#issuecomment-722874048
ok to test
This is an automated message from the Apache Git Service.
To respond to the message, please log
maropu commented on pull request #30243:
URL: https://github.com/apache/spark/pull/30243#issuecomment-722873034
> If we need to judge SELECT _FUNC_(array(1, 2, 3), array(2, 3)) ?
`arrays_overlap(array(1, 2, 3), array(2, 3))`?
Anyway, I think you need to describe more in the
AmplabJenkins removed a comment on pull request #30255:
URL: https://github.com/apache/spark/pull/30255#issuecomment-722869182
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #30255:
URL: https://github.com/apache/spark/pull/30255#issuecomment-722869182
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #30255:
URL: https://github.com/apache/spark/pull/30255#issuecomment-722869169
Kubernetes integration test status success
URL:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35299/
dongjoon-hyun commented on pull request #30267:
URL: https://github.com/apache/spark/pull/30267#issuecomment-722865361
Merged to master. The last two commits are only for comment changes.
This is an automated message from
dongjoon-hyun closed pull request #30267:
URL: https://github.com/apache/spark/pull/30267
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
viirya commented on pull request #21852:
URL: https://github.com/apache/spark/pull/21852#issuecomment-722864515
I agree with @cloud-fan. The `rd` in `CaseWhen` is deterministic already. If
it is embeded in `CaseWhen`, this PR should not remove it.
SparkQA commented on pull request #30222:
URL: https://github.com/apache/spark/pull/30222#issuecomment-722863678
**[Test build #130694 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130694/testReport)**
for PR 30222 at commit
SparkQA commented on pull request #30270:
URL: https://github.com/apache/spark/pull/30270#issuecomment-722863596
**[Test build #130693 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130693/testReport)**
for PR 30270 at commit
cloud-fan commented on a change in pull request #30222:
URL: https://github.com/apache/spark/pull/30222#discussion_r518539170
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
##
@@ -510,6 +510,15 @@ object
wangyum commented on pull request #30222:
URL: https://github.com/apache/spark/pull/30222#issuecomment-722858604
We can reproduce it by:
```scala
spark.sql("CREATE TABLE t(a int, b int, c int) using parquet")
spark.sql(
"""
|SELECT *
| FROM (SELECT CASE
1 - 100 of 793 matches
Mail list logo