Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/6209#discussion_r30467355
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/BLAS.scala ---
@@ -473,13 +473,16 @@ private[spark] object BLAS extends Serializable with
Logging
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/6209#discussion_r30467388
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/BLAS.scala ---
@@ -500,6 +503,55 @@ private[spark] object BLAS extends Serializable with
Logging
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/6209#discussion_r30467395
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/BLAS.scala ---
@@ -500,6 +503,55 @@ private[spark] object BLAS extends Serializable with
Logging
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/6209#discussion_r30467442
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/BLAS.scala ---
@@ -500,6 +503,55 @@ private[spark] object BLAS extends Serializable with
Logging
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/6209#discussion_r30467430
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/BLAS.scala ---
@@ -473,13 +473,16 @@ private[spark] object BLAS extends Serializable with
Logging
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/6209#discussion_r30467448
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/BLAS.scala ---
@@ -500,6 +503,55 @@ private[spark] object BLAS extends Serializable with
Logging
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/6209#discussion_r30467455
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/BLAS.scala ---
@@ -500,6 +503,55 @@ private[spark] object BLAS extends Serializable with
Logging
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/6209#discussion_r30467465
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/BLAS.scala ---
@@ -500,6 +503,55 @@ private[spark] object BLAS extends Serializable with
Logging
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/6209#discussion_r30467474
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/BLAS.scala ---
@@ -500,6 +503,55 @@ private[spark] object BLAS extends Serializable with
Logging
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/6209#discussion_r30472410
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/BLAS.scala ---
@@ -473,44 +473,161 @@ private[spark] object BLAS extends Serializable
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/6209#discussion_r30472444
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/BLAS.scala ---
@@ -473,44 +473,161 @@ private[spark] object BLAS extends Serializable
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/6209#discussion_r30472449
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/BLAS.scala ---
@@ -473,44 +473,161 @@ private[spark] object BLAS extends Serializable
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/6209#discussion_r30472390
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/linalg/BLASSuite.scala ---
@@ -257,32 +257,60 @@ class BLASSuite extends FunSuite {
new
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/6209#discussion_r30472396
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/linalg/BLASSuite.scala ---
@@ -291,7 +319,7 @@ class BLASSuite extends FunSuite {
val dATT
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/6128#discussion_r30271227
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/classification/NaiveBayes.scala ---
@@ -193,7 +191,7 @@ object NaiveBayesModel extends Loader
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/6128#issuecomment-101806762
LGTM. We may refactor it in next round using the aggregator pattern in
LIR/LOR to further avoid creating tuple.
---
If your project is set up for it, you can reply
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/6128#discussion_r30271182
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/classification/NaiveBayes.scala ---
@@ -147,7 +145,7 @@ object NaiveBayesModel extends Loader
GitHub user dbtsai opened a pull request:
https://github.com/apache/spark/pull/6137
[SPARK-7620][ML][MLlib] Removed calling size, length in while condition to
avoid extra JVM call
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/6137#issuecomment-101863897
@zsxwing Unfortunately, scala compiler doesn't do it. Even scala library
does so to avoid another JVM call.
```
def segmentLength(p: A = Boolean, from: Int
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/6209#issuecomment-103112900
LGTM cc: @mengxr @srowen @jkbradley
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/6137#issuecomment-101879949
@zsxwing
We did benchmark in this PR, and actually the performance is different in
the tight loop. JVM just doesn't know if the size will be constant. Also
GitHub user dbtsai opened a pull request:
https://github.com/apache/spark/pull/6109
[SPARK-7568][ML] ml.LogisticRegression doesn't output the right prediction
This is because we regularize the intercept before which effectively
regularizing
less on the weights. Now, we follow
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/6209#discussion_r30483433
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/linalg/BLASSuite.scala ---
@@ -257,32 +257,60 @@ class BLASSuite extends FunSuite {
new
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/6209#discussion_r30484896
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/BLAS.scala ---
@@ -473,44 +473,161 @@ private[spark] object BLAS extends Serializable
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/6209#discussion_r30474398
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/BLAS.scala ---
@@ -473,44 +473,161 @@ private[spark] object BLAS extends Serializable
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/6209#discussion_r30474406
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/BLAS.scala ---
@@ -473,44 +473,161 @@ private[spark] object BLAS extends Serializable
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/6209#discussion_r30474423
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/BLAS.scala ---
@@ -473,44 +473,161 @@ private[spark] object BLAS extends Serializable
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/6209#discussion_r30473141
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/BLAS.scala ---
@@ -473,44 +473,161 @@ private[spark] object BLAS extends Serializable
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/6209#discussion_r30473292
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/BLAS.scala ---
@@ -473,44 +473,161 @@ private[spark] object BLAS extends Serializable
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/6209#discussion_r30473300
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/BLAS.scala ---
@@ -473,44 +473,161 @@ private[spark] object BLAS extends Serializable
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/6209#discussion_r30473306
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/BLAS.scala ---
@@ -473,44 +473,161 @@ private[spark] object BLAS extends Serializable
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/6209#discussion_r30472854
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/BLAS.scala ---
@@ -473,44 +473,161 @@ private[spark] object BLAS extends Serializable
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/6209#discussion_r30473026
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/BLAS.scala ---
@@ -473,44 +473,161 @@ private[spark] object BLAS extends Serializable
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/6209#discussion_r30473011
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/BLAS.scala ---
@@ -473,44 +473,161 @@ private[spark] object BLAS extends Serializable
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/6209#issuecomment-102837804
Finally in `sealed trait Matrix`, change
```
/** Convenience method for `Matrix`-`DenseVector` multiplication. */
def multiply(y: DenseVector): DenseVector
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/6128#discussion_r30276933
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/classification/NaiveBayes.scala ---
@@ -147,7 +145,7 @@ object NaiveBayesModel extends Loader
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/6209#discussion_r30467525
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/BLAS.scala ---
@@ -500,6 +503,55 @@ private[spark] object BLAS extends Serializable with
Logging
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/6209#discussion_r30467658
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/linalg/BLASSuite.scala ---
@@ -270,17 +271,26 @@ class BLASSuite extends FunSuite {
val
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/6209#discussion_r30467514
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/BLAS.scala ---
@@ -500,6 +503,55 @@ private[spark] object BLAS extends Serializable with
Logging
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/6209#discussion_r30467629
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/linalg/BLASSuite.scala ---
@@ -270,17 +271,26 @@ class BLASSuite extends FunSuite {
val
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/6386#issuecomment-110142137
Which scaling factor of 0.1? Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/6386#issuecomment-110216881
Oh, get you.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/6709#issuecomment-110221571
Thanks. Merged in master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/6709#issuecomment-110219781
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/6386#issuecomment-108066634
@holdenk How about I run the benchmark myself this weekend? Also, @mengxr
said it's too late for 1.4, so it will be merged in 1.5.
---
If your project is set up
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/6386#discussion_r31586162
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/classification/LogisticRegression.scala
---
@@ -363,4 +371,54 @@ class LogisticRegressionWithLBFGS
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/6386#discussion_r31581715
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/classification/LogisticRegression.scala
---
@@ -363,4 +371,54 @@ class LogisticRegressionWithLBFGS
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/6386#discussion_r31578786
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -100,8 +100,28 @@ class LogisticRegression(override val uid
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/6576#discussion_r31576746
--- Diff:
examples/src/main/scala/org/apache/spark/examples/ml/LogisticRegressionExample.scala
---
@@ -0,0 +1,160 @@
+/*
+ * Licensed to the Apache
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/6386#discussion_r31578527
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -100,8 +100,28 @@ class LogisticRegression(override val uid
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/6386#discussion_r31580761
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/classification/LogisticRegression.scala
---
@@ -363,4 +371,54 @@ class LogisticRegressionWithLBFGS
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/6386#issuecomment-110480211
haha. or more simply, can you run LogsticRegressionWithLBFGS with/without
the patch and post the run time? Thanks.
---
If your project is set up for it, you can reply
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/6388#discussion_r31874663
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/stat/MultivariateOnlineSummarizer.scala
---
@@ -47,6 +49,39 @@ class MultivariateOnlineSummarizer
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/6388#discussion_r31874716
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/stat/MultivariateOnlineSummarizer.scala
---
@@ -47,6 +49,39 @@ class MultivariateOnlineSummarizer
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/6388#discussion_r31874728
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/stat/MultivariateOnlineSummarizer.scala
---
@@ -47,6 +49,39 @@ class MultivariateOnlineSummarizer
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/6388#discussion_r31874786
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/stat/MultivariateOnlineSummarizer.scala
---
@@ -47,6 +49,39 @@ class MultivariateOnlineSummarizer
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/6388#discussion_r31874711
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/stat/MultivariateOnlineSummarizer.scala
---
@@ -47,6 +49,39 @@ class MultivariateOnlineSummarizer
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/6388#discussion_r31874739
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/stat/MultivariateOnlineSummarizer.scala
---
@@ -47,6 +49,39 @@ class MultivariateOnlineSummarizer
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/6388#discussion_r31874792
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/stat/MultivariateOnlineSummarizer.scala
---
@@ -58,13 +93,13 @@ class MultivariateOnlineSummarizer
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/6927#issuecomment-114621006
Thanks. Merged into master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/6927#discussion_r33000469
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -161,4 +272,34 @@ class LinearRegressionSuite extends
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/6927#discussion_r33000481
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -106,6 +156,37 @@ class LinearRegressionSuite extends
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/6927#discussion_r32903235
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -34,14 +35,20 @@ class LinearRegressionSuite extends
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/6927#discussion_r32902830
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -73,6 +74,15 @@ class LinearRegression(override val uid: String
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/6927#discussion_r32909342
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -34,14 +35,20 @@ class LinearRegressionSuite extends
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/6927#discussion_r32902999
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -34,14 +35,20 @@ class LinearRegressionSuite extends
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/6927#discussion_r32902975
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -133,7 +144,11 @@ class LinearRegression(override val uid: String
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/6927#discussion_r32902955
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -121,8 +131,9 @@ class LinearRegression(override val uid: String
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/6927#discussion_r32903263
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -78,6 +85,49 @@ class LinearRegressionSuite extends
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/6927#issuecomment-114027727
LGTM except minor issues.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/7024#discussion_r33288184
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/param/shared/SharedParamsCodeGen.scala
---
@@ -53,6 +53,7 @@ private[shared] object SharedParamsCodeGen
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/7024#issuecomment-115564492
LGTM. Can you create a subtask in JIRA and update the #? Otherwise, the
merging script will get confused. Also change [MLLIB] to [ML]
---
If your project is set up
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/7024#issuecomment-115571567
Merged into master. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/6946#issuecomment-115050717
This is for LoR, how about LiR? Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/6946#issuecomment-115131705
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/6927#issuecomment-114389143
Although `LeastSquaresAggregator` and `LeastSquaresCostFun` are private,
`MiMa` is not happy about the changes.
```
[error] * method
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/6927#discussion_r33015106
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -34,14 +35,24 @@ class LinearRegressionSuite extends
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/6927#discussion_r33014984
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -78,6 +89,43 @@ class LinearRegressionSuite extends
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/6927#discussion_r33014800
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -26,7 +26,7 @@ import org.apache.spark.Logging
import
Github user dbtsai closed the pull request at:
https://github.com/apache/spark/pull/6045
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/6768#issuecomment-111295649
jenkins please test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/6768#issuecomment-111295754
Ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/6504#issuecomment-111301954
What example do you want to work on? Example in the documentation or in the
example code base?
---
If your project is set up for it, you can reply to this email
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/6768#issuecomment-111296739
add to whitelist
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/6768#issuecomment-111296354
Ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/6768#issuecomment-111400468
jenkins, please test again
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/6768#issuecomment-111640745
test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/5503#issuecomment-111651809
jenkins, please test this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/6339#issuecomment-111651729
This will be useful. But should be have inverse transform api in the parent
class?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/6768#issuecomment-111651422
Merged into master. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/6768#discussion_r32290348
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/util/MLUtils.scala ---
@@ -270,12 +270,28 @@ object MLUtils {
* Returns a new vector with `1.0
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/6768#discussion_r32290408
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/util/MLUtilsSuite.scala ---
@@ -161,10 +161,10 @@ class MLUtilsSuite extends SparkFunSuite
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/6768#discussion_r32290545
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/util/MLUtilsSuite.scala ---
@@ -161,10 +161,10 @@ class MLUtilsSuite extends SparkFunSuite
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/6768#issuecomment-111570856
jenkins, please test again
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/6386#discussion_r31650853
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/classification/LogisticRegression.scala
---
@@ -363,4 +371,79 @@ class LogisticRegressionWithLBFGS
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/6386#issuecomment-106067606
I wonder how much performance impact by doing `toDF`. @mengxr Can you chime
in and comment?
---
If your project is set up for it, you can reply to this email and have
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/6386#issuecomment-105774535
Waiting https://github.com/databricks/spark-perf/pull/72 to see if there is
performance regression.
---
If your project is set up for it, you can reply to this email
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/6504#issuecomment-107830383
Agreed. We should create a separate page for this. For example code, in
https://github.com/apache/spark/pull/6576/files , I have full running apps in
scala, but this may
GitHub user dbtsai opened a pull request:
https://github.com/apache/spark/pull/6576
[SPARK-7547][ML] Scala Example code for ElasticNet
This is scala example code for both linear and logistic regression. Python
and Java versions are to be added.
You can merge this pull request
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/7037#issuecomment-117035158
You don't cover all the test cases including with/without intercept. Also,
for regParam = 0, they should converge to the same solution.
---
If your project is set up
301 - 400 of 1777 matches
Mail list logo
