Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16837
LGTM except one comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16664#discussion_r100182956
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ---
@@ -218,7 +247,14 @@ final class DataFrameWriter[T] private[sql](ds
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16736
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16804
LGTM pending test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16664#discussion_r100186876
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ---
@@ -218,7 +247,14 @@ final class DataFrameWriter[T] private[sql](ds
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16664#discussion_r100229660
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ---
@@ -218,7 +247,14 @@ final class DataFrameWriter[T] private[sql](ds
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16664#discussion_r100232628
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ---
@@ -218,7 +247,14 @@ final class DataFrameWriter[T] private[sql](ds
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16760
Thanks! Merging to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16837
Thanks! Merging to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16638
Your master is clean (i.e., exactly identical to the upstream/master),
right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16736
LGTM
Thanks! Merging to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16674#discussion_r100235360
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveSQLViewSuite.scala
---
@@ -0,0 +1,190 @@
+/*
+ * Licensed to the
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16638
You might not be familiar with the Github/Git. How about submitting a new
PR? : )
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16638
You do not need to do the step 1 every time. You might miss the following
two steps when you want to resolve your conflicts.
> git fetch upstream
> git merge upstream/
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16787
Late in the east coast. Will review it tomorrow. : )
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16638
No worry, open/submit a new PR. : )
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16638
You might be able to make it by forcefully pushing the new changes by `git
push -f origin NEW_BRANCH:REMOTE_BRANCH `
---
If your project is set up for it, you can reply to this email and have
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16787#discussion_r100315562
--- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveUtils.scala
---
@@ -463,117 +459,6 @@ private[spark] object HiveUtils extends Logging
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16787#discussion_r100319490
--- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveUtils.scala
---
@@ -463,117 +459,6 @@ private[spark] object HiveUtils extends Logging
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16787#discussion_r100321748
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
---
@@ -815,7 +809,21 @@ private[hive] class HiveClientImpl
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16787#discussion_r100321936
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
---
@@ -891,7 +905,7 @@ private[hive] class HiveClientImpl
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16787#discussion_r100329892
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
---
@@ -845,10 +855,10 @@ private[hive] class HiveClientImpl
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16674#discussion_r100397916
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveSQLViewSuite.scala
---
@@ -0,0 +1,190 @@
+/*
+ * Licensed to the
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16868
OK to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16868
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16868#discussion_r100423391
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -682,8 +682,8 @@ class HiveDDLSuite
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16868#discussion_r100424068
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -926,38 +1006,63 @@ class HiveDDLSuite
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16868#discussion_r100424167
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -926,38 +1006,63 @@ class HiveDDLSuite
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16664#discussion_r100560364
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ---
@@ -218,7 +247,14 @@ final class DataFrameWriter[T] private[sql](ds
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16067
Sure, let me back port it now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user gatorsmile opened a pull request:
https://github.com/apache/spark/pull/16894
[SPARK-17897] [SQL] [BACKPORT-2.0] Fixed IsNotNull Constraint Inference Rule
### What changes were proposed in this pull request?
This PR is to backport https://github.com/apache/spark
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16674#discussion_r100672397
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -624,6 +624,9 @@ class Analyzer(
} catch
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16674#discussion_r100672477
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/SQLViewSuite.scala ---
@@ -398,26 +472,6 @@ class SQLViewSuite extends QueryTest with
Github user gatorsmile closed the pull request at:
https://github.com/apache/spark/pull/16894
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16787#discussion_r100681160
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/client/VersionsSuite.scala ---
@@ -570,7 +570,6 @@ class VersionsSuite extends QueryTest
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16787#discussion_r100681187
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/client/VersionsSuite.scala ---
@@ -649,6 +648,16 @@ class VersionsSuite extends QueryTest
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16787#discussion_r100681309
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/client/VersionsSuite.scala ---
@@ -649,6 +648,16 @@ class VersionsSuite extends QueryTest
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16787
@windpiger Could you please resolve conflicts? Looks good to me. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16672
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16672
Could you please add the test cases for the scenarios (of non pre existing
location) you explained above? Thanks!
---
If your project is set up for it, you can reply to this email and have your
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16672
The changes in this PR affects both read and write paths. Please update the
PR description and title. Thanks!
---
If your project is set up for it, you can reply to this email and have your
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16878#discussion_r100682314
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -425,7 +425,9 @@ class SparkSqlAstBuilder(conf: SQLConf
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16878#discussion_r100682316
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -425,7 +425,9 @@ class SparkSqlAstBuilder(conf: SQLConf
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16878#discussion_r100682360
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -425,7 +425,9 @@ class SparkSqlAstBuilder(conf: SQLConf
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16878#discussion_r100682391
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
---
@@ -1690,6 +1690,16 @@ class DDLSuite extends QueryTest
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16776#discussion_r100684027
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameStatFunctions.scala ---
@@ -58,49 +58,56 @@ final class DataFrameStatFunctions private
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16776#discussion_r100684044
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameStatFunctions.scala ---
@@ -63,44 +63,49 @@ final class DataFrameStatFunctions private
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16672
: ) `success` is a noun and `exist` is a verb.
`insert/read data to a not exist location datasource table should success`
-> `Reading from or writing to a data-source table with a
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16672#discussion_r100684204
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -1431,4 +1431,30 @@ class HiveDDLSuite
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16672
More test cases for non pre-existing locations? For example, INESRT without
an ALTER LOCATION? You can simply drop the directory. This scenario is
reasonable when the table is external
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16672
The test case also can check another INSERT mode. INSERT OVERWRITE? Also
verifying the behaviors for Hive Serde tables?
---
If your project is set up for it, you can reply to this email and
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16672#discussion_r100684307
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -1431,4 +1431,30 @@ class HiveDDLSuite
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16787
Thank you very much! LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16787
Thanks! Merging to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16674#discussion_r100684516
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -617,13 +617,17 @@ class Analyzer(
private
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16674#discussion_r100684983
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/SQLViewSuite.scala ---
@@ -452,311 +534,96 @@ class SQLViewSuite extends QueryTest with
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16674#discussion_r100685083
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveSQLViewSuite.scala
---
@@ -0,0 +1,154 @@
+/*
+ * Licensed to the
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16868#discussion_r100685099
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -70,12 +71,19 @@ case class CreateTableLikeCommand
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16868#discussion_r100685105
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -70,12 +71,19 @@ case class CreateTableLikeCommand
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16868#discussion_r100685120
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -70,12 +71,19 @@ case class CreateTableLikeCommand
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16868#discussion_r100685138
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -833,54 +833,95 @@ class HiveDDLSuite
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16868#discussion_r100685143
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -833,54 +833,95 @@ class HiveDDLSuite
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16868#discussion_r100685148
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -833,54 +833,95 @@ class HiveDDLSuite
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16868#discussion_r100685152
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -833,54 +833,95 @@ class HiveDDLSuite
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16868#discussion_r100685179
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -926,38 +993,55 @@ class HiveDDLSuite
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16868#discussion_r100685175
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -926,38 +993,55 @@ class HiveDDLSuite
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16868#discussion_r100685183
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -891,32 +932,58 @@ class HiveDDLSuite
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16868#discussion_r100685186
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -926,38 +993,55 @@ class HiveDDLSuite
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16868#discussion_r100685218
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -969,15 +1053,19 @@ class HiveDDLSuite
val
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16868
Please update the PR description. This statement can be used for data
source tables too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16672#discussion_r100703121
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -754,6 +754,8 @@ case class AlterTableSetLocationCommand
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16672
How about creating a separate PR for Hive serde tables? This PR can focus
on the issues of data source tables. Thanks!
---
If your project is set up for it, you can reply to this email and have
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16870#discussion_r100712695
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
---
@@ -98,6 +98,7 @@ object DateTimeUtils {
def
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16870#discussion_r100713251
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DateFunctionsSuite.scala ---
@@ -477,6 +483,27 @@ class DateFunctionsSuite extends QueryTest with
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16870#discussion_r100713312
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DateFunctionsSuite.scala ---
@@ -500,6 +527,23 @@ class DateFunctionsSuite extends QueryTest with
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16870
Could you also add one more case for verifying `to_date` on "2016-02-29"
and "2017-02-29"?
---
If your project is set up for it, you can reply to this email and have your
re
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16868
Please add a test case based on what @tejasapatil suggested. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16733
I think we can close this PR, @maropu ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16777#discussion_r100715180
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -116,48 +114,66 @@ object TypeCoercion
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16777
I think we need to separate the changes from the support of `Type coercion
between ArrayTypes`? Could you submit another PR at first? We might need extra
test cases for this change.
---
If
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16733
I prefer to closing it now. If users hit this again, we can revisit it.
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16777
Yeah, the first PR is for refactoring and cleaning up
`findWiderTypeForTwo`. We need to add the test cases for the behavior changes.
We might also need to document this in the release note
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16777#discussion_r100719832
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -116,48 +114,66 @@ object TypeCoercion
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16777#discussion_r100719964
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -116,48 +114,66 @@ object TypeCoercion
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16777#discussion_r100727682
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -116,48 +114,66 @@ object TypeCoercion
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16776#discussion_r100727960
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameStatFunctions.scala ---
@@ -58,49 +58,54 @@ final class DataFrameStatFunctions private
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16789#discussion_r100733678
--- Diff:
examples/src/main/java/org/apache/spark/examples/ml/JavaTokenizerExample.java
---
@@ -35,13 +35,11 @@
import
GitHub user gatorsmile opened a pull request:
https://github.com/apache/spark/pull/16908
[SPARK-19574][ML][Documentation] Fix Liquid Exception: Start indices amount
is not equal to end indices amount
### What changes were proposed in this pull request?
```
Liquid Exception
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16908
cc @srowen @anshbansal
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16672#discussion_r100734735
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -1431,4 +1432,133 @@ class HiveDDLSuite
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16672#discussion_r100735007
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -1431,4 +1432,133 @@ class HiveDDLSuite
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16672#discussion_r100735110
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -1431,4 +1432,133 @@ class HiveDDLSuite
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16672
Could you move the test cases to `DDLSuite.scala`? This is not for Hive
specific. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16789#discussion_r100859452
--- Diff:
examples/src/main/java/org/apache/spark/examples/ml/JavaTokenizerExample.java
---
@@ -35,13 +35,11 @@
import
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16870#discussion_r100859963
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DateFunctionsSuite.scala ---
@@ -477,6 +483,27 @@ class DateFunctionsSuite extends QueryTest with
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16672#discussion_r100861842
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
---
@@ -1816,4 +1816,127 @@ class DDLSuite extends QueryTest
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16672#discussion_r100882025
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
---
@@ -1816,4 +1816,127 @@ class DDLSuite extends QueryTest
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16672#discussion_r100882612
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
---
@@ -1816,4 +1816,127 @@ class DDLSuite extends QueryTest
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16672
Actually, I found another issue in CTAS with pre-existing location. Maybe
you can take that too? https://issues.apache.org/jira/browse/SPARK-19583
---
If your project is set up for it, you can
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16777#discussion_r100898554
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -117,49 +115,67 @@ object TypeCoercion
1 - 100 of 14069 matches
Mail list logo
