[GitHub] spark issue #21807: [SPARK-24536] Validate that limit clause cannot have a n...

2018-07-28 Thread mauropalsgraaf
Github user mauropalsgraaf commented on the issue: https://github.com/apache/spark/pull/21807 Sorry for my absence, will look into it now --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

[GitHub] spark pull request #21807: [SPARK-24536] Validate that limit clause cannot h...

2018-07-30 Thread mauropalsgraaf
Github user mauropalsgraaf commented on a diff in the pull request: https://github.com/apache/spark/pull/21807#discussion_r206142897 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala --- @@ -68,9 +68,18 @@ trait CheckAnalysis extends

[GitHub] spark issue #21807: [SPARK-24536] Validate that limit clause cannot have a n...

2018-07-30 Thread mauropalsgraaf
Github user mauropalsgraaf commented on the issue: https://github.com/apache/spark/pull/21807 @hvanhovell Do you know what this unknown error code, -9 means? --- - To unsubscribe, e-mail: reviews-unsubscr

[GitHub] spark pull request #21807: [SPARK-24536] Validate that limit clause cannot h...

2018-07-30 Thread mauropalsgraaf
Github user mauropalsgraaf commented on a diff in the pull request: https://github.com/apache/spark/pull/21807#discussion_r206322253 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala --- @@ -68,9 +68,18 @@ trait CheckAnalysis extends

[GitHub] spark issue #21807: [SPARK-24536] Validate that limit clause cannot have a n...

2018-07-28 Thread mauropalsgraaf
Github user mauropalsgraaf commented on the issue: https://github.com/apache/spark/pull/21807 I've added a test case and now it works properly for the given example in the description. Regarding the comment: "make sure eval is only called once", is this wha

[GitHub] spark pull request #21807: [SPARK-24536] Validate that limit clause cannot h...

2018-07-18 Thread mauropalsgraaf
GitHub user mauropalsgraaf opened a pull request: https://github.com/apache/spark/pull/21807 [SPARK-24536] Validate that limit clause cannot have a nullable expression ## What changes were proposed in this pull request? It proposes a version in which nullable expressions