[GitHub] spark pull request #21021: [SPARK-23921][SQL] Add array_sort function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21021#discussion_r182992892 --- Diff: python/pyspark/sql/functions.py --- @@ -2154,10 +2154,13 @@ def array_max(col): def sort_array(col, asc=True

[GitHub] spark pull request #21021: [SPARK-23921][SQL] Add array_sort function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21021#discussion_r18236 --- Diff: python/pyspark/sql/functions.py --- @@ -2154,10 +2154,13 @@ def array_max(col): def sort_array(col, asc=True

[GitHub] spark pull request #21061: [SPARK-23914][SQL] Add array_union function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21061#discussion_r183011714 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CollectionExpressionsSuite.scala --- @@ -169,4 +169,45 @@ class

[GitHub] spark issue #20938: [SPARK-23821][SQL] Collection function: flatten

Github user ueshin commented on the issue: https://github.com/apache/spark/pull/20938 Jenkins, retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark issue #20938: [SPARK-23821][SQL] Collection function: flatten

Github user ueshin commented on the issue: https://github.com/apache/spark/pull/20938 I'm sorry for the delay. Thanks! merging to master. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.or

[GitHub] spark pull request #21040: [SPARK-23930][SQL] Add slice function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21040#discussion_r184257274 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -287,3 +287,101 @@ case class

[GitHub] spark pull request #21040: [SPARK-23930][SQL] Add slice function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21040#discussion_r184257279 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CollectionExpressionsSuite.scala --- @@ -105,4 +105,28 @@ class

[GitHub] spark issue #21008: [SPARK-23902][SQL] Add roundOff flag to months_between

Github user ueshin commented on the issue: https://github.com/apache/spark/pull/21008 Thanks! merging to master. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark pull request #21021: [SPARK-23921][SQL] Add array_sort function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21021#discussion_r184261996 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -168,9 +140,9 @@ case class SortArray

[GitHub] spark pull request #21021: [SPARK-23921][SQL] Add array_sort function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21021#discussion_r184262129 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -117,47 +118,18 @@ case class MapValues

[GitHub] spark pull request #21021: [SPARK-23921][SQL] Add array_sort function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21021#discussion_r184261947 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -300,6 +333,49 @@ case class Reverse

[GitHub] spark pull request #21021: [SPARK-23921][SQL] Add array_sort function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21021#discussion_r184262044 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -191,24 +163,85 @@ case class SortArray

[GitHub] spark pull request #21021: [SPARK-23921][SQL] Add array_sort function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21021#discussion_r184262013 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -191,24 +163,85 @@ case class SortArray

[GitHub] spark pull request #21021: [SPARK-23921][SQL] Add array_sort function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21021#discussion_r184261968 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -168,9 +140,9 @@ case class SortArray

[GitHub] spark pull request #21021: [SPARK-23921][SQL] Add array_sort function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21021#discussion_r184261902 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -191,24 +163,85 @@ case class SortArray

[GitHub] spark pull request #21021: [SPARK-23921][SQL] Add array_sort function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21021#discussion_r184262545 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -191,24 +163,85 @@ case class SortArray

[GitHub] spark pull request #21021: [SPARK-23921][SQL] Add array_sort function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21021#discussion_r184262552 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -300,6 +333,49 @@ case class Reverse

[GitHub] spark pull request #21021: [SPARK-23921][SQL] Add array_sort function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21021#discussion_r184262594 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -117,47 +118,18 @@ case class MapValues

[GitHub] spark pull request #21028: [SPARK-23922][SQL] Add arrays_overlap function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21028#discussion_r184266872 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -288,6 +288,114 @@ case class

[GitHub] spark issue #21011: [SPARK-23916][SQL] Add array_join function

Github user ueshin commented on the issue: https://github.com/apache/spark/pull/21011 Thanks! merging to master. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark pull request #21021: [SPARK-23921][SQL] Add array_sort function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21021#discussion_r184293071 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -185,6 +183,8 @@ trait ArraySortUtil

[GitHub] spark pull request #21028: [SPARK-23922][SQL] Add arrays_overlap function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21028#discussion_r184310311 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -288,6 +288,114 @@ case class

[GitHub] spark issue #21121: [SPARK-24042][SQL] Collection function: zip_with_index

Github user ueshin commented on the issue: https://github.com/apache/spark/pull/21121 I'm not sure we really need this function. If the purpose is only for `transform` function you mentionsed at https://github.com/apache/spark/pull/21121#issuecomment-383319312, how about add

[GitHub] spark pull request #21040: [SPARK-23930][SQL] Add slice function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21040#discussion_r184914154 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -378,6 +378,138 @@ case class

[GitHub] spark issue #21040: [SPARK-23930][SQL] Add slice function

Github user ueshin commented on the issue: https://github.com/apache/spark/pull/21040 Jenkins, retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark pull request #21021: [SPARK-23921][SQL] Add array_sort function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21021#discussion_r185166899 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -191,28 +161,205 @@ case class SortArray

[GitHub] spark pull request #21021: [SPARK-23921][SQL] Add array_sort function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21021#discussion_r185163319 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -191,28 +161,205 @@ case class SortArray

[GitHub] spark pull request #21021: [SPARK-23921][SQL] Add array_sort function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21021#discussion_r185163397 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -191,28 +161,205 @@ case class SortArray

[GitHub] spark pull request #21021: [SPARK-23921][SQL] Add array_sort function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21021#discussion_r185166848 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -191,28 +161,205 @@ case class SortArray

[GitHub] spark pull request #21054: [SPARK-23907][SQL] Add regr_* functions

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21054#discussion_r185171846 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/regression.scala --- @@ -0,0 +1,193 @@ +/* + * Licensed

[GitHub] spark pull request #21054: [SPARK-23907][SQL] Add regr_* functions

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21054#discussion_r185170928 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Average.scala --- @@ -23,23 +23,13 @@ import

[GitHub] spark pull request #21054: [SPARK-23907][SQL] Add regr_* functions

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21054#discussion_r185170552 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Average.scala --- @@ -62,14 +52,6 @@ case class Average(child

[GitHub] spark pull request #21021: [SPARK-23921][SQL] Add array_sort function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21021#discussion_r185196808 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -191,28 +161,202 @@ case class SortArray

[GitHub] spark pull request #21021: [SPARK-23921][SQL] Add array_sort function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21021#discussion_r185197041 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -191,28 +161,202 @@ case class SortArray

[GitHub] spark issue #21040: [SPARK-23930][SQL] Add slice function

Github user ueshin commented on the issue: https://github.com/apache/spark/pull/21040 Jenkins, retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark issue #21031: [SPARK-23923][SQL] Add cardinality function

Github user ueshin commented on the issue: https://github.com/apache/spark/pull/21031 Jenkins, retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark pull request #21054: [SPARK-23907][SQL] Add regr_* functions

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21054#discussion_r185461620 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Corr.scala --- @@ -22,18 +22,14 @@ import

[GitHub] spark pull request #21054: [SPARK-23907][SQL] Add regr_* functions

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21054#discussion_r185462735 --- Diff: sql/core/src/test/resources/sql-tests/inputs/udaf-regrfunctions.sql --- @@ -0,0 +1,61 @@ +-- +-- Licensed to the Apache Software

[GitHub] spark pull request #21054: [SPARK-23907][SQL] Add regr_* functions

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21054#discussion_r185461822 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Average.scala --- @@ -85,4 +65,29 @@ case class Average(child

[GitHub] spark issue #21054: [SPARK-23907][SQL] Add regr_* functions

Github user ueshin commented on the issue: https://github.com/apache/spark/pull/21054 @mgaido91 I agree that the fix should be done in the separate PRs after the discussion. Could you list the differences you found for the future discussion? Thanks

[GitHub] spark issue #21054: [SPARK-23907][SQL] Add regr_* functions

Github user ueshin commented on the issue: https://github.com/apache/spark/pull/21054 @mgaido91 Thanks for letting us know! cc @gatorsmile --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark pull request #21010: [SPARK-23900][SQL] format_number support user spe...

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21010#discussion_r185691812 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -2108,35 +2133,53 @@ case class FormatNumber

[GitHub] spark pull request #21010: [SPARK-23900][SQL] format_number support user spe...

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21010#discussion_r185691861 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -2108,35 +2133,53 @@ case class FormatNumber

[GitHub] spark pull request #21073: [SPARK-23936][SQL] Implement map_concat

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21073#discussion_r185695875 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -116,6 +117,169 @@ case class MapValues

[GitHub] spark pull request #21073: [SPARK-23936][SQL] Implement map_concat

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21073#discussion_r185696085 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -116,6 +117,169 @@ case class MapValues

[GitHub] spark pull request #21073: [SPARK-23936][SQL] Implement map_concat

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21073#discussion_r185694644 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -116,6 +117,169 @@ case class MapValues

[GitHub] spark pull request #21073: [SPARK-23936][SQL] Implement map_concat

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21073#discussion_r185695887 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -116,6 +117,169 @@ case class MapValues

[GitHub] spark pull request #21069: [SPARK-23920][SQL]add array_remove to remove all ...

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21069#discussion_r185716774 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -883,3 +883,70 @@ case class Concat

[GitHub] spark pull request #21069: [SPARK-23920][SQL]add array_remove to remove all ...

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21069#discussion_r185716615 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -883,3 +883,70 @@ case class Concat

[GitHub] spark pull request #21069: [SPARK-23920][SQL]add array_remove to remove all ...

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21069#discussion_r185716705 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -883,3 +883,70 @@ case class Concat

[GitHub] spark pull request #21069: [SPARK-23920][SQL]add array_remove to remove all ...

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21069#discussion_r185722053 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CollectionExpressionsSuite.scala --- @@ -280,4 +280,35 @@ class

[GitHub] spark pull request #21069: [SPARK-23920][SQL]add array_remove to remove all ...

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21069#discussion_r185715072 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -287,3 +287,44 @@ case class

[GitHub] spark pull request #21069: [SPARK-23920][SQL]add array_remove to remove all ...

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21069#discussion_r185721700 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CollectionExpressionsSuite.scala --- @@ -280,4 +280,35 @@ class

[GitHub] spark pull request #21069: [SPARK-23920][SQL]add array_remove to remove all ...

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21069#discussion_r185720852 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -883,3 +883,70 @@ case class Concat

[GitHub] spark pull request #21069: [SPARK-23920][SQL]add array_remove to remove all ...

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21069#discussion_r185723637 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -883,3 +883,70 @@ case class Concat

[GitHub] spark pull request #21069: [SPARK-23920][SQL]add array_remove to remove all ...

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21069#discussion_r185726735 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameFunctionsSuite.scala --- @@ -691,6 +691,30 @@ class DataFrameFunctionsSuite extends

[GitHub] spark pull request #21050: [SPARK-23912][SQL]add array_distinct

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21050#discussion_r185739950 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -1059,3 +1059,96 @@ case class Flatten

[GitHub] spark pull request #21050: [SPARK-23912][SQL]add array_distinct

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21050#discussion_r185731095 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -1059,3 +1059,96 @@ case class Flatten

[GitHub] spark pull request #21021: [SPARK-23921][SQL] Add array_sort function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21021#discussion_r186002801 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -191,28 +161,191 @@ case class SortArray

[GitHub] spark pull request #21021: [SPARK-23921][SQL] Add array_sort function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21021#discussion_r186003960 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -117,47 +118,16 @@ case class MapValues

[GitHub] spark pull request #21021: [SPARK-23921][SQL] Add array_sort function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21021#discussion_r186003272 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -191,28 +161,191 @@ case class SortArray

[GitHub] spark pull request #21021: [SPARK-23921][SQL] Add array_sort function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21021#discussion_r186002826 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -191,28 +161,191 @@ case class SortArray

[GitHub] spark pull request #21208: [SPARK-23925][SQL] Add array_repeat collection fu...

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21208#discussion_r186008908 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -1229,3 +1229,140 @@ case class Flatten

[GitHub] spark pull request #21208: [SPARK-23925][SQL] Add array_repeat collection fu...

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21208#discussion_r186013623 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameFunctionsSuite.scala --- @@ -798,6 +798,156 @@ class DataFrameFunctionsSuite extends

[GitHub] spark pull request #21208: [SPARK-23925][SQL] Add array_repeat collection fu...

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21208#discussion_r186007739 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -1229,3 +1229,140 @@ case class Flatten

[GitHub] spark pull request #21208: [SPARK-23925][SQL] Add array_repeat collection fu...

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21208#discussion_r186012529 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -1229,3 +1229,140 @@ case class Flatten

[GitHub] spark pull request #21208: [SPARK-23925][SQL] Add array_repeat collection fu...

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21208#discussion_r186012320 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -1229,3 +1229,140 @@ case class Flatten

[GitHub] spark pull request #21208: [SPARK-23925][SQL] Add array_repeat collection fu...

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21208#discussion_r186008236 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -1229,3 +1229,140 @@ case class Flatten

[GitHub] spark pull request #21208: [SPARK-23925][SQL] Add array_repeat collection fu...

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21208#discussion_r186014334 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameFunctionsSuite.scala --- @@ -798,6 +798,156 @@ class DataFrameFunctionsSuite extends

[GitHub] spark pull request #21208: [SPARK-23925][SQL] Add array_repeat collection fu...

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21208#discussion_r186016026 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -1229,3 +1229,140 @@ case class Flatten

[GitHub] spark pull request #21054: [SPARK-23907][SQL] Add regr_* functions

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21054#discussion_r186020071 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/regression.scala --- @@ -0,0 +1,190 @@ +/* + * Licensed

[GitHub] spark pull request #21155: SPARK-23927: Add "sequence" expression

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21155#discussion_r186030182 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala --- @@ -536,6 +536,15 @@ object TypeCoercion

[GitHub] spark pull request #21155: SPARK-23927: Add "sequence" expression

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21155#discussion_r186031064 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -1059,3 +1063,316 @@ case class Flatten

[GitHub] spark pull request #21155: SPARK-23927: Add "sequence" expression

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21155#discussion_r186029528 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -1059,3 +1063,316 @@ case class Flatten

[GitHub] spark pull request #21155: SPARK-23927: Add "sequence" expression

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21155#discussion_r186028360 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala --- @@ -536,6 +536,15 @@ object TypeCoercion

[GitHub] spark pull request #21155: SPARK-23927: Add "sequence" expression

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21155#discussion_r186037997 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -1059,3 +1063,316 @@ case class Flatten

[GitHub] spark pull request #21155: SPARK-23927: Add "sequence" expression

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21155#discussion_r186036063 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -1059,3 +1063,316 @@ case class Flatten

[GitHub] spark pull request #21155: SPARK-23927: Add "sequence" expression

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21155#discussion_r186038049 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -1059,3 +1063,316 @@ case class Flatten

[GitHub] spark pull request #21155: SPARK-23927: Add "sequence" expression

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21155#discussion_r186036365 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -1059,3 +1063,316 @@ case class Flatten

[GitHub] spark pull request #21155: SPARK-23927: Add "sequence" expression

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21155#discussion_r186029578 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -1059,3 +1063,316 @@ case class Flatten

[GitHub] spark pull request #21155: SPARK-23927: Add "sequence" expression

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21155#discussion_r186036247 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -1059,3 +1063,316 @@ case class Flatten

[GitHub] spark pull request #21155: SPARK-23927: Add "sequence" expression

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21155#discussion_r186037814 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -1059,3 +1063,316 @@ case class Flatten

[GitHub] spark pull request #21155: SPARK-23927: Add "sequence" expression

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21155#discussion_r186028756 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -1059,3 +1063,316 @@ case class Flatten

[GitHub] spark pull request #21155: SPARK-23927: Add "sequence" expression

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21155#discussion_r186030720 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -1059,3 +1063,316 @@ case class Flatten

[GitHub] spark pull request #21155: SPARK-23927: Add "sequence" expression

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21155#discussion_r186036116 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -1059,3 +1063,316 @@ case class Flatten

[GitHub] spark pull request #21155: SPARK-23927: Add "sequence" expression

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21155#discussion_r186037505 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -1059,3 +1063,316 @@ case class Flatten

[GitHub] spark issue #21021: [SPARK-23921][SQL] Add array_sort function

Github user ueshin commented on the issue: https://github.com/apache/spark/pull/21021 Thanks! merging to master. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark issue #21040: [SPARK-23930][SQL] Add slice function

Github user ueshin commented on the issue: https://github.com/apache/spark/pull/21040 Thanks! merging to master. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark pull request #21028: [SPARK-23922][SQL] Add arrays_overlap function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21028#discussion_r186355622 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala --- @@ -3039,6 +3039,16 @@ object functions { ArrayContains(column.expr

[GitHub] spark pull request #21208: [SPARK-23925][SQL] Add array_repeat collection fu...

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21208#discussion_r186356981 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -1229,3 +1229,140 @@ case class Flatten

[GitHub] spark pull request #21208: [SPARK-23925][SQL] Add array_repeat collection fu...

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21208#discussion_r186357798 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -1229,3 +1229,140 @@ case class Flatten

[GitHub] spark pull request #21236: [SPARK-23935][SQL] Adding map_entries function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21236#discussion_r186371562 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -118,6 +118,162 @@ case class MapValues

[GitHub] spark pull request #21236: [SPARK-23935][SQL] Adding map_entries function

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21236#discussion_r186377811 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -118,6 +118,162 @@ case class MapValues

[GitHub] spark pull request #21010: [SPARK-23900][SQL] format_number support user spe...

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21010#discussion_r186607122 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/StringExpressionsSuite.scala --- @@ -706,6 +706,30 @@ class

[GitHub] spark pull request #21010: [SPARK-23900][SQL] format_number support user spe...

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21010#discussion_r186606198 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -2108,35 +2133,57 @@ case class FormatNumber

[GitHub] spark pull request #21010: [SPARK-23900][SQL] format_number support user spe...

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21010#discussion_r186606172 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -2108,35 +2133,57 @@ case class FormatNumber

[GitHub] spark pull request #21193: [SPARK-24121][SQL] Add API for handling expressio...

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21193#discussion_r186683015 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala --- @@ -56,19 +57,19 @@ import

[GitHub] spark pull request #21193: [SPARK-24121][SQL] Add API for handling expressio...

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21193#discussion_r186674665 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala --- @@ -623,8 +624,14 @@ case class Cast(child: Expression

[GitHub] spark pull request #21193: [SPARK-24121][SQL] Add API for handling expressio...

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21193#discussion_r186677863 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala --- @@ -100,17 +101,18 @@ abstract class Expression

[GitHub] spark pull request #21193: [SPARK-24121][SQL] Add API for handling expressio...

Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21193#discussion_r186681857 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala --- @@ -623,8 +624,14 @@ case class Cast(child: Expression

<    1   2   3   4   5   6   7   8   9   10   >