Github user mrkm4ntr commented on the issue:
https://github.com/apache/spark/pull/19988
This was incorrect.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews
Github user mrkm4ntr closed the pull request at:
https://github.com/apache/spark/pull/19988
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user mrkm4ntr closed the pull request at:
https://github.com/apache/spark/pull/20568
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user mrkm4ntr commented on the issue:
https://github.com/apache/spark/pull/20568
@gatorsmile Thanks! I will close it.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands
Github user mrkm4ntr commented on the issue:
https://github.com/apache/spark/pull/20568
I cannot reproduce this failure of the test in my environment.
It seems to me that this is not related to this change
Github user mrkm4ntr commented on a diff in the pull request:
https://github.com/apache/spark/pull/20568#discussion_r168659153
--- Diff:
common/sketch/src/main/java/org/apache/spark/util/sketch/Murmur3_x86_32.java ---
@@ -71,6 +73,20 @@ public static int hashUnsafeBytes(Object
Github user mrkm4ntr commented on the issue:
https://github.com/apache/spark/pull/20568
@hvanhovell I added a method and changed it so that we call it only from
FeatureHasher.
---
-
To unsubscribe, e-mail: reviews
Github user mrkm4ntr commented on the issue:
https://github.com/apache/spark/pull/20568
@hvanhovell I sent an e-mail to the topic `[VOTE] Spark 2.3.0 (RC3)`.
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user mrkm4ntr commented on the issue:
https://github.com/apache/spark/pull/20568
I registered with the same user name in dev list.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user mrkm4ntr commented on the issue:
https://github.com/apache/spark/pull/20568
@hvanhovell The main motivation is making the online prediction of trained
parameters using FeatureHasher in MLLib. If the generated hash value is
different from the implementations in another
Github user mrkm4ntr commented on the issue:
https://github.com/apache/spark/pull/20568
@kiszk Thank you for your review! I fixed it.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
GitHub user mrkm4ntr opened a pull request:
https://github.com/apache/spark/pull/20568
[SPARK-23381][CORE] Murmur3 hash generates a different value from other
implementations
## What changes were proposed in this pull request?
Murmur3 hash generates a different value from
Github user mrkm4ntr commented on the issue:
https://github.com/apache/spark/pull/19988
> When gradient nearly zero, and line-search failed. I think this is also
possible. This should get valid model.
Yes, I agree.
> When gradient non-zero, line-search
Github user mrkm4ntr commented on the issue:
https://github.com/apache/spark/pull/19988
Surely... I lost my confidence as to whether the model is always
meaningless.
Instead of raising an error, would it be preferable that the model has
information that LineSearch failed? I want
Github user mrkm4ntr commented on a diff in the pull request:
https://github.com/apache/spark/pull/19988#discussion_r157447946
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LinearSVC.scala ---
@@ -244,9 +244,9 @@ class LinearSVC @Since("
Github user mrkm4ntr commented on a diff in the pull request:
https://github.com/apache/spark/pull/19988#discussion_r157396794
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LinearSVC.scala ---
@@ -244,9 +244,9 @@ class LinearSVC @Since("
Github user mrkm4ntr commented on a diff in the pull request:
https://github.com/apache/spark/pull/19988#discussion_r157345097
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/optim/NormalEquationSolver.scala ---
@@ -109,6 +109,11 @@ private[optim] class QuasiNewtonSolver
Github user mrkm4ntr commented on a diff in the pull request:
https://github.com/apache/spark/pull/19988#discussion_r157243741
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/optim/NormalEquationSolver.scala ---
@@ -109,6 +109,11 @@ private[optim] class QuasiNewtonSolver
GitHub user mrkm4ntr opened a pull request:
https://github.com/apache/spark/pull/19988
[Spark-22795] Raise error when line search in FirstOrderMinimizer failed
## What changes were proposed in this pull request?
When line search in FirstOrderMinimizer (LBFGS or OWLQN so
19 matches
Mail list logo
