Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/9800#discussion_r45254024
--- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
@@ -225,7 +225,32 @@ private[spark] class Client(
val capability
Github user sryza commented on the pull request:
https://github.com/apache/spark/pull/9504#issuecomment-154201525
Title should have the [SQL] tag as well
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/9313#discussion_r43909799
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -1611,8 +1611,14 @@ class SparkContext(config: SparkConf) extends
Logging
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/9313#discussion_r43726053
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -1611,8 +1611,14 @@ class SparkContext(config: SparkConf) extends
Logging
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/9313#discussion_r43726148
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -1667,6 +1673,13 @@ class SparkContext(config: SparkConf) extends
Logging
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/9313#discussion_r43682628
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -175,6 +175,29 @@ private[spark] object Utils extends Logging
GitHub user sryza reopened a pull request:
https://github.com/apache/spark/pull/3816
SPARK-4921. TaskSetManager.dequeueTask returns PROCESS_LOCAL for NO_PREF ...
...tasks
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sryza
Github user sryza commented on the pull request:
https://github.com/apache/spark/pull/3816#issuecomment-153165000
@zsxwing I have sadly lost most of the context on this issue and don't have
time to pick it back up at the moment.
What you point out does seem to be an issue
Github user sryza commented on the pull request:
https://github.com/apache/spark/pull/9313#issuecomment-152234819
Could we add that flag to the Scala API as well? Would that break binary
compatibility?
---
If your project is set up for it, you can reply to this email and have your
Github user sryza commented on the pull request:
https://github.com/apache/spark/pull/9313#issuecomment-152069509
Does the Scala SparkContext#addJar add the jar to the driver classpath? My
impression was that it does not. If so, this would be a little inconsistent,
right
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/9313#discussion_r43347726
--- Diff: python/pyspark/context.py ---
@@ -806,6 +806,24 @@ def addPyFile(self, path):
import importlib
Github user sryza commented on the pull request:
https://github.com/apache/spark/pull/8976#issuecomment-145976915
Taking these out seems like the right thing to do to me
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user sryza commented on the pull request:
https://github.com/apache/spark/pull/7918#issuecomment-142201185
Ah, thanks for digging that up @rxin. In light of that, I definitely don't
see a compelling reason to keep the input format caching around.
---
If your project is set
Github user sryza commented on the pull request:
https://github.com/apache/spark/pull/7918#issuecomment-140575553
Ah, yeah, it does look like ReflectionUtils.newInstance caches the
constructor. In that case I'd be OK with removing the input format cache
entirely. Any thoughts
Github user sryza commented on the pull request:
https://github.com/apache/spark/pull/8763#issuecomment-140519129
Oh, nevermind, sorry, this is off by default.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user sryza commented on the pull request:
https://github.com/apache/spark/pull/8763#issuecomment-140518870
This seems like it could have a pretty serious perf impact. Are we able to
do some benchmarking to assess this?
---
If your project is set up for it, you can reply
Github user sryza commented on the pull request:
https://github.com/apache/spark/pull/8504#issuecomment-138678684
My reaction is similar to Andrew's. I haven't across much user pain around
the way that Spark submits apps to YARN. If particular use cases where the
current way
Github user sryza commented on the pull request:
https://github.com/apache/spark/pull/7918#issuecomment-138687768
Sorry for the delay here, have been on PTO.
IIUC, the change here makes Spark work with some exotic InputFormats that
it previously did not work with due
Github user sryza commented on the pull request:
https://github.com/apache/spark/pull/8192#issuecomment-132380275
Yeah, it's needed for the InputFormats that Spark relies on to read Hadoop
data.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user sryza commented on the pull request:
https://github.com/apache/spark/pull/8072#issuecomment-132214961
@tgravescs my thinking for just spark.yarn.tags was that it's redundant to
include application, because configs are by definition per-application. We'd
also
Github user sryza commented on the pull request:
https://github.com/apache/spark/pull/8072#issuecomment-132218054
Cool, in that case @dennishuo mind making the change that @vanzin suggested
and then I'll merge this?
---
If your project is set up for it, you can reply to this email
Github user sryza commented on the pull request:
https://github.com/apache/spark/pull/7075#issuecomment-131819801
@mengxr is it too late to get this in to 1.5?
@josepablocam are you able to resolve merge conflicts?
---
If your project is set up for it, you can reply
GitHub user sryza opened a pull request:
https://github.com/apache/spark/pull/8230
SPARK-7707. User guide and example code for KernelDensity
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sryza/spark sandy-spark-7707
Github user sryza commented on the pull request:
https://github.com/apache/spark/pull/8071#issuecomment-131547053
Sorry all for the delay, have been in Indonesia for the week.
I'm also in favor of the standard way being --deploy-mode. This keeps
things consistent
Github user sryza commented on the pull request:
https://github.com/apache/spark/pull/8230#issuecomment-131547427
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user sryza commented on the pull request:
https://github.com/apache/spark/pull/8072#issuecomment-131679667
@tgravescs @vanzin @andrewor14 can I get one of you to sign off on my
proposed property name `spark.yarn.tags`?
Otherwise, this LGTM
---
If your project is set
Github user sryza commented on the pull request:
https://github.com/apache/spark/pull/8072#issuecomment-130196650
jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/8072#discussion_r36833771
--- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
@@ -163,6 +163,23 @@ private[spark] class Client(
appContext.setQueue
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/8072#discussion_r36708697
--- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
@@ -163,6 +163,23 @@ private[spark] class Client(
appContext.setQueue
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/8072#discussion_r36708684
--- Diff: docs/running-on-yarn.md ---
@@ -320,6 +320,14 @@ If you need a reference to the proper location to put
log files in the YARN so t
/td
/tr
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/8072#discussion_r36708654
--- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
@@ -163,6 +163,23 @@ private[spark] class Client(
appContext.setQueue
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/8072#discussion_r36708634
--- Diff: docs/running-on-yarn.md ---
@@ -320,6 +320,14 @@ If you need a reference to the proper location to put
log files in the YARN so t
/td
/tr
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/8072#discussion_r36708965
--- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
@@ -163,6 +163,23 @@ private[spark] class Client(
appContext.setQueue
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/8072#discussion_r36709001
--- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
@@ -163,6 +163,23 @@ private[spark] class Client(
appContext.setQueue
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/8072#discussion_r36709027
--- Diff:
yarn/src/test/scala/org/apache/spark/deploy/yarn/ClientSuite.scala ---
@@ -170,6 +173,39 @@ class ClientSuite extends SparkFunSuite with Matchers
Github user sryza commented on the pull request:
https://github.com/apache/spark/pull/7075#issuecomment-127758361
This LGTM pending jenkins
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user sryza commented on the pull request:
https://github.com/apache/spark/pull/7075#issuecomment-127758313
jenkins, test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user sryza commented on the pull request:
https://github.com/apache/spark/pull/7874#issuecomment-127438873
jenkins, test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/7874#discussion_r36062508
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -113,6 +113,7 @@ class SparkContext(config: SparkConf) extends Logging
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/7874#discussion_r36062537
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -153,6 +155,8 @@ class SparkContext(config: SparkConf) extends Logging
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/7075#discussion_r36125365
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/stat/test/KolmogorovSmirnovTest.scala
---
@@ -53,6 +53,7 @@ private[stat] object KolmogorovSmirnovTest
Github user sryza commented on the pull request:
https://github.com/apache/spark/pull/7716#issuecomment-127390297
@andrewor14, the code that @KaiXinXiaoLei suggests fixing seems to be code
most recently updated in SPARK-8119.
---
If your project is set up for it, you can reply
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/7075#discussion_r36125136
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/stat/HypothesisTestSuite.scala ---
@@ -254,4 +254,115 @@ class HypothesisTestSuite extends SparkFunSuite
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/7075#discussion_r35939544
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/stat/test/KolmogorovSmirnovTest.scala
---
@@ -190,5 +191,93 @@ private[stat] object
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/7075#discussion_r35939524
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/stat/test/KolmogorovSmirnovTest.scala
---
@@ -190,5 +191,93 @@ private[stat] object
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/7075#discussion_r35939958
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/stat/HypothesisTestSuite.scala ---
@@ -254,4 +254,115 @@ class HypothesisTestSuite extends SparkFunSuite
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/7075#discussion_r35939346
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/stat/test/KolmogorovSmirnovTest.scala
---
@@ -190,5 +191,93 @@ private[stat] object
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/7075#discussion_r35939722
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/stat/test/KolmogorovSmirnovTest.scala
---
@@ -190,5 +191,93 @@ private[stat] object
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/7075#discussion_r35939695
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/stat/test/KolmogorovSmirnovTest.scala
---
@@ -190,5 +191,93 @@ private[stat] object
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/7075#discussion_r35939844
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/stat/test/KolmogorovSmirnovTest.scala
---
@@ -190,5 +191,93 @@ private[stat] object
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/7075#discussion_r35939884
--- Diff: docs/mllib-statistics.md ---
@@ -431,11 +431,16 @@ user tests against the normal distribution
(`distName=norm`), but does not pro
parameters
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/7075#discussion_r35939785
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/stat/test/KolmogorovSmirnovTest.scala
---
@@ -190,5 +191,93 @@ private[stat] object
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/7075#discussion_r35939573
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/stat/test/KolmogorovSmirnovTest.scala
---
@@ -190,5 +191,93 @@ private[stat] object
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/7075#discussion_r35939624
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/stat/test/KolmogorovSmirnovTest.scala
---
@@ -190,5 +191,93 @@ private[stat] object
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/7075#discussion_r35939648
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/stat/test/KolmogorovSmirnovTest.scala
---
@@ -190,5 +191,93 @@ private[stat] object
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/7075#discussion_r35939466
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/stat/test/KolmogorovSmirnovTest.scala
---
@@ -190,5 +191,93 @@ private[stat] object
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/7075#discussion_r35939406
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/stat/Statistics.scala
---
@@ -196,4 +196,18 @@ object Statistics {
: KolmogorovSmirnovTestResult
Github user sryza commented on the pull request:
https://github.com/apache/spark/pull/7075#issuecomment-126536916
@mengxr @josepablocam oops thought it was still a WIP for some reason.
Just took a pass. It looks mostly done - I just had a bunch of nits and a test
request
Github user sryza commented on the pull request:
https://github.com/apache/spark/pull/7716#issuecomment-125735637
@KaiXinXiaoLei we fixed a couple issues that had this symptom in 1.3. Are
you definitely running with a version that's 1.4 or later?
---
If your project is set up
Github user sryza commented on the pull request:
https://github.com/apache/spark/pull/6394#issuecomment-125372128
Great. LGTM as well. Just merged this. Thanks @jerryshao!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/7706#discussion_r35601139
--- Diff:
yarn/src/main/scala/org/apache/spark/deploy/yarn/ExecutorRunnable.scala ---
@@ -86,10 +86,15 @@ class ExecutorRunnable(
val commands
Github user sryza commented on the pull request:
https://github.com/apache/spark/pull/6394#issuecomment-125083816
@kayousterhout do the DAGScheduler changes look good to you after
@jerryshao 's last pass?
---
If your project is set up for it, you can reply to this email and have
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/6394#discussion_r35399233
--- Diff:
core/src/main/scala/org/apache/spark/ExecutorAllocationClient.scala ---
@@ -28,7 +28,10 @@ private[spark] trait ExecutorAllocationClient
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/6394#discussion_r35293276
--- Diff:
core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ---
@@ -526,6 +537,19 @@ private[spark] class ExecutorAllocationManager
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/7278#discussion_r35344727
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/stat/test/AndersonDarlingTest.scala
---
@@ -0,0 +1,289 @@
+/*
+ * Licensed to the Apache
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/7278#discussion_r35343248
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/stat/test/AndersonDarlingTest.scala
---
@@ -0,0 +1,289 @@
+/*
+ * Licensed to the Apache
Github user sryza commented on the pull request:
https://github.com/apache/spark/pull/7278#issuecomment-124167898
This LGTM after some cosmetic changes. @mengxr what do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/7278#discussion_r35342576
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/stat/Statistics.scala
---
@@ -196,4 +196,33 @@ object Statistics {
: KolmogorovSmirnovTestResult
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/7278#discussion_r35343649
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/stat/test/AndersonDarlingTest.scala
---
@@ -0,0 +1,289 @@
+/*
+ * Licensed to the Apache
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/7278#discussion_r35344003
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/stat/test/AndersonDarlingTest.scala
---
@@ -0,0 +1,289 @@
+/*
+ * Licensed to the Apache
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/7278#discussion_r35344145
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/stat/test/AndersonDarlingTest.scala
---
@@ -0,0 +1,289 @@
+/*
+ * Licensed to the Apache
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/7278#discussion_r35344395
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/stat/test/AndersonDarlingTest.scala
---
@@ -0,0 +1,289 @@
+/*
+ * Licensed to the Apache
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/7278#discussion_r35344356
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/stat/test/AndersonDarlingTest.scala
---
@@ -0,0 +1,289 @@
+/*
+ * Licensed to the Apache
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/7278#discussion_r35343600
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/stat/test/AndersonDarlingTest.scala
---
@@ -0,0 +1,289 @@
+/*
+ * Licensed to the Apache
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/7278#discussion_r35344486
--- Diff: docs/mllib-statistics.md ---
@@ -456,6 +456,39 @@ val testResult2 =
Statistics.kolmogorovSmirnovTest(data, myCDF)
/div
/div
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/6394#discussion_r35291311
--- Diff:
core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ---
@@ -526,6 +537,19 @@ private[spark] class ExecutorAllocationManager
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/6394#discussion_r35147210
--- Diff:
core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ---
@@ -526,6 +537,19 @@ private[spark] class ExecutorAllocationManager
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/6394#discussion_r35146872
--- Diff:
core/src/main/scala/org/apache/spark/ExecutorAllocationClient.scala ---
@@ -28,7 +28,10 @@ private[spark] trait ExecutorAllocationClient
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/6394#discussion_r35145466
--- Diff:
yarn/src/main/scala/org/apache/spark/deploy/yarn/ContainerPlacementStrategy.scala
---
@@ -0,0 +1,196 @@
+/*
+ * Licensed to the Apache
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/6394#discussion_r35147681
--- Diff:
core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ---
@@ -526,6 +537,19 @@ private[spark] class ExecutorAllocationManager
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/6394#discussion_r35147827
--- Diff:
core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ---
@@ -526,6 +537,19 @@ private[spark] class ExecutorAllocationManager
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/6394#discussion_r35148779
--- Diff:
core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ---
@@ -637,6 +662,24 @@ private[spark] class ExecutorAllocationManager
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/6394#discussion_r35149276
--- Diff:
yarn/src/main/scala/org/apache/spark/deploy/yarn/ContainerPlacementStrategy.scala
---
@@ -0,0 +1,196 @@
+/*
+ * Licensed to the Apache
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/6394#discussion_r35151031
--- Diff:
yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala ---
@@ -225,8 +245,11 @@ private[yarn] class YarnAllocator(
logInfo
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/6394#discussion_r35151608
--- Diff:
yarn/src/main/scala/org/apache/spark/deploy/yarn/ContainerPlacementStrategy.scala
---
@@ -0,0 +1,196 @@
+/*
+ * Licensed to the Apache
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/6394#discussion_r35148929
--- Diff:
yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala ---
@@ -127,6 +127,16 @@ private[yarn] class YarnAllocator
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/6394#discussion_r35149314
--- Diff:
yarn/src/main/scala/org/apache/spark/deploy/yarn/ContainerPlacementStrategy.scala
---
@@ -0,0 +1,196 @@
+/*
+ * Licensed to the Apache
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/6394#discussion_r35151721
--- Diff:
yarn/src/main/scala/org/apache/spark/deploy/yarn/ContainerPlacementStrategy.scala
---
@@ -0,0 +1,196 @@
+/*
+ * Licensed to the Apache
Github user sryza commented on the pull request:
https://github.com/apache/spark/pull/6394#issuecomment-123474754
I made a final pass on this for clarity issues. I'm being nitpicky on some
of the stuff, but I think it's important to be as clear as possible given that
what's going
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/6394#discussion_r35148005
--- Diff:
core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ---
@@ -637,6 +662,24 @@ private[spark] class ExecutorAllocationManager
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/6394#discussion_r35151169
--- Diff:
yarn/src/test/scala/org/apache/spark/deploy/yarn/ContainerPlacementStrategySuite.scala
---
@@ -0,0 +1,133 @@
+/*
+ * Licensed to the Apache
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/6394#discussion_r35151299
--- Diff:
yarn/src/main/scala/org/apache/spark/deploy/yarn/ContainerPlacementStrategy.scala
---
@@ -0,0 +1,196 @@
+/*
+ * Licensed to the Apache
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/6394#discussion_r35151397
--- Diff:
yarn/src/main/scala/org/apache/spark/deploy/yarn/ContainerPlacementStrategy.scala
---
@@ -0,0 +1,196 @@
+/*
+ * Licensed to the Apache
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/6394#discussion_r35152686
--- Diff:
yarn/src/main/scala/org/apache/spark/deploy/yarn/ContainerPlacementStrategy.scala
---
@@ -0,0 +1,196 @@
+/*
+ * Licensed to the Apache
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/6394#discussion_r35152962
--- Diff:
yarn/src/main/scala/org/apache/spark/deploy/yarn/ContainerPlacementStrategy.scala
---
@@ -0,0 +1,196 @@
+/*
+ * Licensed to the Apache
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/6394#discussion_r35148070
--- Diff:
core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ---
@@ -637,6 +662,24 @@ private[spark] class ExecutorAllocationManager
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/6394#discussion_r35148227
--- Diff:
core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ---
@@ -295,7 +295,9 @@ private[spark] class ExecutorAllocationManager
Github user sryza commented on the pull request:
https://github.com/apache/spark/pull/7278#issuecomment-123123557
jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user sryza commented on the pull request:
https://github.com/apache/spark/pull/7430#issuecomment-122346380
LGTM modulo a small comment
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/7430#discussion_r34910046
--- Diff: python/pyspark/mllib/stat/_statistics.py ---
@@ -238,6 +242,60 @@ def chiSqTest(observed, expected=None):
jmodel = callMLlibFunc
1 - 100 of 1255 matches
Mail list logo
