Github user yijieshen commented on the pull request:
https://github.com/apache/spark/pull/7491#issuecomment-122517024
why doesn't jenkins like me :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user yijieshen opened a pull request:
https://github.com/apache/spark/pull/7491
[SPARK-9055][SQL] WidenTypes should also support Intersect and Except
JIRA: https://issues.apache.org/jira/browse/SPARK-9055
cc @rxin
You can merge this pull request into a Git
Github user yijieshen commented on the pull request:
https://github.com/apache/spark/pull/7365#issuecomment-122515973
@cloud-fan , thanks for reviewing, will resolve the comment soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user yijieshen commented on the pull request:
https://github.com/apache/spark/pull/7488#issuecomment-122550015
LGTM, tried this locally and fix the `CastSuite` test failure due to #7353
, hope to be merged ASAP.
---
If your project is set up for it, you can reply
Github user yijieshen commented on a diff in the pull request:
https://github.com/apache/spark/pull/7365#discussion_r34948044
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -422,47 +422,487 @@ case class Cast(child: Expression
Github user yijieshen commented on the pull request:
https://github.com/apache/spark/pull/7194#issuecomment-122550741
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user yijieshen commented on the pull request:
https://github.com/apache/spark/pull/7365#issuecomment-122618131
@rxin , Since #7488 is merged, can we trigger the test now?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user yijieshen commented on the pull request:
https://github.com/apache/spark/pull/7194#issuecomment-122617593
@JoshRosen , Get it, thanks for explanation.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user yijieshen opened a pull request:
https://github.com/apache/spark/pull/7464
[SPARK-9080][SQL] add isNaN predicate expression
JIRA: https://issues.apache.org/jira/browse/SPARK-9080
You can merge this pull request into a Git repository by running:
$ git pull https
Github user yijieshen commented on the pull request:
https://github.com/apache/spark/pull/7451#issuecomment-122235588
rebase the code to resolve merge conflicts.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user yijieshen commented on the pull request:
https://github.com/apache/spark/pull/7451#issuecomment-122376404
yes, I've resolved it locally, push here again in a minute.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user yijieshen commented on the pull request:
https://github.com/apache/spark/pull/7342#issuecomment-122036783
@yhuai, Thanks for the step by step guide, really appreciate it.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user yijieshen commented on a diff in the pull request:
https://github.com/apache/spark/pull/7451#discussion_r34824223
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/math.scala
---
@@ -510,16 +484,11 @@ case class Logarithm(left: Expression
Github user yijieshen commented on a diff in the pull request:
https://github.com/apache/spark/pull/7451#discussion_r34823962
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/math.scala
---
@@ -387,27 +370,18 @@ case class Atan2(left: Expression
Github user yijieshen commented on a diff in the pull request:
https://github.com/apache/spark/pull/7451#discussion_r34824466
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/MathExpressionsSuite.scala ---
@@ -70,11 +70,6 @@ class MathExpressionsSuite extends QueryTest
Github user yijieshen commented on the pull request:
https://github.com/apache/spark/pull/7451#issuecomment-122050099
cc @rxin
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user yijieshen commented on the pull request:
https://github.com/apache/spark/pull/7451#issuecomment-122048286
Log family semantic comparision:
Expression | Hive | Spark SQL
---|---|
ln(0.0) | NULL | -Infinity
ln(-1) | NULL | NaN
Github user yijieshen commented on the pull request:
https://github.com/apache/spark/pull/6835#issuecomment-122050559
close this and continue in #7451
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user yijieshen closed the pull request at:
https://github.com/apache/spark/pull/6835
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user yijieshen opened a pull request:
https://github.com/apache/spark/pull/7451
[SPARK-8280][SPARK-8281][SQL]Handle NaN, null and Infinity in math
JIRA:
https://issues.apache.org/jira/browse/SPARK-8280
https://issues.apache.org/jira/browse/SPARK-8281
You can merge
Github user yijieshen commented on the pull request:
https://github.com/apache/spark/pull/7451#issuecomment-122147392
So we behave like Hive except that we do support log base in between (0.0,
1.0], and add a unit test like `udf7`
---
If your project is set up for it, you can reply
Github user yijieshen commented on the pull request:
https://github.com/apache/spark/pull/6835#issuecomment-121798697
ok, will do soon
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user yijieshen commented on the pull request:
https://github.com/apache/spark/pull/6835#issuecomment-121797099
@rxin, do you mind my close this one and create a new pr for this? The base
code is quite outdated.
---
If your project is set up for it, you can reply to this email
Github user yijieshen commented on the pull request:
https://github.com/apache/spark/pull/7365#issuecomment-121535054
`CodeHolder` is removed in the latest commit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user yijieshen commented on a diff in the pull request:
https://github.com/apache/spark/pull/6938#discussion_r34649311
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/MathFunctionsSuite.scala
---
@@ -336,4 +338,46 @@ class MathFunctionsSuite
Github user yijieshen commented on a diff in the pull request:
https://github.com/apache/spark/pull/6938#discussion_r34650013
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/MathFunctionsSuite.scala
---
@@ -336,4 +338,46 @@ class MathFunctionsSuite
Github user yijieshen commented on a diff in the pull request:
https://github.com/apache/spark/pull/7365#discussion_r34743636
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -371,7 +371,7 @@ case class Cast(child: Expression
Github user yijieshen commented on a diff in the pull request:
https://github.com/apache/spark/pull/7342#discussion_r34557250
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/sources/rules.scala
---
@@ -119,6 +120,10 @@ private[sql] case class PreWriteCheck(catalog:
Catalog
Github user yijieshen commented on the pull request:
https://github.com/apache/spark/pull/7365#issuecomment-121135059
@davies , thanks for the tip, it's just what I need to check any
unconscious situations. :)
@davies @rxin, the pr is almost done for the current implementation, I
Github user yijieshen commented on a diff in the pull request:
https://github.com/apache/spark/pull/7365#discussion_r34538299
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -421,48 +421,515 @@ case class Cast(child: Expression
Github user yijieshen commented on a diff in the pull request:
https://github.com/apache/spark/pull/7365#discussion_r34538094
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -421,48 +421,515 @@ case class Cast(child: Expression
GitHub user yijieshen opened a pull request:
https://github.com/apache/spark/pull/7365
[SPARK-8935][WIP] Implement code generation for all casts
JIRA: https://issues.apache.org/jira/browse/SPARK-8935
You can merge this pull request into a Git repository by running:
$ git pull
Github user yijieshen commented on the pull request:
https://github.com/apache/spark/pull/7365#issuecomment-120834801
Not ready to be reviewed, just want to trigger test first.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user yijieshen commented on a diff in the pull request:
https://github.com/apache/spark/pull/7342#discussion_r34430902
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/sources/rules.scala
---
@@ -119,6 +120,10 @@ private[sql] case class PreWriteCheck(catalog:
Catalog
Github user yijieshen commented on the pull request:
https://github.com/apache/spark/pull/7342#issuecomment-120739848
thanks, I would update my implementation :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user yijieshen commented on a diff in the pull request:
https://github.com/apache/spark/pull/6938#discussion_r34423767
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/math.scala
---
@@ -520,3 +522,202 @@ case class Logarithm(left: Expression
Github user yijieshen commented on a diff in the pull request:
https://github.com/apache/spark/pull/6938#discussion_r34424137
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/math.scala
---
@@ -520,3 +522,202 @@ case class Logarithm(left: Expression
Github user yijieshen commented on a diff in the pull request:
https://github.com/apache/spark/pull/6938#discussion_r34423168
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/math.scala
---
@@ -520,3 +522,202 @@ case class Logarithm(left: Expression
Github user yijieshen commented on the pull request:
https://github.com/apache/spark/pull/6938#issuecomment-120623499
cc @rxin
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user yijieshen commented on the pull request:
https://github.com/apache/spark/pull/7342#issuecomment-120251015
@yhuai it seems not possible to do checking in `CheckAnalysis` because
LogicalRelation or LogicalRDD is not accessible there. Any ideas?
---
If your project is set
GitHub user yijieshen opened a pull request:
https://github.com/apache/spark/pull/7342
[SPARK-6941][SQL] Provide a better error message to when inserting into RDD
based table
JIRA: https://issues.apache.org/jira/browse/SPARK-6941
You can merge this pull request into a Git
Github user yijieshen commented on a diff in the pull request:
https://github.com/apache/spark/pull/6938#discussion_r34408758
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/math.scala
---
@@ -520,3 +522,127 @@ case class Logarithm(left: Expression
Github user yijieshen commented on the pull request:
https://github.com/apache/spark/pull/6938#issuecomment-120434915
@rxin
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user yijieshen commented on the pull request:
https://github.com/apache/spark/pull/7342#issuecomment-120435667
@rxin, do you mind also reviewing this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user yijieshen commented on the pull request:
https://github.com/apache/spark/pull/6938#issuecomment-120435205
@rxin, do you mind reviewing this again?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user yijieshen commented on the pull request:
https://github.com/apache/spark/pull/6938#issuecomment-120431944
seems test failure not related to the PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user yijieshen commented on the pull request:
https://github.com/apache/spark/pull/6938#issuecomment-120431850
Jenkins retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user yijieshen commented on a diff in the pull request:
https://github.com/apache/spark/pull/6938#discussion_r34225665
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/math.scala
---
@@ -600,3 +604,146 @@ case class Logarithm(left: Expression
Github user yijieshen commented on a diff in the pull request:
https://github.com/apache/spark/pull/7283#discussion_r34136638
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -199,23 +199,23 @@ case class Cast(child: Expression
Github user yijieshen commented on the pull request:
https://github.com/apache/spark/pull/7283#issuecomment-119504924
retest it please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user yijieshen commented on the pull request:
https://github.com/apache/spark/pull/7283#issuecomment-119510169
Seems Jenkins not responding for the moment?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user yijieshen commented on a diff in the pull request:
https://github.com/apache/spark/pull/7283#discussion_r34175586
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -199,23 +199,23 @@ case class Cast(child: Expression
Github user yijieshen commented on the pull request:
https://github.com/apache/spark/pull/7283#issuecomment-119677631
@rxin, mind reviewing this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user yijieshen opened a pull request:
https://github.com/apache/spark/pull/7283
[SPARK-8866][SQL][WIP] use 1us precision for timestamp type
JIRA: https://issues.apache.org/jira/browse/SPARK-8866
You can merge this pull request into a Git repository by running:
$ git
Github user yijieshen commented on the pull request:
https://github.com/apache/spark/pull/7283#issuecomment-119801686
@davies @marmbrus, just update the test to a number without rounding error
---
If your project is set up for it, you can reply to this email and have your
reply
Github user yijieshen commented on a diff in the pull request:
https://github.com/apache/spark/pull/6938#discussion_r34224259
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/math.scala
---
@@ -600,3 +604,146 @@ case class Logarithm(left: Expression
Github user yijieshen commented on a diff in the pull request:
https://github.com/apache/spark/pull/7283#discussion_r34212676
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -199,23 +199,23 @@ case class Cast(child: Expression
Github user yijieshen commented on a diff in the pull request:
https://github.com/apache/spark/pull/6938#discussion_r34225366
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/MathExpressionsSuite.scala ---
@@ -198,6 +198,15 @@ class MathExpressionsSuite extends QueryTest
Github user yijieshen commented on a diff in the pull request:
https://github.com/apache/spark/pull/6938#discussion_r34000276
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/math.scala
---
@@ -600,3 +604,146 @@ case class Logarithm(left: Expression
Github user yijieshen commented on a diff in the pull request:
https://github.com/apache/spark/pull/6938#discussion_r34000504
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/math.scala
---
@@ -600,3 +604,146 @@ case class Logarithm(left: Expression
Github user yijieshen commented on the pull request:
https://github.com/apache/spark/pull/7232#issuecomment-118736827
Tried this out locally and works fine. LGTM as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user yijieshen commented on the pull request:
https://github.com/apache/spark/pull/7232#issuecomment-118721775
Yep, just what I need :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user yijieshen commented on the pull request:
https://github.com/apache/spark/pull/6938#issuecomment-118473160
`DecimalType` comes with `precisionInfo` as constructor argument, is this
possible to represent Fixed precision decimal type here?
`udf_round_3` has test
Github user yijieshen commented on the pull request:
https://github.com/apache/spark/pull/6938#issuecomment-118484476
`DecimalType` is subclass of `AbstractDataType`, do not satisfy requirement
of `TypeCollection(private val types: Seq[DataType])`
---
If your project is set up
Github user yijieshen commented on the pull request:
https://github.com/apache/spark/pull/6938#issuecomment-118488908
udf_round_3 and expected output:
```
-- test for TINYINT
select round(-128), round(127), round(0) from src tablesample (1 rows);
-- test
Github user yijieshen commented on the pull request:
https://github.com/apache/spark/pull/6938#issuecomment-118488219
Hive's round:
Input Type | Output Type
---|-
Double | Double
Float | Float
Byte | Byte
Short | Short
Int
Github user yijieshen commented on the pull request:
https://github.com/apache/spark/pull/6874#issuecomment-118047750
@marmbrus , I have no idea whether we should put namedStruct in
`functions.py` as well as `functions.scala`, since @rxin thought `struct` is
powerful enough itself
Github user yijieshen commented on the pull request:
https://github.com/apache/spark/pull/6938#issuecomment-118215557
Jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user yijieshen commented on the pull request:
https://github.com/apache/spark/pull/6938#issuecomment-118232607
retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user yijieshen commented on the pull request:
https://github.com/apache/spark/pull/6938#issuecomment-118232589
seems test failure is not related to this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user yijieshen commented on a diff in the pull request:
https://github.com/apache/spark/pull/6938#discussion_r33840963
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/math.scala
---
@@ -526,3 +529,171 @@ case class Logarithm(left: Expression
Github user yijieshen commented on the pull request:
https://github.com/apache/spark/pull/6515#issuecomment-115561728
Ok, I will close it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user yijieshen closed the pull request at:
https://github.com/apache/spark/pull/6515
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user yijieshen commented on a diff in the pull request:
https://github.com/apache/spark/pull/6981#discussion_r33342835
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetime.scala
---
@@ -0,0 +1,375 @@
+/*
+ * Licensed
Github user yijieshen commented on a diff in the pull request:
https://github.com/apache/spark/pull/6981#discussion_r33342749
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetime.scala
---
@@ -0,0 +1,375 @@
+/*
+ * Licensed
Github user yijieshen commented on a diff in the pull request:
https://github.com/apache/spark/pull/6981#discussion_r33343329
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetime.scala
---
@@ -0,0 +1,375 @@
+/*
+ * Licensed
Github user yijieshen commented on a diff in the pull request:
https://github.com/apache/spark/pull/6981#discussion_r33343908
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetime.scala
---
@@ -0,0 +1,375 @@
+/*
+ * Licensed
Github user yijieshen commented on the pull request:
https://github.com/apache/spark/pull/6874#issuecomment-115592024
@marmbrus , I remove the previous wrong golden answer and generate a new
one during test.
---
If your project is set up for it, you can reply to this email and have
Github user yijieshen commented on a diff in the pull request:
https://github.com/apache/spark/pull/6981#discussion_r33344535
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetime.scala
---
@@ -0,0 +1,375 @@
+/*
+ * Licensed
Github user yijieshen commented on a diff in the pull request:
https://github.com/apache/spark/pull/6981#discussion_r33345042
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetime.scala
---
@@ -0,0 +1,375 @@
+/*
+ * Licensed
Github user yijieshen commented on a diff in the pull request:
https://github.com/apache/spark/pull/6874#discussion_r33121160
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -78,3 +77,46 @@ case class CreateStruct
Github user yijieshen commented on the pull request:
https://github.com/apache/spark/pull/6938#issuecomment-114827837
@cloud-fan , could you please also review this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user yijieshen commented on the pull request:
https://github.com/apache/spark/pull/6938#issuecomment-114827233
@chenghao-intel , refactored `eval` and moved type specific branching out.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user yijieshen commented on a diff in the pull request:
https://github.com/apache/spark/pull/6938#discussion_r33136569
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/math.scala
---
@@ -312,3 +315,90 @@ case class Logarithm(left: Expression
Github user yijieshen commented on the pull request:
https://github.com/apache/spark/pull/6515#issuecomment-114956452
Run this check would take about ten minutes on my laptop
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user yijieshen commented on a diff in the pull request:
https://github.com/apache/spark/pull/6938#discussion_r33053767
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/math.scala
---
@@ -312,3 +315,90 @@ case class Logarithm(left: Expression
Github user yijieshen commented on a diff in the pull request:
https://github.com/apache/spark/pull/6938#discussion_r33053426
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/math.scala
---
@@ -312,3 +315,90 @@ case class Logarithm(left: Expression
Github user yijieshen commented on a diff in the pull request:
https://github.com/apache/spark/pull/6836#discussion_r33056694
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/math.scala
---
@@ -255,3 +262,121 @@ case class Pow(left: Expression
Github user yijieshen commented on a diff in the pull request:
https://github.com/apache/spark/pull/6836#discussion_r33057274
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/math.scala
---
@@ -255,3 +262,121 @@ case class Pow(left: Expression
Github user yijieshen commented on a diff in the pull request:
https://github.com/apache/spark/pull/6938#discussion_r33054525
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/MathFunctionsSuite.scala
---
@@ -252,4 +254,33 @@ class MathFunctionsSuite
Github user yijieshen commented on a diff in the pull request:
https://github.com/apache/spark/pull/6836#discussion_r33056779
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/math.scala
---
@@ -255,3 +262,121 @@ case class Pow(left: Expression
Github user yijieshen commented on a diff in the pull request:
https://github.com/apache/spark/pull/6938#discussion_r33053982
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/math.scala
---
@@ -312,3 +315,90 @@ case class Logarithm(left: Expression
Github user yijieshen commented on a diff in the pull request:
https://github.com/apache/spark/pull/6836#discussion_r33056496
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/math.scala
---
@@ -255,3 +262,121 @@ case class Pow(left: Expression
Github user yijieshen commented on the pull request:
https://github.com/apache/spark/pull/6874#issuecomment-114562511
Jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user yijieshen commented on a diff in the pull request:
https://github.com/apache/spark/pull/6836#discussion_r33058013
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/math.scala
---
@@ -255,3 +262,121 @@ case class Pow(left: Expression
Github user yijieshen commented on a diff in the pull request:
https://github.com/apache/spark/pull/6836#discussion_r33058249
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/math.scala
---
@@ -255,3 +262,121 @@ case class Pow(left: Expression
Github user yijieshen commented on a diff in the pull request:
https://github.com/apache/spark/pull/6836#discussion_r33057896
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/math.scala
---
@@ -255,3 +262,121 @@ case class Pow(left: Expression
Github user yijieshen commented on the pull request:
https://github.com/apache/spark/pull/6874#issuecomment-114584363
@rxin, could you please review this and also trigger the test?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user yijieshen commented on the pull request:
https://github.com/apache/spark/pull/6938#issuecomment-114583557
@rxin @marmbrus, mind reviewing this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user yijieshen commented on a diff in the pull request:
https://github.com/apache/spark/pull/6874#discussion_r33113971
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -78,3 +77,50 @@ case class CreateStruct
1 - 100 of 184 matches
Mail list logo
