Github user HyukjinKwon closed the pull request at:
https://github.com/apache/spark/pull/15513
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r85624958
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/HyperLogLogPlusPlus.scala
---
@@ -47,10 +47,16 @@ import
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r85626188
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/generators.scala
---
@@ -102,8 +102,17 @@ case class
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r85626782
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
---
@@ -114,7 +118,11 @@ case class Not(child:
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r85626234
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala
---
@@ -631,7 +682,11 @@ case class CurrentDatabase()
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r85625713
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Max.scala
---
@@ -23,7 +23,11 @@ import
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r85626603
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/nullExpressions.scala
---
@@ -126,7 +155,17 @@ case class NullIf(left:
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r85625648
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -234,7 +259,16 @@ case class
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r85625439
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -28,7 +28,15 @@ import
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r85624910
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/First.scala
---
@@ -29,10 +29,16 @@ import
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r85625801
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala
---
@@ -531,7 +615,15 @@ case class Least(children:
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r85626037
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala
---
@@ -162,7 +172,15 @@ abstract class
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r85626369
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/nullExpressions.scala
---
@@ -88,7 +97,17 @@ case class
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r85625732
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Min.scala
---
@@ -23,7 +23,11 @@ import
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r85626278
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/nullExpressions.scala
---
@@ -34,9 +34,18 @@ import
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r85626558
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala
---
@@ -490,7 +521,15 @@ abstract class
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r85624830
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Count.scala
---
@@ -23,9 +23,17 @@ import
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r85625546
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -175,7 +192,15 @@ case class
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r85626365
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/nullExpressions.scala
---
@@ -106,7 +125,17 @@ case class IfNull(left:
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r85628048
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala
---
@@ -372,22 +372,29 @@ abstract class
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r85626702
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/nullExpressions.scala
---
@@ -261,7 +330,15 @@ case class NaNvl(left:
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r85625901
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala
---
@@ -24,7 +24,17 @@ import
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r85624768
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -114,8 +114,16 @@ object Cast {
/** Cast
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r85625485
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -82,7 +90,16 @@ case class
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r85625180
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Last.scala
---
@@ -29,7 +29,16 @@ import
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r85626717
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/nullExpressions.scala
---
@@ -282,7 +359,15 @@ case class IsNull(child:
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r85626871
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
---
@@ -409,7 +427,12 @@ object Equality {
}
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r85625786
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala
---
@@ -471,7 +547,15 @@ case class Pmod(left:
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r85626890
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
---
@@ -435,8 +458,15 @@ case class EqualTo(left:
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r85625172
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/collect.scala
---
@@ -86,7 +86,11 @@ abstract class Collect
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r85625758
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/collect.scala
---
@@ -106,10 +110,14 @@ case class
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r85626660
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/nullExpressions.scala
---
@@ -144,7 +183,20 @@ case class Nvl(left:
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r85628075
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala
---
@@ -401,22 +408,29 @@ case class
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r85627086
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -851,8 +993,16 @@ case class
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r85246919
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
---
@@ -251,7 +259,12 @@ case class InSet(child:
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r85221940
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
---
@@ -251,7 +259,12 @@ case class InSet(child:
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r85217860
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
---
@@ -435,8 +458,15 @@ case class EqualTo(left:
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r85217483
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/randomExpressions.scala
---
@@ -55,8 +55,20 @@ abstract class RDG
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r85214549
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/randomExpressions.scala
---
@@ -77,9 +89,21 @@ case class Rand(seed:
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r85209471
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -657,10 +777,22 @@ case class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r85184948
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/xml/xpath.scala
---
@@ -68,11 +76,21 @@ case class XPathBoolean(xml:
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r85184825
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/xml/xpath.scala
---
@@ -120,9 +168,19 @@ case class XPathFloat(xml:
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r85184742
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/xml/xpath.scala
---
@@ -107,9 +145,19 @@ case class XPathLong(xml:
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r85184264
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/xml/xpath.scala
---
@@ -94,9 +122,19 @@ case class XPathInt(xml:
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r85183882
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/xml/xpath.scala
---
@@ -56,8 +56,16 @@ abstract class XPathExtract
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r85111739
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala
---
@@ -25,7 +25,11 @@ import
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r85061116
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala
---
@@ -410,13 +418,21 @@ case class Lead(input:
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r85060624
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala
---
@@ -664,10 +690,12 @@ case class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r85060476
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala
---
@@ -664,10 +690,12 @@ case class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r85060090
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/xml/xpath.scala
---
@@ -150,8 +206,16 @@ case class XPathString(xml:
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r84867463
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala
---
@@ -25,7 +25,11 @@ import org.apache.spark.sql.types._
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r84867405
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/xml/xpath.scala
---
@@ -108,8 +140,16 @@ case class XPathLong(xml:
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r84867371
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/xml/xpath.scala
---
@@ -95,8 +119,16 @@ case class XPathInt(xml: Expression,
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r84831284
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/xml/xpath.scala
---
@@ -95,8 +119,16 @@ case class XPathInt(xml:
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r84831067
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/xml/xpath.scala
---
@@ -95,8 +119,16 @@ case class XPathInt(xml:
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r84830885
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -105,7 +113,15 @@ case class
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r84828020
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala
---
@@ -25,7 +25,11 @@ import
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r84824488
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -105,7 +113,15 @@ case class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r84824307
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -76,7 +76,15 @@ case class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r84824076
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala
---
@@ -24,7 +24,17 @@ import
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r84823563
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala
---
@@ -367,8 +428,18 @@ case class Remainder(left:
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r84823116
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala
---
@@ -25,7 +25,11 @@ import
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r84822854
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala
---
@@ -25,7 +25,11 @@ import
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r84821645
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala
---
@@ -410,13 +418,21 @@ case class Lead(input:
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r84821378
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala
---
@@ -664,10 +690,12 @@ case class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r84821301
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/xml/xpath.scala
---
@@ -108,8 +140,16 @@ case class XPathLong(xml:
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r84821075
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/xml/xpath.scala
---
@@ -108,8 +140,16 @@ case class XPathLong(xml:
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r84820966
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/xml/xpath.scala
---
@@ -95,8 +119,16 @@ case class XPathInt(xml:
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r84820380
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala
---
@@ -410,13 +418,21 @@ case class Lead(input:
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r84744810
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Covariance.scala
---
@@ -76,8 +76,14 @@ abstract class
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r84615985
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/bitwiseExpressions.scala
---
@@ -27,8 +27,16 @@ import
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r84615684
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/CallMethodViaReflection.scala
---
@@ -43,11 +43,20 @@ import
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r84615167
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Covariance.scala
---
@@ -76,8 +76,14 @@ abstract class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r84613013
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/CallMethodViaReflection.scala
---
@@ -43,11 +43,20 @@ import
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r84604637
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/ApproximatePercentile.scala
---
@@ -49,21 +49,29 @@ import
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r84604598
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/xml/xpath.scala
---
@@ -150,8 +206,16 @@ case class XPathString(xml:
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r84597837
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/ApproximatePercentile.scala
---
@@ -49,21 +49,29 @@ import
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r84597661
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala
---
@@ -692,9 +722,11 @@ case class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r84597610
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/xml/xpath.scala
---
@@ -150,8 +206,16 @@ case class XPathString(xml:
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r84597530
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala
---
@@ -970,9 +1270,19 @@ case class Round(child:
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r84591475
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
---
@@ -1455,50 +1455,59 @@ class DDLSuite extends QueryTest
Github user jodersky commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r84591482
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/functions.scala
---
@@ -125,7 +129,7 @@ case class DescribeFunctionCommand(
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r84590685
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/functions.scala
---
@@ -125,7 +129,7 @@ case class DescribeFunctionCommand(
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r84590609
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/CallMethodViaReflection.scala
---
@@ -43,11 +43,20 @@ import
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r84590562
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/functions.scala
---
@@ -125,7 +129,7 @@ case class DescribeFunctionCommand(
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r84583708
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/CallMethodViaReflection.scala
---
@@ -43,11 +43,20 @@ import
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r84582345
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/functions.scala
---
@@ -125,7 +129,7 @@ case class DescribeFunctionCommand(
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r84576139
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala
---
@@ -367,8 +410,16 @@ case class Remainder(left:
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r84574950
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -706,7 +842,16 @@ case class
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r84574163
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/xml/xpath.scala
---
@@ -150,8 +220,18 @@ case class XPathString(xml:
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r84574104
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
---
@@ -490,7 +525,12 @@ case class LessThan(left:
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r84573971
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala
---
@@ -384,71 +502,157 @@ case class Log2(child:
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r84573731
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala
---
@@ -286,7 +324,12 @@ case class Divide(left:
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r84573927
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala
---
@@ -159,28 +167,69 @@ case class Pi() extends
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r84573878
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -847,7 +1010,16 @@ case class
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r84574029
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala
---
@@ -603,8 +823,16 @@ case class Unhex(child:
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r84574107
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
---
@@ -518,7 +563,12 @@ case class GreaterThan(left:
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r84573696
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala
---
@@ -25,7 +25,11 @@ import org.apache.spark.sql.types._
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r84574135
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -986,7 +1155,14 @@ case class
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r84574050
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala
---
@@ -159,8 +183,15 @@ case class Sha1(child: Expression)
1 - 100 of 117 matches
Mail list logo
