Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20753
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/20753#discussion_r177631719
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -184,12 +217,21 @@ case class StaticInvoke(
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/20753#discussion_r177628991
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -188,8 +189,30 @@ case class StaticInvoke(
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/20753#discussion_r177480722
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -188,8 +189,30 @@ case class StaticInvoke(
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/20753#discussion_r177468352
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -188,8 +189,30 @@ case class StaticInvoke(
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/20753#discussion_r177413074
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -188,8 +189,30 @@ case class StaticInvoke(
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/20753#discussion_r177411749
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -188,8 +189,30 @@ case class StaticInvoke(
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20753#discussion_r173361869
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ObjectExpressionsSuite.scala
---
@@ -95,6 +162,21 @@ class
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/20753#discussion_r173361648
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -188,8 +189,30 @@ case class StaticInvoke(
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/20753#discussion_r173339081
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ObjectExpressionsSuite.scala
---
@@ -95,6 +162,21 @@ class
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20753#discussion_r173327074
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/CallMethodViaReflection.scala
---
@@ -127,6 +128,52 @@ object
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20753#discussion_r173326718
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -188,8 +189,30 @@ case class StaticInvoke(
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/20753#discussion_r173159210
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -188,8 +189,32 @@ case class StaticInvoke(
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/20753#discussion_r173158406
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ObjectExpressionsSuite.scala
---
@@ -71,6 +79,66 @@ class
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/20753#discussion_r173136700
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -133,8 +134,21 @@ case class StaticInvoke(
Github user rednaxelafx commented on a diff in the pull request:
https://github.com/apache/spark/pull/20753#discussion_r173075682
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -133,8 +134,21 @@ case class
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20753#discussion_r173064355
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -133,8 +134,21 @@ case class StaticInvoke(
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/20753#discussion_r172787347
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -133,8 +134,21 @@ case class StaticInvoke(
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20753#discussion_r172755611
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -133,8 +134,21 @@ case class StaticInvoke(
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20753#discussion_r172754548
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -133,8 +134,21 @@ case class StaticInvoke(
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/20753#discussion_r172722081
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -133,8 +134,21 @@ case class StaticInvoke(
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20753#discussion_r172718446
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -133,8 +134,21 @@ case class StaticInvoke(
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20753#discussion_r172717961
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -133,8 +134,21 @@ case class StaticInvoke(
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/20753#discussion_r172713356
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -133,8 +134,21 @@ case class StaticInvoke(
GitHub user kiszk opened a pull request:
https://github.com/apache/spark/pull/20753
[SPARK-23582][SQL] StaticInvoke should support interpreted execution
## What changes were proposed in this pull request?
This pr added interpreted execution for `StaticInvoke`.
##
25 matches
Mail list logo
